Re: [libvirt] [PATCH] qemu: Allow the user to specify vendor and product for disk

2012-11-08 Thread Martin Kletzander
On 11/08/2012 02:52 AM, Dave Allan wrote: On Thu, Nov 08, 2012 at 09:28:06AM +0800, Osier Yang wrote: On 2012年11月08日 05:04, Dave Allan wrote: On Wed, Nov 07, 2012 at 11:24:43PM +0800, Osier Yang wrote: On 2012年11月05日 21:34, Martin Kletzander wrote: On 11/05/2012 08:04 AM, Osier Yang wrote:

[libvirt] [PATCH 2/2] qemu: graphics support for simultaneous one of each sdl, vnc, spice

2012-11-08 Thread Alon Levy
--- src/qemu/qemu_command.c | 23 --- 1 file changed, 20 insertions(+), 3 deletions(-) diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c index f9e4d4d..fcdf60c 100644 --- a/src/qemu/qemu_command.c +++ b/src/qemu/qemu_command.c @@ -6186,9 +6186,26 @@

Re: [libvirt] [PATCH v13] support offline migration

2012-11-08 Thread Peter Krempa
On 11/08/12 04:29, li guang wrote: Hi, Jiri, Daniel Any comment on this patch? Please be patient. They both attend the KVM Forum conference so they won't be around until next week. Peter -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH] qemu: Allow migration to be cancelled at any phase

2012-11-08 Thread Michal Privoznik
On 07.11.2012 23:23, Jiri Denemark wrote: On Wed, Nov 07, 2012 at 12:03:39 +0100, Michal Privoznik wrote: Currently, if user calls virDomainAbortJob we just issue 'migrate_cancel' and hope for the best. However, if user calls the API in wrong phase when migration hasn't been started yet

Re: [libvirt] [PATCH] qemu: Allow the user to specify vendor and product for disk

2012-11-08 Thread Osier Yang
On 2012年11月08日 16:19, Martin Kletzander wrote: On 11/08/2012 02:52 AM, Dave Allan wrote: On Thu, Nov 08, 2012 at 09:28:06AM +0800, Osier Yang wrote: On 2012年11月08日 05:04, Dave Allan wrote: On Wed, Nov 07, 2012 at 11:24:43PM +0800, Osier Yang wrote: On 2012年11月05日 21:34, Martin Kletzander

Re: [libvirt] [PATCHv3] snapshot: qemu: Add support for external inactive snapshots

2012-11-08 Thread Peter Krempa
On 11/08/12 01:48, Eric Blake wrote: On 11/07/2012 04:06 PM, Peter Krempa wrote: This patch adds support for external disk snapshots of inactive domains. The snapshot is created by calling using qemu-img by calling: qemu-img create -f format_of_snapshot -o

Re: [libvirt] [PATCH] qemu: Allow migration to be cancelled at any phase

2012-11-08 Thread Jiri Denemark
On Thu, Nov 08, 2012 at 11:00:40 +0100, Michal Privoznik wrote: On 07.11.2012 23:23, Jiri Denemark wrote: AbortJob API was never a synchronous one and I don't think we need to change it. Not to mention that this code unlocks and locks vm without holding an extra reference to it. And even

Re: [libvirt] [PATCH] qemu: Allow migration to be cancelled at any phase

2012-11-08 Thread Michal Privoznik
On 08.11.2012 11:49, Jiri Denemark wrote: On Thu, Nov 08, 2012 at 11:00:40 +0100, Michal Privoznik wrote: On 07.11.2012 23:23, Jiri Denemark wrote: AbortJob API was never a synchronous one and I don't think we need to change it. Not to mention that this code unlocks and locks vm without

Re: [libvirt] [PATCH v13] support offline migration

2012-11-08 Thread Jiri Denemark
On Thu, Nov 08, 2012 at 11:29:39 +0800, li guang wrote: Hi, Jiri, Daniel Any comment on this patch? Hi, Isn't my review I sent less than a day after your v13 enough? See https://www.redhat.com/archives/libvir-list/2012-November/msg00294.html if you missed it for whatever reason. Jirka --

[libvirt] [PATCH] qemu: Fix function header formating of 2 functions

2012-11-08 Thread Peter Krempa
Headers of qemuDomainSnapshotLoad and qemuDomainNetsRestart were improperly formatted. --- Pushing under the trivial rule. --- src/qemu/qemu_driver.c | 15 +-- 1 file changed, 9 insertions(+), 6 deletions(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index

Re: [libvirt] dnsmasq supporting RA instead of radvd patch

2012-11-08 Thread Gene Czarcinski
On 11/07/2012 04:23 PM, Doug Goldstein wrote: On Wed, Nov 7, 2012 at 3:05 PM, Gene Czarcinski g...@czarc.net wrote: I have a working patch to have dnsmasq support RA instead of radvd. However, something has come up and it will be a week to ten days before I can get it in shape to submit. The

[libvirt] [PATCH] qemu: Fix domain ID numbering race condition

2012-11-08 Thread Peter Krempa
When the libvirt daemon is restarted it tries to reconnect to running qemu domains. Since commit d38897a5d4b1880e1998394b2a37bba979bbdff1 the re-connection code runs in separate threads. In the original implementation the maximum of domain ID's (that is used as an initializer for numbering guests

[libvirt] [PATCH v2] qemu: Allow migration to be cancelled at prepare phase

2012-11-08 Thread Michal Privoznik
Currently, if user calls virDomainAbortJob we just issue 'migrate_cancel' and hope for the best. However, if user calls the API in wrong phase when migration hasn't been started yet (perform phase) the cancel request is just ignored. With this patch, the request is remembered and as soon as

Re: [libvirt] [PATCH 1/2] qemu: refactor graphics code to not hardcode a single display

2012-11-08 Thread Daniel P. Berrange
On Thu, Nov 08, 2012 at 09:48:55AM +0100, Alon Levy wrote: The check for a single display remains so no new functionality is added. --- Concerning both patches, I've tested running with all three simultaneously (sdl+spice+vnc) and with spice+vnc, using a single qxl device.

Re: [libvirt] [PATCH 1/2] qemu: refactor graphics code to not hardcode a single display

2012-11-08 Thread Peter Krempa
On 11/08/12 15:04, Daniel P. Berrange wrote: On Thu, Nov 08, 2012 at 09:48:55AM +0100, Alon Levy wrote: The check for a single display remains so no new functionality is added. --- Concerning both patches, I've tested running with all three simultaneously (sdl+spice+vnc) and with spice+vnc,

[libvirt] [PATCH 2/2] AbortJob: Fix documentation

2012-11-08 Thread Michal Privoznik
This API was never synchronous and probably doesn't even need to be. --- I am sending this as a separate patch as regardless if my previous patch got accepted or not this one is still true. src/libvirt.c |3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git a/src/libvirt.c

Re: [libvirt] Expose virDomainGetAutostart through virsh?

2012-11-08 Thread Daniel P. Berrange
On Wed, Nov 07, 2012 at 11:32:22AM +0100, Peter Krempa wrote: On 11/07/12 11:04, Ruben Kerkhof wrote: Hi list, I'd like to check if a domain has autostart enabled. I do this now by looking if there's a symlink in /etc/libvirt/qemu/autostart, but it feels a bit hackish. Is this something

Re: [libvirt] [PATCH] virsh: add aliases 'boot', 'stop', and 'restart'

2012-11-08 Thread Daniel P. Berrange
On Mon, Nov 05, 2012 at 12:59:16PM -0700, Eric Blake wrote: https://bugzilla.redhat.com/show_bug.cgi?id=873344 suggested that the grouping 'boot', 'shutdown', 'reboot'; as well as the grouping 'start', 'stop', 'restart'; might be easier to remember than the current mix of 'start', 'shutdown',

Re: [libvirt] [PATCH 4/4] qemu: Build command line for ivshmem device

2012-11-08 Thread Daniel P. Berrange
On Wed, Nov 07, 2012 at 05:40:44PM +0800, Osier Yang wrote: Depends on whether source path is specified, the command line is built like: * 'path' is specified, with interrupts (/tmp/nahanni is the ivshmem server socket path) -chardev socket,path=/tmp/nahanni,id=nahanni

Re: [libvirt] [PATCH 1/4] docs: Add documents for memory device

2012-11-08 Thread Daniel P. Berrange
On Wed, Nov 07, 2012 at 05:40:41PM +0800, Osier Yang wrote: Considering there could be other memory related devices in future, this introduces a general device model, called memory device, instead of a specific device like ivshmem, currently only ivshmem is supported though. An example of

[libvirt] [PATCH 3/3] v6-7: Add support for DHCPv6

2012-11-08 Thread Gene Czarcinski
This support includes IPv6 dhcp-range= and dhcp-host= for one IPv6 subnetwork on one interface. The parameter tests have been updated to add some new DHCPv6 tests. Three new tests (6 files) were added. The xml format html documentation has been updated to reflect support for IPv6 DHCP. v6-7:

Re: [libvirt] [PATCH] virsh: add aliases 'boot', 'stop', and 'restart'

2012-11-08 Thread Daniel P. Berrange
On Tue, Nov 06, 2012 at 09:30:15AM +0100, Viktor Mihajlovski wrote: On 11/05/2012 08:59 PM, Eric Blake wrote: This patch documents both spellings. An alternative would be to leave the alternate spellings as hidden aliases (virsh has support for that), but still mention them in virsh.pod

Re: [libvirt] [PATCH 1/2] qemu: refactor graphics code to not hardcode a single display

2012-11-08 Thread Alon Levy
On Thu, Nov 08, 2012 at 09:48:55AM +0100, Alon Levy wrote: The check for a single display remains so no new functionality is added. --- Concerning both patches, I've tested running with all three simultaneously (sdl+spice+vnc) and with spice+vnc, using a single qxl device.

Re: [libvirt] Expose virDomainGetAutostart through virsh?

2012-11-08 Thread Peter Krempa
On 11/08/12 15:13, Daniel P. Berrange wrote: On Wed, Nov 07, 2012 at 11:32:22AM +0100, Peter Krempa wrote: On 11/07/12 11:04, Ruben Kerkhof wrote: Hi list, I'd like to check if a domain has autostart enabled. I do this now by looking if there's a symlink in /etc/libvirt/qemu/autostart, but it

Re: [libvirt] [PATCH v7 5/6] make /proc/meminfo isolate with host through fuse

2012-11-08 Thread Daniel P. Berrange
On Tue, Nov 06, 2012 at 09:00:36AM +, Richard W.M. Jones wrote: On Tue, Nov 06, 2012 at 02:07:21PM +0800, Gao feng wrote: +while (fgets(line, sizeof(line), statfd) != NULL) { I wonder if libvirt prefers the getline API instead of fgets? I don't think we have a documented policy for

Re: [libvirt] Expose virDomainGetAutostart through virsh?

2012-11-08 Thread Daniel P. Berrange
On Thu, Nov 08, 2012 at 03:41:12PM +0100, Peter Krempa wrote: On 11/08/12 15:13, Daniel P. Berrange wrote: On Wed, Nov 07, 2012 at 11:32:22AM +0100, Peter Krempa wrote: On 11/07/12 11:04, Ruben Kerkhof wrote: Hi list, I'd like to check if a domain has autostart enabled. I do this now by

Re: [libvirt] [PATCH v13] support offline migration

2012-11-08 Thread Daniel P. Berrange
On Thu, Nov 08, 2012 at 11:29:39AM +0800, li guang wrote: Hi, Jiri, Daniel Any comment on this patch? Looks like you fixed all the issues I've brought up now. I'll defer to Jiri for review of all the other issues he identified. Daniel -- |: http://berrange.com -o-

Re: [libvirt] [PATCH 0/3] dnsmasq conf-file, interface=, and DHCPv6

2012-11-08 Thread Gene Czarcinski
On 11/06/2012 11:11 AM, Gene Czarcinski wrote: v6-6: put dnsmasq parameters into a file v6-6: add dnsmasq interface= parameter v6-6: Add support for DHCPv6 I will be adding some additional patches which will in addition to the patches already submitted. I am attempting to keep them

[libvirt] [PATCH 1/2] S390: Add SCLP console front end support

2012-11-08 Thread Viktor Mihajlovski
From: J.B. Joret j...@linux.vnet.ibm.com The SCLP console is the native console type for s390 and is preferred over the virtio console as it doesn't require special drivers and is more efficient. Recent versions of QEMU come with SCLP support which is hereby enabled. The new target types 'sclp'

[libvirt] [PATCH 2/2] S390: Enable SCLP Console in QEMU driver

2012-11-08 Thread Viktor Mihajlovski
From: J.B. Joret j...@linux.vnet.ibm.com This is the QEMU backend code for the SCLP console support. It includes SCLP capability detection, QEMU command line generation and a test case. Signed-off-by: J.B. Joret j...@linux.vnet.ibm.com Signed-off-by: Viktor Mihajlovski

[libvirt] [PATCH 0/2] S390: Adding support for SCLP Console

2012-11-08 Thread Viktor Mihajlovski
The S390 architecture comes with a native console type (SCLP console) which is now also supported by current QEMU. This series is enabling libvirt to configure S390 domains with SCLP consoles. The domain XML has to be extended for the new console target types 'sclp' and 'sclplm' (line mode =

Re: [libvirt] dnsmasq supporting RA instead of radvd patch

2012-11-08 Thread Doug Goldstein
On Thu, Nov 8, 2012 at 7:08 AM, Gene Czarcinski g...@czarc.net wrote: On 11/07/2012 04:23 PM, Doug Goldstein wrote: On Wed, Nov 7, 2012 at 3:05 PM, Gene Czarcinski g...@czarc.net wrote: I have a working patch to have dnsmasq support RA instead of radvd. However, something has come up and

[libvirt] [PATCH] storage: allow metadata preallocation when creating qcow2 images

2012-11-08 Thread Ján Tomko
Currently the 'allocation' element is not used when creating new images with qemu-img. This patch interprets a non-zero value as a request to preallocate metadata when a qcow2 image is created. Bug: https://bugzilla.redhat.com/show_bug.cgi?id=684793 --- src/storage/storage_backend.c | 19

Re: [libvirt] [PATCH] virsh: add aliases 'boot', 'stop', and 'restart'

2012-11-08 Thread Viktor Mihajlovski
On 11/08/2012 03:25 PM, Daniel P. Berrange wrote: The 'shutdown' and 'reboot' commands use terms that apply to the operating system, because they *are* controlling the operating system, not the virtual machine. They directly result in the guest OS commands 'shutdown' and 'reboot' being

Re: [libvirt] [PATCH] virsh: add aliases 'boot', 'stop', and 'restart'

2012-11-08 Thread James B. Byrne
On Thu, November 8, 2012 09:24, Daniel P. Berrange wrote: NACK to this patch. I think the current command names are good. Creating duplicates will make life worse. First, it creates divergance from the similarly named commands for networks, storage and other objects. It also means scripts

Re: [libvirt] [PATCH] virsh: add aliases 'boot', 'stop', and 'restart'

2012-11-08 Thread Dave Allan
On Thu, Nov 08, 2012 at 03:24:07PM +0100, Daniel P. Berrange wrote: On Mon, Nov 05, 2012 at 12:59:16PM -0700, Eric Blake wrote: https://bugzilla.redhat.com/show_bug.cgi?id=873344 suggested that the grouping 'boot', 'shutdown', 'reboot'; as well as the grouping 'start', 'stop', 'restart';

Re: [libvirt] [PATCH 4/4] qemu: Build command line for ivshmem device

2012-11-08 Thread Osier Yang
On 2012年11月08日 22:18, Daniel P. Berrange wrote: On Wed, Nov 07, 2012 at 05:40:44PM +0800, Osier Yang wrote: Depends on whether source path is specified, the command line is built like: * 'path' is specified, with interrupts (/tmp/nahanni is the ivshmem server socket path)

Re: [libvirt] [PATCH] virsh: add aliases 'boot', 'stop', and 'restart'

2012-11-08 Thread Eric Blake
On 11/08/2012 07:24 AM, Daniel P. Berrange wrote: On Mon, Nov 05, 2012 at 12:59:16PM -0700, Eric Blake wrote: https://bugzilla.redhat.com/show_bug.cgi?id=873344 suggested that the grouping 'boot', 'shutdown', 'reboot'; as well as the grouping 'start', 'stop', 'restart'; might be easier to

Re: [libvirt] [PATCH 1/4] docs: Add documents for memory device

2012-11-08 Thread Osier Yang
On 2012年11月08日 22:16, Daniel P. Berrange wrote: On Wed, Nov 07, 2012 at 05:40:41PM +0800, Osier Yang wrote: Considering there could be other memory related devices in future, this introduces a general device model, called memory device, instead of a specific device like ivshmem, currently only

Re: [libvirt] [PATCH] virsh: add aliases 'boot', 'stop', and 'restart'

2012-11-08 Thread Daniel P. Berrange
On Thu, Nov 08, 2012 at 10:51:14AM -0500, Dave Allan wrote: On Thu, Nov 08, 2012 at 03:24:07PM +0100, Daniel P. Berrange wrote: On Mon, Nov 05, 2012 at 12:59:16PM -0700, Eric Blake wrote: https://bugzilla.redhat.com/show_bug.cgi?id=873344 suggested that the grouping 'boot', 'shutdown',

Re: [libvirt] [PATCH] virsh: add aliases 'boot', 'stop', and 'restart'

2012-11-08 Thread Daniel P. Berrange
On Thu, Nov 08, 2012 at 10:30:55AM -0500, James B. Byrne wrote: On Thu, November 8, 2012 09:24, Daniel P. Berrange wrote: NACK to this patch. I think the current command names are good. Creating duplicates will make life worse. First, it creates divergance from the similarly named

Re: [libvirt] [PATCH] virsh: add aliases 'boot', 'stop', and 'restart'

2012-11-08 Thread Daniel P. Berrange
On Thu, Nov 08, 2012 at 08:55:27AM -0700, Eric Blake wrote: On 11/08/2012 07:24 AM, Daniel P. Berrange wrote: On Mon, Nov 05, 2012 at 12:59:16PM -0700, Eric Blake wrote: https://bugzilla.redhat.com/show_bug.cgi?id=873344 suggested that the grouping 'boot', 'shutdown', 'reboot'; as well as

Re: [libvirt] [PATCH 2/2] AbortJob: Fix documentation

2012-11-08 Thread Eric Blake
On 11/08/2012 07:14 AM, Michal Privoznik wrote: This API was never synchronous and probably doesn't even need to be. --- I am sending this as a separate patch as regardless if my previous patch got accepted or not this one is still true. ACK. Note however that virDomainBlockJobAbort()

Re: [libvirt] [PATCH] storage: allow metadata preallocation when creating qcow2 images

2012-11-08 Thread Daniel P. Berrange
On Thu, Nov 08, 2012 at 04:24:51PM +0100, Ján Tomko wrote: Currently the 'allocation' element is not used when creating new images with qemu-img. This patch interprets a non-zero value as a request to preallocate metadata when a qcow2 image is created. Bug:

Re: [libvirt] [PATCH] qemu: Fix domain ID numbering race condition

2012-11-08 Thread Eric Blake
On 11/08/2012 06:09 AM, Peter Krempa wrote: When the libvirt daemon is restarted it tries to reconnect to running qemu domains. Since commit d38897a5d4b1880e1998394b2a37bba979bbdff1 the re-connection code runs in separate threads. In the original implementation the maximum of domain ID's (that

Re: [libvirt] [PATCH] virsh: add aliases 'boot', 'stop', and 'restart'

2012-11-08 Thread Laine Stump
On 11/08/2012 11:24 AM, Daniel P. Berrange wrote: On Thu, Nov 08, 2012 at 10:51:14AM -0500, Dave Allan wrote: On Thu, Nov 08, 2012 at 03:24:07PM +0100, Daniel P. Berrange wrote: On Mon, Nov 05, 2012 at 12:59:16PM -0700, Eric Blake wrote: https://bugzilla.redhat.com/show_bug.cgi?id=873344

[libvirt] [PATCH] net: update default.xml to match creation by libvirt

2012-11-08 Thread Eric Blake
I noticed that after a fresh install, the file /etc/libvirt/qemu/networks/default.xml lacked the usual header inserted by modern 'virsh net-edit'; and traced it to the fact that libvirt.spec installs this file by copying a template rather than using libvirt API. We might as well make our template

[libvirt] [PATCH] v1: get, parse, and save dnsmasq version id

2012-11-08 Thread Gene Czarcinski
Use dnsmasq --version to obtain dnsmasq's version id and save the major/minor values. This is a separate patch since other patches will depend on it. --- src/conf/network_conf.h | 2 ++ src/network/bridge_driver.c | 35 +-- 2 files changed, 35 insertions(+),

[libvirt] [PATCH] v1: use dnsmasq instead of radvd to handle RA service

2012-11-08 Thread Gene Czarcinski
This patch tests the version of dnsmasq. If (major 2) or ((major==2) and (minor = 63)), then use dnsmasq. Otherwise, use radvd to provide the RA service. --- src/conf/network_conf.h| 1 + src/network/bridge_driver.c| 36

Re: [libvirt] dnsmasq supporting RA instead of radvd patch

2012-11-08 Thread Laine Stump
On 11/07/2012 04:16 PM, Eric Blake wrote: On 11/07/2012 02:05 PM, Gene Czarcinski wrote: As I was doing this, I also looked through the libvirt.spec file. My, what a wonderful example of wizardly that is. Anyway, I thought some updates may be in ortder: - increase the minimum version for

Re: [libvirt] [PATCH] net: update default.xml to match creation by libvirt

2012-11-08 Thread Laine Stump
On 11/08/2012 01:06 PM, Eric Blake wrote: I noticed that after a fresh install, the file /etc/libvirt/qemu/networks/default.xml lacked the usual header inserted by modern 'virsh net-edit'; and traced it to the fact that libvirt.spec installs this file by copying a template rather than using

Re: [libvirt] dnsmasq supporting RA instead of radvd patch

2012-11-08 Thread Eric Blake
On 11/08/2012 08:26 AM, Doug Goldstein wrote: I'm still not thrilled that you're pushing forward with requiring 2.63 + a few patches backported from 2.64 into 2.63 and only checking against 2.63. My point is if you're going to add a check for 2.63 but really require 2.63 + 3 patches that

Re: [libvirt] [PATCH] net: update default.xml to match creation by libvirt

2012-11-08 Thread Laine Stump
On 11/08/2012 01:51 PM, Laine Stump wrote: On 11/08/2012 01:06 PM, Eric Blake wrote: I noticed that after a fresh install, the file /etc/libvirt/qemu/networks/default.xml lacked the usual header inserted by modern 'virsh net-edit'; and traced it to the fact that libvirt.spec installs this

Re: [libvirt] dnsmasq supporting RA instead of radvd patch

2012-11-08 Thread Laine Stump
On 11/08/2012 01:55 PM, Eric Blake wrote: On 11/08/2012 08:26 AM, Doug Goldstein wrote: I'm still not thrilled that you're pushing forward with requiring 2.63 + a few patches backported from 2.64 into 2.63 and only checking against 2.63. My point is if you're going to add a check for 2.63

Re: [libvirt] dnsmasq supporting RA instead of radvd patch

2012-11-08 Thread Gene Czarcinski
On 11/08/2012 01:55 PM, Eric Blake wrote: On 11/08/2012 08:26 AM, Doug Goldstein wrote: I'm still not thrilled that you're pushing forward with requiring 2.63 + a few patches backported from 2.64 into 2.63 and only checking against 2.63. My point is if you're going to add a check for 2.63 but

Re: [libvirt] Proposed: always allow packets internal to an interface

2012-11-08 Thread Laine Stump
On 11/07/2012 04:25 PM, Gene Czarcinski wrote: On 11/06/2012 11:23 AM, Gene Czarcinski wrote: ip6tables -I FORWARD 1 -i virbr18 -o virbr18 -j ACCEPT This one currently isn't getting added, because networkAddGeneralIp6tablesRules() returns immediately if there are no ipv6 addresses defined

Re: [libvirt] dnsmasq supporting RA instead of radvd patch

2012-11-08 Thread Laine Stump
On 11/08/2012 02:30 PM, Gene Czarcinski wrote: On 11/08/2012 01:55 PM, Eric Blake wrote: On 11/08/2012 08:26 AM, Doug Goldstein wrote: I'm still not thrilled that you're pushing forward with requiring 2.63 + a few patches backported from 2.64 into 2.63 and only checking against 2.63. My

[libvirt] [PATCH] Add NUMA memory and CPU thread siblings to capabilities

2012-11-08 Thread Dusty Mabe
This patch is a follow up to https://www.redhat.com/archives/libvir-list/2012-October/msg01382.html. Since that one hasn't been reviewed yet I combined that work with new work to add memory information to virsh capabilities output and am submitting them both in this patch. With this virsh

[libvirt] [PATCH] Add NUMA memory and CPU thread siblings to capabilities

2012-11-08 Thread Dusty Mabe
--- docs/schemas/capability.rng | 15 +++ src/conf/capabilities.c | 65 ++--- src/conf/capabilities.h | 7 +- src/nodeinfo.c| 155 +- src/test/test_driver.c|

Re: [libvirt] dnsmasq supporting RA instead of radvd patch

2012-11-08 Thread Gene Czarcinski
On 11/08/2012 02:59 PM, Laine Stump wrote: On 11/08/2012 02:30 PM, Gene Czarcinski wrote: On 11/08/2012 01:55 PM, Eric Blake wrote: On 11/08/2012 08:26 AM, Doug Goldstein wrote: I'm still not thrilled that you're pushing forward with requiring 2.63 + a few patches backported from 2.64 into

[libvirt] [PATCH 0/6] dnsmasq conf-file, DHCPv6, dnsmasq-RA updates

2012-11-08 Thread Gene Czarcinski
OK, here it is. There are a related set of patches in that they are mostly dependent and need to be applied in the order show.. The individual patch files explain what each one is. Note that patch file 0003 for DHCPv6 adds some test files. Note that patch file 0006 add a test for the dnsmasq

[libvirt] [PATCH 2/6] v6-6: add dnsmasq interface= parameter

2012-11-08 Thread Gene Czarcinski
This patch adds the interface= dnsmasq parameter to the dnsmasq conf-file. The relavant tests are updated. --- src/network/bridge_driver.c| 10 ++ tests/networkxml2argvdata/isolated-network.argv| 1 +

[libvirt] [PATCH 1/6] v6-6: put dnsmasq parameters into a file

2012-11-08 Thread Gene Czarcinski
This patch changes how parameters are passed to dnsmasq. Instead of being on the command line, the parameters are put into a file (one parameter per line) and a commandline --conf-file= specifies the location of the file. The file is located in the same directory as the leases file. ---

[libvirt] [PATCH 4/6] v1: get, parse, and save dnsmasq version id

2012-11-08 Thread Gene Czarcinski
Use dnsmasq --version to obtain dnsmasq's version id and save the major/minor values. This is a separate patch since other patches will depend on it. --- src/conf/network_conf.h | 2 ++ src/network/bridge_driver.c | 35 +-- 2 files changed, 35 insertions(+),

[libvirt] [PATCH 5/6] v1: use dnsmasq instead of radvd to handle RA service

2012-11-08 Thread Gene Czarcinski
This patch tests the version of dnsmasq. If (major 2) or ((major==2) and (minor = 63)), then use dnsmasq. Otherwise, use radvd to provide the RA service. --- src/conf/network_conf.h| 1 + src/network/bridge_driver.c| 36

[libvirt] [PATCH 6/6] v1: for DHCPv6, add dnsmasq version check

2012-11-08 Thread Gene Czarcinski
If dnsmasq version is = 2.64, then IPV6 dhcp-range and dhcp-host are proccessed/supported. Otherwise, error out with message that DHCPv6 range and host not supported by the installed dnsmasq version. --- src/network/bridge_driver.c | 15 ++- tests/networkxml2argvtest.c | 2 ++ 2

[libvirt] [PATCH 3/6] v6-7: Add support for DHCPv6

2012-11-08 Thread Gene Czarcinski
This support includes IPv6 dhcp-range= and dhcp-host= for one IPv6 subnetwork on one interface. The parameter tests have been updated to add some new DHCPv6 tests. Three new tests (6 files) were added. The xml format html documentation has been updated to reflect support for IPv6 DHCP. This

Re: [libvirt] Proposed: always allow packets internal to an interface

2012-11-08 Thread Gene Czarcinski
On 11/08/2012 02:41 PM, Laine Stump wrote: On 11/07/2012 04:25 PM, Gene Czarcinski wrote: On 11/06/2012 11:23 AM, Gene Czarcinski wrote: ip6tables -I FORWARD 1 -i virbr18 -o virbr18 -j ACCEPT This one currently isn't getting added, because networkAddGeneralIp6tablesRules() returns

Re: [libvirt] Proposed: always allow packets internal to an interface

2012-11-08 Thread Daniel P. Berrange
On Thu, Nov 08, 2012 at 02:41:29PM -0500, Laine Stump wrote: On 11/07/2012 04:25 PM, Gene Czarcinski wrote: IPv4 and IPv6 networks are suppose to have the same (more or less) functionality so why isn't this OK. Maintaining backward compatibility, both API and operational. In the past it

Re: [libvirt] [PATCH] storage: allow metadata preallocation when creating qcow2 images

2012-11-08 Thread Eric Blake
On 11/08/2012 09:28 AM, Daniel P. Berrange wrote: I've thought about doing it this way before, but I always felt it was a bit of a gross hack. It would be nice to keep the 'allocation' element as purely describing the data sector allocation. I was recently wondering if we should just add a

Re: [libvirt] [PATCH] virsh: add aliases 'boot', 'stop', and 'restart'

2012-11-08 Thread Jim Fehlig
Daniel P. Berrange wrote: On Mon, Nov 05, 2012 at 12:59:16PM -0700, Eric Blake wrote: https://bugzilla.redhat.com/show_bug.cgi?id=873344 suggested that the grouping 'boot', 'shutdown', 'reboot'; as well as the grouping 'start', 'stop', 'restart'; might be easier to remember than the

Re: [libvirt] Proposed: always allow packets internal to an interface

2012-11-08 Thread Gene Czarcinski
On 11/08/2012 04:44 PM, Daniel P. Berrange wrote: On Thu, Nov 08, 2012 at 02:41:29PM -0500, Laine Stump wrote: On 11/07/2012 04:25 PM, Gene Czarcinski wrote: IPv4 and IPv6 networks are suppose to have the same (more or less) functionality so why isn't this OK. Maintaining backward

Re: [libvirt] [PATCH 1/2] qemu: refactor graphics code to not hardcode a single display

2012-11-08 Thread Eric Blake
On 11/08/2012 07:04 AM, Daniel P. Berrange wrote: On Thu, Nov 08, 2012 at 09:48:55AM +0100, Alon Levy wrote: The check for a single display remains so no new functionality is added. --- Concerning both patches, I've tested running with all three simultaneously (sdl+spice+vnc) and with

[libvirt] [PATCH 1/2 RESEND] qemu: refactor graphics code to not hardcode a single display

2012-11-08 Thread Eric Blake
From: Alon Levy al...@redhat.com The check for a single display remains so no new functionality is added. --- No change to the patch itself, just the use of the --patience flag to make review much easier. src/qemu/qemu_command.c | 647 +---

Re: [libvirt] [PATCH 1/3] nodeinfo: Add check and workaround to guarantee valid cpu topologies

2012-11-08 Thread Eric Blake
On 11/07/2012 08:22 AM, Peter Krempa wrote: Lately there were a few reports of the output of the virsh nodeinfo command being inaccurate. This patch ties to avoid that by checking if s/ties/tries/ the topology actualy makes sense. If it doesn't we then report a s/actualy/actually/

Re: [libvirt] [PATCH 2/3] nodeinfotest: Add test data for 2 processor host with broken NUMA

2012-11-08 Thread Eric Blake
On 11/07/2012 08:22 AM, Peter Krempa wrote: This test data was gathered on an AMD MagnyCours machine that reports it has only one NUMA node although the hardware is consisting of 4. As duplicate core id's are ignored the reported topology was bogous. This should be fixed by the previous patch.

Re: [libvirt] [PATCH 3/3] nodeinfotest: Add test data from a AMD bulldozer machine.

2012-11-08 Thread Eric Blake
On 11/07/2012 08:22 AM, Peter Krempa wrote: The AMD Bulldozer architecture uses so called Clustered integer core modules that count both as threads and cores. This patch expects the cpu to be detected using the new fallback condition otherwise twice the number of processors would be detected.

Re: [libvirt] [PATCH 1/3] nodeinfo: Add check and workaround to guarantee valid cpu topologies

2012-11-08 Thread Peter Krempa
On 11/08/12 23:55, Eric Blake wrote: On 11/07/2012 08:22 AM, Peter Krempa wrote: Lately there were a few reports of the output of the virsh nodeinfo command being inaccurate. This patch ties to avoid that by checking if s/ties/tries/ the topology actualy makes sense. If it doesn't we then

Re: [libvirt] [PATCH] storage: fix broken backing chain

2012-11-08 Thread Eric Blake
On 11/07/2012 06:53 AM, Philipp Hahn wrote: 82507838 refactured the code to keep both the raw and canonicalized form s/refactured/refactored/ of the backingStore, which breaks badly when the storage pool contains a storage volume, which is missing its backing store file: # ./daemon/libvirtd

Re: [libvirt] Proposed: always allow packets internal to an interface

2012-11-08 Thread Gene Czarcinski
On 11/08/2012 05:41 PM, Gene Czarcinski wrote: The reult is a very private IPv6 network between the virtual guest systems. A bit of clarification on why I would want such a capability (and, in truth, I have it today but I wanted to make it more automatic and available to anyone else). Lets

Re: [libvirt] [PATCH] qemu: Fix domain ID numbering race condition

2012-11-08 Thread Peter Krempa
On 11/08/12 17:21, Eric Blake wrote: On 11/08/2012 06:09 AM, Peter Krempa wrote: When the libvirt daemon is restarted it tries to reconnect to running qemu domains. Since commit d38897a5d4b1880e1998394b2a37bba979bbdff1 the re-connection code runs in separate threads. In the original

Re: [libvirt] dnsmasq supporting RA instead of radvd patch

2012-11-08 Thread Jim Fehlig
Gene Czarcinski wrote: I have a working patch to have dnsmasq support RA instead of radvd. However, something has come up and it will be a week to ten days before I can get it in shape to submit. The current patch has three variables added to the _virNetworkObj structure: dnsmasqRA flag

Re: [libvirt] Expose virDomainGetAutostart through virsh?

2012-11-08 Thread Guido Günther
On Thu, Nov 08, 2012 at 03:42:49PM +0100, Daniel P. Berrange wrote: On Thu, Nov 08, 2012 at 03:41:12PM +0100, Peter Krempa wrote: On 11/08/12 15:13, Daniel P. Berrange wrote: On Wed, Nov 07, 2012 at 11:32:22AM +0100, Peter Krempa wrote: On 11/07/12 11:04, Ruben Kerkhof wrote: Hi list,

Re: [libvirt] Proposed: always allow packets internal to an interface

2012-11-08 Thread Laine Stump
On 11/08/2012 04:44 PM, Daniel P. Berrange wrote: On Thu, Nov 08, 2012 at 02:41:29PM -0500, Laine Stump wrote: On 11/07/2012 04:25 PM, Gene Czarcinski wrote: IPv4 and IPv6 networks are suppose to have the same (more or less) functionality so why isn't this OK. Maintaining backward

Re: [libvirt] Proposed: always allow packets internal to an interface

2012-11-08 Thread Gene Czarcinski
On 11/08/2012 09:01 PM, Laine Stump wrote: Hmm - would it maybe be okay to always add the ip6tables rule to allow ipv6 traffic between interfaces on the bridge, while still setting disable_ipv6=1 (unless there is an ip with an ipv6 address)? The guests could then do IPv6 among themselves if they

Re: [libvirt] [PATCH v3 1/2] helper of copy-storage-* features

2012-11-08 Thread li guang
Hi, Eric any comment on this patch? 在 2012-11-06二的 16:09 +0800,li guang写道: ping ... 在 2012-11-01四的 08:40 +0800,liguang写道: help to create disk images copy-storage-* required, try to do non-shared migration without bothering to create disk images at target by hand. consider this

Re: [libvirt] [PATCH v13] support offline migration

2012-11-08 Thread li guang
在 2012-11-09五的 08:44 +0800,li guang写道: diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index 978af57..6c2bf98 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -9796,7 +9796,7 @@ qemuDomainMigrateBegin3(virDomainPtr domain, asyncJob =

Re: [libvirt] [PATCH v3 2/2] init qemu_driver's qemuImgBinary field

2012-11-08 Thread li guang
Hi, Eric any comment on this patch? 在 2012-11-06二的 16:09 +0800,li guang写道: ping ... 在 2012-11-01四的 08:40 +0800,liguang写道: Signed-off-by: liguang lig.f...@cn.fujitsu.com --- src/qemu/qemu_domain.c |2 +- src/qemu/qemu_driver.c |3 +++ 2 files changed, 4 insertions(+), 1

Re: [libvirt] [PATCH v13] support offline migration

2012-11-08 Thread Eric Blake
On 11/08/2012 07:57 PM, li guang wrote: What if you want to offline migrate a domain that is currently running? I think it's better to first move qemuDomainCheckEjectableMedia down to qemuMigrationBegin in a separate patch and then just use the code from v12 (without using the offline label).

Re: [libvirt] [PATCH v13] support offline migration

2012-11-08 Thread li guang
在 2012-11-08四的 20:28 -0700,Eric Blake写道: On 11/08/2012 07:57 PM, li guang wrote: What if you want to offline migrate a domain that is currently running? I think it's better to first move qemuDomainCheckEjectableMedia down to qemuMigrationBegin in a separate patch and then just use the code

Re: [libvirt] [PATCH v13] support offline migration

2012-11-08 Thread Eric Blake
On 11/08/2012 08:54 PM, li guang wrote: 在 2012-11-08四的 20:28 -0700,Eric Blake写道: On 11/08/2012 07:57 PM, li guang wrote: What if you want to offline migrate a domain that is currently running? I think it's better to first move qemuDomainCheckEjectableMedia down to qemuMigrationBegin in a

Re: [libvirt] [PATCH v13] support offline migration

2012-11-08 Thread li guang
在 2012-11-08四的 21:06 -0700,Eric Blake写道: On 11/08/2012 08:54 PM, li guang wrote: 在 2012-11-08四的 20:28 -0700,Eric Blake写道: On 11/08/2012 07:57 PM, li guang wrote: What if you want to offline migrate a domain that is currently running? I think it's better to first move

[libvirt] [RFC PATCH 1/n] snapshot: add revert-and-create branching of external snapshots

2012-11-08 Thread Eric Blake
Right now, libvirt refuses to revert to the state at the time of an external snapshot, because doing so would reset things so that the next time the domain boots, we are using the backing file; but modifying the backing file invalidates all qcow2 files that are based on top of it. There are three

Re: [libvirt] [PATCH v13] support offline migration

2012-11-08 Thread Eric Blake
On 11/08/2012 09:31 PM, li guang wrote: seem flags was forgotten at qemuDomainMigratePrepare3, so any preparation for offline migration will be impossible, isn't it? do you mean I should change MigratePrepare functions to add flags as a parameter? Huh? qemuDomainMigratePrepare3 already has

Re: [libvirt] [PATCH v3 1/2] helper of copy-storage-* features

2012-11-08 Thread Eric Blake
On 10/31/2012 06:40 PM, liguang wrote: help to create disk images copy-storage-* required, try to do non-shared migration without bothering to create disk images at target by hand. consider this situation: 1. non-shared migration virsh migrate --copy-storage-all ... 2. migration fails

Re: [libvirt] [PATCH v13] support offline migration

2012-11-08 Thread li guang
在 2012-11-08四的 21:50 -0700,Eric Blake写道: On 11/08/2012 09:31 PM, li guang wrote: seem flags was forgotten at qemuDomainMigratePrepare3, so any preparation for offline migration will be impossible, isn't it? do you mean I should change MigratePrepare functions to add flags as a parameter?

Re: [libvirt] [PATCH v3 2/2] init qemu_driver's qemuImgBinary field

2012-11-08 Thread Eric Blake
On 10/31/2012 06:40 PM, liguang wrote: Signed-off-by: liguang lig.f...@cn.fujitsu.com --- src/qemu/qemu_domain.c |2 +- src/qemu/qemu_driver.c |3 +++ 2 files changed, 4 insertions(+), 1 deletions(-) diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c index

Re: [libvirt] [PATCH v3 1/2] helper of copy-storage-* features

2012-11-08 Thread li guang
在 2012-11-08四的 22:10 -0700,Eric Blake写道: On 10/31/2012 06:40 PM, liguang wrote: help to create disk images copy-storage-* required, try to do non-shared migration without bothering to create disk images at target by hand. consider this situation: 1. non-shared migration virsh

Re: [libvirt] Expose virDomainGetAutostart through virsh?

2012-11-08 Thread Daniel P. Berrange
On Fri, Nov 09, 2012 at 01:19:01AM +0100, Guido Günther wrote: On Thu, Nov 08, 2012 at 03:42:49PM +0100, Daniel P. Berrange wrote: On Thu, Nov 08, 2012 at 03:41:12PM +0100, Peter Krempa wrote: On 11/08/12 15:13, Daniel P. Berrange wrote: On Wed, Nov 07, 2012 at 11:32:22AM +0100, Peter