Re: [libvirt] [PATCH 0/9] Add ability to connect to LXC namespaces

2013-01-02 Thread Daniel P. Berrange
On Wed, Dec 26, 2012 at 10:43:56AM +0900, Kamezawa Hiroyuki wrote: (2012/12/22 2:08), Daniel P. Berrange wrote: This series introduces an LXC specific library libvirt-lxc.so which adds ability for a process to connect to the namespaces used by an LXC container from outside. It uses FD passing

Re: [libvirt] [PATCH 0/3] add pci-bridge device and address type

2013-01-02 Thread Daniel P. Berrange
On Wed, Dec 26, 2012 at 09:00:06AM +0800, liguang wrote: Now, it's unnecessary to arrange devices into multi-pci-bus, for example: sound model='ac97' address type='pci' domain='0x' bus='0x00' slot='0x04' function='0x0'/ /sound video model type='cirrus'

Re: [libvirt] [PATCH] qemu: Adapt to new log format

2013-01-02 Thread Daniel P. Berrange
On Sat, Dec 29, 2012 at 10:09:41AM +0100, Michal Privoznik wrote: Since 586502189edf9fd0f89a83de96717a2ea826fdb0 qemu commit, the log lines reporting chardev's path has changed from: $ ./x86_64-softmmu/qemu-system-x86_64 -serial pty -serial pty -monitor pty char device redirected to

Re: [libvirt] [PATCH] qemu: Adapt to new log format

2013-01-02 Thread Michal Privoznik
On 02.01.2013 11:25, Daniel P. Berrange wrote: On Sat, Dec 29, 2012 at 10:09:41AM +0100, Michal Privoznik wrote: Since 586502189edf9fd0f89a83de96717a2ea826fdb0 qemu commit, the log lines reporting chardev's path has changed from: $ ./x86_64-softmmu/qemu-system-x86_64 -serial pty -serial pty

[libvirt] [PATCH 0/6 v9] Unprivileged SG_IO support

2013-01-02 Thread Osier Yang
As a result of RFC [1], this implements the unprivleged SG_IO support. 1/6 and 2/6 are already acked. v8 - v9: * Just rebasing. v7 - v8: * Change the XML tag name from cdbfilter to sgio, and to leave enough room for future values, the values of sgio are filtered and unfiltered

[libvirt] [PATCH 3/6] docs: Add docs and rng schema for new XML tag sgio

2013-01-02 Thread Osier Yang
This introduces new XML tag sgio for disk, its valid values are filtered and unfiltered, setting it as filtered will set the disk's unpriv_sgio to 0, and unfiltered to set it as 1, which allows the unprivileged SG_IO commands. --- docs/formatdomain.html.in | 14 ++-

[libvirt] [PATCH 4/6] conf: Parse and format the new XML

2013-01-02 Thread Osier Yang
Like rawio, sgio is only allowed for block disk of device type lun. It doesn't default disk-sgio to filtered when parsing, as it won't be able to distinguish explicitly requested filtered and a default filtered in driver then. We have to error out for explicit request when the kernel doesn't

[libvirt] [PATCH 1/6] util: Prepare helpers for unpriv_sgio setting

2013-01-02 Thread Osier Yang
virGetDeviceID could be used across the sources, but it doesn't relate with this series, and could be done later. * src/util/virutil.h: (Declare virGetDeviceID, and vir{Get,Set}DeviceUnprivSGIO) * src/util/virutil.c: (Implement virGetDeviceID and

[libvirt] [PATCH 2/6] qemu: Add a hash table for the shared disks

2013-01-02 Thread Osier Yang
This introduces a hash table for qemu driver, to store the shared disk's info as (@major:minor, @ref_count). @ref_count is the number of domains which shares the disk. Since we only care about if the disk support unprivileged SG_IO commands, and the SG_IO commands only make sense for block disk,

[libvirt] [PATCH 6/6] qemu: Check if the shared disk's cdbfilter conflicts with others

2013-01-02 Thread Osier Yang
This prevents domain starting and disk attaching if the shared disk's setting conflicts with other active domain(s), E.g. A domain with sgio set as filtered, however, another active domain is using it set as unfiltered. --- src/qemu/qemu_driver.c |5 src/qemu/qemu_process.c | 53

[libvirt] [PATCH 5/6] qemu: set unpriv_sgio when starting domain and attaching disk

2013-01-02 Thread Osier Yang
This ignores the default filtered if unpriv_sgio is not supported by kernel, but for explicit request filtered, it error out for domain starting. --- src/libvirt_private.syms |1 + src/qemu/qemu_driver.c | 15 +-- src/qemu/qemu_process.c | 31 +++

Re: [libvirt] libvirtd segfault

2013-01-02 Thread Scott Sullivan
On 12/29/2012 04:09 AM, Michal Privoznik wrote: On 28.12.2012 20:23, Scott Sullivan wrote: snip/ I have just now received another SIGSEGV, with your patch applied. Here's the info from the GDB session: Detaching after fork from child process 11266. 2012-12-28 18:56:53.261+: 29943:

[libvirt] [PATCH] Remove the inexistent function in comments

2013-01-02 Thread Osier Yang
virNodeDeviceLookupByKey is inexistent. --- Pushed under trivial rule. --- include/libvirt/libvirt.h.in |7 +++ 1 files changed, 3 insertions(+), 4 deletions(-) diff --git a/include/libvirt/libvirt.h.in b/include/libvirt/libvirt.h.in index c6739d7..2de6835 100644 ---

Re: [libvirt] [PATCH] Remove the inexistent function in comments

2013-01-02 Thread Eric Blake
On 01/02/2013 07:43 AM, Osier Yang wrote: virNodeDeviceLookupByKey is inexistent. s/inexistent/nonexistent/ --- Pushed under trivial rule. Oh well, it needs a followup for grammar: --- include/libvirt/libvirt.h.in |7 +++ 1 files changed, 3 insertions(+), 4 deletions(-)

[libvirt] [PATCH] qemu: Don't parse log output when starting up a domain

2013-01-02 Thread Michal Privoznik
Despite our great effort we still parsed qemu log output. We wouldn't notice unless qemu changed the format of the logs slightly. Anyway, now we should gather all interesting knobs like pty paths from monitor. Moreover, since for historical reasons the first console can be just an alias to the

Re: [libvirt] [PATCH] Remove the inexistent function in comments

2013-01-02 Thread Osier Yang
On 2013年01月02日 23:04, Eric Blake wrote: On 01/02/2013 07:43 AM, Osier Yang wrote: virNodeDeviceLookupByKey is inexistent. s/inexistent/nonexistent/ --- Pushed under trivial rule. Oh well, it needs a followup for grammar: --- include/libvirt/libvirt.h.in |7 +++ 1 files

[libvirt] RFC: An embedded mode for QEMU/LXC drivers

2013-01-02 Thread Daniel P. Berrange
This is something I was thinking about a little over the christmas break. I've no intention of implementing this in the immediate future, but wanted to post it while it was fresh in my mind. Historically we have had 2 ways of using the stateful drivers like QEMU/LXC/UML/etc. - system mode -

[libvirt] [PATCHv2 1/5] api: Add API to tunnel a guest channel via stream

2013-01-02 Thread John Eckersberg
This patch adds a new API, virDomainOpenChannel, that uses streams to connect to a virtio channel on a guest. This creates a secure communication channel between a guest and a libvirt client. This behaves the same as virDomainOpenConsole, except on channels instead of console/serial/parallel

[libvirt] [PATCHv2 2/5] conf: Rename virconsole.* to virchrdev.*

2013-01-02 Thread John Eckersberg
This is just code motion, in preparation to rename identifiers to be less console-specific. --- po/POTFILES.in | 2 +- src/Makefile.am | 2 +- src/conf/virchrdev.c | 414 +++ src/conf/virchrdev.h | 36 +

[libvirt] [PATCHv2 3/5] conf: Rename console-specific identifiers to be more generic

2013-01-02 Thread John Eckersberg
The functionality provided in virchrdev.c (previously virconsole.c) is applicable to other types of character devices besides consoles, such as channels. This patch is just code motion, renaming things such as console or pty, instead using more general terms such as character device or device

[libvirt] [PATCHv2 5/5] qemu: Implement virDomainOpenChannel API

2013-01-02 Thread John Eckersberg
--- v2: correct version comment to 1.0.2 src/qemu/qemu_driver.c | 73 ++ 1 file changed, 73 insertions(+) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index 20e2001..cdbe30d 100644 --- a/src/qemu/qemu_driver.c +++

[libvirt] [PATCHv2 0/5] Add API to tunnel channels

2013-01-02 Thread John Eckersberg
This series enables the qemu driver to tunnel a virtio channel. This is useful for a remote session to communicate with a guest channel via the streaming API. This was originally fleshed out a while back in this thread: https://www.redhat.com/archives/libvir-list/2011-September/msg01049.html

[libvirt] [PATCHv2 4/5] conf: Add unix socket support to virChrdevOpen

2013-01-02 Thread John Eckersberg
This also changes the function signature to take a virDomainChrSourceDefPtr instead of just a path, since it needs to differentiate behavior based on source-type. --- src/conf/virchrdev.c | 38 +- src/conf/virchrdev.h | 5 +++-- src/qemu/qemu_driver.c | 2

[libvirt] [PATCH] maint: update to latest gnulib

2013-01-02 Thread Michal Privoznik
The update results in bootstrap being updated as well. --- .gnulib | 2 +- bootstrap | 15 --- 2 files changed, 9 insertions(+), 8 deletions(-) diff --git a/.gnulib b/.gnulib index d245e6d..964bbc2 16 --- a/.gnulib +++ b/.gnulib @@ -1 +1 @@ -Subproject commit

Re: [libvirt] [PATCH] maint: update to latest gnulib

2013-01-02 Thread Eric Blake
On 01/02/2013 08:39 AM, Michal Privoznik wrote: The update results in bootstrap being updated as well. --- .gnulib | 2 +- bootstrap | 15 --- 2 files changed, 9 insertions(+), 8 deletions(-) Phooey, when trying this, I see: configure.ac:126: warning: gl_INLINE is

[libvirt] [PATCH] maint: update to latest gnulib

2013-01-02 Thread Eric Blake
'make syntax-check' warned that gnulib's copyright is now out of date. * .gnulib: Update to latest, for copyright year bump. * gnulib/local/m4/ssize_t.m4.diff: Regenerate. * bootstrap: Synchronize from upstream. --- configure.ac:126: warning: gl_INLINE is m4_require'd but not m4_defun'd Turns

[libvirt] Build failed in Jenkins: libvirt-build #472

2013-01-02 Thread Jenkins CI
See http://honk.sigxcpu.org:8001/job/libvirt-build/472/changes Changes: [eblake] maint: update to latest gnulib -- [...truncated 5806 lines...] GENwchar.h GENwctype.h make all-am make[3]: Entering directory

Re: [libvirt] [PATCH] qemu: Don't parse log output when starting up a domain

2013-01-02 Thread Eric Blake
On 01/02/2013 08:23 AM, Michal Privoznik wrote: Despite our great effort we still parsed qemu log output. We wouldn't notice unless qemu changed the format of the logs slightly. Maybe mention that the upcoming qemu 1.4 does just that. Anyway, now we should gather all interesting knobs like

Re: [libvirt] Build failed in Jenkins: libvirt-build #472

2013-01-02 Thread Eric Blake
On 01/02/2013 10:29 AM, Jenkins CI wrote: See http://honk.sigxcpu.org:8001/job/libvirt-build/472/changes Changes: [eblake] maint: update to latest gnulib CCLD libvirt_security_manager.la CCLD libvirt.la ./.libs/libvirt_util.a(libvirt_util_la-virnetdevtap.o): In function

[libvirt] [PATCH] build: use autobuild module to make build logs nicer

2013-01-02 Thread Eric Blake
A recent build failure made me realize that we could usefully add a bit more information to configure output, for aid in analysis of failed builds. Pulling in the autobuild module merely adds these four lines to configure output: configure: autobuild project... libvirt configure: autobuild

Re: [libvirt] [PATCH] build: use autobuild module to make build logs nicer

2013-01-02 Thread Daniel P. Berrange
On Wed, Jan 02, 2013 at 11:26:18AM -0700, Eric Blake wrote: A recent build failure made me realize that we could usefully add a bit more information to configure output, for aid in analysis of failed builds. Pulling in the autobuild module merely adds these four lines to configure output:

Re: [libvirt] [PATCH] build: use autobuild module to make build logs nicer

2013-01-02 Thread Eric Blake
On 01/02/2013 11:39 AM, Daniel P. Berrange wrote: On Wed, Jan 02, 2013 at 11:26:18AM -0700, Eric Blake wrote: A recent build failure made me realize that we could usefully add a bit more information to configure output, for aid in analysis of failed builds. Pulling in the autobuild module

Re: [libvirt] Coverity scan

2013-01-02 Thread John Ferlan
On 12/20/2012 04:24 PM, Eric Blake wrote: On 12/20/2012 08:25 AM, John Ferlan wrote: First allow me to introduce myself - I'm John Ferlan a new Red Hat employee (3 weeks). I came from the closed world at HP where for the last 7 years I worked in a group developing/supporting HP's Integrity

Re: [libvirt] Build failed in Jenkins: libvirt-build #472

2013-01-02 Thread Guido Günther
Hi, On Wed, Jan 02, 2013 at 11:20:08AM -0700, Eric Blake wrote: On 01/02/2013 10:29 AM, Jenkins CI wrote: See http://honk.sigxcpu.org:8001/job/libvirt-build/472/changes Changes: [eblake] maint: update to latest gnulib CCLD libvirt_security_manager.la CCLD libvirt.la

[libvirt] where is config.log when debugging a failure reported by Jenkins

2013-01-02 Thread Eric Blake
Hello Jenkins folks, On the libvirt list, we came across a case where a broken commit was detected, but where the information available in the failure report was insufficient (for at least me) to reproduce the failure environment without asking more questions:

Re: [libvirt] Build failed in Jenkins: libvirt-build #472

2013-01-02 Thread Eric Blake
On 01/02/2013 01:14 PM, Guido Günther wrote: This is gcc 4.7.1 and eglibc 2.13. I upgraded to Debian Wheezy's current gcc 4.7.2 without any changes. I'm not able to reproduce it locally on a Debian sid system either. I also tried a clean bootstrap

Re: [libvirt] where is config.log when debugging a failure reported by Jenkins

2013-01-02 Thread Guido Günther
Hi Eric, On Wed, Jan 02, 2013 at 02:45:24PM -0700, Eric Blake wrote: Hello Jenkins folks, On the libvirt list, we came across a case where a broken commit was detected, but where the information available in the failure report was insufficient (for at least me) to reproduce the failure

Re: [libvirt] where is config.log when debugging a failure reported by Jenkins

2013-01-02 Thread Guido Günther
On Wed, Jan 02, 2013 at 11:12:31PM +0100, Guido Günther wrote: Hi Eric, On Wed, Jan 02, 2013 at 02:45:24PM -0700, Eric Blake wrote: Hello Jenkins folks, On the libvirt list, we came across a case where a broken commit was detected, but where the information available in the failure

[libvirt] [PATCHv2] build: use autobuild module to make build logs nicer

2013-01-02 Thread Eric Blake
A recent build failure made me realize that we could usefully add a bit more information to configure output, for aid in analysis of failed builds. Pulling in the autobuild module merely adds these four lines to configure output: configure: autobuild project... libvirt configure: autobuild

Re: [libvirt] Build failed in Jenkins: libvirt-build #472

2013-01-02 Thread Eric Blake
[adding gnulib in cc] On 01/02/2013 03:03 PM, Eric Blake wrote: On 01/02/2013 01:14 PM, Guido Günther wrote: This is gcc 4.7.1 and eglibc 2.13. I upgraded to Debian Wheezy's current gcc 4.7.2 without any changes. I'm not able to reproduce it locally on a Debian sid system either. I also

Re: [libvirt] [PATCH 1/6] util: Prepare helpers for unpriv_sgio setting

2013-01-02 Thread Eric Blake
On 01/02/2013 07:37 AM, Osier Yang wrote: virGetDeviceID could be used across the sources, but it doesn't relate with this series, and could be done later. * src/util/virutil.h: (Declare virGetDeviceID, and vir{Get,Set}DeviceUnprivSGIO) * src/util/virutil.c:

Re: [libvirt] RFC: An embedded mode for QEMU/LXC drivers

2013-01-02 Thread Richard W.M. Jones
On Wed, Jan 02, 2013 at 03:36:54PM +, Daniel P. Berrange wrote: This is something I was thinking about a little over the christmas break. I've no intention of implementing this in the immediate future, but wanted to post it while it was fresh in my mind. Historically we have had 2 ways

Re: [libvirt] [PATCH 0/3] add pci-bridge device and address type

2013-01-02 Thread li guang
在 2013-01-02三的 10:22 +,Daniel P. Berrange写道: On Wed, Dec 26, 2012 at 09:00:06AM +0800, liguang wrote: Now, it's unnecessary to arrange devices into multi-pci-bus, for example: sound model='ac97' address type='pci' domain='0x' bus='0x00' slot='0x04' function='0x0'/

Re: [libvirt] [RFC] Refactoring bridge driver for portability

2013-01-02 Thread Roman Bogorodskiy
Laine Stump wrote: On 12/23/2012 07:54 AM, Roman Bogorodskiy wrote: Hi, Few weeks ago when I have submitted my all-in-one huge FreeBSD, Eric made some comments on the networking part: http://www.redhat.com/archives/libvir-list/2012-December/msg00432.html Now when we're done

[libvirt] [PATCH 0/2]add usb-serial virtual device support for qemu

2013-01-02 Thread Guannan Ren
This two patches are trying to add support for qemu virtual device usb-serial. Add an optional 'type' attribute to target element of serial port device. There are two choices for its value, 'isa-serial' and 'usb-serial'. For backward compatibility, when attribute 'type' is missing the

[libvirt] [PATCH 2/2] qemu: add usb-serial support

2013-01-02 Thread Guannan Ren
Add an optional 'type' attribute to target element of serial port device. There are two choices for its value, 'isa-serial' and 'usb-serial'. For backward compatibility, when attribute 'type' is missing the 'isa-serial' will be chose as before. Libvirt XML sample serial type='pty'

[libvirt] [PATCH 1/2] qemu: add usb-serial caps flag

2013-01-02 Thread Guannan Ren
QEMU_CAPS_DEVICE_USB_SERIAL /* -device usb-serial */ --- src/qemu/qemu_capabilities.c | 2 ++ src/qemu/qemu_capabilities.h | 1 + tests/qemuhelptest.c | 21 ++--- 3 files changed, 17 insertions(+), 7 deletions(-) diff --git a/src/qemu/qemu_capabilities.c

[libvirt] [PATCH 1/3] network: fix typos and docs

2013-01-02 Thread Guannan Ren
--- docs/formatdomain.html.in | 9 ++--- src/conf/domain_conf.c| 4 ++-- 2 files changed, 8 insertions(+), 5 deletions(-) diff --git a/docs/formatdomain.html.in b/docs/formatdomain.html.in index 94df6f8..45d7593 100644 --- a/docs/formatdomain.html.in +++ b/docs/formatdomain.html.in @@

[libvirt] [PATCH 0/3]add usb-net support for qemu

2013-01-02 Thread Guannan Ren
The set of patches fixed some typo in network docs and codes and is trying to support usb-net qemu virtual device. The following is an example for use. Libvirt XML sample: devices interface type='user' mac address='52:54:00:32:6a:91'/ model type='usb-net'/ alias

[libvirt] [PATCH 2/3] qemu: add usb-net caps flag

2013-01-02 Thread Guannan Ren
QEMU_CAPS_DEVICE_USB_NET /* -device usb-net */ --- src/qemu/qemu_capabilities.c | 2 ++ src/qemu/qemu_capabilities.h | 1 + tests/qemuhelptest.c | 21 ++--- 3 files changed, 17 insertions(+), 7 deletions(-) diff --git a/src/qemu/qemu_capabilities.c

[libvirt] [PATCH 3/3] qemu: add usb-net support

2013-01-02 Thread Guannan Ren
Libvirt XML sample: devices interface type='user' mac address='52:54:00:32:6a:91'/ model type='usb-net'/ alias name='net1'/ address type='usb' bus='0' port='1'/ /interface /devices qemu commandline: qemu ${other_vm_args} -netdev user,id=hostnet1 \

[libvirt] [PATCH 1/3] qemu: add usb-audio caps flag

2013-01-02 Thread Guannan Ren
QEMU_CAPS_DEVICE_USB_AUDIO /* -device usb-audio */ --- src/qemu/qemu_capabilities.c | 2 ++ src/qemu/qemu_capabilities.h | 1 + tests/qemuhelptest.c | 9 ++--- 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/qemu/qemu_capabilities.c b/src/qemu/qemu_capabilities.c

[libvirt] [PATCH 3/3] test: add usb-audio testcase

2013-01-02 Thread Guannan Ren
--- tests/qemuxml2argvdata/qemuxml2argv-usb-audio.args | 7 + tests/qemuxml2argvdata/qemuxml2argv-usb-audio.xml | 31 ++ tests/qemuxml2argvtest.c | 3 +++ 3 files changed, 41 insertions(+) create mode 100644

[libvirt] [PATCH 2/3] qemu: parse usb-audio audio device XML and docs

2013-01-02 Thread Guannan Ren
usb-audio XML example: devices sound model='usb-audio' buffer1536/buffer address type='usb' bus='0' port='1'/ /sound /devices qemu ${other_vm_args} \ -device usb-audio,id=sound0,buffer=1536,bus=usb.0,port=1 there is an optional sub-element buffer to customize the buffer size

[libvirt] [PATCH 0/3]add usb-audio support

2013-01-02 Thread Guannan Ren
This set of patches is trying to add qemu usb-audio virtual device support. usb-audio XML example: devices sound model='usb-audio' buffer1536/buffer address type='usb' bus='0' port='1'/ /sound /devices qemu ${other_vm_args} \ -device