Re: [libvirt] Coverity scan

On 02.01.2013 20:22, John Ferlan wrote: On 12/20/2012 04:24 PM, Eric Blake wrote: On 12/20/2012 08:25 AM, John Ferlan wrote: First allow me to introduce myself - I'm John Ferlan a new Red Hat employee (3 weeks). I came from the closed world at HP where for the last 7 years I worked in a

[libvirt] Greetings and next release

Hello everybody, Happy new year and best wishes for 2013 ! When we planned the 1.0.1 release we took the option of taking a bit of extra time to push mid-december and planning the following one for the end of January. Based on this I suggest to enter the freeze for libvirt-1.0.2 on the

Re: [libvirt] [PATCH] qemu: Don't parse log output when starting up a domain

On 02.01.2013 18:45, Eric Blake wrote: On 01/02/2013 08:23 AM, Michal Privoznik wrote: Despite our great effort we still parsed qemu log output. We wouldn't notice unless qemu changed the format of the logs slightly. Maybe mention that the upcoming qemu 1.4 does just that. Anyway, now we

[libvirt] [PATCH 0/4] Fix segfault while redefining snapshots and allow redefinition of external snapshots

This series fixes two issues while redefining snapshots: 1) Segfault when disk alignment of the new snapshot failed (patch 3) 2) Failure to redefine external snapshots. A check was missing to align disks for external snapshots. (patch 4) Peter Krempa (4): snapshot: conf: Make

[libvirt] [PATCH 4/4] snapshot: qemu: Allow redefinition of external snapshots

A redefinition of an external inactive snapshot/checkpoint wasn't possible without this change. --- src/qemu/qemu_driver.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index 4c7558d..3a52b47 100644 --- a/src/qemu/qemu_driver.c

[libvirt] [PATCH 1/4] snapshot: conf: Make virDomainSnapshotIsExternal more reusable

Allow to use definition objects with this predicate function. --- src/conf/snapshot_conf.c | 14 ++ src/conf/snapshot_conf.h | 1 + src/libvirt_private.syms | 1 + 3 files changed, 12 insertions(+), 4 deletions(-) diff --git a/src/conf/snapshot_conf.c b/src/conf/snapshot_conf.c

[libvirt] [PATCH 2/4] snapshot: qemu: Separate logic blocks with newlines

--- src/qemu/qemu_driver.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index b8bb36b..0883a56 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -11365,6 +11365,7 @@ qemuDomainSnapshotCreateXML(virDomainPtr domain,

[libvirt] [PATCH 3/4] snapshot: qemu: Fix segfault and vanishing snapshots when redefining

When the disk alignment check done while redefining an existing snapshot failed, the qemu driver attempted to free the existing snapshot. As in the cleanup path the definition of the snapshot wasn't assigned, the cleanup code dereferenced a NULL pointer. This patch changes the behavior on error

[libvirt] [PATCH v2 5/8] virsh: Expose virDomainInterfacesAddresses

--- tools/virsh-domain.c | 104 +++ 1 file changed, 104 insertions(+) diff --git a/tools/virsh-domain.c b/tools/virsh-domain.c index f3da1d5..e6c09f0 100644 --- a/tools/virsh-domain.c +++ b/tools/virsh-domain.c @@ -8491,6 +8491,109 @@ cleanup:

[libvirt] [PATCH v2 4/8] qemu: Implement qemuDomainInterfacesAddresses

--- src/qemu/qemu_driver.c | 68 ++ 1 file changed, 68 insertions(+) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index b8bb36b..662d956 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -14520,6 +14520,73 @@

[libvirt] [PATCH v2 8/8] python: create example for dumping domain IP addresses

--- examples/python/Makefile.am | 2 +- examples/python/README| 1 + examples/python/domipaddrs.py | 50 +++ 3 files changed, 52 insertions(+), 1 deletion(-) create mode 100755 examples/python/domipaddrs.py diff --git

[libvirt] [PATCH v2 6/8] remote: Implement virDomainInterfacesAddresses

--- daemon/remote.c | 140 +++ src/remote/remote_driver.c | 94 + src/remote/remote_protocol.x | 27 - src/remote_protocol-structs | 27 + 4 files changed, 287 insertions(+), 1 deletion(-) diff

[libvirt] [PATCH v2 3/8] qemu_agent: Implement 'guest-network-get-interfaces' command handling

This command returns an array of all guest interfaces among with their IP and HW addresses. --- src/qemu/qemu_agent.c | 171 ++ src/qemu/qemu_agent.h | 2 + 2 files changed, 173 insertions(+) diff --git a/src/qemu/qemu_agent.c

[libvirt] [PATCH v2 7/8] python: Expose virDomainInterfacesAddresses

--- python/libvirt-override-api.xml | 7 +++ python/libvirt-override.c | 120 2 files changed, 127 insertions(+) diff --git a/python/libvirt-override-api.xml b/python/libvirt-override-api.xml index a0e0496..bea1a59 100644 ---

[libvirt] [PATCH v2 0/8] Dump domain's IP addresses

It's been a while since I tried get this in. I've reworked the patches, the exposed API, and start new round of reviews. Moreover, during work I've come to point, where extending qemu guest agent seemed wise: http://lists.nongnu.org/archive/html/qemu-devel/2012-12/msg03264.html Therefore I am

[libvirt] [PATCH v2 1/8] Introduce virDomainInterfacesAddresses API

This API returns dynamically allocated array of IP addresses for all domain interfaces. --- include/libvirt/libvirt.h.in | 49 ++ python/generator.py | 2 ++ src/driver.h | 6 src/libvirt.c| 71

[libvirt] [PATCH v2 2/8] Introduce virDomainInterfaceFree API

This is just a free function for array of virDomainInterfacePtr as returned by virDomainInterfacesAddresses API. --- include/libvirt/libvirt.h.in | 2 ++ python/generator.py | 1 + src/libvirt.c| 36 src/libvirt_public.syms | 1

Re: [libvirt] [PATCH 2/3] add pci-brige device command line for qemu

On 12/26/12 02:00, liguang wrote: @@ -1801,10 +1803,13 @@ qemuBuildDeviceAddressStr(virBufferPtr buf, * When QEMU grows support for 1 PCI domain, then pci.0 change * to pciNN.0 where NN is the domain number */ -if (qemuCapsGet(caps,

Re: [libvirt] [libvirt-php][PATCH 00/20] compilation under OS X and various

Hi Tugdual! Thanks for the patch series. I've applied and tested it and it's working great! Thanks again for the series. I've noted your major contribution in the AUTHORS file with big thanks going to you :-) Michal On 01/03/2013 10:34 AM, Tugdual Saunier wrote: These patches are the result

[libvirt] [PATCH 0/2] Split out parts of qemu_driver.c into separate files

qemu_driver.c is starting to grow out of proportions. This series creates two(actualy four) files to split out some code from the main file. 1) qemu_util.c - various qemu-related tools and common code (~0.5k lines) 2) qemu_snapshot.c - snapshot related code (~1.7k lines) Apart from reformating

[libvirt] [PATCH 1/2] qemu: Split out various utility functions to qemu_util.c

--- po/POTFILES.in | 1 + src/Makefile.am| 1 + src/qemu/qemu_driver.c | 492 ++--- src/qemu/qemu_util.c | 486 src/qemu/qemu_util.h | 111 +++ 5 files changed, 611

[libvirt] [PATCH] fwrite: silence __wur without using inline

The libvirt folks reported[1] a link error of multiple rpl_fwrite definitions that hits only when optimization and FORTIFY_SOURCE are both enabled, due to improper use of inline. But since that particular use of rpl_fwrite exists only to work around a spurious gcc warning on some versions of

[libvirt] [PATCH] build: fix build with optimization enabled

Build failure detected by Jenkins autobuilder: http://honk.sigxcpu.org:8001/job/libvirt-build/472/changes * .gnulib: Update to latest, for stdio.h rpl_fwrite fix. --- Pushing under the build-breaker rule. I managed to reproduce the link failure on a RHEL 6 box with CFLAGS='-g -O2', and also

Re: [libvirt] libvirtd segfault

On 01/02/2013 09:45 AM, Scott Sullivan wrote: On 12/29/2012 04:09 AM, Michal Privoznik wrote: On 28.12.2012 20:23, Scott Sullivan wrote: snip/ I have just now received another SIGSEGV, with your patch applied. Here's the info from the GDB session: Detaching after fork from child process

Re: [libvirt] [PATCH 1/2] qemu: Split out various utility functions to qemu_util.c

On 01/03/2013 09:45 AM, Peter Krempa wrote: --- po/POTFILES.in | 1 + src/Makefile.am| 1 + src/qemu/qemu_driver.c | 492 ++--- src/qemu/qemu_util.c | 486

Re: [libvirt] [PATCH 1/2] qemu: Split out various utility functions to qemu_util.c

On Thu, Jan 03, 2013 at 05:45:49PM +0100, Peter Krempa wrote: --- po/POTFILES.in | 1 + src/Makefile.am| 1 + src/qemu/qemu_driver.c | 492 ++--- src/qemu/qemu_util.c | 486

Re: [libvirt] [PATCH 2/2] qemu: Split out snapshot related functions to qemu_snapshot.c

On 01/03/2013 09:45 AM, Peter Krempa wrote: --- po/POTFILES.in |1 + src/Makefile.am |1 + src/qemu/qemu_driver.c | 1699 +--- src/qemu/qemu_snapshot.c | 1752 ++

Re: [libvirt] [PATCH 2/2] qemu: Split out snapshot related functions to qemu_snapshot.c

On Thu, Jan 03, 2013 at 10:51:09AM -0700, Eric Blake wrote: On 01/03/2013 09:45 AM, Peter Krempa wrote: --- po/POTFILES.in |1 + src/Makefile.am |1 + src/qemu/qemu_driver.c | 1699 +--- src/qemu/qemu_snapshot.c |

[libvirt] [PATCH] qemu: fix a segfault in qemuProcessWaitForMonitor

Commit b3f2b4ca5cfe98b08ffdb96f0455e3e333e5ace6 left buf unallocated in the case of QMP capability probing being used, leading to a segfault in strlen in the cleanup path. This patch opens the log and allocates the buffer if QMP probing was used, so we can display the helpful error message. ---

Re: [libvirt] [PATCH] fwrite: silence __wur without using inline

Thanks for fixing that. I'm still puzzled about why the problem happened with libvirt. It's better now that stdio doesn't depend on extern-inline, but I worry that whatever bug the libvirt folks were having with stdio and extern inline might crop up when extern inline is used in other include

Re: [libvirt] [PATCH 1/2] qemu: Split out various utility functions to qemu_util.c

On 01/03/13 18:37, Daniel P. Berrange wrote: On Thu, Jan 03, 2013 at 05:45:49PM +0100, Peter Krempa wrote: --- po/POTFILES.in | 1 + src/Makefile.am| 1 + src/qemu/qemu_driver.c | 492 ++--- src/qemu/qemu_util.c | 486

[libvirt] Build failed in Jenkins: libvirt-check #441

See http://honk.sigxcpu.org:8001/job/libvirt-check/441/ -- Started by upstream project libvirt-build build number 482 [workspace] $ /bin/sh -xe /tmp/hudson1110434311877203261.sh + make check Making check in gnulib/lib make[1]: Entering directory

Re: [libvirt] [PATCH] build: fix build with optimization enabled

On Thu, Jan 03, 2013 at 10:15:06AM -0700, Eric Blake wrote: Build failure detected by Jenkins autobuilder: http://honk.sigxcpu.org:8001/job/libvirt-build/472/changes * .gnulib: Update to latest, for stdio.h rpl_fwrite fix. That fixed it. Thanks a lot! As of the latest update I'm seeing

[libvirt] Jenkins build is back to normal : libvirt-syntax-check #437

See http://honk.sigxcpu.org:8001/job/libvirt-syntax-check/437/ -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH v2 1/8] Introduce virDomainInterfacesAddresses API

On 01/03/2013 08:46 AM, Michal Privoznik wrote: This API returns dynamically allocated array of IP addresses for all domain interfaces. --- include/libvirt/libvirt.h.in | 49 ++ python/generator.py | 2 ++ src/driver.h | 6

[libvirt] [PATCH 02/10] Check and handle error for virAsprintf() calls. Ignore the return in parallelsMakePoolName() since subsequent check validates name was allocated.

--- src/parallels/parallels_storage.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/src/parallels/parallels_storage.c b/src/parallels/parallels_storage.c index e768d88..2908bee 100644 --- a/src/parallels/parallels_storage.c +++ b/src/parallels/parallels_storage.c @@

[libvirt] [PATCH 04/10] Ignore the return status check for vmwareUpdateVMStatus in convenience routine vmwareDomainObjListUpdateDomain

--- src/vmware/vmware_driver.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/vmware/vmware_driver.c b/src/vmware/vmware_driver.c index 3763f40..9c81df8 100644 --- a/src/vmware/vmware_driver.c +++ b/src/vmware/vmware_driver.c @@ -949,7 +949,7 @@ static void

[libvirt] [PATCH 06/10] Check return on mkdir for LOCKSPACE_DIR

--- tests/virlockspacetest.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tests/virlockspacetest.c b/tests/virlockspacetest.c index 8673700..7678396 100644 --- a/tests/virlockspacetest.c +++ b/tests/virlockspacetest.c @@ -293,7 +293,8 @@ static int

[libvirt] [PATCH 07/10] Check and handle error for virAsprintf() calls.

--- tests/vmx2xmltest.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/tests/vmx2xmltest.c b/tests/vmx2xmltest.c index 03a8989..2430350 100644 --- a/tests/vmx2xmltest.c +++ b/tests/vmx2xmltest.c @@ -179,7 +179,9 @@ testParseVMXFileName(const char *fileName, void

[libvirt] [PATCH 00/10] Resolve CHECKED_RETURN errors found by Coverity

Bug: https://bugzilla.redhat.com/show_bug.cgi?id=880388 This set of patches resolves the CHECKED_RETURN (CWE-252) errors found by Coverity. John Ferlan (10): interface: Check and handle error for virAsprintf() calls. parallels: Check and handle error for virAsprintf() calls. Ignore the

[libvirt] [PATCH 09/10] Ignore error returns for virBufferTrim().

--- tools/virsh.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tools/virsh.c b/tools/virsh.c index 283194a..9f834e4 100644 --- a/tools/virsh.c +++ b/tools/virsh.c @@ -544,7 +544,7 @@ vshTreePrintInternal(vshControl *ctl, false, indent)

[libvirt] [PATCH 08/10] Check and handle error for virAsprintf() calls.

--- tests/xml2vmxtest.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/tests/xml2vmxtest.c b/tests/xml2vmxtest.c index 653ab6c..c578109 100644 --- a/tests/xml2vmxtest.c +++ b/tests/xml2vmxtest.c @@ -193,8 +193,9 @@ testFormatVMXFileName(const char *src, void *opaque

[libvirt] [PATCH 05/10] Check return status for setting TCP_NODELAY option and generate a VIR_DEBUG message on failure. Allow connection to continue.

--- src/xen/xend_internal.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/xen/xend_internal.c b/src/xen/xend_internal.c index 84a25e8..1f779b0 100644 --- a/src/xen/xend_internal.c +++ b/src/xen/xend_internal.c @@ -91,8 +91,10 @@ do_connect(virConnectPtr xend)

[libvirt] [PATCH 10/10] Check and handle select() errors from waitsocket().

--- src/phyp/phyp_driver.c | 42 -- 1 file changed, 32 insertions(+), 10 deletions(-) diff --git a/src/phyp/phyp_driver.c b/src/phyp/phyp_driver.c index 8e26b0c..2dabd19 100644 --- a/src/phyp/phyp_driver.c +++ b/src/phyp/phyp_driver.c @@ -76,7 +76,6 @@

[libvirt] [PATCH 01/10] Check and handle error for virAsprintf() calls.

--- src/interface/interface_backend_udev.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/src/interface/interface_backend_udev.c b/src/interface/interface_backend_udev.c index cc20b98..3231b73 100644 --- a/src/interface/interface_backend_udev.c +++

[libvirt] [PATCH 03/10] Check status when attempting to set SO_REUSEADDR flag on outgoing connection On failure, VIR_WARN(), but continue to connect.

--- src/rpc/virnetsocket.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/rpc/virnetsocket.c b/src/rpc/virnetsocket.c index ef93892..6684eef 100644 --- a/src/rpc/virnetsocket.c +++ b/src/rpc/virnetsocket.c @@ -470,7 +470,9 @@ int virNetSocketNewConnectTCP(const char

Re: [libvirt] [PATCH 01/10] Check and handle error for virAsprintf() calls.

On Thu, Jan 03, 2013 at 02:16:13PM -0500, John Ferlan wrote: --- src/interface/interface_backend_udev.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/src/interface/interface_backend_udev.c b/src/interface/interface_backend_udev.c index cc20b98..3231b73 100644

Re: [libvirt] [PATCH 02/10] Check and handle error for virAsprintf() calls. Ignore the return in parallelsMakePoolName() since subsequent check validates name was allocated.

NB, you should restrict the first line of the commit message to approx 70 characters. Then have a single blank line, followed by the longer description. This ensures that you get sensible subject lines :-) On Thu, Jan 03, 2013 at 02:16:14PM -0500, John Ferlan wrote: ---

Re: [libvirt] [PATCH 05/10] Check return status for setting TCP_NODELAY option and generate a VIR_DEBUG message on failure. Allow connection to continue.

On Thu, Jan 03, 2013 at 02:16:17PM -0500, John Ferlan wrote: --- src/xen/xend_internal.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/xen/xend_internal.c b/src/xen/xend_internal.c index 84a25e8..1f779b0 100644 --- a/src/xen/xend_internal.c +++

Re: [libvirt] [PATCH 06/10] Check return on mkdir for LOCKSPACE_DIR

On Thu, Jan 03, 2013 at 02:16:18PM -0500, John Ferlan wrote: --- tests/virlockspacetest.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tests/virlockspacetest.c b/tests/virlockspacetest.c index 8673700..7678396 100644 --- a/tests/virlockspacetest.c +++

Re: [libvirt] [PATCH 07/10] Check and handle error for virAsprintf() calls.

On Thu, Jan 03, 2013 at 02:16:19PM -0500, John Ferlan wrote: --- tests/vmx2xmltest.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/tests/vmx2xmltest.c b/tests/vmx2xmltest.c index 03a8989..2430350 100644 --- a/tests/vmx2xmltest.c +++ b/tests/vmx2xmltest.c @@

Re: [libvirt] [PATCH 08/10] Check and handle error for virAsprintf() calls.

On Thu, Jan 03, 2013 at 02:16:20PM -0500, John Ferlan wrote: --- tests/xml2vmxtest.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/tests/xml2vmxtest.c b/tests/xml2vmxtest.c index 653ab6c..c578109 100644 --- a/tests/xml2vmxtest.c +++ b/tests/xml2vmxtest.c @@

Re: [libvirt] [PATCH 03/10] Check status when attempting to set SO_REUSEADDR flag on outgoing connection On failure, VIR_WARN(), but continue to connect.

On Thu, Jan 03, 2013 at 02:16:15PM -0500, John Ferlan wrote: --- src/rpc/virnetsocket.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/rpc/virnetsocket.c b/src/rpc/virnetsocket.c index ef93892..6684eef 100644 --- a/src/rpc/virnetsocket.c +++

Re: [libvirt] [PATCH 09/10] Ignore error returns for virBufferTrim().

On Thu, Jan 03, 2013 at 02:16:21PM -0500, John Ferlan wrote: --- tools/virsh.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tools/virsh.c b/tools/virsh.c index 283194a..9f834e4 100644 --- a/tools/virsh.c +++ b/tools/virsh.c @@ -544,7 +544,7 @@

Re: [libvirt] [PATCH 10/10] Check and handle select() errors from waitsocket().

On Thu, Jan 03, 2013 at 02:16:22PM -0500, John Ferlan wrote: --- src/phyp/phyp_driver.c | 42 -- 1 file changed, 32 insertions(+), 10 deletions(-) diff --git a/src/phyp/phyp_driver.c b/src/phyp/phyp_driver.c index 8e26b0c..2dabd19 100644 ---

Re: [libvirt] [PATCH 00/10] Resolve CHECKED_RETURN errors found by Coverity

On Thu, Jan 03, 2013 at 02:16:12PM -0500, John Ferlan wrote: Bug: https://bugzilla.redhat.com/show_bug.cgi?id=880388 This set of patches resolves the CHECKED_RETURN (CWE-252) errors found by Coverity. John Ferlan (10): interface: Check and handle error for virAsprintf() calls.

Re: [libvirt] [PATCH 03/10] Check status when attempting to set SO_REUSEADDR flag on outgoing connection On failure, VIR_WARN(), but continue to connect.

On 01/03/2013 02:34 PM, Daniel P. Berrange wrote: On Thu, Jan 03, 2013 at 02:16:15PM -0500, John Ferlan wrote: --- src/rpc/virnetsocket.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/rpc/virnetsocket.c b/src/rpc/virnetsocket.c index ef93892..6684eef 100644 ---

Re: [libvirt] [PATCH 2/6] qemu: Add a hash table for the shared disks

On 01/02/2013 07:37 AM, Osier Yang wrote: This introduces a hash table for qemu driver, to store the shared disk's info as (@major:minor, @ref_count). @ref_count is the number of domains which shares the disk. Since we only care about if the disk support unprivileged SG_IO commands, and the

Re: [libvirt] [PATCH] qemu: fix a segfault in qemuProcessWaitForMonitor

On 01/03/2013 11:15 AM, Ján Tomko wrote: Commit b3f2b4ca5cfe98b08ffdb96f0455e3e333e5ace6 left buf unallocated in the case of QMP capability probing being used, leading to a segfault in strlen in the cleanup path. This patch opens the log and allocates the buffer if QMP probing was used, so

Re: [libvirt] [PATCH] fwrite: silence __wur without using inline

On 01/03/2013 11:16 AM, Paul Eggert wrote: Thanks for fixing that. I'm still puzzled about why the problem happened with libvirt. Why libvirt, and not detected elsewhere? Probably because libvirt does this at configure time: AH_VERBATIM([FORTIFY_SOURCE], [/* Enable compile-time and

Re: [libvirt] [PATCH] fwrite: silence __wur without using inline

On 01/03/13 12:23, Eric Blake wrote: The elided code was not using _GL_EXTERN_INLINE, but _GL_INLINE. They have different semantics, but I'm hard-pressed to say _which_ semantics are right from just those names. Standard C semantics. _GL_EXTERN_INLINE is C99/C11 extern inline. _GL_INILNE is

Re: [libvirt] [PATCH] fwrite: silence __wur without using inline

On 01/03/2013 01:48 PM, Paul Eggert wrote: Can't be done in Standard C, as far as I know. Oh well, not worth it then. With GNU C it can be done with __attribute__((__always_inline__)). Why is it important that it not be a linkable entry point? At least in the case libvirt was hitting,

Re: [libvirt] [PATCH 3/6] docs: Add docs and rng schema for new XML tag sgio

On 01/02/2013 07:37 AM, Osier Yang wrote: This introduces new XML tag sgio for disk, its valid values are filtered and unfiltered, setting it as filtered will set the disk's unpriv_sgio to 0, and unfiltered to set it as 1, which allows the unprivileged SG_IO commands. ---

Re: [libvirt] [PATCH 02/10] Check and handle error for virAsprintf() calls. Ignore the return in parallelsMakePoolName() since subsequent check validates name was allocated.

On 01/03/2013 12:32 PM, Daniel P. Berrange wrote: NB, you should restrict the first line of the commit message to approx 70 characters. Then have a single blank line, followed by the longer description. This ensures that you get sensible subject lines :-) Also, using the same subject line

[libvirt] libvirt unable to start domains

Hi, I updated my libvirt git clone and install yesterday (after about a month or so) and now I can't start domains: $ virsh start fedora18 error: Failed to start domain fedora18 error: unsupported configuration: This QEMU does not support QXL graphics adapters While libvirt is self-built, I'm

[libvirt] [PATCH] Install virtlockd.{socket, service} non executable

since they're not scripts but systemd service files. --- src/Makefile.am |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/Makefile.am b/src/Makefile.am index f7a9b91..0cfc1ed 100644 --- a/src/Makefile.am +++ b/src/Makefile.am @@ -1687,9 +1687,9 @@ DISTCLEANFILES +=

Re: [libvirt] [PATCH] Install virtlockd.{socket, service} non executable

On 01/03/2013 03:05 PM, Guido Günther wrote: since they're not scripts but systemd service files. --- src/Makefile.am |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) ACK. diff --git a/src/Makefile.am b/src/Makefile.am index f7a9b91..0cfc1ed 100644 --- a/src/Makefile.am

[libvirt] [PATCH] The -vga CLI arg accepts qxl in qemu 1.2+ always

The -vga command always accepts qxl in 1.2 and newer. --- src/qemu/qemu_capabilities.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/src/qemu/qemu_capabilities.c b/src/qemu/qemu_capabilities.c index f49a31c..c3ab488 100644 --- a/src/qemu/qemu_capabilities.c +++

Re: [libvirt] libvirt unable to start domains

On Thu, Jan 3, 2013 at 3:44 PM, Zeeshan Ali (Khattak) zeesha...@gnome.org wrote: Hi, I updated my libvirt git clone and install yesterday (after about a month or so) and now I can't start domains: $ virsh start fedora18 error: Failed to start domain fedora18 error: unsupported

Re: [libvirt] libvirt unable to start domains

On Thu, Jan 3, 2013 at 11:44 PM, Zeeshan Ali (Khattak) zeesha...@gnome.org wrote: Hi, I updated my libvirt git clone and install yesterday (after about a month or so) and now I can't start domains: $ virsh start fedora18 error: Failed to start domain fedora18 error: unsupported

Re: [libvirt] [PATCH] fwrite: silence __wur without using inline

On 01/03/2013 01:00 PM, Eric Blake wrote: in the case libvirt was hitting, multiple files used fwrite, which in turn meant multiple linkable entries for rpl_fwrite were emitted when linking things together; but because they weren't marked 'static', the linker didn't like us. OK, but surely

Re: [libvirt] libvirt unable to start domains

On Fri, Jan 4, 2013 at 1:44 AM, Doug Goldstein car...@gentoo.org wrote: On Thu, Jan 3, 2013 at 3:44 PM, Zeeshan Ali (Khattak) zeesha...@gnome.org wrote: Hi, I updated my libvirt git clone and install yesterday (after about a month or so) and now I can't start domains: $ virsh start

Re: [libvirt] [PATCH 4/6] conf: Parse and format the new XML

On 01/02/2013 07:37 AM, Osier Yang wrote: Like rawio, sgio is only allowed for block disk of device type lun. It doesn't default disk-sgio to filtered when parsing, as it won't be able to distinguish explicitly requested filtered and a default filtered in driver then. We have to error out

Re: [libvirt] libvirt unable to start domains

On Thu, Jan 3, 2013 at 5:58 PM, Zeeshan Ali (Khattak) zeesha...@gnome.org wrote: On Thu, Jan 3, 2013 at 11:44 PM, Zeeshan Ali (Khattak) zeesha...@gnome.org wrote: Hi, I updated my libvirt git clone and install yesterday (after about a month or so) and now I can't start domains: $ virsh

Re: [libvirt] [PATCH] The -vga CLI arg accepts qxl in qemu 1.2+ always

On 01/03/2013 04:42 PM, Doug Goldstein wrote: The -vga command always accepts qxl in 1.2 and newer. Are you sure? I thought qemu ./configure allows a choice of which graphics engines to support, and that you can compile qxl out (distros don't do that, but a self-built qemu might support -vga

Re: [libvirt] RFC: An embedded mode for QEMU/LXC drivers

On 01/02/2013 09:55 PM, Richard W.M. Jones wrote: On Wed, Jan 02, 2013 at 03:36:54PM +, Daniel P. Berrange wrote: This is something I was thinking about a little over the christmas break. I've no intention of implementing this in the immediate future, but wanted to post it while it was

[libvirt] problem in pciFindStubDriver

For Xen PV guests, pciback is the only working driver, pci-stub doesn't work. Current function finds pci-stub driver first, if pci-stub doesn't exist, find pciback. It won't work for Xen PV guests since it will find pci-stub driver and return, but in fact it needs pciback. One way is to prefer

Re: [libvirt] [PATCH 2/3] add pci-brige device command line for qemu

在 2013-01-03四的 16:13 +0100，Ján Tomko写道： On 12/26/12 02:00, liguang wrote: @@ -1801,10 +1803,13 @@ qemuBuildDeviceAddressStr(virBufferPtr buf, * When QEMU grows support for 1 PCI domain, then pci.0 change * to pciNN.0 where NN is the domain number */ -

Re: [libvirt] [PATCH 4/6] conf: Parse and format the new XML

On 2013年01月04日 08:21, Eric Blake wrote: On 01/02/2013 07:37 AM, Osier Yang wrote: Like rawio, sgio is only allowed for block disk of device type lun. It doesn't default disk-sgio to filtered when parsing, as it won't be able to distinguish explicitly requested filtered and a default filtered

Re: [libvirt] [PATCH 3/6] docs: Add docs and rng schema for new XML tag sgio

On 2013年01月04日 05:25, Eric Blake wrote: On 01/02/2013 07:37 AM, Osier Yang wrote: This introduces new XML tag sgio for disk, its valid values are filtered and unfiltered, setting it as filtered will set the disk's unpriv_sgio to 0, and unfiltered to set it as 1, which allows the unprivileged

Re: [libvirt] [PATCH 1/6] util: Prepare helpers for unpriv_sgio setting

On 2013年01月03日 08:01, Eric Blake wrote: On 01/02/2013 07:37 AM, Osier Yang wrote: virGetDeviceID could be used across the sources, but it doesn't relate with this series, and could be done later. * src/util/virutil.h: (Declare virGetDeviceID, and

Re: [libvirt] libvirt unable to start domains

On 01/04/2013 08:30 AM, Doug Goldstein wrote: On Thu, Jan 3, 2013 at 5:58 PM, Zeeshan Ali (Khattak) zeesha...@gnome.org wrote: On Thu, Jan 3, 2013 at 11:44 PM, Zeeshan Ali (Khattak) zeesha...@gnome.org wrote: Hi, I updated my libvirt git clone and install yesterday (after about a month or

Re: [libvirt] [PATCH 2/6] qemu: Add a hash table for the shared disks

On 2013年01月04日 04:02, Eric Blake wrote: On 01/02/2013 07:37 AM, Osier Yang wrote: This introduces a hash table for qemu driver, to store the shared disk's info as (@major:minor, @ref_count). @ref_count is the number of domains which shares the disk. Since we only care about if the disk support

Re: [libvirt] [PATCH 2/3] add pci-brige device command line for qemu

On 2013年01月04日 10:28, li guang wrote: 在 2013-01-03四的 16:13 +0100，Ján Tomko写道： On 12/26/12 02:00, liguang wrote: @@ -1801,10 +1803,13 @@ qemuBuildDeviceAddressStr(virBufferPtr buf, * When QEMU grows support for 1 PCI domain, then pci.0 change * to pciNN.0 where NN is the

Re: [libvirt] libvirt unable to start domains

On 01/04/2013 08:30 AM, Doug Goldstein wrote: On Thu, Jan 3, 2013 at 5:58 PM, Zeeshan Ali (Khattak) zeesha...@gnome.org wrote: On Thu, Jan 3, 2013 at 11:44 PM, Zeeshan Ali (Khattak) zeesha...@gnome.org wrote: Hi, I updated my libvirt git clone and install yesterday (after about a month or

Re: [libvirt] [ESX:Error] HTTP 403 error for CURL upload operation

I was able to solve this issue, it seems for upload operation the CURL headers needs to contain: Connection: Keep-Alive); Content-Type: application/x-vnd.vmware-streamVmdk); Content-Length: %ld Though the error was related to forbidden

Re: [libvirt] [PATCH] The -vga CLI arg accepts qxl in qemu 1.2+ always

On 01/04/2013 08:40 AM, Eric Blake wrote: On 01/03/2013 04:42 PM, Doug Goldstein wrote: The -vga command always accepts qxl in 1.2 and newer. Are you sure? I thought qemu ./configure allows a choice of which graphics engines to support, and that you can compile qxl out (distros don't do that,