Re: [libvirt] [PATCH v2 1/2] add pci-bridge controller type

2013-01-08 Thread Daniel P. Berrange
On Tue, Jan 08, 2013 at 09:58:49AM +0800, liguang wrote: Signed-off-by: liguang lig.f...@cn.fujitsu.com --- src/conf/device_conf.c | 12 +++- src/conf/device_conf.h |1 + src/conf/domain_conf.c |5 - src/conf/domain_conf.h |1 + 4 files changed, 17 insertions(+),

Re: [libvirt] [PATCH libvirt-java 8/9] Implement and use virDomainMigrateToURI2 instead of virDomainMigrateToURI

2013-01-08 Thread Claudio Bley
At Mon, 07 Jan 2013 17:10:16 -0700, Eric Blake wrote: On 01/05/2013 04:48 AM, Wido den Hollander wrote: The migrateToURI method now uses virDomainMigrateToURI2 so we can support some more features. +public int migrateToURI(String dconnuri, String miguri, String dxml, long

Re: [libvirt] [PATCH v2 1/2] add pci-bridge controller type

2013-01-08 Thread li guang
在 2013-01-08二的 16:37 +0800,li guang写道: 在 2013-01-08二的 08:04 +,Daniel P. Berrange写道: On Tue, Jan 08, 2013 at 09:58:49AM +0800, liguang wrote: Signed-off-by: liguang lig.f...@cn.fujitsu.com --- src/conf/device_conf.c | 12 +++- src/conf/device_conf.h |1 +

Re: [libvirt] [PATCH v2 1/2] add pci-bridge controller type

2013-01-08 Thread Daniel P. Berrange
On Tue, Jan 08, 2013 at 04:47:40PM +0800, li guang wrote: 在 2013-01-08二的 16:37 +0800,li guang写道: 在 2013-01-08二的 08:04 +,Daniel P. Berrange写道: On Tue, Jan 08, 2013 at 09:58:49AM +0800, liguang wrote: Signed-off-by: liguang lig.f...@cn.fujitsu.com --- src/conf/device_conf.c |

Re: [libvirt] [PATCH libvirt-java 8/9] Implement and use virDomainMigrateToURI2 instead of virDomainMigrateToURI

2013-01-08 Thread Wido den Hollander
On 01/08/2013 09:18 AM, Claudio Bley wrote: At Mon, 07 Jan 2013 17:10:16 -0700, Eric Blake wrote: On 01/05/2013 04:48 AM, Wido den Hollander wrote: The migrateToURI method now uses virDomainMigrateToURI2 so we can support some more features. +public int migrateToURI(String dconnuri,

Re: [libvirt] [PATCH v2 1/2] add pci-bridge controller type

2013-01-08 Thread li guang
在 2013-01-08二的 08:51 +,Daniel P. Berrange写道: On Tue, Jan 08, 2013 at 04:47:40PM +0800, li guang wrote: 在 2013-01-08二的 16:37 +0800,li guang写道: 在 2013-01-08二的 08:04 +,Daniel P. Berrange写道: On Tue, Jan 08, 2013 at 09:58:49AM +0800, liguang wrote: Signed-off-by: liguang

Re: [libvirt] [PATCH v2 1/2] add pci-bridge controller type

2013-01-08 Thread Daniel P. Berrange
On Tue, Jan 08, 2013 at 04:55:28PM +0800, li guang wrote: 在 2013-01-08二的 08:51 +,Daniel P. Berrange写道: On Tue, Jan 08, 2013 at 04:47:40PM +0800, li guang wrote: 在 2013-01-08二的 16:37 +0800,li guang写道: 在 2013-01-08二的 08:04 +,Daniel P. Berrange写道: On Tue, Jan 08, 2013 at

[libvirt] [PATCH v2 1/12] Introduce API virNodeDeviceLookupSCSIHostByWWN

2013-01-08 Thread Osier Yang
Since the name (like scsi_host10) is not stable for vHBA, (it can be changed either after recreating or system rebooting), current API virNodeDeviceLookupByName is not nice to use for management app in this case. (E.g. one wants to destroy the vHBA whose name has been changed after system

[libvirt] [PATCH v2 2/4] remote: Wire up the remote protocol

2013-01-08 Thread Osier Yang
Like virNodeDeviceCreateXML, virNodeDeviceLookupSCSIHostByWWN has to be treated specially when generating the RPC codes. Also new rules are added in fixup_name to keep the name. --- src/remote/remote_driver.c |1 + src/remote/remote_protocol.x | 13 -

[libvirt] [PATCH v2 4/12] virsh: Use virNodeDeviceLookupSCSIHostByWWN

2013-01-08 Thread Osier Yang
Only nodedev-destroy and nodedev-dumpxml can benifit from the new API, other commands like nodedev-detach only works for PCI devices, WWN makes no sense for them. --- tools/virsh-nodedev.c | 91 tools/virsh.pod | 15 +--- 2 files

[libvirt] [PATCH v2 3/4] nodedev: Implement virNodeDeviceLookupSCSIHostByWWN

2013-01-08 Thread Osier Yang
This just simply changes nodeDeviceLookupByWWN to be not static, and its name into nodeDeviceLookupSCSIHostByWWN. And use that for udev and HAL backends. --- src/node_device/node_device_driver.c | 13 - src/node_device/node_device_driver.h |4

Re: [libvirt] [PATCH v2 1/2] add pci-bridge controller type

2013-01-08 Thread li guang
在 2013-01-08二的 08:04 +,Daniel P. Berrange写道: On Tue, Jan 08, 2013 at 09:58:49AM +0800, liguang wrote: Signed-off-by: liguang lig.f...@cn.fujitsu.com --- src/conf/device_conf.c | 12 +++- src/conf/device_conf.h |1 + src/conf/domain_conf.c |5 -

Re: [libvirt] [PATCH 01/12] Introduce new public API virNodeDeviceFindByWWN

2013-01-08 Thread Osier Yang
On 2013年01月08日 01:27, Daniel P. Berrange wrote: On Tue, Jan 08, 2013 at 01:05:23AM +0800, Osier Yang wrote: Since the name (like scsi_host10) is not stable for vHBA, (it can be changed either after recreating or system rebooting), current API virNodeDeviceFindByName is not nice to use for

[libvirt] [PATCH] qemu: Relax hard RSS limit

2013-01-08 Thread Michal Privoznik
Currently, if there's no hard memory limit defined for a domain, libvirt tries to calculate one, based on domain definition and magic equation and set it upon the domain startup. The rationale behind was, if there's a memory leak or exploit in qemu, we should prevent the host system trashing.

Re: [libvirt] [PATCH 00/15] [libvirt-java] some improvements and bug fixes (resend

2013-01-08 Thread Claudio Bley
At Mon, 7 Jan 2013 15:31:30 +0100, Jiri Denemark wrote: On Wed, Nov 28, 2012 at 10:51:56 +0100, Claudio Bley wrote: ping? Anyone care to review these patches, before someone redoes this work again...? ACK to the whole series. I looked at the individual patches and while I'm not

Re: [libvirt] [PATCHv4 0/2] S390: Adding support for SCLP Console

2013-01-08 Thread Michal Privoznik
On 07.01.2013 18:17, Viktor Mihajlovski wrote: The S390 architecture comes with a native console type (SCLP console) which is now also supported by current QEMU. This series is enabling libvirt to configure S390 domains with SCLP consoles. The domain XML has to be extended for the new

Re: [libvirt] [PATCHv4 1/2] S390: Add SCLP console front end support

2013-01-08 Thread Michal Privoznik
On 07.01.2013 18:17, Viktor Mihajlovski wrote: From: J.B. Joret j...@linux.vnet.ibm.com The SCLP console is the native console type for s390 and is preferred over the virtio console as it doesn't require special drivers and is more efficient. Recent versions of QEMU come with SCLP support

Re: [libvirt] [PATCHv4 2/2] S390: Enable SCLP Console in QEMU driver

2013-01-08 Thread Michal Privoznik
On 07.01.2013 18:17, Viktor Mihajlovski wrote: From: J.B. Joret j...@linux.vnet.ibm.com This is the QEMU backend code for the SCLP console support. It includes SCLP capability detection, QEMU command line generation and a test case. Signed-off-by: J.B. Joret j...@linux.vnet.ibm.com

[libvirt] [PATCH] docs: remove duplicate check in index.add

2013-01-08 Thread Claudio Bley
Signed-off-by: Claudio Bley cb...@av-test.de --- Pushing under the trivial rule. docs/apibuild.py |2 -- 1 file changed, 2 deletions(-) diff --git a/docs/apibuild.py b/docs/apibuild.py index e73a85d..7b336b3 100755 --- a/docs/apibuild.py +++ b/docs/apibuild.py @@ -240,8 +240,6 @@ class

Re: [libvirt] [PATCHv4 0/2] S390: Adding support for SCLP Console

2013-01-08 Thread Viktor Mihajlovski
On 01/08/2013 11:48 AM, Michal Privoznik wrote: I went ahead and pushed both patches with the cosmetic adjustment proposed in 2/2. Michal Thanks Michal. -- Mit freundlichen Grüßen/Kind Regards Viktor Mihajlovski IBM Deutschland Research Development GmbH Vorsitzender des

Re: [libvirt] [PATCH] docs: remove duplicate check in index.add

2013-01-08 Thread Michal Privoznik
On 08.01.2013 11:43, Claudio Bley wrote: Signed-off-by: Claudio Bley cb...@av-test.de --- Pushing under the trivial rule. docs/apibuild.py |2 -- 1 file changed, 2 deletions(-) diff --git a/docs/apibuild.py b/docs/apibuild.py index e73a85d..7b336b3 100755 --- a/docs/apibuild.py

Re: [libvirt] [PATCH libvirt-java 8/9] Implement and use virDomainMigrateToURI2 instead of virDomainMigrateToURI

2013-01-08 Thread Jiri Denemark
On Tue, Jan 08, 2013 at 09:18:30 +0100, Claudio Bley wrote: At Mon, 07 Jan 2013 17:10:16 -0700, Eric Blake wrote: On 01/05/2013 04:48 AM, Wido den Hollander wrote: The migrateToURI method now uses virDomainMigrateToURI2 so we can support some more features. +public int

Re: [libvirt] [PATCH v2] util: Check for NULL 'dev' on input to usbFreeDevice

2013-01-08 Thread Daniel P. Berrange
On Tue, Jan 08, 2013 at 07:42:26AM -0500, John Ferlan wrote: Added 'usbFreeDevice' to the useless_free_options list in cfg.mk --- cfg.mk| 1 + src/util/virusb.c | 5 +++-- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/cfg.mk b/cfg.mk index f9270b0..ab163af

[libvirt] [PATCH v2] Resolve FORWARD_NULL errors found by Coverity

2013-01-08 Thread John Ferlan
Reworked the usbFreeDevice changes to allow NULL to be passed and added usbFreeDevice to the cfg.mk file. John Ferlan (1): util: Check for NULL 'dev' on input to usbFreeDevice cfg.mk| 1 + src/util/virusb.c | 5 +++-- 2 files changed, 4 insertions(+), 2 deletions(-) -- 1.7.11.7

[libvirt] [PATCH v2] util: Check for NULL 'dev' on input to usbFreeDevice

2013-01-08 Thread John Ferlan
Added 'usbFreeDevice' to the useless_free_options list in cfg.mk --- cfg.mk| 1 + src/util/virusb.c | 5 +++-- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/cfg.mk b/cfg.mk index f9270b0..ab163af 100644 --- a/cfg.mk +++ b/cfg.mk @@ -98,6 +98,7 @@ useless_free_options

Re: [libvirt] [PATCH] docs: remove duplicate check in index.add

2013-01-08 Thread Claudio Bley
At Tue, 08 Jan 2013 12:12:02 +0100, Michal Privoznik wrote: On 08.01.2013 11:43, Claudio Bley wrote: Signed-off-by: Claudio Bley cb...@av-test.de --- Pushing under the trivial rule. docs/apibuild.py |2 -- 1 file changed, 2 deletions(-) diff --git a/docs/apibuild.py

Re: [libvirt] [PATCH] storage: fix leak in virStorageBackendLogicalMakeVol

2013-01-08 Thread Ján Tomko
On 01/07/13 13:34, Peter Krempa wrote: On 01/07/13 13:05, Ján Tomko wrote: Use regfree instead of VIR_FREE. --- src/storage/storage_backend_logical.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) ACK. Peter Thanks, pushed now. -- libvir-list mailing list

Re: [libvirt] [PATCH v2] Resolve FORWARD_NULL errors found by Coverity

2013-01-08 Thread Peter Krempa
On 01/08/13 13:42, John Ferlan wrote: Reworked the usbFreeDevice changes to allow NULL to be passed and added usbFreeDevice to the cfg.mk file. John Ferlan (1): util: Check for NULL 'dev' on input to usbFreeDevice cfg.mk| 1 + src/util/virusb.c | 5 +++-- 2 files changed, 4

Re: [libvirt] [PATCH] Resolve COPY_PASTE error found by Coverity

2013-01-08 Thread Daniel P. Berrange
On Tue, Jan 08, 2013 at 10:10:10AM -0500, John Ferlan wrote: Fix copy-paste error doing handshake. The clientShake was not set to true, thus we'd potentially never leave the handshake while loop. --- tests/virnettlscontexttest.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

[libvirt] [PATCH] Resolve COPY_PASTE error found by Coverity

2013-01-08 Thread John Ferlan
Fix copy-paste error doing handshake. The clientShake was not set to true, thus we'd potentially never leave the handshake while loop. --- tests/virnettlscontexttest.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/virnettlscontexttest.c b/tests/virnettlscontexttest.c

Re: [libvirt] [PATCH] qemu: Relax hard RSS limit

2013-01-08 Thread Daniel P. Berrange
On Tue, Jan 08, 2013 at 10:37:19AM +0100, Michal Privoznik wrote: Currently, if there's no hard memory limit defined for a domain, libvirt tries to calculate one, based on domain definition and magic equation and set it upon the domain startup. The rationale behind was, if there's a memory

[libvirt] [PATCH] Add Claudio Bley to the committers list

2013-01-08 Thread Claudio Bley
Signed-off-by: Claudio Bley cb...@av-test.de --- Is this the way to do it? AUTHORS.in |1 + 1 file changed, 1 insertion(+) diff --git a/AUTHORS.in b/AUTHORS.in index cd54f95..fa61505 100644 --- a/AUTHORS.in +++ b/AUTHORS.in @@ -11,6 +11,7 @@ Alex Jia a...@redhat.com Anthony Liguori

[libvirt] [PATCH 1/2] docs: break longer text into paragraphs in HTML

2013-01-08 Thread Claudio Bley
Libvirt's HTML documentation is not as easy to the eyes as it could be since long text has no visual breaks. Take advantage of the formatting in documentation comments and wrap each part separated by two consecutive \n into a HTML p element. Signed-off-by: Claudio Bley cb...@av-test.de ---

[libvirt] [PATCH 0/2] Improve readability of generated HTML documenation

2013-01-08 Thread Claudio Bley
Hi. These patches try to improve the look and feel of the libvirt documentation. Claudio Bley (2): docs: break longer text into paragraphs in HTML docs: Limit the maximum width of info text to 75em for better readability docs/libvirt.css |4 docs/newapi.xsl | 50

Re: [libvirt] [PATCH] Resolve COPY_PASTE error found by Coverity

2013-01-08 Thread Michal Privoznik
On 08.01.2013 16:17, Daniel P. Berrange wrote: On Tue, Jan 08, 2013 at 10:10:10AM -0500, John Ferlan wrote: Fix copy-paste error doing handshake. The clientShake was not set to true, thus we'd potentially never leave the handshake while loop. --- tests/virnettlscontexttest.c | 2 +- 1

[libvirt] [PATCH 2/2] docs: Limit the maximum width of info text to 75em for better readability

2013-01-08 Thread Claudio Bley
Signed-off-by: Claudio Bley cb...@av-test.de --- docs/libvirt.css |4 docs/newapi.xsl |6 +++--- 2 files changed, 7 insertions(+), 3 deletions(-) diff --git a/docs/libvirt.css b/docs/libvirt.css index 5123ed6..b6f5c4b 100644 --- a/docs/libvirt.css +++ b/docs/libvirt.css @@ -412,3

Re: [libvirt] [PATCH] Add Claudio Bley to the committers list

2013-01-08 Thread Eric Blake
On 01/08/2013 08:15 AM, Claudio Bley wrote: Signed-off-by: Claudio Bley cb...@av-test.de --- Is this the way to do it? Yep. ACK. AUTHORS.in |1 + 1 file changed, 1 insertion(+) -- Eric Blake eblake redhat com+1-919-301-3266 Libvirt virtualization library

[libvirt] [PATCH] build: avoid compiler warning

2013-01-08 Thread Eric Blake
gcc 4.1.2 on RHEL 5 warned: conf/network_conf.c:3136: warning: 'foundIdx' may be used uninitialized in this function The warning is spurious, but initializing the variable doesn't hurt. * src/conf/network_conf.c (virNetworkDefUpdateDNSHost): Silence unused variable warning. --- Pushing under

Re: [libvirt] [PATCH] maint: avoid potential promotion issues with [ug]id_t

2013-01-08 Thread Eric Blake
On 01/07/2013 08:12 PM, Guannan Ren wrote: * src/locking/lock_driver_sanlock.c (virLockManagerSanlockSetupLockspace, virLockManagerSanlockInit) (virLockManagerSanlockCreateLease): Cast -1 to proper type before comparing with uid_t or gid_t. According to GUN C library uid_t This is

[libvirt] [PATCH 4/4] interface: Need to initialize 'add_to_list'

2013-01-08 Thread John Ferlan
--- src/interface/interface_backend_udev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/interface/interface_backend_udev.c b/src/interface/interface_backend_udev.c index 3231b73..10b8a5d 100644 --- a/src/interface/interface_backend_udev.c +++

[libvirt] [PATCH 0/4] Resolve UNINIT errors found by Coverity

2013-01-08 Thread John Ferlan
This set of patches resolves Error: UNINIT (CWE-457) errors found by Coverity John Ferlan (4): parallels: Resolve issues with uninitialized 'ret' value openvz: Need to initialize 'ret' for kb_per_pages error path lxc: Initialize dst due to potential cleanup usage before setting interface:

[libvirt] [PATCH 2/4] openvz: Need to initialize 'ret' for kb_per_pages error path

2013-01-08 Thread John Ferlan
--- src/openvz/openvz_conf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/openvz/openvz_conf.c b/src/openvz/openvz_conf.c index 09518d5..1ad3feb 100644 --- a/src/openvz/openvz_conf.c +++ b/src/openvz/openvz_conf.c @@ -485,7 +485,7 @@ error: static int

[libvirt] [PATCH 3/4] lxc: Initialize dst due to potential cleanup usage before setting

2013-01-08 Thread John Ferlan
--- src/lxc/lxc_driver.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/lxc/lxc_driver.c b/src/lxc/lxc_driver.c index 8050ce6..8457ae9 100644 --- a/src/lxc/lxc_driver.c +++ b/src/lxc/lxc_driver.c @@ -3102,7 +3102,7 @@ lxcDomainAttachDeviceDiskLive(virLXCDriverPtr driver,

[libvirt] [PATCH 1/4] parallels: Resolve issues with uninitialized 'ret' value

2013-01-08 Thread John Ferlan
Added some messaging to indicate possible failure from virXPathULongLong() as well --- src/parallels/parallels_storage.c | 19 ++- 1 file changed, 14 insertions(+), 5 deletions(-) diff --git a/src/parallels/parallels_storage.c b/src/parallels/parallels_storage.c index

Re: [libvirt] [PATCH] qemu: Relax hard RSS limit

2013-01-08 Thread Dave Allan
On Tue, Jan 08, 2013 at 04:42:00PM +0100, Michal Privoznik wrote: On 08.01.2013 16:24, Daniel P. Berrange wrote: On Tue, Jan 08, 2013 at 10:37:19AM +0100, Michal Privoznik wrote: Currently, if there's no hard memory limit defined for a domain, libvirt tries to calculate one, based on domain

Re: [libvirt] [PATCH] qemu: Relax hard RSS limit

2013-01-08 Thread Michal Privoznik
On 08.01.2013 16:24, Daniel P. Berrange wrote: On Tue, Jan 08, 2013 at 10:37:19AM +0100, Michal Privoznik wrote: Currently, if there's no hard memory limit defined for a domain, libvirt tries to calculate one, based on domain definition and magic equation and set it upon the domain startup.

Re: [libvirt] [PATCH] Add Claudio Bley to the committers list

2013-01-08 Thread Claudio Bley
At Tue, 08 Jan 2013 08:30:48 -0700, Eric Blake wrote: [1 text/plain; UTF-8 (quoted-printable)] On 01/08/2013 08:15 AM, Claudio Bley wrote: Signed-off-by: Claudio Bley cb...@av-test.de --- Is this the way to do it? Yep. ACK. Thanks, pushed. Claudio -- AV-Test GmbH,

Re: [libvirt] [PATCH] qemu: Relax hard RSS limit

2013-01-08 Thread Michal Privoznik
On 08.01.2013 16:46, Dave Allan wrote: On Tue, Jan 08, 2013 at 04:42:00PM +0100, Michal Privoznik wrote: On 08.01.2013 16:24, Daniel P. Berrange wrote: On Tue, Jan 08, 2013 at 10:37:19AM +0100, Michal Privoznik wrote: Currently, if there's no hard memory limit defined for a domain, libvirt

Re: [libvirt] [PATCH 1/4] parallels: Resolve issues with uninitialized 'ret' value

2013-01-08 Thread Daniel P. Berrange
On Tue, Jan 08, 2013 at 10:40:58AM -0500, John Ferlan wrote: Added some messaging to indicate possible failure from virXPathULongLong() as well --- src/parallels/parallels_storage.c | 19 ++- 1 file changed, 14 insertions(+), 5 deletions(-) diff --git

Re: [libvirt] [PATCH 6/9] Introduce an LXC specific public API library

2013-01-08 Thread Eric Blake
On 12/21/2012 10:08 AM, Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com This patch introduces support for LXC specific public APIs. In common with what was done for QEMU, this creates a libvirt_lxc.so library and libvirt/libvirt-lxc.h header file. The actual APIs

Re: [libvirt] [PATCH v2] util: Check for NULL 'dev' on input to usbFreeDevice

2013-01-08 Thread Eric Blake
On 01/08/2013 05:45 AM, Daniel P. Berrange wrote: On Tue, Jan 08, 2013 at 07:42:26AM -0500, John Ferlan wrote: Added 'usbFreeDevice' to the useless_free_options list in cfg.mk --- cfg.mk| 1 + src/util/virusb.c | 5 +++-- 2 files changed, 4 insertions(+), 2 deletions(-) ACK

[libvirt] [PATCH RESEND] build: libvirt-guests files misplaced in specfile

2013-01-08 Thread Viktor Mihajlovski
In a non-systemd environment the post and preun scripts of libvirt-client fail, since the required files are in libvirt-daemon. Moved them to client. Doing that I noticed %{_unitdir}/libvirt-guests.service was contained in both libvirt-client and libvirt-daemon, which I don't think was intended.

Re: [libvirt] [PATCH RESEND] build: libvirt-guests files misplaced in specfile

2013-01-08 Thread Eric Blake
On 01/08/2013 09:18 AM, Viktor Mihajlovski wrote: In a non-systemd environment the post and preun scripts of libvirt-client fail, since the required files are in libvirt-daemon. Moved them to client. Doing that I noticed %{_unitdir}/libvirt-guests.service was contained in both libvirt-client

Re: [libvirt] [PATCH] BZ 657918 Default iptables setup in libvirt breaks mDNS

2013-01-08 Thread Eric Blake
On 12/12/2012 01:19 PM, Laine Stump wrote: On 12/11/2012 07:05 PM, Brian J. Murrell wrote: On 12-12-11 06:24 PM, Eric Blake wrote: Thanks! NP. Had it just lying around here anyway. :-) Comment should now mention 4 rules. Doh! Missed that in the patch port. Updated in my local copy

Re: [libvirt] [PATCH] Add RESUME event listener to qemu monitor.

2013-01-08 Thread Dave Allan
On Mon, Jan 07, 2013 at 10:44:41PM +, Daniel P. Berrange wrote: On Mon, Jan 07, 2013 at 04:25:01PM -0500, Andres Lagar-Cavilla wrote: Perform all the appropriate plumbing. When qemu/KVM VMs are paused manually through a monitor not-owned by libvirt, libvirt will think of them as

Re: [libvirt] [PATCH] BZ 657918 Default iptables setup in libvirt breaks mDNS

2013-01-08 Thread Brian J. Murrell
On 13-01-08 11:59 AM, Eric Blake wrote: I noticed this hadn't been applied yet, and was wondering if you were still planning on resubmitting this patch. Yeah, I'd definitely like to. It's just not bubbled back up to the top of the TODO list again yet. Hopefully very soon. Cheers, b.

Re: [libvirt] [PATCH v2 01/11] qemu: Introduce NBD_SERVER capability

2013-01-08 Thread Eric Blake
On 12/10/2012 12:27 PM, Michal Privoznik wrote: This just keeps track whether qemu knows nbd-server-* commands so we can use it during migration or not. --- src/qemu/qemu_capabilities.c |3 +++ src/qemu/qemu_capabilities.h |1 + 2 files changed, 4 insertions(+), 0 deletions(-) ACK.

Re: [libvirt] [PATCH 1/2] docs: break longer text into paragraphs in HTML

2013-01-08 Thread Eric Blake
On 01/08/2013 08:19 AM, Claudio Bley wrote: Libvirt's HTML documentation is not as easy to the eyes as it could be since long text has no visual breaks. Take advantage of the formatting in documentation comments and wrap each part separated by two consecutive \n into a HTML p element. Yay -

Re: [libvirt] [PATCH 2/2] docs: Limit the maximum width of info text to 75em for better readability

2013-01-08 Thread Eric Blake
On 01/08/2013 08:19 AM, Claudio Bley wrote: Signed-off-by: Claudio Bley cb...@av-test.de --- docs/libvirt.css |4 docs/newapi.xsl |6 +++--- 2 files changed, 7 insertions(+), 3 deletions(-) I'm not sure if I found a page where the rendering differed as a result of this, but

[libvirt] [PATCH v2 1/4] parallels: Resolve issues with uninitialized 'ret' value

2013-01-08 Thread John Ferlan
Added some messaging to indicate possible failure from virXPathULongLong() as well --- src/parallels/parallels_storage.c | 17 - 1 file changed, 12 insertions(+), 5 deletions(-) diff --git a/src/parallels/parallels_storage.c b/src/parallels/parallels_storage.c index

[libvirt] [PATCH v2 5/10] xen: Ignore return status for TCP_NODELAY

2013-01-08 Thread John Ferlan
--- src/xen/xend_internal.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/src/xen/xend_internal.c b/src/xen/xend_internal.c index 84a25e8..01d317c 100644 --- a/src/xen/xend_internal.c +++ b/src/xen/xend_internal.c @@ -89,11 +89,10 @@ do_connect(virConnectPtr xend)

Re: [libvirt] [PATCH] qemu: Relax hard RSS limit

2013-01-08 Thread Michal Privoznik
On 08.01.2013 16:42, Michal Privoznik wrote: On 08.01.2013 16:24, Daniel P. Berrange wrote: On Tue, Jan 08, 2013 at 10:37:19AM +0100, Michal Privoznik wrote: Currently, if there's no hard memory limit defined for a domain, libvirt tries to calculate one, based on domain definition and magic

[libvirt] virsh auto completion

2013-01-08 Thread Michal Privoznik
Going over my local git branches, I found old patch set which I was trying to get in once. Along guest IP address patches I feel like this one is desired as well and keeps returning to us from time to time. What I think this feature should look like: virsh # staTAB expands to: virsh # start

Re: [libvirt] [PATCH] Add RESUME event listener to qemu monitor.

2013-01-08 Thread Andres Lagar-Cavilla
On Jan 7, 2013, at 5:44 PM, Daniel P. Berrange berra...@redhat.com wrote: On Mon, Jan 07, 2013 at 04:25:01PM -0500, Andres Lagar-Cavilla wrote: Perform all the appropriate plumbing. When qemu/KVM VMs are paused manually through a monitor not-owned by libvirt, libvirt will think of them as

Re: [libvirt] [PATCH] Add RESUME event listener to qemu monitor.

2013-01-08 Thread Daniel P. Berrange
On Tue, Jan 08, 2013 at 01:28:10PM -0500, Andres Lagar-Cavilla wrote: On Jan 7, 2013, at 5:44 PM, Daniel P. Berrange berra...@redhat.com wrote: On Mon, Jan 07, 2013 at 04:25:01PM -0500, Andres Lagar-Cavilla wrote: Perform all the appropriate plumbing. When qemu/KVM VMs are paused

Re: [libvirt] virsh auto completion

2013-01-08 Thread Laine Stump
On 01/08/2013 01:02 PM, Michal Privoznik wrote: Going over my local git branches, I found old patch set which I was trying to get in once. Along guest IP address patches I feel like this one is desired as well and keeps returning to us from time to time. What I think this feature should

Re: [libvirt] virsh auto completion

2013-01-08 Thread Daniel P. Berrange
On Tue, Jan 08, 2013 at 07:02:00PM +0100, Michal Privoznik wrote: Going over my local git branches, I found old patch set which I was trying to get in once. Along guest IP address patches I feel like this one is desired as well and keeps returning to us from time to time. What I think

Re: [libvirt] [PATCH 0/3]add usb-net support for qemu

2013-01-08 Thread Laine Stump
On 01/03/2013 02:13 AM, Guannan Ren wrote: The set of patches fixed some typo in network docs and codes and is trying to support usb-net qemu virtual device. The following is an example for use. Libvirt XML sample: devices interface type='user' mac address='52:54:00:32:6a:91'/

Re: [libvirt] [PATCH] Add RESUME event listener to qemu monitor.

2013-01-08 Thread Andres Lagar-Cavilla
On Jan 8, 2013, at 1:30 PM, Daniel P. Berrange berra...@redhat.com wrote: On Tue, Jan 08, 2013 at 01:28:10PM -0500, Andres Lagar-Cavilla wrote: On Jan 7, 2013, at 5:44 PM, Daniel P. Berrange berra...@redhat.com wrote: On Mon, Jan 07, 2013 at 04:25:01PM -0500, Andres Lagar-Cavilla wrote:

Re: [libvirt] [PATCH 0/3]add usb-net support for qemu

2013-01-08 Thread Daniel P. Berrange
On Tue, Jan 08, 2013 at 03:03:23PM -0500, Laine Stump wrote: On 01/03/2013 02:13 AM, Guannan Ren wrote: The set of patches fixed some typo in network docs and codes and is trying to support usb-net qemu virtual device. The following is an example for use. Libvirt XML sample:

Re: [libvirt] [PATCH] Make TLS support conditional

2013-01-08 Thread Daniel P. Berrange
On Mon, Jan 07, 2013 at 05:37:30PM -0700, Eric Blake wrote: Touches quite a bit, but hopefully for the better. What platform are you targeting where you were unwilling to require gnutls as a prereq? No specific platform as such, just that if you build with --without-remote and

Re: [libvirt] [PATCH 3/3] qemu: add usb-net support

2013-01-08 Thread Laine Stump
On 01/03/2013 02:13 AM, Guannan Ren wrote: Libvirt XML sample: devices interface type='user' mac address='52:54:00:32:6a:91'/ model type='usb-net'/ alias name='net1'/ address type='usb' bus='0' port='1'/ /interface /devices qemu commandline: qemu

Re: [libvirt] [PATCH 3/3] qemu: add usb-net support

2013-01-08 Thread Daniel P. Berrange
On Tue, Jan 08, 2013 at 04:02:02PM -0500, Laine Stump wrote: On 01/03/2013 02:13 AM, Guannan Ren wrote: Libvirt XML sample: devices interface type='user' mac address='52:54:00:32:6a:91'/ model type='usb-net'/ alias name='net1'/ address type='usb'

[libvirt] [PATCH 0/3] Resolve DEADCODE errors found by Coverity

2013-01-08 Thread John Ferlan
This set of patches resolves Error: DEADCODE (CWE-561) errors found by Coverity John Ferlan (3): phyp: Remove deadcode referencing exit_status nwfilter: Remove unprivileged code path to set base tests: Remove remnants of removing the fake emulator output src/nwfilter/nwfilter_driver.c |

[libvirt] [PATCH 2/3] nwfilter: Remove unprivileged code path to set base

2013-01-08 Thread John Ferlan
Commit id f8ab364c removed ability to run this driver unprivileged. Coverity detected the check and flagged it. --- src/nwfilter/nwfilter_driver.c | 10 ++ 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/src/nwfilter/nwfilter_driver.c b/src/nwfilter/nwfilter_driver.c index

[libvirt] [PATCH 3/3] tests: Remove remnants of removing the fake emulator output

2013-01-08 Thread John Ferlan
Coverity determined that 'emulator' could no longer be set and determined the code was dead. Looking through the history, I discovered commit-id ed769e18 removed code originally added by commit-id 9237e955 and further modified by commit-id 6a7e7c4f. --- tests/qemuxml2argvtest.c | 11 ---

[libvirt] [PATCH 1/3] phyp: Remove deadcode referencing exit_status

2013-01-08 Thread John Ferlan
Remove remnants from commit id '89144534' --- src/phyp/phyp_driver.c | 4 1 file changed, 4 deletions(-) diff --git a/src/phyp/phyp_driver.c b/src/phyp/phyp_driver.c index 2dabd19..f89871f 100644 --- a/src/phyp/phyp_driver.c +++ b/src/phyp/phyp_driver.c @@ -3329,7 +3329,6 @@

[libvirt] [PATCH] virsh: add --start option to the define command

2013-01-08 Thread Doug Goldstein
I often find myself doing virsh define blah.xml; start blah. I figured adding this would be a easier^Hlazier way to do it. --- tools/virsh-domain.c | 20 ++-- 1 files changed, 18 insertions(+), 2 deletions(-) diff --git a/tools/virsh-domain.c b/tools/virsh-domain.c index

Re: [libvirt] [PATCH] Make TLS support conditional

2013-01-08 Thread Eric Blake
On 01/08/2013 01:47 PM, Daniel P. Berrange wrote: On Mon, Jan 07, 2013 at 05:37:30PM -0700, Eric Blake wrote: Touches quite a bit, but hopefully for the better. What platform are you targeting where you were unwilling to require gnutls as a prereq? No specific platform as such, just that

Re: [libvirt] [PATCH] virsh: add --start option to the define command

2013-01-08 Thread Eric Blake
On 01/08/2013 02:36 PM, Doug Goldstein wrote: I often find myself doing virsh define blah.xml; start blah. I figured adding this would be a easier^Hlazier way to do it. --- tools/virsh-domain.c | 20 ++-- 1 files changed, 18 insertions(+), 2 deletions(-) Offhand, I like

Re: [libvirt] virsh auto completion

2013-01-08 Thread Eric Blake
On 01/08/2013 11:02 AM, Michal Privoznik wrote: Going over my local git branches, I found old patch set which I was trying to get in once. Along guest IP address patches I feel like this one is desired as well and keeps returning to us from time to time. Indeed. Furthermore, we'd want a

[libvirt] [PATCH 1/2] add qemu pci-express device support

2013-01-08 Thread liguang
Signed-off-by: liguang lig.f...@cn.fujitsu.com --- src/conf/device_conf.c |8 +++- src/conf/device_conf.h |1 + src/qemu/qemu_capabilities.c | 11 +++ src/qemu/qemu_capabilities.h |1 + src/qemu/qemu_command.c |4 +++- 5 files changed, 23

[libvirt] [PATCH 0/2] add qemu machine type q35 support

2013-01-08 Thread liguang
qemu-1.3 added machine type q35, changelog said: Added Intel Q35 chipset as a new machine type, '--machine q35'. Adds PCIe support. Requires an updated SeaBIOS (bios.bin), and '-acpitable file=/seabios-path/q35-acpi-dsdt.aml' to run. so add q35 support for libvirt. src/conf/device_conf.c

[libvirt] [PATCH 2/2] build acpitable argument for qemu

2013-01-08 Thread liguang
Signed-off-by: liguang lig.f...@cn.fujitsu.com --- src/conf/domain_conf.c |1 + src/conf/domain_conf.h |1 + src/qemu/qemu_command.c |4 3 files changed, 6 insertions(+), 0 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 6a7646e..54ba77f 100644

Re: [libvirt] [PATCH 0/2] add qemu machine type q35 support

2013-01-08 Thread Doug Goldstein
On Tue, Jan 8, 2013 at 8:35 PM, liguang lig.f...@cn.fujitsu.com wrote: qemu-1.3 added machine type q35, changelog said: Added Intel Q35 chipset as a new machine type, '--machine q35'. Adds PCIe support. Requires an updated SeaBIOS (bios.bin), and '-acpitable

Re: [libvirt] [PATCH] virsh: add --start option to the define command

2013-01-08 Thread Doug Goldstein
On Tue, Jan 8, 2013 at 5:41 PM, Eric Blake ebl...@redhat.com wrote: On 01/08/2013 02:36 PM, Doug Goldstein wrote: I often find myself doing virsh define blah.xml; start blah. I figured adding this would be a easier^Hlazier way to do it. --- tools/virsh-domain.c | 20 ++--

Re: [libvirt] [PATCH 3/3] tests: Remove remnants of removing the fake emulator output

2013-01-08 Thread Eric Blake
On 01/08/2013 02:21 PM, John Ferlan wrote: Coverity determined that 'emulator' could no longer be set and determined the code was dead. Looking through the history, I discovered commit-id ed769e18 removed code originally added by commit-id 9237e955 and further modified by commit-id 6a7e7c4f.

Re: [libvirt] [PATCH 1/3] phyp: Remove deadcode referencing exit_status

2013-01-08 Thread Eric Blake
On 01/08/2013 02:21 PM, John Ferlan wrote: Remove remnants from commit id '89144534' 'git blame' points squarely to me :) --- src/phyp/phyp_driver.c | 4 1 file changed, 4 deletions(-) ACK -- Eric Blake eblake redhat com+1-919-301-3266 Libvirt virtualization library

Re: [libvirt] [PATCH 2/3] nwfilter: Remove unprivileged code path to set base

2013-01-08 Thread Eric Blake
On 01/08/2013 02:21 PM, John Ferlan wrote: Commit id f8ab364c removed ability to run this driver unprivileged. Coverity detected the check and flagged it. --- src/nwfilter/nwfilter_driver.c | 10 ++ 1 file changed, 2 insertions(+), 8 deletions(-) ACK. -- Eric Blake eblake redhat

Re: [libvirt] [PATCH 1/2] docs: break longer text into paragraphs in HTML

2013-01-08 Thread Claudio Bley
At Tue, 08 Jan 2013 09:41:40 -0700, Eric Blake wrote: [1 text/plain; UTF-8 (quoted-printable)] On 01/08/2013 08:19 AM, Claudio Bley wrote: Libvirt's HTML documentation is not as easy to the eyes as it could be since long text has no visual breaks. Take advantage of the formatting in