Re: [libvirt] [PATCH v3 01/13] libvirt.h.in: add missing documentation for virConnectCloseFunc

2013-02-01 Thread Claudio Bley
At Wed, 30 Jan 2013 21:55:37 -0700, Eric Blake wrote: [1 text/plain; UTF-8 (quoted-printable)] On 01/30/2013 08:38 AM, Claudio Bley wrote: Signed-off-by: Claudio Bley cb...@av-test.de --- include/libvirt/libvirt.h.in |9 + 1 file changed, 9 insertions(+) ACK.

Re: [libvirt] [PATCH v3 02/13] libvirt.h.in: fix documentation for virConnectDomainEventBlockJobCallback

2013-02-01 Thread Claudio Bley
At Wed, 30 Jan 2013 21:57:01 -0700, Eric Blake wrote: [1 text/plain; UTF-8 (quoted-printable)] On 01/30/2013 08:38 AM, Claudio Bley wrote: In commit 3ac26e2645e6456389a918455213d7e3824f63f9 parameter path was renamed to disk but this change was not reflected in the documentation. Oops

Re: [libvirt] [PATCH v3 03/13] libvirt.h.in: add missing return doc for virEventRemoveHandleFunc

2013-02-01 Thread Claudio Bley
At Thu, 31 Jan 2013 05:52:18 -0700, Eric Blake wrote: On 01/30/2013 08:38 AM, Claudio Bley wrote: Signed-off-by: Claudio Bley cb...@av-test.de --- include/libvirt/libvirt.h.in |2 ++ 1 file changed, 2 insertions(+) ACK. I had to go hunting for where this callback was used,

Re: [libvirt] [PATCH v3 04/13] libvirt.h.in: document virConnectDomainEventCallback's return value

2013-02-01 Thread Claudio Bley
At Thu, 31 Jan 2013 10:21:25 -0700, Eric Blake wrote: [1 text/plain; UTF-8 (quoted-printable)] On 01/30/2013 08:38 AM, Claudio Bley wrote: Signed-off-by: Claudio Bley cb...@av-test.de --- include/libvirt/libvirt.h.in |2 ++ 1 file changed, 2 insertions(+) Hmm, I wonder if

Re: [libvirt] [PATCH v3 05/13] docs: abort when missing return or argument documentation

2013-02-01 Thread Claudio Bley
At Thu, 31 Jan 2013 12:15:49 -0700, Eric Blake wrote: On 01/30/2013 08:38 AM, Claudio Bley wrote: When a function has no associated information to one of its arguments or its return type we report it and stop with an error. Signed-off-by: Claudio Bley cb...@av-test.de ---

Re: [libvirt] [PATCH v3 07/13] docs: use div, not table, for notices on opaque types

2013-02-01 Thread Claudio Bley
At Thu, 31 Jan 2013 14:55:55 -0700, Eric Blake wrote: On 01/30/2013 08:38 AM, Claudio Bley wrote: It's simpler to render and it prevents wrapping the line too early because of the table spacing, border et cetera. Signed-off-by: Claudio Bley cb...@av-test.de --- docs/libvirt.css |

Re: [libvirt] Canonical citation for Libvirt

2013-02-01 Thread Daniel P. Berrange
On Thu, Jan 31, 2013 at 10:00:35PM +, Lempereur, Brett wrote: Hi, Is there a canonical paper I can cite for Libvirt in academic publications? The best I've found so far is Bolt, M., Birkenheuer, G., Niehörster, O., Brinkmann, A. (2010). Non-Intrusive Virtualization Management using

Re: [libvirt] [sheepdog-users] [Sheepdog][Libvirt]Test boot VMs from sheepdog volumes in Libvirt

2013-02-01 Thread Gao Yongwei
2013/2/1 harryxiyou harryxi...@gmail.com Hi all, We can get Boot VMs from sheepdog volumes in Libvirt way from https://github.com/collie/sheepdog/wiki/Libvirt like following. a, prepare a file containing an XML domain description $ cat sheepdog.xml domain type='qemu'

[libvirt] [Sheepdog][Libvirt]Boot VMs from sheepdog volumes error

2013-02-01 Thread harryxiyou
Hi all, I wanna boot VMs from sheepdog volumes so i do according to https://github.com/collie/sheepdog/wiki/Libvirt However, some errors happened to me like following. $ ./virsh create os.xml error:create domain from os.xml failure error:(domain_definition):14: Premature end of data in tag

[libvirt] [PATCH v3 00/13] More refactoring of QEMU driver objects locking

2013-02-01 Thread Daniel P. Berrange
An update of https://www.redhat.com/archives/libvir-list/2013-January/msg01407.html This series does more general refactoring to help in the goal of killing the big QEMU driver lock. There are 3 key changes in this series - Isolating all QEMU configuration parameters in one struct. - Making

[libvirt] [PATCH v3 03/13] Turn virDomainObjList into an opaque virObject

2013-02-01 Thread Daniel P. Berrange
From: Daniel P. Berrange berra...@redhat.com As a step towards making virDomainObjList thread-safe turn it into an opaque virObject, preventing any direct access to its internals. As part of this a new method virDomainObjListForEach is introduced to replace all existing usage of virHashForEach

[libvirt] [PATCH v3 07/13] Remove pointless 'qemuVersion' field from virQEMUDriverPtr

2013-02-01 Thread Daniel P. Berrange
From: Daniel P. Berrange berra...@redhat.com The QEMU driver struct has a 'qemuVersion' field that was previously used to cache the version lookup from capabilities. With the recent QEMU capabilities rewrite the caching happens at a lower level so this field is pointless. Removing it avoids

[libvirt] [PATCH v3 04/13] Merge virDomainObjListIsDuplicate into virDomainObjListAdd

2013-02-01 Thread Daniel P. Berrange
From: Daniel P. Berrange berra...@redhat.com The duplicate VM checking should be done atomically with virDomainObjListAdd, so shoud not be a separate function. Instead just use flags to indicate what kind of checks are required. This pair, used in virDomainCreateXML: if

[libvirt] [PATCH v3 10/13] Convert virPCIDeviceList and virUSBDeviceList into virObjectLockable

2013-02-01 Thread Daniel P. Berrange
From: Daniel P. Berrange berra...@redhat.com To allow modifications to the lists to be synchronized, convert virPCIDeviceList and virUSBDeviceList into virObjectLockable classes. The locking, however, will not be self-contained. The users of these classes will have to call virObjectLock/Unlock in

[libvirt] [PATCH v3 13/13] Initialize qemuImageBinary path at startup

2013-02-01 Thread Daniel P. Berrange
From: Daniel P. Berrange berra...@redhat.com --- src/qemu/qemu_domain.c | 11 +++ src/qemu/qemu_driver.c | 3 +++ 2 files changed, 6 insertions(+), 8 deletions(-) diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c index cb031d8..5bf0ab0 100644 --- a/src/qemu/qemu_domain.c +++

[libvirt] [PATCH v3 05/13] Make virDomainObjList self-locking via virObjectLockable

2013-02-01 Thread Daniel P. Berrange
From: Daniel P. Berrange berra...@redhat.com Switch virDomainObjList to inherit from virObjectLockable and make all the APIs acquire/release the mutex when running. This makes virDomainObjList completely self-locking and no longer reliant on the hypervisor driver locks --- src/conf/domain_conf.c

[libvirt] [PATCH v3 06/13] Use atomic ops to increment nextvmid

2013-02-01 Thread Daniel P. Berrange
From: Daniel P. Berrange berra...@redhat.com Use atomic ops to increment nextvmid and encapsulate it in a methd to prevent accidental non-atomic access --- src/qemu/qemu_conf.c| 6 ++ src/qemu/qemu_conf.h| 2 ++ src/qemu/qemu_process.c | 4 ++-- 3 files changed, 10 insertions(+), 2

[libvirt] [PATCH v3 12/13] Introduce annotations for virQEMUDriverPtr fields

2013-02-01 Thread Daniel P. Berrange
From: Daniel P. Berrange berra...@redhat.com Annotate the fields in virQEMUDriverPtr to indicate the locking rules for their use Signed-off-by: Daniel P. Berrange berra...@redhat.com --- src/qemu/qemu_conf.h | 22 ++ 1 file changed, 22 insertions(+) diff --git

[libvirt] [PATCH v3 11/13] Protect USB/PCI device list access in QEMU with dedicated locks

2013-02-01 Thread Daniel P. Berrange
From: Daniel P. Berrange berra...@redhat.com Currently the activePciHostdevs, inactivePciHostdevsd and activeUsbHostdevs lists are all implicitly protected by the QEMU driver lock. Now that the lists all inherit from the virObjectLockable, we can make the locking explicit, removing the dependency

Re: [libvirt] [sheepdog-users] [Sheepdog][Libvirt]Test boot VMs from sheepdog volumes in Libvirt

2013-02-01 Thread harryxiyou
On Fri, Feb 1, 2013 at 6:14 PM, Gao Yongwei itx...@gmail.com wrote: [...] We can get Boot VMs from sheepdog volumes in Libvirt way from https://github.com/collie/sheepdog/wiki/Libvirt like following. a, prepare a file containing an XML domain description $ cat sheepdog.xml

Re: [libvirt] [PATCH 7/7] docs: syntax highlight code blocks using SHJS

2013-02-01 Thread Claudio Bley
At Thu, 31 Jan 2013 09:20:28 -0700, Eric Blake wrote: On 01/31/2013 02:47 AM, Claudio Bley wrote: IMO, these files are object files, as far as the GPL v3 is concerned. ,[ GPL v3 1. Source Code ] | The source code for a work means the preferred form of the work | for making

[libvirt] [PATCH] build: Add libcurl dependency to libvirt_driver.la

2013-02-01 Thread Jiri Denemark
libvirt.c calls curl_global_init() if WITH_CURL is defined and thus it should be linked with libcurl. This fixes link failure in case neither xenapi nor esx driver is enabled (they are the only users of libcurl). --- src/Makefile.am | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-)

[libvirt] [PATCH] spec: Fix minor changelog issues

2013-02-01 Thread Jiri Denemark
When a changelog entry references an RPM macro, % needs to be escaped so that it does not appear expanded in package changelog. Wed Jul 5 2011 is incorrect since Jul 5 was Tuesday. Let's suppose it was a result of incomplete update (Tue - Wed) and change Jul 5 to Jul 6. --- libvirt.spec.in | 4

Re: [libvirt] [PATCH v3 06/13] docs: only generate function argument info for args with a description

2013-02-01 Thread Claudio Bley
At Thu, 31 Jan 2013 13:41:10 -0700, Eric Blake wrote: On 01/30/2013 08:38 AM, Claudio Bley wrote: When function arguments or return values lack a description there's no use in generating a meaningless ARG1: stanza. Can you point to an example of an argument lacking a description? Have

Re: [libvirt] [PATCH] spec: Fix minor changelog issues

2013-02-01 Thread Jiri Denemark
On Fri, Feb 01, 2013 at 13:45:01 +0100, Jiri Denemark wrote: When a changelog entry references an RPM macro, % needs to be escaped so that it does not appear expanded in package changelog. Wed Jul 5 2011 is incorrect since Jul 5 was Tuesday. Let's suppose it was a result of incomplete update

[libvirt] [PATCH v2] spec: Fix minor changelog issues

2013-02-01 Thread Jiri Denemark
When a changelog entry references an RPM macro, % needs to be escaped so that it does not appear expanded in package changelog. Fri Mar 4 2009 is incorrect since Mar 4 was Wednesday. Since libvirt-0.6.1 was released on Mar 4 2009, we should change Fri to Wed. --- libvirt.spec.in | 4 ++-- 1

Re: [libvirt] [PATCH v3 13/13] Initialize qemuImageBinary path at startup

2013-02-01 Thread Jiri Denemark
On Fri, Feb 01, 2013 at 11:18:35 +, Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com --- src/qemu/qemu_domain.c | 11 +++ src/qemu/qemu_driver.c | 3 +++ 2 files changed, 6 insertions(+), 8 deletions(-) diff --git a/src/qemu/qemu_domain.c

Re: [libvirt] [PATCH v3 06/13] docs: only generate function argument info for args with a description

2013-02-01 Thread Claudio Bley
At Fri, 01 Feb 2013 13:48:45 +0100, Claudio Bley wrote: At Thu, 31 Jan 2013 13:41:10 -0700, Eric Blake wrote: On 01/30/2013 08:38 AM, Claudio Bley wrote: When function arguments or return values lack a description there's no use in generating a meaningless ARG1: stanza. Can

[libvirt] [libvirt-php PATCH 1/1] Fix: mutlithreading compilation: set_error needs 2 params

2013-02-01 Thread stefan . kuhn
--- src/libvirt-php.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/src/libvirt-php.c b/src/libvirt-php.c index 7e7710c..0b8345a 100644 --- a/src/libvirt-php.c +++ b/src/libvirt-php.c @@ -1615,7 +1615,7 @@ PHP_FUNCTION(libvirt_node_get_cpu_stats) #else

[libvirt] [libvirt-php PATCH 0/1] Fix: mutlithreading compilation: set_error needs 2 params

2013-02-01 Thread stefan . kuhn
= Info = Someone reports errors withing PHP_FUNCTION(libvirt_domain_migrate) due to set_error: libvirt-php.c: In function ‘zif_libvirt_domain_migrate’: libvirt-php.c:5456:3: error: too few arguments to function ‘set_error’ = Background = Michal Novotny already reacted to Gentoos bug: Bug 437624

Re: [libvirt] This patch adds the label to lxc-enter-namespace

2013-02-01 Thread Daniel J Walsh
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 01/25/2013 02:39 PM, Daniel J Walsh wrote: (2nd pass) lxc-enter-namespace allows a process from outside a container to start a process inside a container. One problem with the current code is the process running within the container

[libvirt] These patches needed to mount the securityfs in containers.

2013-02-01 Thread Daniel J Walsh
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Simple patch to make sure /sys/kernel/security is mounted inside the container. Systemd attempts to use/mount this file system if it is not present. One of these days I will figure out how to merge patches. securityfs has to be mounted after

Re: [libvirt] This patch adds the label to lxc-enter-namespace

2013-02-01 Thread Daniel P. Berrange
On Fri, Jan 25, 2013 at 02:39:25PM -0500, Daniel J Walsh wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 (2nd pass) lxc-enter-namespace allows a process from outside a container to start a process inside a container. One problem with the current code is the process running

Re: [libvirt] These patches needed to mount the securityfs in containers.

2013-02-01 Thread Daniel P. Berrange
On Fri, Feb 01, 2013 at 11:19:49AM -0500, Daniel J Walsh wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Simple patch to make sure /sys/kernel/security is mounted inside the container. Systemd attempts to use/mount this file system if it is not present. One of these days I

Re: [libvirt] [PATCH] maint: update to latest gnulib

2013-02-01 Thread Eric Blake
On 02/01/2013 12:16 AM, Jiri Denemark wrote: On Thu, Jan 31, 2013 at 16:34:24 -0700, Eric Blake wrote: CVE-2013-0242 in glibc's regex() can cause a DoS in any daemon that runs a regex search on user input while in a multibyte locale. I'm not sure how hard it would be to trigger such a setup

Re: [libvirt] [Sheepdog][Libvirt]Boot VMs from sheepdog volumes error

2013-02-01 Thread Eric Blake
On 02/01/2013 04:08 AM, harryxiyou wrote: Hi all, I wanna boot VMs from sheepdog volumes so i do according to https://github.com/collie/sheepdog/wiki/Libvirt However, some errors happened to me like following. $ ./virsh create os.xml error:create domain from os.xml failure

Re: [libvirt] [PATCH v2] spec: Fix minor changelog issues

2013-02-01 Thread Eric Blake
On 02/01/2013 05:53 AM, Jiri Denemark wrote: When a changelog entry references an RPM macro, % needs to be escaped so that it does not appear expanded in package changelog. Fri Mar 4 2009 is incorrect since Mar 4 was Wednesday. Since libvirt-0.6.1 was released on Mar 4 2009, we should

Re: [libvirt] [PATCH v2] spec: Fix minor changelog issues

2013-02-01 Thread Daniel P. Berrange
On Fri, Feb 01, 2013 at 10:06:28AM -0700, Eric Blake wrote: On 02/01/2013 05:53 AM, Jiri Denemark wrote: When a changelog entry references an RPM macro, % needs to be escaped so that it does not appear expanded in package changelog. Fri Mar 4 2009 is incorrect since Mar 4 was Wednesday.

Re: [libvirt] [Sheepdog][Libvirt]Boot VMs from sheepdog volumes error

2013-02-01 Thread harryxiyou
On Sat, Feb 2, 2013 at 12:49 AM, Eric Blake ebl...@redhat.com wrote: On 02/01/2013 04:08 AM, harryxiyou wrote: Hi all, I wanna boot VMs from sheepdog volumes so i do according to https://github.com/collie/sheepdog/wiki/Libvirt However, some errors happened to me like following. $ ./virsh

Re: [libvirt] [PATCH v3 06/13] docs: only generate function argument info for args with a description

2013-02-01 Thread Eric Blake
On 02/01/2013 05:48 AM, Claudio Bley wrote: The point is, we skip checking all functions contained in the ignored_functions dictionary in apibuild.py. We would have to do the same filtering inside the stylesheet also. But why bother? We never get to XSL processing when apibuild.py fails

[libvirt] [PATCH 4/9 v2] Implement translateDiskSourcePool

2013-02-01 Thread Osier Yang
It iterates over all the domain disks, and translate the source of all the disks of 'volume' type from storage pool/volume to the real underlying source. Disks of type 'file', 'block', and 'dir' are supported now. Network type is not supported yet, it will be another patch.

Re: [libvirt] [sheepdog-users] [Sheepdog][Libvirt]Test boot VMs from sheepdog volumes in Libvirt

2013-02-01 Thread Gao Yongwei
2013/2/1 harryxiyou harryxi...@gmail.com On Fri, Feb 1, 2013 at 6:14 PM, Gao Yongwei itx...@gmail.com wrote: [...] We can get Boot VMs from sheepdog volumes in Libvirt way from https://github.com/collie/sheepdog/wiki/Libvirt like following. a, prepare a file containing an XML domain

Re: [libvirt] persistent virtual networks

2013-02-01 Thread Serge Hallyn
Quoting Gene Czarcinski (g...@czarc.net): I seem to remember that, if you use net-define, the network will be persistent and, if you use net-create, the network will not be persistent. I am now running libvirt-1.0.2 on Fedora 18. When I use net-define a network from a template and then do

[libvirt] [PATCH 9/9 v2] Support network pool for volume disk

2013-02-01 Thread Osier Yang
The only two network pools we supported are rbd and sheepdog, and attributes socket, transport are not supported in storage pool conf yet, this uses the default setting (TCP for 'transport', and socket is not set) temporarily. Future patches will extend the storage pool conf to support 'transport'

Re: [libvirt] [PATCH] complete virterror-virerror name change

2013-02-01 Thread Serge Hallyn
Quoting Eric Blake (ebl...@redhat.com): On 01/30/2013 08:05 PM, Serge Hallyn wrote: Without these two string changes in generator.py, the virGetLastError wrapper does not get created in /usr/share/pyshared/libvirt.py. Noticed when running tests with virt-install. Signed-off-by:

Re: [libvirt] [PATCH v3 01/13] Introduce a virQEMUDriverConfigPtr object

2013-02-01 Thread Jiri Denemark
On Fri, Feb 01, 2013 at 11:18:23 +, Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com Currently the virQEMUDriverPtr struct contains an wide variety of data with varying access needs. Move all the static config data into a dedicated virQEMUDriverConfigPtr object. The

Re: [libvirt] [PATCH v3 02/13] Rename all domain list APIs to have virDomainObjList prefix

2013-02-01 Thread Jiri Denemark
On Fri, Feb 01, 2013 at 11:18:24 +, Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com The APIs names for accessing the domain list object are very inconsistent. Rename them all to have a standard virDomainObjList prefix. --- src/conf/domain_conf.c| 156

Re: [libvirt] [PATCH] complete virterror-virerror name change

2013-02-01 Thread Eric Blake
On 02/01/2013 12:55 PM, Serge Hallyn wrote: Quoting Eric Blake (ebl...@redhat.com): On 01/30/2013 08:05 PM, Serge Hallyn wrote: Without these two string changes in generator.py, the virGetLastError wrapper does not get created in /usr/share/pyshared/libvirt.py. Noticed when running tests

[libvirt] [PATCH V2 3/3] Add support for file descriptor sets

2013-02-01 Thread Stefan Berger
Add support for file descriptor sets by converting some of the command line parameters to use /dev/fdset/%d if -add-fd is found to be supported by QEMU. For those devices libvirt now open()s the device to obtain the file descriptor and 'transfers' the fd using virCommand. For the following

[libvirt] [PATCH V2 0/3] Add support for QEMU file descriptor sets

2013-02-01 Thread Stefan Berger
The following patch series adds initial support for QEMU file descriptor sets implementing support for creating the proper command line. Some devices are using the sets now. Regards, Stefan -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

[libvirt] [PATCH V2 2/3] Add a file descriptor set to QEMU private domain struct

2013-02-01 Thread Stefan Berger
Add a file descriptor set to the QEMU private domain structure. Stefan Berger stef...@linux.vnet.ibm.com --- src/qemu/qemu_domain.c |9 - src/qemu/qemu_domain.h |3 +++ 2 files changed, 11 insertions(+), 1 deletion(-) Index: libvirt/src/qemu/qemu_domain.c

Re: [libvirt] [PATCH V2 1/3] Add function to find and set next available bit

2013-02-01 Thread Eric Blake
On 02/01/2013 02:57 PM, Stefan Berger wrote: Add function to find the next available bit in the bitmap and set it. Signed-off-by: Stefan Berger stef...@linux.vnet.ibm.com --- src/libvirt_private.syms |1 + src/util/virbitmap.c | 34 ++

[libvirt] [PATCH V2 1/3] Add function to find and set next available bit

2013-02-01 Thread Stefan Berger
Add function to find the next available bit in the bitmap and set it. Signed-off-by: Stefan Berger stef...@linux.vnet.ibm.com --- src/libvirt_private.syms |1 + src/util/virbitmap.c | 34 ++ src/util/virbitmap.h |3 +++ 3 files changed, 38

Re: [libvirt] [PATCH] docs: don't ignore virEvent API

2013-02-01 Thread Osier Yang
On 2013年02月02日 07:04, Eric Blake wrote: Commit 6094ad7b (0.9.3 release) promoted several functions from internal to public, but forgot to fix the documentation generator to provide details about those functions. For an example of what this fixes, look at:

[libvirt] [PATCH] bitmap: add way to find next clear bit

2013-02-01 Thread Eric Blake
We had an easy way to iterate set bits, but not for iterating cleared bits. * src/util/virbitmap.h (virBitmapNextClearBit): New prototype. * src/util/virbitmap.c (virBitmapNextClearBit): Implement it. * src/libvirt_private.syms (bitmap.h): Export it. * tests/virbitmaptest.c (test4): Test it. ---

Re: [libvirt] [PATCH] docs: don't ignore virEvent API

2013-02-01 Thread Eric Blake
On 02/01/2013 07:13 PM, Osier Yang wrote: On 2013年02月02日 07:04, Eric Blake wrote: Commit 6094ad7b (0.9.3 release) promoted several functions from internal to public, but forgot to fix the documentation generator to provide details about those functions. For an example of what this fixes,

Re: [libvirt] [PATCH] bitmap: add way to find next clear bit

2013-02-01 Thread Stefan Berger
On 02/01/2013 09:16 PM, Eric Blake wrote: We had an easy way to iterate set bits, but not for iterating cleared bits. * src/util/virbitmap.h (virBitmapNextClearBit): New prototype. * src/util/virbitmap.c (virBitmapNextClearBit): Implement it. * src/libvirt_private.syms (bitmap.h): Export it. *