Re: [libvirt] [PATCH] remote: Prevent race when closing a connection

2013-03-15 Thread Viktor Mihajlovski
On 03/15/2013 10:33 AM, Daniel P. Berrange wrote: No, this really isn't solving the problem. The virConnectDipose function is the last thing to run on an object. Once virConnectDispose is running absolutely nothing else may safely use that object pointer. The thread that is not in virConnectDisp

Re: [libvirt] [libvirt-sandbox][PATCH] Avoid infinite loop in gvir_sandbox_config_set_security_opts()

2013-03-15 Thread Alex Jia
On 03/15/2013 05:44 PM, Daniel P. Berrange wrote: On Fri, Mar 15, 2013 at 05:32:24PM +0800, Alex Jia wrote: Signed-off-by: Alex Jia --- libvirt-sandbox/libvirt-sandbox-config.c |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/libvirt-sandbox/libvirt-sandbox-config.c

Re: [libvirt] [libvirt-sandbox][PATCH] Avoid infinite loop in gvir_sandbox_config_set_security_opts()

2013-03-15 Thread Daniel P. Berrange
On Fri, Mar 15, 2013 at 05:32:24PM +0800, Alex Jia wrote: > > Signed-off-by: Alex Jia > --- > libvirt-sandbox/libvirt-sandbox-config.c |3 +++ > 1 files changed, 3 insertions(+), 0 deletions(-) > > diff --git a/libvirt-sandbox/libvirt-sandbox-config.c > b/libvirt-sandbox/libvirt-sandbox-co

Re: [libvirt] [PATCH 3/4] remove the redundant codes

2013-03-15 Thread Daniel P. Berrange
On Fri, Mar 15, 2013 at 05:03:47PM +0800, Osier Yang wrote: > >diff --git a/src/util/virnuma.h b/src/util/virnuma.h > >index b9046c2..8d9f14d 100644 > >--- a/src/util/virnuma.h > >+++ b/src/util/virnuma.h > >@@ -22,7 +22,31 @@ > > #ifndef __VIR_NUMA_H__ > > # define __VIR_NUMA_H__ > > > >+#includ

Re: [libvirt] [PATCHv2 1/1] Remove contiguous CPU indexes assumption

2013-03-15 Thread Daniel P. Berrange
On Fri, Mar 15, 2013 at 05:25:09PM +0800, Li Zhang wrote: > From: Li Zhang > > When getting CPUs' information, it assumes that CPU indexes > are not contiguous. But for ppc64 platform, CPU indexes are not > contiguous because SMT is needed to be disabled, so CPU information > is not right on ppc6

Re: [libvirt] [PATCH 1/4] rename qemuGetNumadAdvice to virGetNumadAdvice

2013-03-15 Thread Daniel P. Berrange
On Fri, Mar 15, 2013 at 04:13:30PM +0800, Osier Yang wrote: > On 2013年03月01日 14:52, Gao feng wrote: > >qemuGetNumadAdvice will be used by LXC driver,rename > >it to virGetNumaAdvice and move it to virnuma.c > > s/virGetNumaAdvice/virGetNumadAdvice/, > > >diff --git a/src/util/virnuma.h b/src/util

Re: [libvirt] [PATCH] remote: Prevent race when closing a connection

2013-03-15 Thread Daniel P. Berrange
On Thu, Mar 14, 2013 at 01:26:55PM +0100, Viktor Mihajlovski wrote: > A race condition can occur when virConnectClose is called parallel > to the execution of the connection close callback in remoteClientCloseFunc. > > The race happens if the connection object is destroyed (including > the mutex)

[libvirt] [libvirt-sandbox][PATCH] Avoid infinite loop in gvir_sandbox_config_set_security_opts()

2013-03-15 Thread Alex Jia
Signed-off-by: Alex Jia --- libvirt-sandbox/libvirt-sandbox-config.c |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/libvirt-sandbox/libvirt-sandbox-config.c b/libvirt-sandbox/libvirt-sandbox-config.c index 90217f1..f96d417 100644 --- a/libvirt-sandbox/libvirt-sandbox

Re: [libvirt] [PATCH] Update to COPYING.LIB to latest LGPLv2.1 copy

2013-03-15 Thread Daniel P. Berrange
On Fri, Mar 15, 2013 at 10:08:37AM +0100, Christophe Fergeau wrote: > Ping? > > On Mon, Mar 11, 2013 at 12:43:13PM +0100, Christophe Fergeau wrote: > > The text version > > of LGPLv2.1 available at > > http://www.gnu.org/licenses/old-licenses/lgpl-2.1.txt is slightly > > different from COPYING.LIB

Re: [libvirt] [libvirt-sandbox][PATCH] Docs: fix typos in IPv6 address

2013-03-15 Thread Alex Jia
On 03/15/2013 04:02 PM, Osier Yang wrote: On 2013年03月15日 15:23, Alex Jia wrote: Signed-off-by: Alex Jia --- bin/virt-sandbox.c |2 +- libvirt-sandbox/libvirt-sandbox-config.c |2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/bin/virt-sandbox

Re: [libvirt] [PATCH 4/4] LXC: add cpuset cgroup support for lxc

2013-03-15 Thread Osier Yang
On 2013年03月01日 14:52, Gao feng wrote: This patch adds cpuset cgroup support for LXC. also set cpuset cgroup before setting cpu affinity and numa policy. Any special reason to move lxcSetupCgroup before the CPU affinity and NUMA setttings? Signed-off-by: Gao feng --- src/lxc/lxc_cgroup.c

[libvirt] [PATCHv2 1/1] Remove contiguous CPU indexes assumption

2013-03-15 Thread Li Zhang
From: Li Zhang When getting CPUs' information, it assumes that CPU indexes are not contiguous. But for ppc64 platform, CPU indexes are not contiguous because SMT is needed to be disabled, so CPU information is not right on ppc64 and vpuinfo, vcpupin can't work corretly. This patch is to remove t

Re: [libvirt] [PATCHv2 2/2] Add USB option capability

2013-03-15 Thread Li Zhang
On 2013年03月15日 17:19, Li Zhang wrote: From: Li Zhang To avoid the collision for creating USB controllers in machine->init() and -device xx command line, it needs to set usb=off to avoid one USB controller created in machine->init(). So that libvirt can use -device or -usb to create USB controll

[libvirt] [PATCHv2 1/2] Optimize machine option to set more options with it.

2013-03-15 Thread Li Zhang
From: Li Zhang Currently, -machine option is used only when dump-guest-core is set. To use options defined in machine option for newer version of QEMU, it needs to use -machine xxx, and to be compatible with older version -M, this patch addes QEMU_CAPS_MACHINE_OPT capability for newer versio

[libvirt] [PATCHv2 2/2] Add USB option capability

2013-03-15 Thread Li Zhang
From: Li Zhang To avoid the collision for creating USB controllers in machine->init() and -device xx command line, it needs to set usb=off to avoid one USB controller created in machine->init(). So that libvirt can use -device or -usb to create USB controller sucessfully. So QEMU_CAPS_MACHINE_USB

Re: [libvirt] [PATCH V1 4/6] Add SELinux labeling support for TPM

2013-03-15 Thread Daniel P. Berrange
On Thu, Mar 14, 2013 at 08:00:21PM -0400, Stefan Berger wrote: > On 03/14/2013 06:34 PM, Daniel P. Berrange wrote: > >On Thu, Mar 14, 2013 at 04:24:27PM -0400, Stefan Berger wrote: > >>On 03/14/2013 10:29 AM, Daniel P. Berrange wrote: > >>>On Wed, Mar 13, 2013 at 12:03:52PM -0400, Stefan Berger wro

Re: [libvirt] [[PATCHv2]] Add support for qxl.revision in domain XML

2013-03-15 Thread Christophe Fergeau
ping? On Thu, Feb 21, 2013 at 04:49:53PM +0100, Christophe Fergeau wrote: > QXL devices have an associated 'revision' which is raised when > new features have been introduced which would break migration > to older versions. This commit makes it possible to set this > revision as QEMU sometimes sup

Re: [libvirt] [PATCH] Update to COPYING.LIB to latest LGPLv2.1 copy

2013-03-15 Thread Christophe Fergeau
Ping? On Mon, Mar 11, 2013 at 12:43:13PM +0100, Christophe Fergeau wrote: > The text version > of LGPLv2.1 available at > http://www.gnu.org/licenses/old-licenses/lgpl-2.1.txt is slightly > different from COPYING.LIB: > - several paragraphs were rewrapped > - the FSF address has changed, so the li

Re: [libvirt] [PATCH 3/4] remove the redundant codes

2013-03-15 Thread Osier Yang
On 2013年03月01日 14:52, Gao feng wrote: Intend to reduce the redundant code,use virSetupNumaMemoryPolicy to replace virLXCControllerSetupNUMAPolicy and qemuProcessInitNumaMemoryPolicy. Signed-off-by: Gao feng --- src/conf/domain_conf.h | 23 + src/libvirt_private.syms | 1 + src/l

Re: [libvirt] [PATCHv3 3/3] S390: Testcases for virtio-scsi and virtio-rng

2013-03-15 Thread Viktor Mihajlovski
On 03/14/2013 11:05 PM, Eric Blake wrote: ACK, and pushed. Big thanks, again. -- Mit freundlichen Grüßen/Kind Regards Viktor Mihajlovski IBM Deutschland Research & Development GmbH Vorsitzender des Aufsichtsrats: Martina Köderitz Geschäftsführung: Dirk Wittkopp Sitz der Gesellschaft: Böb

Re: [libvirt] [PATCH 2/4] LXC: allow uses advisory nodeset from querying numad

2013-03-15 Thread Osier Yang
On 2013年03月01日 14:52, Gao feng wrote: Allow lxc using the advisory nodeset from querying numad, this means if user doesn't specify the numa nodes that the lxc domain should assign to, libvirt will automatically bind the lxc domain to the advisory nodeset which queried from numad. Signed-off-by:

Re: [libvirt] [PATCH] remote: Prevent race when closing a connection

2013-03-15 Thread Viktor Mihajlovski
On 03/15/2013 12:28 AM, Eric Blake wrote: -if (conn->closeFreeCallback) +if (conn->closeCallback) +conn->closeCallback = NULL; The if is pointless. Just blindly set conn->closeCallback to NULL. agreed + +if (conn->closeFreeCallback) { conn->closeFreeCallback(co

Re: [libvirt] [PATCH 1/4] rename qemuGetNumadAdvice to virGetNumadAdvice

2013-03-15 Thread Osier Yang
On 2013年03月01日 14:52, Gao feng wrote: qemuGetNumadAdvice will be used by LXC driver,rename it to virGetNumaAdvice and move it to virnuma.c s/virGetNumaAdvice/virGetNumadAdvice/, Signed-off-by: Gao feng --- po/POTFILES.in | 1 + src/Makefile.am | 1 + src/libvirt_priv

Re: [libvirt] [PATCHv3] audit: Audit resources used by VirtIO RNG

2013-03-15 Thread Peter Krempa
On 03/13/13 11:21, Daniel P. Berrange wrote: On Wed, Mar 13, 2013 at 10:46:24AM +0100, Peter Krempa wrote: This patch adds auditing of resources used by Virtio RNG devices. Only resources on the local filesystems are audited. The audit logs look like: For the 'random' backend: type=VIRT_RESOUR

[libvirt] [PATCH v2 1/2] json: add stream parser

2013-03-15 Thread Dmitry Guryanov
Add function virJSONValueFromStream, which reads data from a stream and passes it to json parser. When end of the object is reached, it returns this object. To avoid reading from the stream by single bytes it reads to a buffer (in a structure virJSONStreamParserState), which should be passed to a c

[libvirt] [PATCH v2 2/2] json: add test for virJSONValueFromStream function

2013-03-15 Thread Dmitry Guryanov
Signed-off-by: Dmitry Guryanov --- tests/jsontest.c | 205 - 1 files changed, 201 insertions(+), 4 deletions(-) diff --git a/tests/jsontest.c b/tests/jsontest.c index 98a6069..107d772 100644 --- a/tests/jsontest.c +++ b/tests/jsontest.c @@ -4

Re: [libvirt] [libvirt-sandbox][PATCH] Docs: fix typos in IPv6 address

2013-03-15 Thread Osier Yang
On 2013年03月15日 15:23, Alex Jia wrote: Signed-off-by: Alex Jia --- bin/virt-sandbox.c |2 +- libvirt-sandbox/libvirt-sandbox-config.c |2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/bin/virt-sandbox.c b/bin/virt-sandbox.c index 9becd07..69d1

Re: [libvirt] [PATCH] Fix a copy&paste error for virsh dump help

2013-03-15 Thread Osier Yang
On 2013年03月15日 15:40, Yanbing Du wrote: Signed-off-by: Yanbing Du --- tools/virsh-domain.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/tools/virsh-domain.c b/tools/virsh-domain.c index ab90f58..aa45e72 100644 --- a/tools/virsh-domain.c +++ b/tools/virsh-domain.c @

[libvirt] [PATCH] Fix a copy&paste error for virsh dump help

2013-03-15 Thread Yanbing Du
Signed-off-by: Yanbing Du --- tools/virsh-domain.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/tools/virsh-domain.c b/tools/virsh-domain.c index ab90f58..aa45e72 100644 --- a/tools/virsh-domain.c +++ b/tools/virsh-domain.c @@ -4358,7 +4358,7 @@ static const vshCmdOpt

[libvirt] [libvirt-sandbox][PATCH] Docs: fix typos in IPv6 address

2013-03-15 Thread Alex Jia
Signed-off-by: Alex Jia --- bin/virt-sandbox.c |2 +- libvirt-sandbox/libvirt-sandbox-config.c |2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/bin/virt-sandbox.c b/bin/virt-sandbox.c index 9becd07..69d1e62 100644 --- a/bin/virt-sandbox.c +++ b/

<    1   2