Re: [libvirt] patch request

2013-04-17 Thread Thierry Parmentelat
Hi again Just making sure that I captured that one right Are you saying that the core of the problem (the python bindings) has been fixed after 1.0.4 was released ? Because I have built 1.0.4 as-is and this still exhibits the issue (global name 'virGetLastError' is not defined), so as far as

Re: [libvirt] [PATCHv2 4/6] API: Introduce VIR_DOMAIN_VCPU_AGENT, for agent based CPU hot(un)plug

2013-04-17 Thread Peter Krempa
On 04/16/13 19:41, Daniel P. Berrange wrote: On Tue, Apr 16, 2013 at 04:00:10PM +0200, Peter Krempa wrote: This flag will allow to use qemu guest agent commands to disable (offline) and enable (online) processors in a live guest that has the guest agent running. How do guest CPU

[libvirt] [libvirt-glib] Fix year in NEWS

2013-04-17 Thread Christophe Fergeau
We switched from 2012 to 2013!! --- I've pushed this under the trivial rule. Christophe NEWS | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/NEWS b/NEWS index b5f0c84..b1f4a80 100644 --- a/NEWS +++ b/NEWS @@ -1,7 +1,7 @@ libvirt-glib News

Re: [libvirt] new libvirt pci controller type and pcie/q35 (was Re: [PATCH 4/7] add pci-bridge controller type)

2013-04-17 Thread Michael S. Tsirkin
On Tue, Apr 16, 2013 at 12:05:40PM -0400, Laine Stump wrote: On 04/15/2013 05:58 PM, Michael S. Tsirkin wrote: On Mon, Apr 15, 2013 at 11:27:03AM -0600, Alex Williamson wrote: On Fri, 2013-04-12 at 11:46 -0400, Laine Stump wrote: On 04/11/2013 07:23 AM, Michael S. Tsirkin wrote: On Thu,

Re: [libvirt] new libvirt pci controller type and pcie/q35 (was Re: [PATCH 4/7] add pci-bridge controller type)

2013-04-17 Thread Michael S. Tsirkin
On Tue, Apr 16, 2013 at 12:35:29PM -0400, Laine Stump wrote: On 04/15/2013 06:14 PM, Don Dutile wrote: On 04/15/2013 04:09 PM, Laine Stump wrote: On 04/15/2013 06:29 AM, Daniel P. Berrange wrote: On Fri, Apr 12, 2013 at 11:46:15AM -0400, Laine Stump wrote: On 04/11/2013 07:23 AM, Michael

Re: [libvirt] [PATCH 01/10] cleanup: Remove the duplicate header

2013-04-17 Thread Osier Yang
On 17/04/13 10:50, Eric Blake wrote: On 04/16/2013 07:41 AM, Osier Yang wrote: Detected by a simple Shell script: for i in $(find -type f -name *.[ch] | grep -v gnulib); do You can limit things to version-controlled files a bit faster with: for i in $(git ls-files -- '*.[ch]'); do Nice.

Re: [libvirt] [PATCH 04/10] cleanup: Don't include libvirt/virterror.h

2013-04-17 Thread Osier Yang
On 17/04/13 11:16, Eric Blake wrote: On 04/16/2013 07:41 AM, Osier Yang wrote: Which is already included in internal.h, later patch will add syntax-check to avoid it. --- src/remote/remote_driver.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/remote/remote_driver.h

[libvirt] [libvirt-glib] object: Add transfer none annotation to argv parameter

2013-04-17 Thread Christophe Fergeau
This makes the parameter to be passed unowned in Vala. This was previously done using a vala metadata file, but it's better to do it directly through a gtk-doc annotation, as this means the gir file will know about this, and thus any gir-based binding can make use of this info. This also makes

Re: [libvirt] [libvirt-designer 0/9] Handle more devices in GVirDesignerDomain

2013-04-17 Thread Christophe Fergeau
Apart from danpb's comment in patch #3 which I've fixed locally, any more feedback/review on this series? Christophe On Wed, Apr 03, 2013 at 11:37:59AM +0200, Christophe Fergeau wrote: This series builds on the previous one (the one adding gvir_designer_domain_get_supported_devices()). It adds

[libvirt] [PATCH 0/2] Fix forgetting of transient networks on daemon restart

2013-04-17 Thread Peter Krempa
Peter Krempa (2): network: remove autostart flag from network when undefining it network: bridge_driver: don't lose transient networks on daemon restart src/conf/network_conf.c | 220 +--- src/conf/network_conf.h | 10 +-

[libvirt] [PATCH 1/2] network: remove autostart flag from network when undefining it

2013-04-17 Thread Peter Krempa
When turning a started persistent network into a transient one we forgot to remove the autostart flag that is no longer valid at that point. --- src/network/bridge_driver.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/network/bridge_driver.c b/src/network/bridge_driver.c index

[libvirt] [PATCH 2/2] network: bridge_driver: don't lose transient networks on daemon restart

2013-04-17 Thread Peter Krempa
Until now tranisent networks weren't really useful as libvirtd wasn't able to remember them across restarts. This patch adds support for loading status files of transient networks (that already were generated) so that the status isn't lost. This patch chops up virNetworkObjUpdateParseFile and

Re: [libvirt] [PATCHv2 4/6] API: Introduce VIR_DOMAIN_VCPU_AGENT, for agent based CPU hot(un)plug

2013-04-17 Thread Daniel P. Berrange
On Wed, Apr 17, 2013 at 08:47:01AM +0200, Peter Krempa wrote: On 04/16/13 19:41, Daniel P. Berrange wrote: On Tue, Apr 16, 2013 at 04:00:10PM +0200, Peter Krempa wrote: This flag will allow to use qemu guest agent commands to disable (offline) and enable (online) processors in a live guest

Re: [libvirt] patch request

2013-04-17 Thread Daniel P. Berrange
On Wed, Apr 17, 2013 at 08:14:15AM +0200, Thierry Parmentelat wrote: Hi again Just making sure that I captured that one right Are you saying that the core of the problem (the python bindings) has been fixed after 1.0.4 was released ? Because I have built 1.0.4 as-is and this still

Re: [libvirt] [PATCH 1/2] cpu-max: Implement cpu-max attribute into capabilities XML output

2013-04-17 Thread Daniel P. Berrange
On Wed, Apr 17, 2013 at 03:21:04AM +0200, Michal Novotny wrote: Implement the cpu-max attribute into virConnectGetCapabilities() API output to allow caller to check maximum number of CPUs to be set for specified machine type. Signed-off-by: Michal Novotny minov...@redhat.com ---

Re: [libvirt] [PATCH 1/2] cpu-max: Implement cpu-max attribute into capabilities XML output

2013-04-17 Thread Michal Novotny
On 04/17/2013 11:25 AM, Daniel P. Berrange wrote: On Wed, Apr 17, 2013 at 03:21:04AM +0200, Michal Novotny wrote: Implement the cpu-max attribute into virConnectGetCapabilities() API output to allow caller to check maximum number of CPUs to be set for specified machine type. Signed-off-by:

[libvirt] (no subject)

2013-04-17 Thread David Scott
Hi, I've made an improved set of ocaml bindings for the libvirt event mechanism which I'm now reasonably happy with. Improvements since my first submission: 1. it's possible to deregister callbacks with 'deregister_any' 2. the callback to ocaml now re-acquires the heap lock *before* creating

[libvirt] [PATCH 1/3] Add binding for virConnectSetKeepAlive

2013-04-17 Thread David Scott
This one is a 'one-off' but it ought to be possible to use the generator to create the function (it has signature 'conn, int, int : int') This function first appeared in libvirt version 0.9.8. Signed-off-by: David Scott dave.sc...@eu.citrix.com --- config.h.in | 3 +++

[libvirt] [PATCH 3/3] Add a simple example to show how to receive event callbacks

2013-04-17 Thread David Scott
Signed-off-by: David Scott dave.sc...@eu.citrix.com --- .gitignore| 1 + Makefile.in | 1 + examples/.depend | 14 +++-- examples/Makefile.in | 13 - examples/domain_events.ml | 145 ++ 5 files

[libvirt] [PATCH 2/3] Add event callback implementation based on virConnectDomainEventRegisterAny

2013-04-17 Thread David Scott
A client may register a callback as follows: E.register_default_impl (); let conn = C.connect_readonly ?name () in let id = E.register_any conn (E.Lifecycle (fun dom e - printd dom Lifecycle %s (E.Lifecycle.to_string e) )) in Internally this will: 1. generate a unique

[libvirt] [PATCH 1/3] syntax-check: Don't include public headers in internal source

2013-04-17 Thread Osier Yang
Directories python/tools/examples should include them in form, though this patch allows form in these directories by excluding them, a later patch will do the cleanup. --- cfg.mk | 10 ++ daemon/remote.c| 2 -- src/libvirt-qemu.c | 1 - 3 files changed, 10

[libvirt] [PATCH 0/3 v3] cleanup: About header including

2013-04-17 Thread Osier Yang
These 3 patches are the left ones in v2. 6/10 ~ 9/10 in v2 are merged into one single patch. Osier Yang (3): syntax-check: Don't include public headers in internal source syntax-check: Only allows to include public headers in external tools docs: Update HACKING cfg.mk

[libvirt] [PATCH 3/3] docs: Update HACKING

2013-04-17 Thread Osier Yang
To tell libvirt-{qemu,lxc}.h shouldn't be included either. --- docs/hacking.html.in | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/docs/hacking.html.in b/docs/hacking.html.in index 7ef826c..67af5c2 100644 --- a/docs/hacking.html.in +++ b/docs/hacking.html.in @@

[libvirt] [PATCH 2/3] syntax-check: Only allows to include public headers in external tools

2013-04-17 Thread Osier Yang
With this patch, include public headers in form is only allowed for internal.h. And only the external tools (examples|tools|python |include/libvirt) can include the public headers in form. --- cfg.mk | 17 ++--- include/libvirt/libvirt-lxc.h | 2 +-

[libvirt] [PATCH 1/4] syntax-check: Don't include duplicate header

2013-04-17 Thread Osier Yang
gnulib is excluded. --- cfg.mk | 24 +--- 1 file changed, 13 insertions(+), 11 deletions(-) diff --git a/cfg.mk b/cfg.mk index 71f7ee4..dd67816 100644 --- a/cfg.mk +++ b/cfg.mk @@ -724,25 +724,27 @@ sc_prohibit_exit_in_tests: # Don't include duplicate header in the source

[libvirt] [PATCH] Fix typo in ocaml_libvirt_storage_vol_get_info

2013-04-17 Thread David Scott
The info.capacity was being overwritten with the info.allocation. Signed-off-by: David Scott dave.sc...@eu.citrix.com --- libvirt/libvirt_c_oneoffs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libvirt/libvirt_c_oneoffs.c b/libvirt/libvirt_c_oneoffs.c index

Re: [libvirt] [PATCH 1/4] syntax-check: Don't include duplicate header

2013-04-17 Thread Osier Yang
Oops, ignore this please, it's on top of the old commit. On 17/04/13 18:21, Osier Yang wrote: gnulib is excluded. --- cfg.mk | 24 +--- 1 file changed, 13 insertions(+), 11 deletions(-) diff --git a/cfg.mk b/cfg.mk index 71f7ee4..dd67816 100644 --- a/cfg.mk +++ b/cfg.mk

[libvirt] [PATCH 1/4] syntax-check: Don't include duplicate header

2013-04-17 Thread Osier Yang
gnulib is excluded. --- cfg.mk | 24 1 file changed, 24 insertions(+) diff --git a/cfg.mk b/cfg.mk index e60c4e3..dd67816 100644 --- a/cfg.mk +++ b/cfg.mk @@ -722,6 +722,30 @@ sc_prohibit_exit_in_tests: halt='use return, not exit(), in tests'

[libvirt] [PATCH v2] qemu: Implement CPUs check against machine type's cpu-max

2013-04-17 Thread Michal Novotny
Implement check whether (maximum) vCPUs doesn't exceed machine type's cpu-max settings. Signed-off-by: Michal Novotny minov...@redhat.com --- src/conf/capabilities.h | 1 + src/qemu/qemu_capabilities.c | 40 +++- src/qemu/qemu_capabilities.h | 3 ++-

Re: [libvirt] [PATCH v2] qemu: Implement CPUs check against machine type's cpu-max

2013-04-17 Thread Daniel P. Berrange
On Wed, Apr 17, 2013 at 12:36:54PM +0200, Michal Novotny wrote: Implement check whether (maximum) vCPUs doesn't exceed machine type's cpu-max settings. Signed-off-by: Michal Novotny minov...@redhat.com --- src/conf/capabilities.h | 1 + src/qemu/qemu_capabilities.c | 40

Re: [libvirt] [PATCH 03/10] cleanup: Don't include libvirt/libvirt.h

2013-04-17 Thread Daniel P. Berrange
On Tue, Apr 16, 2013 at 09:41:45PM +0800, Osier Yang wrote: Which is already included by internal.h, later patch will add syntax-check to avoid it. --- src/nodeinfo.h | 1 - src/phyp/phyp_driver.c | 1 - src/remote/remote_protocol.x | 1 - src/util/virkeycode.h|

Re: [libvirt] doc: write separate module for hostdev passthrough and in-use tracking

2013-04-17 Thread Daniel P. Berrange
On Fri, Mar 22, 2013 at 05:36:09PM +0800, Chunyan Liu wrote: Hi, List, As the mail I've sent a week before: https://www.redhat.com/archives/libvir-list/2013-March/msg00730.html I'm willing to push this work forward so that the passthrough APIs could be reused by qemu driver and libxl driver

Re: [libvirt] [libvirt-glib] object: Add transfer none annotation to argv parameter

2013-04-17 Thread Claudio Bley
At Wed, 17 Apr 2013 10:17:42 +0200, Christophe Fergeau wrote: This makes the parameter to be passed unowned in Vala. This was previously done using a vala metadata file, but it's better to do it directly through a gtk-doc annotation, as this means the gir file will know about this, and thus

Re: [libvirt] [PATCH 03/10] cleanup: Don't include libvirt/libvirt.h

2013-04-17 Thread Osier Yang
On 17/04/13 18:58, Daniel P. Berrange wrote: On Tue, Apr 16, 2013 at 09:41:45PM +0800, Osier Yang wrote: Which is already included by internal.h, later patch will add syntax-check to avoid it. --- src/nodeinfo.h | 1 - src/phyp/phyp_driver.c | 1 -

[libvirt] [PATCH] qemu: Allow the disk wwn to have 0x prefix

2013-04-17 Thread Osier Yang
The recent qemu requires 0x prefix for the disk wwn, this patch changes virValidateWWN to allow the prefix, and prepend 0x if it's not specified. E.g. qemu-kvm: -device scsi-hd,bus=scsi0.0,channel=0,scsi-id=0,lun=0,\ drive=drive-scsi0-0-0-0,id=scsi0-0-0-0,wwn=6000c60016ea71ad: Property

[libvirt] [libvirt-php] Allow block devices in libvirt_domain_disk_add

2013-04-17 Thread Martijn Otto
I have written a patch to the libvirt_domain_disk_add function which does the following things: 1. Allow adding block devices as disks with libvirt_domain_disk_add 2. Removed the xflags parameter (not relevant as no xml is returned anyways) 3. Added the cache option to

Re: [libvirt] [PATCH] qemu: Allow the disk wwn to have 0x prefix

2013-04-17 Thread Osier Yang
On 17/04/13 21:23, Osier Yang wrote: The recent qemu requires 0x prefix for the disk wwn, this patch changes virValidateWWN to allow the prefix, and prepend 0x if it's not specified. E.g. qemu-kvm: -device scsi-hd,bus=scsi0.0,channel=0,scsi-id=0,lun=0,\

[libvirt] [PATCH v3] qemu: Implement CPUs check against machine type's cpu-max

2013-04-17 Thread Michal Novotny
Implement check whether (maximum) vCPUs doesn't exceed machine type's cpu-max settings. On older versions of QEMU the check is disabled. Signed-off-by: Michal Novotny minov...@redhat.com --- src/qemu/qemu_capabilities.c | 38 +- src/qemu/qemu_capabilities.h |

[libvirt] [PATCH] qemu: New XML to disable memory merge at guest startup

2013-04-17 Thread Osier Yang
QEMU introduced command line -mem-merge=on|off (defaults to on) to enable/disable the memory merge (KSM) at guest startup. This exposes it by new XML: memoryBacking nosharepages/ /memoryBacking The XML tag is same with what we used internally for old RHEL. --- docs/formatdomain.html.in

Re: [libvirt] [PATCH] docs: Add detailed notes snapshots, blockcommit, blockpull

2013-04-17 Thread Kashyap Chamarthy
[Christophe, so sorry for such a late reply. I honestly missed this feedback email, was swamped with other stuff. Just noticed this while I got some time to revisit this do a v2 of this, while browsing through archives.] On 02/22/2013 07:34 PM, Christophe Fergeau wrote: Hey Kashyap, I've

Re: [libvirt] [PATCH 1/2] network: remove autostart flag from network when undefining it

2013-04-17 Thread Laine Stump
On 04/17/2013 04:40 AM, Peter Krempa wrote: When turning a started persistent network into a transient one we forgot to remove the autostart flag that is no longer valid at that point. --- src/network/bridge_driver.c | 1 + 1 file changed, 1 insertion(+) diff --git

Re: [libvirt] [PATCH] qemu: New XML to disable memory merge at guest startup

2013-04-17 Thread Eric Blake
On 04/17/2013 08:22 AM, Osier Yang wrote: QEMU introduced command line -mem-merge=on|off (defaults to on) to enable/disable the memory merge (KSM) at guest startup. This exposes it by new XML: memoryBacking nosharepages/ /memoryBacking The XML tag is same with what we used

Re: [libvirt] [PATCH] qemu: Allow the disk wwn to have 0x prefix

2013-04-17 Thread Eric Blake
On 04/17/2013 07:23 AM, Osier Yang wrote: The recent qemu requires 0x prefix for the disk wwn, this patch changes virValidateWWN to allow the prefix, and prepend 0x if it's not specified. E.g. qemu-kvm: -device scsi-hd,bus=scsi0.0,channel=0,scsi-id=0,lun=0,\

Re: [libvirt] [PATCH 03/10] cleanup: Don't include libvirt/libvirt.h

2013-04-17 Thread Eric Blake
On 04/17/2013 06:38 AM, Osier Yang wrote: */ -%#include libvirt/libvirt.h %#include internal.h %#include arpa/inet.h This has broken make check Let's revert this hunk, and stop enforcing the checks on .x files, then. GEN remote_protocol-struct ---

Re: [libvirt] [PATCH] qemu: Allow the disk wwn to have 0x prefix

2013-04-17 Thread Osier Yang
On 17/04/13 23:02, Eric Blake wrote: On 04/17/2013 07:23 AM, Osier Yang wrote: The recent qemu requires 0x prefix for the disk wwn, this patch changes virValidateWWN to allow the prefix, and prepend 0x if it's not specified. E.g. qemu-kvm: -device

[libvirt] [PATCH] Partially revert cleanup: Don't include libvirt/libvirt.h

2013-04-17 Thread Eric Blake
This reverts the changes to remote_protocol.x made in commit 2d25fd4f410f65b40ef1c3d65124775a944f4025. It turns out that if 'dwarves' is installed, 'make check' fails if any *_LAST enum values are visible from within the .o file compiled from a .x file; including libvirt/libvirt.h prior to

Re: [libvirt] [PATCH] Switch to a more extensible annotation system for RPC protocols

2013-04-17 Thread Daniel P. Berrange
On Wed, Apr 17, 2013 at 04:43:43PM +0100, Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com Currently the RPC protocol files can contain annotations after the protocol enum eg REMOTE_PROC_DOMAIN_SNAPSHOT_LIST_CHILDREN_NAMES = 247, /* autogen autogen priority:high

Re: [libvirt] [PATCH 2/2] network: bridge_driver: don't lose transient networks on daemon restart

2013-04-17 Thread Laine Stump
On 04/17/2013 04:40 AM, Peter Krempa wrote: Until now tranisent networks weren't really useful as libvirtd wasn't able to remember them across restarts. This patch adds support for loading status files of transient networks (that already were generated) so that the status isn't lost. This

Re: [libvirt] [PATCH] Switch to a more extensible annotation system for RPC protocols

2013-04-17 Thread Eric Blake
On 04/17/2013 09:43 AM, Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com Currently the RPC protocol files can contain annotations after the protocol enum eg REMOTE_PROC_DOMAIN_SNAPSHOT_LIST_CHILDREN_NAMES = 247, /* autogen autogen priority:high */ This is not

Re: [libvirt] QEMU/KVM support for non zero PCI domain

2013-04-17 Thread Laine Stump
On 04/16/2013 11:23 AM, Charles Peri wrote: Hi, I am trying to run Virt-Manager, using KVM on a SGIUV100 system with RHEL 6.1. I am trying to enable PCI pass-thorugh for the Mellanox, but the PCI domain for the device is 0001. 4) Does libvirt actually get to the point of running

Re: [libvirt] [PATCH 2/2] network: bridge_driver: don't lose transient networks on daemon restart

2013-04-17 Thread Laine Stump
On 04/17/2013 04:40 AM, Peter Krempa wrote: Until now tranisent networks weren't really useful as libvirtd wasn't able to remember them across restarts. This patch adds support for loading status files of transient networks (that already were generated) so that the status isn't lost. BTW, can

[libvirt] [libvirt-glib] vapi: Get rid of redundant LibvirtGObject-1.0.metadata

2013-04-17 Thread Zeeshan Ali (Khattak)
From: Zeeshan Ali (Khattak) zeesha...@gnome.org Achieve the same through GIR annotations, just like we already do for libvirt-glib. --- libvirt-gobject/libvirt-gobject-main.c | 8 ++-- vapi/LibvirtGObject-1.0.metadata | 2 -- vapi/Makefile.am | 2 +- 3 files

Re: [libvirt] new libvirt pci controller type and pcie/q35 (was Re: [PATCH 4/7] add pci-bridge controller type)

2013-04-17 Thread Laine Stump
On 04/16/2013 01:35 PM, Daniel P. Berrange wrote: Can we just leave multi-domains out of this discussion for now. IMHO they are just causing more confusion to an already complicated problem. Lets focus on just solving the problem of PCI bridges which is what we actually need right now. Sure.

Re: [libvirt] [PATCH 5/7] qemu: build command line for pci-bridge device

2013-04-17 Thread Laine Stump
On 04/03/2013 11:50 AM, Ján Tomko wrote: From: liguang lig.f...@cn.fujitsu.com --- src/qemu/qemu_capabilities.c | 2 ++ src/qemu/qemu_capabilities.h | 1 + src/qemu/qemu_command.c | 15 ++- tests/qemuhelptest.c | 21 ++--- 4 files changed, 31

Re: [libvirt] [PATCH 5/7] qemu: build command line for pci-bridge device

2013-04-17 Thread Laine Stump
On 04/17/2013 01:58 PM, Laine Stump wrote: On 04/03/2013 11:50 AM, Ján Tomko wrote: From: liguang lig.f...@cn.fujitsu.com --- src/qemu/qemu_capabilities.c | 2 ++ src/qemu/qemu_capabilities.h | 1 + src/qemu/qemu_command.c | 15 ++- tests/qemuhelptest.c | 21

Re: [libvirt] [PATCH] Fix typo in ocaml_libvirt_storage_vol_get_info

2013-04-17 Thread Eric Blake
On 04/17/2013 04:23 AM, David Scott wrote: The info.capacity was being overwritten with the info.allocation. If you will do: git config format.subjectprefix 'ocaml PATCH' then future patches from you will come with a mailing list header of: [libvirt][ocaml PATCH] ... to make it more obvious

[libvirt] [PATCH v2 00/11] qemu: add PCI bridge support

2013-04-17 Thread Ján Tomko
Add new 'pci' controller type with two models: pci-root - auto-added to a pc* machine, providing pci bus 0 pci-bridge - auto-added if the devices would not leave at least one slot empty on bus 0 or bus 0 is specified Ján Tomko (10): qemu: make qemuComparePCIDevice aware of multiple buses

[libvirt] [PATCH v2 03/11] qemu: QEMU_PCI constant consistency

2013-04-17 Thread Ján Tomko
Change QEMU_PCI_ADDRESS_LAST_SLOT to the number of slots in the bus, not the maximum slot value, to match QEMU_PCI_ADDRESS_LAST_FUNCTION and rename them both to have _LAST at the end. --- src/qemu/qemu_command.c | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git

[libvirt] [PATCH v2 05/11] qemu: switch PCI address set from hash table to an array

2013-04-17 Thread Ján Tomko
Each bus is represented as an array of 32 8-bit integers where each bit represents a PCI function and each byte represents a PCI slot. Uses just one bus so far. --- src/qemu/qemu_command.c | 152 ++-- 1 file changed, 45 insertions(+), 107 deletions(-)

[libvirt] [PATCH v2 01/11] qemu: make qemuComparePCIDevice aware of multiple buses

2013-04-17 Thread Ján Tomko
Bus and domain need to be checked as well, otherwise we might get false positives when searching for multi-function devices. --- src/qemu/qemu_hotplug.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/qemu/qemu_hotplug.c b/src/qemu/qemu_hotplug.c index a6c75cb..fb78af3

[libvirt] [PATCH v2 07/11] conf: add model attribute to virDomainDefMaybeAddController

2013-04-17 Thread Ján Tomko
--- src/conf/domain_conf.c | 29 +++-- 1 file changed, 11 insertions(+), 18 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 548368e..cf0f1c4 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -9747,21 +9747,18 @@

[libvirt] [PATCH v2 02/11] qemu: print PCI address hexadecimally in errors

2013-04-17 Thread Ján Tomko
Use the same formatting as we do for XML in error and debug outputs. --- src/qemu/qemu_command.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c index 009d42d..ac5e1f3 100644 --- a/src/qemu/qemu_command.c +++

[libvirt] [PATCH v2 04/11] qemu: move PCI address check out of qemuPCIAddressAsString

2013-04-17 Thread Ján Tomko
Create a new function qemuPCIAddressValidate and call it everywhere the user might supply an incorrect address: * qemuCollectPCIAddress for domain definition * qemuDomainPCIAddressEnsureAddr and ReleaseSlot for hotplug Slot and function shouldn't be wrong at this point, since values out of range

[libvirt] [PATCH v2 09/11] qemu: build command line for pci-bridge device

2013-04-17 Thread Ján Tomko
From: liguang lig.f...@cn.fujitsu.com --- src/qemu/qemu_capabilities.c | 3 +++ src/qemu/qemu_capabilities.h | 1 + src/qemu/qemu_command.c | 44 tests/qemuhelptest.c | 21 ++--- 4 files changed, 58 insertions(+), 11

[libvirt] [PATCH v2 06/11] qemu: rename CheckSlot to SlotInUse

2013-04-17 Thread Ján Tomko
Also change its return value from int to bool. --- src/qemu/qemu_command.c | 17 - 1 file changed, 8 insertions(+), 9 deletions(-) diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c index c51c336..1b9d940 100644 --- a/src/qemu/qemu_command.c +++

[libvirt] [PATCH v2 10/11] qemu: auto-add bridges and allow using them

2013-04-17 Thread Ján Tomko
Add a dry run address allocation to figure out how many bridges will be needed for all the devices without explicit addresses. Auto-add just enough bridges to put all the devices on, or up to the bridge with the largest specified index. --- src/conf/domain_conf.c | 9 +--

[libvirt] [PATCH v2 08/11] conf: add PCI controllers

2013-04-17 Thread Ján Tomko
Add new controller type 'pci' with models 'pci-root' and 'pci-bridge'. --- docs/schemas/domaincommon.rng | 3 +++ src/conf/domain_conf.c| 21 - src/conf/domain_conf.h| 9 + 3 files changed, 32 insertions(+), 1 deletion(-) diff --git

[libvirt] [PATCH] conf: fix comment about parsing graphics listen address

2013-04-17 Thread Ján Tomko
--- Pushed under the trivial rule. src/conf/domain_conf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 548368e..1643f30 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -7291,7 +7291,7 @@

Re: [libvirt] [PATCH 1/4] syntax-check: Don't include duplicate header

2013-04-17 Thread Eric Blake
On 04/17/2013 04:25 AM, Osier Yang wrote: gnulib is excluded. --- cfg.mk | 24 1 file changed, 24 insertions(+) Looks like this patch is supposed to come before the patch named [1/3] syntax-check: Don't include public headers in internal source diff --git

Re: [libvirt] [PATCH 1/3] syntax-check: Don't include public headers in internal source

2013-04-17 Thread Eric Blake
On 04/17/2013 04:19 AM, Osier Yang wrote: Directories python/tools/examples should include them in form, though this patch allows form in these directories by excluding them, a later patch will do the cleanup. Looks like a bit of a mishap while sending; this comes after the email titled:

Re: [libvirt] [PATCH 2/3] syntax-check: Only allows to include public headers in external tools

2013-04-17 Thread Eric Blake
On 04/17/2013 04:19 AM, Osier Yang wrote: With this patch, include public headers in form is only allowed for internal.h. And only the external tools (examples|tools|python |include/libvirt) can include the public headers in form. --- cfg.mk | 17 ++---

Re: [libvirt] [PATCH 3/3] docs: Update HACKING

2013-04-17 Thread Eric Blake
On 04/17/2013 04:19 AM, Osier Yang wrote: To tell libvirt-{qemu,lxc}.h shouldn't be included either. --- docs/hacking.html.in | 8 1 file changed, 4 insertions(+), 4 deletions(-) You also need to run 'make HACKING' and check that in at the same time. (Yes, that's one of the few

Re: [libvirt] [PATCH v2 01/11] qemu: make qemuComparePCIDevice aware of multiple buses

2013-04-17 Thread Eric Blake
On 04/17/2013 01:00 PM, Ján Tomko wrote: Bus and domain need to be checked as well, otherwise we might get false positives when searching for multi-function devices. --- src/qemu/qemu_hotplug.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) ACK. diff --git

Re: [libvirt] [PATCH v2 02/11] qemu: print PCI address hexadecimally in errors

2013-04-17 Thread Eric Blake
On 04/17/2013 01:00 PM, Ján Tomko wrote: Use the same formatting as we do for XML in error and debug outputs. --- src/qemu/qemu_command.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) ACK; qemuPCIAddressAsString is only used for hash lookups, and is not something directly handed to

[libvirt] [[libvirt-designer v4] 1/2] Add transfer annotation to *init.argv

2013-04-17 Thread Zeeshan Ali (Khattak)
From: Zeeshan Ali (Khattak) zeesha...@gnome.org Add transfer annotation to argv parameter of library init functions. --- libvirt-designer/libvirt-designer-main.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/libvirt-designer/libvirt-designer-main.c

[libvirt] [[libvirt-designer v4] 2/2] Add Vala API

2013-04-17 Thread Zeeshan Ali (Khattak)
From: Zeeshan Ali (Khattak) zeesha...@gnome.org This is mostly (modified) copypaste from libvirt-glib. --- Makefile.am| 2 +- configure.ac | 37 + vapi/Makefile.am | 27 +++

Re: [libvirt] [PATCH v2 03/11] qemu: QEMU_PCI constant consistency

2013-04-17 Thread Eric Blake
On 04/17/2013 01:00 PM, Ján Tomko wrote: Change QEMU_PCI_ADDRESS_LAST_SLOT to the number of slots in the bus, not the maximum slot value, to match QEMU_PCI_ADDRESS_LAST_FUNCTION and rename them both to have _LAST at the end. --- src/qemu/qemu_command.c | 18 +- 1 file

Re: [libvirt] [PATCH v2 04/11] qemu: move PCI address check out of qemuPCIAddressAsString

2013-04-17 Thread Eric Blake
On 04/17/2013 01:00 PM, Ján Tomko wrote: Create a new function qemuPCIAddressValidate and call it everywhere the user might supply an incorrect address: * qemuCollectPCIAddress for domain definition * qemuDomainPCIAddressEnsureAddr and ReleaseSlot for hotplug Slot and function shouldn't be

Re: [libvirt] [PATCH v2 05/11] qemu: switch PCI address set from hash table to an array

2013-04-17 Thread Eric Blake
On 04/17/2013 01:00 PM, Ján Tomko wrote: Each bus is represented as an array of 32 8-bit integers where each bit represents a PCI function and each byte represents a PCI slot. Uses just one bus so far. --- src/qemu/qemu_command.c | 152 ++--

Re: [libvirt] [PATCH v2 06/11] qemu: rename CheckSlot to SlotInUse

2013-04-17 Thread Eric Blake
On 04/17/2013 01:00 PM, Ján Tomko wrote: Also change its return value from int to bool. --- src/qemu/qemu_command.c | 17 - 1 file changed, 8 insertions(+), 9 deletions(-) +static bool qemuDomainPCIAddressSlotInUse(qemuDomainPCIAddressSetPtr addrs, +

Re: [libvirt] [PATCH v2 07/11] conf: add model attribute to virDomainDefMaybeAddController

2013-04-17 Thread Eric Blake
On 04/17/2013 01:00 PM, Ján Tomko wrote: --- src/conf/domain_conf.c | 29 +++-- 1 file changed, 11 insertions(+), 18 deletions(-) ACK. -- Eric Blake eblake redhat com+1-919-301-3266 Libvirt virtualization library http://libvirt.org signature.asc

Re: [libvirt] [PATCH v2 08/11] conf: add PCI controllers

2013-04-17 Thread Eric Blake
On 04/17/2013 01:00 PM, Ján Tomko wrote: Add new controller type 'pci' with models 'pci-root' and 'pci-bridge'. --- docs/schemas/domaincommon.rng | 3 +++ src/conf/domain_conf.c| 21 - src/conf/domain_conf.h| 9 + 3 files changed, 32

Re: [libvirt] [PATCH v2 08/11] conf: add PCI controllers

2013-04-17 Thread Eric Blake
On 04/17/2013 05:12 PM, Eric Blake wrote: On 04/17/2013 01:00 PM, Ján Tomko wrote: Add new controller type 'pci' with models 'pci-root' and 'pci-bridge'. --- docs/schemas/domaincommon.rng | 3 +++ src/conf/domain_conf.c| 21 - src/conf/domain_conf.h| 9

Re: [libvirt] [PATCH v2 08/11] conf: add PCI controllers

2013-04-17 Thread Laine Stump
On 04/17/2013 03:00 PM, Ján Tomko wrote: Add new controller type 'pci' with models 'pci-root' and 'pci-bridge'. --- docs/schemas/domaincommon.rng | 3 +++ src/conf/domain_conf.c| 21 - src/conf/domain_conf.h| 9 + 3 files changed, 32

Re: [libvirt] [PATCH v2 09/11] qemu: build command line for pci-bridge device

2013-04-17 Thread Laine Stump
On 04/17/2013 03:00 PM, Ján Tomko wrote: From: liguang lig.f...@cn.fujitsu.com --- src/qemu/qemu_capabilities.c | 3 +++ src/qemu/qemu_capabilities.h | 1 + src/qemu/qemu_command.c | 44 tests/qemuhelptest.c | 21

Re: [libvirt] [PATCH v2 1/1] Set legacy USB option with default for ppc64.

2013-04-17 Thread Li Zhang
Hi Daniel, I have added test cases for my description. Any idea? Thanks. :) On 2013年04月15日 21:12, Li Zhang wrote: From: Li Zhang zhlci...@linux.vnet.ibm.com Currently, -device xxx still can't work well for ppc64 platform. It's better use legacy USB option with default for ppc64. This patch

Re: [libvirt] [PATCH v4 2/2] qemu: Add command line parser for NVRAM.

2013-04-17 Thread Li Zhang
ping ? On 2013年04月12日 13:34, Li Zhang wrote: From: Li Zhang zhlci...@linux.vnet.ibm.com This patch is to add command line parser for NVRAM device, and add test cases. Signed-off-by: Li Zhang zhlci...@linux.vnet.ibm.com --- src/qemu/qemu_command.c| 72

Re: [libvirt] [PATCH v4 1/2] Add NVRAM device

2013-04-17 Thread Li Zhang
ping ? On 2013年04月12日 13:34, Li Zhang wrote: From: Li Zhang zhlci...@linux.vnet.ibm.com For pSeries guest in QEMU, NVRAM is one kind of spapr-vio device. Users are allowed to specify spapr-vio devices'address. But NVRAM is not supported in libvirt. So this patch is to add NVRAM device to allow

Re: [libvirt] [PATCH 3/3] docs: Update HACKING

2013-04-17 Thread Osier Yang
On 18/04/13 04:25, Eric Blake wrote: On 04/17/2013 04:19 AM, Osier Yang wrote: To tell libvirt-{qemu,lxc}.h shouldn't be included either. --- docs/hacking.html.in | 8 1 file changed, 4 insertions(+), 4 deletions(-) You also need to run 'make HACKING' and check that in at the same

Re: [libvirt] [PATCH 0/3 v3] cleanup: About header including

2013-04-17 Thread Osier Yang
On 17/04/13 18:19, Osier Yang wrote: These 3 patches are the left ones in v2. 6/10 ~ 9/10 in v2 are merged into one single patch. Osier Yang (3): syntax-check: Don't include public headers in internal source syntax-check: Only allows to include public headers in external tools docs:

Re: [libvirt] [PATCH v2.5 03/10] conf: Introduce scsi hostdev

2013-04-17 Thread Hu Tao
On Mon, Apr 15, 2013 at 08:27:10PM +0800, Han Cheng wrote: Thanks for your best efforts. I only have one problem. Please find it at the end. 于 2013/4/10 16:59, Osier Yang 写道: On 09/04/13 10:32, Han Cheng wrote: Add scsi hostdev, it looks like: hostdev mode='subsystem' type='scsi'

[libvirt] [PATCH] rng: tighten up domain controller schema

2013-04-17 Thread Laine Stump
The rng schema for controller had been non-specific about which types of controllers allowed which models, and also allowed the num_queues attribute (since that hasn't been released yet, should we rename it to numQueues?) and master subelement to be included for any controller type. In reality,

Re: [libvirt] [PATCH v2 08/11] conf: add PCI controllers

2013-04-17 Thread Laine Stump
On 04/17/2013 03:00 PM, Ján Tomko wrote: Add new controller type 'pci' with models 'pci-root' and 'pci-bridge'. --- docs/schemas/domaincommon.rng | 3 +++ src/conf/domain_conf.c| 21 - src/conf/domain_conf.h| 9 + 3 files changed, 32

Re: [libvirt] [PATCH v2 11/11] qemu: auto-add pci-root controller for pc machine types

2013-04-17 Thread Laine Stump
On 04/17/2013 03:00 PM, Ján Tomko wrote: controller type='pci' index='0' model='pci-root'/ is auto-added to pc* machine types. Without this controller PCI bus 0 is not available and no PCI addresses are assigned by default. Since older libvirt supported PCI bus 0 even without this

Re: [libvirt] [PATCH v4 1/2] Add NVRAM device

2013-04-17 Thread Li Zhang
Ah, Just found that mailing list's address I send patches to is not right. I will resend these patches. :( On 2013年04月12日 13:34, Li Zhang wrote: From: Li Zhang zhlci...@linux.vnet.ibm.com For pSeries guest in QEMU, NVRAM is one kind of spapr-vio device. Users are allowed to specify spapr-vio

[libvirt] [PATCH v4 1/2 RESEND] Add NVRAM device

2013-04-17 Thread Li Zhang
From: Li Zhang zhlci...@linux.vnet.ibm.com For pSeries guest in QEMU, NVRAM is one kind of spapr-vio device. Users are allowed to specify spapr-vio devices'address. But NVRAM is not supported in libvirt. So this patch is to add NVRAM device to allow users to specify its address. In QEMU, NVRAM

[libvirt] [PATCH v4 2/2 RESEND] qemu: Add command line parser for NVRAM.

2013-04-17 Thread Li Zhang
From: Li Zhang zhlci...@linux.vnet.ibm.com This patch is to add command line parser for NVRAM device, and add test cases. Signed-off-by: Li Zhang zhlci...@linux.vnet.ibm.com --- src/qemu/qemu_command.c| 72 ++ src/qemu/qemu_command.h