Re: [libvirt] [libvirt-java] [PATCH 00/12] event support

2013-05-08 Thread Daniel Veillard
On Sun, May 05, 2013 at 10:51:35AM +0200, Stefan Majer wrote: Hi, back in January 2013 Claudio Bley submit a series of patches [1] to enable event support to libvirt-java. There was no response on his work and they didn't get merged. Probably because there was not enough need out there.

Re: [libvirt] [PATCH 03/11] Include process start time when doing polkit checks

2013-05-08 Thread Daniel P. Berrange
On Fri, May 03, 2013 at 01:38:47PM -0600, Eric Blake wrote: On 05/02/2013 06:07 AM, Daniel P. Berrange wrote: On Thu, May 02, 2013 at 01:03:41PM +0100, Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com Since PIDs can be reused, polkit prefers to be given a

[libvirt] [PATCH v2] Delete udevFreeIfaceDef function in udev interface driver

2013-05-08 Thread Daniel P. Berrange
From: Daniel P. Berrange berra...@redhat.com The udevFreeIfaceDef function in the udev interface driver just duplicates code from virInterfaceDefFree. Delete it and call the standard API instead. Fix the udevGetIfaceDefVlan method so that it doesn't store pointers to the middle of a malloc'd

Re: [libvirt] [PATCH 04/40] Simplify opening of Xen drivers

2013-05-08 Thread Daniel P. Berrange
On Fri, May 03, 2013 at 04:12:29PM -0600, Jim Fehlig wrote: Daniel P. Berrange wrote: diff --git a/src/xen/xen_driver.c b/src/xen/xen_driver.c index 2ecb86f..b7f1ad4 100644 --- a/src/xen/xen_driver.c +++ b/src/xen/xen_driver.c @@ -86,14 +86,9 @@ static struct xenUnifiedDriver const *

Re: [libvirt] [PATCH 08/40] Simplify the Xen count/list domains driver methods

2013-05-08 Thread Daniel P. Berrange
On Mon, May 06, 2013 at 02:32:13PM -0600, Jim Fehlig wrote: Jim Fehlig wrote: Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com The XenStore driver is mandatory, so it can be used unconditonally for the xenUnifiedConnectListDomains

Re: [libvirt] [PATCH 10/40] Simplify the Xen domain lookup driver methods

2013-05-08 Thread Daniel P. Berrange
On Mon, May 06, 2013 at 03:01:25PM -0600, Jim Fehlig wrote: Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com Unconditionally invoke the xenHypervisorLookupDomainByID, xenHypervisorLookupDomainByUUID or xenDaemonLookupByName for looking up domains. Fallback to

Re: [libvirt] [PATCH 10/40] Simplify the Xen domain lookup driver methods

2013-05-08 Thread Daniel P. Berrange
On Mon, May 06, 2013 at 09:40:43PM -0600, Jim Fehlig wrote: Jim Fehlig wrote: Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com Unconditionally invoke the xenHypervisorLookupDomainByID, xenHypervisorLookupDomainByUUID or xenDaemonLookupByName for looking up

Re: [libvirt] [PATCH 10/40] Simplify the Xen domain lookup driver methods

2013-05-08 Thread Daniel P. Berrange
On Wed, May 08, 2013 at 11:37:44AM +0100, Daniel P. Berrange wrote: On Mon, May 06, 2013 at 09:40:43PM -0600, Jim Fehlig wrote: Jim Fehlig wrote: Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com Unconditionally invoke the xenHypervisorLookupDomainByID,

Re: [libvirt] [PATCH 1/2] lxc: Coverity false positive USE_AFTER_FREE

2013-05-08 Thread John Ferlan
On 05/01/2013 11:53 AM, John Ferlan wrote: --- src/lxc/lxc_container.c | 5 + 1 file changed, 5 insertions(+) diff --git a/src/lxc/lxc_container.c b/src/lxc/lxc_container.c index ac0f69c..d082a06 100644 --- a/src/lxc/lxc_container.c +++ b/src/lxc/lxc_container.c @@ -1772,6 +1772,11

Re: [libvirt] [PATCH 0/4] Extra validation for the sysinfo section

2013-05-08 Thread John Ferlan
On 04/30/2013 02:19 PM, John Ferlan wrote: Not necessary for 1.0.5, but figured I'd put it out there now. https://bugzilla.redhat.com/show_bug.cgi?id=890494 The sysinfo section needs an extra uuid validation check. The current check compares the numerical sysinfo/system_uuid with the

Re: [libvirt] [PATCH 1/2] lxc: Coverity false positive USE_AFTER_FREE

2013-05-08 Thread Daniel P. Berrange
On Wed, May 08, 2013 at 06:51:19AM -0400, John Ferlan wrote: On 05/01/2013 11:53 AM, John Ferlan wrote: --- src/lxc/lxc_container.c | 5 + 1 file changed, 5 insertions(+) diff --git a/src/lxc/lxc_container.c b/src/lxc/lxc_container.c index ac0f69c..d082a06 100644 ---

Re: [libvirt] [ocaml] event registration APis v3

2013-05-08 Thread Richard W.M. Jones
On Wed, Apr 24, 2013 at 11:39:02AM +0100, David Scott wrote: Hi, Here are my latest patches which add OCaml bindings for the libvirt event API. I'm pretty happy with them now: my test programs have been running for long periods of time without incident. Changes from the previous

[libvirt] [libvirt-tck PATCH] Add new file for domain APIs

2013-05-08 Thread Zhe Peng
include APIs dom-block_resize dom-get_block_info dom-block_peek dom-get_interface_parameters dom-migrate_get_max_speed dom-set_interface_parameters con-is_alive --- scripts/domain/180-interface-parameters.t | 173 + 1 files changed, 173 insertions(+), 0 deletions(-)

Re: [libvirt] [libvirt-tck PATCH] Add new file for domain APIs

2013-05-08 Thread Daniel P. Berrange
On Wed, May 08, 2013 at 07:56:28PM +0800, Zhe Peng wrote: include APIs dom-block_resize dom-get_block_info dom-block_peek dom-get_interface_parameters dom-migrate_get_max_speed dom-set_interface_parameters con-is_alive These are alot of unrelated APIs. Each test case should focus on a

Re: [libvirt] [PATCH 1/7] util: Fix regression of wwn reading

2013-05-08 Thread John Ferlan
On 05/06/2013 08:45 AM, Osier Yang wrote: Introduced by commit 244ce462e29, which refactored the helper for wwn reading, however, it forgot to change the old strndup and sizeof(buf), sizeof(buf) operates on the fixed length array (buf) in the old code, but now buf is a pointer. Before the

Re: [libvirt] [ocaml] event registration APis v3

2013-05-08 Thread David Scott
Hi, On 8 May 2013, at 12:32, Richard W.M. Jones rjo...@redhat.com wrote: On Wed, Apr 24, 2013 at 11:39:02AM +0100, David Scott wrote: Hi, Here are my latest patches which add OCaml bindings for the libvirt event API. I'm pretty happy with them now: my test programs have been running for

Re: [libvirt] [PATCH 2/7] util: Fix regression introduced by commit 4360a098441

2013-05-08 Thread John Ferlan
On 05/06/2013 08:45 AM, Osier Yang wrote: Which refactored the old code, and introduced new helper virIsCapableVport, but the path for checking with access() is not correctly constructed. I'd like to make a couple of suggestions... This issue is/was because LINUX_SYSFS_VPORT_CREATE_POSTFIX

Re: [libvirt] [PATCH 3/7] util: Don't miss the slash in constructed path

2013-05-08 Thread John Ferlan
On 05/06/2013 08:45 AM, Osier Yang wrote: In case of the caller can pass a prefix (or sysfs_prefix) without the trailing slash, and Unix-Like system always eats up the redundant slash in the filepath, let's add it explicitly. --- src/util/virutil.c | 14 +++--- 1 file changed, 7

Re: [libvirt] [PATCH 4/7] util: Change virIsCapable* to return bool

2013-05-08 Thread John Ferlan
On 05/06/2013 08:45 AM, Osier Yang wrote: Function name with aIsB generally means its return value is in Bi-state (true/false). --- src/node_device/node_device_linux_sysfs.c | 4 ++-- src/util/virutil.c| 18 +- src/util/virutil.h

Re: [libvirt] [PATCH 5/7] util: Update the comment for virGetFCHostNameByWWN

2013-05-08 Thread John Ferlan
On 05/06/2013 08:45 AM, Osier Yang wrote: The returned result is something like host5 acutally. --- src/util/virutil.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) ACK John -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH 6/7] util: Honor the passed sysfs_prefix

2013-05-08 Thread John Ferlan
On 05/06/2013 08:45 AM, Osier Yang wrote: The helper works for default sysfs_prefix, but for user specified prefix, it doesn't work. (Detected when writing test cases. A later patch will add the test cases for fc_host). --- src/util/virutil.c | 11 ++- 1 file changed, 6

Re: [libvirt] [PATCH 7/7] tests: Add tests for fc_host

2013-05-08 Thread John Ferlan
On 05/06/2013 08:45 AM, Osier Yang wrote: Since the NPIV machine is not easy to get, it's very likely to introduce regressions when doing changes on the existing code. This patch dumps part of the sysfs files (the necessary ones) of fc_host as test input data, to test the related util

Re: [libvirt] [libvirt-java] [RFC] simplify java build process

2013-05-08 Thread Claudio Bley
At Tue, 7 May 2013 16:55:06 +0200, Stefan Majer wrote: after adding a proper setting with the maven-compiler-plugin i get: [ERROR] COMPILATION ERROR : [INFO] - [ERROR]

Re: [libvirt] [libvirt-java] [RFC] simplify java build process

2013-05-08 Thread Daniel P. Berrange
On Wed, May 08, 2013 at 04:11:36PM +0200, Claudio Bley wrote: 3. remove libvirt-java.spec.in and create the libvirt-java.rpm with the rpm-maven-plugin. I have no idea / experience about this one. We'll have to see whether this works out for the different distros I think. The

Re: [libvirt] [libvirt-java] [RFC] simplify java build process

2013-05-08 Thread Stefan Majer
Hi, On Wed, May 8, 2013 at 4:21 PM, Daniel P. Berrange berra...@redhat.com wrote: On Wed, May 08, 2013 at 04:11:36PM +0200, Claudio Bley wrote: 3. remove libvirt-java.spec.in and create the libvirt-java.rpm with the rpm-maven-plugin. I have no idea / experience about this one. We'll have

Re: [libvirt] [libvirt-java] [RFC] simplify java build process

2013-05-08 Thread Stefan Majer
On Wed, May 8, 2013 at 4:11 PM, Claudio Bley cb...@av-test.de wrote: At Tue, 7 May 2013 16:55:06 +0200, Stefan Majer wrote: after adding a proper setting with the maven-compiler-plugin i get: [ERROR] COMPILATION ERROR : [INFO] -

Re: [libvirt] [PATCH 1/7] util: Fix regression of wwn reading

2013-05-08 Thread Osier Yang
On 08/05/13 20:56, John Ferlan wrote: On 05/06/2013 08:45 AM, Osier Yang wrote: Introduced by commit 244ce462e29, which refactored the helper for wwn reading, however, it forgot to change the old strndup and sizeof(buf), sizeof(buf) operates on the fixed length array (buf) in the old code, but

Re: [libvirt] [PATCH 1/7] util: Fix regression of wwn reading

2013-05-08 Thread Doug Goldstein
On Wed, May 8, 2013 at 9:49 AM, Osier Yang jy...@redhat.com wrote: On 08/05/13 20:56, John Ferlan wrote: On 05/06/2013 08:45 AM, Osier Yang wrote: Introduced by commit 244ce462e29, which refactored the helper for wwn reading, however, it forgot to change the old strndup and sizeof(buf),

Re: [libvirt] [PATCH 4/7] util: Change virIsCapable* to return bool

2013-05-08 Thread Osier Yang
On 08/05/13 21:38, John Ferlan wrote: On 05/06/2013 08:45 AM, Osier Yang wrote: Function name with aIsB generally means its return value is in Bi-state (true/false). --- src/node_device/node_device_linux_sysfs.c | 4 ++-- src/util/virutil.c| 18 +-

Re: [libvirt] [PATCH 6/7] util: Honor the passed sysfs_prefix

2013-05-08 Thread Osier Yang
On 08/05/13 21:46, John Ferlan wrote: On 05/06/2013 08:45 AM, Osier Yang wrote: The helper works for default sysfs_prefix, but for user specified prefix, it doesn't work. (Detected when writing test cases. A later patch will add the test cases for fc_host). --- src/util/virutil.c | 11

Re: [libvirt] [PATCH 7/7] tests: Add tests for fc_host

2013-05-08 Thread Osier Yang
On 08/05/13 21:53, John Ferlan wrote: On 05/06/2013 08:45 AM, Osier Yang wrote: Since the NPIV machine is not easy to get, it's very likely to introduce regressions when doing changes on the existing code. This patch dumps part of the sysfs files (the necessary ones) of fc_host as test input

Re: [libvirt] [PATCH 1/7] util: Fix regression of wwn reading

2013-05-08 Thread Osier Yang
On 08/05/13 22:56, Doug Goldstein wrote: On Wed, May 8, 2013 at 9:49 AM, Osier Yang jy...@redhat.com mailto:jy...@redhat.com wrote: On 08/05/13 20:56, John Ferlan wrote: On 05/06/2013 08:45 AM, Osier Yang wrote: Introduced by commit 244ce462e29, which refactored the

Re: [libvirt] [PATCH 2/7] util: Fix regression introduced by commit 4360a098441

2013-05-08 Thread Osier Yang
On 08/05/13 21:23, John Ferlan wrote: On 05/06/2013 08:45 AM, Osier Yang wrote: Which refactored the old code, and introduced new helper virIsCapableVport, but the path for checking with access() is not correctly constructed. I'd like to make a couple of suggestions... This issue is/was

Re: [libvirt] [PATCH 0/2] Resolve Coverity issues

2013-05-08 Thread John Ferlan
On 05/01/2013 11:53 AM, John Ferlan wrote: The following patches resolve a couple of Coverity issues. The 'lxc' change is merely a work-around by adding a Coverity tag to avoid what I consider to be a false positive. Another option to resolving is to change the code in

Re: [libvirt] [libvirt-java] [PATCH] Fix wrapping of native size_t data type

2013-05-08 Thread Claudio Bley
At Wed, 24 Apr 2013 15:43:42 +0200, Claudio Bley wrote: Libvirt function parameters having type (pointer to) size_t were wrapped via JNA using int, long or even NativeLong. Alas, none of these is actually correct as the size of size_t may be the same as the size of either (unsigned) int,

Re: [libvirt] [libvirt-java] [PATCH] Fix wrapping of native size_t data type

2013-05-08 Thread Eric Blake
On 04/24/2013 07:43 AM, Claudio Bley wrote: Libvirt function parameters having type (pointer to) size_t were wrapped via JNA using int, long or even NativeLong. Alas, none of these is actually correct as the size of size_t may be the same as the size of either (unsigned) int, long or even long

Re: [libvirt] [PATCH v2] Delete udevFreeIfaceDef function in udev interface driver

2013-05-08 Thread Eric Blake
On 05/08/2013 03:45 AM, Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com The udevFreeIfaceDef function in the udev interface driver just duplicates code from virInterfaceDefFree. Delete it and call the standard API instead. Fix the udevGetIfaceDefVlan method so that

Re: [libvirt] [Qemu-devel] virtio serial device problem

2013-05-08 Thread fred . konrad
On 05/07/2013 07:50 PM, Paolo Bonzini wrote: Il 07/05/2013 09:20, Li Zhang ha scritto: Hi all, Hi, When we use the latest version of QEMU to build ovirt, we get this error reported from libvirt. What QEMU commit is this? b3e6d591b05538056d665572f3e3bbfb3cbb70e7 This commit is from

Re: [libvirt] [PATCH 20/40] Simplify the Xen domain VCPU driver methods

2013-05-08 Thread Jim Fehlig
Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com Signed-off-by: Daniel P. Berrange berra...@redhat.com --- src/xen/xen_driver.c | 91 src/xen/xen_driver.h | 2 -- src/xen/xen_hypervisor.c | 90

Re: [libvirt] [PATCH 10/40] Simplify the Xen domain lookup driver methods

2013-05-08 Thread Jim Fehlig
Daniel P. Berrange wrote: On Wed, May 08, 2013 at 11:37:44AM +0100, Daniel P. Berrange wrote: On Mon, May 06, 2013 at 09:40:43PM -0600, Jim Fehlig wrote: Jim Fehlig wrote: Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com Unconditionally

Re: [libvirt] [PATCH 10/40] Simplify the Xen domain lookup driver methods

2013-05-08 Thread Jim Fehlig
Daniel P. Berrange wrote: On Mon, May 06, 2013 at 03:01:25PM -0600, Jim Fehlig wrote: Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com Unconditionally invoke the xenHypervisorLookupDomainByID, xenHypervisorLookupDomainByUUID or xenDaemonLookupByName for

Re: [libvirt] [PATCH] iscsi: don't leak portal string when starting a pool

2013-05-08 Thread Eric Blake
On 05/07/2013 02:02 AM, Ján Tomko wrote: --- src/storage/storage_backend_iscsi.c | 1 + 1 file changed, 1 insertion(+) ACK. diff --git a/src/storage/storage_backend_iscsi.c b/src/storage/storage_backend_iscsi.c index cf25919..3b48f44 100644 --- a/src/storage/storage_backend_iscsi.c

Re: [libvirt] [PATCH v3 07/34] Adapt to VIR_STRDUP and VIR_STRNDUP in src/libxl/*

2013-05-08 Thread Eric Blake
On 05/03/2013 08:53 AM, Michal Privoznik wrote: --- src/libxl/libxl_conf.c | 86 ++-- src/libxl/libxl_driver.c | 14 +++- 2 files changed, 29 insertions(+), 71 deletions(-) diff --git a/src/libxl/libxl_conf.c b/src/libxl/libxl_conf.c @@

[libvirt] [PATCH] maint: update to latest gnulib

2013-05-08 Thread Eric Blake
Among others, this fixes a cosmetic bug where bootstrap stated: ./bootstrap: Bootstrapping from checked-out http://libvirt.org sources... instead of the intended: ./bootstrap: Bootstrapping from checked-out libvirt sources... * .gnulib: Update to latest, for bootstrap improvement. * bootstrap:

Re: [libvirt] [PATCH v3 08/34] Adapt to VIR_STRDUP and VIR_STRNDUP in src/locking/*

2013-05-08 Thread Eric Blake
On 05/03/2013 08:53 AM, Michal Privoznik wrote: --- src/locking/lock_daemon.c | 30 +++- src/locking/lock_daemon_config.c | 12 +-- src/locking/lock_daemon_dispatch.c | 6 ++ src/locking/lock_driver_lockd.c| 41

Re: [libvirt] [PATCH 21/40] Simplify the Xen domain get XML driver method

2013-05-08 Thread Jim Fehlig
Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com The xenUnifiedDomainGetXMLDesc driver can assume that the XM and XenD drivers are always present Signed-off-by: Daniel P. Berrange berra...@redhat.com --- src/xen/xen_driver.c| 24 +---

Re: [libvirt] [PATCH v3 09/34] Adapt to VIR_STRDUP and VIR_STRNDUP in src/lxc/*

2013-05-08 Thread Eric Blake
On 05/03/2013 08:53 AM, Michal Privoznik wrote: --- src/lxc/lxc_cgroup.c | 3 +-- src/lxc/lxc_conf.c | 36 +--- src/lxc/lxc_container.c | 18 -- src/lxc/lxc_controller.c | 20 src/lxc/lxc_driver.c | 9

Re: [libvirt] [PATCH v3 10/34] Adapt to VIR_STRDUP and VIR_STRNDUP in src/network/*

2013-05-08 Thread Eric Blake
On 05/03/2013 08:53 AM, Michal Privoznik wrote: --- src/network/bridge_driver.c | 34 +++--- 1 file changed, 11 insertions(+), 23 deletions(-) ACK. -- Eric Blake eblake redhat com+1-919-301-3266 Libvirt virtualization library http://libvirt.org

Re: [libvirt] [PATCH 22/40] Simplify the Xen domain migration driver methods

2013-05-08 Thread Jim Fehlig
Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com All the migration code is done by the XenD subdriver which can be assumed to always be present Signed-off-by: Daniel P. Berrange berra...@redhat.com --- src/xen/xen_driver.c | 32 +--- 1

Re: [libvirt] [PATCH v3 11/34] Adapt to VIR_STRDUP and VIR_STRNDUP in src/node_device/*

2013-05-08 Thread Eric Blake
On 05/03/2013 08:53 AM, Michal Privoznik wrote: --- src/node_device/node_device_driver.c | 33 src/node_device/node_device_hal.c| 13 ++--- src/node_device/node_device_udev.c | 99 ++-- 3 files changed, 46 insertions(+), 99 deletions(-)

Re: [libvirt] [PATCH 23/40] Simplify the Xen driver define domain driver methods

2013-05-08 Thread Jim Fehlig
Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com Directly call either XenD or the XM driver for handling domain define operations. Signed-off-by: Daniel P. Berrange berra...@redhat.com --- src/xen/xen_driver.c| 28 ++--

Re: [libvirt] [PATCH 1/7] util: Fix regression of wwn reading

2013-05-08 Thread Eric Blake
On 05/06/2013 06:45 AM, Osier Yang wrote: Introduced by commit 244ce462e29, which refactored the helper for wwn reading, however, it forgot to change the old strndup and sizeof(buf), sizeof(buf) operates on the fixed length array (buf) in the old code, but now buf is a pointer. +++

Re: [libvirt] [PATCH 25/40] Simplify the Xen domain define/undefine driver methods

2013-05-08 Thread Jim Fehlig
Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com Make the domain define/undefine driver methods directly call into either the XenD or XM drivers Signed-off-by: Daniel P. Berrange berra...@redhat.com --- src/xen/xen_driver.c| 24

Re: [libvirt] [PATCH v3 12/34] Adapt to VIR_STRDUP and VIR_STRNDUP in src/interface/*

2013-05-08 Thread Eric Blake
On 05/03/2013 08:53 AM, Michal Privoznik wrote: --- src/interface/interface_backend_udev.c | 36 +- 1 file changed, 9 insertions(+), 27 deletions(-) ACK. -- Eric Blake eblake redhat com+1-919-301-3266 Libvirt virtualization library

Re: [libvirt] [PATCH 24/40] Simplify the Xen domain start driver method

2013-05-08 Thread Jim Fehlig
Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com Directly call either the XenD or XM driver when starting a persistent domain Signed-off-by: Daniel P. Berrange berra...@redhat.com --- src/xen/xen_driver.c| 20 +++- src/xen/xen_driver.h| 1 -

Re: [libvirt] [PATCH 26/40] Simplify the Xen domain attach/dettach driver methods

2013-05-08 Thread Jim Fehlig
Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com Make the domain attach/dettach driver methods directly call into either the XenD or XM drivers Signed-off-by: Daniel P. Berrange berra...@redhat.com --- src/xen/xen_driver.c| 55

Re: [libvirt] [PATCH 27/40] Simplify the Xen domain scheduler parameter driver methods

2013-05-08 Thread Jim Fehlig
Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com Make the Xen domain scheduler parameter methods directly call into XenD or Xen hypervisor drivers Signed-off-by: Daniel P. Berrange berra...@redhat.com --- src/xen/xen_driver.c | 54

Re: [libvirt] [PATCH v3 13/34] Adapt to VIR_STRDUP and VIR_STRNDUP in src/nwfilter/*

2013-05-08 Thread Eric Blake
On 05/03/2013 08:53 AM, Michal Privoznik wrote: --- src/nwfilter/nwfilter_dhcpsnoop.c | 22 +++--- src/nwfilter/nwfilter_driver.c| 7 +++ src/nwfilter/nwfilter_ebiptables_driver.c | 2 +- src/nwfilter/nwfilter_gentech_driver.c| 5 ++---

Re: [libvirt] [PATCH 28/40] Simplify the Xen domain autostart driver method

2013-05-08 Thread Jim Fehlig
Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com Unconditionally call into the XenD or XM drivers for autostart handling, since they are guaranteed to be open --- src/xen/xen_driver.c| 18 -- src/xen/xend_internal.c | 14 -- 2 files

Re: [libvirt] [PATCH 29/40] Simplify the Xen domain stats/peek / node memory driver methods

2013-05-08 Thread Jim Fehlig
Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com Make the Xen domain stats / peek and node memory driver methods unconditionally call the sub-drivers which are guaranteed to be open. Signed-off-by: Daniel P. Berrange berra...@redhat.com --- src/xen/xen_driver.c|

Re: [libvirt] [PATCH v3 14/34] Adapt to VIR_STRDUP and VIR_STRNDUP in src/openvz/*

2013-05-08 Thread Eric Blake
On 05/03/2013 08:53 AM, Michal Privoznik wrote: --- src/openvz/openvz_conf.c | 45 ++--- src/openvz/openvz_driver.c | 39 +++ 2 files changed, 37 insertions(+), 47 deletions(-) diff --git

Re: [libvirt] [Qemu-devel] virtio serial device problem

2013-05-08 Thread Alexey Kardashevskiy
Hi! On 05/09/2013 01:53 AM, fred.kon...@greensocs.com wrote: On 05/07/2013 07:50 PM, Paolo Bonzini wrote: Il 07/05/2013 09:20, Li Zhang ha scritto: Hi all, Hi, When we use the latest version of QEMU to build ovirt, we get this error reported from libvirt. What QEMU commit is this?

Re: [libvirt] LXC: user namespaces

2013-05-08 Thread Gao feng
On 04/30/2013 06:07 PM, Richard RW. Weinberger wrote: - Ursprüngliche Mail - We'd like to use libvirt for managing our lxc machines. Currently libvirt lacks of user namespace support. Is anyone working on that? Otherwise David and I will implement it and send patches very soon.

Re: [libvirt] [PATCH 30/40] Convert Xen domain lookup driver methods to use virDomainDefPtr

2013-05-08 Thread Jim Fehlig
Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com Introduce use of a virDomainDefPtr in the domain lookup APIs to simplify introduction of ACL security checks. The virDomainPtr cannot be safely used, since the app may have supplied mis-matching name/uuid/id fields. eg

Re: [libvirt] [PATCH v3 15/34] Adapt to VIR_STRDUP and VIR_STRNDUP in src/parallels/*

2013-05-08 Thread Eric Blake
On 05/03/2013 08:53 AM, Michal Privoznik wrote: --- src/parallels/parallels_driver.c | 71 +-- src/parallels/parallels_network.c | 23 + src/parallels/parallels_storage.c | 62 +++--- 3 files changed, 58

Re: [libvirt] [PATCH v3 16/34] Adapt to VIR_STRDUP and VIR_STRNDUP in src/phyp/*

2013-05-08 Thread Eric Blake
On 05/03/2013 08:53 AM, Michal Privoznik wrote: --- src/phyp/phyp_driver.c | 50 ++ 1 file changed, 10 insertions(+), 40 deletions(-) diff --git a/src/phyp/phyp_driver.c b/src/phyp/phyp_driver.c @@ -1141,15 +1137,9 @@

Re: [libvirt] [PATCH v3 17/34] Adapt to VIR_STRDUP and VIR_STRNDUP in src/qemu/*

2013-05-08 Thread Eric Blake
On 05/03/2013 08:53 AM, Michal Privoznik wrote: --- include/libvirt/libvirt.h.in | 10 +- src/qemu/qemu_capabilities.c | 79 src/qemu/qemu_cgroup.c | 4 +- src/qemu/qemu_command.c | 419 +-- src/qemu/qemu_conf.c | 58

Re: [libvirt] [PATCH v3 18/34] Adapt to VIR_STRDUP and VIR_STRNDUP in src/remote/*

2013-05-08 Thread Eric Blake
On 05/03/2013 08:53 AM, Michal Privoznik wrote: --- src/remote/remote_driver.c | 114 + 1 file changed, 44 insertions(+), 70 deletions(-) @@ -4472,15 +4449,15 @@ remoteDomainBuildEventGraphics(virNetClientProgramPtr prog ATTRIBUTE_UNUSED,

Re: [libvirt] [PATCH v3 19/34] Adapt to VIR_STRDUP and VIR_STRNDUP in src/rpc/*

2013-05-08 Thread Eric Blake
On 05/03/2013 08:53 AM, Michal Privoznik wrote: --- src/rpc/gendispatch.pl | 21 Ah, you DID notice the code generator, so that answers my comment on 18/34. src/rpc/virnetclient.c | 16 -- src/rpc/virnetmessage.c | 12 ---

Re: [libvirt] [PATCH v3 20/34] Adapt to VIR_STRDUP and VIR_STRNDUP in src/secret/*

2013-05-08 Thread Eric Blake
On 05/03/2013 08:53 AM, Michal Privoznik wrote: --- src/secret/secret_driver.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) Nice and short! ACK. diff --git a/src/secret/secret_driver.c b/src/secret/secret_driver.c index 377b9f4..5d1739f 100644 ---

Re: [libvirt] [PATCH v3 24/34] Adapt to VIR_STRDUP and VIR_STRNDUP in src/uml/*

2013-05-08 Thread Eric Blake
On 05/03/2013 08:53 AM, Michal Privoznik wrote: --- src/uml/uml_conf.c | 10 -- src/uml/uml_driver.c | 8 +++- 2 files changed, 7 insertions(+), 11 deletions(-) /me needs to go to bed before my eyes glaze over... +++ b/src/uml/uml_driver.c @@ -491,7 +490,7 @@

Re: [libvirt] [PATCH v3 28/34] Adapt to VIR_STRDUP and VIR_STRNDUP in src/vmx/*

2013-05-08 Thread Eric Blake
On 05/03/2013 08:53 AM, Michal Privoznik wrote: --- src/vmx/vmx.c | 36 ++-- 1 file changed, 6 insertions(+), 30 deletions(-) ACK. -- Eric Blake eblake redhat com+1-919-301-3266 Libvirt virtualization library http://libvirt.org signature.asc

Re: [libvirt] [PATCH v3 27/34] Adapt to VIR_STRDUP and VIR_STRNDUP in src/vmware/*

2013-05-08 Thread Eric Blake
On 05/03/2013 08:53 AM, Michal Privoznik wrote: --- src/vmware/vmware_conf.c | 28 ++-- src/vmware/vmware_driver.c | 11 +-- 2 files changed, 15 insertions(+), 24 deletions(-) ACK. -- Eric Blake eblake redhat com+1-919-301-3266 Libvirt

[libvirt] an old bug reappear-TimeoutError

2013-05-08 Thread yue
hi, i encounter an error of libvirt, which is reported in 2011. i intended to update the ticket(spice password) of vm. https://bugzilla.redhat.com/show_bug.cgi?id=676205 -log-- Thread-162::ERROR::2013-05-08 13:50:46,000::BindingXMLRPC::909::vdsm::(wrapper) libvirt