Re: [libvirt] [PATCH 4/6] Correctly detect warning flags with clang

2013-05-15 Thread Paul Eggert
On 05/13/2013 12:28 PM, Eric Blake wrote: Some of this needs to be imported into upstream gnulib. I gave it a try, by installing the following. I'll follow up on bug-gnulib with 7 other clang-related patches. From 45fc031e607cb82dce777228d9334cdac16ca648 Mon Sep 17 00:00:00 2001 From: Paul

Re: [libvirt] [PATCH v3 1/2] Add VNC WebSocket support

2013-05-15 Thread Martin Kletzander
On 05/13/2013 08:38 PM, John Ferlan wrote: On 05/13/2013 09:10 AM, Martin Kletzander wrote: Adding support for new attribute 'websocket' in the 'graphics' element, the attribute value is the port to listen on with '-1' meaning auto-allocation, '0' meaning no websockets. Signed-off-by: Martin

Re: [libvirt] [PATCH v3 2/2] qemu: Add VNC WebSocket support

2013-05-15 Thread Martin Kletzander
On 05/14/2013 09:15 AM, Guannan Ren wrote: On 05/13/2013 09:10 PM, Martin Kletzander wrote: [...] diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c index eddc263..7d80e74 100644 --- a/src/qemu/qemu_command.c +++ b/src/qemu/qemu_command.c @@ -6070,6 +6070,17 @@

Re: [libvirt] [PATCH] Update to COPYING.LIB to latest LGPLv2.1 copy

2013-05-15 Thread Christophe Fergeau
On Tue, May 14, 2013 at 04:38:34PM -0600, Eric Blake wrote: On 05/14/2013 03:02 AM, Christophe Fergeau wrote: I can send a patch removing that bit from configure.ac and adding a GPLv2 COPYING file, however - this is the first time I hear about such a requirement for LGPLv2

[libvirt] ANNOUNCE: Perl binding Sys-Virt release 1.0.5

2013-05-15 Thread Daniel P. Berrange
I am pleased to announce that release 1.0.5 of Sys-Virt, the libvirt Perl API binding is now available for download: http://search.cpan.org/CPAN/authors/id/D/DA/DANBERR/Sys-Virt-1.0.5.tar.gz Changed in this release: - Add all new APIs and constants in libvirt 1.0.4 and 1.0.5 Further

Re: [libvirt] [PATCH v2] interface: report generic error message of lookup failure

2013-05-15 Thread Laine Stump
On 05/14/2013 08:16 PM, Guannan Ren wrote: couldn't find interface named couldn't find interface with MAC address use generic message as follows couldn't find interface with If you were going to do this, having with at the end sounds awkward; it would be better to just make it couldn't find

Re: [libvirt] Warnings messages in logs from DHCP snooping code

2013-05-15 Thread Gao Yongwei
2013/2/28 Daniel P. Berrange berra...@redhat.com I'm noticing that VMs which have nwfilters associated with them will apparently always cause the following errors to appear in the logs upon VM shutdown: 2013-02-27 17:02:18.709+: 9669: error : virNWFilterDHCPSnoopEnd:2131 : internal

[libvirt] [PATCH 1/4] Remove obsolete pivotRoot flag in LXC driver

2013-05-15 Thread Daniel P. Berrange
From: Daniel P. Berrange berra...@redhat.com The lxcContainerMountBasicFS method had a 'bool pivotRoot' flag to control whether it mounted a private /dev. Since removal of the non-pivot root container setup codepaths, this flag is obsolete as the only caller always passes 'true'. Signed-off-by:

[libvirt] [PATCH 2/4] Stop passing around old root directory prefix

2013-05-15 Thread Daniel P. Berrange
From: Daniel P. Berrange berra...@redhat.com Many methods accept a string parameter specifying the old root directory prefix. Since removal of the non-pivot root container setup codepaths, this parameter is obsolete in many methods where the callers always pass /.oldroot. Signed-off-by: Daniel

[libvirt] [PATCH 3/4] Remove obsolete skipRoot flag in LXC driver

2013-05-15 Thread Daniel P. Berrange
From: Daniel P. Berrange berra...@redhat.com The lxcContainerMountAllFS method had a 'bool skipRoot' flag to control whether it mounts the / filesystem. Since removal of the non-pivot root container setup codepaths, this flag is obsolete as the only caller always passes 'true'. Signed-off-by:

[libvirt] [PATCH 4/4] Fix LXC startup when /var/run is an absolute symlink

2013-05-15 Thread Daniel P. Berrange
From: Daniel P. Berrange berra...@redhat.com During startup, the LXC driver uses paths such as /.oldroot/var/run/libvirt/lxc/... to access directories from the previous root filesystem after doing a pivot_root(). Unfortunately if /var/run is an absolute symlink to /run, instead of a relative

[libvirt] [PATCH 0/4] Misc cleanups fixes to LXC driver

2013-05-15 Thread Daniel P. Berrange
From: Daniel P. Berrange berra...@redhat.com This series starts with a few cleanup patches removing code that is no longer required. The final patch fixes an important bug preventing LXC startup on certain distros which unwisely chose to make /var/run an absolute symlink instead of a relative

Re: [libvirt] [libvirt PATCH] qemu: Support discard for disk

2013-05-15 Thread Martin Kletzander
On 05/14/2013 02:44 PM, Osier Yang wrote: QEMU introduced discard option for drive since commit a9384aff53, ... @var{discard} is one of ignore (or off) or unmap (or on) and controls whether @dfn{discard} (also known as @dfn{trim} or @dfn{unmap}) requests are ignored or passed to the

Re: [libvirt] [PATCH 2/4] Adjust comments to describe on_poweroff and on_reboot action

2013-05-15 Thread Michal Privoznik
On 24.04.2013 13:40, John Ferlan wrote: --- src/libvirt.c | 15 +++ 1 file changed, 11 insertions(+), 4 deletions(-) diff --git a/src/libvirt.c b/src/libvirt.c index c236152..4bd6c9a 100644 --- a/src/libvirt.c +++ b/src/libvirt.c @@ -3184,9 +3184,11 @@ error: *

Re: [libvirt] [PATCH 4/4] docs: Update formatdomain for lifecycle events

2013-05-15 Thread Michal Privoznik
On 24.04.2013 13:40, John Ferlan wrote: --- docs/formatdomain.html.in | 30 ++ 1 file changed, 22 insertions(+), 8 deletions(-) diff --git a/docs/formatdomain.html.in b/docs/formatdomain.html.in index 888c005..2c876ed 100644 --- a/docs/formatdomain.html.in +++

Re: [libvirt] [PATCH 0/4] Fix issues with guest lifecycle event action settings

2013-05-15 Thread Michal Privoznik
On 24.04.2013 13:40, John Ferlan wrote: https://bugzilla.redhat.com/show_bug.cgi?id=916052 Domain lifecycle events on_reboot and on_poweroff translate into QEMU command options no-reboot and no-shutdown at startup time. The existing code only checked the on_reboot setting to determine

[libvirt] [PATCH] Move VirtualBox driver into libvirtd

2013-05-15 Thread Daniel P. Berrange
From: Daniel P. Berrange berra...@redhat.com Change the build process driver initialization so that the VirtualBox driver is built into libvirtd, instead of libvirt.so This change avoids the VirtualBox GPLv2-only license causing compatibility problems with libvirt.so which is under the

Re: [libvirt] [PATCH 0/4] Fix issues with guest lifecycle event action settings

2013-05-15 Thread John Ferlan
On 05/15/2013 06:02 AM, Michal Privoznik wrote: On 24.04.2013 13:40, John Ferlan wrote: https://bugzilla.redhat.com/show_bug.cgi?id=916052 Domain lifecycle events on_reboot and on_poweroff translate into QEMU command options no-reboot and no-shutdown at startup time. The existing code only

[libvirt] [PATCH 1/3] qemu: Allow to specify the sysfs root for qemuBuildCommandLine

2013-05-15 Thread Osier Yang
Since 0d70656afded, it starts to access the sysfs files to build the qemu command line (by virSCSIDeviceGetSgName, which is find out the scsi generic device name by adpater:bus:target:unit), there is no way to work around, qemu wants to see the scsi generic device like /dev/sg6 anyway. And I

[libvirt] [PATCH 2/3] tests: Feed the fake sysfs root to qemuBuildCommandLine

2013-05-15 Thread Osier Yang
This creates a new directory sysfsroot under tests, any sysfs test input files should be put into it in future. Currently only the scsi-generic tests need to use it, so only one file path is created (bus/scsi/devices/0:0:0:0/scsi_generic/sg0/dev). --- src/qemu/qemu_cgroup.c

[libvirt] [PATCH 0/3] Fix the build failure

2013-05-15 Thread Osier Yang
As exposed by [1], qemuxml2argvtest fails because of it tries to access non-existing sysfs files when building qemu command for scsi-generic device. This creates tests/sysfsroot, uses it as the fake sysfs root, any future sysfs test input files should be put into it. [1]

[libvirt] [PATCH 3/3] tests: Move fchostdata into sysfsroot

2013-05-15 Thread Osier Yang
fchostdata is also about sysfs files, it can go home now. --- tests/Makefile.am | 2 +- tests/fchostdata/fc_host/host4/fabric_name| 1 - tests/fchostdata/fc_host/host4/max_npiv_vports| 1 - tests/fchostdata/fc_host/host4/node_name

Re: [libvirt] Build failed in Jenkins: libvirt-check #1003

2013-05-15 Thread Osier Yang
On 14/05/13 23:50, Guido Günther wrote: Hi Osier, On Mon, May 13, 2013 at 11:45:15PM +0800, Osier Yang wrote: On 13/05/13 23:25, Guido Günther wrote: On Mon, May 13, 2013 at 03:59:20PM +0100, Daniel P. Berrange wrote: On Mon, May 13, 2013 at 04:16:53PM +0200, Guido Günther wrote: Hi, I don't

Re: [libvirt] [libvirt PATCH] qemu: Support discard for disk

2013-05-15 Thread Osier Yang
On 15/05/13 18:00, Martin Kletzander wrote: On 05/14/2013 02:44 PM, Osier Yang wrote: QEMU introduced discard option for drive since commit a9384aff53, ... @var{discard} is one of ignore (or off) or unmap (or on) and controls whether @dfn{discard} (also known as @dfn{trim} or @dfn{unmap})

Re: [libvirt] [PATCH 1/3] qemu: Allow to specify the sysfs root for qemuBuildCommandLine

2013-05-15 Thread Daniel P. Berrange
On Wed, May 15, 2013 at 06:52:44PM +0800, Osier Yang wrote: Since 0d70656afded, it starts to access the sysfs files to build the qemu command line (by virSCSIDeviceGetSgName, which is find out the scsi generic device name by adpater:bus:target:unit), there is no way to work around, qemu wants

Re: [libvirt] [PATCH 1/3] qemu: Allow to specify the sysfs root for qemuBuildCommandLine

2013-05-15 Thread Daniel P. Berrange
On Wed, May 15, 2013 at 12:07:42PM +0100, Daniel P. Berrange wrote: On Wed, May 15, 2013 at 06:52:44PM +0800, Osier Yang wrote: Since 0d70656afded, it starts to access the sysfs files to build the qemu command line (by virSCSIDeviceGetSgName, which is find out the scsi generic device name

Re: [libvirt] [PATCH v2] interface: report generic error message of lookup failure

2013-05-15 Thread Guannan Ren
On 05/15/2013 05:03 PM, Laine Stump wrote: On 05/14/2013 08:16 PM, Guannan Ren wrote: couldn't find interface named couldn't find interface with MAC address use generic message as follows couldn't find interface with If you were going to do this, having with at the end sounds awkward; it

Re: [libvirt] [PATCH 1/3] qemu: Allow to specify the sysfs root for qemuBuildCommandLine

2013-05-15 Thread Osier Yang
On 15/05/13 19:09, Daniel P. Berrange wrote: On Wed, May 15, 2013 at 12:07:42PM +0100, Daniel P. Berrange wrote: On Wed, May 15, 2013 at 06:52:44PM +0800, Osier Yang wrote: Since 0d70656afded, it starts to access the sysfs files to build the qemu command line (by virSCSIDeviceGetSgName, which

Re: [libvirt] [PATCH] Move VirtualBox driver into libvirtd

2013-05-15 Thread Michal Privoznik
On 15.05.2013 12:33, Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com Change the build process driver initialization so that the VirtualBox driver is built into libvirtd, instead of libvirt.so This change avoids the VirtualBox GPLv2-only license causing compatibility

Re: [libvirt] [PATCH 2/4] Adjust comments to describe on_poweroff and on_reboot action

2013-05-15 Thread Martin Kletzander
On 05/15/2013 12:02 PM, Michal Privoznik wrote: On 24.04.2013 13:40, John Ferlan wrote: --- src/libvirt.c | 15 +++ 1 file changed, 11 insertions(+), 4 deletions(-) diff --git a/src/libvirt.c b/src/libvirt.c index c236152..4bd6c9a 100644 --- a/src/libvirt.c +++

Re: [libvirt] [PATCH 0/4] Misc cleanups fixes to LXC driver

2013-05-15 Thread Daniel P. Berrange
On Wed, May 15, 2013 at 07:59:43AM -0500, Dennis Jenkins wrote: On Wed, May 15, 2013 at 4:53 AM, Daniel P. Berrange berra...@redhat.comwrote: From: Daniel P. Berrange berra...@redhat.com This series starts with a few cleanup patches removing code that is no longer required. The final

Re: [libvirt] [PATCH 3/3] tests: Move fchostdata into sysfsroot

2013-05-15 Thread Guido Günther
On Wed, May 15, 2013 at 06:52:46PM +0800, Osier Yang wrote: fchostdata is also about sysfs files, it can go home now. --- tests/Makefile.am | 2 +- tests/fchostdata/fc_host/host4/fabric_name| 1 - tests/fchostdata/fc_host/host4/max_npiv_vports

Re: [libvirt] [libvirt PATCH] qemu: Support discard for disk

2013-05-15 Thread Daniel P. Berrange
On Wed, May 15, 2013 at 02:56:03PM +0200, Paolo Bonzini wrote: Il 14/05/2013 14:44, Osier Yang ha scritto: QEMU introduced discard option for drive since commit a9384aff53, ... @var{discard} is one of ignore (or off) or unmap (or on) and controls whether @dfn{discard} (also known as

Re: [libvirt] [PATCH 2/3] tests: Feed the fake sysfs root to qemuBuildCommandLine

2013-05-15 Thread Guido Günther
On Wed, May 15, 2013 at 06:52:45PM +0800, Osier Yang wrote: This creates a new directory sysfsroot under tests, any sysfs test input files should be put into it in future. Currently only the scsi-generic tests need to use it, so only one file path is created

Re: [libvirt] [libvirt PATCH] qemu: Support discard for disk

2013-05-15 Thread Paolo Bonzini
Il 14/05/2013 14:44, Osier Yang ha scritto: QEMU introduced discard option for drive since commit a9384aff53, ... @var{discard} is one of ignore (or off) or unmap (or on) and controls whether @dfn{discard} (also known as @dfn{trim} or @dfn{unmap}) requests are ignored or passed to the

Re: [libvirt] [libvirt PATCH] qemu: Support discard for disk

2013-05-15 Thread Martin Kletzander
On 05/15/2013 03:17 PM, Daniel P. Berrange wrote: On Wed, May 15, 2013 at 02:56:03PM +0200, Paolo Bonzini wrote: Il 14/05/2013 14:44, Osier Yang ha scritto: QEMU introduced discard option for drive since commit a9384aff53, ... @var{discard} is one of ignore (or off) or unmap (or on) and

Re: [libvirt] [PATCH 1/3] qemu: Allow to specify the sysfs root for qemuBuildCommandLine

2013-05-15 Thread Guido Günther
On Wed, May 15, 2013 at 06:52:44PM +0800, Osier Yang wrote: Since 0d70656afded, it starts to access the sysfs files to build the qemu command line (by virSCSIDeviceGetSgName, which is find I'm not a native speaker but s/which is/to/ sounds better to me. out the scsi generic device name by

Re: [libvirt] [PATCH 2/4] Stop passing around old root directory prefix

2013-05-15 Thread Michal Privoznik
On 15.05.2013 11:53, Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com Many methods accept a string parameter specifying the old root directory prefix. Since removal of the non-pivot root container setup codepaths, this parameter is obsolete in many methods where the

Re: [libvirt] [libvirt PATCH] qemu: Support discard for disk

2013-05-15 Thread Paolo Bonzini
Il 15/05/2013 15:17, Daniel P. Berrange ha scritto: On Wed, May 15, 2013 at 02:56:03PM +0200, Paolo Bonzini wrote: Il 14/05/2013 14:44, Osier Yang ha scritto: QEMU introduced discard option for drive since commit a9384aff53, ... @var{discard} is one of ignore (or off) or unmap (or on) and

[libvirt] [PATCH] Change label of fusefs mounted at /proc/meminfo in lxc containers

2013-05-15 Thread dwalsh
From: Dan Walsh dwa...@redhat.com We do not want to allow contained applications to be able to read fusefs_t. So we want /proc/meminfo label to match the system default proc_t. --- src/lxc/lxc_container.c | 24 1 file changed, 24 insertions(+) diff --git

[libvirt] This patch is needed for openshift domains to run ps command

2013-05-15 Thread dwalsh
I thought I sent this patch before, but I can not find a record of it, and do not see it in upstream. [PATCH] Change label of fusefs mounted at /proc/meminfo in lxc -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

[libvirt] [PATCH v3] virsh: lookup interface by name or mac other than one by one

2013-05-15 Thread Guannan Ren
Change virMacAddrParse() to accept NULL addr for mac address testing purpose. --- src/util/virmacaddr.c | 3 ++- tools/virsh-interface.c | 11 --- 2 files changed, 10 insertions(+), 4 deletions(-) diff --git a/src/util/virmacaddr.c b/src/util/virmacaddr.c index c4ca0a8..8e41844 100644

Re: [libvirt] [PATCH 0/4] Misc cleanups fixes to LXC driver

2013-05-15 Thread Michal Privoznik
On 15.05.2013 11:53, Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com This series starts with a few cleanup patches removing code that is no longer required. The final patch fixes an important bug preventing LXC startup on certain distros which unwisely chose to make

Re: [libvirt] [PATCH v3] virsh: lookup interface by name or mac other than one by one

2013-05-15 Thread Daniel P. Berrange
On Wed, May 15, 2013 at 09:50:48PM +0800, Guannan Ren wrote: Change virMacAddrParse() to accept NULL addr for mac address testing purpose. --- src/util/virmacaddr.c | 3 ++- tools/virsh-interface.c | 11 --- 2 files changed, 10 insertions(+), 4 deletions(-) diff --git

[libvirt] This patch tells SELinux a name to associate with the MCS Label.

2013-05-15 Thread dwalsh
[PATCH 1/1] libvirt patch to write a mcs translation file to -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

[libvirt] [PATCH 1/1] libvirt patch to write a mcs translation file to /run/setrans directory

2013-05-15 Thread dwalsh
From: Dan Walsh dwa...@redhat.com mcstransd is a translation tool that can translate MCS Labels into human understandable code. I have patched it to watch for translation files in the /run/setrans directory. This allows us to run commands like ps -eZ and see system_u:system_r:svirt_t:Fedora18

Re: [libvirt] [libvirt PATCH] qemu: Support discard for disk

2013-05-15 Thread Osier Yang
On 15/05/13 21:44, Paolo Bonzini wrote: Il 15/05/2013 15:17, Daniel P. Berrange ha scritto: On Wed, May 15, 2013 at 02:56:03PM +0200, Paolo Bonzini wrote: Il 14/05/2013 14:44, Osier Yang ha scritto: QEMU introduced discard option for drive since commit a9384aff53, ... @var{discard} is one of

Re: [libvirt] [PATCH 0/4] Misc cleanups fixes to LXC driver

2013-05-15 Thread Dennis Jenkins
On Wed, May 15, 2013 at 4:53 AM, Daniel P. Berrange berra...@redhat.comwrote: From: Daniel P. Berrange berra...@redhat.com This series starts with a few cleanup patches removing code that is no longer required. The final patch fixes an important bug preventing LXC startup on certain distros

Re: [libvirt] [libvirt PATCH] qemu: Support discard for disk

2013-05-15 Thread Daniel P. Berrange
On Wed, May 15, 2013 at 03:44:11PM +0200, Paolo Bonzini wrote: Il 15/05/2013 15:17, Daniel P. Berrange ha scritto: On Wed, May 15, 2013 at 02:56:03PM +0200, Paolo Bonzini wrote: Il 14/05/2013 14:44, Osier Yang ha scritto: QEMU introduced discard option for drive since commit a9384aff53,

Re: [libvirt] [PATCH] Move VirtualBox driver into libvirtd

2013-05-15 Thread Eric Blake
On 05/15/2013 04:33 AM, Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com Change the build process driver initialization so that the VirtualBox driver is built into libvirtd, instead of libvirt.so This change avoids the VirtualBox GPLv2-only license causing

[libvirt] [PATCH v4] virsh: lookup interface by name or mac other than one by one

2013-05-15 Thread Guannan Ren
Use virMacAddrParse() to distinguish interface name from interface mac address. --- tools/virsh-interface.c | 12 +--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/tools/virsh-interface.c b/tools/virsh-interface.c index f75c572..1c2e40b 100644 ---

Re: [libvirt] [PATCH 1/1] libvirt patch to write a mcs translation file to /run/setrans directory

2013-05-15 Thread Daniel P. Berrange
On Wed, May 15, 2013 at 09:56:33AM -0400, dwa...@redhat.com wrote: From: Dan Walsh dwa...@redhat.com mcstransd is a translation tool that can translate MCS Labels into human understandable code. I have patched it to watch for translation files in the /run/setrans directory. This allows us

[libvirt] Resend with corrected error handling

2013-05-15 Thread dwalsh
[PATCH] Change label of fusefs mounted at /proc/meminfo in lxc -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

[libvirt] [PATCH] Change label of fusefs mounted at /proc/meminfo in lxc containers

2013-05-15 Thread dwalsh
From: Dan Walsh dwa...@redhat.com We do not want to allow contained applications to be able to read fusefs_t. So we want /proc/meminfo label to match the system default proc_t. Fix checking of error codes --- src/lxc/lxc_container.c | 24 1 file changed, 24

Re: [libvirt] [PATCH] Change label of fusefs mounted at /proc/meminfo in lxc containers

2013-05-15 Thread Daniel P. Berrange
On Wed, May 15, 2013 at 10:35:48AM -0400, dwa...@redhat.com wrote: From: Dan Walsh dwa...@redhat.com We do not want to allow contained applications to be able to read fusefs_t. So we want /proc/meminfo label to match the system default proc_t. Fix checking of error codes ---

[libvirt] [PATCH 2/2] tests: Move fchostdata into sysfsroot

2013-05-15 Thread Osier Yang
fchostdata is also about sysfs files, it can go home now. --- tests/Makefile.am | 1 - tests/fchostdata/fc_host/host4/fabric_name| 1 - tests/fchostdata/fc_host/host4/max_npiv_vports| 1 - tests/fchostdata/fc_host/host4/node_name

[libvirt] [PATCH 0/2 v2] Fix the build failure

2013-05-15 Thread Osier Yang
As exposed by [1], qemuxml2argvtest fails because of it tries to access non-existing sysfs files when building qemu command for scsi-generic device. This creates tests/sysfsroot, uses it as the fake sysfs root, any future sysfs test input files should be put into it. [1]

Re: [libvirt] [PATCH 1/2] qemu: Add callback struct for qemuBuildCommandLine

2013-05-15 Thread Daniel P. Berrange
On Wed, May 15, 2013 at 11:25:19PM +0800, Osier Yang wrote: Since 0d70656afded, it starts to access the sysfs files to build the qemu command line (by virSCSIDeviceGetSgName, which is to find out the scsi generic device name by adpater:bus:target:unit), there is no way to work around, qemu

[libvirt] [PATCH 1/2] qemu: Add callback struct for qemuBuildCommandLine

2013-05-15 Thread Osier Yang
Since 0d70656afded, it starts to access the sysfs files to build the qemu command line (by virSCSIDeviceGetSgName, which is to find out the scsi generic device name by adpater:bus:target:unit), there is no way to work around, qemu wants to see the scsi generic device like /dev/sg6 anyway. And

Re: [libvirt] [PATCH 1/3] qemu: Allow to specify the sysfs root for qemuBuildCommandLine

2013-05-15 Thread Osier Yang
On 15/05/13 21:18, Guido Günther wrote: On Wed, May 15, 2013 at 06:52:44PM +0800, Osier Yang wrote: Since 0d70656afded, it starts to access the sysfs files to build the qemu command line (by virSCSIDeviceGetSgName, which is find I'm not a native speaker but s/which is/to/ sounds better to

Re: [libvirt] [PATCH] Change label of fusefs mounted at /proc/meminfo in lxc containers

2013-05-15 Thread Michal Privoznik
On 15.05.2013 16:35, dwa...@redhat.com wrote: From: Dan Walsh dwa...@redhat.com We do not want to allow contained applications to be able to read fusefs_t. So we want /proc/meminfo label to match the system default proc_t. Fix checking of error codes --- src/lxc/lxc_container.c | 24

Re: [libvirt] [PATCH 2/2] tests: Move fchostdata into sysfsroot

2013-05-15 Thread Daniel P. Berrange
On Wed, May 15, 2013 at 11:25:20PM +0800, Osier Yang wrote: fchostdata is also about sysfs files, it can go home now. --- tests/Makefile.am | 1 - tests/fchostdata/fc_host/host4/fabric_name| 1 - tests/fchostdata/fc_host/host4/max_npiv_vports

[libvirt] [PATCH] Don't mount selinux fs in LXC if selinux is disabled

2013-05-15 Thread Daniel P. Berrange
From: Daniel P. Berrange berra...@redhat.com Before trying to mount the selinux filesystem in a container use is_selinux_enabled() to check if the machine actually has selinux support (eg not booted with selinux=0) Signed-off-by: Daniel P. Berrange berra...@redhat.com ---

[libvirt] [PATCH] FreeBSD: disable buggy -fstack-protector-all

2013-05-15 Thread Roman Bogorodskiy
FreeBSD ships an old gcc 4.2.1 which generates bogus code, e.g. getsockopt() call returns struct xucred with bogus values, which doesn't even allow to connect to libvirtd: error: Failed to find group record for gid '1284660778': No error: 0 So roll back to just -fstack-protector on FreeBSD. ---

Re: [libvirt] [PATCH] FreeBSD: disable buggy -fstack-protector-all

2013-05-15 Thread Daniel P. Berrange
On Wed, May 15, 2013 at 07:41:49PM +0400, Roman Bogorodskiy wrote: FreeBSD ships an old gcc 4.2.1 which generates bogus code, e.g. getsockopt() call returns struct xucred with bogus values, which doesn't even allow to connect to libvirtd: error: Failed to find group record for gid

Re: [libvirt] [PATCH v2 3/4] Validate the bios_date format for sysinfo

2013-05-15 Thread Eric Blake
On 05/14/2013 04:22 AM, John Ferlan wrote: On 05/13/2013 03:51 PM, Eric Blake wrote: On 05/13/2013 11:01 AM, John Ferlan wrote: Add incorrectly formatted bios_date validation test --- In any case, in lieu of a v3, here's a diff: Thanks; that works. or more visually appealing if

Re: [libvirt] [PATCH 1/2] qemu: Add callback struct for qemuBuildCommandLine

2013-05-15 Thread Osier Yang
On 15/05/13 23:32, Daniel P. Berrange wrote: On Wed, May 15, 2013 at 11:25:19PM +0800, Osier Yang wrote: Since 0d70656afded, it starts to access the sysfs files to build the qemu command line (by virSCSIDeviceGetSgName, which is to find out the scsi generic device name by

Re: [libvirt] [PATCH 2/2] tests: Move fchostdata into sysfsroot

2013-05-15 Thread Osier Yang
On 15/05/13 23:36, Daniel P. Berrange wrote: On Wed, May 15, 2013 at 11:25:20PM +0800, Osier Yang wrote: fchostdata is also about sysfs files, it can go home now. --- tests/Makefile.am | 1 - tests/fchostdata/fc_host/host4/fabric_name| 1 -

Re: [libvirt] [PATCH] Don't mount selinux fs in LXC if selinux is disabled

2013-05-15 Thread Eric Blake
On 05/15/2013 09:27 AM, Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com Before trying to mount the selinux filesystem in a container use is_selinux_enabled() to check if the machine actually has selinux support (eg not booted with selinux=0) Signed-off-by: Daniel P.

Re: [libvirt] [PATCH v4] virsh: lookup interface by name or mac other than one by one

2013-05-15 Thread Eric Blake
On 05/15/2013 08:22 AM, Guannan Ren wrote: Use virMacAddrParse() to distinguish interface name from interface mac address. --- tools/virsh-interface.c | 12 +--- 1 file changed, 9 insertions(+), 3 deletions(-) ACK. -- Eric Blake eblake redhat com+1-919-301-3266 Libvirt

Re: [libvirt] [PATCH 1/3] qemu: Allow to specify the sysfs root for qemuBuildCommandLine

2013-05-15 Thread Laine Stump
On 05/15/2013 07:23 AM, Osier Yang wrote: On 15/05/13 19:09, Daniel P. Berrange wrote: On Wed, May 15, 2013 at 12:07:42PM +0100, Daniel P. Berrange wrote: On Wed, May 15, 2013 at 06:52:44PM +0800, Osier Yang wrote: Since 0d70656afded, it starts to access the sysfs files to build the qemu

Re: [libvirt] [PATCH 1/2] qemu: Add callback struct for qemuBuildCommandLine

2013-05-15 Thread Laine Stump
On 05/15/2013 11:25 AM, Osier Yang wrote: Since 0d70656afded, it starts to access the sysfs files to build the qemu command line (by virSCSIDeviceGetSgName, which is to find out the scsi generic device name by adpater:bus:target:unit), there is no way to work around, qemu wants to see the scsi

Re: [libvirt] [PATCH v2 0/4] Extra validation for the sysinfo section

2013-05-15 Thread John Ferlan
On 05/13/2013 01:01 PM, John Ferlan wrote: https://bugzilla.redhat.com/show_bug.cgi?id=890494 The sysinfo section needs an extra uuid validation check. The current check compares the numerical sysinfo/system_uuid with the domain uuid; however, it's possible that someone added extra hyphens

[libvirt] Second pass with cleanups suggested from Dan.

2013-05-15 Thread dwalsh
[PATCH 2/2] libvirt patch to write a mcs translation file to -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

[libvirt] [PATCH 2/2] libvirt patch to write a mcs translation file to /run/setrans directory

2013-05-15 Thread dwalsh
From: Dan Walsh dwa...@redhat.com mcstransd is a translation tool that can translate MCS Labels into human understandable code. I have patched it to watch for translation files in the /run/setrans directory. This allows us to run commands like ps -eZ and see system_u:system_r:svirt_t:Fedora18

Re: [libvirt] [PATCH v2 02/12] qemu: Move interface cmd line construction into a separate function

2013-05-15 Thread Laine Stump
On 05/13/2013 01:22 PM, Michal Privoznik wrote: Currently, we have one huge function to construct qemu command line. This is very ineffective esp. if there's a fault somewhere. --- src/qemu/qemu_command.c | 228 +--- 1 file changed, 121

Re: [libvirt] [PATCH v3 27/34] Adapt to VIR_STRDUP and VIR_STRNDUP in src/vmware/*

2013-05-15 Thread Matthias Bolte
2013/5/3 Michal Privoznik mpriv...@redhat.com: --- src/vmware/vmware_conf.c | 28 ++-- src/vmware/vmware_driver.c | 11 +-- 2 files changed, 15 insertions(+), 24 deletions(-) diff --git a/src/vmware/vmware_conf.c b/src/vmware/vmware_conf.c index

Re: [libvirt] [PATCH v2 03/12] qemu: Make qemuMonitorAddHostNetwork to pass multiple FDs

2013-05-15 Thread Laine Stump
On 05/13/2013 01:23 PM, Michal Privoznik wrote: Currently, only one tapfd and one vhostfd could be passed. However, multiqueue network requires several FDs to be passed to qemu so we must adapt out monitor handling functions to cope with that. --- src/qemu/qemu_hotplug.c | 7 +--

Re: [libvirt] [PATCH] FreeBSD: disable buggy -fstack-protector-all

2013-05-15 Thread Eric Blake
On 05/15/2013 10:01 AM, Daniel P. Berrange wrote: On Wed, May 15, 2013 at 07:41:49PM +0400, Roman Bogorodskiy wrote: FreeBSD ships an old gcc 4.2.1 which generates bogus code, e.g. getsockopt() call returns struct xucred with bogus values, which doesn't even allow to connect to libvirtd:

[libvirt] [PATCH] esx: Fix error reporting in esxVI_LookupManagedObjectHelper

2013-05-15 Thread Matthias Bolte
As the name parameter can be NULL the error message can only contain it conditionally. --- src/esx/esx_vi.c | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/src/esx/esx_vi.c b/src/esx/esx_vi.c index 5fd0693..d0df13d 100644 --- a/src/esx/esx_vi.c +++

Re: [libvirt] [PATCH] esx: Fix error reporting in esxVI_LookupManagedObjectHelper

2013-05-15 Thread Eric Blake
On 05/15/2013 03:44 PM, Matthias Bolte wrote: As the name parameter can be NULL the error message can only contain it conditionally. --- src/esx/esx_vi.c | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) ACK -- Eric Blake eblake redhat com+1-919-301-3266 Libvirt

[libvirt] [PATCH 3/4] maint: refer to correct license file

2013-05-15 Thread Eric Blake
Now that COPYING no longer contains the text of the LGPL, modify the LGPLv2-only files from vbox to call out the correct file. * src/vbox/vbox_CAPI_v2_2.h: Refer to correct file. * src/vbox/vbox_CAPI_v3_0.h: Likewise. * src/vbox/vbox_CAPI_v3_1.h: Likewise. * src/vbox/vbox_CAPI_v3_2.h: Likewise. *

[libvirt] [PATCH 4/4] maint: enforce correct copyright usage

2013-05-15 Thread Eric Blake
To ensure we don't regress and cause the need for further cleanups, add a 'make syntax-check' rule that ensures new files have proper copyright contents. * cfg.mk (sc_copyright_file): New rule. Signed-off-by: Eric Blake ebl...@redhat.com --- cfg.mk | 10 ++ 1 file changed, 10

[libvirt] [PATCH 2/4] maint: follow recommended practice for using LGPL

2013-05-15 Thread Eric Blake
https://www.gnu.org/licenses/gpl-howto.html states: You should also include a copy of the license itself somewhere in the distribution of your program. All programs, whether they are released under the GPL or LGPL, should include the text version of the GPL. In GNU programs the license is usually

[libvirt] [PATCH 0/4] Properly use LGPL

2013-05-15 Thread Eric Blake
The FSF has some recommendations on how to use the LGPL, and we weren't always following them. This series tries to clean things up to avoid any confusion on our intent - our source code is LGPLv2+ (except for vbox which is LGPLv2-only); the resulting binaries might be under a different license

[libvirt] [PATCH 1/4] maint: use LGPL correctly

2013-05-15 Thread Eric Blake
Several files called out COPYING or COPYING.LIB instead of using the normal boilerplate. It's especially important that we don't call out COPYING from an LGPL file, since COPYING is traditionally used for the GPL. A few files were lacking copyright altogether. * src/rpc/gendispatch.pl: Add

[libvirt] [PATCH v4] nwfilter: check for inverted ctdir

2013-05-15 Thread Stefan Berger
Linux netfilter at some point (Linux 2.6.39) inverted the meaning of the '--ctdir reply' and newer netfilter implementations now expect '--ctdir original' instead and vice-versa. We check for the kernel version and assume that all Linux kernels with version 2.6.39 have the newer inverted logic.

Re: [libvirt] [PATCH v4] nwfilter: check for inverted ctdir

2013-05-15 Thread Laine Stump
On 05/15/2013 08:39 PM, Stefan Berger wrote: Linux netfilter at some point (Linux 2.6.39) inverted the meaning of the '--ctdir reply' and newer netfilter implementations now expect '--ctdir original' instead and vice-versa. We check for the kernel version and assume that all Linux kernels with

Re: [libvirt] [PATCH v4] nwfilter: check for inverted ctdir

2013-05-15 Thread Eric Blake
On 05/15/2013 06:58 PM, Laine Stump wrote: On 05/15/2013 08:39 PM, Stefan Berger wrote: Linux netfilter at some point (Linux 2.6.39) inverted the meaning of the '--ctdir reply' and newer netfilter implementations now expect '--ctdir original' instead and vice-versa. We check for the kernel

Re: [libvirt] [PATCH v4] virsh: lookup interface by name or mac other than one by one

2013-05-15 Thread Guannan Ren
On 05/16/2013 12:52 AM, Eric Blake wrote: On 05/15/2013 08:22 AM, Guannan Ren wrote: Use virMacAddrParse() to distinguish interface name from interface mac address. --- tools/virsh-interface.c | 12 +--- 1 file changed, 9 insertions(+), 3 deletions(-) ACK. Thanks, pushed now.

Re: [libvirt] [PATCH 3/2] string: test VIR_STRDUP

2013-05-15 Thread Eric Blake
On 05/14/2013 06:50 AM, Ján Tomko wrote: On 05/07/2013 11:42 PM, Eric Blake wrote: The surest way to avoid regressions is to test documented behavior :) * tests/virstringtest.c (testStrdup): New test case. Signed-off-by: Eric Blake ebl...@redhat.com --- tests/virstringtest.c | 49

Re: [libvirt] [PATCH] Expand documentation for LXC driver

2013-05-15 Thread Eric Blake
On 05/14/2013 07:37 AM, Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com Update the LXC driver documentation to describe the way containers are setup by default. Also describe the common virsh commands for managing containers and a little about the security.

Re: [libvirt] [PATCH 1/3] qemu: Allow to specify the sysfs root for qemuBuildCommandLine

2013-05-15 Thread Osier Yang
On 16/05/13 01:09, Laine Stump wrote: On 05/15/2013 07:23 AM, Osier Yang wrote: On 15/05/13 19:09, Daniel P. Berrange wrote: On Wed, May 15, 2013 at 12:07:42PM +0100, Daniel P. Berrange wrote: On Wed, May 15, 2013 at 06:52:44PM +0800, Osier Yang wrote: Since 0d70656afded, it starts to access

Re: [libvirt] [PATCH 1/2] qemu: Add callback struct for qemuBuildCommandLine

2013-05-15 Thread Osier Yang
On 16/05/13 01:23, Laine Stump wrote: On 05/15/2013 11:25 AM, Osier Yang wrote: Since 0d70656afded, it starts to access the sysfs files to build the qemu command line (by virSCSIDeviceGetSgName, which is to find out the scsi generic device name by adpater:bus:target:unit), there is no way to

Re: [libvirt] [PATCH v2 04/12] qemu: Make qemuMonitorAddHostNetwork to pass multiple FDs

2013-05-15 Thread Laine Stump
On 05/13/2013 01:23 PM, Michal Privoznik wrote: Currently, only one tapfd and one vhostfd could be passed. However, multiqueue network requires several FDs to be passed to qemu so we must adapt out monitor handling functions to cope with that. This is the same patch as 03/12. How did you

Re: [libvirt] [PATCH v2 05/12] qemu: Adapt command line generation to multiqueue net

2013-05-15 Thread Laine Stump
On 05/13/2013 01:23 PM, Michal Privoznik wrote: The qemuBuildHostNetStr() function which is responsible for generating command line for a network interface needs to be aware of multiqueue network interface as we are required to use: - fd=%d in case of one FD - fds=%d:%d:%d:...:%d in

[libvirt] [PATCH 1/2] Make virNetDevSetupControl() public.

2013-05-15 Thread Roman Bogorodskiy
This method is useful not only in virnetdev.c. --- src/libvirt_private.syms | 1 + src/util/virnetdev.c | 15 +-- src/util/virnetdev.h | 12 src/util/virnetdevmacvlan.c | 2 +- src/util/virnetdevvportprofile.c | 2 +- 5 files

[libvirt] [PATCH 2/2] BSD: implement virNetDevTapCreate() and virNetDevTapDelete()

2013-05-15 Thread Roman Bogorodskiy
Implementation uses SIOCIFCREATE2 and SIOCIFDESTROY ioctls. --- src/util/virnetdevtap.c | 109 +++- 1 file changed, 107 insertions(+), 2 deletions(-) diff --git a/src/util/virnetdevtap.c b/src/util/virnetdevtap.c index 75599db..468d3a8 100644 ---

Re: [libvirt] [PATCH v2 06/12] util: Learn virNetDevTapCreate multiqueue network

2013-05-15 Thread Laine Stump
On 05/13/2013 01:23 PM, Michal Privoznik wrote: Currently, the function knows how to open a TAP device for a single time. However, in case of multiqueue network we need to open it multiple times. Moreover, when doing TUNSETIFF ioctl, the IFF_MULTI_QUEUE flag shall be requested. This commit