Re: [libvirt] Candidate release 2 for libvirt-1.1.0

2013-06-28 Thread Jason Helfman
On Thu, Jun 27, 2013 at 11:01 AM, Daniel Veillard veill...@redhat.comwrote: I have just tagged the release candidate 2 in git and sent a tarball to the usual place (rpms are coming): ftp://libvirt.org/libvirt/ This includes the end of the patch set from Laine, and hopefully it won't

Re: [libvirt] Candidate release 2 for libvirt-1.1.0

2013-06-28 Thread Laine Stump
On 06/28/2013 03:24 AM, Jason Helfman wrote: On Thu, Jun 27, 2013 at 11:01 AM, Daniel Veillard veill...@redhat.com mailto:veill...@redhat.com wrote: I have just tagged the release candidate 2 in git and sent a tarball to the usual place (rpms are coming):

Re: [libvirt] [PATCH] Allow RO connections to interface udev backend

2013-06-28 Thread Ján Tomko
On 06/28/2013 03:48 AM, Doug Goldstein wrote: The udev based interface backend did not allow querying data over a read-only connection which is different than how the netcf backend operates. This brings the behavior inline with the default, netcf backend. ---

Re: [libvirt] [PATCHv2 0/2] Swap order of AddImplicitControllers and DomainDefPostParse

2013-06-28 Thread Ján Tomko
On 06/17/2013 04:17 PM, Viktor Mihajlovski wrote: Implicit controllers may be dependent on device definitions altered in a post-parse callback. E.g., if a console device is defined without the target type, the type will be set in QEMU's callback. In the case of s390, this is virtio, which

[libvirt] [PATCH] util: fix build error on non-Linux systems

2013-06-28 Thread Laine Stump
Building on FreeBSD had this linker error: /work/a/ports/devel/libvirt/work/libvirt-1.1.0/src/.libs/libvirt.so: undefined reference to `virPCIDeviceAddressParse' This was caused by the new use of virPCIDeviceAddressParse in a portion of virpci.c that wasn't linux-only (in commit 72c029d8).

[libvirt] Design of virDomainSnapshotExport/Import

2013-06-28 Thread Xu Wang
Applications based on libvirt such as OpenStack need some public APIs about export/import of external snapshot during daily backup, snapshot recovery or system migration. virDomainSnapshotDiskExport, virDomainSnapshotVmstateExport and virDomainSnapshotImport are designed to satisfy such

Re: [libvirt] Candidate release 2 for libvirt-1.1.0

2013-06-28 Thread Laine Stump
On 06/28/2013 03:44 AM, Laine Stump wrote: On 06/28/2013 03:24 AM, Jason Helfman wrote: On Thu, Jun 27, 2013 at 11:01 AM, Daniel Veillard veill...@redhat.com mailto:veill...@redhat.com wrote: I have just tagged the release candidate 2 in git and sent a tarball

Re: [libvirt] [PATCH] Drop iptablesContext

2013-06-28 Thread Laine Stump
On 06/28/2013 12:52 AM, Roman Bogorodskiy wrote: iptablesContext holds only 4 pairs of iptables (table, chain) and there's no need to pass it around. This is a first step towards separating bridge_driver.c in platform-specific parts. --- src/libvirt_private.syms| 2 -

Re: [libvirt] [PATCH]Fix vPort Manage of FC vHBA creation

2013-06-28 Thread Ján Tomko
On 06/28/2013 03:22 AM, Dennis Chen wrote: When create a virtual FC HBA with virsh/libvirt API, an error message will be returned:error: Node device not found, also the 'nodedev-dumpxml' shows wrong information of wwpn wwnn for the new created device. Signed-off-by:xsc...@tnsoft.com.cn

Re: [libvirt] [PATCH] Drop iptablesContext

2013-06-28 Thread Daniel P. Berrange
On Fri, Jun 28, 2013 at 12:52:30AM -0400, Roman Bogorodskiy wrote: iptablesContext holds only 4 pairs of iptables (table, chain) and there's no need to pass it around. This is a first step towards separating bridge_driver.c in platform-specific parts. --- src/libvirt_private.syms|

[libvirt] [PATCH v2] Make logical pools independent on target path

2013-06-28 Thread Martin Kletzander
When using logical pools, we had to trust the target-path provided. This parameter, however, can be completely ommited and we can get the correct path using 'lvdisplay' command. In order not to omit the target.path completely, we rather default it to '/dev/source.name' which is used to check the

Re: [libvirt] [PATCH V2] Expose all CPU features in host definition

2013-06-28 Thread Daniel P. Berrange
On Thu, Jun 27, 2013 at 10:35:58AM -0600, Don Dugger wrote: On Mon, Jun 17, 2013 at 10:27:36AM +0200, Jiri Denemark wrote: On Fri, Jun 14, 2013 at 12:32:35 -0600, Don Dugger wrote: On Fri, Jun 14, 2013 at 03:06:52PM +0200, Jiri Denemark wrote: I was just trying to say that it doesn't

[libvirt] Bug 979260 - cpu hot-add doesn't work with upstream libvirt 1.0.6 + qemu 1.5.50

2013-06-28 Thread chandrashekar shastri
Hi All, I have filed the following bug for CPU hot-add issue: Bug 979260 - cpu hot-add doesn't work with upstream libvirt 1.0.6 + qemu 1.5.50 Thanks, Chandrashekar -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH]Fix vPort Manage of FC vHBA creation

2013-06-28 Thread Dennis Chen
On 06/28/2013 04:39 PM, Ján Tomko wrote: On 06/28/2013 03:22 AM, Dennis Chen wrote: When create a virtual FC HBA with virsh/libvirt API, an error message will be returned:error: Node device not found, also the 'nodedev-dumpxml' shows wrong information of wwpn wwnn for the new created device.

Re: [libvirt] Bug 979260 - cpu hot-add doesn't work with upstream libvirt 1.0.6 + qemu 1.5.50

2013-06-28 Thread Peter Krempa
On 06/28/13 11:25, chandrashekar shastri wrote: Hi All, I have filed the following bug for CPU hot-add issue: Bug 979260 - cpu hot-add doesn't work with upstream libvirt 1.0.6 + qemu 1.5.50 The hotplug feature in qemu 1.5 uses a new monitor command. The support was recently added to libvirt

Re: [libvirt] [PATCH]Fix vPort Manage of FC vHBA creation

2013-06-28 Thread Daniel P. Berrange
On Fri, Jun 28, 2013 at 05:30:14PM +0800, Dennis Chen wrote: On 06/28/2013 04:39 PM, Ján Tomko wrote: On 06/28/2013 03:22 AM, Dennis Chen wrote: When create a virtual FC HBA with virsh/libvirt API, an error message will be returned:error: Node device not found, also the 'nodedev-dumpxml'

Re: [libvirt] [PATCH] add support for libssh2 password from auth file

2013-06-28 Thread David Maciejak
enclosed the patch from git repo On Thu, Jun 27, 2013 at 2:31 PM, David Maciejak david.macie...@gmail.comwrote: Hi, I was discussing with Daniel about the best way to pass the ssh password when using such kind of uri: 'xen+libssh2:// root@192.168.0.10?sshauth=password' As it seems

Re: [libvirt] [RFC PATCH 2/2] LXC: Create ro overlay mounts only if we're not within a user namespace

2013-06-28 Thread Daniel P. Berrange
On Thu, Jun 27, 2013 at 08:56:25AM +0800, Gao feng wrote: On 06/26/2013 07:01 PM, Daniel P. Berrange wrote: On Wed, Jun 26, 2013 at 05:56:19PM +0800, Gao feng wrote: On 06/26/2013 05:38 PM, Daniel P. Berrange wrote: On Wed, Jun 26, 2013 at 10:26:10AM +0800, Gao feng wrote: On 06/26/2013

[libvirt] Bug 979360 - Libvirt fails to Bootstrap fails for local gnulib with 1.0.6

2013-06-28 Thread chandrashekar shastri
Hi All, I have filed the following bug for Libvirt (Upstream) Compilation with local gnulib issue : *Bug 979360* https://bugzilla.redhat.com/show_bug.cgi?id=979360 -Libvirt fails to Bootstrap fails for local gnulib with 1.0.6 Thanks, Chandrashekar -- libvir-list mailing list

[libvirt] RFC: Introduce API to query IP addresses for given domain

2013-06-28 Thread Nehal J. Wani
Hello, fellow developers! I am a GSoC candidate this year working for libvirt.org. My project is Introduce API to query IP addresses for given domain. The discussion regarding this feature had started here: http://www.mail-archive.com/libvir-list@redhat.com/msg51857.html and then Michal had

Re: [libvirt] [PATCH] add support for libssh2 password from auth file

2013-06-28 Thread Peter Krempa
On 06/27/13 14:31, David Maciejak wrote: Hi, I was discussing with Daniel about the best way to pass the ssh password when using such kind of uri: 'xen+libssh2://root@192.168.0.10?sshauth=password http://root@192.168.0.10?sshauth=password' As it seems passing the password in the uri is not a

Re: [libvirt] [PATCH]Fix vPort Manage of FC vHBA creation

2013-06-28 Thread Ján Tomko
On 06/28/2013 11:39 AM, Daniel P. Berrange wrote: On Fri, Jun 28, 2013 at 05:30:14PM +0800, Dennis Chen wrote: On 06/28/2013 04:39 PM, Ján Tomko wrote: On 06/28/2013 03:22 AM, Dennis Chen wrote: When create a virtual FC HBA with virsh/libvirt API, an error message will be returned:error:

Re: [libvirt] [PATCH]Fix vPort Manage of FC vHBA creation

2013-06-28 Thread Daniel P. Berrange
On Fri, Jun 28, 2013 at 12:28:25PM +0200, Ján Tomko wrote: On 06/28/2013 11:39 AM, Daniel P. Berrange wrote: On Fri, Jun 28, 2013 at 05:30:14PM +0800, Dennis Chen wrote: On 06/28/2013 04:39 PM, Ján Tomko wrote: On 06/28/2013 03:22 AM, Dennis Chen wrote: When create a virtual FC HBA with

Re: [libvirt] [PATCH] build: Fix VPATH build for access/*

2013-06-28 Thread Jiri Denemark
On Thu, Jun 27, 2013 at 18:24:16 +0200, Viktor Mihajlovski wrote: VPATH build failed for the generated access driver files. Signed-off-by: Viktor Mihajlovski mihaj...@linux.vnet.ibm.com --- src/Makefile.am | 23 +-- 1 file changed, 13 insertions(+), 10 deletions(-)

Re: [libvirt] [PATCHv2 0/2] Swap order of AddImplicitControllers and DomainDefPostParse

2013-06-28 Thread Viktor Mihajlovski
On 06/28/2013 09:56 AM, Ján Tomko wrote: ACK to both. Now pushed. Jan Thanks! -- Mit freundlichen Grüßen/Kind Regards Viktor Mihajlovski IBM Deutschland Research Development GmbH Vorsitzender des Aufsichtsrats: Martina Köderitz Geschäftsführung: Dirk Wittkopp Sitz der Gesellschaft:

Re: [libvirt] [PATCH] build: Fix VPATH build for access/*

2013-06-28 Thread Viktor Mihajlovski
On 06/28/2013 12:46 PM, Jiri Denemark wrote: On Thu, Jun 27, 2013 at 18:24:16 +0200, Viktor Mihajlovski wrote: VPATH build failed for the generated access driver files. Signed-off-by: Viktor Mihajlovski mihaj...@linux.vnet.ibm.com --- src/Makefile.am | 23 +-- 1 file

Re: [libvirt] [PATCH] add support for libssh2 password from auth file

2013-06-28 Thread Michal Novotny
On 06/28/2013 12:28 PM, Peter Krempa wrote: On 06/27/13 14:31, David Maciejak wrote: Hi, I was discussing with Daniel about the best way to pass the ssh password when using such kind of uri: 'xen+libssh2://root@192.168.0.10?sshauth=password http://root@192.168.0.10?sshauth=password' As

[libvirt] [PATCH] qemu: Restored original console alias

2013-06-28 Thread Michal Privoznik
Because of some crazy backward compatibility, console device is in some cases just an alias to a serial device. This means, in the process of generating XML description of a domain, all the interesting info is taken from corresponding serial device, if that's the case. Including the device alias.

Re: [libvirt] [PATCH] qemu: Restored original console alias

2013-06-28 Thread Daniel P. Berrange
On Fri, Jun 28, 2013 at 01:11:40PM +0200, Michal Privoznik wrote: Because of some crazy backward compatibility, console device is in some cases just an alias to a serial device. This means, in the process of generating XML description of a domain, all the interesting info is taken from

Re: [libvirt] [PATCH] add support for libssh2 password from auth file

2013-06-28 Thread David Maciejak
On Fri, Jun 28, 2013 at 1:03 PM, Michal Novotny minov...@redhat.com wrote: On 06/28/2013 12:28 PM, Peter Krempa wrote: On 06/27/13 14:31, David Maciejak wrote: Hi, I was discussing with Daniel about the best way to pass the ssh password when using such kind of uri:

Re: [libvirt] [PATCH] add support for libssh2 password from auth file

2013-06-28 Thread Michal Novotny
On 06/28/2013 01:41 PM, David Maciejak wrote: On Fri, Jun 28, 2013 at 1:03 PM, Michal Novotny minov...@redhat.com mailto:minov...@redhat.com wrote: On 06/28/2013 12:28 PM, Peter Krempa wrote: On 06/27/13 14:31, David Maciejak wrote: Hi, I was discussing with

Re: [libvirt] [PATCH] Allow RO connections to interface udev backend

2013-06-28 Thread Doug Goldstein
On Fri, Jun 28, 2013 at 2:49 AM, Ján Tomko jto...@redhat.com wrote: On 06/28/2013 03:48 AM, Doug Goldstein wrote: The udev based interface backend did not allow querying data over a read-only connection which is different than how the netcf backend operates. This brings the behavior inline

[libvirt] [PATCH] Replace use of 'in_addr_t' with 'struct in_addr'

2013-06-28 Thread Daniel P. Berrange
From: Daniel P. Berrange berra...@redhat.com The 'in_addr_t' typedef is not present in Mingw64 headers. Instead we can use the more portable 'struct in_addr' and then access its 's_addr' field. Signed-off-by: Daniel P. Berrange berra...@redhat.com --- src/util/virsocketaddr.c | 4 ++-- 1 file

Re: [libvirt] [PATCH] add support for libssh2 password from auth file

2013-06-28 Thread Daniel P. Berrange
On Fri, Jun 28, 2013 at 01:43:44PM +0200, Michal Novotny wrote: if libvirt doesn't have the tokenizer support yet, it may be a good RFE as I believe it could be really useful ;-) Peter, do you know about anything libvirt supports to tokenize string? We have virStringSplit for tokenizing

Re: [libvirt] [PATCH] add support for libssh2 password from auth file

2013-06-28 Thread Michal Novotny
On 06/28/2013 01:48 PM, Daniel P. Berrange wrote: On Fri, Jun 28, 2013 at 01:43:44PM +0200, Michal Novotny wrote: if libvirt doesn't have the tokenizer support yet, it may be a good RFE as I believe it could be really useful ;-) Peter, do you know about anything libvirt supports to tokenize

Re: [libvirt] [PATCH] Allow RO connections to interface udev backend

2013-06-28 Thread Daniel P. Berrange
On Fri, Jun 28, 2013 at 06:43:37AM -0500, Doug Goldstein wrote: On Fri, Jun 28, 2013 at 2:49 AM, Ján Tomko jto...@redhat.com wrote: On 06/28/2013 03:48 AM, Doug Goldstein wrote: The udev based interface backend did not allow querying data over a read-only connection which is different

Re: [libvirt] [PATCH] add support for libssh2 password from auth file

2013-06-28 Thread Peter Krempa
On 06/28/13 13:50, Michal Novotny wrote: On 06/28/2013 01:48 PM, Daniel P. Berrange wrote: On Fri, Jun 28, 2013 at 01:43:44PM +0200, Michal Novotny wrote: if libvirt doesn't have the tokenizer support yet, it may be a good RFE as I believe it could be really useful ;-) Peter, do you know

Re: [libvirt] [PATCH] add support for libssh2 password from auth file

2013-06-28 Thread Daniel P. Berrange
On Fri, Jun 28, 2013 at 01:50:08PM +0200, Michal Novotny wrote: On 06/28/2013 01:48 PM, Daniel P. Berrange wrote: On Fri, Jun 28, 2013 at 01:43:44PM +0200, Michal Novotny wrote: if libvirt doesn't have the tokenizer support yet, it may be a good RFE as I believe it could be really useful

Re: [libvirt] [PATCH] add support for libssh2 password from auth file

2013-06-28 Thread Michal Novotny
On 06/28/2013 01:54 PM, Peter Krempa wrote: On 06/28/13 13:50, Michal Novotny wrote: On 06/28/2013 01:48 PM, Daniel P. Berrange wrote: On Fri, Jun 28, 2013 at 01:43:44PM +0200, Michal Novotny wrote: if libvirt doesn't have the tokenizer support yet, it may be a good RFE as I believe it could

Re: [libvirt] [PATCH] Replace use of 'in_addr_t' with 'struct in_addr'

2013-06-28 Thread Jiri Denemark
On Fri, Jun 28, 2013 at 12:45:14 +0100, Daniel Berrange wrote: From: Daniel P. Berrange berra...@redhat.com The 'in_addr_t' typedef is not present in Mingw64 headers. Instead we can use the more portable 'struct in_addr' and then access its 's_addr' field. Signed-off-by: Daniel P.

Re: [libvirt] [PATCH] add support for libssh2 password from auth file

2013-06-28 Thread David Maciejak
On Fri, Jun 28, 2013 at 1:55 PM, Michal Novotny minov...@redhat.com wrote: On 06/28/2013 01:54 PM, Peter Krempa wrote: On 06/28/13 13:50, Michal Novotny wrote: On 06/28/2013 01:48 PM, Daniel P. Berrange wrote: On Fri, Jun 28, 2013 at 01:43:44PM +0200, Michal Novotny wrote: if libvirt

Re: [libvirt] Candidate release 2 for libvirt-1.1.0

2013-06-28 Thread Doug Goldstein
On Thu, Jun 27, 2013 at 9:46 PM, Doug Goldstein car...@gentoo.org wrote: On Thu, Jun 27, 2013 at 11:01 AM, Daniel Veillard veill...@redhat.comwrote: I have just tagged the release candidate 2 in git and sent a tarball to the usual place (rpms are coming): ftp://libvirt.org/libvirt/

[libvirt] Bug 979411 - virsh migration copy-storage-all fails with Unable to read from monitor: Connection reset by peer

2013-06-28 Thread chandrashekar shastri
Hi, I have filed a bug for virsh migration copy-storage-all: Bug 979411 - virsh migration copy-storage-all fails with Unable to read from monitor: Connection reset by peer Earlier I had filed this bug in launched: Bug #1192499 : virsh migration copy-storage-all fails with Unable to read

[libvirt] [PATCH] domain_conf: Include the correct console alias

2013-06-28 Thread Michal Privoznik
For some crazy backward compatibility, a console can by just an alias to a serial device. This is detected in the XML formating function which takes the values to format from corresponding serial device. Including the device alias. This results in wrong alias being written into the XML definition:

Re: [libvirt] [PATCH] domain_conf: Include the correct console alias

2013-06-28 Thread Daniel P. Berrange
On Fri, Jun 28, 2013 at 03:31:17PM +0200, Michal Privoznik wrote: For some crazy backward compatibility, a console can by just an alias to a serial device. This is detected in the XML formating function which takes the values to format from corresponding serial device. Including the device

Re: [libvirt] [Libvirt-announce] Candidate release 2 for libvirt-1.1.0

2013-06-28 Thread Justin Clift
On 27/06/2013, at 5:01 PM, Daniel Veillard wrote: I have just tagged the release candidate 2 in git and sent a tarball to the usual place (rpms are coming): ftp://libvirt.org/libvirt/ Sorry for the delay, only just now remembered to test this. :) Compilation is failing on OSX 10.7 x64

Re: [libvirt] [Libvirt-announce] Candidate release 2 for libvirt-1.1.0

2013-06-28 Thread Daniel P. Berrange
On Fri, Jun 28, 2013 at 03:01:58PM +0100, Justin Clift wrote: On 27/06/2013, at 5:01 PM, Daniel Veillard wrote: I have just tagged the release candidate 2 in git and sent a tarball to the usual place (rpms are coming): ftp://libvirt.org/libvirt/ Sorry for the delay, only just now

Re: [libvirt] [Libvirt-announce] Candidate release 2 for libvirt-1.1.0

2013-06-28 Thread Justin Clift
On 28/06/2013, at 3:05 PM, Daniel P. Berrange wrote: On Fri, Jun 28, 2013 at 03:01:58PM +0100, Justin Clift wrote: snip Googling shows IF_MAXUNIT in context of FreeBSD stuff. Not sure of the right approach here. eg exclude compiling this on OSX, or alternatively make-it-work on OSX. Yes,

[libvirt] [PATCH 0/4] libxl: implement some chuncks of the NUMA interface

2013-06-28 Thread Dario Faggioli
Hi Jim, Everyone, First patch series, so maybe a small introduction is required: I'm Dario and I work for Citrix on improving the NUMA support of Xen. This patch series implements some of the missing bits and pieces, in the libxl driver, regarding obtaining per-host and per-domain NUMA related

[libvirt] [PATCH 1/4] libxl: implement NUMA capabilities reporting

2013-06-28 Thread Dario Faggioli
Starting from Xen 4.2, libxl has all the bits and pieces are in place for retrieving an adequate amount of information about the host NUMA topology. It is therefore possible, after a bit of shuffling, to arrange those information in the way libvirt wants to present them to the outside world.

[libvirt] [PATCH 2/4] libxl: implement per NUMA node free memory reporting

2013-06-28 Thread Dario Faggioli
By providing the implementation of nodeGetCellsFreeMemory for the driver. This is all just a matter of properly formatting, in a way that libvirt like, what Xen provides via libxl_get_numainfo(). [raistlin@Zhaman ~]$ sudo virsh --connect xen:/// freecell --all 0: 25004 KiB 1:

[libvirt] [PATCH 3/4] libxl: advertise the support for VIR_TYPED_PARAM_STRING

2013-06-28 Thread Dario Faggioli
domainGetNumaParameters has a string typed parameter, hence it is necessary for the libxl driver to support this. This change implements the connectSupportsFeature hook for the libxl driver, advertising that VIR_DRV_FEATURE_TYPED_PARAM_STRING is something good to go. Signed-off-by: Dario

[libvirt] [PATCH 4/4] libxl: implement virDomainGetNumaParameters

2013-06-28 Thread Dario Faggioli
Although, having it depending on Xen = 4.3 (by using the proper libxl feature flag). Xen currently implements a NUMA placement policy which is basically the same as the 'interleaved' policy of `numactl', although it can be applied on a subset of the available nodes. We therefore hardcode

Re: [libvirt] [PATCH] domain_conf: Include the correct console alias

2013-06-28 Thread Michal Privoznik
On 28.06.2013 15:55, Daniel P. Berrange wrote: On Fri, Jun 28, 2013 at 03:31:17PM +0200, Michal Privoznik wrote: For some crazy backward compatibility, a console can by just an alias to a serial device. This is detected in the XML formating function which takes the values to format from

[libvirt] [PATCH glib] Fix name of gvir_config_domain_chardev_source_pty_set_path

2013-06-28 Thread Daniel P. Berrange
From: Daniel P. Berrange berra...@redhat.com The method gvir_config_domain_chardev_source_pty_set_path was accidentally called gvir_config_domain_source_pty_set_path. This naming flaw in turn caused the introspection data to be incorrectly generated, putting a 'source_pty_set_path' method on the

Re: [libvirt] [PATCH] domain_conf: Include the correct console alias

2013-06-28 Thread Daniel P. Berrange
On Fri, Jun 28, 2013 at 04:45:08PM +0200, Michal Privoznik wrote: On 28.06.2013 15:55, Daniel P. Berrange wrote: On Fri, Jun 28, 2013 at 03:31:17PM +0200, Michal Privoznik wrote: For some crazy backward compatibility, a console can by just an alias to a serial device. This is detected in

[libvirt] [PATCH 2/3] qemu: Use qemuDomainMemoryLimit when computing memory for VFIO

2013-06-28 Thread Jiri Denemark
--- src/qemu/qemu_command.c | 17 +++-- src/qemu/qemu_domain.c | 16 src/qemu/qemu_hotplug.c | 18 -- 3 files changed, 31 insertions(+), 20 deletions(-) diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c index 4d70004..f902501 100644 ---

[libvirt] [PATCH 3/3] qemu: Set RLIMIT_MEMLOCK when memoryBacking/locked is used

2013-06-28 Thread Jiri Denemark
If a domain is configured to have all its memory locked, we need to set RLIMIT_MEMLOCK so that QEMU is actually allowed to lock the memory. --- src/qemu/qemu_command.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c index f902501..278d2f2

[libvirt] [PATCH 0/3] qemu: Make setting memory limits consistent

2013-06-28 Thread Jiri Denemark
We need to set memory limits in several cases: - when setting hard_limit in memory cgroup - when starting a domain with a VFIO PCI device attached - when hotplugging a VFIO PCI device - when memoryBacking/locked is used This series makes use of a shared code to compute the limits in all of those

[libvirt] [PATCH 1/3] qemu: Move memory limit computation to a reusable function

2013-06-28 Thread Jiri Denemark
--- src/qemu/qemu_cgroup.c | 21 ++--- src/qemu/qemu_domain.c | 29 + src/qemu/qemu_domain.h | 2 ++ 3 files changed, 33 insertions(+), 19 deletions(-) diff --git a/src/qemu/qemu_cgroup.c b/src/qemu/qemu_cgroup.c index 5f54ca6..22bf78e 100644 ---

Re: [libvirt] [PATCH] domain_conf: Include the correct console alias

2013-06-28 Thread Michal Privoznik
On 28.06.2013 17:01, Daniel P. Berrange wrote: On Fri, Jun 28, 2013 at 04:45:08PM +0200, Michal Privoznik wrote: On 28.06.2013 15:55, Daniel P. Berrange wrote: On Fri, Jun 28, 2013 at 03:31:17PM +0200, Michal Privoznik wrote: For some crazy backward compatibility, a console can by just an

Re: [libvirt] [PATCH] Document security reporting handling process

2013-06-28 Thread Eric Blake
On 06/04/2013 09:33 AM, Eric Blake wrote: On 06/04/2013 04:06 AM, Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com Historically security issues in libvirt have been primarily triaged fixed by the Red Hat libvirt members Red Hat security team, who then usually notify

[libvirt] [PATCH] doc: Fix reference to #elementsUSB

2013-06-28 Thread Philipp Hahn
aae0fc2a922b3e31dae7648c547fca2ac2587625 removed the #elementsUSB anchor but did not update the links to point to the new section #elementsHostDev. Signed-off-by: Philipp Hahn h...@univention.de --- docs/formatdomain.html.in |2 +- docs/formatnode.html.in |2 +- 2 files changed, 2

Re: [libvirt] [PATCH V2] Expose all CPU features in host definition

2013-06-28 Thread Don Dugger
On Fri, Jun 28, 2013 at 10:24:48AM +0100, Daniel P. Berrange wrote: On Thu, Jun 27, 2013 at 10:35:58AM -0600, Don Dugger wrote: On Mon, Jun 17, 2013 at 10:27:36AM +0200, Jiri Denemark wrote: On Fri, Jun 14, 2013 at 12:32:35 -0600, Don Dugger wrote: On Fri, Jun 14, 2013 at 03:06:52PM

[libvirt] [PATCH 2/4] Resolve valgrind error in virStorageBackendCreateQemuImgCmd()

2013-06-28 Thread John Ferlan
Commit id '53d5967c' introduced the following: TEST: storagevolxml2argvtest .. 14 OK ==25636== 358 (264 direct, 94 indirect) bytes in 1 blocks are definitely lost in loss record 67 of 75 ==25636==at 0x4A06B6F: calloc (vg_replace_malloc.c:593)

[libvirt] [PATCH 3/4] Resolve valgrind error in remoteConfigGetStringList()

2013-06-28 Thread John Ferlan
Commit id 'ed3bac71' introduced the following: TEST: libvirtdconftest 40 OK ==25875== 690 (480 direct, 210 indirect) bytes in 30 blocks are definitely lost in loss record 18 of 24 ==25875==at 0x4A06B6F: calloc (vg_replace_malloc.c:593)

[libvirt] [PATCH 4/4] Resolve valgrind errors for nodedev cap parsing

2013-06-28 Thread John Ferlan
There were two errors, one as a direct result of commit id '8807b285' and the other from cut-n-paste TEST: nodedevxml2xmltest .. 14 OK ==25735== 3 bytes in 1 blocks are definitely lost in loss record 1 of 24 ==25735==at 0x4A0887C: malloc

[libvirt] [PATCH 1/4] Resolve valgrind error in virNetDevVlanParse()

2013-06-28 Thread John Ferlan
Commit '861d4056' introduced the following: TEST: networkxml2xmltest .. 18 OK ==25504== 7 bytes in 1 blocks are definitely lost in loss record 5 of 23 ==25504==at 0x4A0887C: malloc (vg_replace_malloc.c:270) ==25504==by 0x37C1085D71: strdup

[libvirt] [PATCH 0/4] Resolve some recent Valgrind errors

2013-06-28 Thread John Ferlan
Ran Valgrind today and found, investigated, and resolved the errors seen. John Ferlan (4): Resolve valgrind error in virNetDevVlanParse() Resolve valgrind error in virStorageBackendCreateQemuImgCmd() Resolve valgrind error in remoteConfigGetStringList() Resolve valgrind errors for nodedev

Re: [libvirt] [PATCH 1/4] Resolve valgrind error in virNetDevVlanParse()

2013-06-28 Thread Laine Stump
On 06/28/2013 03:25 PM, John Ferlan wrote: Commit '861d4056' introduced the following: TEST: networkxml2xmltest .. 18 OK ==25504== 7 bytes in 1 blocks are definitely lost in loss record 5 of 23 ==25504==at 0x4A0887C: malloc

Re: [libvirt] [PATCH 2/4] Resolve valgrind error in virStorageBackendCreateQemuImgCmd()

2013-06-28 Thread Laine Stump
On 06/28/2013 03:25 PM, John Ferlan wrote: Commit id '53d5967c' introduced the following: TEST: storagevolxml2argvtest .. 14 OK ==25636== 358 (264 direct, 94 indirect) bytes in 1 blocks are definitely lost in loss record 67 of 75 ==25636==at

Re: [libvirt] [PATCH 4/4] Resolve valgrind errors for nodedev cap parsing

2013-06-28 Thread Laine Stump
On 06/28/2013 03:25 PM, John Ferlan wrote: There were two errors, one as a direct result of commit id '8807b285' and the other from cut-n-paste TEST: nodedevxml2xmltest .. 14 OK ==25735== 3 bytes in 1 blocks are definitely lost in loss record 1 of

Re: [libvirt] [PATCH] doc: Fix reference to #elementsUSB

2013-06-28 Thread Laine Stump
On 06/28/2013 01:06 PM, Philipp Hahn wrote: aae0fc2a922b3e31dae7648c547fca2ac2587625 removed the #elementsUSB anchor but did not update the links to point to the new section #elementsHostDev. ACK and pushed. Signed-off-by: Philipp Hahn h...@univention.de --- docs/formatdomain.html.in |

Re: [libvirt] [PATCH V2] Expose all CPU features in host definition

2013-06-28 Thread Daniel P. Berrange
On Fri, Jun 28, 2013 at 11:51:32AM -0600, Don Dugger wrote: On Fri, Jun 28, 2013 at 10:24:48AM +0100, Daniel P. Berrange wrote: On Thu, Jun 27, 2013 at 10:35:58AM -0600, Don Dugger wrote: On Mon, Jun 17, 2013 at 10:27:36AM +0200, Jiri Denemark wrote: On Fri, Jun 14, 2013 at 12:32:35

Re: [libvirt] [PATCH V2] Expose all CPU features in host definition

2013-06-28 Thread Don Dugger
On Fri, Jun 28, 2013 at 09:03:55PM +0100, Daniel P. Berrange wrote: On Fri, Jun 28, 2013 at 11:51:32AM -0600, Don Dugger wrote: On Fri, Jun 28, 2013 at 10:24:48AM +0100, Daniel P. Berrange wrote: On Thu, Jun 27, 2013 at 10:35:58AM -0600, Don Dugger wrote: On Mon, Jun 17, 2013 at

Re: [libvirt] [PATCH 1/3] qemu: Move memory limit computation to a reusable function

2013-06-28 Thread Laine Stump
On 06/28/2013 11:04 AM, Jiri Denemark wrote: --- src/qemu/qemu_cgroup.c | 21 ++--- src/qemu/qemu_domain.c | 29 + src/qemu/qemu_domain.h | 2 ++ 3 files changed, 33 insertions(+), 19 deletions(-) diff --git a/src/qemu/qemu_cgroup.c

Re: [libvirt] [PATCH 2/3] qemu: Use qemuDomainMemoryLimit when computing memory for VFIO

2013-06-28 Thread Laine Stump
On 06/28/2013 11:04 AM, Jiri Denemark wrote: --- src/qemu/qemu_command.c | 17 +++-- src/qemu/qemu_domain.c | 16 src/qemu/qemu_hotplug.c | 18 -- 3 files changed, 31 insertions(+), 20 deletions(-) ACK, pending a short discussion/explanation of

Re: [libvirt] [PATCH 3/3] qemu: Set RLIMIT_MEMLOCK when memoryBacking/locked is used

2013-06-28 Thread Laine Stump
On 06/28/2013 11:04 AM, Jiri Denemark wrote: If a domain is configured to have all its memory locked, we need to set RLIMIT_MEMLOCK so that QEMU is actually allowed to lock the memory. --- src/qemu/qemu_command.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/qemu/qemu_command.c

Re: [libvirt] [PATCH 3/4] Resolve valgrind error in remoteConfigGetStringList()

2013-06-28 Thread Laine Stump
On 06/28/2013 03:25 PM, John Ferlan wrote: Commit id 'ed3bac71' introduced the following: TEST: libvirtdconftest 40 OK ==25875== 690 (480 direct, 210 indirect) bytes in 30 blocks are definitely lost in loss record 18 of 24 ==25875==at