Re: [libvirt] configuring a disconnected interface

2013-07-03 Thread Dan Kenigsberg
On Tue, Jul 02, 2013 at 05:32:20PM -0400, Laine Stump wrote: On 07/02/2013 04:07 PM, Dan Kenigsberg wrote: On Mon, Jun 24, 2013 at 11:22:16AM +0100, Daniel P. Berrange wrote: On Sun, Jun 23, 2013 at 03:34:06PM +0300, Dan Kenigsberg wrote: On Fri, Jun 21, 2013 at 04:31:53AM -0500, Daniel P.

Re: [libvirt] [PATCH] doc: blkio: add some notification

2013-07-03 Thread Gao feng
On 07/03/2013 03:01 AM, Eric Blake wrote: On 07/02/2013 02:44 AM, Gao feng wrote: If the I/O elevator of disk is not cfq, the setting of blkio.weight is ineffective. And the setting up blkio.weight_device will fail. Add notification for this situation. Signed-off-by: Gao feng

[libvirt] [libvirt-perl][PATCH] Add missing bracket to Sys::Virt::Domain man page

2013-07-03 Thread Ján Tomko
https://bugzilla.redhat.com/show_bug.cgi?id=954254 --- Pushed as trivial. lib/Sys/Virt/Domain.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/Sys/Virt/Domain.pm b/lib/Sys/Virt/Domain.pm index 053f127..3630cf0 100644 --- a/lib/Sys/Virt/Domain.pm +++

[libvirt] [PATCH 1/2] virCgroupNewPartition: Don't leak @newpath

2013-07-03 Thread Michal Privoznik
The @newpath variable is allocated in virCgroupSetPartitionSuffix(). But it's newer freed. --- src/util/vircgroup.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/util/vircgroup.c b/src/util/vircgroup.c index ae71859..e0b25ed 100644 --- a/src/util/vircgroup.c +++

[libvirt] [PATCH 2/2] virNetDevBandwidthUnplug: Don't leak @cmd

2013-07-03 Thread Michal Privoznik
When removing a TAP device, the associated bandwidth settings are removed. Currently, the /sbin/tc is used for that. It is spawned several times. Moreover, we use the same @cmd variable to construct the command and its arguments. That means we need to virCommandFree(cmd); prior to each

Re: [libvirt] [PATCH 1/2] virCgroupNewPartition: Don't leak @newpath

2013-07-03 Thread Ján Tomko
On 07/03/2013 09:47 AM, Michal Privoznik wrote: The @newpath variable is allocated in virCgroupSetPartitionSuffix(). But it's newer freed. --- src/util/vircgroup.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) ACK Jan -- libvir-list mailing list libvir-list@redhat.com

Re: [libvirt] [PATCH 2/2] virNetDevBandwidthUnplug: Don't leak @cmd

2013-07-03 Thread Ján Tomko
On 07/03/2013 09:47 AM, Michal Privoznik wrote: When removing a TAP device, the associated bandwidth settings are removed. Currently, the /sbin/tc is used for that. It is spawned several times. Moreover, we use the same @cmd variable to construct the command and its arguments. That means we

Re: [libvirt] [PATCH 1/2] virCgroupNewPartition: Don't leak @newpath

2013-07-03 Thread Ján Tomko
On 07/03/2013 09:50 AM, Ján Tomko wrote: On 07/03/2013 09:47 AM, Michal Privoznik wrote: The @newpath variable is allocated in virCgroupSetPartitionSuffix(). But it's newer freed. --- src/util/vircgroup.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) ACK Jan

[libvirt] Hostdev: USB passthrough, about hostport support

2013-07-03 Thread Gonglei (Arei)
Hi, the Qemu upstream has a hostport property which allows to specify the host usb devices to pass through by bus number and physical port. Will the libvirt have a plan to support this? Thanks! The Qemu's patch:

Re: [libvirt] configuring a disconnected interface

2013-07-03 Thread Daniel P. Berrange
On Wed, Jul 03, 2013 at 09:39:57AM +0300, Dan Kenigsberg wrote: On Tue, Jul 02, 2013 at 05:32:20PM -0400, Laine Stump wrote: On 07/02/2013 04:07 PM, Dan Kenigsberg wrote: On Mon, Jun 24, 2013 at 11:22:16AM +0100, Daniel P. Berrange wrote: On Sun, Jun 23, 2013 at 03:34:06PM +0300, Dan

Re: [libvirt] [PATCH 8/8] Extend the ACL test case to validate filter rule checks

2013-07-03 Thread Daniel P. Berrange
On Tue, Jul 02, 2013 at 04:21:30PM -0600, Eric Blake wrote: On 06/27/2013 10:57 AM, Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com The 'check-aclrules' test case validates that there are ACL checks in each method. This extends it so that it can also validate

Re: [libvirt] LXC: autostart feature does set all interfaces to state up.

2013-07-03 Thread Gao feng
Hi, On 07/01/2013 03:45 PM, Richard Weinberger wrote: Hi! If you have multiple LXC containers with networking and the autostart feature enabled libvirtd fails to up some veth interfaces on the host side. Most of the time only the first veth device is in state up, all others are down.

Re: [libvirt] [PATCH 1/8] Add access control filtering of domain objects

2013-07-03 Thread Daniel P. Berrange
On Tue, Jul 02, 2013 at 01:17:44PM -0600, Eric Blake wrote: On 06/27/2013 10:57 AM, Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com Ensure that all APIs which list domain objects filter them against the access control system. Signed-off-by: Daniel P. Berrange

Re: [libvirt] [PATCH v3 02/12] LXC: enable user namespace only when user set the uidmap

2013-07-03 Thread John Ferlan
On 05/23/2013 12:06 AM, Gao feng wrote: User namespace will be enabled only when the idmap exist in configuration. If you want disable user namespace,just remove these elements from XML. If kernel doesn't support user namespace and idmap exist in configuration file, libvirt lxc will

Re: [libvirt] [PATCH 2/8] Add qemuMonitorGetObjectProperty() method for QMP qom-get command

2013-07-03 Thread Daniel P. Berrange
On Tue, Jul 02, 2013 at 09:39:20AM -0400, John Ferlan wrote: Add a new qemuMonitorGetObjectProperty() method to support invocation of the 'qom-get' JSON monitor command with a provided path, property, and expected data type return. The qemuMonitorObjectProperty is similar to

Re: [libvirt] [PATCH 1/8] Add qemuMonitorGetObjectListPaths() method for QMP qom-list command

2013-07-03 Thread Daniel P. Berrange
On Tue, Jul 02, 2013 at 09:39:19AM -0400, John Ferlan wrote: Add a new qemuMonitorGetObjectListPaths() method to support invocation of the 'qom-list' JSON monitor command with a provided path. The returned list of paired data fields of name and type that can be used to peruse QOM

Re: [libvirt] [PATCH 4/8] Add 'period' for Memballoon statistics gathering capability

2013-07-03 Thread Daniel P. Berrange
On Tue, Jul 02, 2013 at 09:39:22AM -0400, John Ferlan wrote: Add a period in seconds to allow/enable statistics gathering from the Balloon driver for 'virsh dommemstat domain'. --- docs/schemas/domaincommon.rng | 7 +++ src/conf/domain_conf.c| 27 +++

Re: [libvirt] [PATCH 3/8] Add qemuMonitorSetObjectProperty() method for QMP qom-set command

2013-07-03 Thread Daniel P. Berrange
On Tue, Jul 02, 2013 at 09:39:21AM -0400, John Ferlan wrote: Add a new qemuMonitorSetObjectProperty() method to support invocation of the 'qom-set' JSON monitor command with a provided path, property, and expected data type to set. The test code uses the same /machine/i440fx property as the

Re: [libvirt] [PATCH 5/8] Determine whether to start balloon memory stats gathering.

2013-07-03 Thread Daniel P. Berrange
On Tue, Jul 02, 2013 at 09:39:23AM -0400, John Ferlan wrote: At vm startup, reconnect, and attach - check for the presence of the balloon driver and save the path in the private area of the driver. This path will remain constant throughout the life of the domain and can then be used rather

Re: [libvirt] [PATCH 6/8] Add capability to fetch balloon stats

2013-07-03 Thread Daniel P. Berrange
On Tue, Jul 02, 2013 at 09:39:24AM -0400, John Ferlan wrote: This patch will add the QEMU_MONITOR_OBJECT_PROPERTY_BALLOON_STATS type and a mechanism in the qemuMonitorObjectProperty to fetch and store an opaque data array assuming that we are provided a count of current elements, a count of

Re: [libvirt] [PATCH 7/8] If available fetch the balloon driver memory stats

2013-07-03 Thread Daniel P. Berrange
On Tue, Jul 02, 2013 at 09:39:25AM -0400, John Ferlan wrote: In the 'virsh dommemstats domain' qemu driver code, if we have a balloonpath and we hadn't already collected the data (somehow) from the query-balloon command, then use qom-get to attempt to fill in the domain memory stats data from

Re: [libvirt] [PATCH 8/8] Allow balloon driver collection to be adjusted dynamically

2013-07-03 Thread Daniel P. Berrange
On Tue, Jul 02, 2013 at 09:39:26AM -0400, John Ferlan wrote: Extend the virDomainSetMemeoryFlags() to accept a 'VIR_DOMAIN_MEM_PERIOD' which will be used to dynamically set the collection period for the balloon driver via a 'virsh dommemstat domain --period value' command. Add the --current,

Re: [libvirt] [PATCH 1/2] qemu: Don't miss errors when changing graphics passwords

2013-07-03 Thread Daniel P. Berrange
On Tue, Jul 02, 2013 at 03:46:00PM +0200, Martin Kletzander wrote: Commit 23e8b5d8e7a92bac85b7fd2aca8992501bf680ee forgot to check the return value for all calls to qemuDomainChangeGraphicsPasswords(). Signed-off-by: Martin Kletzander mklet...@redhat.com --- src/qemu/qemu_process.c | 6

Re: [libvirt] [PATCH 2/2] qemu: Allow seamless migration for domains with multiple graphics

2013-07-03 Thread Daniel P. Berrange
On Tue, Jul 02, 2013 at 03:46:01PM +0200, Martin Kletzander wrote: Since commit 23e8b5d8, the code is refactored in a way that supports domains with multiple graphics elements and commit 37b415200 allows starting such domains. However none of those commits take migration into account. Even

[libvirt] [PATCH] LXC: fix memory leak when userns configuration is incorrect

2013-07-03 Thread Gao feng
We forgot to free the stack when userns configuration is incorrect. Signed-off-by: Gao feng gaof...@cn.fujitsu.com --- src/lxc/lxc_container.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/lxc/lxc_container.c b/src/lxc/lxc_container.c index 282c726..c8420db 100644 ---

[libvirt] [PATCH RESEND] LXC: fix memory leak when userns configuration is incorrect

2013-07-03 Thread Gao feng
We forgot to free the stack when Kernel doesn't support user namespace. Signed-off-by: Gao feng gaof...@cn.fujitsu.com --- src/lxc/lxc_container.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/lxc/lxc_container.c b/src/lxc/lxc_container.c index 282c726..c8420db 100644 ---

Re: [libvirt] Memory access API

2013-07-03 Thread Daniel P. Berrange
On Wed, Jun 19, 2013 at 04:29:48AM +0200, Marek Marczykowski-Górecki wrote: Hi, Is there any zero-copy VM memory access API in libvirt? I see only virDomainMemoryPeek function, which copy some memory from VM and do not permit VM memory modifications. What I'm looking for is xen

Re: [libvirt] [PATCH] LXC: blkio: allow to setup weight_device

2013-07-03 Thread Daniel P. Berrange
On Thu, Jun 27, 2013 at 04:32:30PM +0800, Gao feng wrote: libivrt lxc can only set generic weight for container, This patch allows user to setup per device blkio weigh for container. Signed-off-by: Gao feng gaof...@cn.fujitsu.com --- src/lxc/lxc_cgroup.c | 26 --

Re: [libvirt] [PATCH RESEND] LXC: fix memory leak when userns configuration is incorrect

2013-07-03 Thread Daniel P. Berrange
On Wed, Jul 03, 2013 at 07:16:04PM +0800, Gao feng wrote: We forgot to free the stack when Kernel doesn't support user namespace. Signed-off-by: Gao feng gaof...@cn.fujitsu.com --- src/lxc/lxc_container.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/lxc/lxc_container.c

Re: [libvirt] How to get the host network stats

2013-07-03 Thread Daniel P. Berrange
On Tue, Jul 02, 2013 at 03:07:56PM +0200, Michal Novotny wrote: Hi, libvirt_domain_interface stats PHP API is calling virDomainInterfaceStats. That gives you the stats of the guest NICs, but not anything about the host's network stats. We don't have any API for the latter. On 07/02/2013 10:10

Re: [libvirt] [libvirt-users] libvirt virtio_net - host.freeze@reset.domain

2013-07-03 Thread Daniel P. Berrange
On Tue, Jul 02, 2013 at 01:25:21PM +0200, poma wrote: Hello people, libvirtd (libvirt) 1.0.5.2 virsh 1.0.5.2 virt-manager 0.10.0 Host: Linux localhost 3.9.8-300.fc19.x86_64 #1 SMP Thu Jun 27 19:24:23 UTC 2013 x86_64 x86_64 x86_64 GNU/Linux Guest1: Linux localhost

Re: [libvirt] [PATCH 2/8] Add qemuMonitorGetObjectProperty() method for QMP qom-get command

2013-07-03 Thread Michal Privoznik
On 02.07.2013 15:39, John Ferlan wrote: Add a new qemuMonitorGetObjectProperty() method to support invocation of the 'qom-get' JSON monitor command with a provided path, property, and expected data type return. The qemuMonitorObjectProperty is similar to virTypedParameter; however, a future

Re: [libvirt] [PATCH 4/8] Add 'period' for Memballoon statistics gathering capability

2013-07-03 Thread Michal Privoznik
On 02.07.2013 15:39, John Ferlan wrote: Add a period in seconds to allow/enable statistics gathering from the Balloon driver for 'virsh dommemstat domain'. --- docs/schemas/domaincommon.rng | 7 +++ src/conf/domain_conf.c| 27 +++ src/conf/domain_conf.h

Re: [libvirt] [PATCH 8/8] Allow balloon driver collection to be adjusted dynamically

2013-07-03 Thread Michal Privoznik
On 02.07.2013 15:39, John Ferlan wrote: Extend the virDomainSetMemeoryFlags() to accept a 'VIR_DOMAIN_MEM_PERIOD' which will be used to dynamically set the collection period for the balloon driver via a 'virsh dommemstat domain --period value' command. Add the --current, --live, --config

Re: [libvirt] [PATCH 2/8] Add qemuMonitorGetObjectProperty() method for QMP qom-get command

2013-07-03 Thread Ján Tomko
On 07/03/2013 02:03 PM, Michal Privoznik wrote: On 02.07.2013 15:39, John Ferlan wrote: +case QEMU_MONITOR_OBJECT_PROPERTY_STRING: +tmp = virJSONValueGetString(data); +if (tmp VIR_STRDUP(prop-val.str, tmp) 0) Lose the 'tmp' here as VIR_STRDUP will check it for NULL

Re: [libvirt] [PATCH 2/2] qemu: Allow seamless migration for domains with multiple graphics

2013-07-03 Thread Jiri Denemark
On Wed, Jul 03, 2013 at 12:10:23 +0100, Daniel Berrange wrote: On Tue, Jul 02, 2013 at 03:46:01PM +0200, Martin Kletzander wrote: Since commit 23e8b5d8, the code is refactored in a way that supports domains with multiple graphics elements and commit 37b415200 allows starting such domains.

Re: [libvirt] [PATCH 2/8] Add qemuMonitorGetObjectProperty() method for QMP qom-get command

2013-07-03 Thread Michal Privoznik
On 03.07.2013 14:12, Ján Tomko wrote: On 07/03/2013 02:03 PM, Michal Privoznik wrote: On 02.07.2013 15:39, John Ferlan wrote: +case QEMU_MONITOR_OBJECT_PROPERTY_STRING: +tmp = virJSONValueGetString(data); +if (tmp VIR_STRDUP(prop-val.str, tmp) 0) Lose the 'tmp' here as

[libvirt] [PATCHv2 0/2] selinux: Always label FD's passed to qemu

2013-07-03 Thread Peter Krempa
This second version just always creates the imagelabel field that will be used to label the passed FDs appropriately and always even if relabeling is not requested. The rest of the code paths are still relabeled only if relabeling is enabled. Peter Krempa (2): selinux: Cleanup coding style

[libvirt] [PATCHv2 1/2] selinux: Cleanup coding style

2013-07-03 Thread Peter Krempa
--- src/security/security_selinux.c | 14 ++ 1 file changed, 6 insertions(+), 8 deletions(-) diff --git a/src/security/security_selinux.c b/src/security/security_selinux.c index 7802dda..ec4f764 100644 --- a/src/security/security_selinux.c +++ b/src/security/security_selinux.c @@

[libvirt] [PATCHv2 2/2] selinux: Always generate imagelabel

2013-07-03 Thread Peter Krempa
The imagelabel SELinux label was only generated when relabeling was enabled. This prohibited labeling of files created by libvirt that need to be labeled even if relabeling is turned off. The only codepath this change has direct impact on is labeling of FD's passed to qemu which is allways safe

Re: [libvirt] [PATCH 2/2] qemu: Allow seamless migration for domains with multiple graphics

2013-07-03 Thread Martin Kletzander
On 07/03/2013 02:11 PM, Jiri Denemark wrote: On Wed, Jul 03, 2013 at 12:10:23 +0100, Daniel Berrange wrote: On Tue, Jul 02, 2013 at 03:46:01PM +0200, Martin Kletzander wrote: Since commit 23e8b5d8, the code is refactored in a way that supports domains with multiple graphics elements and commit

Re: [libvirt] [PATCH] Put virt-sanlock-cleanup into section 8

2013-07-03 Thread Guido Günther
Hi Eric, On Tue, Jul 02, 2013 at 03:48:04PM -0600, Eric Blake wrote: On 07/02/2013 03:36 PM, Guido Günther wrote: as indicates by the filename. s/indicates/indicated/ --- tools/Makefile.am | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tools/Makefile.am

Re: [libvirt] [PATCH] Put virt-sanlock-cleanup into section 8

2013-07-03 Thread Eric Blake
On 07/03/2013 07:11 AM, Guido Günther wrote: Looks like daemon/Makefile.am needs the same tweak for libvirtd.8. Since libvirtd.8.in in processed by sed and not pod2man it doesn't need any additional tweaks. Or am I missing something? Huh, you're right. I just checked 'man

Re: [libvirt] [PATCH] Put virt-sanlock-cleanup into section 8

2013-07-03 Thread Daniel P. Berrange
On Wed, Jul 03, 2013 at 07:17:37AM -0600, Eric Blake wrote: On 07/03/2013 07:11 AM, Guido Günther wrote: Looks like daemon/Makefile.am needs the same tweak for libvirtd.8. Since libvirtd.8.in in processed by sed and not pod2man it doesn't need any additional tweaks. Or am I missing

[libvirt] best way to provide disk storage for vm without shared storage system

2013-07-03 Thread Vasiliy Tolstov
Hello. I'm very happy with libvirt and qemu, that great software! (after some playing i want to create golang bindings to libvirt).. Now i provide ext4 fs for qcow2 images (raid1 with two sata disks). Now i don't need live migration (but may need it in feature). What is the best way to provide

[libvirt] attach-device error: XML error: unknown device type

2013-07-03 Thread Chris Evich
Hi, On Fedora 18 (libvirt 0.10.2.6-1) I'm trying to add a new serial device to a KVM VM with: virsh attach-device foobar /tmp/serial.xml and I keep getting: error: Failed to attach device from /tmp/serial.xml error: XML error: unknown device type with serial.xml: serial type='file' source

Re: [libvirt] attach-device error: XML error: unknown device type

2013-07-03 Thread Daniel P. Berrange
On Wed, Jul 03, 2013 at 09:44:46AM -0400, Chris Evich wrote: Hi, On Fedora 18 (libvirt 0.10.2.6-1) I'm trying to add a new serial device to a KVM VM with: virsh attach-device foobar /tmp/serial.xml and I keep getting: error: Failed to attach device from /tmp/serial.xml error: XML

[libvirt] [PATCH glib] Add API to access device alias names

2013-07-03 Thread Daniel P. Berrange
From: Daniel P. Berrange berra...@redhat.com Add gvir_config_domain_device_get_alias to read the alias name=foo/ XML in each device. Signed-off-by: Daniel P. Berrange berra...@redhat.com --- libvirt-gconfig/libvirt-gconfig-domain-device.c | 9 +

[libvirt] [PATCH glib] Add APIs to access chardev source information

2013-07-03 Thread Daniel P. Berrange
From: Daniel P. Berrange berra...@redhat.com Enable apps to determine the current source path of a chardev with a pty based source. --- .../libvirt-gconfig-domain-chardev-source-pty.c| 23 + .../libvirt-gconfig-domain-chardev-source-pty.h| 2 ++

Re: [libvirt] attach-device error: XML error: unknown device type

2013-07-03 Thread Eric Blake
On 07/03/2013 07:46 AM, Daniel P. Berrange wrote: What am I doing wrong with the virsh attach-device command or XML? There is no support for hotplug of any character device (that covers serial, parallel, console, channnel elements in the XML) Although that's about to change in libvirt 1.1.1:

Re: [libvirt] attach-device error: XML error: unknown device type

2013-07-03 Thread Daniel P. Berrange
On Wed, Jul 03, 2013 at 07:54:51AM -0600, Eric Blake wrote: On 07/03/2013 07:46 AM, Daniel P. Berrange wrote: What am I doing wrong with the virsh attach-device command or XML? There is no support for hotplug of any character device (that covers serial, parallel, console, channnel

[libvirt] [PATCH] Resolve Coverity complaints in tests/securityselinuxlabeltest.c

2013-07-03 Thread John Ferlan
Two complaints of RESOURCE_FREE due to going to cleanup prior to a VIR_FREE(line). Two complaints of FORWARD_NULL due to 'tmp' being accessed after a strchr() without first checking if the return was NULL. While looking at the code it seems that 'line' need only be allocated once as the while

Re: [libvirt] [PATCH] Put virt-sanlock-cleanup into section 8

2013-07-03 Thread Guido Günther
On Wed, Jul 03, 2013 at 07:17:37AM -0600, Eric Blake wrote: On 07/03/2013 07:11 AM, Guido Günther wrote: Looks like daemon/Makefile.am needs the same tweak for libvirtd.8. Since libvirtd.8.in in processed by sed and not pod2man it doesn't need any additional tweaks. Or am I missing

Re: [libvirt] attach-device error: XML error: unknown device type

2013-07-03 Thread Michal Privoznik
On 03.07.2013 15:59, Daniel P. Berrange wrote: On Wed, Jul 03, 2013 at 07:54:51AM -0600, Eric Blake wrote: On 07/03/2013 07:46 AM, Daniel P. Berrange wrote: What am I doing wrong with the virsh attach-device command or XML? There is no support for hotplug of any character device (that covers

Re: [libvirt] attach-device error: XML error: unknown device type

2013-07-03 Thread Daniel P. Berrange
On Wed, Jul 03, 2013 at 04:19:01PM +0200, Michal Privoznik wrote: On 03.07.2013 15:59, Daniel P. Berrange wrote: On Wed, Jul 03, 2013 at 07:54:51AM -0600, Eric Blake wrote: On 07/03/2013 07:46 AM, Daniel P. Berrange wrote: What am I doing wrong with the virsh attach-device command or XML?

Re: [libvirt] [PATCH glib] Add APIs to access chardev source information

2013-07-03 Thread Michal Privoznik
On 03.07.2013 15:51, Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com Enable apps to determine the current source path of a chardev with a pty based source. --- .../libvirt-gconfig-domain-chardev-source-pty.c| 23 +

Re: [libvirt] [PATCH glib] Add API to access device alias names

2013-07-03 Thread Michal Privoznik
On 03.07.2013 15:51, Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com Add gvir_config_domain_device_get_alias to read the alias name=foo/ XML in each device. Signed-off-by: Daniel P. Berrange berra...@redhat.com --- libvirt-gconfig/libvirt-gconfig-domain-device.c |

[libvirt] qemu64 - not valid cpu with 'Intel Westmere Family'

2013-07-03 Thread Sandro Bonazzola
Hi, I'm trying to run latest vdsm master on RHEL-6.4. I've built the rpms against livirt-1.10 I'm creating a VM using cpu family = 'Intel Westmere Family' cpu match=exact modelqemu64/model feature name=svm policy=disable/ /cpu Thread-40::DEBUG::2013-07-03

Re: [libvirt] configuring a disconnected interface

2013-07-03 Thread Laine Stump
On 07/03/2013 05:27 AM, Daniel P. Berrange wrote: On Wed, Jul 03, 2013 at 09:39:57AM +0300, Dan Kenigsberg wrote: On Tue, Jul 02, 2013 at 05:32:20PM -0400, Laine Stump wrote: On 07/02/2013 04:07 PM, Dan Kenigsberg wrote: On Mon, Jun 24, 2013 at 11:22:16AM +0100, Daniel P. Berrange wrote: On

Re: [libvirt] qemu64 - not valid cpu with 'Intel Westmere Family'

2013-07-03 Thread Sandro Bonazzola
Il 03/07/2013 16:40, Sandro Bonazzola ha scritto: Hi, I'm trying to run latest vdsm master on RHEL-6.4. I've built the rpms against livirt-1.10 I'm creating a VM using cpu family = 'Intel Westmere Family' cpu match=exact modelqemu64/model feature name=svm policy=disable/

Re: [libvirt] [PATCH v3 1/9] domain_conf: Introduce chardev hotplug helpers

2013-07-03 Thread Daniel P. Berrange
On Tue, Jul 02, 2013 at 05:53:00PM +0200, Michal Privoznik wrote: For now, only these three helpers are needed: virDomainChrFind - to find a duplicate chardev within VM def virDomainChrInsert - wrapper for inserting a new chardev into VM def virDomainChrRemove - wrapper for removing chardev

Re: [libvirt] [PATCH v3 3/9] qemu_monitor_json: Move InetSocketAddress build to a separate function

2013-07-03 Thread Daniel P. Berrange
On Tue, Jul 02, 2013 at 05:53:02PM +0200, Michal Privoznik wrote: Currently, we are building InetSocketAddress qemu json type within the qemuMonitorJSONNBDServerStart function. However, other future functions may profit from the code as well. So it should be moved into a static function. ---

Re: [libvirt] [PATCH] Resolve Coverity complaints in tests/securityselinuxlabeltest.c

2013-07-03 Thread Daniel P. Berrange
On Wed, Jul 03, 2013 at 10:05:58AM -0400, John Ferlan wrote: Two complaints of RESOURCE_FREE due to going to cleanup prior to a VIR_FREE(line). Two complaints of FORWARD_NULL due to 'tmp' being accessed after a strchr() without first checking if the return was NULL. While looking at the

Re: [libvirt] [PATCH v3 2/9] qemu: Implement chardev hotplug on config level

2013-07-03 Thread Daniel P. Berrange
On Tue, Jul 02, 2013 at 05:53:01PM +0200, Michal Privoznik wrote: There are two levels on which a device may be hotplugged: config and live. The config level requires just an insert or remove from internal domain definition structure, which is exactly what this patch does. There is currently

Re: [libvirt] [PATCH v3 4/9] qemu_monitor: Introduce qemuMonitorAttachCharDev

2013-07-03 Thread Daniel P. Berrange
On Tue, Jul 02, 2013 at 05:53:03PM +0200, Michal Privoznik wrote: The function being introduced is responsible for preparing and executing 'chardev-add' qemu monitor command. Moreover, in case of PTY chardev, the corresponding pty path is updated. --- src/qemu/qemu_monitor.c | 21 +

Re: [libvirt] [PATCH v3 5/9] qemu_monitor: Introduce qemuMonitorDetachCharDev

2013-07-03 Thread Daniel P. Berrange
On Tue, Jul 02, 2013 at 05:53:04PM +0200, Michal Privoznik wrote: This function wraps 'chardev-remove' qemu monitor command around. It takes chardev alias as its single argument besides qemu monitor pointer. --- src/qemu/qemu_monitor.c | 20 src/qemu/qemu_monitor.h

Re: [libvirt] [PATCH v3 6/9] qemu_command: Honour chardev alias assignment with a function

2013-07-03 Thread Daniel P. Berrange
On Tue, Jul 02, 2013 at 05:53:05PM +0200, Michal Privoznik wrote: The chardev alias assignment is going to be needed in a separate places, so it should be moved into a separate function rather than copying code randomly around. --- src/qemu/qemu_command.c | 75

Re: [libvirt] [PATCH 1/8] Add qemuMonitorGetObjectListPaths() method for QMP qom-list command

2013-07-03 Thread Daniel P. Berrange
On Wed, Jul 03, 2013 at 11:30:46AM -0400, John Ferlan wrote: On 07/03/2013 06:56 AM, Daniel P. Berrange wrote: On Tue, Jul 02, 2013 at 09:39:19AM -0400, John Ferlan wrote: Add a new qemuMonitorGetObjectListPaths() method to support invocation of the 'qom-list' JSON monitor command with a

Re: [libvirt] [PATCH 1/8] Add qemuMonitorGetObjectListPaths() method for QMP qom-list command

2013-07-03 Thread John Ferlan
On 07/03/2013 06:56 AM, Daniel P. Berrange wrote: On Tue, Jul 02, 2013 at 09:39:19AM -0400, John Ferlan wrote: Add a new qemuMonitorGetObjectListPaths() method to support invocation of the 'qom-list' JSON monitor command with a provided path. The returned list of paired data fields of name

Re: [libvirt] qemu64 - not valid cpu with 'Intel Westmere Family'

2013-07-03 Thread Dan Kenigsberg
On Wed, Jul 03, 2013 at 04:51:30PM +0200, Sandro Bonazzola wrote: Il 03/07/2013 16:40, Sandro Bonazzola ha scritto: Hi, I'm trying to run latest vdsm master on RHEL-6.4. I've built the rpms against livirt-1.10 I'm creating a VM using cpu family = 'Intel Westmere Family' cpu

[libvirt] [PATCH] maint: update to latest gnulib

2013-07-03 Thread Eric Blake
The latest mingw headers on Fedora 19 fail to build with gnulib without an update. Meanwhile, now that upstream gnulib has better handling of -W probing for clang, we can drop some of our own solutions in favor of upstream; thus this reverts commit c1634100, Correctly detect warning flags with

Re: [libvirt] attach-device error: XML error: unknown device type

2013-07-03 Thread Chris Evich
On 07/03/2013 10:21 AM, Daniel P. Berrange wrote: On Wed, Jul 03, 2013 at 04:19:01PM +0200, Michal Privoznik wrote: On 03.07.2013 15:59, Daniel P. Berrange wrote: On Wed, Jul 03, 2013 at 07:54:51AM -0600, Eric Blake wrote: On 07/03/2013 07:46 AM, Daniel P. Berrange wrote: What am I doing

Re: [libvirt] [PATCH v2 06/14] conf: virDomainObjListRemoveLocked function

2013-07-03 Thread Jim Fehlig
On 06/20/2013 10:24 AM, Marek Marczykowski-Górecki wrote: On 20.06.2013 17:34, Jim Fehlig wrote: Marek Marczykowski-Górecki wrote: While iterating with virDomainObjListForEach it is safe to remove current element. But while iterating, 'doms' lock is already taken, so can't use standard

Re: [libvirt] [PATCH v2 07/14] libxl: fix deadlock in libxlReconnectDomain

2013-07-03 Thread Jim Fehlig
On 06/12/2013 07:54 PM, Marek Marczykowski-Górecki wrote: Use virDomainObjListRemoveLocked instead of virDomainObjListRemove, as driver-domains is already taken by virDomainObjListForEach. Above deadlock can be triggered when libvirtd is started after some domain have been started by hand (in

[libvirt] [PATCH] build: honor autogen.sh --no-git

2013-07-03 Thread Eric Blake
Based on a report by Chandrashekar Shastri, at https://bugzilla.redhat.com/show_bug.cgi?id=979360 On systems where git cannot access the outside world, a developer can instead arrange to get a copy of gnulib at the right commit via side channels (such as NFS share drives), set GNULIB_SRCDIR, then

Re: [libvirt] Libvirt : Bootstrap fails for local gnulib

2013-07-03 Thread Eric Blake
On 06/29/2013 12:20 PM, Eric Blake wrote: [dropping qemu-devel and virt-tools-list, as this question does not concern those lists] On 06/26/2013 03:12 AM, chandrashekar shastri wrote: Hi All, The Libvirt compliation fails to bootstarp for local gnulib. We do not have outbound access for

Re: [libvirt] libvirt compliation from git source fails with gnulib/tests/Makefile.in' not found error

2013-07-03 Thread Eric Blake
On 07/01/2013 07:17 AM, chandrashekar shastri wrote: On 06/29/2013 11:43 PM, Eric Blake wrote: On 06/17/2013 03:57 AM, chandrashekar shastri wrote: Hi, I am compiling the libvirt from source and I am getting the following error: We need more details - are you trying to compile libvirt.git

Re: [libvirt] [PATCH v2 11/14] libxl: support network device attach/detach

2013-07-03 Thread Jim Fehlig
On 06/12/2013 07:54 PM, Marek Marczykowski-Górecki wrote: Both live and config. Signed-off-by: Marek Marczykowski-Górecki marma...@invisiblethingslab.com --- src/libxl/libxl_driver.c | 164 ++- 1 file changed, 161 insertions(+), 3 deletions(-)

Re: [libvirt] [PATCH 1/2] util: add virGetGroupList

2013-07-03 Thread Eric Blake
On 05/22/2013 11:02 AM, Eric Blake wrote: +/* Figure out what size list to expect */ +getgrouplist(pwd.pw_name, gid, groups, ngroups); Do we need to be concerned about the BUGS info in the manpage? BUGS In glibc versions before 2.3.3, the implementation of

Re: [libvirt] [PATCH v2 12/14] libxl: pass ipaddr to libxl toolstack

2013-07-03 Thread Jim Fehlig
On 06/12/2013 07:54 PM, Marek Marczykowski-Górecki wrote: Do not silently ignore its value. Signed-off-by: Marek Marczykowski-Górecki marma...@invisiblethingslab.com --- src/libxl/libxl_conf.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/libxl/libxl_conf.c

Re: [libvirt] [PATCH v2 14/14] libxl: add tablet/mouse input device support

2013-07-03 Thread Jim Fehlig
On 06/12/2013 07:54 PM, Marek Marczykowski-Górecki wrote: Signed-off-by: Marek Marczykowski-Górecki marma...@invisiblethingslab.com --- src/libxl/libxl_conf.c | 30 ++ 1 file changed, 30 insertions(+) diff --git a/src/libxl/libxl_conf.c b/src/libxl/libxl_conf.c

[libvirt] [libvirt-1.0.5]deadlock in child process after call function backtrace, any suggestions is appreciate!

2013-07-03 Thread Caizhifeng
Hi ALL, In order to catch the calltrace of deadlock in libvirtd, I modified the function virMutexLock as follows: struct virMutex { pthread_mutex_t lock; void *trace[TRACE_SIZE];//added for test int ntrace; //added for test }; void