On 07/04/13 21:45, Jiri Denemark wrote:
---
src/qemu/qemu_process.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
ACK.
Peter
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
On 07/04/13 20:13, Jiri Denemark wrote:
https://bugzilla.redhat.com/show_bug.cgi?id=981139
If a domain is paused before migration starts, we need to tell that to
the destination libvirtd to prevent it from resuming the domain at the
end of migration. This regression was introduced by commit
On 07/04/2013 02:06 PM, Michal Privoznik wrote:
---
src/conf/cpu_conf.c | 34 +---
src/conf/domain_conf.c | 328
+++
src/conf/domain_event.c | 30 +---
src/conf/interface_conf.c| 35 +---
On 07/04/2013 02:06 PM, Michal Privoznik wrote:
---
src/secret/secret_driver.c | 49
--
1 file changed, 12 insertions(+), 37 deletions(-)
ACK
Jan
--
libvir-list mailing list
libvir-list@redhat.com
On 07/04/2013 02:06 PM, Michal Privoznik wrote:
---
src/xenapi/xenapi_driver.c | 29 -
src/xenapi/xenapi_utils.c | 11 ---
2 files changed, 12 insertions(+), 28 deletions(-)
diff --git a/src/xenapi/xenapi_driver.c b/src/xenapi/xenapi_driver.c
index
On 07/08/2013 09:34 AM, Ján Tomko wrote:
On 07/04/2013 02:06 PM, Michal Privoznik wrote:
---
src/secret/secret_driver.c | 49
--
1 file changed, 12 insertions(+), 37 deletions(-)
ACK
Jan
You can also get rid of the out_of_memory label
On 07/04/2013 02:06 PM, Michal Privoznik wrote:
---
src/libxl/libxl_conf.c | 18 +-
src/libxl/libxl_driver.c | 46 +++---
2 files changed, 16 insertions(+), 48 deletions(-)
@@ -1274,7 +1262,7 @@ libxlStateInitialize(bool privileged,
Eric, could you please share your opinion as to what should be more
appropriate to use for this functionality: Structs/XML/VirTypedParams ?
On Tue, Jul 2, 2013 at 7:25 PM, Osier Yang jy...@redhat.com wrote:
On 02/07/13 18:33, Daniel P. Berrange wrote:
On Fri, Jun 28, 2013 at 03:56:10PM
On 07/04/2013 02:06 PM, Michal Privoznik wrote:
---
src/vbox/vbox_MSCOMGlue.c | 8 +--
src/vbox/vbox_XPCOMCGlue.c | 4 +-
src/vbox/vbox_tmpl.c | 126
+++--
3 files changed, 32 insertions(+), 106 deletions(-)
ACK
Jan
--
libvir-list
On 07/04/13 14:06, Michal Privoznik wrote:
---
in src/util/virbitmap.c:
/**
* virBitmapNew:
* @size: number of bits
*
* Allocate a bitmap capable of containing @size bits.
*
* Returns a pointer to the allocated bitmap or NULL if
* memory cannot be allocated.
This function historically
On 07/04/13 14:07, Michal Privoznik wrote:
---
tools/console.c | 6 +-
tools/virsh-domain-monitor.c | 4 +---
tools/virsh-domain.c | 28
tools/virsh.c| 1 -
4 files changed, 10 insertions(+), 29 deletions(-)
...
On 07/04/2013 02:06 PM, Michal Privoznik wrote:
---
src/locking/lock_daemon.c | 33 +
src/locking/lock_daemon_config.c | 8 ++--
src/locking/lock_driver_lockd.c | 23 ++-
src/locking/lock_driver_sanlock.c | 28
On 07/04/13 14:06, Michal Privoznik wrote:
---
src/nwfilter/nwfilter_dhcpsnoop.c | 29 +--
src/nwfilter/nwfilter_driver.c| 13 ++---
src/nwfilter/nwfilter_ebiptables_driver.c | 46 ++-
src/nwfilter/nwfilter_gentech_driver.c
On 07/04/2013 02:06 PM, Michal Privoznik wrote:
---
src/interface/interface_backend_netcf.c | 19 ---
src/interface/interface_backend_udev.c | 33
+
2 files changed, 13 insertions(+), 39 deletions(-)
You missed double OOM error reporting
On 07/04/2013 02:06 PM, Michal Privoznik wrote:
---
src/remote/remote_driver.c | 107
-
1 file changed, 27 insertions(+), 80 deletions(-)
ACK
Jan
--
libvir-list mailing list
libvir-list@redhat.com
On 07/04/13 14:06, Michal Privoznik wrote:
---
src/storage/storage_backend.c | 35 ++---
src/storage/storage_backend_disk.c | 17 +++-
src/storage/storage_backend_fs.c | 31 ++
src/storage/storage_backend_iscsi.c| 27
On 07/04/2013 02:06 PM, Michal Privoznik wrote:
[...]
diff --git a/src/util/vircgroup.c b/src/util/vircgroup.c
index 13fd162..f7f05fd 100644
--- a/src/util/vircgroup.c
+++ b/src/util/vircgroup.c
@@ -1212,8 +1211,6 @@ static int virCgroupSetPartitionSuffix(const char
*path, char **res)
On 07/04/2013 02:06 PM, Michal Privoznik wrote:
---
src/test/test_driver.c | 91
--
1 file changed, 28 insertions(+), 63 deletions(-)
ACK,
Martin
--
libvir-list mailing list
libvir-list@redhat.com
On 07/04/13 14:06, Michal Privoznik wrote:
---
src/lxc/lxc_cgroup.c | 4 +--
src/lxc/lxc_conf.c | 5 +--
src/lxc/lxc_container.c | 77 ++--
src/lxc/lxc_controller.c | 50 +++---
src/lxc/lxc_driver.c | 92
On 07/04/2013 02:06 PM, Michal Privoznik wrote:
---
src/esx/esx_driver.c| 62 -
src/esx/esx_network_driver.c| 16 ++--
src/esx/esx_storage_backend_iscsi.c | 4 +-
src/esx/esx_storage_backend_vmfs.c | 78
On 07/04/13 14:06, Michal Privoznik wrote:
---
src/xen/block_stats.c| 8 ++--
src/xen/xen_driver.c | 42 +++---
src/xen/xen_hypervisor.c | 17 ++---
src/xen/xen_inotify.c| 4 +---
src/xen/xend_internal.c | 38
On 07/04/13 14:06, Michal Privoznik wrote:
---
src/node_device/node_device_driver.c | 4 +---
src/node_device/node_device_udev.c | 18 --
2 files changed, 5 insertions(+), 17 deletions(-)
ACK,
Peter
--
libvir-list mailing list
libvir-list@redhat.com
On 07/04/13 14:06, Michal Privoznik wrote:
---
src/hyperv/hyperv_driver.c | 21 ++---
src/hyperv/hyperv_util.c | 4 +---
src/hyperv/hyperv_wmi.c| 8 ++--
3 files changed, 9 insertions(+), 24 deletions(-)
ACK,
Peter
--
libvir-list mailing list
On 07/04/2013 02:06 PM, Michal Privoznik wrote:
---
src/xenxs/xen_sxpr.c | 112
src/xenxs/xen_xm.c | 204
++-
2 files changed, 135 insertions(+), 181 deletions(-)
ACK
Jan
--
libvir-list mailing list
On 07/04/2013 02:06 PM, Michal Privoznik wrote:
[...]
diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c
index ba93233..7288ce7 100644
--- a/src/qemu/qemu_command.c
+++ b/src/qemu/qemu_command.c
@@ -10289,7 +10186,7 @@ virDomainDefPtr qemuParseCommandLine(virCapsPtr
qemuCaps,
On 07/04/13 14:06, Michal Privoznik wrote:
---
src/uml/uml_conf.c | 28 +++-
src/uml/uml_driver.c | 36 +---
2 files changed, 16 insertions(+), 48 deletions(-)
diff --git a/src/uml/uml_conf.c b/src/uml/uml_conf.c
index
On Mon, Jul 08, 2013 at 08:58:02 +0200, Peter Krempa wrote:
On 07/04/13 20:13, Jiri Denemark wrote:
https://bugzilla.redhat.com/show_bug.cgi?id=981139
If a domain is paused before migration starts, we need to tell that to
the destination libvirtd to prevent it from resuming the domain at
On Mon, Jul 08, 2013 at 08:55:31 +0200, Peter Krempa wrote:
On 07/04/13 21:45, Jiri Denemark wrote:
---
src/qemu/qemu_process.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
ACK.
Peter
Pushed, thanks.
Jirka
--
libvir-list mailing list
libvir-list@redhat.com
On Fri, Jul 05, 2013 at 09:46:26 +0200, Michal Privoznik wrote:
On 04.07.2013 21:46, Jiri Denemark wrote:
Whenever virPortAllocatorRelease is called with port == 0, it complains
that the port is not in an allowed range, which is expectable as the
port was never allocated. Let's make
On 07/04/2013 02:06 PM, Michal Privoznik wrote:
---
src/parallels/parallels_driver.c | 65
+++
src/parallels/parallels_network.c | 24 ---
src/parallels/parallels_storage.c | 50 +-
src/parallels/parallels_utils.c
On 07/04/13 14:06, Michal Privoznik wrote:
---
src/vmx/vmx.c | 92 +++
1 file changed, 23 insertions(+), 69 deletions(-)
diff --git a/src/vmx/vmx.c b/src/vmx/vmx.c
index 5464d13..64bf4be 100644
--- a/src/vmx/vmx.c
+++ b/src/vmx/vmx.c
On 07/04/2013 02:06 PM, Michal Privoznik wrote:
---
tests/commandtest.c | 8 ++--
tests/libvirtdconftest.c | 4 +---
tests/qemumonitortestutils.c | 17 +
tests/securityselinuxlabeltest.c | 21 +
tests/securityselinuxtest.c
On 07/04/2013 02:06 PM, Michal Privoznik wrote:
---
src/openvz/openvz_conf.c | 42 --
src/openvz/openvz_driver.c | 10 +++---
2 files changed, 19 insertions(+), 33 deletions(-)
ACK
Jan
--
libvir-list mailing list
libvir-list@redhat.com
On 07/04/2013 02:06 PM, Michal Privoznik wrote:
---
src/fdstream.c | 4 +---
src/libvirt.c | 21 ++---
src/nodeinfo.c | 58
++
3 files changed, 21 insertions(+), 62 deletions(-)
ACK
Jan
--
libvir-list mailing list
On 07/04/2013 02:06 PM, Michal Privoznik wrote:
---
src/security/security_apparmor.c | 25 ++--
src/security/security_dac.c | 12 +++-
src/security/security_manager.c | 8 ++--
src/security/security_selinux.c | 41
On Fri, Jun 28, 2013 at 17:04:27 +0200, Jiri Denemark wrote:
We need to set memory limits in several cases:
- when setting hard_limit in memory cgroup
- when starting a domain with a VFIO PCI device attached
- when hotplugging a VFIO PCI device
- when memoryBacking/locked is used
This
On 07/03/2013 11:17 AM, Daniel P. Berrange wrote:
On Wed, Jul 03, 2013 at 10:05:58AM -0400, John Ferlan wrote:
Two complaints of RESOURCE_FREE due to going to cleanup prior to a
VIR_FREE(line). Two complaints of FORWARD_NULL due to 'tmp' being
accessed after a strchr() without first checking
On 07/04/13 14:06, Michal Privoznik wrote:
---
src/network/bridge_driver.c | 138 +---
1 file changed, 40 insertions(+), 98 deletions(-)
ACK,
Peter
--
libvir-list mailing list
libvir-list@redhat.com
On 07/04/2013 02:06 PM, Michal Privoznik wrote:
---
src/rpc/gendispatch.pl| 8 ++--
src/rpc/virnetclient.c| 26 --
src/rpc/virnetclientprogram.c | 12 +++-
src/rpc/virnetclientstream.c | 4 +---
src/rpc/virnetmessage.c | 24
On 07/04/13 14:06, Michal Privoznik wrote:
---
src/vmware/vmware_conf.c | 33 +++--
src/vmware/vmware_driver.c | 4 +---
2 files changed, 8 insertions(+), 29 deletions(-)
diff --git a/src/vmware/vmware_conf.c b/src/vmware/vmware_conf.c
index 9d3d37e..b6d20ea
On 07/04/2013 02:06 PM, Michal Privoznik wrote:
---
src/phyp/phyp_driver.c | 95
+-
1 file changed, 24 insertions(+), 71 deletions(-)
ACK,
Martin
--
libvir-list mailing list
libvir-list@redhat.com
On 07/04/2013 02:06 PM, Michal Privoznik wrote:
---
src/cpu/cpu.c | 4 +--
src/cpu/cpu_arm.c | 6 +---
src/cpu/cpu_generic.c | 12 +++
src/cpu/cpu_powerpc.c | 20 +++-
src/cpu/cpu_s390.c| 4 +--
src/cpu/cpu_x86.c | 86
From: Jincheng Miao jm...@redhat.com
The index of the controller should not be less than zero.
So use virStrToLong_ui() to check the controller index in
virDomainControllerDefParseXML().
---
src/conf/domain_conf.c |2 +-
src/conf/domain_conf.h |2 +-
src/qemu/qemu_command.c |2 +-
On 07/03/2013 02:43 PM, Peter Krempa wrote:
---
src/security/security_selinux.c | 14 ++
1 file changed, 6 insertions(+), 8 deletions(-)
ACK,
Martin
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
On 07/03/2013 02:43 PM, Peter Krempa wrote:
The imagelabel SELinux label was only generated when relabeling was
enabled. This prohibited labeling of files created by libvirt that need
to be labeled even if relabeling is turned off.
The only codepath this change has direct impact on is
On 05.07.2013 17:39, Chris Evich wrote:
On 07/04/2013 03:43 AM, Michal Privoznik wrote:
On 03.07.2013 20:34, Chris Evich wrote:
On 07/03/2013 09:46 AM, Daniel P. Berrange wrote:
On Wed, Jul 03, 2013 at 09:44:46AM -0400, Chris Evich wrote:
Hi,
On Fedora 18 (libvirt 0.10.2.6-1) I'm trying to
For low-memory domains (roughly under 400MB) our automatic memory limit
computation comes up with a limit that's too low. This is because the
0.5 multiplication does not add enough for such small values. Let's
increase the constant part of the computation to fix this.
---
src/qemu/qemu_domain.c |
On Mon, Jul 08, 2013 at 07:44:18AM -0600, Eric Blake wrote:
On 07/04/2013 03:32 AM, Daniel P. Berrange wrote:
On Wed, Jul 03, 2013 at 03:07:51PM -0600, Eric Blake wrote:
Based on a report by Chandrashekar Shastri, at
https://bugzilla.redhat.com/show_bug.cgi?id=979360
On systems where
On 05.07.2013 20:46, Laine Stump wrote:
Eliminate memmove() by using VIR_*_ELEMENT API instead.
In both pci and usb cases, the count that held the size of the list
was unsigned int so it had to be changed to size_t.
---
This is an alternate fix to the same problem fixed by
On 07/05/2013 08:00 AM, Laine Stump wrote:
On 07/04/2013 01:43 AM, Caizhifeng wrote:
Hi ALL,
In order to catch the calltrace of deadlock in libvirtd, I modified the
function virMutexLock as follows:
But, unfortunatly, sometimes, deadlock happened in child process after
virFork,
The
On 07/08/2013 02:27 AM, Nehal J. Wani wrote:
Eric, could you please share your opinion as to what should be more
appropriate to use for this functionality: Structs/XML/VirTypedParams ?
Looking at this possible approach of virTypedParameter, I'm think I am
preferring either the XML or fixed
[please don't top-post on technical lists]
On 07/02/2013 05:04 AM, Nehal J. Wani wrote:
Following will be the methods:
(i) Querying qemu-guest-agent
(ii) Getting info from dnsmasq.leases file
(iii) Using the nwfilter to snoop the traffic
Valid values:
domifaddr domain-name qemu-ga
In nodeGetFreeMemory/nodeGetCellsFreeMemory, they will calculate the free
memory of every nodes. They assumed that nodeid of NUMA machine must be
continuous and start from 0.
But here is a counter-example:
# numactl -H
available: 1 nodes (1)
node 1 cpus: 0 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15
On 07/08/13 14:35, Martin Kletzander wrote:
On 07/03/2013 02:43 PM, Peter Krempa wrote:
---
src/security/security_selinux.c | 14 ++
1 file changed, 6 insertions(+), 8 deletions(-)
ACK,
Pushed; Thanks.
Peter
--
libvir-list mailing list
libvir-list@redhat.com
On 07/08/13 15:01, Martin Kletzander wrote:
On 07/03/2013 02:43 PM, Peter Krempa wrote:
The imagelabel SELinux label was only generated when relabeling was
enabled. This prohibited labeling of files created by libvirt that need
to be labeled even if relabeling is turned off.
The only codepath
From: Daniel P. Berrange berra...@redhat.com
Convert the type of loop iterators named 'i', 'j', k',
'ii', 'jj', 'kk', to be 'size_t' instead of 'int' or
'unsigned int', also santizing 'ii', 'jj', 'kk' to use
the normal 'i', 'j', 'k' naming
Signed-off-by: Daniel P. Berrange berra...@redhat.com
From: Daniel P. Berrange berra...@redhat.com
Convert the type of loop iterators named 'i', 'j', k',
'ii', 'jj', 'kk', to be 'size_t' instead of 'int' or
'unsigned int', also santizing 'ii', 'jj', 'kk' to use
the normal 'i', 'j', 'k' naming
Signed-off-by: Daniel P. Berrange berra...@redhat.com
From: Daniel P. Berrange berra...@redhat.com
Convert the type of loop iterators named 'i', 'j', k',
'ii', 'jj', 'kk', to be 'size_t' instead of 'int' or
'unsigned int', also santizing 'ii', 'jj', 'kk' to use
the normal 'i', 'j', 'k' naming
Signed-off-by: Daniel P. Berrange berra...@redhat.com
From: Daniel P. Berrange berra...@redhat.com
Convert the type of loop iterators named 'i', 'j', k',
'ii', 'jj', 'kk', to be 'size_t' instead of 'int' or
'unsigned int', also santizing 'ii', 'jj', 'kk' to use
the normal 'i', 'j', 'k' naming
Signed-off-by: Daniel P. Berrange berra...@redhat.com
From: Daniel P. Berrange berra...@redhat.com
Convert the type of loop iterators named 'i', 'j', k',
'ii', 'jj', 'kk', to be 'size_t' instead of 'int' or
'unsigned int', also santizing 'ii', 'jj', 'kk' to use
the normal 'i', 'j', 'k' naming
Signed-off-by: Daniel P. Berrange berra...@redhat.com
From: Daniel P. Berrange berra...@redhat.com
Convert the type of loop iterators named 'i', 'j', k',
'ii', 'jj', 'kk', to be 'size_t' instead of 'int' or
'unsigned int', also santizing 'ii', 'jj', 'kk' to use
the normal 'i', 'j', 'k' naming
Signed-off-by: Daniel P. Berrange berra...@redhat.com
From: Daniel P. Berrange berra...@redhat.com
Convert the type of loop iterators named 'i', 'j', k',
'ii', 'jj', 'kk', to be 'size_t' instead of 'int' or
'unsigned int', also santizing 'ii', 'jj', 'kk' to use
the normal 'i', 'j', 'k' naming
Signed-off-by: Daniel P. Berrange berra...@redhat.com
From: Daniel P. Berrange berra...@redhat.com
Convert the type of loop iterators named 'i', 'j', k',
'ii', 'jj', 'kk', to be 'size_t' instead of 'int' or
'unsigned int', also santizing 'ii', 'jj', 'kk' to use
the normal 'i', 'j', 'k' naming
Signed-off-by: Daniel P. Berrange berra...@redhat.com
From: Daniel P. Berrange berra...@redhat.com
Convert the type of loop iterators named 'i', 'j', k',
'ii', 'jj', 'kk', to be 'size_t' instead of 'int' or
'unsigned int', also santizing 'ii', 'jj', 'kk' to use
the normal 'i', 'j', 'k' naming
Signed-off-by: Daniel P. Berrange berra...@redhat.com
From: Daniel P. Berrange berra...@redhat.com
Add two syntax-check rules
- sc_prohibit_int_ijk - block use of 'int' as a data type
for any variables named 'i', 'j', 'k'
- sc_prohibit_int_iijjkk - block use of 'ii', 'jj', 'kk'
for any variable names
---
cfg.mk | 14 ++
1 file
From: Daniel P. Berrange berra...@redhat.com
The libvirt code has a mixture of data types used for the common
'i', 'j', 'k' variable names, int, unsigned int size_t. Change
them all to use 'size_t'. In the few cases which actually required
the use of a signed variable, either the use of the
From: Daniel P. Berrange berra...@redhat.com
Convert the type of loop iterators named 'i', 'j', k',
'ii', 'jj', 'kk', to be 'size_t' instead of 'int' or
'unsigned int', also santizing 'ii', 'jj', 'kk' to use
the normal 'i', 'j', 'k' naming
Signed-off-by: Daniel P. Berrange berra...@redhat.com
From: Daniel P. Berrange berra...@redhat.com
Convert the type of loop iterators named 'i', 'j', k',
'ii', 'jj', 'kk', to be 'size_t' instead of 'int' or
'unsigned int', also santizing 'ii', 'jj', 'kk' to use
the normal 'i', 'j', 'k' naming
Signed-off-by: Daniel P. Berrange berra...@redhat.com
From: Daniel P. Berrange berra...@redhat.com
Convert the type of loop iterators named 'i', 'j', k',
'ii', 'jj', 'kk', to be 'size_t' instead of 'int' or
'unsigned int', also santizing 'ii', 'jj', 'kk' to use
the normal 'i', 'j', 'k' naming
Signed-off-by: Daniel P. Berrange berra...@redhat.com
From: Daniel P. Berrange berra...@redhat.com
Convert the type of loop iterators named 'i', 'j', k',
'ii', 'jj', 'kk', to be 'size_t' instead of 'int' or
'unsigned int', also santizing 'ii', 'jj', 'kk' to use
the normal 'i', 'j', 'k' naming
Signed-off-by: Daniel P. Berrange berra...@redhat.com
From: Daniel P. Berrange berra...@redhat.com
Convert the type of loop iterators named 'i', 'j', k',
'ii', 'jj', 'kk', to be 'size_t' instead of 'int' or
'unsigned int', also santizing 'ii', 'jj', 'kk' to use
the normal 'i', 'j', 'k' naming
Signed-off-by: Daniel P. Berrange berra...@redhat.com
From: Daniel P. Berrange berra...@redhat.com
Convert the type of loop iterators named 'i', 'j', k',
'ii', 'jj', 'kk', to be 'size_t' instead of 'int' or
'unsigned int', also santizing 'ii', 'jj', 'kk' to use
the normal 'i', 'j', 'k' naming
Signed-off-by: Daniel P. Berrange berra...@redhat.com
From: Daniel P. Berrange berra...@redhat.com
Convert the type of loop iterators named 'i', 'j', k',
'ii', 'jj', 'kk', to be 'size_t' instead of 'int' or
'unsigned int', also santizing 'ii', 'jj', 'kk' to use
the normal 'i', 'j', 'k' naming
Signed-off-by: Daniel P. Berrange berra...@redhat.com
From: Daniel P. Berrange berra...@redhat.com
Convert the type of loop iterators named 'i', 'j', k',
'ii', 'jj', 'kk', to be 'size_t' instead of 'int' or
'unsigned int', also santizing 'ii', 'jj', 'kk' to use
the normal 'i', 'j', 'k' naming
Signed-off-by: Daniel P. Berrange berra...@redhat.com
From: Daniel P. Berrange berra...@redhat.com
Convert the type of loop iterators named 'i', 'j', k',
'ii', 'jj', 'kk', to be 'size_t' instead of 'int' or
'unsigned int', also santizing 'ii', 'jj', 'kk' to use
the normal 'i', 'j', 'k' naming
Signed-off-by: Daniel P. Berrange berra...@redhat.com
From: Daniel P. Berrange berra...@redhat.com
Convert the type of loop iterators named 'i', 'j', k',
'ii', 'jj', 'kk', to be 'size_t' instead of 'int' or
'unsigned int', also santizing 'ii', 'jj', 'kk' to use
the normal 'i', 'j', 'k' naming
Signed-off-by: Daniel P. Berrange berra...@redhat.com
From: Daniel P. Berrange berra...@redhat.com
Convert the type of loop iterators named 'i', 'j', k',
'ii', 'jj', 'kk', to be 'size_t' instead of 'int' or
'unsigned int', also santizing 'ii', 'jj', 'kk' to use
the normal 'i', 'j', 'k' naming
Signed-off-by: Daniel P. Berrange berra...@redhat.com
From: Daniel P. Berrange berra...@redhat.com
Convert the type of loop iterators named 'i', 'j', k',
'ii', 'jj', 'kk', to be 'size_t' instead of 'int' or
'unsigned int', also santizing 'ii', 'jj', 'kk' to use
the normal 'i', 'j', 'k' naming
Signed-off-by: Daniel P. Berrange berra...@redhat.com
From: Daniel P. Berrange berra...@redhat.com
Convert the type of loop iterators named 'i', 'j', k',
'ii', 'jj', 'kk', to be 'size_t' instead of 'int' or
'unsigned int', also santizing 'ii', 'jj', 'kk' to use
the normal 'i', 'j', 'k' naming
Signed-off-by: Daniel P. Berrange berra...@redhat.com
From: Daniel P. Berrange berra...@redhat.com
Convert the type of loop iterators named 'i', 'j', k',
'ii', 'jj', 'kk', to be 'size_t' instead of 'int' or
'unsigned int', also santizing 'ii', 'jj', 'kk' to use
the normal 'i', 'j', 'k' naming
Signed-off-by: Daniel P. Berrange berra...@redhat.com
From: Daniel P. Berrange berra...@redhat.com
Convert the type of loop iterators named 'i', 'j', k',
'ii', 'jj', 'kk', to be 'size_t' instead of 'int' or
'unsigned int', also santizing 'ii', 'jj', 'kk' to use
the normal 'i', 'j', 'k' naming
Signed-off-by: Daniel P. Berrange berra...@redhat.com
From: Daniel P. Berrange berra...@redhat.com
Convert the type of loop iterators named 'i', 'j', k',
'ii', 'jj', 'kk', to be 'size_t' instead of 'int' or
'unsigned int', also santizing 'ii', 'jj', 'kk' to use
the normal 'i', 'j', 'k' naming
Signed-off-by: Daniel P. Berrange berra...@redhat.com
From: Daniel P. Berrange berra...@redhat.com
Convert the type of loop iterators named 'i', 'j', k',
'ii', 'jj', 'kk', to be 'size_t' instead of 'int' or
'unsigned int', also santizing 'ii', 'jj', 'kk' to use
the normal 'i', 'j', 'k' naming
Signed-off-by: Daniel P. Berrange berra...@redhat.com
From: Daniel P. Berrange berra...@redhat.com
Convert the type of loop iterators named 'i', 'j', k',
'ii', 'jj', 'kk', to be 'size_t' instead of 'int' or
'unsigned int', also santizing 'ii', 'jj', 'kk' to use
the normal 'i', 'j', 'k' naming
Signed-off-by: Daniel P. Berrange berra...@redhat.com
From: Daniel P. Berrange berra...@redhat.com
Convert the type of loop iterators named 'i', 'j', k',
'ii', 'jj', 'kk', to be 'size_t' instead of 'int' or
'unsigned int', also santizing 'ii', 'jj', 'kk' to use
the normal 'i', 'j', 'k' naming
Signed-off-by: Daniel P. Berrange berra...@redhat.com
From: Daniel P. Berrange berra...@redhat.com
Convert the type of loop iterators named 'i', 'j', k',
'ii', 'jj', 'kk', to be 'size_t' instead of 'int' or
'unsigned int', also santizing 'ii', 'jj', 'kk' to use
the normal 'i', 'j', 'k' naming
Signed-off-by: Daniel P. Berrange berra...@redhat.com
On 07/08/2013 02:08 PM, jm...@redhat.com wrote:
From: Jincheng Miao jm...@redhat.com
The index of the controller should not be less than zero.
So use virStrToLong_ui() to check the controller index in
virDomainControllerDefParseXML().
---
src/conf/domain_conf.c |2 +-
The device bus value was used instead of the device target when
building the sysfs device path. Trivial.
Signed-off-by: Viktor Mihajlovski mihaj...@linux.vnet.ibm.com
---
Should probably go into the 1.0.6 maintenance branch as well.
src/util/virscsi.c |2 +-
1 file changed, 1 insertion(+),
On 07/03/2013 08:20 AM, Michal Privoznik wrote:
On 03.07.2013 14:12, Ján Tomko wrote:
On 07/03/2013 02:03 PM, Michal Privoznik wrote:
On 02.07.2013 15:39, John Ferlan wrote:
+case QEMU_MONITOR_OBJECT_PROPERTY_STRING:
+tmp = virJSONValueGetString(data);
+if (tmp
On 07/03/2013 08:03 AM, Michal Privoznik wrote:
On 02.07.2013 15:39, John Ferlan wrote:
Extend the virDomainSetMemeoryFlags() to accept a 'VIR_DOMAIN_MEM_PERIOD'
which will be used to dynamically set the collection period for the balloon
driver via a 'virsh dommemstat domain --period value'
Add a new qemuMonitorJSONGetObjectListPaths() method to support invocation
of the 'qom-list' JSON monitor command with a provided path.
The returned list of paired data fields of name and type that can
be used to peruse QOM configuration data and eventually utilize for the
balloon statistics.
This patchset replaces:
https://www.redhat.com/archives/libvir-list/2013-July/msg00108.html
Changes since V1:
* Remove the external (eg, qemu_monitor.{c,h}) API's to the qom-list,
qom-get, qom-set interfaces
* Handle errors in virXPathInt() return checking domain_conf.c
* Move the 'period'
At vm startup, reconnect, and attach - check for the presence of the balloon
driver and save the path in the private area of the driver. This path will
remain constant throughout the life of the domain and can then be used rather
than attempting to find the path each time balloon driver
Add a period in seconds to allow/enable statistics gathering from the
Balloon driver for 'virsh dommemstat domain'.
---
docs/formatdomain.html.in | 10 ++
docs/schemas/domaincommon.rng | 7 +++
src/conf/domain_conf.c| 44 +--
Use the virDomainSetMemoryStatsPeriodFlags() to pass a period defined by
usage of a new --period option in order to set the collection period for the
balloon driver. This may enable or disable the collection based on the value.
Add the --current, --live, --config options to dommemstat.
---
Add a new qemuMonitorJSONSetObjectProperty() method to support invocation
of the 'qom-set' JSON monitor command with a provided path, property, and
expected data type to set.
The test code uses the same /machine/i440fx property as the get test and
attempts to set the realized property to true
This patch will add the QEMU_MONITOR_OBJECT_PROPERTY_BALLOON_STATS type and
a mechanism in the qemuMonitorObjectProperty to fetch and store an opaque
data array assuming that we are provided a count of current elements,
a count of maximum elements, and the address of the array store the data.
Use
Implement the new API that will handle setting the balloon driver statistics
collection period in order to enable or disable the collection dynamically.
---
src/qemu/qemu_driver.c | 66 ++
1 file changed, 66 insertions(+)
diff --git
Add new API in order to set the balloon memory driver statistics collection
period in order to allow dynamic period adjustment for the virsh dommemstats to
display balloon stats data
---
include/libvirt/libvirt.h.in | 3 ++
src/driver.h | 6
src/libvirt.c|
Add a new qemuMonitorJSONGetObjectProperty() method to support invocation
of the 'qom-get' JSON monitor command with a provided path, property, and
expected data type return. The qemuMonitorJSONObjectProperty is similar to
virTypedParameter; however, a future patch will extend it a bit to include
1 - 100 of 111 matches
Mail list logo
