Re: [libvirt] [PATCH 02/32] Convert 'int i' to 'size_t i' in src/conf/ files

2013-07-09 Thread Ján Tomko
On 07/08/2013 04:21 PM, Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com Convert the type of loop iterators named 'i', 'j', k', 'ii', 'jj', 'kk', to be 'size_t' instead of 'int' or 'unsigned int', also santizing 'ii', 'jj', 'kk' to use the normal 'i', 'j', 'k' naming

Re: [libvirt] [PATCH 03/32] Convert 'int i' to 'size_t i' in src/util/ files

2013-07-09 Thread Ján Tomko
On 07/08/2013 04:21 PM, Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com Convert the type of loop iterators named 'i', 'j', k', 'ii', 'jj', 'kk', to be 'size_t' instead of 'int' or 'unsigned int', also santizing 'ii', 'jj', 'kk' to use the normal 'i', 'j', 'k' naming

Re: [libvirt] [PATCH 04/32] Convert 'int i' to 'size_t i' in tests/ files

2013-07-09 Thread Ján Tomko
On 07/08/2013 04:21 PM, Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com Convert the type of loop iterators named 'i', 'j', k', 'ii', 'jj', 'kk', to be 'size_t' instead of 'int' or 'unsigned int', also santizing 'ii', 'jj', 'kk' to use the normal 'i', 'j', 'k' naming

Re: [libvirt] [PATCH v2 1/3] libxl: implement NUMA capabilities reporting

2013-07-09 Thread Dario Faggioli
On lun, 2013-07-08 at 18:45 -0600, Jim Fehlig wrote: Dario Faggioli wrote: diff --git a/src/libxl/libxl_conf.c b/src/libxl/libxl_conf.c index e170357..7515995 100644 --- a/src/libxl/libxl_conf.c +++ b/src/libxl/libxl_conf.c @@ -161,6 +161,115 @@ libxlBuildCapabilities(virArch hostarch,

Re: [libvirt] [PATCH 02/32] Convert 'int i' to 'size_t i' in src/conf/ files

2013-07-09 Thread Guannan Ren
On 07/08/2013 10:21 PM, Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com Convert the type of loop iterators named 'i', 'j', k', 'ii', 'jj', 'kk', to be 'size_t' instead of 'int' or 'unsigned int', also santizing 'ii', 'jj', 'kk' to use the normal 'i', 'j', 'k' naming

Re: [libvirt] [PATCH] lxc: Create /dev/tty within a container

2013-07-09 Thread Daniel P. Berrange
On Wed, Jun 12, 2013 at 07:46:28PM +0200, Richard Weinberger wrote: Many applications use /dev/tty to read from stdin. E.g. zypper on openSUSE. Let's create this device node to unbreak those applications. As /dev/tty is a synonym for the current controlling terminal it cannot harm the host

Re: [libvirt] [PATCH 05/32] Convert 'int i' to 'size_t i' in tools/ files

2013-07-09 Thread Ján Tomko
On 07/08/2013 04:21 PM, Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com Convert the type of loop iterators named 'i', 'j', k', 'ii', 'jj', 'kk', to be 'size_t' instead of 'int' or 'unsigned int', also santizing 'ii', 'jj', 'kk' to use the normal 'i', 'j', 'k' naming

Re: [libvirt] [PATCH 1/2] LXC: hostdev: introduce lxcContainerSetupHostdevCapsMakePath

2013-07-09 Thread Daniel P. Berrange
On Tue, Jul 09, 2013 at 11:20:35AM +0800, Gao feng wrote: This helper function is used to create parent directroy for the hostdev which will be added to the container. if the parent directory of this hostdev doesn't exist, the mknod of the hostdev will fail. Signed-off-by: Gao feng

Re: [libvirt] [PATCH 2/2] LXC: hostdev: parent directroy for hostdev atomically

2013-07-09 Thread Daniel P. Berrange
On Tue, Jul 09, 2013 at 11:20:36AM +0800, Gao feng wrote: Create parent directroy for hostdev atomically when we start a lxc domain or attach a hostdev to a lxc domain. Signed-off-by: Gao feng gaof...@cn.fujitsu.com --- src/lxc/lxc_container.c | 42

[libvirt] [Qeustion] NPIV support on guest

2013-07-09 Thread Ren Mingxin
Hi, It seems this is a old question, but I couldn't get a exact answer via historical mails: How to assign vhba to guest now? It'll be much appreciated if exact xml format/qemu commandcan be showed. And, it seems that persistent vhba hasn't been supported by libvirt, yes? Thanks, Ren --

Re: [libvirt] [PATCH 06/32] Convert 'int i' to 'size_t i' in src/{xen, xenapi, xenxs} files

2013-07-09 Thread Ján Tomko
On 07/08/2013 04:21 PM, Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com Convert the type of loop iterators named 'i', 'j', k', 'ii', 'jj', 'kk', to be 'size_t' instead of 'int' or 'unsigned int', also santizing 'ii', 'jj', 'kk' to use the normal 'i', 'j', 'k' naming

Re: [libvirt] [PATCH 03/32] Convert 'int i' to 'size_t i' in src/util/ files

2013-07-09 Thread Guannan Ren
On 07/08/2013 10:21 PM, Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com Convert the type of loop iterators named 'i', 'j', k', 'ii', 'jj', 'kk', to be 'size_t' instead of 'int' or 'unsigned int', also santizing 'ii', 'jj', 'kk' to use the normal 'i', 'j', 'k' naming

Re: [libvirt] [PATCH 07/32] Convert 'int i' to 'size_t i' in src/{esx, vmx, vmware} files

2013-07-09 Thread Ján Tomko
On 07/08/2013 04:21 PM, Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com Convert the type of loop iterators named 'i', 'j', k', 'ii', 'jj', 'kk', to be 'size_t' instead of 'int' or 'unsigned int', also santizing 'ii', 'jj', 'kk' to use the normal 'i', 'j', 'k' naming

Re: [libvirt] [PATCH 08/32] Convert 'int i' to 'size_t i' in src/storage/ files

2013-07-09 Thread Ján Tomko
On 07/08/2013 04:21 PM, Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com Convert the type of loop iterators named 'i', 'j', k', 'ii', 'jj', 'kk', to be 'size_t' instead of 'int' or 'unsigned int', also santizing 'ii', 'jj', 'kk' to use the normal 'i', 'j', 'k' naming

Re: [libvirt] [PATCH 09/32] Convert 'int i' to 'size_t i' in src/vbox/ files

2013-07-09 Thread Ján Tomko
On 07/08/2013 04:21 PM, Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com Convert the type of loop iterators named 'i', 'j', k', 'ii', 'jj', 'kk', to be 'size_t' instead of 'int' or 'unsigned int', also santizing 'ii', 'jj', 'kk' to use the normal 'i', 'j', 'k' naming

Re: [libvirt] [PATCH 10/32] Convert 'int i' to 'size_t i' in src/uml/ files

2013-07-09 Thread Ján Tomko
On 07/08/2013 04:21 PM, Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com Convert the type of loop iterators named 'i', 'j', k', 'ii', 'jj', 'kk', to be 'size_t' instead of 'int' or 'unsigned int', also santizing 'ii', 'jj', 'kk' to use the normal 'i', 'j', 'k' naming

Re: [libvirt] [PATCH 11/32] Convert 'int i' to 'size_t i' in src/test/ files

2013-07-09 Thread Ján Tomko
On 07/08/2013 04:21 PM, Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com Convert the type of loop iterators named 'i', 'j', k', 'ii', 'jj', 'kk', to be 'size_t' instead of 'int' or 'unsigned int', also santizing 'ii', 'jj', 'kk' to use the normal 'i', 'j', 'k' naming

Re: [libvirt] [PATCH 13/32] Convert 'int i' to 'size_t i' in src/secret/ files

2013-07-09 Thread Ján Tomko
On 07/08/2013 04:21 PM, Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com Convert the type of loop iterators named 'i', 'j', k', 'ii', 'jj', 'kk', to be 'size_t' instead of 'int' or 'unsigned int', also santizing 'ii', 'jj', 'kk' to use the normal 'i', 'j', 'k' naming

Re: [libvirt] [PATCH 12/32] Convert 'int i' to 'size_t i' in src/security files

2013-07-09 Thread Ján Tomko
On 07/08/2013 04:21 PM, Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com Convert the type of loop iterators named 'i', 'j', k', 'ii', 'jj', 'kk', to be 'size_t' instead of 'int' or 'unsigned int', also santizing 'ii', 'jj', 'kk' to use the normal 'i', 'j', 'k' naming

Re: [libvirt] [PATCH 05/32] Convert 'int i' to 'size_t i' in tools/ files

2013-07-09 Thread Guannan Ren
On 07/08/2013 10:21 PM, Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com Convert the type of loop iterators named 'i', 'j', k', 'ii', 'jj', 'kk', to be 'size_t' instead of 'int' or 'unsigned int', also santizing 'ii', 'jj', 'kk' to use the normal 'i', 'j', 'k' naming

Re: [libvirt] [PATCH 14/32] Convert 'int i' to 'size_t i' in src/rpc/ files

2013-07-09 Thread Ján Tomko
On 07/08/2013 04:21 PM, Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com Convert the type of loop iterators named 'i', 'j', k', 'ii', 'jj', 'kk', to be 'size_t' instead of 'int' or 'unsigned int', also santizing 'ii', 'jj', 'kk' to use the normal 'i', 'j', 'k' naming

Re: [libvirt] [PATCH 17/32] Convert 'int i' to 'size_t i' in src/phyp/ files

2013-07-09 Thread Ján Tomko
On 07/08/2013 04:21 PM, Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com Convert the type of loop iterators named 'i', 'j', k', 'ii', 'jj', 'kk', to be 'size_t' instead of 'int' or 'unsigned int', also santizing 'ii', 'jj', 'kk' to use the normal 'i', 'j', 'k' naming

Re: [libvirt] [PATCH 15/32] Convert 'int i' to 'size_t i' in src/remote/ files

2013-07-09 Thread Ján Tomko
On 07/08/2013 04:21 PM, Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com Convert the type of loop iterators named 'i', 'j', k', 'ii', 'jj', 'kk', to be 'size_t' instead of 'int' or 'unsigned int', also santizing 'ii', 'jj', 'kk' to use the normal 'i', 'j', 'k' naming

Re: [libvirt] [PATCH 18/32] Convert 'int i' to 'size_t i' in src/parallels/ files

2013-07-09 Thread Ján Tomko
On 07/08/2013 04:21 PM, Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com Convert the type of loop iterators named 'i', 'j', k', 'ii', 'jj', 'kk', to be 'size_t' instead of 'int' or 'unsigned int', also santizing 'ii', 'jj', 'kk' to use the normal 'i', 'j', 'k' naming

Re: [libvirt] [PATCH 19/32] Convert 'int i' to 'size_t i' in src/openvz/ files

2013-07-09 Thread Ján Tomko
On 07/08/2013 04:21 PM, Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com Convert the type of loop iterators named 'i', 'j', k', 'ii', 'jj', 'kk', to be 'size_t' instead of 'int' or 'unsigned int', also santizing 'ii', 'jj', 'kk' to use the normal 'i', 'j', 'k' naming

Re: [libvirt] [PATCH 20/32] Convert 'int i' to 'size_t i' in src/nwfilter/ files

2013-07-09 Thread Ján Tomko
On 07/08/2013 04:21 PM, Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com Convert the type of loop iterators named 'i', 'j', k', 'ii', 'jj', 'kk', to be 'size_t' instead of 'int' or 'unsigned int', also santizing 'ii', 'jj', 'kk' to use the normal 'i', 'j', 'k' naming

Re: [libvirt] [PATCH 21/32] Convert 'int i' to 'size_t i' in src/node_device/ files

2013-07-09 Thread Ján Tomko
On 07/08/2013 04:21 PM, Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com Convert the type of loop iterators named 'i', 'j', k', 'ii', 'jj', 'kk', to be 'size_t' instead of 'int' or 'unsigned int', also santizing 'ii', 'jj', 'kk' to use the normal 'i', 'j', 'k' naming

Re: [libvirt] [PATCH] Split up platfrom specifics from bridge driver

2013-07-09 Thread Daniel P. Berrange
On Thu, Jul 04, 2013 at 08:25:32PM +0400, Roman Bogorodskiy wrote: * Functions were renamed: s/Iptables/Firewall/ to make names more general. * Platform specific things (e.g. firewalling and route collision checks) were moved into bridge_driver_platform * Created two platform specific

Re: [libvirt] [PATCH 23/32] Convert 'int i' to 'size_t i' in src/locking/ files

2013-07-09 Thread Ján Tomko
On 07/08/2013 04:21 PM, Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com Convert the type of loop iterators named 'i', 'j', k', 'ii', 'jj', 'kk', to be 'size_t' instead of 'int' or 'unsigned int', also santizing 'ii', 'jj', 'kk' to use the normal 'i', 'j', 'k' naming

Re: [libvirt] [PATCH 22/32] Convert 'int i' to 'size_t i' in src/lxc/ files

2013-07-09 Thread Ján Tomko
On 07/08/2013 04:21 PM, Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com Convert the type of loop iterators named 'i', 'j', k', 'ii', 'jj', 'kk', to be 'size_t' instead of 'int' or 'unsigned int', also santizing 'ii', 'jj', 'kk' to use the normal 'i', 'j', 'k' naming

Re: [libvirt] LXC: autostart feature does set all interfaces to state up.

2013-07-09 Thread Richard Weinberger
Am 08.07.2013 05:54, schrieb Gao feng: On 07/05/2013 06:22 PM, Richard Weinberger wrote: Am 05.07.2013 03:36, schrieb Gao feng: On 07/05/2013 04:45 AM, Richard Weinberger wrote: Hi, Am 03.07.2013 12:04, schrieb Gao feng: Hi, On 07/01/2013 03:45 PM, Richard Weinberger wrote: Hi! If you

Re: [libvirt] [PATCH 24/32] Convert 'int i' to 'size_t i' in src/libxl/ files

2013-07-09 Thread Ján Tomko
On 07/08/2013 04:21 PM, Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com Convert the type of loop iterators named 'i', 'j', k', 'ii', 'jj', 'kk', to be 'size_t' instead of 'int' or 'unsigned int', also santizing 'ii', 'jj', 'kk' to use the normal 'i', 'j', 'k' naming

[libvirt] [PATCH] Properly detect VMDK with internal version 2

2013-07-09 Thread Martin Kletzander
Initially proposed as [1], but then changed to comment fix only. VMDK can have internal version set to 2 when there are few features added which do not affect us. Thanks to Jan's commit a1ee8e18 this can be easily fixed by adding it to list of supported versions. [1]

[libvirt] [PATCH] LXC: Set default driver for image backed filesystems

2013-07-09 Thread Daniel P. Berrange
From: Daniel P. Berrange berra...@redhat.com If no explicit driver is set for an image backed filesystem, set it to use the loop driver (if raw) or nbd driver (if non-raw) Signed-off-by: Daniel P. Berrange berra...@redhat.com --- src/lxc/lxc_controller.c | 8 1 file changed, 8

[libvirt] [PATCH] LXC: Fix some error reporting in filesystem setup

2013-07-09 Thread Daniel P. Berrange
From: Daniel P. Berrange berra...@redhat.com A couple of places in LXC setup for filesystems did not do a goto cleanup after reporting errors. While fixing this, also add in many more debug statements to aid troubleshooting Signed-off-by: Daniel P. Berrange berra...@redhat.com ---

Re: [libvirt] [PATCH 25/32] Convert 'int i' to 'size_t i' in src/network/ files

2013-07-09 Thread Ján Tomko
On 07/08/2013 04:21 PM, Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com Convert the type of loop iterators named 'i', 'j', k', 'ii', 'jj', 'kk', to be 'size_t' instead of 'int' or 'unsigned int', also santizing 'ii', 'jj', 'kk' to use the normal 'i', 'j', 'k' naming

Re: [libvirt] [PATCH 26/32] Convert 'int i' to 'size_t i' in src/interface/ files

2013-07-09 Thread Ján Tomko
On 07/08/2013 04:21 PM, Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com Convert the type of loop iterators named 'i', 'j', k', 'ii', 'jj', 'kk', to be 'size_t' instead of 'int' or 'unsigned int', also santizing 'ii', 'jj', 'kk' to use the normal 'i', 'j', 'k' naming

Re: [libvirt] [PATCH 27/32] Convert 'int i' to 'size_t i' in src/hyperv/ files

2013-07-09 Thread Ján Tomko
On 07/08/2013 04:21 PM, Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com Convert the type of loop iterators named 'i', 'j', k', 'ii', 'jj', 'kk', to be 'size_t' instead of 'int' or 'unsigned int', also santizing 'ii', 'jj', 'kk' to use the normal 'i', 'j', 'k' naming

Re: [libvirt] [PATCH 06/32] Convert 'int i' to 'size_t i' in src/{xen, xenapi, xenxs} files

2013-07-09 Thread Guannan Ren
On 07/08/2013 10:21 PM, Daniel P. Berrange wrote: From: Daniel P. Berrangeberra...@redhat.com Convert the type of loop iterators named 'i', 'j', k', 'ii', 'jj', 'kk', to be 'size_t' instead of 'int' or 'unsigned int', also santizing 'ii', 'jj', 'kk' to use the normal 'i', 'j', 'k' naming

Re: [libvirt] [PATCH 28/32] Convert 'int i' to 'size_t i' in src/cpu/ files

2013-07-09 Thread Ján Tomko
On 07/08/2013 04:21 PM, Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com Convert the type of loop iterators named 'i', 'j', k', 'ii', 'jj', 'kk', to be 'size_t' instead of 'int' or 'unsigned int', also santizing 'ii', 'jj', 'kk' to use the normal 'i', 'j', 'k' naming

Re: [libvirt] [PATCH] Properly detect VMDK with internal version 2

2013-07-09 Thread Ján Tomko
On 07/09/2013 03:20 PM, Martin Kletzander wrote: Initially proposed as [1], but then changed to comment fix only. VMDK can have internal version set to 2 when there are few features added which do not affect us. Thanks to Jan's commit a1ee8e18 this can be easily fixed by adding it to list of

Re: [libvirt] [PATCH] LXC: Set default driver for image backed filesystems

2013-07-09 Thread Eric Blake
On 07/09/2013 07:25 AM, Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com If no explicit driver is set for an image backed filesystem, set it to use the loop driver (if raw) or nbd driver (if non-raw) Signed-off-by: Daniel P. Berrange berra...@redhat.com ---

Re: [libvirt] [PATCH 29/32] Convert 'int i' to 'size_t i' in src/ files

2013-07-09 Thread Ján Tomko
On 07/08/2013 04:21 PM, Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com Convert the type of loop iterators named 'i', 'j', k', 'ii', 'jj', 'kk', to be 'size_t' instead of 'int' or 'unsigned int', also santizing 'ii', 'jj', 'kk' to use the normal 'i', 'j', 'k' naming

Re: [libvirt] [PATCH] LXC: Fix some error reporting in filesystem setup

2013-07-09 Thread Eric Blake
On 07/09/2013 07:25 AM, Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com A couple of places in LXC setup for filesystems did not do a goto cleanup after reporting errors. While fixing this, also add in many more debug statements to aid troubleshooting Signed-off-by:

[libvirt] [PATCH] daemon: Fix command example in libvirtd.sasl

2013-07-09 Thread Cole Robinson
sasldblistusers2 doesn't have a '-a' option --- daemon/libvirtd.sasl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/daemon/libvirtd.sasl b/daemon/libvirtd.sasl index bfa056f..5e2528d 100644 --- a/daemon/libvirtd.sasl +++ b/daemon/libvirtd.sasl @@ -27,5 +27,5 @@ mech_list:

[libvirt] [PATCH glib] Add support for reading/writing UUID attribute in domain config

2013-07-09 Thread Daniel P. Berrange
From: Daniel P. Berrange berra...@redhat.com Signed-off-by: Daniel P. Berrange berra...@redhat.com --- libvirt-gconfig/libvirt-gconfig-domain.c | 33 libvirt-gconfig/libvirt-gconfig-domain.h | 2 ++ 2 files changed, 35 insertions(+) diff --git

[libvirt] [PATCH] LXC: Ensure security context is set when mounting images

2013-07-09 Thread Daniel P. Berrange
From: Daniel P. Berrange berra...@redhat.com When setting up filesystems backed by block devices or file images, the SELinux mount options must be used to ensure the correct context is set Signed-off-by: Daniel P. Berrange berra...@redhat.com --- src/lxc/lxc_container.c | 36

[libvirt] [PATCH v2 09/37] Adapt to VIR_ALLOC and virAsprintf in src/hyperv/*

2013-07-09 Thread Michal Privoznik
--- src/hyperv/hyperv_driver.c | 21 ++--- src/hyperv/hyperv_util.c | 4 +--- src/hyperv/hyperv_wmi.c| 8 ++-- 3 files changed, 9 insertions(+), 24 deletions(-) diff --git a/src/hyperv/hyperv_driver.c b/src/hyperv/hyperv_driver.c index dd8d018..389a151 100644 ---

[libvirt] [PATCH v2 30/37] Adapt to VIR_ALLOC and virAsprintf in src/vmware/*

2013-07-09 Thread Michal Privoznik
--- src/vmware/vmware_conf.c | 33 +++-- src/vmware/vmware_driver.c | 4 +--- 2 files changed, 8 insertions(+), 29 deletions(-) diff --git a/src/vmware/vmware_conf.c b/src/vmware/vmware_conf.c index 9d3d37e..b6d20ea 100644 --- a/src/vmware/vmware_conf.c +++

[libvirt] [PATCH v2 07/37] Adapt to VIR_ALLOC and virAsprintf in src/cpu/*

2013-07-09 Thread Michal Privoznik
--- src/cpu/cpu.c | 4 +-- src/cpu/cpu_arm.c | 6 +--- src/cpu/cpu_generic.c | 12 +++ src/cpu/cpu_powerpc.c | 20 +++- src/cpu/cpu_s390.c| 4 +-- src/cpu/cpu_x86.c | 86 +++ 6 files changed, 44 insertions(+), 88

[libvirt] [PATCH v2 08/37] Adapt to VIR_ALLOC and virAsprintf in src/esx/*

2013-07-09 Thread Michal Privoznik
--- src/esx/esx_driver.c| 62 +--- src/esx/esx_network_driver.c| 16 +++-- src/esx/esx_storage_backend_iscsi.c | 4 +-- src/esx/esx_storage_backend_vmfs.c | 72 + src/esx/esx_util.c | 4

[libvirt] [PATCH v2 27/37] Adapt to VIR_ALLOC and virAsprintf in src/uml/*

2013-07-09 Thread Michal Privoznik
--- src/uml/uml_conf.c | 28 +++- src/uml/uml_driver.c | 36 +--- 2 files changed, 16 insertions(+), 48 deletions(-) diff --git a/src/uml/uml_conf.c b/src/uml/uml_conf.c index 38dcfbb..e9d3ddb 100644 --- a/src/uml/uml_conf.c +++

[libvirt] [PATCH v2 25/37] Adapt to VIR_ALLOC and virAsprintf in src/storage/*

2013-07-09 Thread Michal Privoznik
--- src/storage/storage_backend.c | 35 ++--- src/storage/storage_backend_disk.c | 17 +++- src/storage/storage_backend_fs.c | 31 ++ src/storage/storage_backend_iscsi.c| 27 +--

[libvirt] [PATCH v2 37/37] Adapt to VIR_ALLOC and virAsprintf in tools/*

2013-07-09 Thread Michal Privoznik
--- tools/console.c | 6 +- tools/virsh-domain-monitor.c | 4 +--- tools/virsh-domain.c | 28 tools/virsh.c| 1 - 4 files changed, 10 insertions(+), 29 deletions(-) diff --git a/tools/console.c b/tools/console.c index

[libvirt] [PATCH v2 22/37] Adapt to VIR_ALLOC and virAsprintf in src/rpc/*

2013-07-09 Thread Michal Privoznik
--- src/rpc/gendispatch.pl| 8 ++-- src/rpc/virnetclient.c| 26 -- src/rpc/virnetclientprogram.c | 12 +++- src/rpc/virnetclientstream.c | 4 +--- src/rpc/virnetmessage.c | 26 +++--- src/rpc/virnetserver.c|

[libvirt] [PATCH v2 03/37] Adapt to VIR_ALLOC and virAsprintf in docs/

2013-07-09 Thread Michal Privoznik
--- HACKING | 20 +--- docs/hacking.html.in | 20 +--- 2 files changed, 10 insertions(+), 30 deletions(-) diff --git a/HACKING b/HACKING index a310faa..26dc0d0 100644 --- a/HACKING +++ b/HACKING @@ -535,10 +535,8 @@ routines, use the macros from

[libvirt] [PATCH v2 26/37] Adapt to VIR_ALLOC and virAsprintf in src/test/*

2013-07-09 Thread Michal Privoznik
--- src/test/test_driver.c | 91 -- 1 file changed, 28 insertions(+), 63 deletions(-) diff --git a/src/test/test_driver.c b/src/test/test_driver.c index 80a84d5..a5dbdc3 100644 --- a/src/test/test_driver.c +++ b/src/test/test_driver.c @@ -170,18

[libvirt] [PATCH v2 23/37] Adapt to VIR_ALLOC and virAsprintf in src/secret/*

2013-07-09 Thread Michal Privoznik
--- src/secret/secret_driver.c | 55 -- 1 file changed, 14 insertions(+), 41 deletions(-) diff --git a/src/secret/secret_driver.c b/src/secret/secret_driver.c index 71b3fe7..836288c 100644 --- a/src/secret/secret_driver.c +++

[libvirt] [PATCH v2 32/37] Adapt to VIR_ALLOC and virAsprintf in src/xen/*

2013-07-09 Thread Michal Privoznik
--- src/xen/block_stats.c| 8 ++-- src/xen/xen_driver.c | 42 +++--- src/xen/xen_hypervisor.c | 18 ++ src/xen/xen_inotify.c| 4 +--- src/xen/xend_internal.c | 38 ++ src/xen/xm_internal.c

[libvirt] [PATCH v2 13/37] Adapt to VIR_ALLOC and virAsprintf in src/lxc/*

2013-07-09 Thread Michal Privoznik
--- src/lxc/lxc_cgroup.c | 4 +-- src/lxc/lxc_conf.c | 5 +-- src/lxc/lxc_container.c | 77 ++-- src/lxc/lxc_controller.c | 47 ++--- src/lxc/lxc_driver.c | 92

[libvirt] [PATCH v2 36/37] Adapt to VIR_ALLOC and virAsprintf in tests/*

2013-07-09 Thread Michal Privoznik
--- tests/commandhelper.c| 2 +- tests/commandtest.c | 8 ++-- tests/libvirtdconftest.c | 4 +--- tests/qemumonitortestutils.c | 17 + tests/securityselinuxlabeltest.c | 24 ++-- tests/securityselinuxtest.c | 8

[libvirt] [PATCH v2 24/37] Adapt to VIR_ALLOC and virAsprintf in src/security/*

2013-07-09 Thread Michal Privoznik
--- src/security/security_apparmor.c | 25 ++ src/security/security_dac.c | 12 +++ src/security/security_manager.c | 12 +++ src/security/security_selinux.c | 46 src/security/security_stack.c| 8 ++-

[libvirt] [PATCH v2 34/37] Adapt to VIR_ALLOC and virAsprintf in src/xenxs/*

2013-07-09 Thread Michal Privoznik
--- src/xenxs/xen_sxpr.c | 112 src/xenxs/xen_xm.c | 204 ++- 2 files changed, 135 insertions(+), 181 deletions(-) diff --git a/src/xenxs/xen_sxpr.c b/src/xenxs/xen_sxpr.c index 394b814..13f9f32 100644 ---

[libvirt] [PATCH v2 15/37] Adapt to VIR_ALLOC and virAsprintf in src/network/*

2013-07-09 Thread Michal Privoznik
--- src/network/bridge_driver.c | 138 +--- 1 file changed, 40 insertions(+), 98 deletions(-) diff --git a/src/network/bridge_driver.c b/src/network/bridge_driver.c index d7e90ac..6fae832 100644 --- a/src/network/bridge_driver.c +++

[libvirt] [PATCH v2 18/37] Adapt to VIR_ALLOC and virAsprintf in src/parallels/*

2013-07-09 Thread Michal Privoznik
--- src/nodeinfo.c| 3 +- src/parallels/parallels_driver.c | 65 +++ src/parallels/parallels_network.c | 24 --- src/parallels/parallels_storage.c | 50 +- src/parallels/parallels_utils.c | 4 +--

[libvirt] [PATCH v2 14/37] Adapt to VIR_ALLOC and virAsprintf in src/node_device/*

2013-07-09 Thread Michal Privoznik
--- src/node_device/node_device_driver.c | 4 +--- src/node_device/node_device_udev.c | 18 -- 2 files changed, 5 insertions(+), 17 deletions(-) diff --git a/src/node_device/node_device_driver.c b/src/node_device/node_device_driver.c index 1f7e0fd..bbad113 100644 ---

[libvirt] [PATCH v2 05/37] Adapt to VIR_ALLOC and virAsprintf in src/access/*

2013-07-09 Thread Michal Privoznik
--- src/access/viraccessdriverpolkit.c | 4 +--- src/access/viraccessdriverstack.c | 4 +--- src/access/viraccessmanager.c | 4 +--- 3 files changed, 3 insertions(+), 9 deletions(-) diff --git a/src/access/viraccessdriverpolkit.c b/src/access/viraccessdriverpolkit.c index 6e503ba..4c76e64

[libvirt] [PATCH v2 31/37] Adapt to VIR_ALLOC and virAsprintf in src/vmx/*

2013-07-09 Thread Michal Privoznik
--- src/vmx/vmx.c | 88 +++ 1 file changed, 22 insertions(+), 66 deletions(-) diff --git a/src/vmx/vmx.c b/src/vmx/vmx.c index 5464d13..9b08914 100644 --- a/src/vmx/vmx.c +++ b/src/vmx/vmx.c @@ -553,10 +553,8 @@ virVMXEscapeHex(const char

[libvirt] [PATCH v2 04/37] Adapt to VIR_ALLOC and virAsprintf in daemon/*

2013-07-09 Thread Michal Privoznik
--- daemon/libvirtd-config.c | 12 +-- daemon/libvirtd.c| 24 ++--- daemon/remote.c | 234 --- daemon/stream.c | 4 +- 4 files changed, 70 insertions(+), 204 deletions(-) diff --git a/daemon/libvirtd-config.c

[libvirt] [PATCH v2 33/37] Adapt to VIR_ALLOC and virAsprintf in src/xenapi/*

2013-07-09 Thread Michal Privoznik
--- src/xenapi/xenapi_driver.c | 20 +--- src/xenapi/xenapi_utils.c | 13 + 2 files changed, 10 insertions(+), 23 deletions(-) diff --git a/src/xenapi/xenapi_driver.c b/src/xenapi/xenapi_driver.c index cc8da49..20753b7 100644 --- a/src/xenapi/xenapi_driver.c +++

[libvirt] [PATCH v2 19/37] Adapt to VIR_ALLOC and virAsprintf in src/phyp/*

2013-07-09 Thread Michal Privoznik
--- src/phyp/phyp_driver.c | 95 +- 1 file changed, 24 insertions(+), 71 deletions(-) diff --git a/src/phyp/phyp_driver.c b/src/phyp/phyp_driver.c index cae3b59..c515f3e 100644 --- a/src/phyp/phyp_driver.c +++ b/src/phyp/phyp_driver.c @@ -110,10

[libvirt] [PATCH v2 21/37] Adapt to VIR_ALLOC and virAsprintf in src/remote/*

2013-07-09 Thread Michal Privoznik
--- src/remote/remote_driver.c | 107 - 1 file changed, 27 insertions(+), 80 deletions(-) diff --git a/src/remote/remote_driver.c b/src/remote/remote_driver.c index 7f3e833..c2f1132 100644 --- a/src/remote/remote_driver.c +++

[libvirt] [PATCH v2 17/37] Adapt to VIR_ALLOC and virAsprintf in src/openvz/*

2013-07-09 Thread Michal Privoznik
--- src/openvz/openvz_conf.c | 42 -- src/openvz/openvz_driver.c | 10 +++--- 2 files changed, 19 insertions(+), 33 deletions(-) diff --git a/src/openvz/openvz_conf.c b/src/openvz/openvz_conf.c index 90b4483..93f2377 100644 ---

[libvirt] [PATCH v2 35/37] Adapt to VIR_ALLOC and virAsprintf in src/*

2013-07-09 Thread Michal Privoznik
--- src/fdstream.c | 4 +--- src/libvirt.c | 21 ++--- src/nodeinfo.c | 58 ++ 3 files changed, 21 insertions(+), 62 deletions(-) diff --git a/src/fdstream.c b/src/fdstream.c index d5e5aaf..30f1729 100644 ---

[libvirt] [PATCH v2 12/37] Adapt to VIR_ALLOC and virAsprintf in src/locking/*

2013-07-09 Thread Michal Privoznik
--- src/locking/lock_daemon.c | 33 + src/locking/lock_daemon_config.c | 8 ++-- src/locking/lock_driver_lockd.c | 23 ++- src/locking/lock_driver_sanlock.c | 28 +++- src/locking/lock_manager.c|

[libvirt] [PATCH v2 29/37] Adapt to VIR_ALLOC and virAsprintf in src/vbox/*

2013-07-09 Thread Michal Privoznik
--- src/vbox/vbox_MSCOMGlue.c | 8 +-- src/vbox/vbox_XPCOMCGlue.c | 4 +- src/vbox/vbox_tmpl.c | 126 +++-- 3 files changed, 32 insertions(+), 106 deletions(-) diff --git a/src/vbox/vbox_MSCOMGlue.c b/src/vbox/vbox_MSCOMGlue.c index

[libvirt] [PATCH v2 02/37] Introduce OOM reporting to virAsprintf

2013-07-09 Thread Michal Privoznik
Actually, I'm turning this function into a macro as filename, function name and line number needs to be passed. The new function virAsprintfInternal is introduced with the extended set of arguments. --- cfg.mk| 2 +- src/conf/domain_audit.c | 36

[libvirt] [PATCH v2 16/37] Adapt to VIR_ALLOC and virAsprintf in src/nwfilter/*

2013-07-09 Thread Michal Privoznik
--- src/nwfilter/nwfilter_dhcpsnoop.c | 29 +-- src/nwfilter/nwfilter_driver.c| 13 ++--- src/nwfilter/nwfilter_ebiptables_driver.c | 46 ++- src/nwfilter/nwfilter_gentech_driver.c| 24

[libvirt] [PATCH v2 11/37] Adapt to VIR_ALLOC and virAsprintf in src/libxl/*

2013-07-09 Thread Michal Privoznik
--- src/libxl/libxl_conf.c | 18 +- src/libxl/libxl_driver.c | 49 2 files changed, 17 insertions(+), 50 deletions(-) diff --git a/src/libxl/libxl_conf.c b/src/libxl/libxl_conf.c index e170357..1b27b6f 100644 ---

[libvirt] [PATCH v2 10/37] Adapt to VIR_ALLOC and virAsprintf in src/interface/*

2013-07-09 Thread Michal Privoznik
--- src/interface/interface_backend_netcf.c | 27 ++- src/interface/interface_backend_udev.c | 33 + 2 files changed, 15 insertions(+), 45 deletions(-) diff --git a/src/interface/interface_backend_netcf.c

Re: [libvirt] libvirt: xen error

2013-07-09 Thread Eric Blake
[dropping libvirt-users, as this appears to be a development question] On 06/16/2013 10:39 AM, varun bhatnagar wrote: Hi, I am trying to install xen and provide libvrit support to it but while installing at some point of time it tries to connect to GIT repository and creates a clone but I

Re: [libvirt] Load Test leads to Libvirt crash

2013-07-09 Thread Eric Blake
On 06/13/2013 10:42 AM, SHREE DUTH AWASTHI wrote: Hi All, Can you please help us in solving this issue. Version used : libvirt-0.10.2 Note: We could reproduce the same crash using the latest libvirt version 1.0.5 1.0.5 is not the latest version. Can you please retest with 1.1.0 or

Re: [libvirt] [PATCH] LXC: Ensure security context is set when mounting images

2013-07-09 Thread Eric Blake
On 07/09/2013 08:55 AM, Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com When setting up filesystems backed by block devices or file images, the SELinux mount options must be used to ensure the correct context is set Signed-off-by: Daniel P. Berrange

Re: [libvirt] [PATCH] daemon: Fix command example in libvirtd.sasl

2013-07-09 Thread Eric Blake
On 07/09/2013 08:02 AM, Cole Robinson wrote: sasldblistusers2 doesn't have a '-a' option --- daemon/libvirtd.sasl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) ACK. diff --git a/daemon/libvirtd.sasl b/daemon/libvirtd.sasl index bfa056f..5e2528d 100644 --- a/daemon/libvirtd.sasl

[libvirt] [PATCH] RFC: Introduce new domain create APIs to pass pre-opened FDs to LXC

2013-07-09 Thread Daniel P. Berrange
From: Daniel P. Berrange berra...@redhat.com With container based virt, it is useful to be able to pass pre-opened file descriptors to the container init process. This allows for containers to be auto-activated from incoming socket connections, passing the active socket into the container. To do

Re: [libvirt] [PATCH] daemon: Fix command example in libvirtd.sasl

2013-07-09 Thread Cole Robinson
On 07/09/2013 12:09 PM, Eric Blake wrote: On 07/09/2013 08:02 AM, Cole Robinson wrote: sasldblistusers2 doesn't have a '-a' option --- daemon/libvirtd.sasl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) ACK. Thanks, pushed. - Cole -- libvir-list mailing list

Re: [libvirt] [PATCH glib] Add support for reading/writing UUID attribute in domain config

2013-07-09 Thread Michal Privoznik
On 09.07.2013 16:14, Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com Signed-off-by: Daniel P. Berrange berra...@redhat.com --- libvirt-gconfig/libvirt-gconfig-domain.c | 33 libvirt-gconfig/libvirt-gconfig-domain.h | 2 ++ 2 files

[libvirt] [PATCH] maint: fix typo in qemu error message

2013-07-09 Thread Eric Blake
Introduced in commit d47eff88. * src/qemu/qemu_driver.c (qemuDomainSetVcpusFlags): Fix spelling. Signed-off-by: Eric Blake ebl...@redhat.com --- Pushed under the trivial rule. src/qemu/qemu_driver.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/qemu/qemu_driver.c

Re: [libvirt] [PATCH 01/32] Convert 'int i' to 'size_t i' in daemon/ files

2013-07-09 Thread Laine Stump
On 07/08/2013 10:21 AM, Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com Convert the type of loop iterators named 'i', 'j', k', 'ii', 'jj', 'kk', to be 'size_t' instead of 'int' or 'unsigned int', also santizing 'ii', 'jj', 'kk' to use the normal 'i', 'j', 'k' naming

Re: [libvirt] [PATCH] qemu: Slightly increase memory limit

2013-07-09 Thread Laine Stump
On 07/08/2013 09:20 AM, Jiri Denemark wrote: For low-memory domains (roughly under 400MB) our automatic memory limit computation comes up with a limit that's too low. This is because the 0.5 multiplication does not add enough for such small values. Let's increase the constant part of the

[libvirt] ANNOUNCE: libvirt-sandbox Owami Desert release 0.2.1

2013-07-09 Thread Daniel P. Berrange
I pleased to announce the a new public release of libvirt-sandbox, version 0.2.1, is now available for download ftp://libvirt.org/libvirt/sandbox/ The packages are GPG signed with Key fingerprint: DAF3 A6FD B26B 6291 2D0E 8E3F BE86 EBB4 1510 4FDF (4096R) The libvirt-sandbox package

[libvirt] [PATCH v2 0/7] Support CHAP authentication for iscsi pool

2013-07-09 Thread John Ferlan
https://bugzilla.redhat.com/show_bug.cgi?id=957294 Since Osier is out temporarily, I was asked to pick up this work since I initially reviewed the changes. Originally posted by Osier as: https://www.redhat.com/archives/libvir-list/2013-May/msg01879.html I reviewed the changes and had comments

[libvirt] [PATCH v2 7/7] storage: Improve the pool auth type parsing and formatting

2013-07-09 Thread John Ferlan
From: Osier Yang jy...@redhat.com Use the helpers Type{From,To}String instead. --- src/conf/storage_conf.c | 17 ++--- src/conf/storage_conf.h | 3 +++ 2 files changed, 13 insertions(+), 7 deletions(-) diff --git a/src/conf/storage_conf.c b/src/conf/storage_conf.c index

[libvirt] [PATCH v2 1/7] storage: Refactor the rng schema for storage pool auth

2013-07-09 Thread John Ferlan
From: Osier Yang jy...@redhat.com The attributes/elements for auth type chap and ceph are completely different, but the schema didn't reflect that. This patch separates each of the definitions into groups. Changed chap type login and passwd attributes to be be interleaved. Also adjusted the

[libvirt] [PATCH v2 5/7] storage: Output auth type before username

2013-07-09 Thread John Ferlan
From: Osier Yang jy...@redhat.com Change the order of output to print the 'type' first in the XML --- src/conf/storage_conf.c | 2 +- tests/storagepoolxml2xmlout/pool-rbd.xml | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/conf/storage_conf.c

[libvirt] [PATCH v2 3/7] storage: Add a struct for auth secret

2013-07-09 Thread John Ferlan
From: Osier Yang jy...@redhat.com Create _virStoragePoolAuthSecret for the _virStoragePoolAuthCephx to abstract parsing the XML secret object. --- src/conf/storage_conf.c | 68 - src/conf/storage_conf.h | 14 ++ 2 files changed, 48

[libvirt] [PATCH v2 4/7] storage: Introduce XMLs to use secret object for pool auth

2013-07-09 Thread John Ferlan
Allow using a secret object type for 'chap' authentication attributes. Using plain password is still supported for back-compat reason. Introduce virStoragePoolAuthChapType enum to allow either plain password or chap secret as options keeping the plain text as the first option, even though it's

[libvirt] [PATCH v2 6/7] storage: Support chap authentication for iscsi pool

2013-07-09 Thread John Ferlan
From: Osier Yang jy...@redhat.com Although the XML for chap authentication with plain password was introduced long ago, the function was never implemented. This patch completes it by performing the authentication during findPoolSources() processing of pools with an authType of

[libvirt] [PATCH v2 2/7] storage: Support username for chap type auth

2013-07-09 Thread John Ferlan
To be consistent with ceph types for storage auth elements, allow username to be used as an auth attribute name for chap types. Continue to allow login for backwards compatibility when reading the XML, but when writing the XML use username. --- docs/schemas/storagepool.rng |

Re: [libvirt] [PATCH v2 1/3] libxl: implement NUMA capabilities reporting

2013-07-09 Thread Jim Fehlig
Dario Faggioli wrote: On lun, 2013-07-08 at 18:45 -0600, Jim Fehlig wrote: Dario Faggioli wrote: diff --git a/src/libxl/libxl_conf.c b/src/libxl/libxl_conf.c index e170357..7515995 100644 --- a/src/libxl/libxl_conf.c +++ b/src/libxl/libxl_conf.c @@ -161,6 +161,115 @@

  1   2   >