On 07/23/2013 12:20 AM, Eric Blake wrote:
On 07/22/2013 01:40 AM, Guannan Ren wrote:
Resolves:https://bugzilla.redhat.com/show_bug.cgi?id=923053
When cdrom is block type, the virsh change-media failed to insert
source info because virsh uses source block='/dev/sdb'/ while
the correct name of
On 07/22/2013 06:31 PM, Eric Blake wrote:
On 07/22/2013 07:58 AM, Daniel P. Berrange wrote:
I'm really inclined to say that anyone wanting todo lock debugging
should just use systemtap / dtrace todo it, since it is better in
every way.
I tend to agree on that point, with one caveat - we
On 22.07.2013 21:39, Konrad Rzeszutek Wilk wrote:
On Mon, Jul 22, 2013 at 12:51:05PM +0200, Stefan Bader wrote:
This fixes the basic setup but there is likely more to do if things
like manual CPU hirarchy (nodes, cores, threads) to be working.
Cross-posting to xen-devel to make sure I am
On Mon, Jul 22, 2013 at 02:32:49PM -0400, Roman Bogorodskiy wrote:
Commit 834c9c94 introduced virDBusMessageEncode and
virDBusMessageDecode functions, however corresponding stubs
were not added to !WITH_DBUS section, therefore 'make check'
started to fail when compiled w/out dbus support like
On Mon, Jul 22, 2013 at 02:14:22PM -0400, Roman Bogorodskiy wrote:
Continue preparation for extracting platform-specific
parts from bridge_driver: s/Iptables/Firewall/ for
firewall related function names.
---
src/network/bridge_driver.c | 70
++---
On Fri, Jul 19, 2013 at 02:12:06AM +, Wangyufei (A) wrote:
When I shutdown a vm, I found sockets which act as UNIX domain socket server
were not deleted. When I add the following code, it work out.
Signed-off-by: WangYufei
james.wangyu...@huawei.commailto:james.wangyu...@huawei.com
On Tue, Jul 23, 2013 at 08:34:35AM +0200, Martin Kletzander wrote:
On 07/22/2013 06:31 PM, Eric Blake wrote:
On 07/22/2013 07:58 AM, Daniel P. Berrange wrote:
I'm really inclined to say that anyone wanting todo lock debugging
should just use systemtap / dtrace todo it, since it is better in
On Tue, Jul 23, 2013 at 10:44:48 +0800, Peter Huang(Peng) wrote:
libvirt's host-passthrough uses -cpu host', and it -cpu host
enables every feature that can be enabled on the host.
From my test results, I found that even when use host-passthrough mode, VM's
cpu features are very different
On 07/23/2013 12:15 PM, Daniel P. Berrange wrote:
On Mon, Jul 22, 2013 at 02:14:22PM -0400, Roman Bogorodskiy wrote:
Continue preparation for extracting platform-specific
parts from bridge_driver: s/Iptables/Firewall/ for
firewall related function names.
---
src/network/bridge_driver.c | 70
On 07/23/2013 12:15 PM, Daniel P. Berrange wrote:
On Mon, Jul 22, 2013 at 02:32:49PM -0400, Roman Bogorodskiy wrote:
Commit 834c9c94 introduced virDBusMessageEncode and
virDBusMessageDecode functions, however corresponding stubs
were not added to !WITH_DBUS section, therefore 'make check'
libvirt's host-passthrough uses -cpu host', and it -cpu host
enables every feature that can be enabled on the host.
From my test results, I found that even when use host-passthrough mode, VM's
cpu features are very different from host, this doesn't match what
host-passthrough
mode's
Il 19/07/2013 14:32, John Ferlan ha scritto:
There are two ways to use a iSCSI LUN as disk source for qemu.
* The LUN's path as it shows up on host, e.g.
/dev/disk/by-path/ip-$ip:3260-iscsi-$iqn-fc18:iscsi.iscsi0-lun-1
* The libiscsi URI from the storage pool source element host
Il 22/07/2013 12:30, Osier Yang ha scritto:
+def-srcpool-pooltype = pooldef-type;
+if (pooldef-type == VIR_STORAGE_POOL_ISCSI) {
+/* Default to use the LUN's path on host */
+if (!def-srcpool-mode)
+def-srcpool-mode =
On Tue, Jul 23, 2013 at 03:22:54PM +0200, Paolo Bonzini wrote:
Il 22/07/2013 12:30, Osier Yang ha scritto:
+def-srcpool-pooltype = pooldef-type;
+if (pooldef-type == VIR_STORAGE_POOL_ISCSI) {
+/* Default to use the LUN's path on host */
+if
Il 22/07/2013 22:31, John Ferlan ha scritto:
Although the XML for CHAP authentication with plain password
was introduced long ago, the function was never implemented. This
patch replaces the login/password mechanism by following the
'ceph' (or RBD) model of using a 'username' with a 'secret'
Il 23/07/2013 15:26, Daniel P. Berrange ha scritto:
Ok, this answers my question. :)
I think the default mode should be direct, because otherwise things such
as persistent reservations do not work.
No, the default has to be host mode, because that is the only mode that
is guaranteed
On Tue, Jul 23, 2013 at 03:29:40PM +0200, Paolo Bonzini wrote:
Il 23/07/2013 15:26, Daniel P. Berrange ha scritto:
Ok, this answers my question. :)
I think the default mode should be direct, because otherwise things such
as persistent reservations do not work.
No, the default
util/virdbuspriv.h needed to be added to UTIL_SOURCES in the makefile.
---
Pushed under build breaker rule.
src/Makefile.am | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/Makefile.am b/src/Makefile.am
index 0eb3cb5..84372cb 100644
--- a/src/Makefile.am
+++
From: Daniel P. Berrange berra...@redhat.com
Current code for handling dbus errors only works for errors
received from the remote application itself. We must also
handle errors emitted by the bus itself, for example, when
it fails to spawn the target service.
Signed-off-by: Daniel P. Berrange
From: Daniel P. Berrange berra...@redhat.com
If systemd machine does not exist, return -2 instead of -1,
so that applications don't need to repeat the tedious error
checking code
Signed-off-by: Daniel P. Berrange berra...@redhat.com
---
src/util/virsystemd.c | 13 ++-
Il 23/07/2013 15:36, Daniel P. Berrange ha scritto:
On Tue, Jul 23, 2013 at 03:29:40PM +0200, Paolo Bonzini wrote:
Il 23/07/2013 15:26, Daniel P. Berrange ha scritto:
Ok, this answers my question. :)
I think the default mode should be direct, because otherwise things such
as persistent
On Tue, Jul 23, 2013 at 03:52:56PM +0200, Paolo Bonzini wrote:
Il 23/07/2013 15:36, Daniel P. Berrange ha scritto:
On Tue, Jul 23, 2013 at 03:29:40PM +0200, Paolo Bonzini wrote:
Il 23/07/2013 15:26, Daniel P. Berrange ha scritto:
Ok, this answers my question. :)
I think the default
On 07/22/2013 10:31 PM, John Ferlan wrote:
During qemuTranslateDiskSourcePool() execution, if the srcpool has been
defined with authentication information, then for iSCSI pools copy the
authentication and host information to virDomainDiskDef.
---
src/qemu/qemu_conf.c | 55
On 07/22/2013 10:31 PM, John Ferlan wrote:
Split out into its own separate routine
---
src/qemu/qemu_command.c | 108
1 file changed, 64 insertions(+), 44 deletions(-)
ACK, just code movement.
Jan
--
libvir-list mailing list
On 07/22/2013 10:31 PM, John Ferlan wrote:
Make the secret fetching code common for qemuBuildRBDString() and
qemuBuildDriveURIString() using the virDomainDiskDef.
---
src/qemu/qemu_command.c | 157
+---
1 file changed, 81 insertions(+), 76
On 07/22/2013 10:31 PM, John Ferlan wrote:
---
src/storage/storage_backend_iscsi.c | 111
+++-
1 file changed, 110 insertions(+), 1 deletion(-)
I can confirm this works, but it's a shame it doesn't work on autostart.
ACK if you clarify the error.
Jan
--
On 07/22/2013 10:31 PM, John Ferlan wrote:
Update virStorageBackendRBDOpenRADOSConn() to use the internal API to the
secret driver in order to get the secret value instead of the external
virSecretGetValue() path. Without the flag VIR_SECRET_GET_VALUE_INTERNAL_CALL
there is no way to get the
Due to a goto statement missed when refactoring in 2771f8b74c1bf50d1fa
when acquiring of a domain job failed the error path was not taken. This
resulted into a crash afterwards as a extra reference was removed from a
domain object leading to it being freed. An attempt to list the domains
On Tue, Jul 23, 2013 at 16:21:10 +0200, Peter Krempa wrote:
Due to a goto statement missed when refactoring in 2771f8b74c1bf50d1fa
when acquiring of a domain job failed the error path was not taken. This
resulted into a crash afterwards as a extra reference was removed from a
s/as a/as an/
On 07/23/13 16:26, Jiri Denemark wrote:
On Tue, Jul 23, 2013 at 16:21:10 +0200, Peter Krempa wrote:
Due to a goto statement missed when refactoring in 2771f8b74c1bf50d1fa
when acquiring of a domain job failed the error path was not taken. This
resulted into a crash afterwards as a extra
Although these two enums are named ..._LAST, they really had the value
of ..._SIZE. This patch changes their values so that, e.g.,
QEMU_PCI_ADDRESS_SLOT_LAST really is the slot number of the last slot
on a PCI bus.
---
src/qemu/qemu_command.c | 18 +-
1 file changed, 9
qemuDomainPCIAddressBus was an array of QEMU_PCI_ADDRESS_SLOT_LAST
uint8_t's, which worked fine as long as every PCI bus was
identical. In the future, some PCI busses will allow connecting PCI
devices, and some will allow PCIe devices; also some will only allow
connection of a single device, while
This is *almost* usable. I still need to add support for a
dmi-to-pci-bridge before the q35 machine type can be used.
1/5 and 3/5 are just cleaning up some things that bothered me while
writing patch 4/5.
2/5 should help out other machine types (e.g. arm)
just a bit, by eliminating the extra
This controller is implicit on q35 machinetypes. It provides 31 PCIe
(*not* PCI) slots as controller 0.
Currently there are no devices that can connect to pcie-root. For a
usable q35 system, we still need to add a dmi-to-pci-bridge pci
controller, which can connect to pcie-root, and provides pci
On 07/23/2013 10:18 AM, Ján Tomko wrote:
On 07/22/2013 10:31 PM, John Ferlan wrote:
---
src/storage/storage_backend_iscsi.c | 111
+++-
1 file changed, 110 insertions(+), 1 deletion(-)
I can confirm this works, but it's a shame it doesn't work on
Since PCI bridges, PCIe bridges, PCIe switches, and PCIe root ports
all share the same namespace, they are all defined as controllers of
type='pci' in libvirt (but with a differing model attribute). Each of
these controllers has a certain connection type upstream, allows
certain connection types
We have received numerous requests to extend the CFP deadline and so
we are happy to announce that the CFP deadline has been moved by two
weeks to August 4th.
=
KVM Forum 2013: Call For Participation
October 21-23, 2013 - Edinburgh
On Tue, Jul 23, 2013 at 10:47:46AM -0400, John Ferlan wrote:
On 07/23/2013 10:18 AM, Ján Tomko wrote:
On 07/22/2013 10:31 PM, John Ferlan wrote:
---
src/storage/storage_backend_iscsi.c | 111
+++-
1 file changed, 110 insertions(+), 1 deletion(-)
On 07/22/2013 04:31 PM, John Ferlan wrote:
This is a reworking and reposting of the authentication patches originally
posted as part of my v3 reworking of Osier's original patches, see:
...snip...
John Ferlan (5):
qemu: Add source pool auth info to virDomainDiskDef for iSCSI
qemu: Create
https://bugzilla.redhat.com/show_bug.cgi?id=964358
Since neither getpwuid_r() nor initgroups() are safe to call in
between fork and exec (they obtain a mutex, but if some other
thread in the parent also held the mutex at the time of the fork,
the child will deadlock), we have to split out the
https://bugzilla.redhat.com/show_bug.cgi?id=964358
A future patch wants the DAC security manager to be able to safely
get the supplemental group list for a given uid, but at the time
of a fork rather than during initialization so as to pick up on
live changes to the system's group database. This
https://bugzilla.redhat.com/show_bug.cgi?id=964358
A future patch needs to look up pw_gid; but it is wasteful
to crawl through getpwuid_r twice for two separate pieces
of information, and annoying to copy that much boilerplate
code for doing the crawl. The current internal-only
virGetUserEnt is
From: Daniel P. Berrange berra...@redhat.com
https://bugzilla.redhat.com/show_bug.cgi?id=964358
The hook scripts used by virCommand must be careful wrt
accessing any mutexes that may have been held by other
threads in the parent process. With the recent refactoring
there are 2 potential flaws
https://bugzilla.redhat.com/show_bug.cgi?id=964358
POSIX states that multi-threaded apps should not use functions
that are not async-signal-safe between fork and exec, yet we
were using getpwuid_r and initgroups. Although rare, it is
possible to hit deadlock in the child, when it tries to grab
a
https://bugzilla.redhat.com/show_bug.cgi?id=964358
Attempts to start a domain with both SELinux and DAC security
modules loaded will deadlock; latent problem introduced in commit
fdb3bde and exposed in commit 29fe5d7. Basically, when recursing
into the security manager for other driver's
https://bugzilla.redhat.com/show_bug.cgi?id=964358
Since it was on Fedora 18 that I first noticed the deadlock possible
when a child process calls getpwuid_r while the parent owned the
lock in a different thread, I'm interested in backporting my recent
work on virGetGroupList to v0.10.2-maint.
Il 23/07/2013 16:14, Daniel P. Berrange ha scritto:
On Tue, Jul 23, 2013 at 03:52:56PM +0200, Paolo Bonzini wrote:
Il 23/07/2013 15:36, Daniel P. Berrange ha scritto:
On Tue, Jul 23, 2013 at 03:29:40PM +0200, Paolo Bonzini wrote:
Il 23/07/2013 15:26, Daniel P. Berrange ha scritto:
Ok, this
On Tue, Jul 23, 2013 at 10:44:55AM -0400, Laine Stump wrote:
This controller is implicit on q35 machinetypes. It provides 31 PCIe
(*not* PCI) slots as controller 0.
Currently there are no devices that can connect to pcie-root. For a
usable q35 system, we still need to add a dmi-to-pci-bridge
From: Daniel P. Berrange berra...@redhat.com
Currently the LXC driver creates the VM's cgroup prior to
forking, and then libvirt_lxc moves the child process
into the cgroup. This won't work with systemd whose APIs
do the creation of cgroups + attachment of processes atomically.
Fortunately we
From: Daniel P. Berrange berra...@redhat.com
Current code for handling dbus errors only works for errors
received from the remote application itself. We must also
handle errors emitted by the bus itself, for example, when
it fails to spawn the target service.
Signed-off-by: Daniel P. Berrange
On Tue, Jul 23, 2013 at 10:44:51AM -0400, Laine Stump wrote:
qemuDomainPCIAddressBus was an array of QEMU_PCI_ADDRESS_SLOT_LAST
uint8_t's, which worked fine as long as every PCI bus was
identical. In the future, some PCI busses will allow connecting PCI
devices, and some will allow PCIe
From: Daniel P. Berrange berra...@redhat.com
Add a virCgroupNewDetect API which is used to initialize a
cgroup object with the placement of an arbitrary process.
Signed-off-by: Daniel P. Berrange berra...@redhat.com
---
src/libvirt_private.syms | 1 +
src/util/vircgroup.c | 81
From: Daniel P. Berrange berra...@redhat.com
This is a patch series which adds support for using systemd-machined
for creating cgroups. The first 12 patches are all really just cleanups
and refactoring. The actual systemd code is the last patch, but at time
of posting it doesn't quite work
From: Daniel P. Berrange berra...@redhat.com
Instead of requiring one API call to create a cgroup and
another to add a task to it, introduce a new API
virCgroupNewMachine which does both jobs at once. This
will facilitate the later code to talk to systemd to
achieve this job which is also atomic.
From: Daniel P. Berrange berra...@redhat.com
Add protection such that the virCgroupRemove and
virCgroupKill* do not do anything to the root cgroup.
Killing all PIDs in the root cgroup does not end well.
Signed-off-by: Daniel P. Berrange berra...@redhat.com
---
src/util/vircgroup.c | 12
From: Daniel P. Berrange berra...@redhat.com
If systemd machine does not exist, return -2 instead of -1,
so that applications don't need to repeat the tedious error
checking code
Signed-off-by: Daniel P. Berrange berra...@redhat.com
---
src/util/virsystemd.c | 13 ++-
From: Daniel P. Berrange berra...@redhat.com
Convert the QEMU driver code to use the new atomic API
for setup of cgroups
Signed-off-by: Daniel P. Berrange berra...@redhat.com
---
src/qemu/qemu_cgroup.c | 29 +++--
1 file changed, 11 insertions(+), 18 deletions(-)
diff
From: Daniel P. Berrange berra...@redhat.com
Use the new virCgroupNewDetect function to determine cgroup
placement of existing running VMs. This will allow the legacy
cgroups creation APIs to be removed entirely
Signed-off-by: Daniel P. Berrange berra...@redhat.com
---
src/lxc/lxc_cgroup.c|
From: Daniel P. Berrange berra...@redhat.com
Add virCgroupIsValidMachine API to check whether a auto
detected cgroup is valid for a machine. This lets us
check if a VM has just been placed into some generic
shared cgroup, or worse, the root cgroup
Signed-off-by: Daniel P. Berrange
From: Daniel P. Berrange berra...@redhat.com
Currently the QEMU driver creates the VM's cgroup prior to
forking, and then uses a virCommand hook to move the child
into the cgroup. This won't work with systemd whose APIs
do the creation of cgroups + attachment of processes atomically.
Fortunately
From: Daniel P. Berrange berra...@redhat.com
Convert the LXC driver code to use the new atomic API
for setup of cgroups
Signed-off-by: Daniel P. Berrange berra...@redhat.com
---
src/lxc/lxc_cgroup.c | 53 +++-
src/lxc/lxc_controller.c | 2 +-
2
From: Daniel P. Berrange berra...@redhat.com
Make the virCgroupNewMachine method try to use systemd-machined
first. If that fails, then fallback to using the traditional
cgroup setup code path.
Signed-off-by: Daniel P. Berrange berra...@redhat.com
---
src/util/vircgroup.c | 115
On Tue, Jul 23, 2013 at 10:44:52AM -0400, Laine Stump wrote:
The implicit IDE, USB, and video controllers provided by the PIIX3
chipset in the pc-* machinetypes are not present on other
machinetypes, so we shouldn't be doing the special checking for them.
The diffs for this patch look hairy,
On Tue, Jul 23, 2013 at 10:44:53AM -0400, Laine Stump wrote:
Although these two enums are named ..._LAST, they really had the value
of ..._SIZE. This patch changes their values so that, e.g.,
QEMU_PCI_ADDRESS_SLOT_LAST really is the slot number of the last slot
on a PCI bus.
---
From: Daniel P. Berrange berra...@redhat.com
The virCgroupNewDomainDriver and virCgroupNewDriver methods
are obsolete now that we can auto-detect existing cgroup
placement. Delete them to reduce code bloat.
Signed-off-by: Daniel P. Berrange berra...@redhat.com
---
src/libvirt_private.syms | 2
On Tue, Jul 23, 2013 at 10:44:54AM -0400, Laine Stump wrote:
diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c
index 059aa6a..64787b6 100644
--- a/src/qemu/qemu_command.c
+++ b/src/qemu/qemu_command.c
@@ -1412,7 +1412,15 @@ cleanup:
#define QEMU_PCI_ADDRESS_FUNCTION_LAST 7
On Tue, Jul 23, 2013 at 10:44:55AM -0400, Laine Stump wrote:
This controller is implicit on q35 machinetypes. It provides 31 PCIe
(*not* PCI) slots as controller 0.
Currently there are no devices that can connect to pcie-root. For a
usable q35 system, we still need to add a dmi-to-pci-bridge
Il 23/07/2013 16:14, Daniel P. Berrange ha scritto:
Perhaps the default could be specified in a configuration file (and the
default should be the safe one).
No, that is even worse because now the default is not predictable..
We simply default to host mode and if applications want to use
On 07/23/2013 10:56 AM, Daniel P. Berrange wrote:
...snip...
+++ b/src/storage/storage_backend_iscsi.c
@@ -714,7 +714,8 @@ virStorageBackendISCSISetAuth(const char *portal,
if (!conn) {
virReportError(VIR_ERR_INTERNAL_ERROR, %s,
- _(iscsi 'chap'
Commit id '4421e257' strdup'd devAlias, but didn't free
Running qemuhotplugtest under valgrind resulted in the following:
==7375== 9 bytes in 1 blocks are definitely lost in loss record 11 of 70
==7375==at 0x4A0887C: malloc (vg_replace_malloc.c:270)
==7375==by 0x37C1085D71: strdup
Commit 'c8695053' resulted in the following:
Coverity error seen in the output:
ERROR: REVERSE_INULL
FUNCTION: lxcProcessAutoDestroy
Due to the 'dom' being checked before 'dom-persistent' since 'dom'
is already dereferenced prior to that.
---
src/lxc/lxc_process.c | 2 +-
1 file
These patches resolve a Coverity warning and a found Valgrind leak.
Added more patterns to the .valgrind.supp file to suppress the commandtests
and seclabeltest output. This will thus result in a mostly clean valgrind
run. All that remains is a hotplugtest failure, which some patches were posted:
On Tue, Jul 23, 2013 at 05:35:57PM +0200, Paolo Bonzini wrote:
Il 23/07/2013 16:14, Daniel P. Berrange ha scritto:
Perhaps the default could be specified in a configuration file (and the
default should be the safe one).
No, that is even worse because now the default is not predictable..
On 07/23/13 17:59, John Ferlan wrote:
Commit id '4421e257' strdup'd devAlias, but didn't free
Running qemuhotplugtest under valgrind resulted in the following:
==7375== 9 bytes in 1 blocks are definitely lost in loss record 11 of 70
==7375==at 0x4A0887C: malloc (vg_replace_malloc.c:270)
On Tue, Jul 23, 2013 at 11:50:57AM -0400, John Ferlan wrote:
On 07/23/2013 10:56 AM, Daniel P. Berrange wrote:
...snip...
+++ b/src/storage/storage_backend_iscsi.c
@@ -714,7 +714,8 @@ virStorageBackendISCSISetAuth(const char *portal,
if (!conn) {
On 07/23/13 17:59, John Ferlan wrote:
Commit 'c8695053' resulted in the following:
Coverity error seen in the output:
ERROR: REVERSE_INULL
FUNCTION: lxcProcessAutoDestroy
Due to the 'dom' being checked before 'dom-persistent' since 'dom'
is already dereferenced prior to that.
---
Since QEMU and kvm may filter some host CPU features or add efficiently
emulated features, asking QEMU binary for host CPU data provides
better results when we later use the data for building guest CPUs.
Jiri Denemark (7):
cpu: Add support for loading and storing CPU data
cpu: Export few
Since QEMU and kvm may filter some host CPU features or add efficiently
emulated features, asking QEMU binary for host CPU data provides
better results when we later use the data for building guest CPUs.
---
src/qemu/qemu_capabilities.c | 44 +++-
---
src/cpu/cpu.c| 41 ++
src/cpu/cpu.h| 13 +
src/cpu/cpu_x86.c| 135 +++
src/libvirt_private.syms | 2 +
4 files changed, 170 insertions(+), 21 deletions(-)
diff --git a/src/cpu/cpu.c
---
src/qemu/qemu_monitor.c| 21 +++
src/qemu/qemu_monitor.h| 3 +
src/qemu/qemu_monitor_json.c | 162 +
src/qemu/qemu_monitor_json.h | 6 +
tests/Makefile.am
---
src/qemu/qemu_capabilities.c | 192 +++
1 file changed, 120 insertions(+), 72 deletions(-)
diff --git a/src/qemu/qemu_capabilities.c b/src/qemu/qemu_capabilities.c
index 5dc3c9e..9440396 100644
--- a/src/qemu/qemu_capabilities.c
+++
---
src/cpu/cpu_x86.c| 21 ++---
src/cpu/cpu_x86.h| 10 ++
src/libvirt_private.syms | 7 +++
3 files changed, 35 insertions(+), 3 deletions(-)
diff --git a/src/cpu/cpu_x86.c b/src/cpu/cpu_x86.c
index 560a2a9..dbbcfd2 100644
--- a/src/cpu/cpu_x86.c
+++
Use the host CPU data probed by the current emulator when updating a
guest CPU according to a host CPU or when checking whether they are
compatible.
---
src/qemu/qemu_command.c | 32 ++--
src/qemu/qemu_domain.c | 21 +++--
2 files changed, 41
We don't need to store any CPUID data for function we know nothing
about. However, this limit may need to be increased in the future when
libvirt learns features described by a CPUID function greater than 10.
The comparison is done after subtracting high-bits prefix, so currently
functions
On Tue, Jul 23, 2013 at 06:11:35PM +0200, Jiri Denemark wrote:
Since QEMU and kvm may filter some host CPU features or add efficiently
emulated features, asking QEMU binary for host CPU data provides
better results when we later use the data for building guest CPUs.
---
Il 23/07/2013 18:01, Daniel P. Berrange ha scritto:
On Tue, Jul 23, 2013 at 05:35:57PM +0200, Paolo Bonzini wrote:
Il 23/07/2013 16:14, Daniel P. Berrange ha scritto:
Perhaps the default could be specified in a configuration file (and the
default should be the safe one).
No, that is even
On Tue, Jul 23, 2013 at 06:11:34PM +0200, Jiri Denemark wrote:
Could really do with a commit message describing what is
being changed here what the need is
---
src/qemu/qemu_capabilities.c | 192
+++
1 file changed, 120 insertions(+), 72
[adding qemu]
On 07/23/2013 10:19 AM, Daniel P. Berrange wrote:
On Tue, Jul 23, 2013 at 06:11:35PM +0200, Jiri Denemark wrote:
Since QEMU and kvm may filter some host CPU features or add efficiently
emulated features, asking QEMU binary for host CPU data provides
better results when we later
On Tue, Jul 23, 2013 at 06:11:30PM +0200, Jiri Denemark wrote:
Could use a more verbose commit message.
Looking at later patches, I see cpuDataFormat used in the
test suite, but I don't see cpuDataParse used anywhere ?
If these are only for the test suite, then perhaps adding
them to a cpupriv.h
On Tue, Jul 23, 2013 at 06:11:32PM +0200, Jiri Denemark wrote:
We don't need to store any CPUID data for function we know nothing
about. However, this limit may need to be increased in the future when
libvirt learns features described by a CPUID function greater than 10.
The comparison is done
On Tue, Jul 23, 2013 at 06:11:31PM +0200, Jiri Denemark wrote:
This is adding a new function as well as exporting some
existing functions, so should probably be split in two.
---
src/cpu/cpu_x86.c| 21 ++---
src/cpu/cpu_x86.h| 10 ++
On 07/23/13 17:59, John Ferlan wrote:
Update based on recent run/failures seen
---
tests/.valgrind.supp | 60
1 file changed, 60 insertions(+)
diff --git a/tests/.valgrind.supp b/tests/.valgrind.supp
index 10cc3c0..f04912d 100644
---
On Tue, Jul 23, 2013 at 17:19:03 +0100, Daniel Berrange wrote:
On Tue, Jul 23, 2013 at 06:11:35PM +0200, Jiri Denemark wrote:
Since QEMU and kvm may filter some host CPU features or add efficiently
emulated features, asking QEMU binary for host CPU data provides
better results when we later
On 07/23/2013 09:21 AM, Daniel P. Berrange wrote:
From: Daniel P. Berrange berra...@redhat.com
Add a virCgroupNewDetect API which is used to initialize a
cgroup object with the placement of an arbitrary process.
Signed-off-by: Daniel P. Berrange berra...@redhat.com
---
On 07/23/2013 09:59 AM, John Ferlan wrote:
Update based on recent run/failures seen
---
tests/.valgrind.supp | 60
1 file changed, 60 insertions(+)
diff --git a/tests/.valgrind.supp b/tests/.valgrind.supp
index 10cc3c0..f04912d 100644
On 07/23/2013 12:18 PM, Paolo Bonzini wrote:
Il 23/07/2013 18:01, Daniel P. Berrange ha scritto:
On Tue, Jul 23, 2013 at 05:35:57PM +0200, Paolo Bonzini wrote:
Il 23/07/2013 16:14, Daniel P. Berrange ha scritto:
Perhaps the default could be specified in a configuration file (and the
default
On Tue, Jul 23, 2013 at 17:27:41 +0100, Daniel Berrange wrote:
On Tue, Jul 23, 2013 at 06:11:30PM +0200, Jiri Denemark wrote:
Could use a more verbose commit message.
Looking at later patches, I see cpuDataFormat used in the
test suite, but I don't see cpuDataParse used anywhere ?
If
Il 23/07/2013 18:47, John Ferlan ha scritto:
On 07/23/2013 12:18 PM, Paolo Bonzini wrote:
Il 23/07/2013 18:01, Daniel P. Berrange ha scritto:
On Tue, Jul 23, 2013 at 05:35:57PM +0200, Paolo Bonzini wrote:
Il 23/07/2013 16:14, Daniel P. Berrange ha scritto:
Perhaps the default could be
On 07/23/2013 12:03 PM, Daniel P. Berrange wrote:
On Tue, Jul 23, 2013 at 11:50:57AM -0400, John Ferlan wrote:
On 07/23/2013 10:56 AM, Daniel P. Berrange wrote:
...snip...
+++ b/src/storage/storage_backend_iscsi.c
@@ -714,7 +714,8 @@ virStorageBackendISCSISetAuth(const char *portal,
On Tue, Jul 23, 2013 at 06:11:33PM +0200, Jiri Denemark wrote:
---
src/qemu/qemu_monitor.c| 21 +++
src/qemu/qemu_monitor.h| 3 +
src/qemu/qemu_monitor_json.c | 162
+
1 - 100 of 134 matches
Mail list logo
