Re: [libvirt] [PATCHv3 1/2] qemu: enable using implicit sata controller in q35 machines

2013-08-06 Thread Gerd Hoffmann
On 08/06/13 03:13, Laine Stump wrote: q35 machines have an implicit ahci (sata) controller at 00:1F.2 which has no id associated with it. For this reason, we can't refer to it as ahci0. The busses get a name nevertheless, it is derived from the bus type then, so it is ide. Resulting in bus

Re: [libvirt] : [Bug 993411] Compilation fails on lxc/lxc_monitor_protocol.c 31: undefined reference to xdr_uinit64_t

2013-08-06 Thread Daniel P. Berrange
On Mon, Aug 05, 2013 at 04:19:54PM -0500, Gerald Palmer wrote: suggested patch for compilation issue. --- lxc_monitor_protocol.h 2013-08-05 20:22:23.96300 + +++ libvirt-1.1.1/src/lxc/lxc_monitor_protocol.h2013-08-05 20:22:46.22600 + @@ -5,6 +5,8 @@ #ifndef

Re: [libvirt] [PATCH] xen: Use internal interfaces in xenDomainUsedCpus

2013-08-06 Thread Stefan Bader
On 05.08.2013 19:52, Jim Fehlig wrote: libvirt typically uses a '*Internal' naming pattern for these types of internal functions, e.g. xenUnifiedDomainGetVcpusFlagsInternal. Also as we touch this code we should strive to use the libvirt pattern of putting each parameter after the first on a

[libvirt] [PATCH 4/4] Fix validation of CA certificate chains

2013-08-06 Thread Daniel P. Berrange
From: Daniel P. Berrange berra...@redhat.com The code added to validate CA certificates did not take into account the possibility that the cacert.pem file can contain multiple (concatenated) cert data blocks. Extend the code for loading CA certs to use the gnutls APIs for loading cert lists. Add

[libvirt] [PATCH 2/4] Avoid re-generating certs every time

2013-08-06 Thread Daniel P. Berrange
From: Daniel P. Berrange berra...@redhat.com Currently every test case in the TLS test suite generates the certs fresh. This is a waste of time, since its parameters don't change across test cases. Create certs once in main method. Signed-off-by: Daniel P. Berrange berra...@redhat.com ---

[libvirt] [PATCH 3/4] Change data passed into TLS test cases

2013-08-06 Thread Daniel P. Berrange
From: Daniel P. Berrange berra...@redhat.com Currently a 'struct testTLSCertReq' instance is passed into the TLS test cases. This is not flexible enough to cope with certificate chains, where one file now corresponds to multiple certificates. Change the test cases so that we pass in filenames

[libvirt] [PATCH 0/4] Fix handling of CA certificate chains

2013-08-06 Thread Daniel P. Berrange
This series fixes the CA certificate validation so that it correctly works when a client and server cert are both signed by intermediate CAs, sharing a common ancestor CA. -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

[libvirt] virsh [attach-detach]-device question

2013-08-06 Thread Scott Sullivan
I have noticed a behavior I am hoping someone can help me understand. Consider the following scenario: 1.) Start a test dummy qemu-kvm instance with no OS via virsh named no_os. 2.) Attach a device to it; [root@host ~]# virsh attach-device no_os /root/hotplug_device_b.xml Device attached

Re: [libvirt] [PATCH v6 2/2] qemu: support to drop disk with 'optional' startupPolicy

2013-08-06 Thread Martin Kletzander
On 08/02/2013 08:37 AM, Guannan Ren wrote: Go through disks of guest, if one disk doesn't exist or its backing chain is broken, with 'optional' startupPolicy, for CDROM and Floppy we only discard its source path definition in xml, for disks we drop it from disk list and free it. ---

[libvirt] [PATCH] nwfilter: Use -m conntrack rather than -m state

2013-08-06 Thread Stefan Berger
Since iptables version 1.4.16 '-m state --state NEW' is converted to '-m conntrack --ctstate NEW'. Therefore, when encountering this or later versions of iptables use '-m conntrack --ctstate'. Signed-off-by: Stefan Berger stef...@linux.vnet.ibm.com --- src/nwfilter/nwfilter_ebiptables_driver.c

Re: [libvirt] : [Bug 993411] Compilation fails on lxc/lxc_monitor_protocol.c 31: undefined reference to xdr_uinit64_t

2013-08-06 Thread Eric Blake
On 08/06/2013 03:27 AM, Daniel P. Berrange wrote: On Mon, Aug 05, 2013 at 04:19:54PM -0500, Gerald Palmer wrote: suggested patch for compilation issue. --- lxc_monitor_protocol.h 2013-08-05 20:22:23.96300 + +++ libvirt-1.1.1/src/lxc/lxc_monitor_protocol.h2013-08-05

Re: [libvirt] virsh [attach-detach]-device question

2013-08-06 Thread Scott Sullivan
On 08/06/2013 08:54 AM, Scott Sullivan wrote: I have noticed a behavior I am hoping someone can help me understand. Consider the following scenario: 1.) Start a test dummy qemu-kvm instance with no OS via virsh named no_os. 2.) Attach a device to it; [root@host ~]# virsh attach-device no_os

Re: [libvirt] [PATCH] xen: fix memory corruption in legacy driver

2013-08-06 Thread Doug Goldstein
On Mon, Aug 5, 2013 at 12:28 PM, Jim Fehlig jfeh...@suse.com wrote: Eric Blake wrote: On 08/05/2013 10:39 AM, Jim Fehlig wrote: Commit 632180d1 introduced memory corruption in xenDaemonListDefinedDomains by starting to populate the names array at index -1, causing all sorts of havoc in

Re: [libvirt] [PATCH] qemu_migration: Don't error on tunelled migration with --copy-storage

2013-08-06 Thread Doug Goldstein
On Mon, Aug 5, 2013 at 11:36 AM, Eric Blake ebl...@redhat.com wrote: On 08/05/2013 04:20 AM, Michal Privoznik wrote: https://bugzilla.redhat.com/show_bug.cgi?id=979477 Since 1.0.3 we are using the new way to copy non shared storage during migration (the NBD way). However, whether the new or

Re: [libvirt] : [Bug 993411] Compilation fails on lxc/lxc_monitor_protocol.c 31: undefined reference to xdr_uinit64_t

2013-08-06 Thread Gerald Palmer
Linux localhost.localnet 3.8.1 #1 SMP Sun Jul 21 16:11:57 GMT 2013 x86_64 GNU/Linux bc-1.06 zlib-1.2.5 openssl-1.0.0a openssh-5.5p1 # gcc -v Using built-in specs. COLLECT_GCC=gcc COLLECT_LTO_WRAPPER=/usr/lib/gcc/x86_64-unknown-linux-gnu/4.7.2/lto-wrapper Target: x86_64-unknown-linux-gnu

Re: [libvirt] [PATCHv3 2/2] qemu: improve error reporting during PCI address validation

2013-08-06 Thread Doug Goldstein
On Mon, Aug 5, 2013 at 9:15 PM, Doug Goldstein car...@gentoo.org wrote: On Mon, Aug 5, 2013 at 8:13 PM, Laine Stump la...@laine.org wrote: This patch addresses two concerns with the error reporting when an incompatible PCI address is specified for a device: 1) It wasn't always apparent which

Re: [libvirt] [PATCH v6 2/2] qemu: support to drop disk with 'optional' startupPolicy

2013-08-06 Thread Guannan Ren
On 08/06/2013 09:40 PM, Martin Kletzander wrote: On 08/02/2013 08:37 AM, Guannan Ren wrote: Go through disks of guest, if one disk doesn't exist or its backing chain is broken, with 'optional' startupPolicy, for CDROM and Floppy we only discard its source path definition in xml, for disks we

Re: [libvirt] [PATCH] nwfilter: Use -m conntrack rather than -m state

2013-08-06 Thread John Ferlan
On 08/06/2013 09:52 AM, Stefan Berger wrote: Since iptables version 1.4.16 '-m state --state NEW' is converted to '-m conntrack --ctstate NEW'. Therefore, when encountering this or later versions of iptables use '-m conntrack --ctstate'. Signed-off-by: Stefan Berger

[libvirt] [TCK][PATCH] nwfilter: convert ctstate to state

2013-08-06 Thread Stefan Berger
iptables version 1.4.16 and later automatically convert -m state --state ... to -m conntrack --ctstate ... In the test cases we will then only see 'ctstate' and convert that back to the older 'state' before comparing actual against expected output. Signed-off-by: Stefan Berger

Re: [libvirt] [TCK][PATCH] nwfilter: convert ctstate to state

2013-08-06 Thread Eric Blake
On 08/06/2013 09:24 AM, Stefan Berger wrote: iptables version 1.4.16 and later automatically convert -m state --state ... to -m conntrack --ctstate ... In the test cases we will then only see 'ctstate' and convert that back to the older 'state' before comparing actual against expected

[libvirt] [PATCH v2] virGetGroupList: always include the primary group

2013-08-06 Thread Guido Günther
The change from initgroups to virGetGroupList/setgroups in cab36cfe71ba83b71e536ba5c98e596f02b697b0 dropped the primary group from processes group list iff the passed in group to virGetGroupList differs from the user's primary group. So always include the primary group to bring back the old

Re: [libvirt] [PATCH] nwfilter: Use -m conntrack rather than -m state

2013-08-06 Thread Stefan Berger
On 08/06/2013 11:20 AM, John Ferlan wrote: On 08/06/2013 09:52 AM, Stefan Berger wrote: Since iptables version 1.4.16 '-m state --state NEW' is converted to '-m conntrack --ctstate NEW'. Therefore, when encountering this or later versions of iptables use '-m conntrack --ctstate'.

Re: [libvirt] [TCK][PATCH] nwfilter: convert ctstate to state

2013-08-06 Thread Stefan Berger
On 08/06/2013 12:01 PM, Eric Blake wrote: On 08/06/2013 09:24 AM, Stefan Berger wrote: iptables version 1.4.16 and later automatically convert -m state --state ... to -m conntrack --ctstate ... In the test cases we will then only see 'ctstate' and convert that back to the older 'state' before

Re: [libvirt] [PATCH v2] virGetGroupList: always include the primary group

2013-08-06 Thread Eric Blake
On 08/06/2013 10:36 AM, Guido Günther wrote: The change from initgroups to virGetGroupList/setgroups in cab36cfe71ba83b71e536ba5c98e596f02b697b0 dropped the primary group from processes group list iff the passed in group to virGetGroupList differs from the user's primary group. So always

Re: [libvirt] [PATCHv3] build: avoid -lgcrypt with newer gnutls

2013-08-06 Thread Eric Blake
ping On 07/30/2013 02:45 PM, Eric Blake wrote: https://bugzilla.redhat.com/show_bug.cgi?id=951637 Newer gnutls uses nettle, rather than gcrypt, which is a lot nicer regarding initialization. Yet we were unconditionally initializing gcrypt even when gnutls wouldn't be using it, and having

Re: [libvirt] [PATCHv2] build: add configure option to disable gnulib tests

2013-08-06 Thread Eric Blake
ping series On 08/02/2013 03:08 PM, Eric Blake wrote: The gnulib testsuite is relatively stable - the only times it is likely to have a test change from pass to fail is on a gnulib submodule update or a major system change (such as moving from Fedora 18 to 19, or other large change to libc).

Re: [libvirt] [PATCH] xen: Use internal interfaces in xenDomainUsedCpus

2013-08-06 Thread Jim Fehlig
Stefan Bader wrote: On 05.08.2013 19:52, Jim Fehlig wrote: libvirt typically uses a '*Internal' naming pattern for these types of internal functions, e.g. xenUnifiedDomainGetVcpusFlagsInternal. Also as we touch this code we should strive to use the libvirt pattern of putting each

Re: [libvirt] [PATCHv3 2/2] qemu: improve error reporting during PCI address validation

2013-08-06 Thread Laine Stump
On 08/06/2013 10:56 AM, Doug Goldstein wrote: Works as expected. error: Failed to define domain from error.xml error: XML error: PCI bus is not compatible with the device at :00:04.0. Device requires a standard PCI slot, which is not provided by bus :00 Okay. I changed the char* to

Re: [libvirt] [PATCHv3 1/2] qemu: enable using implicit sata controller in q35 machines

2013-08-06 Thread Laine Stump
On 08/05/2013 10:09 PM, Doug Goldstein wrote: On Mon, Aug 5, 2013 at 8:13 PM, Laine Stump la...@laine.org wrote: q35 machines have an implicit ahci (sata) controller at 00:1F.2 which has no id associated with it. For this reason, we can't refer to it as ahci0. Instead, we don't give an id on

[libvirt] [TCK][PATCH v2] nwfilter: convert ctstate to state

2013-08-06 Thread Stefan Berger
iptables version 1.4.16 and later automatically convert -m state --state ... to -m conntrack --ctstate ... In the test cases we will then only see 'ctstate' and convert that back to the older 'state'. Signed-off-by: Stefan Berger stef...@linux.vnet.ibm.com ---

Re: [libvirt] [PATCH] nwfilter: Use -m conntrack rather than -m state

2013-08-06 Thread Stefan Berger
On 08/06/2013 11:20 AM, John Ferlan wrote: On 08/06/2013 09:52 AM, Stefan Berger wrote: Since iptables version 1.4.16 '-m state --state NEW' is converted to '-m conntrack --ctstate NEW'. Therefore, when encountering this or later versions of iptables use '-m conntrack --ctstate'. Forgot to

Re: [libvirt] [TCK][PATCH v2] nwfilter: convert ctstate to state

2013-08-06 Thread Eric Blake
On 08/06/2013 01:34 PM, Stefan Berger wrote: iptables version 1.4.16 and later automatically convert -m state --state ... to -m conntrack --ctstate ... In the test cases we will then only see 'ctstate' and convert that back to the older 'state'. Signed-off-by: Stefan Berger

[libvirt] [PATCH] build: fix configure detection of if_bridge.h on RHEL 6

2013-08-06 Thread Eric Blake
A fresh checkout on a RHEL 6 machine with these packages: kernel-headers-2.6.32-405.el6.x86_64 glibc-2.12-1.128.el6.x86_64 failed to configure with this message: checking for linux/if_bridge.h... no configure: error: You must install kernel-headers in order to compile libvirt with QEMU or LXC

Re: [libvirt] [PATCH v2] virGetGroupList: always include the primary group

2013-08-06 Thread Guido Günther
On Tue, Aug 06, 2013 at 10:54:36AM -0600, Eric Blake wrote: On 08/06/2013 10:36 AM, Guido Günther wrote: The change from initgroups to virGetGroupList/setgroups in cab36cfe71ba83b71e536ba5c98e596f02b697b0 dropped the primary group from processes group list iff the passed in group to

Re: [libvirt] [TCK][PATCH v2] nwfilter: convert ctstate to state

2013-08-06 Thread Stefan Berger
On 08/06/2013 04:03 PM, Eric Blake wrote: On 08/06/2013 01:34 PM, Stefan Berger wrote: iptables version 1.4.16 and later automatically convert -m state --state ... to -m conntrack --ctstate ... In the test cases we will then only see 'ctstate' and convert that back to the older 'state'.

Re: [libvirt] [PATCH] nwfilter: Use -m conntrack rather than -m state

2013-08-06 Thread John Ferlan
On 08/06/2013 12:43 PM, Stefan Berger wrote: On 08/06/2013 11:20 AM, John Ferlan wrote: On 08/06/2013 09:52 AM, Stefan Berger wrote: Since iptables version 1.4.16 '-m state --state NEW' is converted to '-m conntrack --ctstate NEW'. Therefore, when encountering this or later versions of

Re: [libvirt] [PATCH] nwfilter: Use -m conntrack rather than -m state

2013-08-06 Thread Stefan Berger
On 08/06/2013 07:10 PM, John Ferlan wrote: On 08/06/2013 12:43 PM, Stefan Berger wrote: On 08/06/2013 11:20 AM, John Ferlan wrote: On 08/06/2013 09:52 AM, Stefan Berger wrote: Since iptables version 1.4.16 '-m state --state NEW' is converted to '-m conntrack --ctstate NEW'. Therefore, when

[libvirt] [PATCH v2] nwfilter: Use -m conntrack rather than -m state

2013-08-06 Thread Stefan Berger
Since iptables version 1.4.16 '-m state --state NEW' is converted to '-m conntrack --ctstate NEW'. Therefore, when encountering this or later versions of iptables use '-m conntrack --ctstate'. Signed-off-by: Stefan Berger stef...@linux.vnet.ibm.com --- v1-v2: - Fixed a logic bug and adjusted

Re: [libvirt] [PATCH v2] nwfilter: Use -m conntrack rather than -m state

2013-08-06 Thread John Ferlan
On 08/06/2013 07:46 PM, Stefan Berger wrote: Since iptables version 1.4.16 '-m state --state NEW' is converted to '-m conntrack --ctstate NEW'. Therefore, when encountering this or later versions of iptables use '-m conntrack --ctstate'. Signed-off-by: Stefan Berger

Re: [libvirt] [PATCH v2] nwfilter: Use -m conntrack rather than -m state

2013-08-06 Thread Stefan Berger
On 08/06/2013 08:11 PM, John Ferlan wrote: On 08/06/2013 07:46 PM, Stefan Berger wrote: Since iptables version 1.4.16 '-m state --state NEW' is converted to '-m conntrack --ctstate NEW'. Therefore, when encountering this or later versions of iptables use '-m conntrack --ctstate'.