Re: [libvirt] virDomainCreateWithFlags error

2013-08-08 Thread Alex Jia
On 08/08/2013 01:54 PM, Wangpan wrote: Hi all, I'm using 'libvirt 1.1.1-1 amd64' undef debian wheezy, I found that the return code is 139 when I run command: $ sudo virsh start df1c4670-18eb-4520-b5d8-aa8a492eb876 --paused; echo $? Thanks for reporting this issue, it's a libvirt's bug and

Re: [libvirt] [PATCH] cgroup: refactor macros usage

2013-08-08 Thread Roman Bogorodskiy
Eric Blake wrote: On 08/03/2013 12:01 PM, Roman Bogorodskiy wrote: util/vircgroup.c uses a lot of macros to detect if cgroup is supported by the system or not. These macros are pretty smart and allow to keep code compact, however the downside of that is that it's getting harder to

Re: [libvirt] [sandbox][PATCH v2] Fix delete of running container

2013-08-08 Thread Wayne Sun
On 08/07/2013 09:34 PM, Daniel P. Berrange wrote: On Wed, Aug 07, 2013 at 09:24:14PM +0800, Wayne Sun wrote: Delete running container is not supprted and will report an error. Related to bug: https://bugzilla.redhat.com/show_bug.cgi?id=994495 Signed-off-by: Wayne Sun g...@redhat.com ---

[libvirt] [sandbox][PATCH v3] Fix delete of running container

2013-08-08 Thread Wayne Sun
Delete running container is not supprted and will report an error. Related to bug: https://bugzilla.redhat.com/show_bug.cgi?id=994495 v1: Fix stop function and delete running container. v2: Delete running container is not allowed, spawn virsh to get domain status. v3: Using exist libvirt

[libvirt] With different libvirt version, lxc-enter-namespace return Different Execution results.

2013-08-08 Thread hzguanqi...@corp.netease.com
Hi Alex, I noticed you did lots of work about lxc-enter-namespace function. There is one thing really confusing me and I really want to consult with you about it. When I execute lxc-enter-namespace to get disk space info for lxc container under different libvirt version, It return different

[libvirt] [PATCH] remote: Fix a segfault in remoteDomainCreateWithFlags

2013-08-08 Thread Alex Jia
Valgrind defects memory error: ==16759== 1 errors in context 1 of 8: ==16759== Invalid free() / delete / delete[] / realloc() ==16759==at 0x4A074C4: free (in /usr/lib64/valgrind/vgpreload_memcheck-amd64-linux.so) ==16759==by 0x83CD329: xdr_string (in /usr/lib64/libc-2.17.so) ==16759==

Re: [libvirt] With different libvirt version, lxc-enter-namespace return Different Execution results.

2013-08-08 Thread Daniel P. Berrange
On Thu, Aug 08, 2013 at 03:56:35PM +0800, hzguanqi...@corp.netease.com wrote: But when I did the same thing under libvirt of version 1.1.0 with debian host OS, the execution result changed: #disk info of host hzguanqiang@debian:~$ df -hl Filesystem

Re: [libvirt] With different libvirt version, lxc-enter-namespace return Different Execution results.

2013-08-08 Thread hzguanqi...@corp.netease.com
On 2013-08-08 16:53 , Daniel P. Berrange wrote: On Thu, Aug 08, 2013 at 03:56:35PM +0800, hzguanqi...@corp.netease.com wrote: But when I did the same thing under libvirt of version 1.1.0 with debian host OS, the execution result changed: #disk info of host hzguanqiang@debian:~$ df -hl

Re: [libvirt] virDomainCreateWithFlags error

2013-08-08 Thread Alex Jia
Hi Wangpan, Here is a bug https://bugzilla.redhat.com/show_bug.cgi?id=994855, if you're familiar with bugzilla then you may file a bug by yourself next time, for details, please see the following link, thanks. http://libvirt.org/bugs.html -- Regards, Alex - Original Message -

Re: [libvirt] With different libvirt version, lxc-enter-namespace return Different Execution results.

2013-08-08 Thread Daniel P. Berrange
On Thu, Aug 08, 2013 at 05:00:38PM +0800, hzguanqi...@corp.netease.com wrote: On 2013-08-08 16:53 , Daniel P. Berrange wrote: On Thu, Aug 08, 2013 at 03:56:35PM +0800, hzguanqi...@corp.netease.com wrote: But when I did the same thing under libvirt of version 1.1.0 with debian host OS, the

Re: [libvirt] virDomainCreateWithFlags error

2013-08-08 Thread Wangpan
Thanks Alex for your notification! From:Alex Jia a...@redhat.com Date:2013-08-08 17:02 Subject:Re: [libvirt] virDomainCreateWithFlags error To:Wangpanhzwang...@corp.netease.com Cc:libvir-listlibvir-list@redhat.com Hi Wangpan, Here is a bug https://bugzilla.redhat.com/show_bug.cgi?id=994855, if

Re: [libvirt] With different libvirt version, lxc-enter-namespace return Different Execution results.

2013-08-08 Thread hzguanqi...@corp.netease.com
On 2013-08-08 17:06 , Daniel P. Berrange wrote: On Thu, Aug 08, 2013 at 05:00:38PM +0800, hzguanqi...@corp.netease.com wrote: On 2013-08-08 16:53 , Daniel P. Berrange wrote: On Thu, Aug 08, 2013 at 03:56:35PM +0800, hzguanqi...@corp.netease.com wrote: But when I did the same thing under

Re: [libvirt] [PATCH] remote: Fix a segfault in remoteDomainCreateWithFlags

2013-08-08 Thread Claudio Bley
At Thu, 8 Aug 2013 16:48:46 +0800, Alex Jia wrote: ... # virsh start domain --paused RHBZ: https://bugzilla.redhat.com/show_bug.cgi?id=994855 Signed-off-by: Alex Jia a...@redhat.com --- src/remote/remote_driver.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff

Re: [libvirt] [sandbox][PATCH v3] Fix delete of running container

2013-08-08 Thread Alex Jia
On 08/08/2013 03:42 PM, Wayne Sun wrote: Delete running container is not supprted and will report an error. Related to bug: https://bugzilla.redhat.com/show_bug.cgi?id=994495 v1: Fix stop function and delete running container. v2: Delete running container is not allowed, spawn virsh to get

Re: [libvirt] [sandbox][PATCH v3] Fix delete of running container

2013-08-08 Thread Daniel P. Berrange
On Thu, Aug 08, 2013 at 03:42:28PM +0800, Wayne Sun wrote: Delete running container is not supprted and will report an error. Related to bug: https://bugzilla.redhat.com/show_bug.cgi?id=994495 v1: Fix stop function and delete running container. v2: Delete running container is not allowed,

Re: [libvirt] [sandbox][PATCH v3] Fix delete of running container

2013-08-08 Thread Alex Jia
On 08/08/2013 06:42 PM, Daniel P. Berrange wrote: On Thu, Aug 08, 2013 at 03:42:28PM +0800, Wayne Sun wrote: Delete running container is not supprted and will report an error. Related to bug: https://bugzilla.redhat.com/show_bug.cgi?id=994495 v1: Fix stop function and delete running

Re: [libvirt] [PATCH] Add info about access control checks into API reference

2013-08-08 Thread Daniel P. Berrange
On Wed, Aug 07, 2013 at 12:06:09PM -0600, Eric Blake wrote: On 08/07/2013 06:06 AM, Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com So that app developers / admins know what access control checks are performed for each API, this patch extends the API docs

[libvirt] [PATCH] qemu: Allow hotplug of multiple SCSI devices

2013-08-08 Thread Viktor Mihajlovski
From: Eric Farman far...@linux.vnet.ibm.com Hotplugging a single SCSI device works, but adding additional ones result in an error from QEMU: [root@gpok197 ~]# virsh attach-device guest01 blah.xml Device attached successfully [root@gpok197 ~]# virsh attach-device guest01 blah2.xml error: Failed

[libvirt] [PATCH] Record the where the auto-generated data comes from

2013-08-08 Thread Daniel P. Berrange
From: Daniel P. Berrange berra...@redhat.com The gendispatch.pl script puts comments at the top of files it creates, saying that it auto-generated them. Also include the name of the source data file which it reads when doing the auto-generation. Signed-off-by: Daniel P. Berrange

[libvirt] [PATCH] Add documentation for access control system

2013-08-08 Thread Daniel P. Berrange
From: Daniel P. Berrange berra...@redhat.com This adds two new pages to the website, acl.html describing the general access control framework and permissions models, and aclpolkit.html describing the use of polkit as an access control driver. page.xsl is modified to support a new syntax div

[libvirt] [PATCH] Ensure securityfs is mounted readonly in container

2013-08-08 Thread Daniel P. Berrange
From: Dan Walsh dwa...@redhat.com If securityfs is available on the host, we should ensure to mount it read-only in the container. This will avoid systemd trying to mount it during startup causing SELinux AVCs. Signed-off-by: Daniel P. Berrange berra...@redhat.com --- src/lxc/lxc_container.c |

Re: [libvirt] [PATCH] remote: Fix a segfault in remoteDomainCreateWithFlags

2013-08-08 Thread Martin Kletzander
On 08/08/2013 10:48 AM, Alex Jia wrote: Valgrind defects memory error: ==16759== 1 errors in context 1 of 8: ==16759== Invalid free() / delete / delete[] / realloc() ==16759==at 0x4A074C4: free (in /usr/lib64/valgrind/vgpreload_memcheck-amd64-linux.so) ==16759==by 0x83CD329:

Re: [libvirt] [PATCH] qemu: Allow hotplug of multiple SCSI devices

2013-08-08 Thread Martin Kletzander
On 08/08/2013 01:26 PM, Viktor Mihajlovski wrote: From: Eric Farman far...@linux.vnet.ibm.com Hotplugging a single SCSI device works, but adding additional ones result in an error from QEMU: [root@gpok197 ~]# virsh attach-device guest01 blah.xml Device attached successfully [root@gpok197

Re: [libvirt] [PATCH 2/2] qemu: Support setting the 'removable' flag for USB disks

2013-08-08 Thread intrigeri
Hi, Add an attribute named 'removable' to the 'target' element of disks, which controls the removable flag. For instance, on a Linux guest it controls the value of /sys/block/$dev/removable. This option is only valid for USB disks (i.e. bus='usb'), and its default value is 'off', which is

Re: [libvirt] [PATCH] Record the where the auto-generated data comes from

2013-08-08 Thread Michal Privoznik
On 08.08.2013 13:27, Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com The gendispatch.pl script puts comments at the top of files it creates, saying that it auto-generated them. Also include the name of the source data file which it reads when doing the

Re: [libvirt] With different libvirt version, lxc-enter-namespace return Different Execution results.

2013-08-08 Thread Eric Blake
On 08/08/2013 03:16 AM, hzguanqi...@corp.netease.com wrote: That's your problem. The kernel you are running on is too old to support attaching to the mount namespace. You need to see 'mnt' in the files there, and also 'pid' and 'user' too for completeness. Daniel -- |: http://berrange.com

Re: [libvirt] [PATCH] Ensure securityfs is mounted readonly in container

2013-08-08 Thread Eric Blake
On 08/08/2013 05:52 AM, Daniel P. Berrange wrote: From: Dan Walsh dwa...@redhat.com If securityfs is available on the host, we should ensure to mount it read-only in the container. This will avoid systemd trying to mount it during startup causing SELinux AVCs. Signed-off-by: Daniel P.

[libvirt] [PATCH] Add support for detecting PPC little endian arches

2013-08-08 Thread Daniel P. Berrange
From: Daniel P. Berrange berra...@redhat.com The recent patch series proposing the addition of PPC little endian arch support to Linux defines new arch names 'ppcle' and 'ppc64le': https://lists.ozlabs.org/pipermail/linuxppc-dev/2013-August/109908.html This just makes libvirt know about these

Re: [libvirt] [PATCH 0/2] Support settings the 'removable' flag for USB disks

2013-08-08 Thread Eric Blake
[replying mainly to float this thread back to the surface of my inbox] On 07/25/2013 04:43 AM, Fred A. Kemp wrote: From: Fred A. Kemp ano...@lavabit.com The commit message of patch #2 explains the purpose of this patch set. A review would be greatly appreciated! Note that I've only added

Re: [libvirt] [PATCH 2/2] qemu: Support setting the 'removable' flag for USB disks

2013-08-08 Thread Eric Blake
On 08/08/2013 06:18 AM, intrigeri wrote: Hi, For what it's worth, I have been successfully using this patchset in production since March, in its various incarnations. What is missing to get these patches merged, then? If you are providing a positive review (anyone can do that, not just

Re: [libvirt] [PATCH] Add support for detecting PPC little endian arches

2013-08-08 Thread Eric Blake
On 08/08/2013 07:07 AM, Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com The recent patch series proposing the addition of PPC little endian arch support to Linux defines new arch names 'ppcle' and 'ppc64le':

Re: [libvirt] [PATCH] Add support for detecting PPC little endian arches

2013-08-08 Thread Doug Goldstein
On Thu, Aug 8, 2013 at 8:07 AM, Daniel P. Berrange berra...@redhat.com wrote: From: Daniel P. Berrange berra...@redhat.com The recent patch series proposing the addition of PPC little endian arch support to Linux defines new arch names 'ppcle' and 'ppc64le':

[libvirt] [PATCH 7/8] virsh: Add completer functions to snapshotCmds

2013-08-08 Thread Tomas Meszaros
Add .completer and .completer_flags to snapshotCmds. Provides domain completion for most of the snapshotCmds commands. --- tools/virsh-snapshot.c | 45 - 1 file changed, 36 insertions(+), 9 deletions(-) diff --git a/tools/virsh-snapshot.c

[libvirt] [PATCH 2/8] virsh: Add vshDomainCompleter

2013-08-08 Thread Tomas Meszaros
Function vshDomainCompler returns domains names. Michal Privoznik recommended to add global variable __my_conn so we can get the list of domains from the virConnecTListAllDomains(). vshReconnect() is called before the first command is executed in order to provide autocompletion for the very

[libvirt] [PATCH 4/8] virsh: Add vshRebootShutdownModeCompleter

2013-08-08 Thread Tomas Meszaros
vshRebootShutdownModeCompleter returns available modes for reboot/shutdown commands. --- tools/virsh.c | 28 tools/virsh.h | 1 + 2 files changed, 29 insertions(+) diff --git a/tools/virsh.c b/tools/virsh.c index f9c9ccb..13d66c7 100644 --- a/tools/virsh.c +++

[libvirt] [PATCH 3/8] virsh: Add vshSuspendTargetCompleter

2013-08-08 Thread Tomas Meszaros
vshSuspendTargetCompleter returns targets available for suspend. This completer can be used for the command option completion (for dompmsuspend, etc.). --- tools/virsh.c | 28 tools/virsh.h | 1 + 2 files changed, 29 insertions(+) diff --git a/tools/virsh.c

[libvirt] [PATCH 8/8] virsh: Add completer functions to domMonitoringCmds

2013-08-08 Thread Tomas Meszaros
Add .completer and .completer_flags to domMonitoringCmds. Provides domain completion for domMonitoringCmds commands. --- tools/virsh-domain-monitor.c | 32 +--- 1 file changed, 25 insertions(+), 7 deletions(-) diff --git a/tools/virsh-domain-monitor.c

[libvirt] [PATCH 1/8] virsh: Add vshCmdCompleter and vshOptCompleter

2013-08-08 Thread Tomas Meszaros
completer and completer_flags added to the _vshCmdDef and _vshCmdOptDef structures so it will be possible for completion generators to conveniently call completer functions with desired flags. --- tools/virsh-domain.c | 10 +- tools/virsh.h| 7 +++ 2 files changed, 12

[libvirt] [PATCH 5/8] virsh: Improve readline generators and readline completion

2013-08-08 Thread Tomas Meszaros
New completion generators responsible for advances command and command options completions. vshReadlineCommandCompletionGenerator - generator for advanced command completions. This function will call some vshCmdCompleter function (e.g. vshDomainCompleter), which will return relevant data used for

[libvirt] [PATCH 0/8] virsh: More intelligent auto-completion

2013-08-08 Thread Tomas Meszaros
Hi, this patch series is a prototype for my GSoC project (Michal Privoznik is my mentor). I'm working on virsh auto-completion, trying to make it more intelligent. At this stage, prototype is capable of command and option completion. Three completer functions are currently implemented so you can

[libvirt] [PATCH 6/8] virsh: Add completer functions to domManaggementCmds

2013-08-08 Thread Tomas Meszaros
Add .completer and .completer_flags to domManagementCmds. vshDomainCompleter (with appropriate flags) is enabled for commands requiring only single domain argument. --- tools/virsh-domain.c | 230 --- 1 file changed, 180 insertions(+), 50

Re: [libvirt] [PATCH] remote: Fix a segfault in remoteDomainCreateWithFlags

2013-08-08 Thread Alex Jia
Hi Martin, I think if the call() can't do this then it's impossible to de-duplicate in all similar functions. -- Regards, Alex - Original Message - From: Martin Kletzander mklet...@redhat.com To: Alex Jia a...@redhat.com Cc: libvir-list@redhat.com Sent: Thursday, August 8, 2013

[libvirt] [PATCH] configure: fix formatting of missing pkg-config modules error

2013-08-08 Thread Giuseppe Scrivano
It adds an empty space after the package version. Previously the error message looked like: You must install the dbus-1 = 1.0.0pkg-config module to compile libvirt Signed-off-by: Giuseppe Scrivano gscri...@redhat.com --- m4/virt-lib.m4 | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

[libvirt] [PATCH] Add a man page for virtlockd daemon

2013-08-08 Thread Daniel P. Berrange
From: Daniel P. Berrange berra...@redhat.com Create a virtlockd.pod.in file containing the man page content for virtlockd. Signed-off-by: Daniel P. Berrange berra...@redhat.com --- .gitignore | 2 + libvirt.spec.in | 1 + src/Makefile.am | 24

[libvirt] [PATCH] Add an example config file for virtlockd

2013-08-08 Thread Daniel P. Berrange
From: Daniel P. Berrange berra...@redhat.com The virtlockd daemon supports an /etc/libvirt/virtlockd.conf config file, but we never installed a default config, nor created any augeas scripts. This change addresses that omission. Signed-off-by: Daniel P. Berrange berra...@redhat.com ---

Re: [libvirt] [PATCH] configure: fix formatting of missing pkg-config modules error

2013-08-08 Thread Daniel P. Berrange
On Thu, Aug 08, 2013 at 04:56:59PM +0200, Giuseppe Scrivano wrote: It adds an empty space after the package version. Previously the error message looked like: You must install the dbus-1 = 1.0.0pkg-config module to compile libvirt Signed-off-by: Giuseppe Scrivano gscri...@redhat.com ---

Re: [libvirt] Updated patch for virt-login-shell for joing libvirt lxc containers.

2013-08-08 Thread Daniel P. Berrange
On Fri, Aug 02, 2013 at 04:52:52PM +0100, Daniel P. Berrange wrote: On Fri, Aug 02, 2013 at 11:22:07AM -0400, Daniel J Walsh wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 THis patch fixes all of Eric's and Daniels comments. [PATCH] virt-login-shell joins users into lxc

Re: [libvirt] [PATCH] maint: the compiler is not always named gcc

2013-08-08 Thread Guido Günther
On Wed, Aug 07, 2013 at 09:46:06AM -0600, Eric Blake wrote: https://bugzilla.redhat.com/show_bug.cgi?id=994589 complained that even when using a cross-compiler not named 'gcc', the configure output confusingly referred to gcc. * m4/virt-compile-warnings.m4 (LIBVIRT_COMPILE_WARNINGS): Use a

Re: [libvirt] [PATCH] maint: avoid C99 loop declaration

2013-08-08 Thread Guido Günther
On Wed, Aug 07, 2013 at 04:53:30PM -0600, Eric Blake wrote: Commit 3d0e3c1 reintroduced a problem previously squelched in commit 7e5aa78. Add a syntax check this time around. Didn't notice we want to avoid this sorry. util/virutil.c: In function 'virGetGroupList': util/virutil.c:1015:

Re: [libvirt] [PATCH] configure: fix formatting of missing pkg-config modules error

2013-08-08 Thread Eric Blake
On 08/08/2013 09:10 AM, Daniel P. Berrange wrote: On Thu, Aug 08, 2013 at 04:56:59PM +0200, Giuseppe Scrivano wrote: It adds an empty space after the package version. Previously the error message looked like: You must install the dbus-1 = 1.0.0pkg-config module to compile libvirt

[libvirt] [PATCH] build: fix compilation of virt-login-shell.c

2013-08-08 Thread Jim Fehlig
virt-login-shell.c was failing to compile with CC virt_login_shell-virt-login-shell.o virt-login-shell.c: In function 'main': virt-login-shell.c:205:5: error: implicit declaration of function 'setlocale' [-Werror=implicit-function-declaration] virt-login-shell.c:205:5: error: nested extern

Re: [libvirt] [PATCH] maint: avoid C99 loop declaration

2013-08-08 Thread Eric Blake
On 08/08/2013 12:41 PM, Guido Günther wrote: On Wed, Aug 07, 2013 at 04:53:30PM -0600, Eric Blake wrote: Commit 3d0e3c1 reintroduced a problem previously squelched in commit 7e5aa78. Add a syntax check this time around. Didn't notice we want to avoid this sorry. That's okay - it's my own

Re: [libvirt] [PATCH] build: fix compilation of virt-login-shell.c

2013-08-08 Thread Eric Blake
On 08/08/2013 02:04 PM, Jim Fehlig wrote: virt-login-shell.c was failing to compile with CC virt_login_shell-virt-login-shell.o virt-login-shell.c: In function 'main': virt-login-shell.c:205:5: error: implicit declaration of function 'setlocale'

Re: [libvirt] [PATCH] build: fix compilation of virt-login-shell.c

2013-08-08 Thread Jim Fehlig
Eric Blake wrote: On 08/08/2013 02:04 PM, Jim Fehlig wrote: virt-login-shell.c was failing to compile with CC virt_login_shell-virt-login-shell.o virt-login-shell.c: In function 'main': virt-login-shell.c:205:5: error: implicit declaration of function 'setlocale'

Re: [libvirt] [PATCH 0/4] Fix handling of CA certificate chains

2013-08-08 Thread Eric Blake
On 08/06/2013 05:35 AM, Daniel P. Berrange wrote: This series fixes the CA certificate validation so that it correctly works when a client and server cert are both signed by intermediate CAs, sharing a common ancestor CA. After the application of this series, I'm starting to see sporadic test

[libvirt] [PATCH] tests: work with older dbus

2013-08-08 Thread Eric Blake
On RHEL 5, with dbus 1.1.2, compilation failed with: virsystemdmock.c: In function 'dbus_connection_send_with_reply_and_block': virsystemdmock.c:68: warning: implicit declaration of function 'dbus_message_set_serial' Fix this by instead bypassing all attempts to use a dbus serial. *

Re: [libvirt] [PATCH] build: fix compilation of virt-login-shell.c

2013-08-08 Thread Daniel P. Berrange
On Thu, Aug 08, 2013 at 02:28:53PM -0600, Eric Blake wrote: On 08/08/2013 02:04 PM, Jim Fehlig wrote: virt-login-shell.c was failing to compile with CC virt_login_shell-virt-login-shell.o virt-login-shell.c: In function 'main': virt-login-shell.c:205:5: error: implicit

Re: [libvirt] [PATCH] tests: work with older dbus

2013-08-08 Thread Daniel P. Berrange
On Thu, Aug 08, 2013 at 03:05:25PM -0600, Eric Blake wrote: On RHEL 5, with dbus 1.1.2, compilation failed with: virsystemdmock.c: In function 'dbus_connection_send_with_reply_and_block': virsystemdmock.c:68: warning: implicit declaration of function 'dbus_message_set_serial' Fix this by

[libvirt] [PATCH] Fix parallel runs of TLS test suites

2013-08-08 Thread Daniel P. Berrange
From: Daniel P. Berrange berra...@redhat.com Use a seperate keyfile name for the two TLS test suites so that they don't clash when running tests in parallel Signed-off-by: Daniel P. Berrange berra...@redhat.com --- tests/virnettlscontexttest.c | 10 ++ tests/virnettlshelpers.c | 6

Re: [libvirt] Updated patch for virt-login-shell for joing libvirt lxc containers.

2013-08-08 Thread Eric Blake
On 08/02/2013 09:22 AM, Daniel J Walsh wrote: Subject: [PATCH] virt-login-shell joins users into lxc container. Openshift wants to have their gears stuck into a container when they login to the system. virt-login-shell will join a running gear with the username of the person running it, or

Re: [libvirt] [PATCH] Fix parallel runs of TLS test suites

2013-08-08 Thread Eric Blake
On 08/08/2013 04:09 PM, Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com Use a seperate keyfile name for the two TLS test suites so that s/seperate/separate/ they don't clash when running tests in parallel Signed-off-by: Daniel P. Berrange berra...@redhat.com ---

Re: [libvirt] [PATCH] tests: work with older dbus

2013-08-08 Thread Eric Blake
On 08/08/2013 04:03 PM, Daniel P. Berrange wrote: On Thu, Aug 08, 2013 at 03:05:25PM -0600, Eric Blake wrote: On RHEL 5, with dbus 1.1.2, compilation failed with: virsystemdmock.c: In function 'dbus_connection_send_with_reply_and_block': virsystemdmock.c:68: warning: implicit declaration of

Re: [libvirt] [PATCH] Add a man page for virtlockd daemon

2013-08-08 Thread Eric Blake
On 08/08/2013 09:07 AM, Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com Create a virtlockd.pod.in file containing the man page content for virtlockd. Signed-off-by: Daniel P. Berrange berra...@redhat.com --- .gitignore | 2 + libvirt.spec.in

[libvirt] [PATCH] libxl: Create per-domain log file

2013-08-08 Thread Jim Fehlig
Currently, only one log file is created by the libxl driver, with all output from libxl for all domains going to this one file. Create a per-domain log file based on domain name, making sifting through the logs a bit easier. This required deferring libxl_ctx allocation until starting the domain,

Re: [libvirt] [PATCH] remote: Fix a segfault in remoteDomainCreateWithFlags

2013-08-08 Thread Alex Jia
Martin, I pushed this now. -- Regards, Alex - Original Message - From: Martin Kletzander mklet...@redhat.com To: Alex Jia a...@redhat.com Cc: libvir-list@redhat.com Sent: Thursday, August 8, 2013 8:09:57 PM Subject: Re: [libvirt] [PATCH] remote: Fix a segfault in

[libvirt] LXC: Helper function for checking ownership of dir when userns enabled

2013-08-08 Thread Chen Hanxiao
From: Chen Hanxiao chenhanx...@cn.fujitsu.com If we enable userns, the ownership of dir we provided for containers should match the uid/gid in idmap. Currently, the debug log is very implicit or misleading sometimes. This patch will help clarify this for us when using debug log or virsh.