Re: [libvirt] LXC: Helper function for checking ownership of dir when userns enabled

2013-08-09 Thread Alex Jia
On 08/09/2013 01:53 PM, Chen Hanxiao wrote: From: Chen Hanxiaochenhanx...@cn.fujitsu.com If we enable userns, the ownership of dir we provided for containers should match the uid/gid in idmap. Currently, the debug log is very implicit or misleading sometimes. This patch will help

Re: [libvirt] LXC: Helper function for checking ownership of dir when userns enabled

2013-08-09 Thread Alex Jia
On 08/09/2013 01:53 PM, Chen Hanxiao wrote: From: Chen Hanxiaochenhanx...@cn.fujitsu.com If we enable userns, the ownership of dir we provided for containers should match the uid/gid in idmap. Currently, the debug log is very implicit or misleading sometimes. This patch will help

Re: [libvirt] [PATCH] Fix parallel runs of TLS test suites

2013-08-09 Thread Martin Kletzander
On 08/09/2013 12:29 AM, Eric Blake wrote: On 08/08/2013 04:09 PM, Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com Use a seperate keyfile name for the two TLS test suites so that s/seperate/separate/ they don't clash when running tests in parallel Signed-off-by:

[libvirt] [PATCH v2]LXC: Helper function for checking ownership of dir when userns enabled

2013-08-09 Thread Chen Hanxiao
From: Chen Hanxiao chenhanx...@cn.fujitsu.com If we enable userns, the ownership of dir we provided for containers should match the uid/gid in idmap. Currently, the debug log is very implicit or misleading sometimes. This patch will help clarify this for us when using debug log or virsh. v2:

[libvirt] Hyper-V driver API version support

2013-08-09 Thread surface
Hello The version function is not supported by the hyperv driver: $ virsh --connect=hyperv://hypervhost version Compiled against library: libvirt 1.1.1 Using library: libvirt 1.1.1 Using API: Hyper-V 1.1.1 error: failed to get the hypervisor version error: this function is not supported by the

[libvirt] [PATCH v4 1/2] libxl: fix node ranges in libxlNodeGetCellsFreeMemory()

2013-08-09 Thread Dario Faggioli
introduced by cs 4b9eec50fe2c23343 (libxl: implement per NUMA node free memory reporting). What was wrong was that libxl_get_numainfo() put in nr_nodes the actual number of host NUMA nodes, not the highest node ID (like libnuma's numa_max_node() does instead). While at it, turn the failure of

[libvirt] [PATCH v4 0/2] libxl: implement some chuncks of the NUMA interface

2013-08-09 Thread Dario Faggioli
Hi and sorry for being so late at this. :-( This is the leftover of my NUMA series for the libxl driver. Basically, all the patches have been checked in but the one actually building the topology capability, which is patch 2/2 of this series. I think I addressed all Daniel's comments about

[libvirt] [PATCH v4 2/2] libxl: implement NUMA capabilities reporting

2013-08-09 Thread Dario Faggioli
Starting from Xen 4.2, libxl has all the bits and pieces in place for retrieving an adequate amount of information about the host NUMA topology. It is therefore possible, after a bit of shuffling, to arrange those information in the way libvirt wants to present them to the outside world.

Re: [libvirt] [PATCH] Fix parallel runs of TLS test suites

2013-08-09 Thread Daniel P. Berrange
On Fri, Aug 09, 2013 at 09:53:30AM +0200, Martin Kletzander wrote: On 08/09/2013 12:29 AM, Eric Blake wrote: On 08/08/2013 04:09 PM, Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com Use a seperate keyfile name for the two TLS test suites so that

Re: [libvirt] [PATCH] libxl: Create per-domain log file

2013-08-09 Thread Dario Faggioli
On gio, 2013-08-08 at 17:41 -0600, Jim Fehlig wrote: Currently, only one log file is created by the libxl driver, with all output from libxl for all domains going to this one file. Create a per-domain log file based on domain name, making sifting through the logs a bit easier. That is

[libvirt] [test-API][PATCH] Add network update test case

2013-08-09 Thread hongming zhang
The patch add network update test case to cover network update api. modified: cases/basic_network.conf - The test suite covers add/modify/delete ip-dhcp-host in network. For other test scenario, they can be test via customing the conf file. new file: repos/network/update.py - So far the network

Re: [libvirt] Hyper-V driver API version support

2013-08-09 Thread Daniel P. Berrange
On Fri, Aug 09, 2013 at 10:13:03AM +0200, surf...@me.is-a-linux-user.org wrote: Hello The version function is not supported by the hyperv driver: $ virsh --connect=hyperv://hypervhost version Compiled against library: libvirt 1.1.1 Using library: libvirt 1.1.1 Using API: Hyper-V 1.1.1

[libvirt] [libvirt-sandbox][PATCH 0/2] Fix some issues in virt-sandbox-service

2013-08-09 Thread Alex Jia
Alex Jia (2): Fix logical judgement in get_name Raise clear error message if no legacy configuration bin/virt-sandbox-service | 11 +-- 1 file changed, 9 insertions(+), 2 deletions(-) -- 1.8.3.1 -- libvir-list mailing list libvir-list@redhat.com

[libvirt] [libvirt-sandbox][PATCH 1/2] Fix logical judgement in get_name

2013-08-09 Thread Alex Jia
Signed-off-by: Alex Jia a...@redhat.com --- bin/virt-sandbox-service | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/bin/virt-sandbox-service b/bin/virt-sandbox-service index 03873c9..26b4a40 100755 --- a/bin/virt-sandbox-service +++ b/bin/virt-sandbox-service @@

[libvirt] [libvirt-sandbox][PATCH 2/2] Raise clear error message if no legacy configuration

2013-08-09 Thread Alex Jia
Signed-off-by: Alex Jia a...@redhat.com --- bin/virt-sandbox-service | 3 +++ 1 file changed, 3 insertions(+) diff --git a/bin/virt-sandbox-service b/bin/virt-sandbox-service index 26b4a40..cb40f6a 100755 --- a/bin/virt-sandbox-service +++ b/bin/virt-sandbox-service @@ -965,6 +965,9 @@ def

Re: [libvirt] [libvirt-sandbox][PATCH 1/2] Fix logical judgement in get_name

2013-08-09 Thread Daniel P. Berrange
On Fri, Aug 09, 2013 at 06:26:46PM +0800, Alex Jia wrote: Please explain the scenario where you hit the flaw in the commit message. I can see what you've changed, but I don't see why you have changed it. The commit message must describe the 'why'. Signed-off-by: Alex Jia a...@redhat.com ---

Re: [libvirt] [libvirt-sandbox][PATCH 2/2] Raise clear error message if no legacy configuration

2013-08-09 Thread Daniel P. Berrange
On Fri, Aug 09, 2013 at 06:26:47PM +0800, Alex Jia wrote: Signed-off-by: Alex Jia a...@redhat.com --- bin/virt-sandbox-service | 3 +++ 1 file changed, 3 insertions(+) diff --git a/bin/virt-sandbox-service b/bin/virt-sandbox-service index 26b4a40..cb40f6a 100755 ---

Re: [libvirt] [libvirt-sandbox][PATCH 2/2] Raise clear error message if no legacy configuration

2013-08-09 Thread Alex Jia
On 08/09/2013 06:30 PM, Daniel P. Berrange wrote: On Fri, Aug 09, 2013 at 06:26:47PM +0800, Alex Jia wrote: Signed-off-by: Alex Jiaa...@redhat.com --- bin/virt-sandbox-service | 3 +++ 1 file changed, 3 insertions(+) diff --git a/bin/virt-sandbox-service b/bin/virt-sandbox-service index

Re: [libvirt] [libvirt-sandbox][PATCH 1/2] Fix logical judgement in get_name

2013-08-09 Thread Alex Jia
On 08/09/2013 06:29 PM, Daniel P. Berrange wrote: On Fri, Aug 09, 2013 at 06:26:46PM +0800, Alex Jia wrote: Please explain the scenario where you hit the flaw in the commit message. I can see what you've changed, but I don't see why you have changed it. The commit message must describe the

[libvirt] [libvirt-sandbox][PATCH v2] Fix logical judgement in get_name

2013-08-09 Thread Alex Jia
As usual, this issue can't be hit, but from codes point of view, if deliberately remove 'name' in the configuration, and then the 'Name not congfigured' error message can't be raised unless the configuration file doesn't exist, in fact, the get_name() will directly return None without expected

Re: [libvirt] Updated patch for virt-login-shell for joing libvirt lxc containers.

2013-08-09 Thread John Ferlan
On 08/02/2013 11:22 AM, Daniel J Walsh wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 THis patch fixes all of Eric's and Daniels comments. [PATCH] virt-login-shell joins users into lxc container. -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.14 (GNU/Linux) Comment: Using GnuPG

[libvirt] [PATCH] Fix double-free and broken logic in virt-login-shell

2013-08-09 Thread Daniel P. Berrange
From: Daniel P. Berrange berra...@redhat.com The virLoginShellAllowedUser method must not free the 'groups' parameter it is given, as that is owned by the caller. The virLoginShellAllowedUser method should be checking '!*ptr' (ie empty string) rather than '!ptr' (NULL string) since the latter

Re: [libvirt] [PATCH] Fix double-free and broken logic in virt-login-shell

2013-08-09 Thread John Ferlan
On 08/09/2013 07:01 AM, Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com The virLoginShellAllowedUser method must not free the 'groups' parameter it is given, as that is owned by the caller. The virLoginShellAllowedUser method should be checking '!*ptr' (ie empty

Re: [libvirt] Updated patch for virt-login-shell for joing libvirt lxc containers.

2013-08-09 Thread Daniel P. Berrange
On Fri, Aug 09, 2013 at 06:51:25AM -0400, John Ferlan wrote: On 08/02/2013 11:22 AM, Daniel J Walsh wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 THis patch fixes all of Eric's and Daniels comments. [PATCH] virt-login-shell joins users into lxc container. -BEGIN PGP

[libvirt] [PATCH] virnettlscontext: Resolve Coverity warnings (UNINIT)

2013-08-09 Thread John Ferlan
Coverity complained about the usage of the uninitialized cacerts in the event(s) that access(certFile, R_OK) and/or access(cacertFile, R_OK) fail the for loop used to fill in the certs will have indeterminate data as well as the possibility that both failures would result in the

Re: [libvirt] [PATCH] virnettlscontext: Resolve Coverity warnings (UNINIT)

2013-08-09 Thread Daniel P. Berrange
On Fri, Aug 09, 2013 at 07:19:18AM -0400, John Ferlan wrote: Coverity complained about the usage of the uninitialized cacerts in the event(s) that access(certFile, R_OK) and/or access(cacertFile, R_OK) fail the for loop used to fill in the certs will have indeterminate data as well as the

Re: [libvirt] [PATCH] Fix double-free and broken logic in virt-login-shell

2013-08-09 Thread Eric Blake
On 08/09/2013 05:01 AM, Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com The virLoginShellAllowedUser method must not free the 'groups' parameter it is given, as that is owned by the caller. The virLoginShellAllowedUser method should be checking '!*ptr' (ie empty

Re: [libvirt] [PATCH] Fix double-free and broken logic in virt-login-shell

2013-08-09 Thread Daniel P. Berrange
On Fri, Aug 09, 2013 at 06:27:36AM -0600, Eric Blake wrote: On 08/09/2013 05:01 AM, Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com The virLoginShellAllowedUser method must not free the 'groups' parameter it is given, as that is owned by the caller. The

Re: [libvirt] Updated patch for virt-login-shell for joing libvirt lxc containers.

2013-08-09 Thread Eric Blake
On 08/09/2013 04:51 AM, John Ferlan wrote: 88if (!ptr) (4) Event dead_error_line:Execution cannot reach this statement continue;. Also see events: [assignment][notnull][dead_error_condition] 89continue; Did you perhaps

Re: [libvirt] [PATCH] Add an example config file for virtlockd

2013-08-09 Thread Eric Blake
On 08/08/2013 09:08 AM, Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com The virtlockd daemon supports an /etc/libvirt/virtlockd.conf config file, but we never installed a default config, nor created any augeas scripts. This change addresses that omission.

Re: [libvirt] [PATCH] libxl: Create per-domain log file

2013-08-09 Thread Michal Privoznik
On 09.08.2013 01:41, Jim Fehlig wrote: Currently, only one log file is created by the libxl driver, with all output from libxl for all domains going to this one file. Create a per-domain log file based on domain name, making sifting through the logs a bit easier. This required deferring

Re: [libvirt] [PATCH] Add documentation for access control system

2013-08-09 Thread Michal Privoznik
On 08.08.2013 13:27, Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com This adds two new pages to the website, acl.html describing the general access control framework and permissions models, and aclpolkit.html describing the use of polkit as an access control driver.

[libvirt] [PATCH] qemu: Drop qemuDomainMemoryLimit

2013-08-09 Thread Michal Privoznik
This function is to guess the correct limit for maximal memory usage by qemu for given domain. This can never be guessed correctly, not to mention all the pains and sleepless nights this code has caused. Once somebody discovers algorithm to solve the Halting Problem, we can compute the limit

Re: [libvirt] [PATCH] qemu: Drop qemuDomainMemoryLimit

2013-08-09 Thread Eric Blake
On 08/09/2013 06:56 AM, Michal Privoznik wrote: This function is to guess the correct limit for maximal memory usage by qemu for given domain. This can never be guessed correctly, not to mention all the pains and sleepless nights this code has caused. Once somebody discovers algorithm to solve

Re: [libvirt] [PATCH] qemu: Drop qemuDomainMemoryLimit

2013-08-09 Thread Daniel P. Berrange
On Fri, Aug 09, 2013 at 07:13:58AM -0600, Eric Blake wrote: On 08/09/2013 06:56 AM, Michal Privoznik wrote: This function is to guess the correct limit for maximal memory usage by qemu for given domain. This can never be guessed correctly, not to mention all the pains and sleepless nights

[libvirt] [PATCH] qemu: Drop qemuDomainMemoryLimit

2013-08-09 Thread Michal Privoznik
This function is to guess the correct limit for maximal memory usage by qemu for given domain. This can never be guessed correctly, not to mention all the pains and sleepless nights this code has caused. Once somebody discovers algorithm to solve the Halting Problem, we can compute the limit

Re: [libvirt] [PATCH] qemu: Drop qemuDomainMemoryLimit

2013-08-09 Thread Michal Privoznik
[CC'ing qemu-devel list] On 09.08.2013 15:17, Daniel P. Berrange wrote: On Fri, Aug 09, 2013 at 07:13:58AM -0600, Eric Blake wrote: On 08/09/2013 06:56 AM, Michal Privoznik wrote: This function is to guess the correct limit for maximal memory usage by qemu for given domain. This can never be

[libvirt] [PATCH] tests: avoid too-large constants

2013-08-09 Thread Eric Blake
Compiling with gcc 4.1.2 (RHEL 5) complains: virdbustest.c: In function 'testMessageSimple': virdbustest.c:61: warning: integer constant is too large for 'long' type virdbustest.c:62: warning: integer constant is too large for 'long' type virdbustest.c: In function 'testMessageArray':

Re: [libvirt] [PATCH] tests: avoid too-large constants

2013-08-09 Thread Daniel P. Berrange
On Fri, Aug 09, 2013 at 07:45:16AM -0600, Eric Blake wrote: Compiling with gcc 4.1.2 (RHEL 5) complains: virdbustest.c: In function 'testMessageSimple': virdbustest.c:61: warning: integer constant is too large for 'long' type virdbustest.c:62: warning: integer constant is too large for

Re: [libvirt] Proposing Archive / Unarchive VM Guest functionality.

2013-08-09 Thread Daniel P. Berrange
On Fri, Aug 09, 2013 at 06:39:34PM +0530, Suhas Mane wrote: Hello Team, Me and few of my friends are planning to add VM Guest archival functionality. What we are proposing is: 1. Below diagram shows: possible states of VM guest (*archived new state introduced*) 2. For any reason, User /

Re: [libvirt] [PATCH] tests: avoid too-large constants

2013-08-09 Thread Eric Blake
On 08/09/2013 07:53 AM, Daniel P. Berrange wrote: On Fri, Aug 09, 2013 at 07:45:16AM -0600, Eric Blake wrote: Compiling with gcc 4.1.2 (RHEL 5) complains: virdbustest.c: In function 'testMessageSimple': virdbustest.c:61: warning: integer constant is too large for 'long' type

Re: [libvirt] [PATCH] libxl: Create per-domain log file

2013-08-09 Thread Jim Fehlig
Michal Privoznik wrote: On 09.08.2013 01:41, Jim Fehlig wrote: Currently, only one log file is created by the libxl driver, with all output from libxl for all domains going to this one file. Create a per-domain log file based on domain name, making sifting through the logs a bit easier.

Re: [libvirt] [PATCH] libxl: Create per-domain log file

2013-08-09 Thread Jim Fehlig
Dario Faggioli wrote: On gio, 2013-08-08 at 17:41 -0600, Jim Fehlig wrote: Currently, only one log file is created by the libxl driver, with all output from libxl for all domains going to this one file. Create a per-domain log file based on domain name, making sifting through the logs a

Re: [libvirt] Hyper-V driver API version support

2013-08-09 Thread surface
On Fri, Aug 09, 2013 at 10:13:03AM +0200, surf...@me.is-a-linux-user.org wrote: Hello The version function is not supported by the hyperv driver: $ virsh --connect=hyperv://hypervhost version Compiled against library: libvirt 1.1.1 Using library: libvirt 1.1.1 Using API: Hyper-V 1.1.1 error:

Re: [libvirt] [PATCHv3] build: avoid -lgcrypt with newer gnutls

2013-08-09 Thread Eric Blake
On 08/07/2013 08:15 AM, Eric Blake wrote: On 08/07/2013 07:29 AM, Doug Goldstein wrote: On Tue, Jul 30, 2013 at 3:45 PM, Eric Blake ebl...@redhat.com wrote: https://bugzilla.redhat.com/show_bug.cgi?id=951637 Newer gnutls uses nettle, rather than gcrypt, which is a lot nicer regarding

Re: [libvirt] [PATCHv3] build: more workarounds for if_bridge.h

2013-08-09 Thread Daniel P. Berrange
On Wed, Aug 07, 2013 at 05:10:26PM -0600, Eric Blake wrote: This is a second attempt at fixing the problem first attempted in commit 2df8d99; basically undoing the fact that it was reverted in commit 43cee32f, plus fixing two more issues: the code in configure.ac has to EXACTLY match

Re: [libvirt] [PATCHv3] build: avoid -lgcrypt with newer gnutls

2013-08-09 Thread Daniel P. Berrange
On Fri, Aug 09, 2013 at 09:31:39AM -0600, Eric Blake wrote: On 08/07/2013 08:15 AM, Eric Blake wrote: On 08/07/2013 07:29 AM, Doug Goldstein wrote: On Tue, Jul 30, 2013 at 3:45 PM, Eric Blake ebl...@redhat.com wrote: https://bugzilla.redhat.com/show_bug.cgi?id=951637 Newer gnutls uses

Re: [libvirt] [PATCH] Add documentation for access control system

2013-08-09 Thread Eric Blake
On 08/08/2013 05:27 AM, Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com This adds two new pages to the website, acl.html describing the general access control framework and permissions models, and aclpolkit.html describing the use of polkit as an access control

Re: [libvirt] [PATCH] Add documentation for access control system

2013-08-09 Thread Daniel P. Berrange
On Fri, Aug 09, 2013 at 09:47:46AM -0600, Eric Blake wrote: On 08/08/2013 05:27 AM, Daniel P. Berrange wrote: +aclperms.htmlinc: $(top_srcdir)/src/access/viraccessperm.h \ +genaclperms.pl Makefile.am + $(PERL) genaclperms.pl $ $@ Did you test a VPATH build? No, but I will do.

Re: [libvirt] [PATCH] Add documentation for access control system

2013-08-09 Thread Eric Blake
On 08/09/2013 09:51 AM, Daniel P. Berrange wrote: This function has no return statement when the initial 'if' is not satisfied; is that valid? Yeah, it will just carry on with other polkit rules that are defined in other files, eventually fallback back to the default policy defined for

Re: [libvirt] [Qemu-devel] [PATCH] qemu: Drop qemuDomainMemoryLimit

2013-08-09 Thread Anthony Liguori
Michal Privoznik mpriv...@redhat.com writes: [CC'ing qemu-devel list] On 09.08.2013 15:17, Daniel P. Berrange wrote: On Fri, Aug 09, 2013 at 07:13:58AM -0600, Eric Blake wrote: On 08/09/2013 06:56 AM, Michal Privoznik wrote: This function is to guess the correct limit for maximal memory

Re: [libvirt] [PATCHv3] build: more workarounds for if_bridge.h

2013-08-09 Thread Eric Blake
On 08/09/2013 09:38 AM, Daniel P. Berrange wrote: On Wed, Aug 07, 2013 at 05:10:26PM -0600, Eric Blake wrote: This is a second attempt at fixing the problem first attempted in commit 2df8d99; basically undoing the fact that it was reverted in commit 43cee32f, plus fixing two more issues: the

Re: [libvirt] [PATCH v4 1/2] libxl: fix node ranges in libxlNodeGetCellsFreeMemory()

2013-08-09 Thread Jim Fehlig
Dario Faggioli wrote: introduced by cs 4b9eec50fe2c23343 (libxl: implement per NUMA node free memory reporting). What was wrong was that libxl_get_numainfo() put in nr_nodes the actual number of host NUMA nodes, not the highest node ID (like libnuma's numa_max_node() does instead). Ok,

Re: [libvirt] Hyper-V driver API version support

2013-08-09 Thread Matthias Bolte
2013/8/9 surf...@me.is-a-linux-user.org: On Fri, Aug 09, 2013 at 10:13:03AM +0200, surf...@me.is-a-linux-user.org wrote: Hello The version function is not supported by the hyperv driver: $ virsh --connect=hyperv://hypervhost version Compiled against library: libvirt 1.1.1 Using library:

[libvirt] [PATCH] Fix VPATH build of ACL docs

2013-08-09 Thread Daniel P. Berrange
From: Daniel P. Berrange berra...@redhat.com The aclperms.htmlinc file must be generated in $(srcdir) to let includes work when doing a VPATH build Signed-off-by: Daniel P. Berrange berra...@redhat.com --- docs/Makefile.am | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff

Re: [libvirt] Hyper-V driver API version support

2013-08-09 Thread Daniel P. Berrange
On Fri, Aug 09, 2013 at 06:08:38PM +0200, Matthias Bolte wrote: 2013/8/9 surf...@me.is-a-linux-user.org: On Fri, Aug 09, 2013 at 10:13:03AM +0200, surf...@me.is-a-linux-user.org wrote: Hello The version function is not supported by the hyperv driver: $ virsh

Re: [libvirt] [PATCH] Fix VPATH build of ACL docs

2013-08-09 Thread Eric Blake
On 08/09/2013 10:09 AM, Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com The aclperms.htmlinc file must be generated in $(srcdir) to let includes work when doing a VPATH build Signed-off-by: Daniel P. Berrange berra...@redhat.com --- docs/Makefile.am | 10

Re: [libvirt] [PATCH] Fix VPATH build of ACL docs

2013-08-09 Thread Daniel P. Berrange
On Fri, Aug 09, 2013 at 05:09:34PM +0100, Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com The aclperms.htmlinc file must be generated in $(srcdir) to let includes work when doing a VPATH build Signed-off-by: Daniel P. Berrange berra...@redhat.com ---

Re: [libvirt] [Qemu-devel] [PATCH] qemu: Drop qemuDomainMemoryLimit

2013-08-09 Thread Daniel P. Berrange
On Fri, Aug 09, 2013 at 10:58:55AM -0500, Anthony Liguori wrote: Michal Privoznik mpriv...@redhat.com writes: [CC'ing qemu-devel list] On 09.08.2013 15:17, Daniel P. Berrange wrote: On Fri, Aug 09, 2013 at 07:13:58AM -0600, Eric Blake wrote: On 08/09/2013 06:56 AM, Michal Privoznik

Re: [libvirt] [Qemu-devel] [PATCH] qemu: Drop qemuDomainMemoryLimit

2013-08-09 Thread Andreas Färber
Am 09.08.2013 17:58, schrieb Anthony Liguori: Even if we had an algorithm for calculating memory overhead (we don't), glibc will still introduce uncertainty since malloc(size) doesn't translate to allocating size bytes from the kernel. When you throw in fragmentation too it becomes extremely

Re: [libvirt] [PATCH] libxl: Create per-domain log file

2013-08-09 Thread Daniel P. Berrange
On Thu, Aug 08, 2013 at 05:41:26PM -0600, Jim Fehlig wrote: Currently, only one log file is created by the libxl driver, with all output from libxl for all domains going to this one file. Create a per-domain log file based on domain name, making sifting through the logs a bit easier. This

Re: [libvirt] Hyper-V driver API version support

2013-08-09 Thread Matthias Bolte
2013/8/9 Daniel P. Berrange berra...@redhat.com: On Fri, Aug 09, 2013 at 06:08:38PM +0200, Matthias Bolte wrote: 2013/8/9 surf...@me.is-a-linux-user.org: On Fri, Aug 09, 2013 at 10:13:03AM +0200, surf...@me.is-a-linux-user.org wrote: Hello The version function is not supported by

Re: [libvirt] [PATCH] libxl: Create per-domain log file

2013-08-09 Thread Daniel P. Berrange
On Fri, Aug 09, 2013 at 10:48:52AM -0600, Jim Fehlig wrote: Daniel P. Berrange wrote: On Thu, Aug 08, 2013 at 05:41:26PM -0600, Jim Fehlig wrote: Currently, only one log file is created by the libxl driver, with all output from libxl for all domains going to this one file. Create a

Re: [libvirt] [PATCH v2]LXC: Helper function for checking ownership of dir when userns enabled

2013-08-09 Thread Daniel P. Berrange
On Fri, Aug 09, 2013 at 04:05:58PM +0800, Chen Hanxiao wrote: From: Chen Hanxiao chenhanx...@cn.fujitsu.com If we enable userns, the ownership of dir we provided for containers should match the uid/gid in idmap. Currently, the debug log is very implicit or misleading sometimes. This patch

Re: [libvirt] [PATCH] libxl: Create per-domain log file

2013-08-09 Thread Eric Blake
On 08/09/2013 10:50 AM, Daniel P. Berrange wrote: I should have looked at the xen code closer. Seems libxl doesn't cope well with a NULL logger :(. Hmm, should the logger for this driver-wide ctx (used for getting libxl version and the like, no domain ops) just dump messages to /dev/null or

Re: [libvirt] [PATCH 01/10] test: Split object parsing into their own functions

2013-08-09 Thread Daniel P. Berrange
On Wed, Aug 07, 2013 at 07:28:55PM -0400, Cole Robinson wrote: The function that parses custom driver XML was getting pretty unruly, split the object parsing into their own functions. Rename some variables to be consistent across each function. This should be functionally identical. ---

Re: [libvirt] [PATCH 02/10] test: Simplify args passed to testDomainStartState

2013-08-09 Thread Daniel P. Berrange
On Wed, Aug 07, 2013 at 07:28:56PM -0400, Cole Robinson wrote: Passing virConnectPtr is redundant, just pass testConnPtr and simplify certain callers. --- src/test/test_driver.c | 36 +--- 1 file changed, 17 insertions(+), 19 deletions(-) ACK Daniel -- |:

Re: [libvirt] [PATCH 03/10] test: Unify object XML parsing

2013-08-09 Thread Daniel P. Berrange
On Wed, Aug 07, 2013 at 07:28:57PM -0400, Cole Robinson wrote: Right now things are split a bit between parsing from a relative file path or parsing from inline XML. Unify it. This will simplify upcoming bits. --- src/test/test_driver.c | 236

Re: [libvirt] [PATCH 04/10] test: Allow specifying object runstate in driver XML

2013-08-09 Thread Daniel P. Berrange
On Wed, Aug 07, 2013 at 07:28:58PM -0400, Cole Robinson wrote: When passing in custom driver XML, allow a block like domain ... testdriver runstate3/runstate /testdriver /domain This is only read at initial driver start time, and sets the initial run state of the object.

Re: [libvirt] [PATCH 07/10] snapshot_conf: Allow parsing an XML node

2013-08-09 Thread Daniel P. Berrange
On Wed, Aug 07, 2013 at 07:29:01PM -0400, Cole Robinson wrote: Similar to how other objects arrange their parse APIs. This will be used by the test driver. --- src/conf/snapshot_conf.c | 85 ++-- src/conf/snapshot_conf.h | 6 2 files

Re: [libvirt] [PATCH 00/10] test: Mock snapshot APIs and misc improvements

2013-08-09 Thread Daniel P. Berrange
On Wed, Aug 07, 2013 at 07:28:54PM -0400, Cole Robinson wrote: This series implements snapshot APIs for the test driver, and adds some misc improvements, like specifying domain state in the passed in driver XML. Good addition, the test driver would be usefully put to work in a unit test to

Re: [libvirt] [PATCH] libxl: Create per-domain log file

2013-08-09 Thread Daniel P. Berrange
On Fri, Aug 09, 2013 at 10:56:41AM -0600, Eric Blake wrote: On 08/09/2013 10:50 AM, Daniel P. Berrange wrote: I should have looked at the xen code closer. Seems libxl doesn't cope well with a NULL logger :(. Hmm, should the logger for this driver-wide ctx (used for getting libxl

Re: [libvirt] [PATCH] libxl: Create per-domain log file

2013-08-09 Thread Jim Fehlig
Daniel P. Berrange wrote: On Thu, Aug 08, 2013 at 05:41:26PM -0600, Jim Fehlig wrote: Currently, only one log file is created by the libxl driver, with all output from libxl for all domains going to this one file. Create a per-domain log file based on domain name, making sifting through

[libvirt] [PATCH] Make check for /dev/loop device names stricter to avoid /dev/loop-control

2013-08-09 Thread Daniel P. Berrange
From: Daniel P. Berrange berra...@redhat.com Recentish (2011) kernels introduced a new device called /dev/loop-control, which causes libvirt's detection of loop devices to get confused since it only checks for a prefix of 'loop'. Also check that the next character is a digit Signed-off-by:

Re: [libvirt] [PATCH] libxl: Create per-domain log file

2013-08-09 Thread Jim Fehlig
Daniel P. Berrange wrote: On Fri, Aug 09, 2013 at 10:56:41AM -0600, Eric Blake wrote: On 08/09/2013 10:50 AM, Daniel P. Berrange wrote: I should have looked at the xen code closer. Seems libxl doesn't cope well with a NULL logger :(. Hmm, should the logger for this driver-wide

Re: [libvirt] [PATCH] libxl: Create per-domain log file

2013-08-09 Thread Eric Blake
On 08/09/2013 11:04 AM, Daniel P. Berrange wrote: On Fri, Aug 09, 2013 at 10:56:41AM -0600, Eric Blake wrote: On 08/09/2013 10:50 AM, Daniel P. Berrange wrote: I should have looked at the xen code closer. Seems libxl doesn't cope well with a NULL logger :(. Hmm, should the logger for this

Re: [libvirt] [PATCH] Make check for /dev/loop device names stricter to avoid /dev/loop-control

2013-08-09 Thread Eric Blake
On 08/09/2013 10:45 AM, Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com Recentish (2011) kernels introduced a new device called /dev/loop-control, which causes libvirt's detection of loop devices to get confused since it only checks for a prefix of 'loop'. Also check

[libvirt] [PATCH] virsh: nicer abort of blockcopy

2013-08-09 Thread Eric Blake
I attempted 'virsh blockcopy $dom vda $path --wait --verbose', then hit Ctrl-C; I was a bit surprised to see this error message: Block Copy: [ 3 %]error: failed to query job for disk vda when I had been expecting: Block Copy: [ 3 %] Copy aborted * tools/virsh-domain.c (cmdBlockCopy): Print

[libvirt] [PATCH] libxl: fix libvirtd segfault

2013-08-09 Thread Jim Fehlig
Commit d72ef888 introduced a bug in the libxl driver that will segfault libvirtd if libxl reports an error message, e.g. when attempting to initialize the driver on a non-Xen system. I assumed it was valid to pass a NULL logger to libxl_ctx_alloc(), but that is not the case since any errors

Re: [libvirt] [PATCH] libxl: Create per-domain log file

2013-08-09 Thread Jim Fehlig
Daniel P. Berrange wrote: On Thu, Aug 08, 2013 at 05:41:26PM -0600, Jim Fehlig wrote: Currently, only one log file is created by the libxl driver, with all output from libxl for all domains going to this one file. Create a per-domain log file based on domain name, making sifting through

Re: [libvirt] [PATCH] libxl: fix libvirtd segfault

2013-08-09 Thread Dave Allan
Functional ack; this patch fixes the crash on my system. On Fri, Aug 09, 2013 at 05:58:45PM -0600, Jim Fehlig wrote: Commit d72ef888 introduced a bug in the libxl driver that will segfault libvirtd if libxl reports an error message, e.g. when attempting to initialize the driver on a non-Xen

Re: [libvirt] [PATCH] remote: Fix a segfault in remoteDomainCreateWithFlags

2013-08-09 Thread Doug Goldstein
On Thu, Aug 8, 2013 at 10:05 PM, Alex Jia a...@redhat.com wrote: Martin, I pushed this now. -- Regards, Alex Pushed to v1.1.1-maint -- Doug Goldstein -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCHv3] build: avoid -lgcrypt with newer gnutls

2013-08-09 Thread Doug Goldstein
On Fri, Aug 9, 2013 at 10:31 AM, Eric Blake ebl...@redhat.com wrote: On 08/07/2013 08:15 AM, Eric Blake wrote: On 08/07/2013 07:29 AM, Doug Goldstein wrote: On Tue, Jul 30, 2013 at 3:45 PM, Eric Blake ebl...@redhat.com wrote: https://bugzilla.redhat.com/show_bug.cgi?id=951637 Newer gnutls

Re: [libvirt] [PATCH] libxl: fix libvirtd segfault

2013-08-09 Thread Jim Fehlig
Dave Allan wrote: Functional ack; this patch fixes the crash on my system. I've pushed this patch since it fixes a crash affecting everyone that has built the libxl driver but not actually running Xen. Any additional review comments can be addressed with a follow-up patch. Regards, Jim