On 08/13/2013 04:20 AM, Eric Blake wrote:
On 08/09/2013 03:23 AM, Daniel P. Berrange wrote:
Anyway, why I'm saying this is that one more filename should be renamed
in order to avoid a race (which I was unable to reproduce, though).
I have reproduced the race.
ACK, yes this is also
controller type='pci' index='0' model='pci-root' pcihole64='1'/
It can be used to adjust (or disable) the size of the 64-bit
PCI hole. The size attribute is in gigabytes, since it would
get rounded up to nearest GB by QEMU anyway.
Disabling it will be needed for guests that crash with the
64-bit
QEMU commit 3984890 introduced the pci-hole64-size property,
to i440FX-pcihost and q35-pcihost with a default setting of 2 GB.
Translate controller ... pcihole64='x'/ to:
-global q35-pcihost.pci-hole64-size=x for q35 machines and
-global i440FX-pcihost.pci-hole64-size=x for i440FX-based machines.
v2:
Use 'pcihole64' attribute of the root PCI controller
instead of pcihole64 element in domain features.
v1:
https://www.redhat.com/archives/libvir-list/2013-August/msg00510.html
https://bugzilla.redhat.com/show_bug.cgi?id=990418
Ján Tomko (2):
Add pcihole64 attribute to root PCI controllers
On Mon, Aug 12, 2013 at 10:13:07PM +0200, Guido Günther wrote:
On Mon, Aug 12, 2013 at 01:21:08PM -0600, Eric Blake wrote:
On 08/12/2013 01:14 PM, Guido Günther wrote:
otherwise we fail like:
CCLD virdbustest
/usr/bin/ld: virdbustest-virdbustest.o: undefined reference
On Tue, Aug 13, 2013 at 10:51:04AM +0200, Ján Tomko wrote:
controller type='pci' index='0' model='pci-root' pcihole64='1'/
It can be used to adjust (or disable) the size of the 64-bit
PCI hole. The size attribute is in gigabytes, since it would
get rounded up to nearest GB by QEMU anyway.
To avoid having to assign a failure code to the returned variable switch
this function to negative logic. This will fix issue with invalid number
of cpus returning success return code.
https://bugzilla.redhat.com/show_bug.cgi?id=996466
---
tools/virsh-domain.c | 17 -
1 file
Signed-off-by: Yanbing Du y...@redhat.com
---
tools/virsh-domain.c |6 ++
1 files changed, 6 insertions(+), 0 deletions(-)
diff --git a/tools/virsh-domain.c b/tools/virsh-domain.c
index 4081451..9ccbc35 100644
--- a/tools/virsh-domain.c
+++ b/tools/virsh-domain.c
@@ -9139,6 +9139,12 @@
On 08/13/2013 10:55 AM, Daniel P. Berrange wrote:
On Tue, Aug 13, 2013 at 10:51:04AM +0200, Ján Tomko wrote:
controller type='pci' index='0' model='pci-root' pcihole64='1'/
It can be used to adjust (or disable) the size of the 64-bit
PCI hole. The size attribute is in gigabytes, since it
On Tue, Aug 13, 2013 at 11:53:42AM +0200, Ján Tomko wrote:
On 08/13/2013 10:55 AM, Daniel P. Berrange wrote:
On Tue, Aug 13, 2013 at 10:51:04AM +0200, Ján Tomko wrote:
controller type='pci' index='0' model='pci-root' pcihole64='1'/
It can be used to adjust (or disable) the size of the
On 08/13/2013 11:22 AM, Peter Krempa wrote:
To avoid having to assign a failure code to the returned variable switch
this function to negative logic. This will fix issue with invalid number
of cpus returning success return code.
https://bugzilla.redhat.com/show_bug.cgi?id=996466
---
On 08/13/2013 11:54 AM, Daniel P. Berrange wrote:
On Tue, Aug 13, 2013 at 11:53:42AM +0200, Ján Tomko wrote:
On 08/13/2013 10:55 AM, Daniel P. Berrange wrote:
On Tue, Aug 13, 2013 at 10:51:04AM +0200, Ján Tomko wrote:
controller type='pci' index='0' model='pci-root' pcihole64='1'/
It can be
On Tue, Aug 13, 2013 at 12:24:51PM +0200, Ján Tomko wrote:
On 08/13/2013 11:54 AM, Daniel P. Berrange wrote:
On Tue, Aug 13, 2013 at 11:53:42AM +0200, Ján Tomko wrote:
On 08/13/2013 10:55 AM, Daniel P. Berrange wrote:
On Tue, Aug 13, 2013 at 10:51:04AM +0200, Ján Tomko wrote:
controller
From: Daniel P. Berrange berra...@redhat.com
Address a number of code, style and docs issues identified
in review of virt-login-shell after it was merged.
Signed-off-by: Daniel P. Berrange berra...@redhat.com
---
tools/Makefile.am | 1 -
tools/virt-login-shell.c | 58
From: Daniel P. Berrange berra...@redhat.com
The virtlockd/libvirtd daemons had listed '?' as the short option
for --help. getopt_long uses '?' for any unknown option. We want
to be able to distinguish unknown options (which use EXIT_FAILURE)
from correct usage of help (which should use
From: Fred A. Kemp ano...@riseup.net
Allow use of the usb-storage device only if the new capability flag
QEMU_CAPS_DEVICE_USB_STORAGE is set, which it is for qemu(-kvm)
versions = 0.12.1.2-rhel62-beta.
---
src/qemu/qemu_capabilities.c |2 ++
src/qemu/qemu_capabilities.h |1 +
From: Fred A. Kemp ano...@riseup.net
Add an attribute named 'removable' to the 'target' element of disks,
which controls the removable flag. For instance, on a Linux guest it
controls the value of /sys/block/$dev/removable. This option is only
valid for USB disks (i.e. bus='usb'), and its default
From: Fred A. Kemp ano...@riseup.net
The commit message of patch #2 explains the purpose of this patch set.
A review would be greatly appreciated!
Note that I've only added the new capability for usb-storage.removable
to the qemu help tests of qemu(-kvm) version 1.2.0, since that's what I
had
Eric Blake wrote:
Does this patch still apply as is?
No, so I just re-submitted a rebased patch-set:
http://www.redhat.com/archives/libvir-list/2013-August/msg00581.html
It should be noted that my patches constantly gets in a conflicting
state versus your master since they add capabilities,
On Tue, Aug 13, 2013 at 09:51:22AM +0100, Daniel P. Berrange wrote:
On Mon, Aug 12, 2013 at 10:13:07PM +0200, Guido Günther wrote:
On Mon, Aug 12, 2013 at 01:21:08PM -0600, Eric Blake wrote:
On 08/12/2013 01:14 PM, Guido Günther wrote:
otherwise we fail like:
CCLD
On 08/13/13 12:03, Ján Tomko wrote:
On 08/13/2013 11:22 AM, Peter Krempa wrote:
To avoid having to assign a failure code to the returned variable switch
this function to negative logic. This will fix issue with invalid number
of cpus returning success return code.
On 08/12/2013 11:54 PM, Guido Günther wrote:
The Linux build revealed another missing direkt link target, this time
s/direkt/direct/
against selinux libs:
http://honk.sigxcpu.org:8001/view/libvirt/job/libvirt-build-debian-sid-amd64/9/console
---
Sorry for missing this in the
From: Daniel P. Berrange berra...@redhat.com
The lxcContainerMountFSBlockAuto method can be used to mount the
initial root filesystem, so it cannot assume a prefix of /.oldroot.
Signed-off-by: Daniel P. Berrange berra...@redhat.com
---
src/lxc/lxc_container.c | 14 --
1 file
On 08/13/2013 05:16 AM, Daniel P. Berrange wrote:
From: Daniel P. Berrange berra...@redhat.com
Address a number of code, style and docs issues identified
in review of virt-login-shell after it was merged.
Signed-off-by: Daniel P. Berrange berra...@redhat.com
---
tools/Makefile.am
On Tue, Aug 13, 2013 at 02:23:41PM +0200, Guido Günther wrote:
On Tue, Aug 13, 2013 at 09:51:22AM +0100, Daniel P. Berrange wrote:
On Mon, Aug 12, 2013 at 10:13:07PM +0200, Guido Günther wrote:
On Mon, Aug 12, 2013 at 01:21:08PM -0600, Eric Blake wrote:
On 08/12/2013 01:14 PM, Guido
On 08/13/2013 05:17 AM, Daniel P. Berrange wrote:
From: Daniel P. Berrange berra...@redhat.com
The virtlockd/libvirtd daemons had listed '?' as the short option
for --help. getopt_long uses '?' for any unknown option. We want
to be able to distinguish unknown options (which use EXIT_FAILURE)
The description for permissions was copied from the storage volume
section to the storage pool section, but the semantics are different:
1. Currently only the dir, fs and netfs storage pools use it.
2. They use it only to build the final directory.
3. A default for the storage volumes can't be
On 08/13/2013 06:26 AM, Daniel P. Berrange wrote:
From: Daniel P. Berrange berra...@redhat.com
The lxcContainerMountFSBlockAuto method can be used to mount the
initial root filesystem, so it cannot assume a prefix of /.oldroot.
Signed-off-by: Daniel P. Berrange berra...@redhat.com
---
From: Daniel P. Berrange berra...@redhat.com
If booting a container with a root FS that isn't the host's
root, we must ensure that the /dev mount point exists.
Signed-off-by: Daniel P. Berrange berra...@redhat.com
---
src/lxc/lxc_container.c | 14 --
1 file changed, 12
On Tue, Aug 13, 2013 at 11:55:40AM +0800, Li Zhang wrote:
From: Li Zhang zhlci...@linux.vnet.ibm.com
Power7+ and Power8 are supported in QEMU, so it needs to define CPUs
in libvirt to support them.
Signed-off-by: Li Zhang zhlci...@linux.vnet.ibm.com
---
src/cpu/cpu_map.xml | 11
On Mon, Aug 12, 2013 at 10:19:47PM -0600, Eric Blake wrote:
https://bugzilla.redhat.com/show_bug.cgi?id=924153
Commit 904e05a2 (v0.9.9) added a per-disk seclabel element with
an attribute relabel='no' in order to try and minimize the
impact of shutdown delays when an NFS server disappears.
On Tue, Aug 13, 2013 at 01:52:33PM +0200, Fred A. Kemp wrote:
From: Fred A. Kemp ano...@riseup.net
Allow use of the usb-storage device only if the new capability flag
QEMU_CAPS_DEVICE_USB_STORAGE is set, which it is for qemu(-kvm)
versions = 0.12.1.2-rhel62-beta.
---
Hi Chris,
On 2013年08月13日 09:55, Chris Lalancette wrote:
Thanks for the patch, that is great!
I've now applied it to the main ruby-libvirt repository. Let me know
if you have any problems with it.
Looks good. No problem.
IMHO, there are many progress from 0.4.0 release, it is chance to
On 08/13/2013 07:59 AM, Daniel P. Berrange wrote:
From: Daniel P. Berrange berra...@redhat.com
If booting a container with a root FS that isn't the host's
root, we must ensure that the /dev mount point exists.
Signed-off-by: Daniel P. Berrange berra...@redhat.com
---
On 08/13/2013 08:11 AM, Daniel P. Berrange wrote:
On Mon, Aug 12, 2013 at 10:19:47PM -0600, Eric Blake wrote:
https://bugzilla.redhat.com/show_bug.cgi?id=924153
Commit 904e05a2 (v0.9.9) added a per-disk seclabel element with
an attribute relabel='no' in order to try and minimize the
impact
On Tue, Aug 13, 2013 at 06:29:10AM -0600, Eric Blake wrote:
On 08/12/2013 11:54 PM, Guido Günther wrote:
The Linux build revealed another missing direkt link target, this time
s/direkt/direct/
Fixed and pushed. Thanks.
-- Guido
against selinux libs:
This will allow us to run sandbox as the calling process, If I am
running a shell as staff_u:unconfined_r:unconfined_t:s0, and I
execute virt-sandbox -c lxc/// -- /bin/sh
The second patch fixes a problem when users try to upgrade Generic Containers.
[sandbox PATCH 1/2] Add virt-sandbox -s
-s static,label=unconfined_u:unconfined_r:unconfined_t:s0-s0:c0.c1023
Well running virt-sandbox -s inherit would run as unconfined_t for most users.
I the future we need to add a check to libvirt to ask SELinux if it is ok for a
user to transiton to the label, rather then just to do it.
This will allow us to run sandbox as the calling process, If I am
running a shell as staff_u:unconfined_r:unconfined_t:s0, and I
execute virt-sandbox -c lxc/// -- /bin/sh
/bin/sh will run as staff_u:unconfined_r:unconfined_t:s0
---
bin/virt-sandbox-service.pod | 6 +-
Do not attempt to fix the unit file of Generic Containers.
---
bin/virt-sandbox-service | 36 ++--
1 file changed, 18 insertions(+), 18 deletions(-)
diff --git a/bin/virt-sandbox-service b/bin/virt-sandbox-service
index 03873c9..3e83c94 100755
---
On Tue, Aug 13, 2013 at 1:16 PM, Daniel P. Berrange berra...@redhat.comwrote:
virReportSystemError(errno, _(Unable exec shell %s), shargv[0]);
s/Unable/Unable to/
Kind regards,
Ruben
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Daniel Berrange (correctly) pointed out that we should do a better
job of testing selinux labeling fallbacks on NFS disks that lack
labeling support.
* tests/securityselinuxhelper.c (includes): Makefile already
guaranteed xattr support. Add additional headers.
(init_syms): New function,
On 08/13/2013 06:38 AM, Philipp Hahn wrote:
The description for permissions was copied from the storage volume
section to the storage pool section, but the semantics are different:
1. Currently only the dir, fs and netfs storage pools use it.
2. They use it only to build the final directory.
On 08/13/2013 08:05 AM, Daniel P. Berrange wrote:
On Tue, Aug 13, 2013 at 11:55:40AM +0800, Li Zhang wrote:
From: Li Zhang zhlci...@linux.vnet.ibm.com
Power7+ and Power8 are supported in QEMU, so it needs to define CPUs
in libvirt to support them.
ACK
Pushed.
--
Eric Blake eblake
On 07/25/2013 03:35 AM, Daniel P. Berrange wrote:
NACK,
As I explained on IRC, the hypervisor drivers have no business accessing
the dnsmasq lease files from the bridge driver. This is considered to be
a private implementation detail.
At a conceptual level, what you're after here is a
On 08/13/2013 04:48 PM, Eric Blake wrote:
virNetworkGetDHCPLeaseForMAC(virNetworkPtr network,
unsigned char *macaddr,
I personally think the public API should stick to stringized
representations. Yes, it's less friendly to machine code, but
internally,
This resolves the issue that prompted the filing of
https://bugzilla.redhat.com/show_bug.cgi?id=928638
(although the request there is for something much larger and more
general than this patch).
commit f3868259ca0517212e439a65c9060868f673b6c9 disabled the
forwarding to upstream DNS servers of
On Wed, Aug 14, 2013 at 4:29 AM, Eric Blake ebl...@redhat.com wrote:
On 08/13/2013 04:48 PM, Eric Blake wrote:
virNetworkGetDHCPLeaseForMAC(virNetworkPtr network,
unsigned char *macaddr,
I personally think the public API should stick to stringized
On 08/13/2013 12:09 PM, Ruben Kerkhof wrote:
On Tue, Aug 13, 2013 at 1:16 PM, Daniel P. Berrange
berra...@redhat.comwrote:
virReportSystemError(errno, _(Unable exec shell %s), shargv[0]);
s/Unable/Unable to/
Pushed the fix in your name, along with another line with the same
problem
-Original Message-
From: Daniel P. Berrange [mailto:berra...@redhat.com]
Sent: Saturday, August 10, 2013 12:54 AM
To: Chen Hanxiao
Cc: libvir-list@redhat.com
Subject: Re: [libvirt] [PATCH v2]LXC: Helper function for checking ownership
of
dir when userns enabled
On Fri, Aug
50 matches
Mail list logo
