[libvirt] [PATCH] tools: Make sure to distribute conf_DATA, fix RPM build

2013-08-17 Thread Cole Robinson
--- Pushed as build breaker. tools/Makefile.am | 1 + 1 file changed, 1 insertion(+) diff --git a/tools/Makefile.am b/tools/Makefile.am index d48883c..f85c35c 100644 --- a/tools/Makefile.am +++ b/tools/Makefile.am @@ -33,6 +33,7 @@ ICON_FILES = \ EXTRA_DIST = \ $(ICON_FILES)

[libvirt] [PATCH 2/5] VMX: Add cdrom-raw dev type from VMWare Fusion

2013-08-17 Thread Doug Goldstein
According to VMWare's documentation 'cdrom-raw' is an acceptable value for deviceType for a CD-ROM drive. ide|scsi(n):(n).deviceType = cdrom-raw|atapi-cdrom|cdrom-image 'cdrom-raw' appears to pass on your host CD-ROM instead of emulating an ATAPI CD-ROM drive. --- src/vmx/vmx.c

[libvirt] [PATCH 4/5] VMX: Some serial ports are not actually connected

2013-08-17 Thread Doug Goldstein
Sometimes a serial port might not be actually wired to a device when the user does not have the device connected at power on and we should not consider this a fatal error. --- src/vmx/vmx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/vmx/vmx.c b/src/vmx/vmx.c index

[libvirt] [PATCH 0/5] RFC: VMX parsing improvements

2013-08-17 Thread Doug Goldstein
A user came into #virt the other day and was trying to get libvirtd to work with VMWare Fusion 5, which is basically the Mac OS X version of VMWare Workstation. In helping him out I noticed a few limitations of our VMX parser so I've added support through this patchset. However I came across the

[libvirt] [PATCH 3/5] VMX: Add support for 'auto detect' fileNames

2013-08-17 Thread Doug Goldstein
VMWare Fusion 5 can set the CD-ROM's file name to be 'auto detect' when using the physical drive via 'cdrom-raw' device type. VMWare will then connect to first available host CD-ROM to the virtual machine upon start up according to VMWare documentation. --- src/vmx/vmx.c

[libvirt] [PATCH 5/5] VMX: Add a VMWare Fusion 5 configuration for tests

2013-08-17 Thread Doug Goldstein
A user was having an issue with this specific VMWare Fusion config and he gave me permission to add it as part of our test suite to further expand our VMX test coverage. --- tests/vmx2xmldata/vmx2xml-fusion-in-the-wild-1.vmx | 88 ++

[libvirt] [PATCH 1/5] VMX: Improve disk parse error for unknown values

2013-08-17 Thread Doug Goldstein
Previously the error message showed the following: error: internal error: Invalid or not yet handled value 'auto detect' for VMX entry 'ide0:0.fileName' This left the user unsure if it was a CD-ROM or a disk device that they needed to fix. Now the error shows: error: internal error: Invalid or