Re: [libvirt] [SOLVED] virDomainAttachDevice error during disk hotplug

2013-08-18 Thread Deepak C Shetty
On 08/17/2013 02:18 AM, Doug Goldstein wrote: On Fri, Aug 16, 2013 at 8:30 AM, Daniel P. Berrange berra...@redhat.com mailto:berra...@redhat.com wrote: On Fri, Aug 16, 2013 at 06:51:21PM +0530, Deepak C Shetty wrote: On 08/10/2013 06:20 PM, Deepak C Shetty wrote: 2013-08-10

Re: [libvirt] [PATCH v2] bridge driver: implement networkEnableIpForwarding for BSD

2013-08-18 Thread Roman Bogorodskiy
Roman Bogorodskiy wrote: Implement networkEnableIpForwarding() using BSD style sysctl. --- configure.ac| 7 --- src/network/bridge_driver.c | 13 + 2 files changed, 17 insertions(+), 3 deletions(-) ping? Roman Bogorodskiy pgphJ37aCW7yP.pgp Description:

Re: [libvirt] [PATCH v3] BSD: implement virNetDev(Set|Clear)IPv4Address

2013-08-18 Thread Roman Bogorodskiy
Roman Bogorodskiy wrote: Provide an implementation of virNetDev(Set|Clear)IPv4Address based on BSD ifconfig tool in addition to 'ip' from Linux iproute2 package. --- configure.ac | 15 +++ src/util/virnetdev.c | 24 2 files changed, 39

Re: [libvirt] [PATCHv2 1/5] domifaddr: Implement the public API

2013-08-18 Thread Osier Yang
On 15/08/13 17:30, Daniel P. Berrange wrote: On Thu, Aug 15, 2013 at 02:24:26AM +0530, nehaljwani wrote: diff --git a/include/libvirt/libvirt.h.in b/include/libvirt/libvirt.h.in index 52ac95d..fa49e70 100644 --- a/include/libvirt/libvirt.h.in +++ b/include/libvirt/libvirt.h.in @@ -2044,6

Re: [libvirt] [PATCHv2 2/5] domifaddr: Implement the remote protocol

2013-08-18 Thread Osier Yang
On 15/08/13 17:36, Daniel P. Berrange wrote: On Thu, Aug 15, 2013 at 02:24:27AM +0530, nehaljwani wrote: Implement RPC calls for virDomainInterfacesAddresses daemon/remote.c * Define remoteSerializeDomainInterfacePtr, remoteDispatchDomainInterfacesAddresses src/remote/remote_driver.c

Re: [libvirt] RFC: Introduce API to return configuration/state paths of the network driver

2013-08-18 Thread Osier Yang
On 15/08/13 19:32, Daniel P. Berrange wrote: On Wed, Aug 14, 2013 at 04:57:51AM +0530, Nehal J. Wani wrote: On Wed, Aug 14, 2013 at 4:29 AM, Eric Blake ebl...@redhat.com wrote: On 08/13/2013 04:48 PM, Eric Blake wrote: virNetworkGetDHCPLeaseForMAC(virNetworkPtr network,

[libvirt] virtlockd max_clients limitation

2013-08-18 Thread David Weber
Hi, we recently ran into a problem when trying to start more than 20 guests if direct locking with virtlockd was enabled. The error message locked like this: # start test7 error: Failed to start domain test7 error: Cannot recv data: Connection reset by peer Our research indicated there is a

[libvirt] [PATCH v2 6/9] qemu: Don't try to allocate PCI addresses for ARM

2013-08-18 Thread Cole Robinson
--- src/qemu/qemu_command.c | 16 ++-- 1 file changed, 14 insertions(+), 2 deletions(-) diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c index ceab12c..aaff132 100644 --- a/src/qemu/qemu_command.c +++ b/src/qemu/qemu_command.c @@ -1773,6 +1773,16 @@ cleanup: return

[libvirt] [PATCH v2 5/9] qemu: Fix adding specifying char devs for ARM

2013-08-18 Thread Cole Robinson
QEMU ARM boards don't give us any way to explicitly wire in a -chardev, so use the old style -serial options. Unfortunately this isn't as simple as just turning off the CHARDEV flag for qemu-system-arm, as upcoming virtio support _will_ use device/chardev. --- src/qemu/qemu_capabilities.c | 18

[libvirt] [PATCH v2 0/9] Support qemu-system-arm vexpress-a9

2013-08-18 Thread Cole Robinson
This series adds the bits needed to kick of a qemu-system-arm -machine vexpress-a9 guest. vexpress-a15 likely works as well but is untested. Patches 1-3 are related bugfixes/improvements. Patch 7 adds disk bus=sd, which is often the only way to specify storage for ARM boards. Patch 9 adds

[libvirt] [PATCH v2 2/9] qemu: Only setup vhost if virtType == kvm

2013-08-18 Thread Cole Robinson
vhost only works in KVM mode at the moment, and is infact compiled out if the emulator is built for non-native architecture. While it may work at some point in the future for plain qemu, for now it's just noise on the command line (and which contributes to arm cli breakage). ---

[libvirt] [PATCH v2 3/9] domain_conf: Add default memballon in PostParse callbacks

2013-08-18 Thread Cole Robinson
This should be a no-op change for now. --- src/qemu/qemu_domain.c | 10 ++ src/xen/xen_driver.c | 9 + 2 files changed, 19 insertions(+) diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c index 393af6b..8dc7675 100644 --- a/src/qemu/qemu_domain.c +++

[libvirt] [PATCH v2 8/9] qemu: Fix networking for ARM guests

2013-08-18 Thread Cole Robinson
Similar to the chardev bit, ARM boards depend on the old style '-net nic' for actually instantiating net devices. But we can't block out -netdev altogether since it's needed for upcoming virtio support. And add tests for working ARM XML with console, disk, and networking. ---

[libvirt] [PATCH v2 7/9] domain_conf: Add disk bus=sd, wire it up for qemu

2013-08-18 Thread Cole Robinson
This corresponds to '-sd' and '-drive if=sd' on the qemu command line. Needed for many ARM boards which don't provide any other way to pass in storage. --- docs/formatdomain.html.in | 3 ++- docs/schemas/domaincommon.rng | 1 + src/conf/domain_conf.c| 4 +++- src/conf/domain_conf.h

[libvirt] [PATCH v2 4/9] qemu: Don't add default memballoon device on ARM

2013-08-18 Thread Cole Robinson
And add test cases for a basic working ARM guest. --- docs/schemas/domaincommon.rng | 19 + src/conf/domain_conf.c | 14 - src/qemu/qemu_domain.c | 4 ++- .../qemuxml2argv-arm-vexpressa9-nodevs.args

[libvirt] [PATCH v2 9/9] qemu: Support virtio-mmio transport for virtio on ARM

2013-08-18 Thread Cole Robinson
Starting with qemu 1.6, the qemu-system-arm vexpress-a9 model has a hardcoded virtio-mmio transport which enables attaching all virtio devices. On the command line, we have to use virtio-XXX-device rather than virtio-XXX-pci, thankfully s390 already set the precedent here so it's fairly straight

Re: [libvirt] [PATCH] util: Fix crash of libvirtd when running numatune with invalid nodeset

2013-08-18 Thread Alex Jia
On 08/16/2013 07:42 PM, Eric Blake wrote: On 08/16/2013 01:47 AM, Alex Jia wrote: This issue is introduced by commit 0fc8909, the virBitmapIsSet() needs caller to ensure 'b bitmap-max_bit', but it's lost in the virBitmapParse() caller, this will cause crash of libvirtd, with the patch,