Re: [libvirt] [PATCH] netns: unix: only allow to find out unix socket in same net namespace

2013-08-21 Thread Eric W. Biederman
Gao feng gaof...@cn.fujitsu.com writes: cc libvirt-list On 08/21/2013 01:30 PM, Eric W. Biederman wrote: Gao feng gaof...@cn.fujitsu.com writes: Unix sockets are private resources of net namespace, allowing one net namespace to access to other netns's unix sockets is meaningless.

Re: [libvirt] [PATCH] netns: unix: only allow to find out unix socket in same net namespace

2013-08-21 Thread Gao feng
cc libvirt-list On 08/21/2013 01:30 PM, Eric W. Biederman wrote: Gao feng gaof...@cn.fujitsu.com writes: Unix sockets are private resources of net namespace, allowing one net namespace to access to other netns's unix sockets is meaningless. Allowing one net namespace to access another

Re: [libvirt] Domblklist

2013-08-21 Thread Osier Yang
On 21/08/13 13:38, Yaniv Hadad wrote: I am looking for the equivalent of virsh *domblklist *in libvirt API reference. I am using the Java binding. What I want to get is the device list of the domain as in the following example: virsh # domblklist centos64test Target Source

Re: [libvirt] [PATCH] netns: unix: only allow to find out unix socket in same net namespace

2013-08-21 Thread Gao feng
On 08/21/2013 03:06 PM, Eric W. Biederman wrote: Gao feng gaof...@cn.fujitsu.com writes: cc libvirt-list On 08/21/2013 01:30 PM, Eric W. Biederman wrote: Gao feng gaof...@cn.fujitsu.com writes: Unix sockets are private resources of net namespace, allowing one net namespace to access to

[libvirt] [PATCH] tests: fix building without xattr support

2013-08-21 Thread Claudio Bley
Only compile securityselinuxhelper.c if xattr support was detected to avoid this error: securityselinuxhelper.c:34:24: fatal error: attr/xattr.h: No such file or directory compilation terminated. Since all SELinux tests depend upon the securityselinuxhelper library, these test programs are now

[libvirt] [PATCH] LXC: mount a fresh /run directory for container

2013-08-21 Thread Gao feng
The unix socket file /run/systemd/private is used to send reboot/shutdown messages. and since this type of unix sockets are not per net namespace , they are global resources. systemctl in container can use this unix socket to send shutdown message to the systemd-shutdownd running on host. finally

Re: [libvirt] [PATCH] blkio: change the minimum weight from 100 to 10

2013-08-21 Thread Gao feng
On 08/20/2013 01:23 AM, Eric Blake wrote: On 08/18/2013 11:59 PM, Gao feng wrote: kernel had changed the minimum weight of device blkio from 100 to 10 in commit df457f845e5449be2e7d96668791f789b3770ac7. commit df457f845e5449be2e7d96668791f789b3770ac7 Author: Justin TerAvest

[libvirt] [libvirt-IEEE-plan][PATCH] delete regression test of bug 990061 since it is moved to rhel6.6

2013-08-21 Thread Xuesong Zhang
--- 6-5/markdown/10-Test_design/22-Node_devices.txt | 6 -- 1 file changed, 6 deletions(-) diff --git a/6-5/markdown/10-Test_design/22-Node_devices.txt b/6-5/markdown/10-Test_design/22-Node_devices.txt index bf86615..dea4850 100644 --- a/6-5/markdown/10-Test_design/22-Node_devices.txt +++

Re: [libvirt] SIGSEGV using virConnect.newStream with Python

2013-08-21 Thread Claudio Bley
At Tue, 20 Aug 2013 11:34:56 +0200, Claudio Bley wrote: Hi. I tried this on Fedora 19, using libvirt 1.0.5 and also tested with git v1.1.1-maint as well as git master on Ubuntu 12.04. How to reproduce: python - import libvirt as l c = l.virConnect(test:///default) v =

Re: [libvirt] [PATCH] migration: do not restore labels on failed migration

2013-08-21 Thread Daniel P. Berrange
On Tue, Aug 20, 2013 at 05:10:38PM -0600, Eric Blake wrote: The problem at hand is that when migrating between different configurations, the destination first attempts to label files before even starting qemu - and does a chown() to root:root. IMHO making libvirt work in the face of such

Re: [libvirt] [PATCH] LXC: mount a fresh /run directory for container

2013-08-21 Thread Daniel P. Berrange
On Wed, Aug 21, 2013 at 04:22:29PM +0800, Gao feng wrote: The unix socket file /run/systemd/private is used to send reboot/shutdown messages. and since this type of unix sockets are not per net namespace , they are global resources. systemctl in container can use this unix socket to send

[libvirt] [PATCH]LXC: force container to enable network namespace

2013-08-21 Thread Chen Hanxiao
From: Chen Hanxiao chenhanx...@cn.fujitsu.com If we don't enable network namespace, we could shutdown host inside container by command 'shutdown', which is unacceptable. This patch will force users to enable network namespace before they start container. Signed-off-by: Chen Hanxiao

[libvirt] [PATCH] Fix URI connect precedence

2013-08-21 Thread Martin Kletzander
Commit abfff210 changed the order of vshParseArgv() and vshInit() in order to make fix debugging of parameter parsing. However, vshInit() did a vshReconnect() even though ctl-name wasn't set according to the '-c' parameter yet. In order to keep both issues fixed, I've split the vshInit() into

Re: [libvirt] [PATCH 0/2] Follow up patches for the storage fix.

2013-08-21 Thread Osier Yang
On 20/08/13 17:08, Osier Yang wrote: Osier Yang (2): storage: Fix coverity warning storage: Fix the use-after-free memory bug src/storage/storage_driver.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) Pushed the set. Thanks for reviewing. Osier -- libvir-list mailing

Re: [libvirt] [PATCH]LXC: force container to enable network namespace

2013-08-21 Thread Daniel P. Berrange
On Wed, Aug 21, 2013 at 05:49:05PM +0800, Chen Hanxiao wrote: From: Chen Hanxiao chenhanx...@cn.fujitsu.com If we don't enable network namespace, we could shutdown host inside container by command 'shutdown', which is unacceptable. This patch will force users to enable network namespace

Re: [libvirt] [systemd-devel] [PATCH] netns: unix: only allow to find out unix socket in same net namespace

2013-08-21 Thread Kay Sievers
On Wed, Aug 21, 2013 at 9:22 AM, Gao feng gaof...@cn.fujitsu.com wrote: On 08/21/2013 03:06 PM, Eric W. Biederman wrote: I suspect libvirt should simply not share /run or any other normally writable directory with the host. Sharing /run /var/run or even /tmp seems extremely dubious if you

[libvirt] virsh cpu-stats not working !!!

2013-08-21 Thread SHREE DUTH AWASTHI
Hi All, Can you please guide us in solving this issue. Version used : libvirt-1.0.6 # rpm -qa | egrep libvirt|qemu qemu-kvm-0.14.1-1_WR4.3.x86_64_XXX.x86_64 libvirt-1.0.6-1_WR4.3.x86_64_XXX.2.x86_64 Problem : # virsh cpu-stats CLA-0 error: Failed to retrieve CPU statistics for

Re: [libvirt] [systemd-devel] [PATCH] netns: unix: only allow to find out unix socket in same net namespace

2013-08-21 Thread Daniel P. Berrange
On Wed, Aug 21, 2013 at 11:51:53AM +0200, Kay Sievers wrote: On Wed, Aug 21, 2013 at 9:22 AM, Gao feng gaof...@cn.fujitsu.com wrote: On 08/21/2013 03:06 PM, Eric W. Biederman wrote: I suspect libvirt should simply not share /run or any other normally writable directory with the host.

[libvirt] Libvirt multi queue support

2013-08-21 Thread Naor Shlomo
Hello experts, Could anyone please tell me if Multi Queue it fully supported in Libvirt and if so what version contains it? Thanks, Naor -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH] Fix URI connect precedence

2013-08-21 Thread Daniel P. Berrange
On Wed, Aug 21, 2013 at 11:15:39AM +0200, Martin Kletzander wrote: Commit abfff210 changed the order of vshParseArgv() and vshInit() in order to make fix debugging of parameter parsing. However, vshInit() did a vshReconnect() even though ctl-name wasn't set according to the '-c' parameter

Re: [libvirt] [PATCH v2]LXC: Helper function for checking ownership of dir when userns enabled

2013-08-21 Thread Daniel P. Berrange
On Fri, Aug 09, 2013 at 04:05:58PM +0800, Chen Hanxiao wrote: From: Chen Hanxiao chenhanx...@cn.fujitsu.com If we enable userns, the ownership of dir we provided for containers should match the uid/gid in idmap. Currently, the debug log is very implicit or misleading sometimes. This patch

Re: [libvirt] [PATCH] netns: unix: only allow to find out unix socket in same net namespace

2013-08-21 Thread Eric W. Biederman
Gao feng gaof...@cn.fujitsu.com writes: right now I only take note of the unix socket /run/systemd/private, but there may have many similar unix sockets, they can exist in any path. the strange problems will still happen. It could just as easily have been a fifo in the filesystem, and the

Re: [libvirt] [PATCH 1/2] Simplify RELRO_LDFLAGS

2013-08-21 Thread Guido Günther
On Tue, Aug 20, 2013 at 01:23:18PM -0600, Eric Blake wrote: On 08/20/2013 08:39 AM, Guido Günther wrote: by adding it to AM_LDFLAGS instead of every linking rule and by avoiding a forked grep. --- Daniel kind of nacked the AM_LDFLAGS part already but I think it's a reasonable cleanup.

[libvirt] [PATCH v4 1/3] Simplify RELRO_LDFLAGS

2013-08-21 Thread Guido Günther
by adding it to AM_LDFLAGS instead of every linking rule and by avoiding a forked grep. --- daemon/Makefile.am | 4 +++- m4/virt-linker-relro.m4 | 11 +++ src/Makefile.am | 13 +++-- tools/Makefile.am | 18 +- 4 files changed, 26 insertions(+),

[libvirt] [PATCH v4 3/3] python: Use RELRO_LDFLAGS and NO_INDIRECT_LDFLAGS

2013-08-21 Thread Guido Günther
A readonly GOT and detecting indirect linkage is useful here too. --- python/Makefile.am | 7 +++ 1 file changed, 7 insertions(+) diff --git a/python/Makefile.am b/python/Makefile.am index 925e1f4..3f967a9 100644 --- a/python/Makefile.am +++ b/python/Makefile.am @@ -28,6 +28,10 @@ INCLUDES =

[libvirt] [PATCH v4 2/3] Check for --no-copy-dt-needed linker flag

2013-08-21 Thread Guido Günther
and use it when available --- configure.ac | 1 + daemon/Makefile.am| 1 + m4/virt-linker-no-indirect.m4 | 32 src/Makefile.am | 1 + tests/Makefile.am | 1 + tools/Makefile.am | 1 + 6 files

Re: [libvirt] Libvirt multi queue support

2013-08-21 Thread Michal Privoznik
On 21.08.2013 07:31, Naor Shlomo wrote: Hello experts, Could anyone please tell me if Multi Queue it fully supported in Libvirt and if so what version contains it? Do you mean multiqueue network? It's supported from 1.0.6. You can set it in /domain/devices/interface/driver/@queues

[libvirt] [PATCH] Test handling of non-existant x509 certs

2013-08-21 Thread Daniel P. Berrange
From: Daniel P. Berrange berra...@redhat.com In commit f905cc998449c89339d0e2894a71d9a9e45293e5 a use of uninitialized data was fixed based on a coverity report. It turns out it was possible to trigger this issue by pointing libvirt at non-existant certificate files, typically causing a crash.

[libvirt] [PATCH] vl: allow cont from panicked state

2013-08-21 Thread Paolo Bonzini
After reporting the GUEST_PANICKED monitor event, QEMU stops the VM. The reason for this is that events are edge-triggered, and can be lost if management dies at the wrong time. Stopping a panicked VM lets management know of a panic even if it has crashed; management can learn about the panic

Re: [libvirt] [Qemu-devel] [PATCH] vl: allow cont from panicked state

2013-08-21 Thread Laszlo Ersek
one question below On 08/21/13 14:01, Paolo Bonzini wrote: After reporting the GUEST_PANICKED monitor event, QEMU stops the VM. The reason for this is that events are edge-triggered, and can be lost if management dies at the wrong time. Stopping a panicked VM lets management know of a panic

Re: [libvirt] SIGSEGV using virConnect.newStream with Python

2013-08-21 Thread Eric Blake
On 08/21/2013 02:51 AM, Claudio Bley wrote: At Tue, 20 Aug 2013 11:34:56 +0200, Claudio Bley wrote: Hi. I tried this on Fedora 19, using libvirt 1.0.5 and also tested with git v1.1.1-maint as well as git master on Ubuntu 12.04. How to reproduce: python - import libvirt as l c

Re: [libvirt] [PATCH] vl: allow cont from panicked state

2013-08-21 Thread Paolo Bonzini
Il 21/08/2013 14:42, Laszlo Ersek ha scritto: (*) Hm I think I understand why. main_loop_should_exit(), when a reset was requested *and* runstate_needs_reset() evaluated to true, used to set the runstate to PAUSED -- I guess temporarily. Yes, this is the code that does the PANICKED - PAUSED

Re: [libvirt] [PATCH] Test handling of non-existant x509 certs

2013-08-21 Thread Eric Blake
On 08/21/2013 05:52 AM, Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com In commit f905cc998449c89339d0e2894a71d9a9e45293e5 a use of uninitialized data was fixed based on a coverity report. It turns out it was possible to trigger this issue by pointing libvirt at

Re: [libvirt] [PATCH] migration: do not restore labels on failed migration

2013-08-21 Thread Daniel P. Berrange
On Tue, Aug 20, 2013 at 04:46:47PM -0600, Eric Blake wrote: https://bugzilla.redhat.com/show_bug.cgi?id=822052 When doing a live migration, if the destination fails for any reason after the point in which files should be labeled, then the cleanup of the destination would restore the labels

Re: [libvirt] [PATCH] tests: fix building without xattr support

2013-08-21 Thread Daniel P. Berrange
On Wed, Aug 21, 2013 at 09:28:26AM +0200, Claudio Bley wrote: Only compile securityselinuxhelper.c if xattr support was detected to avoid this error: securityselinuxhelper.c:34:24: fatal error: attr/xattr.h: No such file or directory compilation terminated. Since all SELinux tests depend

Re: [libvirt] [PATCH v4 1/3] Simplify RELRO_LDFLAGS

2013-08-21 Thread Daniel P. Berrange
On Wed, Aug 21, 2013 at 01:22:57PM +0200, Guido Günther wrote: by adding it to AM_LDFLAGS instead of every linking rule and by avoiding a forked grep. --- daemon/Makefile.am | 4 +++- m4/virt-linker-relro.m4 | 11 +++ src/Makefile.am | 13 +++--

Re: [libvirt] [PATCH v4 3/3] python: Use RELRO_LDFLAGS and NO_INDIRECT_LDFLAGS

2013-08-21 Thread Daniel P. Berrange
On Wed, Aug 21, 2013 at 01:23:55PM +0200, Guido Günther wrote: A readonly GOT and detecting indirect linkage is useful here too. --- python/Makefile.am | 7 +++ 1 file changed, 7 insertions(+) ACK Daniel -- |: http://berrange.com -o-http://www.flickr.com/photos/dberrange/ :|

Re: [libvirt] [PATCH v4 2/3] Check for --no-copy-dt-needed linker flag

2013-08-21 Thread Daniel P. Berrange
On Wed, Aug 21, 2013 at 01:23:46PM +0200, Guido Günther wrote: and use it when available --- configure.ac | 1 + daemon/Makefile.am| 1 + m4/virt-linker-no-indirect.m4 | 32 src/Makefile.am | 1 +

Re: [libvirt] [PATCHv2 1/2] virBitmapParse: Fix behavior in case of error

2013-08-21 Thread Daniel P. Berrange
On Tue, Aug 20, 2013 at 11:33:43AM +0200, Peter Krempa wrote: Re-arrange the code so that the returned bitmap is always initialized to NULL even on early failures and return an error message as some callers are already expecting it. --- Notes: Version 2: Was already ACKed in v1,

Re: [libvirt] [PATCHv2 2/2] virBitmapParse: Don't shadow errors

2013-08-21 Thread Daniel P. Berrange
On Tue, Aug 20, 2013 at 11:33:44AM +0200, Peter Krempa wrote: A few of the callers of virBitmapParse shadow the returned error. --- Notes: I'm kind of worried that we are making some error messages worse compared to what they were before. If you don't like the way this will

[libvirt] [PATCHv2] virBitmapParse: Fix behavior in case of error and fix up callers

2013-08-21 Thread Peter Krempa
Re-arrange the code so that the returned bitmap is always initialized to NULL even on early failures and return an error message as some callers are already expecting it. Fix up the rest not to shadow the error. --- Version 2: - squashed cleanup of callers into this patch po/POTFILES.in

Re: [libvirt] [PATCHv4 1/4] add hostdev passthrough common library

2013-08-21 Thread Daniel P. Berrange
On Mon, Aug 19, 2013 at 04:49:37PM -0400, cy...@suse.com wrote: diff --git a/src/util/virhostdev.c b/src/util/virhostdev.c new file mode 100644 index 000..1baa829 --- /dev/null +++ b/src/util/virhostdev.c + +/* For virReportOOMError() and virReportSystemError() */ No need for this

Re: [libvirt] [PATCHv4 1/4] add hostdev passthrough common library

2013-08-21 Thread Daniel P. Berrange
On Mon, Aug 19, 2013 at 04:49:37PM -0400, cy...@suse.com wrote: + +/* functions to get active/inactive lists */ +virHostdevNameListPtr +virHostdevGetActivePciHostdevs(virHostdevManagerPtr mgr); + +virHostdevNameListPtr +virHostdevGetActiveUsbHostdevs(virHostdevManagerPtr mgr); +

Re: [libvirt] [PATCH] tests: fix building without xattr support

2013-08-21 Thread Claudio Bley
At Wed, 21 Aug 2013 13:55:27 +0100, Daniel P. Berrange wrote: On Wed, Aug 21, 2013 at 09:28:26AM +0200, Claudio Bley wrote: Only compile securityselinuxhelper.c if xattr support was detected to avoid this error: securityselinuxhelper.c:34:24: fatal error: attr/xattr.h: No such file

Re: [libvirt] [PATCH v2 1/9] qemu: Set QEMU_AUDIO_DRV=none with -nographic

2013-08-21 Thread Daniel P. Berrange
On Mon, Aug 19, 2013 at 12:24:39PM -0400, Cole Robinson wrote: On my machine, a guest fails to boot if it has a sound card, but not graphical device/display is configured, because pulseaudio fails to initialize since it can't access $HOME. A workaround is removing the audio device, however

Re: [libvirt] [PATCH] vl: allow cont from panicked state

2013-08-21 Thread Michael S. Tsirkin
On Wed, Aug 21, 2013 at 02:01:17PM +0200, Paolo Bonzini wrote: After reporting the GUEST_PANICKED monitor event, QEMU stops the VM. The reason for this is that events are edge-triggered, and can be lost if management dies at the wrong time. Stopping a panicked VM lets management know of a

Re: [libvirt] [Qemu-devel] [PATCH] vl: allow cont from panicked state

2013-08-21 Thread Michael S. Tsirkin
On Wed, Aug 21, 2013 at 02:42:38PM +0200, Laszlo Ersek wrote: Reviewed-by: Laszlo Ersek ler...@redhat.com (Note that my R-b is mostly worthless: similarly to the ACPI table move, I've been happily acking patches with opposite goals here, and that seriously questions whether my review adds

Re: [libvirt] [PATCH] tests: fix building without xattr support

2013-08-21 Thread Eric Blake
On 08/21/2013 01:28 AM, Claudio Bley wrote: Only compile securityselinuxhelper.c if xattr support was detected to avoid this error: securityselinuxhelper.c:34:24: fatal error: attr/xattr.h: No such file or directory compilation terminated. Since all SELinux tests depend upon the

[libvirt] [[libvirt-cim PATCH]] libvirt-cim.spec.in: Uninstall open-pegasus-specific providers

2013-08-21 Thread Ján Tomko
Older libvirt-cim might've installed these in the sblim-sfcb repository, causing errors when calling sfcbrepos on libvirt-cim update. --- libvirt-cim.spec.in | 7 +++ 1 file changed, 7 insertions(+) diff --git a/libvirt-cim.spec.in b/libvirt-cim.spec.in index a027246..cd399b1 100644 ---

Re: [libvirt] [[libvirt-cim PATCH]] libvirt-cim.spec.in: Uninstall open-pegasus-specific providers

2013-08-21 Thread John Ferlan
Probably should be sent to libvirt-...@redhat.com John On 08/21/2013 09:42 AM, Ján Tomko wrote: Older libvirt-cim might've installed these in the sblim-sfcb repository, causing errors when calling sfcbrepos on libvirt-cim update. --- libvirt-cim.spec.in | 7 +++ 1 file changed, 7

[libvirt] [PATCH] python: simplify complicated conditional assignment

2013-08-21 Thread Claudio Bley
Signed-off-by: Claudio Bley cb...@av-test.de --- Just noticed this while reading the generated .py files. Might save a few cycles eventually... python/generator.py |3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/python/generator.py b/python/generator.py index

Re: [libvirt] [PATCH] migration: do not restore labels on failed migration

2013-08-21 Thread Eric Blake
On 08/21/2013 06:54 AM, Daniel P. Berrange wrote: On Tue, Aug 20, 2013 at 04:46:47PM -0600, Eric Blake wrote: https://bugzilla.redhat.com/show_bug.cgi?id=822052 When doing a live migration, if the destination fails for any reason after the point in which files should be labeled, then the

Re: [libvirt] [PATCH] vl: allow cont from panicked state

2013-08-21 Thread Luiz Capitulino
On Wed, 21 Aug 2013 14:01:17 +0200 Paolo Bonzini pbonz...@redhat.com wrote: After reporting the GUEST_PANICKED monitor event, QEMU stops the VM. The reason for this is that events are edge-triggered, and can be lost if management dies at the wrong time. Stopping a panicked VM lets management

Re: [libvirt] [PATCH] vl: allow cont from panicked state

2013-08-21 Thread Luiz Capitulino
On Wed, 21 Aug 2013 14:43:11 +0200 Paolo Bonzini pbonz...@redhat.com wrote: Il 21/08/2013 14:42, Laszlo Ersek ha scritto: (*) Hm I think I understand why. main_loop_should_exit(), when a reset was requested *and* runstate_needs_reset() evaluated to true, used to set the runstate to PAUSED

Re: [libvirt] [PATCH] vl: allow cont from panicked state

2013-08-21 Thread Michael S. Tsirkin
On Wed, Aug 21, 2013 at 10:17:49AM -0400, Luiz Capitulino wrote: On Wed, 21 Aug 2013 14:43:11 +0200 Paolo Bonzini pbonz...@redhat.com wrote: Il 21/08/2013 14:42, Laszlo Ersek ha scritto: (*) Hm I think I understand why. main_loop_should_exit(), when a reset was requested *and*

Re: [libvirt] [PATCH] vl: allow cont from panicked state

2013-08-21 Thread Paolo Bonzini
Il 21/08/2013 16:30, Michael S. Tsirkin ha scritto: I think the same reasoning went behind the PANICKED state, and for most cases it's going to be disastrous to put the guest to run again, Why will it? It will most likely just call halt a bit later. I agree. but I can understand that this

Re: [libvirt] [PATCH] vl: allow cont from panicked state

2013-08-21 Thread Paolo Bonzini
Il 21/08/2013 15:30, Michael S. Tsirkin ha scritto: On Wed, Aug 21, 2013 at 02:01:17PM +0200, Paolo Bonzini wrote: After reporting the GUEST_PANICKED monitor event, QEMU stops the VM. The reason for this is that events are edge-triggered, and can be lost if management dies at the wrong time.

Re: [libvirt] [Qemu-devel] [ANNOUNCE] Key Signing Party at KVM Forum 2013

2013-08-21 Thread Eric Blake
FYI for those libvirt developers attending KVM Forum in October. On 07/24/2013 06:50 AM, Anthony Liguori wrote: I will be hosting a key signing party at this year's KVM Forum. http://wiki.qemu.org/KeySigningParty2013 Starting for the 1.7 release (begins in December), I will only accepted

Re: [libvirt] [PATCH] vl: allow cont from panicked state

2013-08-21 Thread Michael S. Tsirkin
On Wed, Aug 21, 2013 at 04:37:56PM +0200, Paolo Bonzini wrote: Il 21/08/2013 16:30, Michael S. Tsirkin ha scritto: I think the same reasoning went behind the PANICKED state, and for most cases it's going to be disastrous to put the guest to run again, Why will it? It will most likely

Re: [libvirt] [PATCH] vl: allow cont from panicked state

2013-08-21 Thread Paolo Bonzini
Il 21/08/2013 16:58, Michael S. Tsirkin ha scritto: On Wed, Aug 21, 2013 at 04:37:56PM +0200, Paolo Bonzini wrote: Il 21/08/2013 16:30, Michael S. Tsirkin ha scritto: I think the same reasoning went behind the PANICKED state, and for most cases it's going to be disastrous to put the guest to

Re: [libvirt] [PATCH] vl: allow cont from panicked state

2013-08-21 Thread Eric Blake
On 08/21/2013 06:01 AM, Paolo Bonzini wrote: After reporting the GUEST_PANICKED monitor event, QEMU stops the VM. The reason for this is that events are edge-triggered, and can be lost if management dies at the wrong time. Stopping a panicked VM lets management know of a panic even if it has

Re: [libvirt] [PATCH] vl: allow cont from panicked state

2013-08-21 Thread Paolo Bonzini
Il 21/08/2013 17:23, Eric Blake ha scritto: Upon learning of a panic, management (if configured to do so) can pick a variety of behaviors: leave the VM paused, reset it, destroy it. In addition to all of these behaviors, it is possible dumping the VM core from the host. s/possible

Re: [libvirt] [PATCH] vl: allow cont from panicked state

2013-08-21 Thread Michael S. Tsirkin
On Wed, Aug 21, 2013 at 05:32:27PM +0200, Paolo Bonzini wrote: Il 21/08/2013 17:23, Eric Blake ha scritto: Upon learning of a panic, management (if configured to do so) can pick a variety of behaviors: leave the VM paused, reset it, destroy it. In addition to all of these behaviors, it is

Re: [libvirt] [PATCH] python: simplify complicated conditional assignment

2013-08-21 Thread Eric Blake
On 08/21/2013 08:05 AM, Claudio Bley wrote: Signed-off-by: Claudio Bley cb...@av-test.de --- Just noticed this while reading the generated .py files. Might save a few cycles eventually... python/generator.py |3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) ACK. diff

Re: [libvirt] [PATCHv2] virBitmapParse: Fix behavior in case of error and fix up callers

2013-08-21 Thread Eric Blake
On 08/21/2013 07:12 AM, Peter Krempa wrote: Re-arrange the code so that the returned bitmap is always initialized to NULL even on early failures and return an error message as some callers are already expecting it. Fix up the rest not to shadow the error. --- Version 2: - squashed cleanup

[libvirt] [PATCH 1/3] vl: allow cont from panicked state

2013-08-21 Thread Paolo Bonzini
After reporting the GUEST_PANICKED monitor event, QEMU stops the VM. The reason for this is that events are edge-triggered, and can be lost if management dies at the wrong time. Stopping a panicked VM lets management know of a panic even if it has crashed; management can learn about the panic

[libvirt] [PATCH 2/3] pc: get rid of builtin pvpanic

2013-08-21 Thread Paolo Bonzini
It is a source of pain, and the previous patch anyway changed the behavior of -M pc-1.5 compared to the real 1.5. This also makes it clear that -device pvpanic is not enough: it will not expose pvpanic in fw_cfg properly. No idea how to fix that. Signed-off-by: Paolo Bonzini pbonz...@redhat.com

[libvirt] [RFC PATCH v2 0/3] Start fixing the pvpanic mess

2013-08-21 Thread Paolo Bonzini
The pvpanic mess is even bigger than anticipated. Let's fix the monitor's behavior (patch 1), get rid of all traces that the broken pvpanic existed (patch 2), and give it a new name so that libvirt can detect a design that works (patch 3). All downstreams are urged to apply patches 1+2 as soon

[libvirt] [PATCH 3/3] pvpanic: rename to isa-pvpanic

2013-08-21 Thread Paolo Bonzini
The pvpanic situation is already messed up enough. Let us give our libvirt friends an easy indication that we have untied our side. Not-yet-signed-off-by: Paolo Bonzini pbonz...@redhat.com ... because we first have to determine how to expose the device's existence in the ACPI tables or in

[libvirt] [PATCH] Allow a HTTP URL for cdrom ISO image

2013-08-21 Thread Aline Manera
From: Aline Manera alin...@br.ibm.com Hi all, qemu/KVM has support to iso streaming, allowing a HTTP UTL for cdrom iso image. I just added it to libvirt as well. Aline Manera (1): Allow a HTTP URL for cdrom ISO image src/conf/domain_conf.c |3 +-

[libvirt] [PATCH] Allow a HTTP URL for cdrom ISO image

2013-08-21 Thread Aline Manera
From: Aline Manera alin...@br.ibm.com QEMU/KVM already allows an HTTP URL for the cdrom ISO image so add this support to libvirt as well. The xml should be as following: disk type='network' device='cdrom' source protocol='http' name='/url/path' host name='host.name' port='80'/

Re: [libvirt] [RFC PATCH v2 0/3] Start fixing the pvpanic mess

2013-08-21 Thread Daniel P. Berrange
On Wed, Aug 21, 2013 at 06:43:13PM +0200, Paolo Bonzini wrote: The pvpanic mess is even bigger than anticipated. Let's fix the monitor's behavior (patch 1), get rid of all traces that the broken pvpanic existed (patch 2), and give it a new name so that libvirt can detect a design that works

Re: [libvirt] [PATCH] Allow a HTTP URL for cdrom ISO image

2013-08-21 Thread Daniel P. Berrange
On Wed, Aug 21, 2013 at 01:47:36PM -0300, Aline Manera wrote: From: Aline Manera alin...@br.ibm.com QEMU/KVM already allows an HTTP URL for the cdrom ISO image so add this support to libvirt as well. The xml should be as following: disk type='network' device='cdrom' source

Re: [libvirt] [RFC PATCH v2 0/3] Start fixing the pvpanic mess

2013-08-21 Thread Paolo Bonzini
Il 21/08/2013 18:48, Daniel P. Berrange ha scritto: No, on_crash is the right thing to be using for this from libvirt's pov I don't think we should invent something new. The on_crash element has always been intended to represent handling of guest panics, not qemu internal errors. Actually

Re: [libvirt] [RFC PATCH v2 0/3] Start fixing the pvpanic mess

2013-08-21 Thread Daniel P. Berrange
On Wed, Aug 21, 2013 at 06:51:11PM +0200, Paolo Bonzini wrote: Il 21/08/2013 18:48, Daniel P. Berrange ha scritto: No, on_crash is the right thing to be using for this from libvirt's pov I don't think we should invent something new. The on_crash element has always been intended to

Re: [libvirt] [RFC PATCH v2 0/3] Start fixing the pvpanic mess

2013-08-21 Thread Paolo Bonzini
Il 21/08/2013 18:55, Daniel P. Berrange ha scritto: On Wed, Aug 21, 2013 at 06:51:11PM +0200, Paolo Bonzini wrote: Il 21/08/2013 18:48, Daniel P. Berrange ha scritto: No, on_crash is the right thing to be using for this from libvirt's pov I don't think we should invent something new. The

Re: [libvirt] [PATCH 3/3] pvpanic: rename to isa-pvpanic

2013-08-21 Thread Michael S. Tsirkin
On Wed, Aug 21, 2013 at 06:43:16PM +0200, Paolo Bonzini wrote: The pvpanic situation is already messed up enough. Let us give our libvirt friends an easy indication that we have untied our side. Not-yet-signed-off-by: Paolo Bonzini pbonz...@redhat.com ... because we first have to determine

Re: [libvirt] [PATCH 2/3] pc: get rid of builtin pvpanic

2013-08-21 Thread Michael S. Tsirkin
On Wed, Aug 21, 2013 at 06:43:15PM +0200, Paolo Bonzini wrote: It is a source of pain, and the previous patch anyway changed the behavior of -M pc-1.5 compared to the real 1.5. This also makes it clear that -device pvpanic is not enough: it will not expose pvpanic in fw_cfg properly. No

Re: [libvirt] [RFC PATCH v2 0/3] Start fixing the pvpanic mess

2013-08-21 Thread Eric Blake
On 08/21/2013 10:51 AM, Paolo Bonzini wrote: Il 21/08/2013 18:48, Daniel P. Berrange ha scritto: No, on_crash is the right thing to be using for this from libvirt's pov I don't think we should invent something new. The on_crash element has always been intended to represent handling of guest

Re: [libvirt] [PATCH 2/3] pc: get rid of builtin pvpanic

2013-08-21 Thread Michael S. Tsirkin
On Wed, Aug 21, 2013 at 08:03:58PM +0300, Michael S. Tsirkin wrote: On Wed, Aug 21, 2013 at 06:43:15PM +0200, Paolo Bonzini wrote: It is a source of pain, and the previous patch anyway changed the behavior of -M pc-1.5 compared to the real 1.5. This also makes it clear that -device

Re: [libvirt] [PATCH 3/3] pvpanic: rename to isa-pvpanic

2013-08-21 Thread Paolo Bonzini
Il 21/08/2013 19:01, Michael S. Tsirkin ha scritto: The pvpanic situation is already messed up enough. Let us give our libvirt friends an easy indication that we have untied our side. Not-yet-signed-off-by: Paolo Bonzini pbonz...@redhat.com ... because we first have to determine how to

Re: [libvirt] [PATCH 2/3] pc: get rid of builtin pvpanic

2013-08-21 Thread Paolo Bonzini
Il 21/08/2013 19:03, Michael S. Tsirkin ha scritto: It is a source of pain, and the previous patch anyway changed the behavior of -M pc-1.5 compared to the real 1.5. This also makes it clear that -device pvpanic is not enough: it will not expose pvpanic in fw_cfg properly. No idea

Re: [libvirt] [PATCH 3/3] pvpanic: rename to isa-pvpanic

2013-08-21 Thread Michael S. Tsirkin
On Wed, Aug 21, 2013 at 07:01:39PM +0200, Paolo Bonzini wrote: Il 21/08/2013 19:01, Michael S. Tsirkin ha scritto: The pvpanic situation is already messed up enough. Let us give our libvirt friends an easy indication that we have untied our side. Not-yet-signed-off-by: Paolo Bonzini

Re: [libvirt] [RFC PATCH v2 0/3] Start fixing the pvpanic mess

2013-08-21 Thread Paolo Bonzini
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Il 21/08/2013 19:02, Eric Blake ha scritto: So, this boils down to a question of what SHOULD the valid states for on_crash be? Generically, we want on_crashdestroy/on_crash to not invalidate a guest, but also to not instantiate a pvpanic device;

Re: [libvirt] [RFC PATCH v2 0/3] Start fixing the pvpanic mess

2013-08-21 Thread Paolo Bonzini
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Il 21/08/2013 19:10, Eric Blake ha scritto: On 08/21/2013 10:56 AM, Paolo Bonzini wrote: eg it is valid to have on_crash present in the XML at all times, even if there's no pvpanic device present. That simply means the actions will never be

Re: [libvirt] [PATCH 2/3] pc: get rid of builtin pvpanic

2013-08-21 Thread Andreas Färber
Am 21.08.2013 19:02, schrieb Paolo Bonzini: Il 21/08/2013 19:03, Michael S. Tsirkin ha scritto: It is a source of pain, and the previous patch anyway changed the behavior of -M pc-1.5 compared to the real 1.5. This also makes it clear that -device pvpanic is not enough: it will not expose

[libvirt] [PATCH] libxl: fix libvirtd crash when reconnecting domains

2013-08-21 Thread Jim Fehlig
More fallout from commit d72ef888. When reconnecting to running domains, the libxl_ctx in libxlDomainObjPrivate was used before initializing it, causing a segfault in libxl and consequently crashing libvirtd. Initialize the libxlDomainObjPrivate libxl_ctx in libxlReconnectDomain, and while at it

Re: [libvirt] [RFC PATCH v2 0/3] Start fixing the pvpanic mess

2013-08-21 Thread Eric Blake
On 08/21/2013 10:56 AM, Paolo Bonzini wrote: eg it is valid to have on_crash present in the XML at all times, even if there's no pvpanic device present. That simply means the actions will never be triggered. So are you suggesting to add a pvpanic/ element to devices? That may be fine, but

Re: [libvirt] [RFC PATCH v2 0/3] Start fixing the pvpanic mess

2013-08-21 Thread Michael S. Tsirkin
On Wed, Aug 21, 2013 at 11:02:56AM -0600, Eric Blake wrote: On 08/21/2013 10:51 AM, Paolo Bonzini wrote: Il 21/08/2013 18:48, Daniel P. Berrange ha scritto: No, on_crash is the right thing to be using for this from libvirt's pov I don't think we should invent something new. The on_crash

Re: [libvirt] [PATCH 3/3] pvpanic: rename to isa-pvpanic

2013-08-21 Thread Michael S. Tsirkin
On Wed, Aug 21, 2013 at 07:06:21PM +0200, Paolo Bonzini wrote: Il 21/08/2013 19:07, Michael S. Tsirkin ha scritto: On Wed, Aug 21, 2013 at 07:01:39PM +0200, Paolo Bonzini wrote: Il 21/08/2013 19:01, Michael S. Tsirkin ha scritto: The pvpanic situation is already messed up enough. Let us

Re: [libvirt] [PATCH 3/3] pvpanic: rename to isa-pvpanic

2013-08-21 Thread Paolo Bonzini
Il 21/08/2013 19:07, Michael S. Tsirkin ha scritto: On Wed, Aug 21, 2013 at 07:01:39PM +0200, Paolo Bonzini wrote: Il 21/08/2013 19:01, Michael S. Tsirkin ha scritto: The pvpanic situation is already messed up enough. Let us give our libvirt friends an easy indication that we have untied our

Re: [libvirt] [PATCH] libxl: fix libvirtd crash when reconnecting domains

2013-08-21 Thread Eric Blake
On 08/21/2013 11:15 AM, Jim Fehlig wrote: More fallout from commit d72ef888. When reconnecting to running domains, the libxl_ctx in libxlDomainObjPrivate was used before initializing it, causing a segfault in libxl and consequently crashing libvirtd. Initialize the libxlDomainObjPrivate

Re: [libvirt] [PATCH 3/3] pvpanic: rename to isa-pvpanic

2013-08-21 Thread Andreas Färber
Am 21.08.2013 19:01, schrieb Michael S. Tsirkin: On Wed, Aug 21, 2013 at 06:43:16PM +0200, Paolo Bonzini wrote: The pvpanic situation is already messed up enough. Let us give our libvirt friends an easy indication that we have untied our side. Not-yet-signed-off-by: Paolo Bonzini

Re: [libvirt] [PATCH] libxl: fix libvirtd crash when reconnecting domains

2013-08-21 Thread Jim Fehlig
Eric Blake wrote: On 08/21/2013 11:15 AM, Jim Fehlig wrote: More fallout from commit d72ef888. When reconnecting to running domains, the libxl_ctx in libxlDomainObjPrivate was used before initializing it, causing a segfault in libxl and consequently crashing libvirtd. Initialize the

Re: [libvirt] [PATCH 3/3] pvpanic: rename to isa-pvpanic

2013-08-21 Thread Paolo Bonzini
Il 21/08/2013 19:35, Andreas Färber ha scritto: Am 21.08.2013 19:01, schrieb Michael S. Tsirkin: On Wed, Aug 21, 2013 at 06:43:16PM +0200, Paolo Bonzini wrote: The pvpanic situation is already messed up enough. Let us give our libvirt friends an easy indication that we have untied our side.

Re: [libvirt] [PATCH 2/3] pc: get rid of builtin pvpanic

2013-08-21 Thread Michael S. Tsirkin
On Wed, Aug 21, 2013 at 06:43:15PM +0200, Paolo Bonzini wrote: It is a source of pain, and the previous patch anyway changed the behavior of -M pc-1.5 compared to the real 1.5. This also makes it clear that -device pvpanic is not enough: it will not expose pvpanic in fw_cfg properly. No

Re: [libvirt] [RFC PATCH v2 0/3] Start fixing the pvpanic mess

2013-08-21 Thread Paolo Bonzini
Il 21/08/2013 19:26, Michael S. Tsirkin ha scritto: This is a QEMU bug that you happened to be Cc'd on. Michael, this is bullshit and you know. I know you're more intelligent than this. Stop it, please. Paolo -- libvir-list mailing list libvir-list@redhat.com

Re: [libvirt] [PATCH v2 3/9] domain_conf: Add default memballon in PostParse callbacks

2013-08-21 Thread Eric Blake
On 08/18/2013 12:57 PM, Cole Robinson wrote: This should be a no-op change for now. s/memballon/memballoon/ in the subject -- Eric Blake eblake redhat com+1-919-301-3266 Libvirt virtualization library http://libvirt.org signature.asc Description: OpenPGP digital signature --

Re: [libvirt] [PATCH] docs: Reformat disk attribute description in formatdomain

2013-08-21 Thread Eric Blake
On 08/20/2013 01:41 PM, John Ferlan wrote: Reformat the description to more cleanly delineate the attributes for a disk element. --- Similar to the recently changed source attribute. docs/formatdomain.html.in | 121 +++--- 1 file changed, 71

Re: [libvirt] [PATCH] Allow a HTTP URL for cdrom ISO image

2013-08-21 Thread Aline Manera
On 08/21/2013 01:51 PM, Daniel P. Berrange wrote: On Wed, Aug 21, 2013 at 01:47:36PM -0300, Aline Manera wrote: From: Aline Manera alin...@br.ibm.com QEMU/KVM already allows an HTTP URL for the cdrom ISO image so add this support to libvirt as well. The xml should be as following: disk

  1   2   >