Re: [libvirt] struct random on FreeBSD [was: FreeBSD-8.3 build failure for amd64/i386, build archive included]

2013-10-01 Thread Jason Helfman
On Mon, Sep 30, 2013 at 7:04 PM, Doug Goldstein car...@gentoo.org wrote: On Mon, Sep 30, 2013 at 2:27 PM, Jason Helfman j...@freebsd.org wrote: On Mon, Sep 30, 2013 at 11:50 AM, Eric Blake ebl...@redhat.com wrote: On 09/30/2013 10:09 AM, Jason Helfman wrote: So, what has to be

Re: [libvirt] [PATCH] libvirt: hostdev SCSI AdapterId retrieval fix

2013-10-01 Thread Boris Fiuczynski
Michal, I am sorry about that. Had some trouble sending the patch. Do you want me to resend it with a none-mangling email client? On 09/30/2013 03:14 PM, Michal Privoznik wrote: On 30.09.2013 13:20, Boris Fiuczynski wrote: Fixed the retrieval of the AdapterId from the AdapterName of the

[libvirt] Release of libvirt-1.1.3

2013-10-01 Thread Daniel Veillard
As scheduled I made the 1.1.3 release today, the git tree is tagged and tarball and rpms are available at the usual place: ftp://libvirt.org/libvirt/ Overall a rather big release, with more than 300 patches included, with a lot of fixes many of them being leaks or report from Coverity,

Re: [libvirt] [PATCH] libvirt: hostdev SCSI AdapterId retrieval fix

2013-10-01 Thread Michal Privoznik
On 01.10.2013 09:57, Boris Fiuczynski wrote: Michal, I am sorry about that. Had some trouble sending the patch. Do you want me to resend it with a none-mangling email client? No, the patch is already pushed. But just for the future: you can use 'git send-email' to send not mangled patches.

[libvirt] [PATCH 0/2] Support IPv6 in port allocator

2013-10-01 Thread Ján Tomko
Ján Tomko (2): Split out virHostHasIPv6 from qemuMigrationPrepareAny Bind to both IPv4 and v6 when checking port availability src/libvirt_private.syms| 1 + src/qemu/qemu_migration.c | 8 +--- src/util/virportallocator.c | 34 +++--- src/util/virutil.c

[libvirt] [PATCH 1/2] Split out virHostHasIPv6 from qemuMigrationPrepareAny

2013-10-01 Thread Ján Tomko
Split out the part of qemuMigrationPrepareAny that decides whether to listen on [::] or 0.0.0.0 by checking whether IPv6 is enabled on the host. --- src/libvirt_private.syms | 1 + src/qemu/qemu_migration.c | 8 +--- src/util/virutil.c| 14 ++ src/util/virutil.h

[libvirt] [PATCH 2/2] Bind to both IPv4 and v6 when checking port availability

2013-10-01 Thread Ján Tomko
If IPv6 is enabled on the host, bind to :: with IPV6_V6ONLY disabled to check for ports available on both IPv6 and IPv4. --- src/util/virportallocator.c | 34 +++--- 1 file changed, 27 insertions(+), 7 deletions(-) diff --git a/src/util/virportallocator.c

Re: [libvirt] [PATCH 2/2] Bind to both IPv4 and v6 when checking port availability

2013-10-01 Thread Daniel P. Berrange
On Tue, Oct 01, 2013 at 11:01:37AM +0200, Ján Tomko wrote: If IPv6 is enabled on the host, bind to :: with IPV6_V6ONLY disabled to check for ports available on both IPv6 and IPv4. --- src/util/virportallocator.c | 34 +++--- 1 file changed, 27 insertions(+), 7

Re: [libvirt] [PATCH 1/2] Split out virHostHasIPv6 from qemuMigrationPrepareAny

2013-10-01 Thread Daniel P. Berrange
On Tue, Oct 01, 2013 at 11:01:36AM +0200, Ján Tomko wrote: Split out the part of qemuMigrationPrepareAny that decides whether to listen on [::] or 0.0.0.0 by checking whether IPv6 is enabled on the host. --- src/libvirt_private.syms | 1 + src/qemu/qemu_migration.c | 8 +---

[libvirt] [PATCH] Fix handling of IPv6 listen addresses in cmdDomDisplay

2013-10-01 Thread Ján Tomko
Use virSocketAddrIsWildcard instead of STREQ to check for the ANY address and put brackets around the address if it contains ':'. --- tools/virsh-domain.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/tools/virsh-domain.c b/tools/virsh-domain.c index fa012d1..42c9920

Re: [libvirt] networking restart after redefinition

2013-10-01 Thread Laine Stump
On 09/30/2013 01:22 AM, Mihamina Rakotomandimby wrote: On 2013-09-28 09:53, Mihamina Rakotomandimby wrote: Hi all, Running Fedora 18 and the bundled libvirt and virt-tools. Desktop use. As I like to access my guests with a hostname and not a numerical IP address, I fix the IP addressing in

Re: [libvirt] libvirt-glib fails to compile with CLANG compiler

2013-10-01 Thread Christophe Fergeau
Hi, On Fri, Sep 27, 2013 at 12:09:43PM -0700, Jason Helfman wrote: On Thu, Sep 26, 2013 at 6:06 AM, Christophe Fergeau cferg...@redhat.comwrote: On Wed, Sep 25, 2013 at 09:31:52AM -0700, Jason Helfman wrote: When compiling libvirt-glib with CLANG, I get the following error. 16

Re: [libvirt] [PATCH] LXC: Detect fs support. Mount only supported fs in containers

2013-10-01 Thread Purcareata Bogdan-B43198
-Original Message- From: car...@cardoe.com [mailto:car...@cardoe.com] On Behalf Of Doug Goldstein Sent: Wednesday, September 25, 2013 6:26 PM To: Purcareata Bogdan-B43198 Cc: libvir-list Subject: Re: [libvirt] [PATCH] LXC: Detect fs support. Mount only supported fs in containers

[libvirt] [PATCH] qemu: cgroup: Fix crash if starting nographics guest

2013-10-01 Thread Cole Robinson
We can dereference graphics[0] even if guest has no graphics device configured. I screwed this up in a216e6487255d3b65d97c7ec1fa5da63dbced902 --- src/qemu/qemu_cgroup.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/qemu/qemu_cgroup.c b/src/qemu/qemu_cgroup.c index

Re: [libvirt] [PATCH] Fix handling of IPv6 listen addresses in cmdDomDisplay

2013-10-01 Thread Eric Blake
On 10/01/2013 03:33 AM, Ján Tomko wrote: Use virSocketAddrIsWildcard instead of STREQ to check for the ANY address and put brackets around the address if it contains ':'. --- tools/virsh-domain.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) ACK. -- Eric Blake eblake

Re: [libvirt] [PATCH] qemu: cgroup: Fix crash if starting nographics guest

2013-10-01 Thread Eric Blake
On 10/01/2013 05:56 AM, Cole Robinson wrote: We can dereference graphics[0] even if guest has no graphics device configured. I screwed this up in a216e6487255d3b65d97c7ec1fa5da63dbced902 --- src/qemu/qemu_cgroup.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) ACK. diff

[libvirt] [PATCH] selinux: Only close the selabel_handle once

2013-10-01 Thread Ján Tomko
On selinux driver initialization failure (missing/incorrectly formated contexts file), selabel_handle was closed twice. Introduced by 6159710. --- src/security/security_selinux.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/security/security_selinux.c

Re: [libvirt] [PATCH] Fix handling of IPv6 listen addresses in cmdDomDisplay

2013-10-01 Thread Ján Tomko
On 10/01/2013 02:04 PM, Eric Blake wrote: On 10/01/2013 03:33 AM, Ján Tomko wrote: Use virSocketAddrIsWildcard instead of STREQ to check for the ANY address and put brackets around the address if it contains ':'. --- tools/virsh-domain.c | 7 ++- 1 file changed, 6 insertions(+), 1

Re: [libvirt] [PATCH] selinux: Only close the selabel_handle once

2013-10-01 Thread Eric Blake
On 10/01/2013 06:44 AM, Ján Tomko wrote: On selinux driver initialization failure (missing/incorrectly formated contexts file), selabel_handle was closed twice. s/formated/formatted/ Introduced by 6159710. --- src/security/security_selinux.c | 5 - 1 file changed, 4 insertions(+), 1

Re: [libvirt] [PATCH] selinux: Only close the selabel_handle once

2013-10-01 Thread Ján Tomko
On 10/01/2013 02:52 PM, Eric Blake wrote: On 10/01/2013 06:44 AM, Ján Tomko wrote: On selinux driver initialization failure (missing/incorrectly formated contexts file), selabel_handle was closed twice. s/formated/formatted/ Introduced by 6159710. --- src/security/security_selinux.c |

Re: [libvirt] error: server response too large

2013-10-01 Thread Daniel P. Berrange
On Mon, Sep 30, 2013 at 04:24:49PM +0100, Daniel P. Berrange wrote: On Mon, Sep 30, 2013 at 05:23:33PM +0200, Michal Privoznik wrote: On 30.09.2013 17:02, Claudio Bley wrote: Hi. When trying to do a screenshot of a remote domain connected via qemu+tcp (for testing purposes only), I

[libvirt] [PATCH] qemu_hotplug: Allow QoS update in qemuDomainChangeNet

2013-10-01 Thread Michal Privoznik
The qemuDomainChangeNet() is called when 'virsh update-device' is invoked on a NIC. Currently, we fail to update the QoS even though we have routines for that. Signed-off-by: Michal Privoznik mpriv...@redhat.com --- src/qemu/qemu_hotplug.c | 14 -- 1 file changed, 12 insertions(+), 2

[libvirt] ANNOUNCE: libvirt 0.9.12.1 maintenance release

2013-10-01 Thread Guido Günther
libvirt 0.9.12.1 maintenance release is now available. This is libvirt 0.9.12 with additional bugfixes that have accumulated upstream since the initial release. This release can be downloaded at: http://libvirt.org/sources/stable_updates/libvirt-0.9.12.1.tar.gz Checksums: md5sum:

Re: [libvirt] ANNOUNCE: libvirt 1.0.5.6 maintenance release

2013-10-01 Thread Guido Günther
On Mon, Sep 23, 2013 at 01:36:40PM -0400, Cole Robinson wrote: On 09/23/2013 08:12 AM, Guido Günther wrote: Hi, On Fri, Sep 20, 2013 at 06:48:04PM -0400, Cole Robinson wrote: libvirt 1.0.5.6 maintenance release is now available. This is libvirt 1.0.5 with additional bugfixes that have

Re: [libvirt] [PATCH] qemu_hotplug: Allow QoS update in qemuDomainChangeNet

2013-10-01 Thread Laine Stump
On 10/01/2013 09:07 AM, Michal Privoznik wrote: The qemuDomainChangeNet() is called when 'virsh update-device' is invoked on a NIC. Currently, we fail to update the QoS even though we have routines for that. Signed-off-by: Michal Privoznik mpriv...@redhat.com --- src/qemu/qemu_hotplug.c |

[libvirt] [v0.9.12-maint] Distribute viratomic.h

2013-10-01 Thread Guido Günther
Sicne cbcb1983afbd76f0503185e4183afa10af88af47 we need viratmic.h in the distributed tarball as well. This fixes make distcheck. --- src/Makefile.am | 1 + 1 file changed, 1 insertion(+) diff --git a/src/Makefile.am b/src/Makefile.am index 6656fa0..88b6160 100644 --- a/src/Makefile.am +++

Re: [libvirt] [v0.9.12-maint] Distribute viratomic.h

2013-10-01 Thread Eric Blake
On 10/01/2013 09:00 AM, Guido Günther wrote: Sicne cbcb1983afbd76f0503185e4183afa10af88af47 we need viratmic.h in the distributed tarball as well. This fixes make distcheck. --- src/Makefile.am | 1 + 1 file changed, 1 insertion(+) ACK. diff --git a/src/Makefile.am b/src/Makefile.am

Re: [libvirt] [v0.9.12-maint] Distribute viratomic.h

2013-10-01 Thread Eric Blake
On 10/01/2013 09:00 AM, Guido Günther wrote: Sicne cbcb1983afbd76f0503185e4183afa10af88af47 we need viratmic.h in the s/Sicne/Since/ s/viratmic/viratomic/ distributed tarball as well. This fixes make distcheck. --- src/Makefile.am | 1 + 1 file changed, 1 insertion(+) diff --git

Re: [libvirt] [v0.9.12-maint] Distribute viratomic.h

2013-10-01 Thread Doug Goldstein
On Tue, Oct 1, 2013 at 10:00 AM, Guido Günther a...@sigxcpu.org wrote: Sicne cbcb1983afbd76f0503185e4183afa10af88af47 we need viratmic.h in the s/atmic/atomic/ distributed tarball as well. This fixes make distcheck. --- src/Makefile.am | 1 + 1 file changed, 1 insertion(+) diff --git

Re: [libvirt] [PATCH] qemu: cgroup: Fix crash if starting nographics guest

2013-10-01 Thread Cole Robinson
On 10/01/2013 08:07 AM, Eric Blake wrote: On 10/01/2013 05:56 AM, Cole Robinson wrote: We can dereference graphics[0] even if guest has no graphics device configured. I screwed this up in a216e6487255d3b65d97c7ec1fa5da63dbced902 --- src/qemu/qemu_cgroup.c | 5 +++-- 1 file changed, 3

Re: [libvirt] libvirt-glib fails to compile with CLANG compiler

2013-10-01 Thread Jason Helfman
On Tue, Oct 1, 2013 at 3:17 AM, Christophe Fergeau cferg...@redhat.comwrote: Hi, On Fri, Sep 27, 2013 at 12:09:43PM -0700, Jason Helfman wrote: On Thu, Sep 26, 2013 at 6:06 AM, Christophe Fergeau cferg...@redhat.com wrote: On Wed, Sep 25, 2013 at 09:31:52AM -0700, Jason Helfman wrote:

Re: [libvirt] [PATCH v3 1/8] test: Allow specifying object transient state in driver XML

2013-10-01 Thread Cole Robinson
On 09/26/2013 10:45 AM, Michal Privoznik wrote: On 25.09.2013 21:15, Cole Robinson wrote: Similar to the runstate commit, allow a boolean test:transient/ element for setting domain persistence at driver startup. --- v3: Validate that transient is not specified with runstate=shutoff

Re: [libvirt] [PATCH v3 2/8] test: Wire up managed save APIs

2013-10-01 Thread Cole Robinson
On 09/26/2013 10:44 AM, Michal Privoznik wrote: On 25.09.2013 21:15, Cole Robinson wrote: Also add a test:hasmanagedsave element to set this data when starting the connection. --- v3: Mandate managedsave have runstate=shutoff src/test/test_driver.c | 134

Re: [libvirt] libvirt-glib fails to compile with CLANG compiler

2013-10-01 Thread Daniel P. Berrange
On Tue, Oct 01, 2013 at 08:35:41AM -0700, Jason Helfman wrote: On Tue, Oct 1, 2013 at 3:17 AM, Christophe Fergeau cferg...@redhat.comwrote: Hi, On Fri, Sep 27, 2013 at 12:09:43PM -0700, Jason Helfman wrote: On Thu, Sep 26, 2013 at 6:06 AM, Christophe Fergeau cferg...@redhat.com

Re: [libvirt] [v0.9.12-maint] Distribute viratomic.h

2013-10-01 Thread Guido Günther
On Tue, Oct 01, 2013 at 09:05:54AM -0600, Eric Blake wrote: On 10/01/2013 09:00 AM, Guido Günther wrote: Sicne cbcb1983afbd76f0503185e4183afa10af88af47 we need viratmic.h in the s/Sicne/Since/ s/viratmic/viratomic/ Pushed with these fixed. Thanks, -- Guido distributed tarball as

Re: [libvirt] ANNOUNCE: libvirt 1.0.5.6 maintenance release

2013-10-01 Thread Eric Blake
On 10/01/2013 07:47 AM, Guido Günther wrote: - quick smoke test to make sure libvirt and virsh are working: -- stop system libvirtd -- sudo ./daemon/libvirt -- sudo ./tools/virsh list --all - make check make rpm make distcheck - cd po/ make update-po - bump configure.ac - bump rpm spec

Re: [libvirt] error: server response too large

2013-10-01 Thread Viktor Mihajlovski
On 10/01/2013 03:02 PM, Daniel P. Berrange wrote: On Mon, Sep 30, 2013 at 04:24:49PM +0100, Daniel P. Berrange wrote: On Mon, Sep 30, 2013 at 05:23:33PM +0200, Michal Privoznik wrote: On 30.09.2013 17:02, Claudio Bley wrote: Hi. When trying to do a screenshot of a remote domain connected via

Re: [libvirt] error: server response too large

2013-10-01 Thread Daniel P. Berrange
On Tue, Oct 01, 2013 at 06:13:10PM +0200, Viktor Mihajlovski wrote: On 10/01/2013 03:02 PM, Daniel P. Berrange wrote: On Mon, Sep 30, 2013 at 04:24:49PM +0100, Daniel P. Berrange wrote: On Mon, Sep 30, 2013 at 05:23:33PM +0200, Michal Privoznik wrote: On 30.09.2013 17:02, Claudio Bley wrote:

Re: [libvirt] [PATCH v3 3/8] test: Implement readonly snapshot APIs

2013-10-01 Thread Cole Robinson
On 09/26/2013 10:44 AM, Michal Privoznik wrote: On 25.09.2013 21:15, Cole Robinson wrote: This is just stolen from qemu_driver.c with tweaks to fit the test driver. --- src/test/test_driver.c | 392 + 1 file changed, 392 insertions(+) diff

Re: [libvirt] error: server response too large

2013-10-01 Thread Viktor Mihajlovski
On 10/01/2013 06:19 PM, Daniel P. Berrange wrote: What were you doing to get a message greater than 256KB ? This patch did not attempt to fix all possible combinations. If a API call such as virConnectListAllDomains has so much data that it requires 256KB to encode, this fix won't solve

Re: [libvirt] [PATCH v3 5/8] qemu: snapshots: Simplify REDEFINE flag check

2013-10-01 Thread Cole Robinson
On 09/26/2013 10:44 AM, Michal Privoznik wrote: On 25.09.2013 21:15, Cole Robinson wrote: Makes things more readable IMO --- src/qemu/qemu_driver.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index

Re: [libvirt] [PATCH v3 8/8] test: Allow specifying domainsnapshot XML

2013-10-01 Thread Cole Robinson
On 09/27/2013 02:13 AM, Michal Privoznik wrote: On 25.09.2013 21:15, Cole Robinson wrote: The user can pass it as a test:domainsnapshot subelement of a domain. --- src/test/test_driver.c | 99 +- 1 file changed, 98 insertions(+), 1

[libvirt] ANNOUNCE: libvirt 0.9.12.2 maintenance release

2013-10-01 Thread Guido Günther
libvirt 0.9.12.2 maintenance release is now available. This is libvirt 0.9.12 with additional bugfixes that have accumulated upstream since the initial release. This release can be downloaded at: http://libvirt.org/sources/stable_updates/libvirt-0.9.12.2.tar.gz md5sum:

Re: [libvirt] ANNOUNCE: libvirt 1.0.5.6 maintenance release

2013-10-01 Thread Guido Günther
On Tue, Oct 01, 2013 at 10:04:56AM -0600, Eric Blake wrote: On 10/01/2013 07:47 AM, Guido Günther wrote: - quick smoke test to make sure libvirt and virsh are working: -- stop system libvirtd -- sudo ./daemon/libvirt -- sudo ./tools/virsh list --all - make check make rpm make

Re: [libvirt] libvirt-glib fails to compile with CLANG compiler

2013-10-01 Thread Jason Helfman
On Tue, Oct 1, 2013 at 8:46 AM, Daniel P. Berrange berra...@redhat.comwrote: On Tue, Oct 01, 2013 at 08:35:41AM -0700, Jason Helfman wrote: On Tue, Oct 1, 2013 at 3:17 AM, Christophe Fergeau cferg...@redhat.com wrote: Hi, On Fri, Sep 27, 2013 at 12:09:43PM -0700, Jason Helfman

Re: [libvirt] [PATCHv4 1/4] net-dhcp-leases: Implement the public APIs

2013-10-01 Thread Nehal J Wani
Since we have lost the train for 1.1.3, changes in a/src/libvirt_public.syms attached. -- Nehal J Wani UG3, BTech CS+MS(CL) IIIT-Hyderabad 1.diff Description: Binary data -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCHv4 2/4] net-dhcp-leases: Implement the remote protocol

2013-10-01 Thread Nehal J Wani
In accordance with latest changes in rules for making building src/remote_protocol-structs, diff attached. -- Nehal J Wani UG3, BTech CS+MS(CL) IIIT-Hyderabad 2.diff Description: Binary data -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCHv4 3/4] net-dhcp-leases: Private implementation inside network driver

2013-10-01 Thread Nehal J Wani
Removing redundant if, diff attached. -- Nehal J Wani UG3, BTech CS+MS(CL) IIIT-Hyderabad 3.diff Description: Binary data -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCHv4 4/4] net-dhcp-leases: Add virsh support

2013-10-01 Thread Nehal J Wani
In accordance with latest rule: use VIR_STRDUP instead of virAsprintf with %s Diff attached. -- Nehal J Wani UG3, BTech CS+MS(CL) IIIT-Hyderabad 4.diff Description: Binary data -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCHv4 4/4] net-dhcp-leases: Add virsh support

2013-10-01 Thread Nehal J Wani
Rectified attachment. -- Nehal J Wani UG3, BTech CS+MS(CL) IIIT-Hyderabad 4.diff Description: Binary data -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCHv4 1/4] net-dhcp-leases: Implement the public APIs

2013-10-01 Thread Nehal J Wani
Rectified attachment. -- Nehal J Wani UG3, BTech CS+MS(CL) IIIT-Hyderabad 1.diff Description: Binary data -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCHv4 3/4] net-dhcp-leases: Private implementation inside network driver

2013-10-01 Thread Nehal J Wani
Rectified attachment. -- Nehal J Wani UG3, BTech CS+MS(CL) IIIT-Hyderabad 3.diff Description: Binary data -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCHv4 2/4] net-dhcp-leases: Implement the remote protocol

2013-10-01 Thread Nehal J Wani
Rectified attachment. -- Nehal J Wani UG3, BTech CS+MS(CL) IIIT-Hyderabad 2.diff Description: Binary data -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCHv4 1/4] net-dhcp-leases: Implement the public APIs

2013-10-01 Thread Eric Blake
On 09/26/2013 02:08 AM, Nehal J Wani wrote: Introduce 3 new APIs, virNetworkGetDHCPLeases, virNetworkGetDHCPLeasesForMAC and virNetworkDHCPLeaseFree. * virNetworkGetDHCPLeases: returns the dhcp leases information for a given virtual network. For DHCPv4, the information includes:

Re: [libvirt] [PATCHv4 1/4] net-dhcp-leases: Implement the public APIs

2013-10-01 Thread Eric Blake
On 10/01/2013 04:16 PM, Nehal J Wani wrote: Rectified attachment. A patch of a patch is hard to review; you're better off reposting a clean v5. That said, I'll still try to review, so you may want to wait for comments so you can save some churn by fixing those in your v5. -- Eric Blake

Re: [libvirt] [PATCHv4 2/4] net-dhcp-leases: Implement the remote protocol

2013-10-01 Thread Eric Blake
On 09/26/2013 02:08 AM, Nehal J Wani wrote: Implement RPC calls for virNetworkGetDHCPLeases, virNetworkGetDHCPLeasesForMAC --- daemon/remote.c | 157 src/remote/remote_driver.c | 169 ++-

Re: [libvirt] [PATCHv4 1/4] net-dhcp-leases: Implement the public APIs

2013-10-01 Thread Nehal J Wani
I sense some struggle in getting the interface right - for everyone's sake, let's FIRST get the interface nailed down, rather than churning on implementations of something that then has to be reworked because the interface wasn't correct. Agreed. I hope we can have some discussion on whether

Re: [libvirt] [PATCHv4 1/4] net-dhcp-leases: Implement the public APIs

2013-10-01 Thread Nehal J Wani
According to commit 2d5cd1d724084d9975b2514fb31776627acbe997, libvirt supports DHCPv6. The virNetworkGetDHCPLeases API doesn't mention anywhere (in its name) that it is specific to DHCPv4. Hence I thought of adding the support for DHCPv6. Since the format for DHCPv6 leases is a bit different, it