[libvirt] PATCH: pci-subsystem: ixgbe: SR-IOV: kernel way to order driver's virtfn -entries is odd causing libvirt failures.

2013-10-24 Thread Niilona
Hi. As Bjorn Helgaas recommend, this might be the item to discuss in the wider area. --- There is a behavior effecting virtfn -entries in sysfs, when amount of them increases over 10. Run VM's through LIBVIRT - QEMU/KVM, this causes : - MAC address setting by

[libvirt] [PATCH] virsh domxml-from-native to treat SCSI as the bus type for pseries by default

2013-10-24 Thread Shivaprasad G Bhat
From: Shivaprasad G Bhat sb...@linux.vnet.ibm.com The bus type IDE being enum Zero, the bus type on pseries system appears as IDE for all the disk types. Pseries platform needs this to appear as SCSI instead of IDE. Signed-off-by: Shivaprasad G Bhat sb...@linux.vnet.ibm.com ---

[libvirt] [PATCHv2 0/2] virsh: hide 'attach-disk --shareable'

2013-10-24 Thread Eric Blake
As promised here: https://www.redhat.com/archives/libvir-list/2013-October/msg01047.html Eric Blake (2): virsh: allow alias to expand to opt=value pair virsh: undocument --shareable (--mode already covers it) tests/virshtest.c| 1 + tools/virsh-domain.c | 11 -- tools/virsh.c

[libvirt] [PATCHv2 2/2] virsh: undocument --shareable (--mode already covers it)

2013-10-24 Thread Eric Blake
Commit e962a57 added 'attach-disk --shareable', even though we already had 'attach-disk --mode=shareable'. Worse, if the user types 'attach-disk --mode=readonly --shareable', we create non-sensical XML. The best solution is just to undocument the duplicate spelling, by having it fall back to the

[libvirt] [PATCHv2 1/2] virsh: allow alias to expand to opt=value pair

2013-10-24 Thread Eric Blake
We want to treat 'attach-disk --shareable' as an undocumented alias for 'attach-disk --mode=shareable'. By improving our alias handling, we can allow all such --bool - --opt=value replacements, and guarantee up front that the alias is not mixed with its replacement. * tools/virsh.c

Re: [libvirt] [PATCH] virsh domxml-from-native to treat SCSI as the bus type for pseries by default

2013-10-24 Thread Li Zhang
On 2013年10月24日 15:07, Shivaprasad G Bhat wrote: From: Shivaprasad G Bhat sb...@linux.vnet.ibm.com The bus type IDE being enum Zero, the bus type on pseries system appears as IDE for all the disk types. Pseries platform needs this to appear as SCSI instead of IDE. Signed-off-by: Shivaprasad G

Re: [libvirt] [PATCH] virsh domxml-from-native to treat SCSI as the bus type for pseries by default

2013-10-24 Thread Eric Blake
On 10/24/2013 08:07 AM, Shivaprasad G Bhat wrote: From: Shivaprasad G Bhat sb...@linux.vnet.ibm.com The bus type IDE being enum Zero, the bus type on pseries system appears as IDE for all the disk types. Pseries platform needs this to appear as SCSI instead of IDE. Signed-off-by:

[libvirt] failed to write to disk on vm with lvm pool

2013-10-24 Thread Vasiliy Tolstov
Hi all. Today i can't mkfs.ext3 inside virual machine while install it (ubuntu 13.04). Why this happening? On other node i see that virSecurityDACSetOwnership sets perms on /dev/vg/xxx and /dev/dm-xxx, but in this host this not happening. Libvirt logs: 2013-10-24 07:50:15.639+: 3700: info :

Re: [libvirt] PATCH: pci-subsystem: ixgbe: SR-IOV: kernel way to order driver's virtfn -entries is odd causing libvirt failures.

2013-10-24 Thread Daniel P. Berrange
On Thu, Oct 24, 2013 at 09:52:31AM +0300, Niilona wrote: Hi. As Bjorn Helgaas recommend, this might be the item to discuss in the wider area. --- There is a behavior effecting virtfn -entries in sysfs, when amount of them increases over 10. Run VM's

[libvirt] [PATCH 0/3] Add complete blkiotune support for per-device with blkio cgroup

2013-10-24 Thread Guan Qiang
From: Guan Qiang hzguanqi...@corp.netease.com The patches add a complete blkiotune support per-device with blkio cgroup for both lxc or qemu driver, by extending the existed 'domainSetBlkioParameters' and 'domainGetBlkioParameters' interface. Beside device weight, read/write bps and iops

[libvirt] [PATCH 2/3] lxc: add blkiotune support for per device

2013-10-24 Thread Guan Qiang
From: Guan Qiang hzguanqi...@corp.netease.com This add per-device weight, iops and bps throttle to blkiotune. By extending the existed 'domainSetBlkioParameters' interface, blkiotune for per-device can be set with blkio cgroup. --- src/lxc/lxc_driver.c | 743

[libvirt] [PATCH 3/3] blkiotune: add virsh support for blkiotune interface

2013-10-24 Thread Guan Qiang
From: Guan Qiang hzguanqi...@corp.netease.com This adds four parameters --device-read-bps, --device-write-bps, --device-read-iops and --device-write-iops to virsh command blkiotune for setting/getting blkiotune.throttle.{read/write}_{iops/bps}_device. --- tools/virsh-domain.c | 64

[libvirt] [PATCH] virsh: fix doc typos

2013-10-24 Thread Eric Blake
Reported in https://bugzilla.redhat.com/show_bug.cgi?id=1022872 * tools/virsh.pod: s/COMMMANDS/COMMANDS/ Signed-off-by: Eric Blake ebl...@redhat.com --- Pushing as trivial. tools/virsh.pod | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/tools/virsh.pod

Re: [libvirt] [PATCH] Quick fix for config-demo.py

2013-10-24 Thread Christophe Fergeau
On Tue, Oct 22, 2013 at 03:50:36PM -0700, Ian Main wrote: I guess this must have been changed and the demo not updated. Fix the demo so it uses the right value. ACK (this was broken in c6b98f67d4b794ae1a91bf9fdff3445f1135bc85 , I tried to update to update the demo but somehow failed at it ;)

Re: [libvirt] [PATCH] Quick fix for config-demo.py

2013-10-24 Thread Michal Privoznik
On 22.10.2013 23:50, Ian Main wrote: I guess this must have been changed and the demo not updated. Fix the demo so it uses the right value. Signed-off-by: Ian Main im...@redhat.com --- examples/config-demo.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [libvirt] [libvirt-glib PATCH v2] Add filterref and filterref parameter support.

2013-10-24 Thread Christophe Fergeau
On Tue, Oct 22, 2013 at 03:48:36PM -0700, Ian Main wrote: This patch adds support for setting filterref's on interfaces. Also supported are parameters to the filterref's. V2: - alphabetical orderized (don't look it up!) Makefile.am - s/set_filter/set_name/ s/get_filter/get_name/ -

Re: [libvirt] [PATCHv2 1/2] virsh: allow alias to expand to opt=value pair

2013-10-24 Thread Chen Hanxiao
-Original Message- From: Eric Blake [mailto:ebl...@redhat.com] Sent: Thursday, October 24, 2013 3:22 PM To: libvir-list@redhat.com Cc: chenhanx...@cn.fujitsu.com Subject: [PATCHv2 1/2] virsh: allow alias to expand to opt=value pair We want to treat 'attach-disk --shareable' as

[libvirt] [PATCH] libxl: Fix possible invalid read

2013-10-24 Thread Martin Kletzander
According to the following valgrind output, there seems to be a invalid limit for the iterator (captured on Fedora 19): ==3945== Invalid read of size 1 ==3945==at 0x1E1FA410: libxlVmStart (libxl_driver.c:475) ==3945==by 0x1E1FAD9A: libxlDomainCreateWithFlags (libxl_driver.c:2633) ==3945==

Re: [libvirt] failed to write to disk on vm with lvm pool

2013-10-24 Thread Vasiliy Tolstov
2013/10/24 Vasiliy Tolstov v.tols...@selfip.ru: Hi all. Today i can't mkfs.ext3 inside virual machine while install it (ubuntu 13.04). Why this happening? On other node i see that virSecurityDACSetOwnership sets perms on /dev/vg/xxx and /dev/dm-xxx, but in this host this not happening. Ps.

Re: [libvirt] RHBZ 1013045: Crash on xen domain startup

2013-10-24 Thread Martin Kletzander
On Wed, Oct 23, 2013 at 10:46:14AM -0700, Jeremy Fitzhardinge wrote: Hi all, I posted this bug (https://bugzilla.redhat.com/show_bug.cgi?id=1013045) to the Redhat Bugzilla a while ago, and the only response has been to post a note to this list about the bug. Summary below, but it looks

Re: [libvirt] [PATCH] Avoid Coverity DEADCODE warning

2013-10-24 Thread John Ferlan
Ping On 10/18/2013 06:59 AM, John Ferlan wrote: Commit '922b7fda' resulted in two DEADCODE warnings from Coverity in remoteDispatchAuthPolkit and virAccessDriverPolkitFormatProcess. Commit '604ae657' modified the daemon.c code to remove the deadcode issue, but did not do so for

Re: [libvirt] [PATCH]lxc: improve readability of lxcContainer[Send|Waitfor]Continue

2013-10-24 Thread Chen Hanxiao
Subject: Re: [libvirt] [PATCH]lxc: improve readability of lxcContainer[Send|Waitfor]Continue On 16.10.2013 08:27, Chen Hanxiao wrote: From: Chen Hanxiao chenhanx...@cn.fujitsu.com I think this can be achieved even without this hack. We already can produce a stack trace on

Re: [libvirt] [PATCH] libxl: Fix possible invalid read

2013-10-24 Thread Daniel P. Berrange
On Thu, Oct 24, 2013 at 10:50:02AM +0100, Martin Kletzander wrote: According to the following valgrind output, there seems to be a invalid limit for the iterator (captured on Fedora 19): ==3945== Invalid read of size 1 ==3945==at 0x1E1FA410: libxlVmStart (libxl_driver.c:475) ==3945==

Re: [libvirt] [PATCHv2 2/2] virsh: undocument --shareable (--mode already covers it)

2013-10-24 Thread Chen Hanxiao
-Original Message- From: Eric Blake [mailto:ebl...@redhat.com] Sent: Thursday, October 24, 2013 3:22 PM To: libvir-list@redhat.com Cc: chenhanx...@cn.fujitsu.com Subject: [PATCHv2 2/2] virsh: undocument --shareable (--mode already covers it) Commit e962a57 added 'attach-disk

Re: [libvirt] [PATCHv2 0/2] virsh: hide 'attach-disk --shareable'

2013-10-24 Thread Peter Krempa
On 10/24/13 08:21, Eric Blake wrote: As promised here: https://www.redhat.com/archives/libvir-list/2013-October/msg01047.html Eric Blake (2): virsh: allow alias to expand to opt=value pair virsh: undocument --shareable (--mode already covers it) tests/virshtest.c| 1 +

Re: [libvirt] [PATCH] libxl: Fix possible invalid read

2013-10-24 Thread Martin Kletzander
On Thu, Oct 24, 2013 at 10:57:37AM +0100, Daniel P. Berrange wrote: On Thu, Oct 24, 2013 at 10:50:02AM +0100, Martin Kletzander wrote: According to the following valgrind output, there seems to be a invalid limit for the iterator (captured on Fedora 19): ==3945== Invalid read of size 1

Re: [libvirt] [PATCH] Avoid Coverity DEADCODE warning

2013-10-24 Thread Eric Blake
On 10/18/2013 11:59 AM, John Ferlan wrote: Commit '922b7fda' resulted in two DEADCODE warnings from Coverity in remoteDispatchAuthPolkit and virAccessDriverPolkitFormatProcess. Commit '604ae657' modified the daemon.c code to remove the deadcode issue, but did not do so for

Re: [libvirt] [PATCHv2 0/2] virsh: hide 'attach-disk --shareable'

2013-10-24 Thread Eric Blake
On 10/24/2013 11:05 AM, Peter Krempa wrote: On 10/24/13 08:21, Eric Blake wrote: As promised here: https://www.redhat.com/archives/libvir-list/2013-October/msg01047.html Eric Blake (2): virsh: allow alias to expand to opt=value pair virsh: undocument --shareable (--mode already covers

Re: [libvirt] [PATCH] Avoid Coverity DEADCODE warning

2013-10-24 Thread Martin Kletzander
On Fri, Oct 18, 2013 at 06:59:51AM -0400, John Ferlan wrote: Commit '922b7fda' resulted in two DEADCODE warnings from Coverity in remoteDispatchAuthPolkit and virAccessDriverPolkitFormatProcess. Commit '604ae657' modified the daemon.c code to remove the deadcode issue, but did not do so for

Re: [libvirt] [PATCH] Avoid Coverity DEADCODE warning

2013-10-24 Thread John Ferlan
Thanks for the reviews - pushed now. John -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCHv2 0/8] Introduce paravirtual spinlock support

2013-10-24 Thread Peter Krempa
On 10/17/13 14:10, Peter Krempa wrote: Version 2 fixes stuff pointed out in Dan's review Jiri Denemark (2): cpu: Export few x86-specific APIs qemu: Add monitor APIs to fetch CPUID data from QEMU Peter Krempa (6): cpu_x86: Refactor storage of CPUID data to add support for KVM

Re: [libvirt] [PATCH]lxc: improve readability of lxcContainer[Send|Waitfor]Continue

2013-10-24 Thread Martin Kletzander
On Thu, Oct 24, 2013 at 05:55:59PM +0800, Chen Hanxiao wrote: Subject: Re: [libvirt] [PATCH]lxc: improve readability of lxcContainer[Send|Waitfor]Continue On 16.10.2013 08:27, Chen Hanxiao wrote: From: Chen Hanxiao chenhanx...@cn.fujitsu.com I think this can be achieved

Re: [libvirt] [Qemu-devel] [PATCH 14/17] add new RanState RAN_STATE_FLIPPING_MIGRATE

2013-10-24 Thread Paolo Bonzini
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Il 22/10/2013 09:10, Eric Blake ha scritto: http://wiki.qemu.org/Planning/1.7 Soft freeze has already happened, so it's up to the maintainers whether there is still time to be adding this feature in 1.7 - but yes, that would affect the tag you

Re: [libvirt] [Qemu-devel] [PATCH 14/17] add new RanState RAN_STATE_FLIPPING_MIGRATE

2013-10-24 Thread Paolo Bonzini
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Il 22/10/2013 04:51, Eric Blake ha scritto: Last time we added a new user-visible runstate, it broke migration with older libvirt versions that weren't prepared to see the new state (hmm, I need to check if libvirt has fixed that in the

Re: [libvirt] [RFC] net-dhcp-leases: Query: Reg: Leases API Script

2013-10-24 Thread Nehal J Wani
I tried writing the helper program, didn't send v5, since I have some doubts. The program works. Problems listed below. diff --git a/src/Makefile.am b/src/Makefile.am index 21b9caf..ef88132 100644 --- a/src/Makefile.am +++ b/src/Makefile.am @@ -825,6 +825,9 @@ STORAGE_HELPER_DISK_SOURCES =

[libvirt] [PATCH] virnetsocket: fix getsockopt on FreeBSD

2013-10-24 Thread Ryota Ozaki
aa0f099 introduced a strict error checking for getsockopt and it revealed that getting a peer credential of a socket on FreeBSD didn't work. Libvirtd hits the error: error : virNetSocketGetUNIXIdentity:1198 : Failed to get valid client socket identity groups SOL_SOCKET (0x) was used as a

Re: [libvirt] RHBZ 1013045: Crash on xen domain startup

2013-10-24 Thread Jeremy Fitzhardinge
-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 On 10/24/2013 02:52 AM, Martin Kletzander wrote: On Wed, Oct 23, 2013 at 10:46:14AM -0700, Jeremy Fitzhardinge wrote: Hi all, I posted this bug (https://bugzilla.redhat.com/show_bug.cgi?id=1013045) to the Redhat Bugzilla a while ago, and the

Re: [libvirt] [PATCH]lxc: improve readability of lxcContainer[Send|Waitfor]Continue

2013-10-24 Thread Chen Hanxiao
-Original Message- From: Martin Kletzander [mailto:mklet...@redhat.com] Sent: Thursday, October 24, 2013 6:52 PM To: Chen Hanxiao Cc: 'Michal Privoznik'; libvir-list@redhat.com Subject: Re: [libvirt] [PATCH]lxc: improve readability of lxcContainer[Send|Waitfor]Continue On Thu,

Re: [libvirt] [PATCH 0/3] Add complete blkiotune support for per-device with blkio cgroup

2013-10-24 Thread hzguanqi...@corp.netease.com
Hi, guys, I've developed some patches to support setting device iops and bps with blkio cgroup, by extending the existed 'domainSetBlkioParameters' and 'domainGetBlkioParameters' interface. Please help me to review the patches and give me your expertise. Thanks very much. On 2013-10-24 16:18

[libvirt] [PATCH 1/2]virsh: introduce member exclude_option in vshCmdOptDef and improve auto complete with it

2013-10-24 Thread Chen Hanxiao
From: Chen Hanxiao chenhanx...@cn.fujitsu.com If we need to exclude one parameter from another, we could use member 'exclude_option' to specify one. With this flag, we could archive what Eric comments on: https://www.redhat.com/archives/libvir-list/2013-October/msg00965.html 1. COMMAND TAB or

[libvirt] [PATCH 0/2] improve auto complete in virsh

2013-10-24 Thread Chen Hanxiao
From: Chen Hanxiao chenhanx...@cn.fujitsu.com Chen Hanxiao (2): [libvirt]virsh: introduce member exclude_option in vshCmdOptDef and improve auto complete with it [libvirt]virsh: set --shareable and --mode's new member: exclude_option tools/virsh-domain.c | 6 -- tools/virsh.c

[libvirt] [PATCH 2/2]virsh: set --shareable and --mode's new member: exclude_option

2013-10-24 Thread Chen Hanxiao
From: Chen Hanxiao chenhanx...@cn.fujitsu.com Signed-off-by: Chen Hanxiao chenhanx...@cn.fujitsu.com --- tools/virsh-domain.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/tools/virsh-domain.c b/tools/virsh-domain.c index 59e3d8d..cb2678b 100644 ---

[libvirt] [PATCH]doc: fix a typo in formatdomain

2013-10-24 Thread Chen Hanxiao
From: Chen Hanxiao chenhanx...@cn.fujitsu.com s/no/not Signed-off-by: Chen Hanxiao chenhanx...@cn.fujitsu.com --- docs/formatdomain.html.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/formatdomain.html.in b/docs/formatdomain.html.in index 8ad755b..aa90701 100644 ---