- Original Message -
The 'out' returned from exec_cmds is not 'None' type if stderr occurs, it is
because utils pass 'subprocess.PIPE' to stdout to open this subprocess.
Similarly, to get anything other than None in the result tuple, you need to
give stdout=PIPE and/or stderr=PIPE
On 11/12/2013 05:59 PM, Eric Farman wrote:
For systems without a PCI bus, attaching a SCSI controller fails:
[root@ ~]# cat controller.xml
controller type='scsi' model='virtio-scsi' index='0' /
[root@ ~]# virsh attach-device guest01 controller.xml
error: Failed to
---
Pushed as trivial.
src/util/virjson.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/src/util/virjson.c b/src/util/virjson.c
index f0a06ab..7044e11 100644
--- a/src/util/virjson.c
+++ b/src/util/virjson.c
@@ -1018,9 +1018,8 @@ cleanup:
if (parser.nstate) {
On 11/15/2013 08:47 AM, Martin Kletzander wrote:
On Tue, Nov 05, 2013 at 03:59:55PM +0100, Ján Tomko wrote:
---
tests/jsontest.c | 13 +
1 file changed, 13 insertions(+)
ACK if you want to use the second option.
I've changed it as you suggested and pushed it.
Thanks!
Jan
It makes no sense to go forward to get the parent host number of a
HBA, and treat the HBA as a vHBA with trying to delete it.
---
src/storage/storage_backend_scsi.c | 8
1 file changed, 8 insertions(+)
diff --git a/src/storage/storage_backend_scsi.c
b/src/storage/storage_backend_scsi.c
On 20/11/13 08:30, Eric Blake wrote:
Most of our code base uses space after comma but not before;
fix the remaining uses before adding a syntax check.
* src/nwfilter/nwfilter_ebiptables_driver.c: Consistently use
commas.
* src/nwfilter/nwfilter_gentech_driver.c: Likewise.
*
On 20/11/13 08:30, Eric Blake wrote:
Most of our code base uses space after comma but not before;
fix the remaining uses before adding a syntax check.
* src/conf/capabilities.c: Consistently use commas.
* src/conf/domain_conf.c: Likewise.
* src/conf/network_conf.c: Likewise.
*
On 20/11/13 08:30, Eric Blake wrote:
Most of our code base uses space after comma but not before;
fix the remaining uses before adding a syntax check.
* src/libxl/libxl_driver.c: Consistently use commas.
* src/xen/xend_internal.c: Likewise.
* src/xen/xs_internal.c: Likewise.
*
On 20/11/13 08:30, Eric Blake wrote:
Most of our code base uses space after comma but not before;
fix the remaining uses before adding a syntax check.
* src/qemu/qemu_cgroup.c: Consistently use commas.
* src/qemu/qemu_command.c: Likewise.
* src/qemu/qemu_conf.c: Likewise.
*
On 20/11/13 08:30, Eric Blake wrote:
Most of our code base uses space after comma but not before;
fix the remaining uses before adding a syntax check.
* tests/sysinfotest.c: Consistently use commas.
* tests/viratomictest.c: Likewise.
* tests/vircgroupmock.c: Likewise.
* tools/virsh-domain.c:
On 20/11/13 08:30, Eric Blake wrote:
Most of our code base uses space after comma but not before;
fix the remaining uses before adding a syntax check.
* src/util/vircommand.c: Consistently use commas.
* src/util/virlog.c: Likewise.
* src/util/virnetdevbandwidth.c: Likewise.
*
On 20/11/13 08:30, Eric Blake wrote:
Most of our code base uses space after comma but not before;
fix the remaining uses before adding a syntax check.
* python/libvirt-override.c: Consistently use commas.
Signed-off-by: Eric Blakeebl...@redhat.com
---
python/libvirt-override.c | 12
On Wed, Nov 13, 2013 at 12:02:08PM +1100, Michael Chapman wrote:
RHEL's rpmbuild wipes the docdir for a (sub-)package if any %doc
directives are present, prior to copying in the marked documentation.
This means we can't prepopulate this directory with the HTML
documentation during the %install
On 20/11/13 08:30, Eric Blake wrote:
Most of our code base uses space after comma but not before;
fix the remaining uses before adding a syntax check.
* src/lxc/lxc_container.c: Consistently use commas.
* src/openvz/openvz_driver.c: Likewise.
* src/openvz/openvz_util.c: Likewise.
*
On 20/11/13 08:30, Eric Blake wrote:
Most of our code base uses space after comma but not before;
fix the remaining uses before adding a syntax check.
* src/vbox/vbox_tmpl.c: Consistently use commas.
Signed-off-by: Eric Blakeebl...@redhat.com
---
src/vbox/vbox_tmpl.c | 27
On 20/11/13 08:30, Eric Blake wrote:
Most of our code base uses space after comma but not before;
fix the remaining uses before adding a syntax check.
* src/network/bridge_driver.c: Consistently use commas.
* src/node_device/node_device_hal.c: Likewise.
* src/node_device/node_device_udev.c:
On 20/11/13 08:30, Eric Blake wrote:
Enforce and document the style set up by the previous patches.
* build-aux/bracket-spacing.pl: Add comma checks.
* docs/hacking.html.in: Document the rules.
* HACKING: Regenerate.
Signed-off-by: Eric Blake ebl...@redhat.com
---
HACKING
On 20/11/13 06:17, Doug Goldstein wrote:
In commit de51dc9c9, we removed virConnectGetCPUModelNames from
skip_impl but without this the module will always generate a symbol for
libvirt_virConnectGetCPUModelNames which we don't always want.
CC: Giuseppe Scrivano gscri...@redhat.com
---
I
On 11/19/2013 03:29 PM, Cole Robinson wrote:
On 11/19/2013 03:27 PM, Eric Blake wrote:
On 11/19/2013 01:22 PM, Cole Robinson wrote:
Possible fix for occasional libvirt-guests failure at boot time.
---
tools/libvirt-guests.service.in | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
On Nov 19, 2013, at 23:20 , Dan Kenigsberg dan...@redhat.com wrote:
On Tue, Nov 19, 2013 at 04:36:24PM +, Martin Goldstone wrote:
Hi all,
We're currently experiencing an issue in our production oVirt 3.2.2
environment (on CentOS 6.4) with time keeping on our Windows guests. It
seems
On 11/20/2013 05:44 AM, Osier Yang wrote:
It makes no sense to go forward to get the parent host number of a
HBA, and treat the HBA as a vHBA with trying to delete it.
---
src/storage/storage_backend_scsi.c | 8
1 file changed, 8 insertions(+)
ACK.
diff --git
On Tue, Nov 19, 2013 at 4:17 PM, Doug Goldstein car...@cardoe.com wrote:
In commit de51dc9c9, we removed virConnectGetCPUModelNames from
skip_impl but without this the module will always generate a symbol for
libvirt_virConnectGetCPUModelNames which we don't always want.
CC: Giuseppe
In anticipation of the python bindings moving to their own repo and in
an effort to preserve history, move the examples within the python/
directory.
---
Makefile.am| 3 +--
configure.ac
On 11/20/2013 06:26 AM, Osier Yang wrote:
On 20/11/13 08:30, Eric Blake wrote:
Enforce and document the style set up by the previous patches.
* build-aux/bracket-spacing.pl: Add comma checks.
* docs/hacking.html.in: Document the rules.
* HACKING: Regenerate.
+When declaring an enum or
We've got a couple of versions of libvirt and qemu installed across our
boxes:
qemu-kvm-0.12.1.2-2.355.0.1.el6.centos.6.x86_64
libvirt-0.10.2-18.el6_4.9.x86_64
qemu-kvm-0.12.1.2-2.355.0.1.el6_4.9.x86_64
libvirt-0.10.2-18.el6_4.14.x86_64
qemu-kvm-0.12.1.2-2.355.0.1.el6.centos.7.x86_64
On 11/20/2013 04:16 AM, Ján Tomko wrote:
On 11/12/2013 05:59 PM, Eric Farman wrote:
For systems without a PCI bus, attaching a SCSI controller fails:
[root@ ~]# cat controller.xml
controller type='scsi' model='virtio-scsi' index='0' /
[root@ ~]# virsh attach-device
On 11/19/2013 04:49 PM, Clark Laughlin wrote:
These changes allow the correct virtio-blk-device and virtio-net-device
devices to be used for the 'virt' machine type for armv7 rather than the
PCI virtio devices.
A test case was added to qemuxml2argvtest for this change.
Signed-off-by:
On 11/19/2013 10:43 AM, Cédric Bosdonnat wrote:
These changes are all about bringing events for network object like the
ones existing for domains. This feature is needed for virt-manager to
refresh its UI when networks are started/destroyed/defined/undefined.
The first commit is a
On 11/19/2013 10:43 AM, Cédric Bosdonnat wrote:
The idea behind this commit is to make use of the Domain event
mechanism for other events like network ones. This introduces some
renaming from virDomainEvent* to virOjbectEvent*.
---
diff --git a/src/Makefile.am b/src/Makefile.am
index
If a SCSI hostdev is included in an initial domain XML, without a
corresponding controller statement, one is created silently when the
guest is booted.
When hotplugging a SCSI hostdev, a presumption is that the controller
is already present in the domain either from the original XML, or via
an
Today, hotplug of a SCSI hostdev relies on the presence of an existing
SCSI controller, which can be defined in the initial domain XML. Hotplug
of a SCSI controller relies on the presence of a PCI bus, which does not
work in all environments.
These patches correct this behavior, in order to
For attach/detach of controller devices, we rename the functions to
remove 'PCI' from their title. The actual separation of PCI-specific
operations will be handled in the next patch.
Signed-off-by: Eric Farman far...@linux.vnet.ibm.com
---
src/qemu/qemu_driver.c |4 ++--
For systems without a PCI bus, attaching a SCSI controller fails:
[root@ ~]# cat controller.xml
controller type='scsi' model='virtio-scsi' index='0' /
[root@ ~]# virsh attach-device guest01 controller.xml
error: Failed to attach device from controller.xml
error: XML
On 20/11/13 23:57, Eric Blake wrote:
On 11/20/2013 05:44 AM, Osier Yang wrote:
It makes no sense to go forward to get the parent host number of a
HBA, and treat the HBA as a vHBA with trying to delete it.
---
src/storage/storage_backend_scsi.c | 8
1 file changed, 8 insertions(+)
From: Li Zhang zhlci...@linux.vnet.ibm.com
It doesn't need to add a default memory balloon for PPC64.
Only if users want it, it can be added explicitly.
Signed-off-by: Li Zhang zhlci...@linux.vnet.ibm.com
---
src/qemu/qemu_command.c | 12
src/qemu/qemu_domain.c | 12
As described before, this patch should be :
---
utils/utils.py | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/utils/utils.py b/utils/utils.py
index 147c1ef..ec09c33 100644
--- a/utils/utils.py
+++ b/utils/utils.py
@@ -409,9 +409,8 @@ def exec_cmd(command, sudo=False,
From: Li Zhang zhlci...@linux.vnet.ibm.com
It doesn't need to add a default memory balloon for PPC64.
Only if users want it, it can be added explicitly.
Signed-off-by: Li Zhang zhlci...@linux.vnet.ibm.com
---
v2 - v1:
* Fix one qemuargv2xmltest failure
src/qemu/qemu_command.c
37 matches
Mail list logo
