Re: [libvirt] [question] We can create two network of one same linux bridge or local ethernet. It is a bug?

On Sat, Nov 30, 2013 at 07:30:03PM +0800, Sheldon wrote: We can create two network of one same linux bridge or local ethernet: This is not harmful. But I wonder should this case is allowed? Why? It should probably be rejected as invalid. virsh # net-list --all Name State Autostart

Re: [libvirt] [PATCH] Fix VMware support for Fusion 6 / Workstation 10

On Sat, Nov 30, 2013 at 07:51:10PM -0500, Brad Ackerman wrote: This patch gets VMware Fusion 6 working, but the support for ThinPrint needs work—I’m not sure what a good way would be to represent that in libvirt; none of the existing virDomainChrType values seem to be appropriate. Can you

Re: [libvirt] [PATCH] Fix pid ouput of libvirt.rpc.socket_new probe

On Mon, Dec 02, 2013 at 10:55:49AM +0800, Jincheng Miao wrote: Pass the pid value when invoking virNetSocketNew(). This will make libvirt.rpc.socket_new stap probe return the right pid. Signed-off-by: Jincheng Miao jm...@redhat.com --- src/rpc/virnetsocket.c | 16 ++-- 1 file

Re: [libvirt] [PATCH v2 1/2] conf: add xml element devices/pvpanic

On 12/02/13 07:11, Hu Tao wrote: This patch adds a new xml element devices/pvpanic to support qemu device pvpanic. It can be used to receive guest panic notification. Signed-off-by: Hu Tao hu...@cn.fujitsu.com --- docs/formatdomain.html.in | 25 + src/conf/domain_conf.c

Re: [libvirt] [PATCH v2 2/2] qemu: add support for -device pvpanic

On 12/02/13 07:11, Hu Tao wrote: This patch will add -device pvpanic to qemu command line if user enables pvpanic in domain xml and the qemu version supports pvpanic. Signed-off-by: Hu Tao hu...@cn.fujitsu.com --- src/qemu/qemu_capabilities.c | 3 +++ src/qemu/qemu_capabilities.h | 2 ++

Re: [libvirt] [PATCHv2 1/4] test: Implement fake storage pool driver in qemuxml2argv test

On 11/28/13 09:27, Osier Yang wrote: On 27/11/13 23:14, Peter Krempa wrote: To support testing of volume disk backing, we need to implement a few disk driver backend functions. The fake storage driver uses files in storagepoolxml2xmlout/POOLNAME.xml as XML files for pool definitions and

Re: [libvirt] [PATCHv2 2/4] qemuxml2argv: Add test to verify correct usage of disk type=volume

On 11/28/13 09:29, Osier Yang wrote: On 27/11/13 23:14, Peter Krempa wrote: Tweak the existing file to test command line generator too. --- tests/qemuxml2argvdata/qemuxml2argv-disk-source-pool.args | 8 tests/qemuxml2argvdata/qemuxml2argv-disk-source-pool.xml | 2 +-

Re: [libvirt] [PATCHv2 3/4] qemuxml2argv: Add test for disk type='volume' with iSCSI pools

On 11/28/13 09:31, Osier Yang wrote: On 27/11/13 23:14, Peter Krempa wrote: Tweak the existing file so that it can be tested for command line corectness. --- tests/qemuxml2argvdata/qemuxml2argv-disk-source-pool-mode.args | 10 ++

[libvirt] [PATCH] tests: Fix comment for fake storage pool driver

Commit bae124e40ff2b9d4de75d44510619db2c08d548a was accidentaly pushed without review feedback worked in. Fix it up. --- tests/qemuxml2argvtest.c | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/tests/qemuxml2argvtest.c b/tests/qemuxml2argvtest.c index 17d4554..e9a32fb

Re: [libvirt] [PATCH] tests: Fix comment for fake storage pool driver

On 12/02/13 13:36, Peter Krempa wrote: Commit bae124e40ff2b9d4de75d44510619db2c08d548a was accidentaly pushed without review feedback worked in. Fix it up. --- tests/qemuxml2argvtest.c | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) This patch was pushed under the trivial

[libvirt] [PATCH] qemu: add -boot strict to commandline whenever possible

This resolves: https://bugzilla.redhat.com/show_bug.cgi?id=888635 (which was already closed as CANTFIX because the qemu -boot strict commandline option wasn't available at the time). Problem: you couldn't have a domain that used PXE to boot, but also had an un-bootable disk device *even if

Re: [libvirt] [PATCH 3/3] vbox: handle several errors correctly in vboxHostDeviceGetXMLDesc

On Mon, Dec 2, 2013 at 12:03 PM, Daniel Veillard veill...@redhat.com wrote: This patch also looks fine, but is more complex, I would rather postpone it after the 1.2.0 release, Okay, not a problem :) I will check the patch again and resend it later. Thanks, ozaki-r Daniel On Sun, Dec

Re: [libvirt] [PATCH 22/34] Removed virDomainEventPtr in favor of virObjectEventPtr

On Fri, 2013-11-29 at 17:18 +, Daniel P. Berrange wrote: On Fri, Nov 29, 2013 at 04:18:58PM +0100, Cédric Bosdonnat wrote: The virDomainEvent class wasn't defining anything special, thus it has been dropped. diff --git a/src/conf/domain_event.c b/src/conf/domain_event.c index

Re: [libvirt] [PATCH 09/34] Create virDomainEventLifecycle to start removing the huge union

On Fri, 2013-11-29 at 17:09 +, Daniel P. Berrange wrote: On Fri, Nov 29, 2013 at 04:18:45PM +0100, Cédric Bosdonnat wrote: static virClassPtr virObjectEventClass; static virClassPtr virDomainEventClass; +static virClassPtr virDomainEventLifecycleClass; static void

Re: [libvirt] [PATCH 22/34] Removed virDomainEventPtr in favor of virObjectEventPtr

On Mon, Dec 02, 2013 at 01:50:58PM +0100, Cedric Bosdonnat wrote: On Fri, 2013-11-29 at 17:18 +, Daniel P. Berrange wrote: On Fri, Nov 29, 2013 at 04:18:58PM +0100, Cédric Bosdonnat wrote: The virDomainEvent class wasn't defining anything special, thus it has been dropped.

[libvirt] [PATCH] qemu: fix lastError memory leak

When an error occurred in qemuMonitorIO, it will be saved in mon-lastError, but the memory which mon-lastError.message, mon-lastError.str1, mon-lastError.str2 and mon-lastError.str3 will not be freed at last. The same bug happened in qemuAgentIO. So I add the following code to fix it.

Re: [libvirt] [PATCHv1.5 12/27] conf: Support disk source formatting without needing a virDomainDiskDefPtr

On 11/27/13 12:15, Michal Privoznik wrote: On 26.11.2013 17:48, Peter Krempa wrote: The source element formatting function was expecting a virDomainDiskDefPtr to store the data. As snapshots are not using this data structure to hold the data, we need to add an internal function which splits

Re: [libvirt] [PATCHv1.5 14/27] conf: Split out seclabel formating code for disk source

On 11/27/13 12:15, Michal Privoznik wrote: On 26.11.2013 17:48, Peter Krempa wrote: The code is common for all the various disk types. Split it out to a common function. --- src/conf/domain_conf.c | 62 -- 1 file changed, 30 insertions(+),

Re: [libvirt] [PATCHv1.5 13/27] conf: Clean up virDomainDiskSourceDefFormatInternal

On 11/27/13 12:15, Michal Privoznik wrote: On 26.11.2013 17:48, Peter Krempa wrote: Avoid if statements when used with virBufferEscapeString which automaticaly omits the whole string. Also add some line breaks to visualy separate the code. --- src/conf/domain_conf.c | 48

Re: [libvirt] [PATCHv1.5 15/27] conf: Export disk source formatter and parser

On 11/27/13 12:15, Michal Privoznik wrote: On 26.11.2013 17:48, Peter Krempa wrote: This code will be reused in the snapshot disk definition parser. --- src/conf/domain_conf.c | 4 ++-- src/conf/domain_conf.h | 20 2 files changed, 22 insertions(+), 2 deletions(-) ...

Re: [libvirt] [PATCHv1.5 16/27] snapshot: conf: Use common parsing and formatting functions for source

On 11/27/13 12:15, Michal Privoznik wrote: On 26.11.2013 17:48, Peter Krempa wrote: Disk source elements for snapshots were using separate code from our config parser. As snapshots can be stored on more than just regular files, we will need the universal parser to allow us to expose a variety

Re: [libvirt] [PATCHv1.5 17/27] snapshot: conf: Fix NULL dereference when driver element is empty

On 11/27/13 12:15, Michal Privoznik wrote: On 26.11.2013 17:48, Peter Krempa wrote: Consider the following valid snapshot XML as the driver element is allowed to be empty in the domainsnapshot.rng schema: $ cat snap.xml domainsnapshot disks disk name='vda' snapshot='external'

Re: [libvirt] [PATCHv1.5 18/27] conf: Add functions to copy and free network disk source definitions

On 11/27/13 12:15, Michal Privoznik wrote: On 26.11.2013 17:49, Peter Krempa wrote: To simplify operations on virDomainDiskHostDef arrays we will need deep copy and freeing functions. Add and properly export them. --- src/conf/domain_conf.c | 55

Re: [libvirt] [PATCHv1.5 20/27] conf: Add helper do clear disk source authentication struct

On 11/27/13 12:15, Michal Privoznik wrote: On 26.11.2013 17:49, Peter Krempa wrote: Add virDomainDiskAuthClear to help cleaning out the struct in other places too. --- src/conf/domain_conf.c | 17 ++--- src/conf/domain_conf.h | 1 + src/libvirt_private.syms | 1 + 3

Re: [libvirt] [PATCHv1.5 23/27] qemu: snapshot: Add functions similar to disk source pool translation

On 11/27/13 12:14, Michal Privoznik wrote: On 26.11.2013 17:49, Peter Krempa wrote: To avoid future pain, add placeholder functions to get the actual snapshot disk type. --- src/qemu/qemu_conf.c | 23 +++ src/qemu/qemu_conf.h | 6 ++ 2 files changed, 29

Re: [libvirt] [PATCHv1.5 22/27] qemu: snapshot: Touch up error message

On 11/29/13 15:30, Laine Stump wrote: On 11/27/2013 01:14 PM, Michal Privoznik wrote: On 26.11.2013 17:49, Peter Krempa wrote: --- src/qemu/qemu_driver.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index

Re: [libvirt] [PATCH v3] Pin guest to memory node on NUMA system

On Tue, Nov 26, 2013 at 07:59:31PM +0530, Shivaprasad G Bhat wrote: Version 3: Addressed comments on V2. Version 2: Fixed the string formatting errors in v1. The patch contains the fix for defect 1009880 reported at redhat bugzilla. The root cause is, ever since the

Re: [libvirt] [question] We can create two network of one same linux bridge or local ethernet. It is a bug?

On 12/02/2013 11:52 AM, Daniel P. Berrange wrote: On Sat, Nov 30, 2013 at 07:30:03PM +0800, Sheldon wrote: We can create two network of one same linux bridge or local ethernet: This is not harmful. But I wonder should this case is allowed? Why? It should probably be rejected as invalid. In

[libvirt] [PATCHv3] qemu: Refactor qemuTranslateDiskSourcePool

Before this patch, the translation function still needs a second ugly helper function to actually format the command line for qemu. But if we do the right stuff in the translation function, we don't have to bother with the second function any more. This patch removes the messy

[libvirt] clone img on iscsi storage

Hi: I need to clone a vm, the source is vm1.img,i need to clone the vm1.img to a iscsi storage volume, it's said that i can't create volume on a iscsi. I use virStorageVolCreateXMLFrom to do this, can you do me a favor? thank you. the virt-manager can clone the vm1.img to overwrite the

[libvirt] [v3 04/32] Renamed virDomainEventQueue to virObjectEventQueue

--- src/conf/domain_event.c | 49 ++--- src/conf/domain_event.h | 3 --- 2 files changed, 26 insertions(+), 26 deletions(-) diff --git a/src/conf/domain_event.c b/src/conf/domain_event.c index 3bfe1e0..ee19142 100644 --- a/src/conf/domain_event.c +++

[libvirt] [v3 02/32] Rename virDomainEventCallback to virObjectEventCallback

--- src/conf/domain_event.c | 8 src/conf/domain_event.h | 4 ++-- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/src/conf/domain_event.c b/src/conf/domain_event.c index 19e3920..fd68820 100644 --- a/src/conf/domain_event.c +++ b/src/conf/domain_event.c @@ -43,7 +43,7 @@

[libvirt] [v3 03/32] Renamed virDomainMeta to virObjectMeta

--- src/conf/domain_event.c | 46 +++--- 1 file changed, 23 insertions(+), 23 deletions(-) diff --git a/src/conf/domain_event.c b/src/conf/domain_event.c index fd68820..3bfe1e0 100644 --- a/src/conf/domain_event.c +++ b/src/conf/domain_event.c @@ -32,13

[libvirt] [v3 17/32] Create virDomainEventDiskChange

--- src/conf/domain_event.c | 87 +++-- 1 file changed, 56 insertions(+), 31 deletions(-) diff --git a/src/conf/domain_event.c b/src/conf/domain_event.c index 91bdbae..49b87dd 100644 --- a/src/conf/domain_event.c +++ b/src/conf/domain_event.c @@ -91,6

[libvirt] [v3 22/32] Add object event namespaces for the event IDs

Each unique event ID will thus be composed by 1 byte for the namespace and 1 byte for a namespace-specific ID. The namespace for domain event needs to be 0 for compatibility reasons. --- src/conf/domain_event.c | 10 -- src/conf/domain_event.h | 8 2 files changed, 16

[libvirt] [v3 06/32] Renamed virDomainEventCallbackList* to virObjectEventCallbackList*

Keep the legacy Domain lifecycle event functions as is. --- src/conf/domain_event.c | 94 - src/conf/domain_event.h | 3 -- 2 files changed, 53 insertions(+), 44 deletions(-) diff --git a/src/conf/domain_event.c b/src/conf/domain_event.c index

[libvirt] [v3 15/32] Created virDomainEventGraphics

--- src/conf/domain_event.c | 148 +++- src/conf/domain_event.h | 20 +++ 2 files changed, 95 insertions(+), 73 deletions(-) diff --git a/src/conf/domain_event.c b/src/conf/domain_event.c index de3664f..e145157 100644 --- a/src/conf/domain_event.c

[libvirt] [v3 13/32] Created virDomainEventWatchdog to get rid of the huge union

--- src/conf/domain_event.c | 60 + 1 file changed, 41 insertions(+), 19 deletions(-) diff --git a/src/conf/domain_event.c b/src/conf/domain_event.c index ab38a3b..63119b2 100644 --- a/src/conf/domain_event.c +++ b/src/conf/domain_event.c @@ -87,10

[libvirt] [v3 07/32] Created virObjectEventStateRegisterID

Keep virDomainEventStateRegisterID as a convenience wrapper around this new function. --- src/conf/domain_event.c | 130 ++- src/conf/domain_event.h | 25 + src/libvirt_private.syms | 1 + 3 files changed, 110 insertions(+), 46 deletions(-)

[libvirt] [v3 09/32] Create virDomainEventLifecycle to start removing the huge union

--- src/conf/domain_event.c | 57 +++-- 1 file changed, 41 insertions(+), 16 deletions(-) diff --git a/src/conf/domain_event.c b/src/conf/domain_event.c index 6b02022..9a0c32b 100644 --- a/src/conf/domain_event.c +++ b/src/conf/domain_event.c @@ -85,8

[libvirt] [v3 08/32] virObject-ified virDomainEvent

Added a parent class virObjectEvent for future event types --- cfg.mk | 2 - src/conf/domain_event.c | 619 +++ src/conf/domain_event.h | 5 +- src/libvirt_private.syms | 1 - src/qemu/qemu_driver.c | 2 +-

[libvirt] [v3 30/32] daemon/remote.c: renamed remoteDispatchDomainEventSend

Renamed into remoteDispatchObjectEventSend as it will later be used for both the domain and network events. --- daemon/remote.c | 36 ++-- 1 file changed, 18 insertions(+), 18 deletions(-) diff --git a/daemon/remote.c b/daemon/remote.c index decaecc..f060006

[libvirt] [v3 20/32] Created virDomainEventDeviceRemoved and removed the huge union

RIP virDomainEvent union. All data are now stored in each virObjectEvent subclass. --- src/conf/domain_event.c | 77 + 1 file changed, 45 insertions(+), 32 deletions(-) diff --git a/src/conf/domain_event.c b/src/conf/domain_event.c index

[libvirt] [v3 00/32] network events feature

Changes with v2: * This patch serie includes fixes for Daniel's comments. * The two commits adding the network events API have been merged into one to get rid of build problems between those two. * Otherwise one commit has been dropped to fix the void* returns of domain events creation

[libvirt] [v3 19/32] Created virDomainEventBalloonChange

--- src/conf/domain_event.c | 56 +++-- 1 file changed, 40 insertions(+), 16 deletions(-) diff --git a/src/conf/domain_event.c b/src/conf/domain_event.c index 47b183a..589ffea 100644 --- a/src/conf/domain_event.c +++ b/src/conf/domain_event.c @@ -93,6

[libvirt] [v3 32/32] Added network events to the bridged network driver

--- src/network/bridge_driver.c | 90 src/network/bridge_driver_platform.h | 3 ++ 2 files changed, 93 insertions(+) diff --git a/src/network/bridge_driver.c b/src/network/bridge_driver.c index 1e4cc70..1b5742d 100644 ---

[libvirt] [v3 01/32] Added domain start/stop/define/undefine event unit tests

These unit tests are aiming at providing some help during the domain events refactoring. --- .gitignore | 1 + tests/Makefile.am | 7 ++ tests/objecteventtest.c | 246 3 files changed, 254 insertions(+) create mode 100644

[libvirt] [v3 26/32] Added Network events API and virNetworkEventLifecycle.

Put all network-events related code in src/conf/network_event.[ch] --- include/libvirt/libvirt.h.in | 77 ++ src/Makefile.am | 5 ++ src/conf/network_event.c | 152 +++ src/conf/network_event.h | 50

[libvirt] [v3 05/32] Renamed virDomainEventState to virObjectEventState

Leave virDomainEventRegister and its Deregister brother as these are legacy functions only for domain lifecycle events. --- cfg.mk | 4 +- src/conf/domain_event.c | 100 src/conf/domain_event.h | 26 +--

[libvirt] [v3 23/32] Renamed virDomainEventTimer to virObjectEventTimer

--- src/conf/domain_event.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/conf/domain_event.c b/src/conf/domain_event.c index 8462754..2fc0870 100644 --- a/src/conf/domain_event.c +++ b/src/conf/domain_event.c @@ -853,7 +853,7 @@

[libvirt] [v3 31/32] Add network events to the remote driver

--- daemon/libvirtd.h| 1 + daemon/remote.c | 140 +++ src/remote/remote_driver.c | 127 +++ src/remote/remote_protocol.x | 46 +- 4 files changed, 313 insertions(+), 1

[libvirt] [v3 11/32] Renamed virDomainEventNewInternal to virDomainEventNew

This change may be confusing at first, but provides a much more consistent naming scheme for the virObjectEvent children construction functions. --- src/conf/domain_event.c | 154 1 file changed, 77 insertions(+), 77 deletions(-) diff --git

[libvirt] [v3 14/32] Created virDomainEventIOError

--- src/conf/domain_event.c | 105 ++-- 1 file changed, 66 insertions(+), 39 deletions(-) diff --git a/src/conf/domain_event.c b/src/conf/domain_event.c index 63119b2..de3664f 100644 --- a/src/conf/domain_event.c +++ b/src/conf/domain_event.c @@ -88,11

[libvirt] [v3 24/32] Split the virObjectEvent and virDomainEvent* to separate them after

--- src/conf/domain_event.c | 68 ++--- 1 file changed, 42 insertions(+), 26 deletions(-) diff --git a/src/conf/domain_event.c b/src/conf/domain_event.c index 2fc0870..b804f55 100644 --- a/src/conf/domain_event.c +++ b/src/conf/domain_event.c @@ -84,6

[libvirt] [v3 18/32] Created virDomainEventTrayChange

--- src/conf/domain_event.c | 57 ++--- 1 file changed, 40 insertions(+), 17 deletions(-) diff --git a/src/conf/domain_event.c b/src/conf/domain_event.c index 49b87dd..47b183a 100644 --- a/src/conf/domain_event.c +++ b/src/conf/domain_event.c @@ -92,6

[libvirt] [v3 28/32] test driver: implemented network events

--- src/test/test_driver.c | 62 ++ 1 file changed, 62 insertions(+) diff --git a/src/test/test_driver.c b/src/test/test_driver.c index 4972e3d..66afdf7 100644 --- a/src/test/test_driver.c +++ b/src/test/test_driver.c @@ -45,6 +45,7 @@ #include

[libvirt] [v3 27/32] test driver: renamed testDomainEventQueue into testObjectEventQueue

--- src/test/test_driver.c | 40 1 file changed, 20 insertions(+), 20 deletions(-) diff --git a/src/test/test_driver.c b/src/test/test_driver.c index 6d2a0e2..4972e3d 100644 --- a/src/test/test_driver.c +++ b/src/test/test_driver.c @@ -121,7 +121,7 @@

Re: [libvirt] [PATCH] Doc: Explicitly declaring that nodedev-destroy only works for vHBA

On 11/22/2013 05:55 AM, Osier Yang wrote: Though trying to destroy a physical HBA doesn't make sense at all, it's still a bit misleading with saying only works for HBA. Signed-off-by: Osier Yang jy...@redhat.com --- src/libvirt.c | 5 +++-- tools/virsh.pod | 6 +++--- 2 files changed,

[libvirt] [PATCH] Ensure to zero out the virDomainBlockJobInfo arg

From: Daniel P. Berrange berra...@redhat.com The virDomainGetBlockJobInfo method did not zero out the virDomainBlockJobInfo pointer arg, so when block jobs were not active it would return garbage for the bandwidth/cur/end fields. Signed-off-by: Daniel P. Berrange berra...@redhat.com ---

Re: [libvirt] [PATCH] qemu: default to vfio for nodedev-detach

On 11/29/2013 04:47 AM, Laine Stump wrote: This patch resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1035188 Commit f094aaac48a6 changed the PCI device assignment in qemu domains to default to using VFIO rather than legacy KVM device assignment (when VFIO is available). It didn't

[libvirt] [v3 16/32] Created virDomainEventBlockJob

--- src/conf/domain_event.c | 86 - src/conf/domain_event.h | 12 +++ 2 files changed, 62 insertions(+), 36 deletions(-) diff --git a/src/conf/domain_event.c b/src/conf/domain_event.c index e145157..91bdbae 100644 --- a/src/conf/domain_event.c

[libvirt] [v3 12/32] Create virDomainEventRTCChange to get rid of the huge union

--- src/conf/domain_event.c | 53 +++-- 1 file changed, 38 insertions(+), 15 deletions(-) diff --git a/src/conf/domain_event.c b/src/conf/domain_event.c index 23d4965..ab38a3b 100644 --- a/src/conf/domain_event.c +++ b/src/conf/domain_event.c @@ -86,9

[libvirt] [v3 29/32] Add network events unit tests

--- tests/objecteventtest.c | 165 1 file changed, 165 insertions(+) diff --git a/tests/objecteventtest.c b/tests/objecteventtest.c index 031d677..9f0ff78 100644 --- a/tests/objecteventtest.c +++ b/tests/objecteventtest.c @@ -40,6 +40,18 @@ static

Re: [libvirt] Release of libvirt-python-1.2.0

On Mon, Dec 02, 2013 at 02:28:00PM +0800, Daniel Veillard wrote: So this is the first release fo the separated libvirt-python code base out of the main libvirt git. In this case the two release have been made in tandem to avoid disruptions, but there is no guarantee that the future releases

Re: [libvirt] RFC: virsh: add support for redirecting output to files in virsh shell

On 11/30/2013 12:00 PM, Nehal J Wani wrote: Currently, for redirecting output (most of the times its the output of --dumpxml) we use: virsh $command $file But such redirection is not possible in virsh shell. It would be great if libvirt supported this feature for those who love working in

Re: [libvirt] [PATCH] docs: fix typos in libvirt.h.in

On 11/28/2013 07:03 AM, Nehal J Wani wrote: On Thu, Nov 28, 2013 at 5:31 PM, Chen Hanxiao chenhanx...@cn.fujitsu.com wrote: From: Chen Hanxiao chenhanx...@cn.fujitsu.com /** * virDomainEventDefinedDetailType: * - * Details on the caused of the 'defined' lifecycle event + * Details

Re: [libvirt] [PATCH v2] docs: fix typos in libvirt.h.in

On 12/01/2013 07:56 PM, Daniel Veillard wrote: On Mon, Dec 02, 2013 at 10:36:16AM +0800, Chen Hanxiao wrote: From: Chen Hanxiao chenhanx...@cn.fujitsu.com s/caused/causes ACK, applied and pushed :-) Actually, see my comments on v1. cause is better than causes here. I'm pushing this:

Re: [libvirt] [PATCH] Ensure to zero out the virDomainBlockJobInfo arg

On 12/02/2013 09:57 AM, Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com The virDomainGetBlockJobInfo method did not zero out the virDomainBlockJobInfo pointer arg, so when block jobs were not active it would return garbage for the bandwidth/cur/end fields.

Re: [libvirt] Internal error message from netcf when trying to start libvirtd

On 17.10.2013 14:40, Daniel P. Berrange wrote: On Tue, Oct 15, 2013 at 06:03:27PM +0200, Christophe Fergeau wrote: Hey, Due to a configuration issue on my system, libvirtd is not starting on my system (not complaining about this!): 2013-10-15 15:40:51.024+: 10222: info : libvirt version:

Re: [libvirt] Internal error message from netcf when trying to start libvirtd

On Mon, Dec 02, 2013 at 06:17:00PM +0100, Michal Privoznik wrote: On 17.10.2013 14:40, Daniel P. Berrange wrote: On Tue, Oct 15, 2013 at 06:03:27PM +0200, Christophe Fergeau wrote: Hey, Due to a configuration issue on my system, libvirtd is not starting on my system (not complaining

Re: [libvirt] Internal error message from netcf when trying to start libvirtd

On 02.12.2013 18:24, Daniel P. Berrange wrote: On Mon, Dec 02, 2013 at 06:17:00PM +0100, Michal Privoznik wrote: On 17.10.2013 14:40, Daniel P. Berrange wrote: On Tue, Oct 15, 2013 at 06:03:27PM +0200, Christophe Fergeau wrote: Hey, Due to a configuration issue on my system, libvirtd is not

Re: [libvirt] Internal error message from netcf when trying to start libvirtd

On Mon, Dec 02, 2013 at 06:38:37PM +0100, Michal Privoznik wrote: On 02.12.2013 18:24, Daniel P. Berrange wrote: On Mon, Dec 02, 2013 at 06:17:00PM +0100, Michal Privoznik wrote: On 17.10.2013 14:40, Daniel P. Berrange wrote: On Tue, Oct 15, 2013 at 06:03:27PM +0200, Christophe Fergeau

Re: [libvirt] [PATCH 1/4] Add USB Keyboard support in libvirt

+QEMU_CAPS_DEVICE_USB_KBD = 160, /*-device usb-kbd*/ + Why this extra newline? QEMU_CAPS_LAST, /* this must always be the last item */ }; diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c index 763417f..318f7a1 100644 --- a/src/qemu/qemu_command.c

Re: [libvirt] Internal error message from netcf when trying to start libvirtd

On 02.12.2013 18:40, Daniel P. Berrange wrote: On Mon, Dec 02, 2013 at 06:38:37PM +0100, Michal Privoznik wrote: On 02.12.2013 18:24, Daniel P. Berrange wrote: On Mon, Dec 02, 2013 at 06:17:00PM +0100, Michal Privoznik wrote: On 17.10.2013 14:40, Daniel P. Berrange wrote: On Tue, Oct 15, 2013

Re: [libvirt] Internal error message from netcf when trying to start libvirtd

On Mon, Dec 02, 2013 at 06:53:37PM +0100, Michal Privoznik wrote: On 02.12.2013 18:40, Daniel P. Berrange wrote: On Mon, Dec 02, 2013 at 06:38:37PM +0100, Michal Privoznik wrote: On 02.12.2013 18:24, Daniel P. Berrange wrote: On Mon, Dec 02, 2013 at 06:17:00PM +0100, Michal Privoznik wrote:

[libvirt] [PATCH] docs: fix typo in previous patch

Avoid a nested comment compilation error. * include/libvirt/libvirt.h.in: Fix typo. Signed-off-by: Eric Blake ebl...@redhat.com --- Pushing as trivial/build-breaker, and sorry for the one-byte mistake. include/libvirt/libvirt.h.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

Re: [libvirt] GlusterFS with libvirt

On 11/28/2013 08:22 PM, Umar Draz wrote: HI Weiqing, [Please don't top-post on technical lists] Yes I want storage pool of glusterfs. http://www.gluster.org/community/documentation/images/9/9d/QEMU_GlusterFS.pdf Are you using libvirt 1.2.0 (released today)? If so, a gluster storage pool

Re: [libvirt] [PATCH] Add docs about audit subsystem logging

On 11/29/2013 09:23 AM, Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com Adds a new page to the website Deployment section describing what data is sent to the audit logs and how to configure libvirtd audit settings. Signed-off-by: Daniel P. Berrange

Re: [libvirt] [PATCH] Add docs about audit subsystem logging

On 12/02/2013 11:58 AM, Eric Blake wrote: On 11/29/2013 09:23 AM, Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com Adds a new page to the website Deployment section describing what data is sent to the audit logs and how to configure libvirtd audit settings.

Re: [libvirt] [PATCH] Added python binding for the new network events API

On 11/29/2013 08:27 AM, Cédric Bosdonnat wrote: This patch was extracted from the network events feature patch to fit the new libvirt-python repository. Thanks for remembering this. In the future, if you will do a one-time: git config format.subjectprefix python PATCH then it will be more

Re: [libvirt] [PATCH] Fix VMware support for Fusion 6 / Workstation 10

On Mon, Dec 2, 2013 at 3:54 AM, Daniel P. Berrange berra...@redhat.com wrote: On Sat, Nov 30, 2013 at 07:51:10PM -0500, Brad Ackerman wrote: This patch gets VMware Fusion 6 working, but the support for ThinPrint needs work—I’m not sure what a good way would be to represent that in libvirt;

Re: [libvirt] [PATCH] qemu: add -boot strict to commandline whenever possible

On 12/02/2013 05:41 AM, Laine Stump wrote: This resolves: https://bugzilla.redhat.com/show_bug.cgi?id=888635 (which was already closed as CANTFIX because the qemu -boot strict commandline option wasn't available at the time). Problem: you couldn't have a domain that used PXE to boot,

Re: [libvirt] [PATCH v2 1/2] conf: add xml element devices/pvpanic

On 12/01/2013 11:11 PM, Hu Tao wrote: This patch adds a new xml element devices/pvpanic to support qemu device pvpanic. It can be used to receive guest panic notification. Signed-off-by: Hu Tao hu...@cn.fujitsu.com --- docs/formatdomain.html.in | 25 +

Re: [libvirt] [PATCH v2 2/2] qemu: add support for -device pvpanic

On 12/01/2013 11:11 PM, Hu Tao wrote: This patch will add -device pvpanic to qemu command line if user enables pvpanic in domain xml and the qemu version supports pvpanic. Signed-off-by: Hu Tao hu...@cn.fujitsu.com --- src/qemu/qemu_capabilities.c | 3 +++ src/qemu/qemu_capabilities.h |

Re: [libvirt] [libvirt-users] virsh detach typo

On 12/02/2013 02:28 PM, Mauricio Tavares wrote: [root@vmhost vms]# virsh detach-disk puppet vdb error: No found disk whose source path or target is vdb [root@vmhost vms]# virsh --version 0.10.2 [root@vmhost vms]# This probably was solved already but if not, No found disk probably

Re: [libvirt] [PATCH python] Skip copying manually written python for C APIs which don't exist

On 11/27/2013 04:14 AM, Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com If the libvirt-override-vir.py file has methods which call C APIs that don't exist in the version of libvirt built against we need to skip copying their code. eg for 0.9.13 libvirt we should

Re: [libvirt] [PATCH] qemu: fix lastError memory leak

On 12/02/2013 06:25 AM, Wangyufei (James) wrote: When an error occurred in qemuMonitorIO, it will be saved in mon-lastError, but the memory which mon-lastError.message, mon-lastError.str1, mon-lastError.str2 and mon-lastError.str3 will not be freed at last. The same bug happened in

Re: [libvirt] [PATCHv1.5 17/27] snapshot: conf: Fix NULL dereference when driver element is empty

On 11/27/2013 04:15 AM, Michal Privoznik wrote: On 26.11.2013 17:48, Peter Krempa wrote: Consider the following valid snapshot XML as the driver element is allowed to be empty in the domainsnapshot.rng schema: $ cat snap.xml domainsnapshot disks disk name='vda' snapshot='external'

Re: [libvirt] [PATCHv1.5 18/27] conf: Add functions to copy and free network disk source definitions

On 11/27/2013 04:15 AM, Michal Privoznik wrote: On 26.11.2013 17:49, Peter Krempa wrote: To simplify operations on virDomainDiskHostDef arrays we will need deep copy and freeing functions. Add and properly export them. --- +if (VIR_STRDUP(dst-port, src-port) 0) +goto

Re: [libvirt] [PATCHv3] qemu: Refactor qemuTranslateDiskSourcePool

On 12/02/2013 08:19 AM, Peter Krempa wrote: Before this patch, the translation function still needs a second ugly helper function to actually format the command line for qemu. But if we do the right stuff in the translation function, we don't have to bother with the second function any more.

Re: [libvirt] [v3 01/32] Added domain start/stop/define/undefine event unit tests

On 12/02/2013 09:39 AM, Cédric Bosdonnat wrote: These unit tests are aiming at providing some help during the domain events refactoring. --- .gitignore | 1 + tests/Makefile.am | 7 ++ tests/objecteventtest.c | 246

Re: [libvirt] [PATCH v2 1/2] conf: add xml element devices/pvpanic

On Mon, Dec 02, 2013 at 11:13:33AM +0100, Peter Krempa wrote: On 12/02/13 07:11, Hu Tao wrote: This patch adds a new xml element devices/pvpanic to support qemu device pvpanic. It can be used to receive guest panic notification. Signed-off-by: Hu Tao hu...@cn.fujitsu.com ---

Re: [libvirt] [PATCH v2 2/2] qemu: add support for -device pvpanic

On Mon, Dec 02, 2013 at 11:15:17AM +0100, Peter Krempa wrote: On 12/02/13 07:11, Hu Tao wrote: This patch will add -device pvpanic to qemu command line if user enables pvpanic in domain xml and the qemu version supports pvpanic. Signed-off-by: Hu Tao hu...@cn.fujitsu.com ---

Re: [libvirt] [PATCH v2 2/2] qemu: add support for -device pvpanic

On Mon, Dec 02, 2013 at 02:38:09PM -0700, Eric Blake wrote: On 12/01/2013 11:11 PM, Hu Tao wrote: This patch will add -device pvpanic to qemu command line if user enables pvpanic in domain xml and the qemu version supports pvpanic. Signed-off-by: Hu Tao hu...@cn.fujitsu.com ---

Re: [libvirt] [PATCH v2 1/2] conf: add xml element devices/pvpanic

On Mon, Dec 02, 2013 at 02:34:44PM -0700, Eric Blake wrote: On 12/01/2013 11:11 PM, Hu Tao wrote: This patch adds a new xml element devices/pvpanic to support qemu device pvpanic. It can be used to receive guest panic notification. Signed-off-by: Hu Tao hu...@cn.fujitsu.com ---

Re: [libvirt] [PATCH 0/9] Add throttle blkio cgroup support for libvirt

On 2013-12-02 14:47 , Gao feng wrote: Right now, libvirt only supports the cfq based blkio cgorup, this means if the block devices doesn't use cfq scheduler, the blkio cgroup will loss effect. This patchset adds the throttle blkio cgroup support for libvirt, intoduces four elements for domain

Re: [libvirt] [PATCH 1/4] Add USB Keyboard support in libvirt

On 2013年12月03日 01:43, Nehal J Wani wrote: +QEMU_CAPS_DEVICE_USB_KBD = 160, /*-device usb-kbd*/ + Why this extra newline? Thanks for your reviewing. :) Let me remove the blank line in next version. QEMU_CAPS_LAST, /* this must always be the last item */ };

[libvirt] [PATCH] qemuAgentDispose: Reset lastError

When an error occurred in qemuAgentIO, it will be saved in mon-lastError, but it will not be freed at last. So I add the following code to fix it. ==22219== 54 bytes in 1 blocks are definitely lost in loss record 982 of 1,379 ==22219==at 0x4C26B9B: malloc (vg_replace_malloc.c:263) ==22219==

[libvirt] [PATCHv2 2/3] qemu: conf: Parse RBD storage pool from domain xml

Modify switch statement in qemuTranslateDiskSourcePool to parse the storage pool definition for RBD pools instead of throwing an error. I do throw errors for any other usage case of VIR_STORAGE_VOL_NETWORK, as my code does not cover their use cases currently. Once I have the ability to test such

[libvirt] [PATCHv2 1/3] qemu: config: Add qemuAddRBDPoolSourceHost helper function

Add a function to grab the RBD hosts from a pool definition and add them to the disk definition. This function allows the addition of RBD storage pool functionality. --- src/qemu/qemu_conf.c | 39 +++ 1 file changed, 39 insertions(+) diff --git

  1   2   >