Hello, list.
Refuse following symlinks in virInitctlSetRunLevel.
A reasonable fallback for the next two patches, which apply fork-setns
technique recommended on this list.
---
src/util/virinitctl.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/util/virinitctl.c
Implement fork setns for lxcDomainShutdownFlags
---
src/lxc/lxc_driver.c | 45 +
1 file changed, 45 insertions(+)
diff --git a/src/lxc/lxc_driver.c b/src/lxc/lxc_driver.c
index c499182..9d200b2 100644
--- a/src/lxc/lxc_driver.c
+++
Implement fork setns for lxcDomainShutdownFlags
---
src/lxc/lxc_driver.c | 45 +
1 file changed, 45 insertions(+)
diff --git a/src/lxc/lxc_driver.c b/src/lxc/lxc_driver.c
index 9d200b2..1227736 100644
--- a/src/lxc/lxc_driver.c
+++
Hello, list.
Refuse following symlinks in virInitctlSetRunLevel.
A reasonable fallback for the next two patches, which apply fork-setns
technique recommended on this list.
---
src/util/virinitctl.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/util/virinitctl.c
On 10/03/2013 07:25 AM, Michal Privoznik wrote:
The actual patches are accessible at:
git://gitorious.org/libvirt/michal-staging.git
branch test_qemu_capabilities_data
I'm not sending the actual patches as it's big junk of JSON qemu replies. The
patches has from 35KiB to 59KiB. I don't
On gio, 2013-12-19 at 11:46 +, Ian Jackson wrote:
Dario Faggioli writes (Segfault in libxl_osevent_occurred_timeout [Was: Re:
[libvirt-users] About debugging of libvirt.]):
[Moving this to libvir, libvir-users in Bcc. Also, added xen-devel]
4.2.1 is lacking
libxl: fix stale timeout
On Thu, Dec 19, 2013 at 01:54:19AM +0500, Umar Draz wrote:
Hi I am trying to stop the storage pool through php-libvirt api which is a
LVM volume group.
when I tried to stop it I got error
error: internal error Child process (/sbin/vgchange -aln mylvmgrp)
unexpected exit status 5: Can't
Changed the constraints on gnutls to 3.1+
---
tests/virnettlscontexttest.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/tests/virnettlscontexttest.c b/tests/virnettlscontexttest.c
index fc512fc..d9a4e9d 100644
--- a/tests/virnettlscontexttest.c
+++
On 12/19/2013 02:18 AM, Peter Krempa wrote:
On 12/19/13 05:38, Eric Blake wrote:
Commit 6cd60b6 was flat out broken - it tried to print into the
wrong variable. My testing was obviously too cursory (did the
name get a slash added?); valgrind would have caught the error.
Thankfully it didn't
On Wed, Dec 18, 2013 at 07:19:31PM +0100, Michal Privoznik wrote:
Currently, the @flags usage is a bit unclear at first sight to say the
least. There's no need for such unclear code especially when we can
borrow the working code from qemuDomainShutdownFlags().
In addition, this fixes one bug
On Fri, Dec 13, 2013 at 11:08:10AM +0800, Gao feng wrote:
With this patch, user can setup throttle blkio cgroup
through virsh for qemu domain.
Signed-off-by: Guan Qiang hzguanqi...@corp.netease.com
Signed-off-by: Gao feng gaof...@cn.fujitsu.com
---
src/qemu/qemu_driver.c | 442
On 12/19/2013 08:17 AM, Daniel P. Berrange wrote:
On Thu, Dec 19, 2013 at 08:13:36AM -0700, Eric Blake wrote:
diff --git a/src/libvirt_internal.h b/src/libvirt_internal.h
index 115d8d1..b8c842d 100644
--- a/src/libvirt_internal.h
+++ b/src/libvirt_internal.h
@@ -27,6 +27,113 @@
# include
On Fri, Dec 13, 2013 at 11:09:01AM +0800, Gao feng wrote:
With this patch,user can set throttle blkio cgroup for
lxc domain through virsh tool.
Signed-off-by: Guan Qiang hzguanqi...@corp.netease.com
Signed-off-by: Gao feng gaof...@cn.fujitsu.com
---
src/lxc/lxc_driver.c | 671
On Thu, Dec 19, 2013 at 09:35:23AM -0700, Eric Blake wrote:
On 12/19/2013 08:17 AM, Daniel P. Berrange wrote:
On Thu, Dec 19, 2013 at 08:13:36AM -0700, Eric Blake wrote:
diff --git a/src/libvirt_internal.h b/src/libvirt_internal.h
index 115d8d1..b8c842d 100644
--- a/src/libvirt_internal.h
On Thu, Dec 19, 2013 at 08:07:39PM +0400, Reco wrote:
Hello, list.
Refuse following symlinks in virInitctlSetRunLevel.
A reasonable fallback for the next two patches, which apply fork-setns
technique recommended on this list.
---
src/util/virinitctl.c |2 +-
1 file changed, 1
Don't set the PCI address of primary video to the default
if it's already occupied by another device.
Without this, a primary video card that doesn't have an
address gets the default one on the 1st pass of PCI address
allocation, even if it's occupied. This address gets picked
up by the second
On Thu, Dec 19, 2013 at 08:07:50PM +0400, Reco wrote:
Implement fork setns for lxcDomainShutdownFlags
---
src/lxc/lxc_driver.c | 45 +
1 file changed, 45 insertions(+)
diff --git a/src/lxc/lxc_driver.c b/src/lxc/lxc_driver.c
index
On 12/19/2013 08:18 AM, Daniel P. Berrange wrote:
On Thu, Dec 19, 2013 at 08:13:35AM -0700, Eric Blake wrote:
While looking at event code, I noticed that the documentation was
trying to refer me to functions that don't exist. Also fix some
typos and poor formatting.
* src/libvirt.c
Hi Daniel,
my Virtual machines are running, so how I can stop the volumes?
Br.
Umar
On Thu, Dec 19, 2013 at 9:21 PM, Daniel P. Berrange berra...@redhat.comwrote:
On Thu, Dec 19, 2013 at 01:54:19AM +0500, Umar Draz wrote:
Hi I am trying to stop the storage pool through php-libvirt api
On Thu, Dec 19, 2013 at 09:51:31PM +0500, Umar Draz wrote:
Hi Daniel,
my Virtual machines are running, so how I can stop the volumes?
If you have VMs using volumes in a pool then you cannot stop
that pool until the VMs are stopped.
Daniel
--
|: http://berrange.com -o-
On Mon, Dec 16, 2013 at 04:41:31PM +0200, Laine Stump wrote:
On 12/10/2013 04:45 PM, Daniel P. Berrange wrote:
So considering your example XML config above we're debating the
behaviour of the following 5 possible DNS requests
- myguest
- myguest.example.com
- notmyguest
-
On 19.12.2013 11:19, Ian Campbell wrote:
On Wed, 2013-12-18 at 17:44 -0700, Jim Fehlig wrote:
Stefan Bader wrote:
On 18.12.2013 14:28, Ian Campbell wrote:
On Wed, 2013-12-18 at 14:12 +0100, Stefan Bader wrote:
On 18.12.2013 13:27, Ian Campbell wrote:
On Tue, 2013-12-17 at
On Thu, Dec 19, 2013 at 16:46:50 +0100, Michal Privoznik wrote:
https://bugzilla.redhat.com/show_bug.cgi?id=1044806
Currently, sending the ANSI_A keycode from os_x codepage doesn't work as
it has a special value of 0x0. Our internal code handles that no
different to other not defined
On Thu, Dec 19, 2013 at 17:43:33 +0100, Jano Tomko wrote:
Don't set the PCI address of primary video to the default
if it's already occupied by another device.
Without this, a primary video card that doesn't have an
address gets the default one on the 1st pass of PCI address
allocation,
On 12/19/2013 06:18 PM, Jiri Denemark wrote:
On Thu, Dec 19, 2013 at 17:43:33 +0100, Jano Tomko wrote:
Don't set the PCI address of primary video to the default
if it's already occupied by another device.
Without this, a primary video card that doesn't have an
address gets the default one on
On Thu, 2013-12-19 at 18:06 +0100, Stefan Bader wrote:
How about we:
* move the init to setdefault to catch the single NIC added via
hotplug case
Init of devid?
Yes, sorry for not being clear.
Hm, would that work as I am not sure there is a simple way of
differentiating
On 12/19/2013 08:23 AM, Daniel P. Berrange wrote:
On Thu, Dec 19, 2013 at 08:15:09AM -0700, Eric Blake wrote:
diff --git a/src/libvirt-qemu.c b/src/libvirt-qemu.c
index db52c65..849932d 100644
+if (dom
+!(VIR_IS_CONNECTED_DOMAIN(dom) dom-conn == conn)) {
+
Stefan Bader wrote:
Oh, just while talking about setdefault. Jim, this is one of the odd things
when
moving from xm to xl stack from libvirt: libvirt defaults to the netfront NIC
when no model is specified and sets the type. The libxl setdefault function
sets
the model to rtl8139 but
On Thu, Dec 19, 2013 at 11:32:32AM -0700, Eric Blake wrote:
On 12/19/2013 08:23 AM, Daniel P. Berrange wrote:
On Thu, Dec 19, 2013 at 08:15:09AM -0700, Eric Blake wrote:
diff --git a/src/libvirt-qemu.c b/src/libvirt-qemu.c
index db52c65..849932d 100644
+if (dom
+
Dario Faggioli wrote:
On gio, 2013-12-19 at 11:46 +, Ian Jackson wrote:
Dario Faggioli writes (Segfault in libxl_osevent_occurred_timeout [Was: Re:
[libvirt-users] About debugging of libvirt.]):
[Moving this to libvir, libvir-users in Bcc. Also, added xen-devel]
4.2.1
On Thu, Dec 19, 2013 at 18:41:25 +0100, Jano Tomko wrote:
On 12/19/2013 06:18 PM, Jiri Denemark wrote:
On Thu, Dec 19, 2013 at 17:43:33 +0100, Jano Tomko wrote:
Don't set the PCI address of primary video to the default
if it's already occupied by another device.
Without this, a primary
On 12/19/2013 09:01 AM, Daniel P. Berrange wrote:
+typedef void (*virConnectDomainQemuMonitorEventCallback)(virConnectPtr
conn,
+ virDomainPtr dom,
+ const char *event,
+
On 12/19/2013 09:07 AM, Reco wrote:
Hello, list.
Refuse following symlinks in virInitctlSetRunLevel.
A reasonable fallback for the next two patches, which apply fork-setns
technique recommended on this list.
Your patches came through as independent top-level threads, rather than
in-reply
On 12/19/2013 09:23 AM, Cédric Bosdonnat wrote:
Changed the constraints on gnutls to 3.1+
---
tests/virnettlscontexttest.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/tests/virnettlscontexttest.c b/tests/virnettlscontexttest.c
index fc512fc..d9a4e9d 100644
---
On 12/19/2013 09:37 AM, Daniel P. Berrange wrote:
+#define virLibDomainSnapshotError(code, ...) \
+virReportErrorHelper(VIR_FROM_DOMAIN_SNAPSHOT, code, __FILE__, \
+ __FUNCTION__, __LINE__, __VA_ARGS__)
I'd venture to sugggest that these
- Original Message -
From: Daniel P. Berrange berra...@redhat.com
To: John Ferlan jfer...@redhat.com
Cc: libvir-list@redhat.com
Sent: Wednesday, December 18, 2013 3:57:22 PM
Subject: Re: [libvirt] [PATCH] Block info query: Add flag to allow failure if
not active
On Wed, Dec 18,
I noticed that the virDomainQemuMonitorCommand debug output wasn't
telling me the name of the domain it was working on. While it was
easy enough to determine which pointer matches the domain based on
other log messages, it is nicer to be consistent.
* src/util/viruuid.h (VIR_UUID_DEBUG): Moved
Dario Faggioli wrote:
So that it is possible to query vcpu related information of
a persistent but not running domain, like it is for the QEMU
driver.
In fact, before this patch, we have:
# virsh list --all
IdName State
there is a segfault in libxl logging in libxl_ctx_free when domain
create fail. because the log output handler vmessage is freed by
xtl_logger_destroy before libxl_ctx_free in virDomainObjListRemove.
move xtl_logger_destroy after libxl_ctx_free could fix this bug.
Signed-off-by: Bamvor Jian Zhang
Introduce helper program to catch events from dnsmasq and maintain a custom
lease file per network. It supports dhcpv4 and dhcpv6. The file is saved as
interface-name.status.
The format of each lease is:
expiry-time (epoch time) mac iaid ip-address hostname clientid
Example of custom leases
Yudai, would you be comfortable with updating our test suite to test
this corner case?
Okay, I've taken look at the test suite and I can update it.
However, my time is pretty limited right now so it may take a little while
to get the update done. If you need this ASAP, maybe someone else
should
On 12/19/2013 12:40 PM, Pradipta Kr. Banerjee wrote:
From: Pradipta Kr. Banerjee bpra...@in.ibm.com
virsh nodecpustats erroneously returns stats for offline cpus on Linux
To retrieve node cpu statistics on Linux system, the
linuxNodeGetCPUstats function performs a minimal match of the input
On 12/19/13 05:38, Eric Blake wrote:
Commit 6cd60b6 was flat out broken - it tried to print into the
wrong variable. My testing was obviously too cursory (did the
name get a slash added?); valgrind would have caught the error.
Thankfully it didn't hit any release.
Reported by Peter Krempa.
On Wed, 2013-12-18 at 17:44 -0700, Jim Fehlig wrote:
Stefan Bader wrote:
On 18.12.2013 14:28, Ian Campbell wrote:
On Wed, 2013-12-18 at 14:12 +0100, Stefan Bader wrote:
On 18.12.2013 13:27, Ian Campbell wrote:
On Tue, 2013-12-17 at 18:32 +0100, Stefan Bader wrote:
On 12/19/2013 02:02 PM, Bing Bu Cao wrote:
On 12/19/2013 12:40 PM, Pradipta Kr. Banerjee wrote:
From: Pradipta Kr. Banerjee bpra...@in.ibm.com
virsh nodecpustats erroneously returns stats for offline cpus on Linux
To retrieve node cpu statistics on Linux system, the
linuxNodeGetCPUstats
On 12/19/13 05:54, Eric Blake wrote:
On 12/16/2013 09:32 AM, Peter Krempa wrote:
Recent adition of the gluster pool type omitted fixing the virsh and
s/adition/addition/
virConnectListAllStoragePool filters. A typecast of the converting
function in virsh showed that also the sheepdog pool
[Moving this to libvir, libvir-users in Bcc. Also, added xen-devel]
Jim,
cooldharma06 reports having issues when destroying VMs with libvirt
1.2.0 and Xen 4.2.1 (is that the case, cooldharma06)?
Look at the stack trace at the end of this message, or here:
On 12/19/13 05:56, Eric Blake wrote:
On 12/16/2013 09:32 AM, Peter Krempa wrote:
Move the code around so that the forward declaration isn't needed.
---
src/storage/storage_driver.c | 181
++-
1 file changed, 91 insertions(+), 90 deletions(-)
ACK;
Dario Faggioli writes (Segfault in libxl_osevent_occurred_timeout [Was: Re:
[libvirt-users] About debugging of libvirt.]):
[Moving this to libvir, libvir-users in Bcc. Also, added xen-devel]
4.2.1 is lacking
libxl: fix stale timeout event callback race
libxl: fix stale fd event callback
On gio, 2013-12-19 at 11:46 +, Ian Jackson wrote:
Dario Faggioli writes (Segfault in libxl_osevent_occurred_timeout [Was: Re:
[libvirt-users] About debugging of libvirt.]):
[Moving this to libvir, libvir-users in Bcc. Also, added xen-devel]
4.2.1 is lacking
libxl: fix stale timeout
This eliminates the misleading error message that was being logged
when a vfio hostdev hotplug failed:
error: unable to set user and group to '107:107' on '/dev/vfio/22':
No such file or directory
as documented in:
https://bugzilla.redhat.com/show_bug.cgi?id=1035490
Commit
This resolves:
https://bugzilla.redhat.com/show_bug.cgi?id=1045002
If a domain has an interface type='hostdev' or an interface
type='network' where the network itself is a pool of hostdev devices,
then libvirt will internally keep that device on both the interface
list *and* the hostdev list
These were all found as a result of researching Bug 1035490. Patch 1
fixes the originally reported problem, Patch 2 fixes the cause of
incorrect error reporting in a later comment of that bug, and Patch 3
fixes a behavior that I encountered while searching for the cause.
Laine Stump (3):
qemu:
This resolves:
https://bugzilla.redhat.com/show_bug.cgi?id=1035490
virProcessSetMaxMemLock() (which is a wrapper over prlimit(3)) expects
the memory size in bytes, but libvirt's domain definition (which was
being used by qemuDomainAttachHostPciDevice()) stores all memory
tuning parameters in
While looking at event code, I noticed that the documentation was
trying to refer me to functions that don't exist. Also fix some
typos and poor formatting.
* src/libvirt.c (virConnectDomainEventDeregister)
(virConnectDomainEventRegisterAny)
(virConnectDomainEventDeregisterAny)
I noticed that the virDomainQemuMonitorCommand debug output wasn't
telling me the name of the domain it was working on. While it was
easy enough to determine which pointer matches the domain based on
other log messages, it is nicer to be consistent. Along the same
lines, having
Noticed these while working on another patch. Although it is mostly
cosmetic, it is not small enough to push under the trivial rule, so
I'll wait for a review.
Eric Blake (2):
docs: improve event-related documentation
maint: improve debug of libvirt-{qemu,lxc} apis
Several times in the past, qemu has implemented a new event,
but libvirt has not yet caught up to reporting that event to
the user applications. While it is possible to track libvirt
logs to see that an unknown event was received and ignored,
it would be nicer to copy what 'virsh
On Thu, Dec 19, 2013 at 08:13:36AM -0700, Eric Blake wrote:
diff --git a/src/libvirt_internal.h b/src/libvirt_internal.h
index 115d8d1..b8c842d 100644
--- a/src/libvirt_internal.h
+++ b/src/libvirt_internal.h
@@ -27,6 +27,113 @@
# include internal.h
+/* Helper macros to implement
On Thu, Dec 19, 2013 at 08:13:35AM -0700, Eric Blake wrote:
While looking at event code, I noticed that the documentation was
trying to refer me to functions that don't exist. Also fix some
typos and poor formatting.
* src/libvirt.c (virConnectDomainEventDeregister)
On Thu, Dec 19, 2013 at 08:15:09AM -0700, Eric Blake wrote:
diff --git a/src/libvirt-qemu.c b/src/libvirt-qemu.c
index db52c65..849932d 100644
--- a/src/libvirt-qemu.c
+++ b/src/libvirt-qemu.c
@@ -237,3 +237,126 @@ error:
virDispatchError(conn);
return NULL;
}
+
+
+/**
+ *
https://bugzilla.redhat.com/show_bug.cgi?id=1044806
Currently, sending the ANSI_A keycode from os_x codepage doesn't work as
it has a special value of 0x0. Our internal code handles that no
different to other not defined keycodes. Hence, in order to allow it we
must change all the undefined
On 12/19/2013 12:40 PM, Pradipta Kr. Banerjee wrote:
From: Pradipta Kr. Banerjee bpra...@in.ibm.com
virsh nodecpustats erroneously returns stats for offline cpus on Linux
To retrieve node cpu statistics on Linux system, the
linuxNodeGetCPUstats function performs a minimal match of the input
At Thu, 18 Oct 2012 15:48:22 +,
Benjamin Wang (gendwang) wrote:
Hi,
When I changed code as following:
public class Connect {
// Load the native part
static {
Libvirt.INSTANCE.virInitialize();
try {
ErrorHandler.processError(Libvirt.INSTANCE);
On 19.12.2013 16:15, Eric Blake wrote:
Several times in the past, qemu has implemented a new event,
but libvirt has not yet caught up to reporting that event to
the user applications. While it is possible to track libvirt
logs to see that an unknown event was received and ignored,
it would
On Thu, Dec 19, 2013 at 04:46:50PM +0100, Michal Privoznik wrote:
https://bugzilla.redhat.com/show_bug.cgi?id=1044806
Currently, sending the ANSI_A keycode from os_x codepage doesn't work as
it has a special value of 0x0. Our internal code handles that no
different to other not defined
On Thu, Dec 19, 2013 at 04:59:28PM +0100, Michal Privoznik wrote:
On 19.12.2013 16:15, Eric Blake wrote:
Several times in the past, qemu has implemented a new event,
but libvirt has not yet caught up to reporting that event to
the user applications. While it is possible to track libvirt
67 matches
Mail list logo
