>On Wed, Mar 05, 2014 at 02:53:10PM -0500, Tomoki Sekiyama wrote:
>> Adds an quiesced flag into qemuDomainObjPrivate that tracks whether guest
>> filesystems of the domain is quiesced of not.
>> It also modify error code from qemuDomainSnapshotFSFreeze and
>> qemuDomainSnapshotFSThaw, so that a cal
Hi Daniel,
Thank you for the review.
>> @@ -5262,5 +5271,17 @@ enum remote_procedure {
>> * @generate: both
>> * @acl: none
>> */
>> -REMOTE_PROC_DOMAIN_EVENT_CALLBACK_DEVICE_REMOVED = 333
>> +REMOTE_PROC_DOMAIN_EVENT_CALLBACK_DEVICE_REMOVED = 333,
>> +
>> +/**
>> +
On Fri, Mar 14, 2014 at 06:52:19PM -0300, Marcelo Tosatti wrote:
> On Tue, Feb 04, 2014 at 11:54:22AM -0500, Marcelo Tosatti wrote:
> > On Tue, Feb 04, 2014 at 04:42:02PM +, Daniel P. Berrange wrote:
> > > On Tue, Feb 04, 2014 at 11:32:47AM -0500, Marcelo Tosatti wrote:
> > > >
> > > > Add an
On Tue, Feb 04, 2014 at 11:54:22AM -0500, Marcelo Tosatti wrote:
> On Tue, Feb 04, 2014 at 04:42:02PM +, Daniel P. Berrange wrote:
> > On Tue, Feb 04, 2014 at 11:32:47AM -0500, Marcelo Tosatti wrote:
> > >
> > > Add an element named "strict-hugepages" to control whether to
> > > refuse guest
Sorry for the slow response, I've been distracted with other projects.
On Monday, March 10, 2014 09:25:37 PM Osier Yang wrote:
> Hm, $tck->cleanup() doesn't close the connection, it just destroy and
> undefine the existing domains, networks, and pools.
>
>
> sub reset {
> my $self = shift;
On 03/14/2014 03:48 PM, Laine Stump wrote:
> On 03/14/2014 07:41 AM, Cole Robinson wrote:
>> -S causes qemu to start in the paused state. Since XML2Native is intended
>> to generate something that users can run directly, this will trip them up.
>> ---
>
> Based on Daniel's answer to my query about
On 03/14/2014 07:41 AM, Cole Robinson wrote:
> -S causes qemu to start in the paused state. Since XML2Native is intended
> to generate something that users can run directly, this will trip them up.
> ---
Based on Daniel's answer to my query about the intent of XMLtoNative,
ACK on the entire series
On Fri, Mar 14, 2014 at 07:54:58 -0600, Eric Blake wrote:
> On 03/14/2014 04:43 AM, Jiri Denemark wrote:
> > Ancient automake (such as from RHEL5) does not provide abs_srcdir and
> > abs_builddir variables which are used by a recent commit of mine
> > (e562e82).
> >
> > Signed-off-by: Jiri Denemar
On 11.03.2014 08:17, Roman Bogorodskiy wrote:
We have to explicitly destroy TAP devices on FreeBSD because
they're not freed after being closed, otherwise we end up with
orphaned TAP devices after destroying a domain.
---
src/qemu/qemu_process.c | 14 --
src/util/virnetdevtap.h |
On 03/14/2014 08:35 AM, Daniel P. Berrange wrote:
> On Fri, Mar 14, 2014 at 08:03:27AM -0600, Eric Blake wrote:
>> On 03/14/2014 07:42 AM, Daniel P. Berrange wrote:
>>
>>>
>>> The point is to get something that works with the "native" tools. In
>>> Xen world the goal was to create a valid /etc/xen/
---
src/lxc/lxc_cgroup.c | 13 ++---
src/lxc/lxc_driver.c | 6 +-
src/qemu/qemu_cgroup.c | 12 +---
src/qemu/qemu_driver.c | 7 ++-
4 files changed, 30 insertions(+), 8 deletions(-)
diff --git a/src/lxc/lxc_cgroup.c b/src/lxc/lxc_cgroup.c
index 876c32e..5887b24 10064
Currently, 0 is treated
as if it were not specified.
Treat is as a valid value if it was explicitly specified
and write it to the cgroups.
---
src/conf/domain_conf.c | 12
src/conf/domain_conf.h | 1 +
src/lxc/lxc_cgroup.c
Treat 0 as a valid value for cputune shares.
v1: https://www.redhat.com/archives/libvir-list/2014-March/msg00215.html
v2:
squashed the fixup that was sent as a separate patch to the first commit
and fixed two more occurences (one of them pointed out by Martin)
Ján Tomko (2):
Treat zero cpu shar
On 03/14/2014 08:34 AM, Daniel P. Berrange wrote:
>>> I don't think we want todo that - there are genuine use cases where
>>> that is a reasonable thing todo. eg you can provide a raw file to a
>>> guest and that guest may genuinely want to format the virtual disk
>>> it received with some other fo
On 08.03.2014 17:51, Roman Bogorodskiy wrote:
Do not include test_libvirt_lockd.aug when configured without qemu
driver.
https://bugzilla.redhat.com/show_bug.cgi?id=1071777
---
src/Makefile.am | 8 +---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/src/Makefile.am b/src/Ma
On Fri, Mar 14, 2014 at 08:03:27AM -0600, Eric Blake wrote:
> On 03/14/2014 07:42 AM, Daniel P. Berrange wrote:
>
> >
> > The point is to get something that works with the "native" tools. In
> > Xen world the goal was to create a valid /etc/xen/ config file, in
> > QEMU world the goal is to creat
On Fri, Mar 14, 2014 at 02:05:49PM +, Richard W.M. Jones wrote:
> On Fri, Mar 14, 2014 at 11:07:21AM +, Daniel P. Berrange wrote:
> > I understand why you chose to use nesting, but I can't say I like
> > the appearance of nesting. I think that in the common case where
> > we have a single n
On 03/14/2014 05:07 AM, Daniel P. Berrange wrote:
> On Wed, Mar 12, 2014 at 02:21:46PM -0600, Eric Blake wrote:
>> # virsh vol-dumpxml --pool gluster img3
>>
>> img3
>> vol1/img3
>> ...
>>
>> gluster://localhost/vol1/img3
>
> A shame we chose this representation instead of something th
On 03/14/2014 07:59 AM, Richard W.M. Jones wrote:
> On Fri, Mar 14, 2014 at 10:53:48AM +, Daniel P. Berrange wrote:
>> On Wed, Mar 12, 2014 at 05:34:17PM -0600, Eric Blake wrote:
>>> Hmm. Another feature coming down the pipes in qemu 2.0 is the ability
>>> to give an alias to any portion of th
On Fri, Mar 14, 2014 at 11:07:21AM +, Daniel P. Berrange wrote:
> I understand why you chose to use nesting, but I can't say I like
> the appearance of nesting. I think that in the common case where
> we have a single non-branching chain, the XML structure is kind of
> unpleasant and would be n
On Fri, Mar 14, 2014 at 10:53:48AM +, Daniel P. Berrange wrote:
> On Wed, Mar 12, 2014 at 05:34:17PM -0600, Eric Blake wrote:
> > Hmm. Another feature coming down the pipes in qemu 2.0 is the ability
> > to give an alias to any portion of the backing chain. Right now, we
> > have an element
On 03/14/2014 07:42 AM, Daniel P. Berrange wrote:
>
> The point is to get something that works with the "native" tools. In
> Xen world the goal was to create a valid /etc/xen/ config file, in
> QEMU world the goal is to create an ARGV set you can use to launch
> QEMU. So you are correct that we s
On 03/14/2014 04:43 AM, Jiri Denemark wrote:
> Ancient automake (such as from RHEL5) does not provide abs_srcdir and
> abs_builddir variables which are used by a recent commit of mine
> (e562e82).
>
> Signed-off-by: Jiri Denemark
> ---
> src/Makefile.am | 4
> 1 file changed, 4 insertions(+
On 05.03.2014 13:08, Michal Privoznik wrote:
https://bugzilla.redhat.com/show_bug.cgi?id=981729
So far we can limit how many clients are connected,
how many are waiting in accept() line but we could
not control the count of accepted but not
authenticated yet.
diff to v2:
-Dan's suggestions work
On Fri, Mar 14, 2014 at 09:20:14AM -0400, Cole Robinson wrote:
> On 03/13/2014 05:18 PM, Laine Stump wrote:
> > On 03/13/2014 01:13 PM, Cole Robinson wrote:
> >> Just skip the vhost command line generation, since this won't work if
> >> attempting to run manually.
> >> ---
> >> src/qemu/qemu_comma
-S causes qemu to start in the paused state. Since XML2Native is intended
to generate something that users can run directly, this will trip them up.
---
v2:
s/forXMLToArgv/standalone/g
src/qemu/qemu_command.c | 8 ++--
src/qemu/qemu_command.h | 3 ++-
src/qemu/qemu_driver.c | 6 -
Right now we are parsing the XML as though it's live, which for example
will choke on hardcoded XML like:
Erroring with:
$ sudo virsh domxml-to-native qemu-argv f
error: XML error: security label is missing
All drivers are fixed, but only qemu was tested.
---
v2:
Fix all drivers
s
Just skip the vhost command line generation, since this won't work if
attempting to run manually.
---
v2:
s/forXMLToArgv/standalone/g
src/qemu/qemu_command.c | 15 +--
1 file changed, 9 insertions(+), 6 deletions(-)
diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c
i
On 03/13/2014 06:27 PM, Jim Fehlig wrote:
> Cole Robinson wrote:
>> Right now we are parsing the XML as though it's live, which for example
>> will choke on hardcoded XML like:
>>
>>
>>
>> Erroring with:
>>
>> $ sudo virsh domxml-to-native qemu-argv f
>> error: XML error: security label is m
On 03/13/2014 05:18 PM, Laine Stump wrote:
> On 03/13/2014 01:13 PM, Cole Robinson wrote:
>> Just skip the vhost command line generation, since this won't work if
>> attempting to run manually.
>> ---
>> src/qemu/qemu_command.c | 15 +--
>> 1 file changed, 9 insertions(+), 6 deletions(
On Fri, Mar 14, 2014 at 06:45:59AM -0400, John Ferlan wrote:
> A recent change to openvz_driver.c caused Coverity to make additional
> comparisons and find that the openvzRegister() was not checking the
> status of virRegisterDriver() call like other callers and thus generated
> a CHECKED_RETURN co
On Wed, Mar 12, 2014 at 02:21:46PM -0600, Eric Blake wrote:
> # virsh vol-dumpxml --pool gluster img3
>
> img3
> vol1/img3
> ...
>
> gluster://localhost/vol1/img3
A shame we chose this representation instead of something that
matched the format used in the domain XML. At least we can a
On 14.3.2014 11:43, Jiri Denemark wrote:
Ancient automake (such as from RHEL5) does not provide abs_srcdir and
abs_builddir variables which are used by a recent commit of mine
(e562e82).
Signed-off-by: Jiri Denemark
---
src/Makefile.am | 4
1 file changed, 4 insertions(+)
diff --git a/
On Wed, Mar 12, 2014 at 05:34:17PM -0600, Eric Blake wrote:
> Hmm. Another feature coming down the pipes in qemu 2.0 is the ability
> to give an alias to any portion of the backing chain. Right now, we
> have an element tied to the as a whole (in qemu parlance,
> the device id), but some qemu o
A recent change to openvz_driver.c caused Coverity to make additional
comparisons and find that the openvzRegister() was not checking the
status of virRegisterDriver() call like other callers and thus generated
a CHECKED_RETURN condition
Signed-off-by: John Ferlan
---
src/openvz/openvz_driver.c
Ancient automake (such as from RHEL5) does not provide abs_srcdir and
abs_builddir variables which are used by a recent commit of mine
(e562e82).
Signed-off-by: Jiri Denemark
---
src/Makefile.am | 4
1 file changed, 4 insertions(+)
diff --git a/src/Makefile.am b/src/Makefile.am
index d4d7b
36 matches
Mail list logo
