[libvirt] [PATCH] Modify help information of virsh list command

2014-03-27 Thread Li Yang
Use 'virsh list domain --title' option can get domain's title, not description, the original help information 'show short domain description' will confuse users, so modify it to 'show domain title' Signed-off-by: Li Yang liyang.f...@cn.fujitsu.com --- tools/virsh-domain-monitor.c |2 +- 1

Re: [libvirt] [PATCH] Fix Memory Leak in testGetCaps()

2014-03-27 Thread Ján Tomko
On 03/26/2014 11:37 PM, Nehal J Wani wrote: While running qemucaps2xmltest, it was found that valgrind pointed out the following memory leaks: ==27045== 160 (112 direct, 48 indirect) bytes in 1 blocks are definitely lost in loss record 51 of 65 ==27045==at 0x4A0577B: calloc

[libvirt] [PATCH v6 0/3] fix query-command-line-options

2014-03-27 Thread Amos Kong
This patchset fixed some issues of query-command-line-options: * some new options that haven't argument can't be queried. (eg: -enable-fips) * some legacy options that have argument can't be queried. (eg: -vnc display) More discussion: http://marc.info/?l=qemu-develm=139081830416684w=2

[libvirt] [PATCH v6 1/3] qmp: rename query_option_descs() to get_param_info()

2014-03-27 Thread Amos Kong
Signed-off-by: Amos Kong ak...@redhat.com Reviewed-by: Eric Blake ebl...@redhat.com --- util/qemu-config.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/util/qemu-config.c b/util/qemu-config.c index f610101..508adbc 100644 --- a/util/qemu-config.c +++

[libvirt] [PATCH v6 2/3] query-command-line-options: expose implicit parameter name

2014-03-27 Thread Amos Kong
This patch added a new field to expose implicit parameter name, we make it optional for compatibility. Suggested-by: Eric Blake ebl...@redhat.com Signed-off-by: Amos Kong ak...@redhat.com --- qapi-schema.json | 6 +- util/qemu-config.c | 24 +++- 2 files changed, 20

[libvirt] [PATCH v6 3/3] query-command-line-options: query all the options in qemu-options.hx

2014-03-27 Thread Amos Kong
vm_config_groups[] only contains part of the options which have parameters, and all options which have no parameter aren't added to vm_config_groups[]. Current query-command-line-options only checks options from vm_config_groups[], so some options will be lost. We have macro in qemu-options.hx to

Re: [libvirt] [Qemu-devel] [PATCH v6 0/3] fix query-command-line-options

2014-03-27 Thread Amos Kong
On Thu, Mar 27, 2014 at 02:57:00PM +0800, Amos Kong wrote: This patchset fixed some issues of query-command-line-options: * some new options that haven't argument can't be queried. (eg: -enable-fips) * some legacy options that have argument can't be queried. (eg: -vnc display) More

[libvirt] [PATCH] bhyve: add domainLookupByID

2014-03-27 Thread Wojciech Macek
Implement domainLookupByID as required by OpenStack stuff. Wojciech Macek (1): bhyve: add domainLookupByID src/bhyve/bhyve_driver.c | 29 + 1 file changed, 29 insertions(+) -- 1.9.0 -- libvir-list mailing list libvir-list@redhat.com

[libvirt] [PATCH] bhyve: add domainLookupByID

2014-03-27 Thread Wojciech Macek
Implement domain lookup by its ID. --- src/bhyve/bhyve_driver.c | 29 + 1 file changed, 29 insertions(+) diff --git a/src/bhyve/bhyve_driver.c b/src/bhyve/bhyve_driver.c index f54dff0..38a7f41 100644 --- a/src/bhyve/bhyve_driver.c +++ b/src/bhyve/bhyve_driver.c @@

Re: [libvirt] [RFC PATCH] Behaviour of topology, vcpus and maxcpus

2014-03-27 Thread Nikunj A Dadhania
Nikunj A Dadhania nik...@linux.vnet.ibm.com writes: I have observed the following with libvirt xml: vcpu6/vcpu cpu topology sockets='1' cores='4' threads='2'/ /cpu So according to the topology maximum supported is 8 vcpus, while the libvirt sets that to 6 - specified in vcpu tag.

Re: [libvirt] [PATCH] bhyve: add domainLookupByID

2014-03-27 Thread Roman Bogorodskiy
Wojciech Macek wrote: Implement domain lookup by its ID. --- src/bhyve/bhyve_driver.c | 29 + 1 file changed, 29 insertions(+) static virDriver bhyveDriver = { .no = VIR_DRV_BHYVE, .name = bhyve, @@ -811,6 +839,7 @@ static virDriver bhyveDriver

Re: [libvirt] is there a way to convert vm's filter into comandline

2014-03-27 Thread Laine Stump
On 03/27/2014 04:43 AM, Eric Blake wrote: On 03/26/2014 07:20 PM, bigclouds wrote: hi,all is there a way to convert vm's filter into comandline, i think it is useful. You mean, as in virsh domxml-to-native qemu-argv $(virsh dumpxml $dom) or are you asking about the nwfilter settings

Re: [libvirt] [Qemu-devel] [PATCH v4 2/2] query-command-line-options: query all the options in qemu-options.hx

2014-03-27 Thread Markus Armbruster
Amos Kong ak...@redhat.com writes: On Wed, Mar 26, 2014 at 02:15:18PM +0100, Markus Armbruster wrote: Amos Kong ak...@redhat.com writes: On Fri, Mar 07, 2014 at 10:54:09AM +0100, Markus Armbruster wrote: Eric Blake ebl...@redhat.com writes: On 03/05/2014 07:36 PM, Amos Kong wrote:

Re: [libvirt] [TCK] nwfilter tests and libvirt commit 4f209434

2014-03-27 Thread Laine Stump
On 03/27/2014 12:22 AM, Mike Latimer wrote: Hi, As I've been looking through libvirt-tck tests, I found that commit 4f209434 (in libvirt) changes a condition that the nwfilter/050-apply-verify-host.t relies on. Specifically, the 050-apply-verify-host.t test creates a number of filters

Re: [libvirt] [PATCH v2] Fix Memory Leak in virQEMUCapsInitGuestFromBinary()

2014-03-27 Thread Daniel P. Berrange
On Thu, Mar 27, 2014 at 03:17:09AM +0530, Nehal J Wani wrote: While running qemucaps2xmltest, it was found that valgrind pointed out the following memory leaks: ==29896== 0 bytes in 1 blocks are definitely lost in loss record 1 of 65 ==29896==at 0x4A0577B: calloc

Re: [libvirt] [TCK] nwfilter tests and libvirt commit 4f209434

2014-03-27 Thread Daniel P. Berrange
On Wed, Mar 26, 2014 at 04:22:04PM -0600, Mike Latimer wrote: Hi, As I've been looking through libvirt-tck tests, I found that commit 4f209434 (in libvirt) changes a condition that the nwfilter/050-apply-verify-host.t relies on. Specifically, the 050-apply-verify-host.t test creates a

Re: [libvirt] is there a way to convert vm's filter into comandline

2014-03-27 Thread Daniel P. Berrange
On Thu, Mar 27, 2014 at 09:20:23AM +0800, bigclouds wrote: hi,all is there a way to convert vm's filter into comandline, i think it is useful. if there is the functionality, so you think it is worthy to be done. Currently the nwfilter driver generates horrible hacky shell scripts which run

Re: [libvirt] [PATCH v2] Fix Memory Leak in virQEMUCapsInitGuestFromBinary()

2014-03-27 Thread Nehal J Wani
This doesn't look at all right either. If nmachines is 0, then machines should already be NULL. If you look at the code of virQEMUCapsGetMachineTypesCaps, you see: int virQEMUCapsGetMachineTypesCaps(virQEMUCapsPtr qemuCaps, size_t *nmachines,

Re: [libvirt] [PATCH v2] Fix Memory Leak in virQEMUCapsInitGuestFromBinary()

2014-03-27 Thread Daniel P. Berrange
On Thu, Mar 27, 2014 at 04:39:28PM +0530, Nehal J Wani wrote: This doesn't look at all right either. If nmachines is 0, then machines should already be NULL. If you look at the code of virQEMUCapsGetMachineTypesCaps, you see: int virQEMUCapsGetMachineTypesCaps(virQEMUCapsPtr qemuCaps,

[libvirt] [PATCH] docs: cgroups: fix typo about LXC cgroups

2014-03-27 Thread Jean-Baptiste Rouault
--- docs/cgroups.html.in | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/docs/cgroups.html.in b/docs/cgroups.html.in index f7c2450..33de453 100644 --- a/docs/cgroups.html.in +++ b/docs/cgroups.html.in @@ -33,9 +33,9 @@ p The LXC driver is capable of using the

[libvirt] [PATCHv3] Fix Memory Leak in virQEMUCapsInitGuestFromBinary()

2014-03-27 Thread Nehal J Wani
While running qemucaps2xmltest, it was found that valgrind pointed out the following memory leaks: ==29896== 0 bytes in 1 blocks are definitely lost in loss record 1 of 65 ==29896==at 0x4A0577B: calloc (vg_replace_malloc.c:593) ==29896==by 0x4C6B45E: virAllocN (viralloc.c:191) ==29896==

Re: [libvirt] [PATCH v2] libvirt-tck: prefer kvm domains if multiple domain types exist

2014-03-27 Thread Daniel P. Berrange
On Fri, Mar 07, 2014 at 11:06:35AM -0700, Mike Latimer wrote: When matching capabilities of a guest, if multiple domain types exist (for example, 'qemu' and 'kvm') the order in which they are returned can change. To avoid unpredictable test results, this patch prefers kvm if that domain type

Re: [libvirt] [PATCH] libvirt-tck: 052-domain-hook.t - reload after hook cleanup

2014-03-27 Thread Daniel P. Berrange
On Thu, Mar 06, 2014 at 03:41:01PM -0700, Mike Latimer wrote: Reload libvirtd after hook testing has completed. Otherwise, libvirtd is still expecting hook test scripts to exist. --- scripts/hooks/052-domain-hook.t | 4 1 file changed, 4 insertions(+) diff --git

[libvirt] [PATCH] Cope with newer ebtables tools in testvm.fwall.dat

2014-03-27 Thread Daniel P. Berrange
Newer ebtables tools turn 0x8035 into RARP, so our test file must expect this. Signed-off-by: Daniel P. Berrange berra...@redhat.com --- scripts/nwfilter/nwfilterxml2fwallout/testvm.fwall.dat | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git

[libvirt] [PATCH] Remove illegal values in nwfilter test XML/firewall files

2014-03-27 Thread Daniel P. Berrange
A number of the nwfilter XML files have attribute values which are out of range. Previously the libvirt nwfilter XML parser would silently ignore illegal values, causing them to default to 0. This resulted in creating incorrect iptables rules, which the TCK suite then validated as correct. Current

[libvirt] [PATCH] Do not truncate output of nwfilter2vmtest.sh

2014-03-27 Thread Daniel P. Berrange
When printing test results, nwfilter2vmtest.sh, truncates the output at 66 or 70 characters. This is very unhelpful when debugging problems where you want to see the full output Signed-off-by: Daniel P. Berrange berra...@redhat.com --- scripts/nwfilter/nwfilter2vmtest.sh | 4 ++-- 1 file

Re: [libvirt] [PATCH] Remove illegal values in nwfilter test XML/firewall files

2014-03-27 Thread Eric Blake
On 03/27/2014 05:44 AM, Daniel P. Berrange wrote: You might want to 'git config format.subjectprefix tck PATCH' to make it obvious when you are patching libvirt-tck. A number of the nwfilter XML files have attribute values which are out of range. Previously the libvirt nwfilter XML parser

[libvirt] libvirt Wiki account creation request

2014-03-27 Thread Sophoklis Goumas
... We still welcome contributions from anyone interested in updating content. Simply send an email to the main libvirt development list asking for an account and one will be created for you with as little delay as practical. ... Hence, Sophoklis -- libvir-list mailing list

Re: [libvirt] [PATCH] Do not truncate output of nwfilter2vmtest.sh

2014-03-27 Thread Eric Blake
On 03/27/2014 05:45 AM, Daniel P. Berrange wrote: When printing test results, nwfilter2vmtest.sh, truncates the output at 66 or 70 characters. This is very unhelpful when debugging problems where you want to see the full output Signed-off-by: Daniel P. Berrange berra...@redhat.com ---

Re: [libvirt] [PATCH] Cope with newer ebtables tools in testvm.fwall.dat

2014-03-27 Thread Eric Blake
On 03/27/2014 05:44 AM, Daniel P. Berrange wrote: Newer ebtables tools turn 0x8035 into RARP, so our test file must expect this. Signed-off-by: Daniel P. Berrange berra...@redhat.com --- scripts/nwfilter/nwfilterxml2fwallout/testvm.fwall.dat | 8 1 file changed, 4 insertions(+),

Re: [libvirt] [PATCH] Remove illegal values in nwfilter test XML/firewall files

2014-03-27 Thread Daniel P. Berrange
On Thu, Mar 27, 2014 at 06:04:41AM -0600, Eric Blake wrote: On 03/27/2014 05:44 AM, Daniel P. Berrange wrote: You might want to 'git config format.subjectprefix tck PATCH' to make it obvious when you are patching libvirt-tck. A number of the nwfilter XML files have attribute values

Re: [libvirt] libvirt Wiki account creation request

2014-03-27 Thread Daniel P. Berrange
On Thu, Mar 27, 2014 at 02:04:32PM +0200, Sophoklis Goumas wrote: ... We still welcome contributions from anyone interested in updating content. Simply send an email to the main libvirt development list asking for an account and one will be created for you with as little delay as

[libvirt] question for qemu migrate fail by virDomainMigrate API

2014-03-27 Thread Wangrui (K)
Hi everyone, when I use the API virDomainMigrate to do migration operation in KVM environment(libvirt1.1.0 qemu1.5.1), I encountered with some problems. I found that If the connection to source side is disconnected in the BEGIN phase of a migration, the migration job would fail. Further more,

Re: [libvirt] [PATCH] docs: cgroups: fix typo about LXC cgroups

2014-03-27 Thread Eric Blake
On 03/27/2014 05:21 AM, Jean-Baptiste Rouault wrote: --- docs/cgroups.html.in | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) ACK, will push shortly. diff --git a/docs/cgroups.html.in b/docs/cgroups.html.in index f7c2450..33de453 100644 --- a/docs/cgroups.html.in +++

Re: [libvirt] [PATCHv3] Fix Memory Leak in virQEMUCapsInitGuestFromBinary()

2014-03-27 Thread Eric Blake
On 03/27/2014 05:38 AM, Nehal J Wani wrote: While running qemucaps2xmltest, it was found that valgrind pointed out the following memory leaks: ==29896== 0 bytes in 1 blocks are definitely lost in loss record 1 of 65 ==29896==at 0x4A0577B: calloc (vg_replace_malloc.c:593) ==29896==by

[libvirt] Entering freeze for libvirt-1.2.3

2014-03-27 Thread Daniel Veillard
I'm one day late but i have tagged the tree and pushed a release candidate 1 tarball and associated rpms to the usual place: ftp://libvirt.org/libvirt/ Being optimistic maybe we can push it on April 1st but maybe it will be safer to wait for Wed for more feedback. I gave it a bit of

[libvirt] [PATCH]execute netdev_del after receive DEVICE_DELETED event

2014-03-27 Thread x00221466
Hi, When live detaching the virtual net device, such as virtio nic、 RTL8139、E1000, there are some problems: (1)If the Guest OS don't support the hot plugging pci device, detach the virtual network device by Libvirt, the net device in Qemu will still exist, but hostnet(tap) in Qemu will be

Re: [libvirt] [PATCHv3] Fix Memory Leak in virQEMUCapsInitGuestFromBinary()

2014-03-27 Thread Eric Blake
On 03/27/2014 05:38 AM, Nehal J Wani wrote: While running qemucaps2xmltest, it was found that valgrind pointed out the following memory leaks: +++ b/src/qemu/qemu_capabilities.c @@ -1996,10 +1996,12 @@ int virQEMUCapsGetMachineTypesCaps(virQEMUCapsPtr qemuCaps, *nmachines = 0;

Re: [libvirt] [Qemu-devel] [PATCH v4 for 2.0 0/3] ABI change: change group name of option table to match with option name

2014-03-27 Thread Amos Kong
On Thu, Mar 27, 2014 at 01:28:37PM +0100, Paolo Bonzini wrote: Il 27/03/2014 03:38, Amos Kong ha scritto: This patchset changes group names of option tables to match with option name, this breakes ABI, release note was updated. Amos Kong (3): only add qemu_tpmdev_opts when CONFIG_TPM is

[libvirt] [PATCH v5 for 2.0 0/3] ABI change: change group name of option table to match with option name

2014-03-27 Thread Amos Kong
This patchset changes group names of option tables to match with option name, this breakes ABI, release note was updated. V4: fix tpmdev, add name matching test (markus) V5: adjust patch order (paolo) Amos Kong (3): only add qemu_tpmdev_opts when CONFIG_TPM is defined update names in option

[libvirt] [PATCH v5 for 2.0 1/3] only add qemu_tpmdev_opts when CONFIG_TPM is defined

2014-03-27 Thread Amos Kong
Signed-off-by: Amos Kong ak...@redhat.com --- vl.c | 4 1 file changed, 4 insertions(+) diff --git a/vl.c b/vl.c index 2355227..596ecfa 100644 --- a/vl.c +++ b/vl.c @@ -449,6 +449,7 @@ static QemuOptsList qemu_object_opts = { }, }; +#ifdef CONFIG_TPM static QemuOptsList

[libvirt] [PATCH v5 for 2.0 2/3] update names in option tables to match with actual command-line spelling

2014-03-27 Thread Amos Kong
We want to establish a mapping between option name and option table, then we can search related option table by option name. This patch makes all the member name of QemuOptsList to match with actual command-line spelling(option name). [ Important Note ] The QemuOptsList member name values are

[libvirt] [PATCH v5 for 2.0 3/3] abort QEMU if group name in option table doesn't match with defined option name

2014-03-27 Thread Amos Kong
All the options are defined in qemu-options.hx. If we can't find a matched option definition by group name of option table, then the group name doesn't match with defined option name, it's not allowed from 2.0 Signed-off-by: Amos Kong ak...@redhat.com --- qemu-options.h | 12

Re: [libvirt] [PATCH 1/n] conf: split security label structs to util/

2014-03-27 Thread Peter Krempa
On 03/27/14 00:09, Eric Blake wrote: In order to reuse the newly-created host-side disk struct in the virstoragefile backing chain code, I first have to move it to util/. This starts the process, by first moving the security label structures. * src/conf/domain_conf.h

Re: [libvirt] [PATCH 2/n] conf: split network host structs to util/

2014-03-27 Thread Peter Krempa
On 03/27/14 00:09, Eric Blake wrote: Continuing the refactoring of host-side storage descriptions out of conf/domain_conf and into util/virstoragefile, this patch focuses on details about a host name/port/transport as used by a network storage volume. * src/conf/domain_conf.h

[libvirt] Device attach / detach problem for passthrough/SR-IOV in libvirt

2014-03-27 Thread Mohsen Ghaemi
Hi all I just encountered a problem in libvirt while was trying to attach and detach a sr-iov vf to my VM The version of my libvirt is 1.1.1-0ubuntu8.5 I tried to attach the device using following xml interface type='hostdev' managed='yes' mac address='5c:01:fd:12:34:58'/ source

Re: [libvirt] [PATCH] Modify help information of virsh list command

2014-03-27 Thread Eric Blake
On 03/27/2014 12:10 AM, Li Yang wrote: Use 'virsh list domain --title' option can get domain's title, not description, the original help information 'show short domain description' will confuse users, so modify it to 'show domain title' Signed-off-by: Li Yang liyang.f...@cn.fujitsu.com ---

Re: [libvirt] [PATCH] libvirt-tck: 052-domain-hook.t - reload after hook cleanup

2014-03-27 Thread Eric Blake
On 03/27/2014 05:39 AM, Daniel P. Berrange wrote: On Thu, Mar 06, 2014 at 03:41:01PM -0700, Mike Latimer wrote: Reload libvirtd after hook testing has completed. Otherwise, libvirtd is still expecting hook test scripts to exist. --- scripts/hooks/052-domain-hook.t | 4 1 file changed,

Re: [libvirt] [PATCH]execute netdev_del after receive DEVICE_DELETED event

2014-03-27 Thread Jiri Denemark
On Thu, Mar 27, 2014 at 20:51:24 +0800, x00221466 wrote: Hi, When live detaching the virtual net device, such as virtio nic、 RTL8139、E1000, there are some problems: (1)If the Guest OS don't support the hot plugging pci device, detach the virtual network device by Libvirt, the net device

Re: [libvirt] [PATCH]execute netdev_del after receive DEVICE_DELETED event

2014-03-27 Thread Daniel P. Berrange
On Thu, Mar 27, 2014 at 03:14:06PM +0100, Jiri Denemark wrote: On Thu, Mar 27, 2014 at 20:51:24 +0800, x00221466 wrote: Hi, When live detaching the virtual net device, such as virtio nic、 RTL8139、E1000, there are some problems: (1)If the Guest OS don't support the hot plugging pci

Re: [libvirt] [PATCH 0/3] ABI change: change group name of option table to match with option name

2014-03-27 Thread Paolo Bonzini
Il 27/03/2014 03:38, Amos Kong ha scritto: This patchset changes group names of option tables to match with option name, this breakes ABI, release note was updated. Amos Kong (3): only add qemu_tpmdev_opts when CONFIG_TPM is defined abort QEMU if group name in option table doesn't match

Re: [libvirt] is there a way to convert vm's filter into comandline

2014-03-27 Thread longguang.yue
killing all of the shell script code ? you mean nwfilter of libvirt does not exist any more? yes. nwfilter code is horrible . maybe we can think of a better way. after all ip|eb tables is complicated, and must be done, user or libvirt. thanks At 2014-03-27 18:57:23,Daniel P.

[libvirt] VM host name

2014-03-27 Thread Vikas Kokare
Is there a way using LibVirt (java) API to find out the DNS host name of a virtual machine, if already configured? -Vikas -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] is there a way to convert vm's filter into comandline

2014-03-27 Thread longguang.yue
Dan Berrange: if there are some one work with you to refactore nwfilter architeture. i hope i can help thanks At 2014-03-27 17:41:15,Laine Stump la...@laine.org wrote: On 03/27/2014 04:43 AM, Eric Blake wrote: On 03/26/2014 07:20 PM, bigclouds wrote: hi,all is there a way to

Re: [libvirt] is there a way to convert vm's filter into comandline

2014-03-27 Thread Eric Blake
On 03/27/2014 08:25 AM, longguang.yue wrote: [please don't top-post on technical lists] killing all of the shell script code ? Rewriting it so it uses saner mechanisms than shell script. you mean nwfilter of libvirt does not exist any more? No. nwfilter will still exist, it will just be

[libvirt] [PATCH tck] Adapt network tests to changed cli tool formats

2014-03-27 Thread Daniel P. Berrange
The network tests invoke various ifconfig and route commands to test network setup, and also grep for dnsmasq/radvd args. Switch to use 'ip' since ifconfig and route commands are not installed by default on recent distros any more and their output formats have also changed. Remove grepping for

[libvirt] [PATCH tck] Change 'Sys::Virt::TCK::generic_domain' to take named params

2014-03-27 Thread Daniel P. Berrange
To make it easier to add more optional parameters to the Sys::Virt::TCK::generic_domain method, change it to take named parameters instead of positional parameters. Signed-off-by: Daniel P. Berrange berra...@redhat.com --- docs/writing-tests.pod | 6 ++---

Re: [libvirt] [PATCH]execute netdev_del after receive DEVICE_DELETED event

2014-03-27 Thread Jiri Denemark
On Thu, Mar 27, 2014 at 14:18:46 +, Daniel Berrange wrote: On Thu, Mar 27, 2014 at 03:14:06PM +0100, Jiri Denemark wrote: On Thu, Mar 27, 2014 at 20:51:24 +0800, x00221466 wrote: Hi, When live detaching the virtual net device, such as virtio nic、 RTL8139、E1000, there are some

Re: [libvirt] is there a way to convert vm's filter into comandline

2014-03-27 Thread Daniel P. Berrange
On Thu, Mar 27, 2014 at 10:31:32PM +0800, longguang.yue wrote: Dan Berrange: if there are some one work with you to refactore nwfilter architeture. i hope i can help I've already done pretty much all the work for this. I'm onto testing it now before posting for review. Regards, Daniel -- |:

Re: [libvirt] Crash when using python-libvirt setSchedulerParameters

2014-03-27 Thread Brian Rak
On 3/25/2014 6:50 AM, Michal Privoznik wrote: On 24.03.2014 21:45, Brian Rak wrote: I'm seeing a very weird (and somewhat reproducable) crash in setSchedulerParameters. The backtrace looks like this: *** glibc detected *** python2.7: free(): invalid pointer: 0x0152bc48 *** ===

Re: [libvirt] [PATCH 1/2] Fixed regression in apparmor profiles for qemu brought by 43c030f

2014-03-27 Thread Eric Blake
On 03/24/2014 11:20 AM, Cédric Bosdonnat wrote: --- src/security/virt-aa-helper.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) ACK and pushed. diff --git a/src/security/virt-aa-helper.c b/src/security/virt-aa-helper.c index b8b0610..59de517 100644 ---

Re: [libvirt] Crash when using python-libvirt setSchedulerParameters

2014-03-27 Thread Brian Rak
On 3/27/2014 10:54 AM, Brian Rak wrote: On 3/25/2014 6:50 AM, Michal Privoznik wrote: On 24.03.2014 21:45, Brian Rak wrote: I'm seeing a very weird (and somewhat reproducable) crash in setSchedulerParameters. The backtrace looks like this: *** glibc detected *** python2.7: free(): invalid

Re: [libvirt] [PATCH v2] Fix apparmor profile to make vfio pci passthrough work

2014-03-27 Thread Eric Blake
On 03/25/2014 03:27 PM, Serge Hallyn wrote: Quoting Cedric Bosdonnat (cbosdon...@suse.com): On Tue, 2014-03-25 at 10:40 -0500, Serge Hallyn wrote: Quoting Cédric Bosdonnat (cbosdon...@suse.com): See lp#1276719 for the bug description. As virt-aa-helper doesn't know the VFIO groups to use for

Re: [libvirt] Crash when using python-libvirt setSchedulerParameters

2014-03-27 Thread Michal Privoznik
On 27.03.2014 16:01, Brian Rak wrote: On 3/27/2014 10:54 AM, Brian Rak wrote: On 3/25/2014 6:50 AM, Michal Privoznik wrote: On 24.03.2014 21:45, Brian Rak wrote: I'm seeing a very weird (and somewhat reproducable) crash in setSchedulerParameters. The backtrace looks like this: *** glibc

[libvirt] [PATCH tck] Avoid assumptions about selinux contexts

2014-03-27 Thread Daniel P. Berrange
The current SELinux tests assume a context system_u:system_r or system_u:object_r, which is not true if running against a libvirtd from the source tree. --- lib/Sys/Virt/TCK/SELinux.pm | 30 +++--- scripts/selinux/050-dynamic-relabel-yes.t | 10 ++

[libvirt] [PATCH] Fix potential crash when setting partial cpu/memory/numa/interface limits on domains

2014-03-27 Thread Brian Rak
The number of parameters in new_params is not guaranteed to be the same as the number of parameters in params. Use the correct count when freeing new_params to avoid crashes --- libvirt-override.c | 24 1 files changed, 12 insertions(+), 12 deletions(-) diff --git

[libvirt] [PATCH tck] Fix 202-numa-set-parameters.t test querying numa params

2014-03-27 Thread Daniel P. Berrange
The 202-numa-set-parameters.t test would attempt to fetch NUMA parameters while the guest is shutoff using the VIR_DOMAIN_AFFECT_LIVE parameter. Change it to use the param AFFECT_CONFIG instead, and add a separate test for AFFECT_LIVE after the guest has been started again. Signed-off-by: Daniel

Re: [libvirt] [PATCH] Added example script on how to convert LXC container config

2014-03-27 Thread Eric Blake
On 03/11/2014 06:40 AM, Cédric Bosdonnat wrote: --- Makefile.am | 2 +- configure.ac | 1 + examples/lxcconvert/Makefile.am | 19 ++ examples/lxcconvert/virt-lxc-convert | 67 4 files

Re: [libvirt] [PATCH] Do not truncate output of nwfilter2vmtest.sh

2014-03-27 Thread Mike Latimer
On Thursday, March 27, 2014 11:45:06 AM Daniel P. Berrange wrote: When printing test results, nwfilter2vmtest.sh, truncates the output at 66 or 70 characters. This is very unhelpful when debugging problems where you want to see the full output Signed-off-by: Daniel P. Berrange

[libvirt] [PATCH 3/3] libxl: Implement basic video device selection

2014-03-27 Thread Stefan Bader
This started as an investigation into an issue where libvirt (using the libxl driver) and the Xen host, like an old couple, could not agree on who is responsible for selecting the VNC port to use. Things usually (and a bit surprisingly) did work because, just like that old couple, they had the

[libvirt] libxl fixes/improvements for libvirt

2014-03-27 Thread Stefan Bader
Here several changes which improve the handling of Xen for me: * 0001-libxl-Use-id-from-virDomainObj-inside-the-driver.patch This is a re-send as I initially submitted that as a reply to some discussion. Starting from the visibly broken libxlDomainGetInfo when creating or rebooting a guest

[libvirt] [PATCH 2/3] libxl: Set disk format for empty cdrom device

2014-03-27 Thread Stefan Bader
The XML config for a CDROM device can be without a source path, indicating that there is no media present. Without this change the libxl driver fails to start a guest in that case because the libxl library checks for the LIBXL_DISK_FORMAT_EMPTY format type and tries to stat the NULL pointer that

[libvirt] [PATCH 1/3] libxl: Use id from virDomainObj inside the driver

2014-03-27 Thread Stefan Bader
There is a domain id in the virDomain structure as well as in the virDomainObj structure. While the former can become stale the latter is kept up to date. So it is safer to always (virDomainObjPtr)-def-id internally. This will fix issues seen when managing Xen guests through libvirt from

Re: [libvirt] [PATCH] Do not truncate output of nwfilter2vmtest.sh

2014-03-27 Thread Eric Blake
On 03/27/2014 10:45 AM, Mike Latimer wrote: On Thursday, March 27, 2014 11:45:06 AM Daniel P. Berrange wrote: When printing test results, nwfilter2vmtest.sh, truncates the output at 66 or 70 characters. This is very unhelpful when debugging problems where you want to see the full output

Re: [libvirt] [PATCH] Do not truncate output of nwfilter2vmtest.sh

2014-03-27 Thread Mike Latimer
On Thursday, March 27, 2014 11:10:15 AM Eric Blake wrote: New or not, your reviews are helpful! We all had to start somewhere. And right now, the fact that you are attempting to run tck gives you better status as a reviewer, even if only to say I applied this, and it {still passed for

Re: [libvirt] [PATCH tck] Change 'Sys::Virt::TCK::generic_domain' to take named params

2014-03-27 Thread Mike Latimer
On Thursday, March 27, 2014 02:49:11 PM Daniel P. Berrange wrote: To make it easier to add more optional parameters to the Sys::Virt::TCK::generic_domain method, change it to take named parameters instead of positional parameters. Signed-off-by: Daniel P. Berrange berra...@redhat.com ---

Re: [libvirt] [PATCH tck] Fix 202-numa-set-parameters.t test querying numa params

2014-03-27 Thread Mike Latimer
On Thursday, March 27, 2014 03:38:47 PM Daniel P. Berrange wrote: The 202-numa-set-parameters.t test would attempt to fetch NUMA parameters while the guest is shutoff using the VIR_DOMAIN_AFFECT_LIVE parameter. Change it to use the param AFFECT_CONFIG instead, and add a separate test for

[libvirt] [PATCH] Expose SLIRP attributes

2014-03-27 Thread Michal Privoznik
We allow users to use SLIRP stack. However, there are some knobs which are not exposed to users, such as host network address, DNS server, smb, and others. Signed-off-by: Michal Privoznik mpriv...@redhat.com --- docs/formatdomain.html.in | 7 +-

Re: [libvirt] [PATCH] Expose SLIRP attributes

2014-03-27 Thread Eric Blake
On 03/27/2014 11:17 AM, Michal Privoznik wrote: We allow users to use SLIRP stack. However, there are some knobs which are not exposed to users, such as host network address, DNS server, smb, and others. Signed-off-by: Michal Privoznik mpriv...@redhat.com --- docs/formatdomain.html.in

[libvirt] Segfault in libvirt.git virHostdevManagerOnceInit

2014-03-27 Thread Richard W.M. Jones
Current libvirt.git: $ ~/d/libvirt/run gdb --args ~/d/libvirt/daemon/libvirtd --timeout=30 [...] 2014-03-27 18:44:21.816+: 11868: info : libvirt version: 1.2.3 2014-03-27 18:44:21.816+: 11868: error : virHostdevManagerNew:116 : operation failed: Failed to create state dir

Re: [libvirt] [PATCH] Expose SLIRP attributes

2014-03-27 Thread Richard W.M. Jones
On Thu, Mar 27, 2014 at 06:17:46PM +0100, Michal Privoznik wrote: We allow users to use SLIRP stack. However, there are some knobs which are not exposed to users, such as host network address, DNS server, smb, and others. The XML looks good. I have posted a patch to libguestfs to consume this

Re: [libvirt] [PATCH tck] Adapt network tests to changed cli tool formats

2014-03-27 Thread Mike Latimer
On Thursday, March 27, 2014 02:49:25 PM Daniel P. Berrange wrote: The network tests invoke various ifconfig and route commands to test network setup, and also grep for dnsmasq/radvd args. Switch to use 'ip' since ifconfig and route commands are not installed by default on recent distros any

[libvirt] [PATCH tck] 300-vsitype.t: skip earlier if lldptool is not available

2014-03-27 Thread Mike Latimer
Move the test for /usr/sbin/lldptool up so libvirt-tck will report the skip and reason, rather than passing the test as 'ok'. --- scripts/nwfilter/300-vsitype.t | 48 ++ 1 file changed, 25 insertions(+), 23 deletions(-) diff --git

Re: [libvirt] [PATCH v4 0/5] Expose FSFreeze/FSThaw within the guest as API

2014-03-27 Thread Jon Bernard
* Tomoki Sekiyama tomoki.sekiy...@hds.com wrote: Hello, This is patchset v4 to add FSFreeze/FSThaw API for custom disk snapshotting. This patchset works for my tests. Without pausing the guest I am able to quiesce all attached volumes. Does there exists an option to create a snapshot of

[libvirt] [PATCH 1/2] ESX: Allow method calls for VI version 2.5

2014-03-27 Thread Dawid Zamirski
Currently, ESX driver can only issue VI method calls available in version 2.5. To send method calls available in newer versions, a SOAPAction header needs to be set in the following format: 'SOAPAction: urn:vim25/version_number' This patch modifies the Python code generator to optionally read

[libvirt] [PATCH 2/2] ESX: Implement virDomainScreenshot

2014-03-27 Thread Dawid Zamirski
This patch implements virDomainScreenshot support for ESX versions newer than 4.0. It adds CreateScreenshot_Task (apiVersion 4.0) and DeleteDatastoreFile_Task (v2.5) then uses those to implement esxDomainScreenshot function. The DeleteDatastoreFile_Task is used to remove the screenshot file that

[libvirt] [PATCH 0/2] ESX: Implement virDomainScreenshot

2014-03-27 Thread Dawid Zamirski
Hello, The following patches implement virDomainScreenshot for the ESX driver. The screenshot VI API call was added in version 4.0, therefore, I had to make changes to esx_vi_generator.py in order to allow VI method calls for versions newer than 2.5. This was done by adding an optional apiVersion

[libvirt] [PATCH] ESX: Add support for virtualHW version 10

2014-03-27 Thread Dawid Zamirski
This follows the same pattern when v8 and v9 were added. I've tested this with my ESX 5.5 and seems to work fine. --- src/vmx/vmx.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/vmx/vmx.c b/src/vmx/vmx.c index 32ddd05..5dc9925 100644 --- a/src/vmx/vmx.c +++

[libvirt] ANNOUNCE: libguestfs 1.26 released

2014-03-27 Thread Richard W.M. Jones
I'm pleased to announce libguestfs 1.26, a library and set of tools for accessing and modifying virtual machine disk images. This release took more than 6 months of work by a considerable number of people, and has many new features (see release notes below). You can get libguestfs 1.26 here:

Re: [libvirt] [PATCH v4 0/5] Expose FSFreeze/FSThaw within the guest as API

2014-03-27 Thread Eric Blake
On 03/27/2014 04:21 PM, Jon Bernard wrote: * Tomoki Sekiyama tomoki.sekiy...@hds.com wrote: Hello, This is patchset v4 to add FSFreeze/FSThaw API for custom disk snapshotting. This patchset works for my tests. Without pausing the guest I am able to quiesce all attached volumes. Does

Re: [libvirt] [PATCH v4 0/5] Expose FSFreeze/FSThaw within the guest as API

2014-03-27 Thread Jon Bernard
* Eric Blake ebl...@redhat.com wrote: On 03/27/2014 04:21 PM, Jon Bernard wrote: * Tomoki Sekiyama tomoki.sekiy...@hds.com wrote: Hello, This is patchset v4 to add FSFreeze/FSThaw API for custom disk snapshotting. This patchset works for my tests. Without pausing the guest I am

[libvirt] [PATCH 4/n] conf: move network disk protocol type to util/

2014-03-27 Thread Eric Blake
Another enum moved to util/, this time the fallout from renaming is not quite as large. * src/conf/domain_conf.h (virDomainDiskProtocol): Move... * src/util/virstoragefile.h (virStorageNetProtocol): ...and rename. * src/conf/domain_conf.c: Update clients. * src/qemu/qemu_command.c: Likewise. *

Re: [libvirt] [PATCH v4 0/5] Expose FSFreeze/FSThaw within the guest as API

2014-03-27 Thread Eric Blake
On 03/27/2014 04:48 PM, Jon Bernard wrote: One thing comes to mind: once volumes are quiesced, qemu-img could be used directly to create the snapshot. In the case of iSCSI-attached volumes, a remote snapshot command could be issued to create a snapshot. Once all have completed the guest

[libvirt] [PATCH tck] Remove /128 from ip6tables output

2014-03-27 Thread Mike Latimer
Due to iptables commit 945353a2 (in iptables v1.4.20 and higher), ip6tables no longer prints out /128. This patch removes /128 from output files, and replaces '/128' in command output with '' to remain compatible with older versions of ip6tables. ---

Re: [libvirt] [PATCH v4 0/5] Expose FSFreeze/FSThaw within the guest as API

2014-03-27 Thread Tomoki Sekiyama
On 3/27/14 18:27 , Eric Blake ebl...@redhat.com wrote: On 03/27/2014 04:21 PM, Jon Bernard wrote: * Tomoki Sekiyama tomoki.sekiy...@hds.com wrote: Hello, This is patchset v4 to add FSFreeze/FSThaw API for custom disk snapshotting. This patchset works for my tests. Without pausing the

Re: [libvirt] [PATCH v4 0/5] Expose FSFreeze/FSThaw within the guest as API

2014-03-27 Thread Eric Blake
On 03/27/2014 05:54 PM, Tomoki Sekiyama wrote: This sounds reasonable for me to add disks parameters. I will try adding them in next version. Then the api will look like: int virDomainFSFreeze(virDomainPtr dom, char** disks, int ndisks, unsigned int flags); and int

[libvirt] [PATCH 5/n] conf: move storage encryption type to util/

2014-03-27 Thread Eric Blake
Encryption keys can be associated with each source file in a backing chain; as such, this file belongs more in util/ where it can be used by virstoragefile.h. * src/conf/storage_encryption_conf.h: Rename... * src/util/virstorageencryption.h: ...to this. * src/conf/storage_encryption_conf.c:

[libvirt] [PATCH 6/n] conf: move source pool type to util/

2014-03-27 Thread Eric Blake
Another struct being moved to util. This one doesn't have as much use yet, thankfully. * src/conf/domain_conf.h (virDomainDiskSourcePoolMode) (virDomainDiskSourcePoolDef): Move... * src/util/virstoragefile.h (virStorageSourcePoolMode) (virStorageSourcePoolDef): ...and rename. *