On 04/14/2014 08:13 PM, John Ferlan wrote:
On 04/14/2014 12:47 PM, Ján Tomko wrote:
The whole hunk would IMHO look simpler as:
bool fail = false;
if (FindNFSPoolSources() 0)
fail = true;
#ifdef GLUSTER_CLI
if (FindGlusterPoolSources() 0)
fail = true;
else
fail =
On Mon, Apr 14, 2014 at 05:50:07PM -0600, Chris Friesen wrote:
Hi,
I've been digging through the libvirt code and something that struck
me was that it appears that when using qemu libvirt will migrate the
instance with autostart disabled, then sit on the source host
periodically polling for
On Mon, Apr 14, 2014 at 04:47:50PM -0400, Stefan Berger wrote:
On 04/08/2014 11:37 AM, Daniel P. Berrange wrote:
Currently we have three places which interact with the firewall
- util/virebtables - simple MAC filtering used by QEMU driver
- util/viriptables - used by network driver
Working for the other corrections but I disegree with these ones:
1. This is an unsigned long long in C, so it must be a long, not
NativeLong here.
2. flags is an unsigned int in C, so it
must be an int in Java
As in java types are signed I'd avoid to allocate the exact same memory, on
the
That is if we would need to read/process these values too instead of just
using them.
2014-04-15 10:36 GMT+02:00 Pasquale Dir phate...@gmail.com:
Working for the other corrections but I disegree with these ones:
1. This is an unsigned long long in C, so it must be a long, not
NativeLong
At Tue, 15 Apr 2014 10:36:02 +0200,
Pasquale Dir wrote:
Working for the other corrections but I disegree with these ones:
1. This is an unsigned long long in C, so it must be a long, not
NativeLong here.
2. flags is an unsigned int in C, so it
must be an int in Java
That is a hard
On Tue, Apr 01, 2014 at 11:43:36AM -0600, Mike Latimer wrote:
Trivial, but there are only 5 tests in 110-static-relabel-yes.t.
---
scripts/selinux/110-static-relabel-yes.t | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
ACK
Regards,
Daniel
--
|: http://berrange.com -o-
On Tue, Apr 01, 2014 at 11:37:39AM -0600, Mike Latimer wrote:
With $tck added to the skip conditional, the entire codeblock has to be
after $tck is defined. Also, $tck-cleanup should be added to the skip
conditions.
---
scripts/nwfilter/300-vsitype.t | 18 ++
1 file
On Mon, Apr 14, 2014 at 16:54:20 -0600, Eric Blake wrote:
Still an RFC, since this claims over 400 tests are impacted:
$ git grep 'driver.*type=\(\(.\)[a-zA-Z0-9]*\2\)' tests/*data/ | wc
Most uses of driver are per-disk - they affect the way the hypervisor
exposes storage to the guest,
On Tue, Apr 01, 2014 at 05:24:19PM -0600, Mike Latimer wrote:
Some environments (openSUSE 13.1) can report the network is unreachable during
this test. Trap that condition as well.
---
scripts/nwfilter/210-no-mac-spoofing.t | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
ACK
On Thu, 10 Apr 2014 15:53:57 -0600
Eric Blake ebl...@redhat.com wrote:
On 04/10/2014 02:52 PM, Natanael Copa wrote:
I suppose we could use helper function to make it more readable:
int virReaddir(DIR *dirp, struct dirent **ent)
{
errno = 0;
*ent = readdir(dirp);
if
On Tue, Apr 01, 2014 at 05:24:33PM -0600, Mike Latimer wrote:
For environments not using a /24 netmask, this test can end up in a hung
state. This patch reads the netmask from the nic and uses it later when
ip addresses are changed and restored.
---
scripts/nwfilter/220-no-ip-spoofing.t |
On Wed, Apr 09, 2014 at 03:12:47PM -0600, Mike Latimer wrote:
The 202-numa-set-parameters.t test sets NUMA_NODESET using AFFECT_LIVE on a
running domain, destroys and starts the domain, then verifies the NUMA_NODESET
setting. As AFFECT_LIVE does not write the setting to the domain xml file,
On Tue, Apr 15, 2014 at 11:27:12AM +0200, Natanael Copa wrote:
On Thu, 10 Apr 2014 15:53:57 -0600
Eric Blake ebl...@redhat.com wrote:
On 04/10/2014 02:52 PM, Natanael Copa wrote:
I suppose we could use helper function to make it more readable:
int virReaddir(DIR *dirp, struct
The gnulib's physmem_total will as a fallback report 64MB as total
memory if sysconf(_SC_PHYS_PAGES) is unimplemented on linux. This makes
it impossible to detect if physmem_total works or not, so we try first
the linux only sysinfo(2) before falling back to gnulibs physmem_total.
This makes the
On Tue, Apr 15, 2014 at 11:31:23AM +0200, Natanael Copa wrote:
The gnulib's physmem_total will as a fallback report 64MB as total
memory if sysconf(_SC_PHYS_PAGES) is unimplemented on linux. This makes
it impossible to detect if physmem_total works or not, so we try first
the linux only
Hi All,
Greetings!!!
We are using KVM hypervisor driver for running OpenStack IaaS. Couple of months
back we have reported one security issue [1] in OS.
Basically we want to limit on the number of vnc client connections that can be
opened by users for a given VM.
From libvirt 1.0.6 version
From: Pasquale Di Rienzo phate...@gmail.com
-Added the getNodeCpuStat binding to Libvirt class
-Added virNodeCPUStats and CPUStat classes to support this binding
-Added the method getCPUStats to Connect class
---
AUTHORS| 1 +
From: Pasquale Di Rienzo phate...@gmail.com
-fixed some bindings
-reworked the CPUStat class introducing a CPUStats class which
encaplulates an HashMap and is more user friendly.
-added a convenience method Connection.getOverallStats() for retrieving
overall stats, instead of passing -1 as cpu
Hi all,
Current virsh migrate command require specfying migration URI with
command option.
1) If user specifies --migrateuri on virsh migrate command, then the
command transfers the data to specified host.
2) If --migrateuri is not specified, the command transfers the data to host
whose name is
Current virsh migrate command require specfying migration URI with
command option.
Here is current step.
1) If user specifies --migrateuri on virsh migrate command, then the command
transfers the data to specified host.
2) If --migrateuri is not specified, the command transfers the data to
Currently, function virConnectGetConfigFile() is in src/libvirt.c,
but this function is to manipulate configration file, so we move
it to virconf.c could make it more generic.
Signed-off-by: Chen Fan chen.fan.f...@cn.fujitsu.com
---
src/libvirt.c| 54
On Tue, Apr 15, 2014 at 06:31:09PM +0800, Chen Fan wrote:
Current virsh migrate command require specfying migration URI with
command option.
Here is current step.
1) If user specifies --migrateuri on virsh migrate command, then the command
transfers the data to specified host.
2) If
On Sat, Apr 12, 2014 at 08:49:50PM -0600, Eric Blake wrote:
On 03/12/2014 02:21 PM, Eric Blake wrote:
tl;dr:
I am working on a series of patches to expose backing chain information
in domain XML. Comments are welcome, to make sure my XML design is on
the right track.
A backing
On Tue, 15 Apr 2014 10:37:40 +0100
Daniel P. Berrange berra...@redhat.com wrote:
On Tue, Apr 15, 2014 at 11:31:23AM +0200, Natanael Copa wrote:
The gnulib's physmem_total will as a fallback report 64MB as total
memory if sysconf(_SC_PHYS_PAGES) is unimplemented on linux. This makes
it
On Tue, Apr 15, 2014 at 01:26:27PM +0200, Natanael Copa wrote:
On Tue, 15 Apr 2014 10:37:40 +0100
Daniel P. Berrange berra...@redhat.com wrote:
On Tue, Apr 15, 2014 at 11:31:23AM +0200, Natanael Copa wrote:
The gnulib's physmem_total will as a fallback report 64MB as total
memory if
On 04/15/2014 04:29 AM, Daniel P. Berrange wrote:
On Mon, Apr 14, 2014 at 04:47:50PM -0400, Stefan Berger wrote:
On 04/08/2014 11:37 AM, Daniel P. Berrange wrote:
Currently we have three places which interact with the firewall
- util/virebtables - simple MAC filtering used by QEMU driver
On Tue, Apr 15, 2014 at 07:40:41AM -0400, Stefan Berger wrote:
On 04/15/2014 04:29 AM, Daniel P. Berrange wrote:
On Mon, Apr 14, 2014 at 04:47:50PM -0400, Stefan Berger wrote:
On 04/08/2014 11:37 AM, Daniel P. Berrange wrote:
Currently we have three places which interact with the firewall
On Mon, Apr 14, 2014 at 16:54:12 -0600, Eric Blake wrote:
In general, we try to make virt-xml-validate tolerant of input
elements in any order when possible. However, as written, the
RNG grammar did not permit source unless there was an explicit
type= attribute (even though the C code manages
On Mon, Apr 14, 2014 at 16:54:14 -0600, Eric Blake wrote:
Domain snapshots should only permit an external snapshot into
a storage format that permits a backing chain, since the new
snapshot file necessarily must be backed by the existing file.
The C code for the qemu driver is a little bit
On Mon, Apr 14, 2014 at 16:54:13 -0600, Eric Blake wrote:
We had incomplete RelaxNG support for storage formats listed
in virstoragefile.h: commit 027bf2e added 'vdi' but forgot
to update the volume and domain xml lists; the volume
list was also missing 'fat' and 'vhd'. Maintaining two lists
On 04/10/2014 09:19 AM, Laine Stump wrote:
This directory should be created when the network driver is first
started up, not just when a dhcp daemon is run. This hasn't posed a
problem in the past, because the directory has always been
pre-existing.
---
src/network/bridge_driver.c | 13
On 04/10/2014 09:19 AM, Laine Stump wrote:
For some reason these have been stored in /var/lib, although other
drivers store their state files in /var/run.
It's much nicer to store them in /var/run because they are
automatically cleared out when the system reboots. This can be a
useful way
On 04/10/2014 09:19 AM, Laine Stump wrote:
This eliminates problems with upgrading from older libvirt that stores
network status in /var/lib/libvirt/network to newer libvirt that
stores it in /var/run/libvirt/network, by also reading any status
files from the old location, saving them to the
On 04/10/2014 09:19 AM, Laine Stump wrote:
libvirt attempts to determine at startup time which networks are
already active, and set their active flags. Previously it has done
this by assuming that all networks are inactive, then setting the flag
if the network has a bridge device associated
On 04/10/2014 09:19 AM, Laine Stump wrote:
The check for a network being active during interface attach was being
done individually in several places (by both the lxc driver and the
qemu driver), but those places were too specific, leading to it *not*
being checked when allocating a
Commit id '18642d10' caused a virt-test regression for NFS backend
storage error path checks when running the command:
'virsh find-storage-pool-sources-as netfs Unknown '
when the host did not have Gluster installed. Prior to the commit,
the test would fail with the error:
error:
On 04/15/2014 03:26 PM, John Ferlan wrote:
On 04/10/2014 09:19 AM, Laine Stump wrote:
For some reason these have been stored in /var/lib, although other
drivers store their state files in /var/run.
It's much nicer to store them in /var/run because they are
automatically cleared out when the
On 04/15/2014 07:42 AM, Daniel P. Berrange wrote:
On Tue, Apr 15, 2014 at 07:40:41AM -0400, Stefan Berger wrote:
On 04/15/2014 04:29 AM, Daniel P. Berrange wrote:
On Mon, Apr 14, 2014 at 04:47:50PM -0400, Stefan Berger wrote:
On 04/08/2014 11:37 AM, Daniel P. Berrange wrote:
Currently we
On 04/08/2014 11:37 AM, Daniel P. Berrange wrote:
+bool virNWFilterRuleIsProtocolEthernet(virNWFilterRuleDefPtr rule)
+{
+if (rule-prtclType = VIR_NWFILTER_RULE_PROTOCOL_NONE
+rule-prtclType = VIR_NWFILTER_RULE_PROTOCOL_IPV6)
+return true;
+return false;
+}
I get a
On Tue, Apr 15, 2014 at 10:04:01AM -0400, Stefan Berger wrote:
On 04/15/2014 07:42 AM, Daniel P. Berrange wrote:
On Tue, Apr 15, 2014 at 07:40:41AM -0400, Stefan Berger wrote:
On 04/15/2014 04:29 AM, Daniel P. Berrange wrote:
On Mon, Apr 14, 2014 at 04:47:50PM -0400, Stefan Berger wrote:
On
On Tue, Apr 15, 2014 at 10:06:22AM -0400, Stefan Berger wrote:
On 04/08/2014 11:37 AM, Daniel P. Berrange wrote:
+bool virNWFilterRuleIsProtocolEthernet(virNWFilterRuleDefPtr rule)
+{
+if (rule-prtclType = VIR_NWFILTER_RULE_PROTOCOL_NONE
+rule-prtclType =
On 04/15/2014 03:27 PM, John Ferlan wrote:
On 04/10/2014 09:19 AM, Laine Stump wrote:
This eliminates problems with upgrading from older libvirt that stores
network status in /var/lib/libvirt/network to newer libvirt that
stores it in /var/run/libvirt/network, by also reading any status
On Tue, Apr 15, 2014 at 05:31:17PM +0300, Laine Stump wrote:
On 04/15/2014 03:27 PM, John Ferlan wrote:
On 04/10/2014 09:19 AM, Laine Stump wrote:
This eliminates problems with upgrading from older libvirt that stores
network status in /var/lib/libvirt/network to newer libvirt that
On Tue, 15 Apr 2014 12:30:47 +0100
Daniel P. Berrange berra...@redhat.com wrote:
On Tue, Apr 15, 2014 at 01:26:27PM +0200, Natanael Copa wrote:
On Tue, 15 Apr 2014 10:37:40 +0100
Daniel P. Berrange berra...@redhat.com wrote:
On Tue, Apr 15, 2014 at 11:31:23AM +0200, Natanael Copa
On 04/15/2014 02:28 AM, Daniel P. Berrange wrote:
On Mon, Apr 14, 2014 at 05:50:07PM -0600, Chris Friesen wrote:
Hi,
I've been digging through the libvirt code and something that struck
me was that it appears that when using qemu libvirt will migrate the
instance with autostart disabled, then
On 04/15/2014 10:31 AM, Laine Stump wrote:
On 04/15/2014 03:27 PM, John Ferlan wrote:
On 04/10/2014 09:19 AM, Laine Stump wrote:
This eliminates problems with upgrading from older libvirt that stores
network status in /var/lib/libvirt/network to newer libvirt that
stores it in
On 04/15/2014 10:06 AM, Daniel P. Berrange wrote:
On Tue, Apr 15, 2014 at 10:04:01AM -0400, Stefan Berger wrote:
On 04/15/2014 07:42 AM, Daniel P. Berrange wrote:
On Tue, Apr 15, 2014 at 07:40:41AM -0400, Stefan Berger wrote:
On 04/15/2014 04:29 AM, Daniel P. Berrange wrote:
On Mon, Apr 14,
On Tue, Apr 15, 2014 at 09:09:55AM -0600, Chris Friesen wrote:
On 04/15/2014 02:28 AM, Daniel P. Berrange wrote:
On Mon, Apr 14, 2014 at 05:50:07PM -0600, Chris Friesen wrote:
Hi,
I've been digging through the libvirt code and something that struck
me was that it appears that when using
On 04/15/2014 10:30 AM, Daniel P. Berrange wrote:
On Tue, Apr 15, 2014 at 10:06:22AM -0400, Stefan Berger wrote:
On 04/08/2014 11:37 AM, Daniel P. Berrange wrote:
+bool virNWFilterRuleIsProtocolEthernet(virNWFilterRuleDefPtr rule)
+{
+if (rule-prtclType = VIR_NWFILTER_RULE_PROTOCOL_NONE
+
On 04/08/2014 11:38 AM, Daniel P. Berrange wrote:
Convert the nwfilter ebiptablesAllTeardown method to use the
virFirewall object APIs instead of creating shell scripts
using virBuffer APIs. This provides a performance improvement
through allowing direct use of firewalld dbus APIs and will
On 04/08/2014 11:38 AM, Daniel P. Berrange wrote:
The nwfilter ebiptables driver will build up commands to run in
two phases. The first phase contains all of the command, except
for the '-A' part. Instead it has a '%c' placeholder, along with
a '%s' placeholder for a position arg. The second
Eric,
I changed the enum structures to typedef structures.
Specially the structures from util/ and conf/ dirs
that have a big number of enum structures.
To keep a stable release, I didn't change the attributes of the structs.
Most of them still keep the old type: 'int type; /* enum virName */'
On Mon, Apr 14, 2014 at 16:54:15 -0600, Eric Blake wrote:
This patch is my first experience playing with nested grammars,
as documented in http://relaxng.org/tutorial-20011203.html#IDA3PZR.
I plan on doing more overrides in order to make the RelaxNG
grammar mirror the C code refactoring into a
On 04/08/2014 11:38 AM, Daniel P. Berrange wrote:
The network and nwfilter drivers both have a need to update
firewall rules. The currently share no code for interacting
with iptables / firewalld. The nwfilter driver is fairly
tied to the concept of creating shell scripts to execute
which makes
On Mon, Apr 14, 2014 at 16:54:16 -0600, Eric Blake wrote:
Disk snapshots use a subset of disk sources (no directory or
pool support yet, and while domain disks support a startupPolicy,
it doesn't make sense for snapshots). This patch lets the two
RelaxNG grammars share a bit more code, as
On 04/08/2014 11:38 AM, Daniel P. Berrange wrote:
Update the iptables methods so that instead of directly
executing iptables commands, they populate rules in an
instance of virFirewallPtr. The bridge driver can thus
construct the ruleset and then invoke it in one operation
having rollback
On 04/08/2014 11:38 AM, Daniel P. Berrange wrote:
The networkCheckRouteCollision, networkAddFirewallRules and
networkRemoveFirewallRules APIs all take a virNetworkObjPtr
instance, but only ever access the 'def' member. It thus
simplifies testing if the APIs are changed to just take a
On Tue, Apr 15, 2014 at 05:15:02PM -0400, Stefan Berger wrote:
On 04/08/2014 11:38 AM, Daniel P. Berrange wrote:
The network and nwfilter drivers both have a need to update
firewall rules. The currently share no code for interacting
with iptables / firewalld. The nwfilter driver is fairly
On 04/08/2014 11:38 AM, Daniel P. Berrange wrote:
Using the virCommand dry run capability, capture iptables rules
created by various network XML documents.
Signed-off-by: Daniel P. Berrange berra...@redhat.com
---
Great. I did not check the individual iptables rules whether they are
correct
On 04/08/2014 11:38 AM, Daniel P. Berrange wrote:
Convert the virebtables.{c,h} files to use the new virFirewall
APIs for changing ebtables rules.
Signed-off-by: Daniel P. Berrange berra...@redhat.com
/**
* ebtablesContextNew:
*
@@ -216,12 +89,30 @@
https://bugzilla.redhat.com/show_bug.cgi?id=789766
This patch addresses a possible misperception that libvirt is hung
during pool startup/refresh as well as virt-manager startup as it
needs to start/refresh storage pools found.
The problem is that the 'udevadm settle' command will wait for a
Hello everyone,
Thanks for libvirt. I did see on the libvirt page that hyper-v 2008 is
supported (which it does). So I tried running it on Hyper-v 2012 r2 but
virsh fails to connect by an error that says
*error: internal error: SOAP fault during enumeration: code 's:Sender',
subcode
Update,
I tried adding root\virtualization\*v2 *to the namespace in libvirt source
code for hyperv. I ran some tests and it seems to work. I get the same
functionality (supported vs non-supported drivers) as hyper-v 2008.
Do you guys want me to submit the patch? If yes, what all do I need to
Hi Daniel,
On Tue, 2014-04-15 at 12:04 +0100, Daniel P. Berrange wrote:
On Tue, Apr 15, 2014 at 06:31:09PM +0800, Chen Fan wrote:
Current virsh migrate command require specfying migration URI with
command option.
Here is current step.
1) If user specifies --migrateuri on virsh
65 matches
Mail list logo
