Re: [libvirt] [PATCH] Add capability to example AppArmor profile

2014-05-29 Thread Jamie Strandboge
On 05/29/2014 01:03 AM, Steven Leung wrote: I encountered an AppArmor denial in Ubuntu 14.04. I had filed a bug here https://bugs.launchpad.net/ubuntu/+source/libvirt/+bug/1324251 ... + # to create and modify with 9p shares + capability fowner, + capability fsetid, I commented on this

Re: [libvirt] [PATCH v5] bhyve: implement PCI address allocation

2014-05-29 Thread Roman Bogorodskiy
Ján Tomko wrote: One more thing that bothers me: after this change user needs to re-define a domain, otherwise domain will have no addresses and will fail to start. Could/should it be handled somehow? Yes, it would be nice not to break upgrades :) In QEMU driver, this is done by

[libvirt] [PATCH 00/12] Couple of host info getting improvements

2014-05-29 Thread Michal Privoznik
The rationale is to fill in the gaps as described here: https://wiki.openstack.org/wiki/VirtDriverGuestCPUMemoryPlacement Note that these are targeted for 1.2.6. Michal Privoznik (12): Introduce virNodeHugeTLB Initial virsh exposure of virNodeHugeTLB nodeinfo: Implement nodeHugeTLB

[libvirt] [PATCH 02/12] Initial virsh exposure of virNodeHugeTLB

2014-05-29 Thread Michal Privoznik
The API is exposed as 'hugepage' command. Signed-off-by: Michal Privoznik mpriv...@redhat.com --- tools/virsh-host.c | 62 ++ tools/virsh.pod| 7 ++ 2 files changed, 69 insertions(+) diff --git a/tools/virsh-host.c

[libvirt] [PATCH 01/12] Introduce virNodeHugeTLB

2014-05-29 Thread Michal Privoznik
The API queries huge page info in the host and reports it back to the caller. This may be handy for management application to decide whether to run a domain with huge pages enabled or not. Signed-off-by: Michal Privoznik mpriv...@redhat.com --- daemon/remote.c | 54

[libvirt] [PATCH 05/12] nodedev: Introduce pci-express/ to PCI devices

2014-05-29 Thread Michal Privoznik
This new element is there to represent PCI-Express capabilities of a PCI devices, like link speed, number of lanes, etc. Signed-off-by: Michal Privoznik mpriv...@redhat.com --- docs/formatnode.html.in| 19 docs/schemas/nodedev.rng | 26

[libvirt] [PATCH 09/12] virhostdev: Move IOMMU and VFIO funcs from qemu

2014-05-29 Thread Michal Privoznik
The functions in question are qemuHostdevHostSupportsPassthroughLegacy and qemuHostdevHostSupportsPassthroughVFIO. At the same time the functions are renamed to match 'vir' prefix instead of 'qemu' one. Signed-off-by: Michal Privoznik mpriv...@redhat.com --- src/libvirt_private.syms | 2 ++

[libvirt] [PATCH 11/12] Expose IOMMU and VFIO capabilities from virCaps

2014-05-29 Thread Michal Privoznik
This piece of information may be useful for management application to decide if a domain with a device passthrough can be started on given host or not. Signed-off-by: Michal Privoznik mpriv...@redhat.com --- Notes: I'm not very happy with the element names, but they're the best I could

[libvirt] [PATCH 04/12] virpci: Introduce virPCIDeviceIsPCIExpress and friends

2014-05-29 Thread Michal Privoznik
These functions will handle PCIe devices and their link capabilities to query some info about it. Signed-off-by: Michal Privoznik mpriv...@redhat.com --- src/libvirt_private.syms | 3 ++ src/util/virpci.c| 81 +++- src/util/virpci.h|

[libvirt] [PATCH 07/12] interface_backend_udev: Implement link speed state

2014-05-29 Thread Michal Privoznik
In previous commit the interface XML is prepared for exporting information on NIC link speed and state. This commit implement actual logic for getting such info and writing it into XML. Signed-off-by: Michal Privoznik mpriv...@redhat.com --- src/interface/interface_backend_udev.c | 19

[libvirt] [PATCH 08/12] interface_backend_netcf: Implement link speed state

2014-05-29 Thread Michal Privoznik
While the previous commit was pretty straightforward, things are different with netcf as it doesn't exposed the bits we need yet. However, we can work around it by fetching the info we need from SYSFS. Signed-off-by: Michal Privoznik mpriv...@redhat.com ---

[libvirt] [PATCH 06/12] virInterface: Expose link state speed

2014-05-29 Thread Michal Privoznik
Currently it is not possible to determine the speed of an interface and whether a link is actually detected from the API. Orchestrating platforms want to be able to determine when the link has failed and where multiple speeds may be available which one the interface is actually connected at. This

[libvirt] [PATCH 12/12] nodedev: Export NUMA node locality for PCI devices

2014-05-29 Thread Michal Privoznik
A PCI device can be associated with a specific NUMA node. Later, when a guest is pinned to one NUMA node the PCI device can be assigned on different NUMA node. This makes DMA transfers travel across nodes and thus results in suboptimal performance. We should expose the NUMA node locality for PCI

[libvirt] [PATCH 10/12] virCaps: Introduce IOMMU and VFIO capabilities

2014-05-29 Thread Michal Privoznik
There's no need to check for these two host capabilities on each device attach or detach. It's sufficient to check them on the daemon start and then just query them from virCaps when needed. Moreover, this way it's fairly simple to expose them in capabilities XML. Signed-off-by: Michal Privoznik

[libvirt] [PATCH 03/12] nodeinfo: Implement nodeHugeTLB

2014-05-29 Thread Michal Privoznik
At the same time, in the qemu driver this is exposed as qemuNodeHugeTLB. Signed-off-by: Michal Privoznik mpriv...@redhat.com --- include/libvirt/libvirt.h.in | 20 + src/libvirt.c| 13 +++- src/libvirt_private.syms | 1 + src/nodeinfo.c | 177

[libvirt] [libvirt-python][PATCH] Implement virNodeHugeTLB

2014-05-29 Thread Michal Privoznik
Signed-off-by: Michal Privoznik mpriv...@redhat.com --- generator.py | 2 ++ libvirt-override-virConnect.py | 7 libvirt-override.c | 78 ++ 3 files changed, 87 insertions(+) diff --git a/generator.py b/generator.py

Re: [libvirt] [PATCHv2] util: fix virTimeLocalOffsetFromUTC DST processing

2014-05-29 Thread Laine Stump
On 05/28/2014 05:51 PM, Eric Blake wrote: On 05/28/2014 04:46 AM, Laine Stump wrote: The original version of virTimeLocalOffsetFromUTC() would fail for certain times of the day if daylight savings time was active. This could most easily be seen by uncommenting the TEST_LOCALOFFSET() cases

[libvirt] [PATCH 0/2] qemu: Fix few snapshot issues

2014-05-29 Thread Peter Krempa
Peter Krempa (2): qemu: snapshot: Reject internal active snapshot without memory state qemu: snapshot: Improve detection of mixed snapshots src/qemu/qemu_driver.c | 13 - 1 file changed, 12 insertions(+), 1 deletion(-) -- 1.9.3 -- libvir-list mailing list

[libvirt] [PATCH 2/2] qemu: snapshot: Improve detection of mixed snapshots

2014-05-29 Thread Peter Krempa
Currently we don't support mixed (external + internal) snapshots. The code detecting the snapshot type didn't make sure that the memory image was consistent with the snapshot type leading into strange error message: $ virsh snapshot-create-as --domain VM --diskspec vda,snapshot=internal

[libvirt] [PATCH 1/2] qemu: snapshot: Reject internal active snapshot without memory state

2014-05-29 Thread Peter Krempa
A internal snapshot of a active VM with the memory snapshot disabled explicitly would actually still take the memory snapshot. Reject it explicitly. Before: $ virsh snapshot-create-as --domain VM --diskspec vda,snapshot=internal --memspec snapshot=no Domain snapshot 1401353155 created After:

[libvirt] [PATCH] Don't use AI_ADDRCONFIG when binding to wildcard addresses

2014-05-29 Thread Ján Tomko
https://bugzilla.redhat.com/show_bug.cgi?id=1098659 With parallel boot, network addresses might not yet be assigned [1], but binding to wildcard addresses should work. For non-wildcard addresses, ADDRCONFIG is still used. Document this in libvirtd.conf. [1]

Re: [libvirt] GSoC student introduction and work plan

2014-05-29 Thread Michal Privoznik
On 23.05.2014 06:03, Taowei Luo wrote: Hi, everyone, My name is Taowei Luo. I'm one of the students working for GSoC this summer. My project is rewriting the vbox driver. The plan sounds good to me. If you write some patches please make sure you won't end up with one huge patch that does all

[libvirt] [libvirt-glib] [PATCH] GVirDomainSnapshot: add gvir_domain_snapshot_delete

2014-05-29 Thread Timm Bäder
--- libvirt-gobject/libvirt-gobject-domain-snapshot.c | 21 + libvirt-gobject/libvirt-gobject-domain-snapshot.h | 3 +++ libvirt-gobject/libvirt-gobject.sym | 5 + 3 files changed, 29 insertions(+) diff --git

Re: [libvirt] [PATCH V2] virsh: forbid negative vcpu argument to vcpupin.

2014-05-29 Thread Peter Krempa
On 05/29/14 05:34, Jincheng Miao wrote: vcpupin will allow argument --vcpu as a signed number, and pass it to virDomainPinVcpu directlly without checking if this value is positive(valid). virsh vcpupin r7 -1 0 error: numerical overflow: input too large: 4294967295 This message is

[libvirt] [PATCHv3 0/2] virsh: Fix negative value parsing in vcpuinfo

2014-05-29 Thread Peter Krempa
Jincheng Miao (1): virsh: forbid negative vcpu argument to vcpupin Peter Krempa (1): virsh: Reject negative numbers in vshCommandOptUInt tests/vcpupin| 29 - tools/virsh-domain.c | 35 ++- tools/virsh.c| 4 ++-- 3

[libvirt] [PATCHv3 1/2] virsh: Reject negative numbers in vshCommandOptUInt

2014-05-29 Thread Peter Krempa
Use virStrToLong_uip instead of virStrToLong_ui to reject negative numbers in the helper. None of the callers expects the wraparound feature for negative numbers. Also be explicit about the new semantics in the function docs. --- tools/virsh.c | 4 ++-- 1 file changed, 2 insertions(+), 2

[libvirt] [PATCHv3 2/2] virsh: forbid negative vcpu argument to vcpupin

2014-05-29 Thread Peter Krempa
From: Jincheng Miao jm...@redhat.com The vcpupin command allowed specifying a negative number for the --vcpu argument. This would the overflow when the underlying virDomainPinVcpu API was called. $ virsh vcpupin r7 -1 0 error: numerical overflow: input too large: 4294967295 Switch the vCPU

[libvirt] libvirt: Xen Driver error : Domain not found: xenGetDomainDefForName

2014-05-29 Thread deepanshus
Hi, I have successfully installed xen 3.11 kernel but when I am running the vm I am getting this error: libvirt: Xen Driver error : Domain not found: xenGetDomainDefForName I am sending the xend log file as well error file as an attachment. Thanks And Regards, Deepanshu Saxena

Re: [libvirt] [PATCH 1/2] qemu: snapshot: Reject internal active snapshot without memory state

2014-05-29 Thread Eric Blake
On 05/29/2014 03:07 AM, Peter Krempa wrote: A internal snapshot of a active VM with the memory snapshot disabled explicitly would actually still take the memory snapshot. Reject it explicitly. Before: $ virsh snapshot-create-as --domain VM --diskspec vda,snapshot=internal --memspec

Re: [libvirt] [PATCH 2/2] qemu: snapshot: Improve detection of mixed snapshots

2014-05-29 Thread Eric Blake
On 05/29/2014 03:08 AM, Peter Krempa wrote: Currently we don't support mixed (external + internal) snapshots. The code detecting the snapshot type didn't make sure that the memory image was consistent with the snapshot type leading into strange error message: $ virsh snapshot-create-as

Re: [libvirt] libvirt: Xen Driver error : Domain not found: xenGetDomainDefForName

2014-05-29 Thread Eric Blake
[meta-comment] On 05/29/2014 07:17 AM, deepanshus wrote: Hi, I have successfully installed xen 3.11 kernel but when I am running the vm I am getting this error: libvirt: Xen Driver error : Domain not found: xenGetDomainDefForName Unfortunately, I'm not familiar enough with xen to

[libvirt] [PATCH v2] qemu: Properly label FDs when restoring domain with static label

2014-05-29 Thread Shivaprasad G Bhat
The restore of a saved image file fails when the selinux context is static. The libvirt has to set the conext of save image file handle to that of the guest before handing off the FD to qemu. Signed-off-by: Shivaprasad G Bhat shivaprasadb...@gmail.com --- src/qemu/qemu_process.c |4 ++-- 1

Re: [libvirt] [PATCH] Don't use AI_ADDRCONFIG when binding to wildcard addresses

2014-05-29 Thread Eric Blake
On 05/29/2014 03:32 AM, Ján Tomko wrote: https://bugzilla.redhat.com/show_bug.cgi?id=1098659 With parallel boot, network addresses might not yet be assigned [1], but binding to wildcard addresses should work. For non-wildcard addresses, ADDRCONFIG is still used. Document this in

[libvirt] [PATCH] util: storage: Fix crash of libvirtd on network backed guest block-pull

2014-05-29 Thread Peter Krempa
For guests backed by gluster volumes (or other network storage) we don't fill the backing chain (see qemuDomainDetermineDiskChain). This leaves the relPath field of the top image NULL. This causes a crash in virStorageFileChainLookup() when looking up a backing element for such a disk. Since I'm

Re: [libvirt] [PATCH V2] virsh: forbid negative vcpu argument to vcpupin.

2014-05-29 Thread Peter Krempa
On 05/29/14 16:51, Eric Blake wrote: On 05/29/2014 05:47 AM, Peter Krempa wrote: Still not quite right ... vshCommandOptUInt currently wraps negative numbers to their 2's complement and stores them in the uint. I recently tweaked virstring.c to provide virStrToLong_uip and friends for

Re: [libvirt] [PATCH V2] virsh: forbid negative vcpu argument to vcpupin.

2014-05-29 Thread Eric Blake
On 05/29/2014 05:47 AM, Peter Krempa wrote: Still not quite right ... vshCommandOptUInt currently wraps negative numbers to their 2's complement and stores them in the uint. I recently tweaked virstring.c to provide virStrToLong_uip and friends for rejecting negative input when parsing

Re: [libvirt] [PATCH] util: storage: Fix crash of libvirtd on network backed guest block-pull

2014-05-29 Thread Eric Blake
On 05/29/2014 08:52 AM, Peter Krempa wrote: For guests backed by gluster volumes (or other network storage) we don't fill the backing chain (see qemuDomainDetermineDiskChain). This leaves the relPath field of the top image NULL. This causes a crash in virStorageFileChainLookup() when looking

Re: [libvirt] [PATCH] util: storage: Fix crash of libvirtd on network backed guest block-pull

2014-05-29 Thread Peter Krempa
On 05/29/14 16:58, Eric Blake wrote: On 05/29/2014 08:52 AM, Peter Krempa wrote: For guests backed by gluster volumes (or other network storage) we don't fill the backing chain (see qemuDomainDetermineDiskChain). This leaves the relPath field of the top image NULL. This causes a crash in

Re: [libvirt] [PATCH 2/2] qemu: snapshot: Improve detection of mixed snapshots

2014-05-29 Thread Peter Krempa
On 05/29/14 16:38, Eric Blake wrote: On 05/29/2014 03:08 AM, Peter Krempa wrote: Currently we don't support mixed (external + internal) snapshots. The code detecting the snapshot type didn't make sure that the memory image was consistent with the snapshot type leading into strange error

Re: [libvirt] [PATCH 1/2] qemu: snapshot: Reject internal active snapshot without memory state

2014-05-29 Thread Peter Krempa
On 05/29/14 16:36, Eric Blake wrote: On 05/29/2014 03:07 AM, Peter Krempa wrote: A internal snapshot of a active VM with the memory snapshot disabled explicitly would actually still take the memory snapshot. Reject it explicitly. Before: $ virsh snapshot-create-as --domain VM --diskspec

Re: [libvirt] [PATCHv3 1/2] virsh: Reject negative numbers in vshCommandOptUInt

2014-05-29 Thread Eric Blake
On 05/29/2014 05:54 AM, Peter Krempa wrote: Use virStrToLong_uip instead of virStrToLong_ui to reject negative numbers in the helper. None of the callers expects the wraparound feature for negative numbers. I had to audit all callers, and found the following (fortunately the list is fairly

Re: [libvirt] [libvirt-users] Host OS, Storage Info

2014-05-29 Thread Ainsworth, Thomas
Martin, et al, Sorry for the lag in response. So I started playing with the various virsh commands. Awesome. Been doing some reading and I believe I have some things configured not so well. As I stated earlier in the thread, we have all of the VM image files on one RAID5. Very fast machine.

Re: [libvirt] Weekly meeting minutes May 22nd, 2014

2014-05-29 Thread Jim Fehlig
Daniel P. Berrange wrote: Agenda + minutes from 22/05/2014 * Welcome / rollcall * IRC comments from: * eblake * danpb * pkrempa * derRichard * rbogorodskiy * mkletzan * nehaljwani * mprivozn * Next release schedule * Freeze: Mon May 26th *

Re: [libvirt] [Qemu-devel] [PATCHv2 3/4] qemu: fix RTC_CHANGE event for clock offset='variable' basis='utc'/

2014-05-29 Thread Marcelo Tosatti
On Fri, May 23, 2014 at 11:36:56PM +0200, Paolo Bonzini wrote: You can get the current time via the qom-get command, and then follow the same algorithm as QEMU: time_t seconds; if (rtc_date_offset == -1) { if (rtc_utc) { seconds = mktimegm(tm); } else

Re: [libvirt] libvirt: Xen Driver error : Domain not found: xenGetDomainDefForName

2014-05-29 Thread Jim Fehlig
deepanshus wrote: Hi, I have successfully installed xen 3.11 kernel but when I am running the vm I am getting this error: What version of Xen? Your problem appears to be more tools or packaging related, not the kernel. libvirt: Xen Driver error : Domain not found:

Re: [libvirt] [PATCH 2/2] libxl: Fix up VRAM to minimum requirements

2014-05-29 Thread Jim Fehlig
Stefan Bader wrote: This is a bit debatable. On one side it hides configuration errors in a way that makes them hard to spot. On the other side there is at least one issue with (maybe some older versions) virt-manager. Virt-manager sets VRAM directly, not using the default memory setting but

Re: [libvirt] [PATCH 1/2] libxl: Implement basic video device selection

2014-05-29 Thread Jim Fehlig
Hi Stefan, Thanks for the patches, sorry for the delay... Stefan Bader wrote: This started as an investigation into an issue where libvirt (using the libxl driver) and the Xen host, like an old couple, could not agree on who is responsible for selecting the VNC port to use. Things usually

[libvirt] Availability of release candidate 2 of libvirt-1.2.5

2014-05-29 Thread Daniel Veillard
1.2.5-rc2 is now tagged in git and tarball and signed rpms are also available at the usual place: ftp://libvirt.org/libvirt/ Still seems to work with my minimal testing, so if there is no serious issue raised we're probably good for a release over the w.e. or monday morning ! But please

Re: [libvirt] GSoC student introduction and work plan

2014-05-29 Thread Taowei Luo
Thanks, I will keep this in mind when I submit patches. -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list