[libvirt] [PATCH] storage: remove unused 'canonPath' in virStorageFileGetMetadata

2014-08-26 Thread Chen Fan
Signed-off-by: Chen Fan chen.fan.f...@cn.fujitsu.com --- src/storage/storage_driver.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/storage/storage_driver.c b/src/storage/storage_driver.c index 3604613..5ddc23a 100644 --- a/src/storage/storage_driver.c +++

Re: [libvirt] [PATCH v1 1/6] doc: schema: Add documentation for the shmem support

2014-08-26 Thread Martin Kletzander
On Fri, Aug 22, 2014 at 12:47:00PM +0200, Maxime Leroy wrote: This patch documents XML elements used for support of shmem devices. Considering there could be other shared memory related devices, this patch introduces a general device model, called shmem device. Currenly ivshmem is the only

Re: [libvirt] [PATCH 1/2] lib: Introduce API for retrieving bulk domain stats

2014-08-26 Thread Peter Krempa
On 08/26/14 03:45, Li Wei wrote: On 08/26/2014 01:05 AM, Peter Krempa wrote: The motivation for this API is that management layers that use libvirt usually poll for statistics using various split up APIs we currently provide. To get all the necessary stuff, the app needs to issue a lot of

Re: [libvirt] Plan for the next release

2014-08-26 Thread Daniel Veillard
On Mon, Aug 25, 2014 at 02:34:37PM +0200, Peter Krempa wrote: On 08/20/14 13:26, Daniel Veillard wrote: We already have a number of commits in, over 150, I can't freeze next monday but I could do this next Tuesday (the 26) for a planned release around Sep 1st, So unless there is a

Re: [libvirt] [PATCH 1/2] lib: Introduce API for retrieving bulk domain stats

2014-08-26 Thread Peter Krempa
On 08/26/14 05:21, Li Wei wrote: On 08/26/2014 01:05 AM, Peter Krempa wrote: The motivation for this API is that management layers that use libvirt usually poll for statistics using various split up APIs we currently provide. To get all the necessary stuff, the app needs to issue a lot of

Re: [libvirt] [PATCHv2] iotune: setting an invalid value now reports error

2014-08-26 Thread Erik Skultety
Thanks. Erik On 08/25/2014 04:48 PM, Ján Tomko wrote: On 08/25/2014 10:50 AM, Erik Skultety wrote: When trying to set an invalid value into iotune element, standard behavior was to not report any error, rather to reset all affected subelements of the iotune element back to 0 which results in

Re: [libvirt] [PATCH 1/2] lib: Introduce API for retrieving bulk domain stats

2014-08-26 Thread Li Wei
On 08/26/2014 03:46 PM, Peter Krempa wrote: On 08/26/14 05:21, Li Wei wrote: On 08/26/2014 01:05 AM, Peter Krempa wrote: The motivation for this API is that management layers that use libvirt usually poll for statistics using various split up APIs we currently provide. To get all the

[libvirt] [PATCH] blkdeviotune: check for overflow when parsing XML

2014-08-26 Thread Erik Skultety
According to docs/schemas/domaincommon.rng and _virDomainBlockIoTuneInfo all the iotune values are interpreted as unsigned long long, however according to qemu_monitor_json.c, qemu silently truncates numbers larger than LLONG_MAX. There's really not much of a usage for such large numbers anyway

Re: [libvirt] [PATCH 1/2] lib: Introduce API for retrieving bulk domain stats

2014-08-26 Thread Li Wei
On 08/26/2014 03:43 PM, Peter Krempa wrote: On 08/26/14 03:45, Li Wei wrote: On 08/26/2014 01:05 AM, Peter Krempa wrote: The motivation for this API is that management layers that use libvirt usually poll for statistics using various split up APIs we currently provide. To get all the

Re: [libvirt] [PATCH v1 2/6] conf: Parse and format shmem device XML

2014-08-26 Thread Martin Kletzander
On Fri, Aug 22, 2014 at 12:47:01PM +0200, Maxime Leroy wrote: This patch adds configuration support for the shmem device as described in the schema in the previous patch. Signed-off-by: Maxime Leroy maxime.le...@6wind.com --- src/conf/domain_conf.c | 249

Re: [libvirt] [PATCH v1 4/6] qemu: Build command line for ivshmem device

2014-08-26 Thread Martin Kletzander
On Fri, Aug 22, 2014 at 12:47:03PM +0200, Maxime Leroy wrote: This patch implements support for the ivshmem device in QEMU. Example from this xml: shmem name='ivshmem0' model='ivshmem' server path='/tmp/socket-ivshmem0'/ size unit='M'32/size msi vectors='32' ioeventfd='on'/

Re: [libvirt] [PATCH v2] Add new 'kvm' domain feature and ability to hide KVM signature

2014-08-26 Thread Ján Tomko
On 08/25/2014 05:13 PM, Ján Tomko wrote: On 08/21/2014 07:04 PM, Alex Williamson wrote: QEMU 2.1 added support for the kvm=off option to the -cpu command, allowing the KVM hypervisor signature to be hidden from the guest. This enables disabling of some paravirualization features in the guest

Re: [libvirt] [PATCH] storage: remove unused 'canonPath' in virStorageFileGetMetadata

2014-08-26 Thread Ján Tomko
On 08/26/2014 08:11 AM, Chen Fan wrote: Signed-off-by: Chen Fan chen.fan.f...@cn.fujitsu.com --- src/storage/storage_driver.c | 2 -- 1 file changed, 2 deletions(-) Introduced by commit 395171f. I have added the comment to the commit message and pushed the patch. Jan signature.asc

Re: [libvirt] [PATCH v1 5/6] tests: Add tests for ivshmem device handling

2014-08-26 Thread Martin Kletzander
On Fri, Aug 22, 2014 at 12:47:04PM +0200, Maxime Leroy wrote: Add XML parsing and qemu command line tests for the ivshmem device support. Signed-off-by: Maxime Leroy maxime.le...@6wind.com --- tests/qemuxml2argvdata/qemuxml2argv-ivshmem.args | 10 +++

Re: [libvirt] [PATCH v1 2/6] conf: Parse and format shmem device XML

2014-08-26 Thread Wang Rui
On 2014/8/22 18:47, Maxime Leroy wrote: This patch adds configuration support for the shmem device as described in the schema in the previous patch. Signed-off-by: Maxime Leroy maxime.le...@6wind.com --- +static virDomainShmemDefPtr +virDomainShmemDefParseXML(xmlNodePtr node, +

Re: [libvirt] [PATCH v1 4/6] qemu: Build command line for ivshmem device

2014-08-26 Thread Wang Rui
On 2014/8/22 18:47, Maxime Leroy wrote: +static int +qemuBuildIvshmemCommandLine(virCommandPtr cmd, +virDomainDefPtr def, +virDomainShmemDefPtr dev, +virQEMUCapsPtr qemuCaps) +{ +char *devstr; +

Re: [libvirt] [RFC PATCH 0/3] Introduce virDomainOpenGraphicsFD API

2014-08-26 Thread Ján Tomko
On 08/25/2014 08:22 PM, Ján Tomko wrote: Introduce virDomainOpenGraphicsFD which returns a socket fd created by the daemon, unlike virDomainOpenGraphics, where it's created by client. This should be usable by virt-viewer under SELinux, but I was not able to verify that yet. I have now

Re: [libvirt] [PATCH v1 6/6] ivshmem: add start param to server attribute

2014-08-26 Thread Martin Kletzander
[Cc'ing David due to some questions/ideas about the ivshmem server] On Fri, Aug 22, 2014 at 12:47:05PM +0200, Maxime Leroy wrote: With the new start param, we are able to start the ivshmem-server. With this xml: shmem name='ivshmem0' model='ivshmem' server path='/tmp/ivshmem0.sock'

Re: [libvirt] Mentors wanted for Outreach Program for Women October 2014

2014-08-26 Thread Stefan Hajnoczi
On Mon, Aug 25, 2014 at 5:40 PM, Marina Zhurakhinskaya mari...@redhat.com wrote: - Original Message - From: Stefan Hajnoczi stefa...@gmail.com To: Martin Kletzander mklet...@redhat.com Cc: qemu-devel qemu-de...@nongnu.org, libvir-list@redhat.com, kvm k...@vger.kernel.org, Marina

Re: [libvirt] Mentors wanted for Outreach Program for Women October 2014

2014-08-26 Thread Martin Kletzander
On Tue, Aug 26, 2014 at 10:33:27AM +0100, Stefan Hajnoczi wrote: On Mon, Aug 25, 2014 at 5:40 PM, Marina Zhurakhinskaya mari...@redhat.com wrote: - Original Message - From: Stefan Hajnoczi stefa...@gmail.com To: Martin Kletzander mklet...@redhat.com Cc: qemu-devel

Re: [libvirt] [PATCH] blkdeviotune: check for overflow when parsing XML

2014-08-26 Thread Martin Kletzander
On Tue, Aug 26, 2014 at 10:17:22AM +0200, Erik Skultety wrote: According to docs/schemas/domaincommon.rng and _virDomainBlockIoTuneInfo all the iotune values are interpreted as unsigned long long, however according to qemu_monitor_json.c, qemu silently truncates numbers larger than LLONG_MAX.

Re: [libvirt] [PATCH 2/2] remote: Implement bulk domain stats APIs in the remote driver

2014-08-26 Thread Li Wei
On 08/26/2014 01:05 AM, Peter Krempa wrote: Implement the remote driver support for shuffling the domain stats around. --- daemon/remote.c | 91 src/remote/remote_driver.c | 88 ++

Re: [libvirt] [PATCH v1 6/6] ivshmem: add start param to server attribute

2014-08-26 Thread Wang Rui
On 2014/8/22 18:47, Maxime Leroy wrote: +# util/virivshmemserver.h +virStartIvshmemServer; +virStopIvshmemServer; I think function name virIvshmemStartServer is better. So is the stop function. @@ -5120,6 +5121,12 @@ qemuBuildIvshmemCommandLine(virCommandPtr cmd, return

Re: [libvirt] Mentors wanted for Outreach Program for Women October 2014

2014-08-26 Thread Stefan Hajnoczi
On Tue, Aug 26, 2014 at 10:39 AM, Martin Kletzander mklet...@redhat.com wrote: On Tue, Aug 26, 2014 at 10:33:27AM +0100, Stefan Hajnoczi wrote: On Mon, Aug 25, 2014 at 5:40 PM, Marina Zhurakhinskaya mari...@redhat.com wrote: - Original Message - From: Stefan Hajnoczi

Re: [libvirt] Mentors wanted for Outreach Program for Women October 2014

2014-08-26 Thread Martin Kletzander
On Tue, Aug 26, 2014 at 11:27:41AM +0100, Stefan Hajnoczi wrote: On Tue, Aug 26, 2014 at 10:39 AM, Martin Kletzander mklet...@redhat.com wrote: On Tue, Aug 26, 2014 at 10:33:27AM +0100, Stefan Hajnoczi wrote: On Mon, Aug 25, 2014 at 5:40 PM, Marina Zhurakhinskaya mari...@redhat.com wrote:

Re: [libvirt] [PATCH 1/4] domain_conf: Introduce iothreads XML

2014-08-26 Thread John Ferlan
On 08/26/2014 01:03 AM, Martin Kletzander wrote: On Mon, Aug 25, 2014 at 08:38:06PM -0400, John Ferlan wrote: Introduce XML to allowing adding iothreads to the domain. These can be used by virtio-blk-pci devices in order to assign a specific thread to handle the workload for the device. The

Re: [libvirt] [PATCH 2/4] qemu: Add support for iothreads

2014-08-26 Thread John Ferlan
On 08/26/2014 01:03 AM, Martin Kletzander wrote: On Mon, Aug 25, 2014 at 08:38:07PM -0400, John Ferlan wrote: Add a new capability to ensure the iothreads feature exists for the qemu emulator being run - requires the query-iothreads QMP command. Using the domain XML add correspoding command

Re: [libvirt] [PATCH 3/4] domain_conf: Add support for iothreads in disk definition

2014-08-26 Thread John Ferlan
On 08/26/2014 01:03 AM, Martin Kletzander wrote: On Mon, Aug 25, 2014 at 08:38:08PM -0400, John Ferlan wrote: Add a new disk driver attribute iothread to be parsed as the thread number for the disk to use. In order to more easily facilitate the usage and configuration of the iothread, a zero

[libvirt] [PATCH] virsh: fix password auth failed on ssh connection

2014-08-26 Thread Seyeong Kim
When try to connect to another host using virsh with password auth on ssh env, can't put password properly because it's waiting IO from STDIN. This patch check if it's in pts so make that doesn't poll from STDIN. --- tools/virsh-domain.c | 3 +++ tools/virsh.c| 11 +++

[libvirt] [PATCH v2 2/8] blockcopy: split out virsh implementation

2014-08-26 Thread Eric Blake
I'm about to extend the capabilities of blockcopy. Hiding a few common lines of implementation gets in the way of the new required logic, and putting the new logic in the common implementation won't benefit any of the other blockjob operations. Therefore, it is simpler to just do the work

[libvirt] [PATCH v2 0/8] new virDomainBlockCopy API

2014-08-26 Thread Eric Blake
v2: finish the series for local files, address Peter's doc suggestions on patch 1, and make several tweaks to many of the patches to fix issues that I found in testing the final product. Not included - patches to actually target a gluster destination. But those can be delayed until 1.2.9. Eric

[libvirt] [PATCH v2 1/8] blockcopy: virDomainBlockCopy with XML destination, typed params

2014-08-26 Thread Eric Blake
This commit (finally) adds the virDomainBlockCopy API, with the intent that it will provide more power to the existing 'virsh blockcopy' command. 'virsh blockcopy' was first added in Apr 2012 (v0.9.12), which corresponds to the upstream qemu 1.2 timeframe. It was done as a hack on top of the

[libvirt] [PATCH v2 8/8] blockcopy: add qemu implementation of new tunables

2014-08-26 Thread Eric Blake
Upstream qemu 1.4 added some drive-mirror tunables not present when it was first introduced in 1.3. Management apps may want to set these in some cases (for example, without tuning granularity down to sector size, a copy may end up occupying more bytes than the original because an entire cluster

[libvirt] [PATCH v2 6/8] blockcopy: add a way to parse disk source

2014-08-26 Thread Eric Blake
The new blockcopy API wants to reuse only a subset of the disk hotplug parser - namely, we only care about the embedded virStorageSourcePtr inside a disk XML. Strange as it may seem, it was easier to just parse an entire disk definition, then throw away everything but the embedded source, than it

[libvirt] [PATCH v2 7/8] blockcopy: add qemu implementation of new API

2014-08-26 Thread Eric Blake
The hard part of managing the disk copy is already coded; all this had to do was convert the XML and virTypedParameters into the internal representation. With this patch, all blockcopy operations that used the old API should also work via the new API. Additional extensions, such as supporting

[libvirt] [PATCH v2 5/8] blockcopy: tweak how rebase calls into copy

2014-08-26 Thread Eric Blake
In order to implement the new virDomainBlockCopy, the existing block copy internal implementation needs to be adjusted. The new function will parse XML into a storage source, and parse typed parameters into integers, then call into the same common backend. For now, it's easier to keep the same

[libvirt] [PATCH v2 4/8] blockcopy: remote implementation for new API

2014-08-26 Thread Eric Blake
Fairly straightforward. * src/remote/remote_protocol.x (remote_domain_block_copy_args): New struct. (REMOTE_PROC_DOMAIN_BLOCK_COPY): New RPC. * src/remote/remote_driver.c (remote_driver): Wire it up. * src/remote_protocol-structs: Regenerate. Signed-off-by: Eric Blake ebl...@redhat.com ---

[libvirt] [PATCH v2 3/8] blockcopy: expose new API in virsh

2014-08-26 Thread Eric Blake
Expose the new power of virDomainBlockCopy through virsh. Continue to use the older API where possible, for maximum compatibility. The command now requires either --dest (with optional --format), to directly describe the file destination, or --xml, to name a file that contains an XML description

[libvirt] [PATCH] virsh: Initialize vshData in cmdMigrate

2014-08-26 Thread Ján Tomko
If the virConnect did not succeeed, we called virConnectClose on uninitialized data. Introduced by commit 7eabd55. --- tools/virsh-domain.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Pushed as trivial. diff --git a/tools/virsh-domain.c b/tools/virsh-domain.c index 2562326..fcfbf74

Re: [libvirt] [PATCH] blkdeviotune: check for overflow when parsing XML

2014-08-26 Thread Erik Skultety
Thank you very much for review. You're right, except for the part about adding a test case I think, it's fine to do it locally, but you can't predict data type sizes on all architectures, so in terms of creating a static XML description, you can't rely on a specific number being long/short

[libvirt] [PATCHv2] blkdeviotune: check for overflow when parsing XML

2014-08-26 Thread Erik Skultety
According to docs/schemas/domaincommon.rng and _virDomainBlockIoTuneInfo all the iotune values are interpreted as unsigned long long, however according to qemu_monitor_json.c, qemu silently truncates numbers larger than LLONG_MAX. There's really not much of a usage for such large numbers anyway

Re: [libvirt] [PATCH 4/4] qemu: Allow use of iothreads for disk definitions

2014-08-26 Thread John Ferlan
On 08/26/2014 01:03 AM, Martin Kletzander wrote: On Mon, Aug 25, 2014 at 08:38:09PM -0400, John Ferlan wrote: For virtio-blk-pci disks with the disk iothread attribute that are running the correct emulator, add the iothread=libvirtIothread# to the -device command line in order to enable

Re: [libvirt] [PATCH 4/4] qemu: Allow use of iothreads for disk definitions

2014-08-26 Thread Martin Kletzander
On Tue, Aug 26, 2014 at 07:34:16AM -0400, John Ferlan wrote: On 08/26/2014 01:03 AM, Martin Kletzander wrote: On Mon, Aug 25, 2014 at 08:38:09PM -0400, John Ferlan wrote: For virtio-blk-pci disks with the disk iothread attribute that are running the correct emulator, add the

[libvirt] [PATCHv2 07/16] Domain network devices can now have a gateway element

2014-08-26 Thread Cédric Bosdonnat
Network interfaces devices and host devices with net capabilities can now have an IPv4 and/or an IPv6 address configured. --- docs/formatdomain.html.in| 9 docs/schemas/domaincommon.rng| 23 src/conf/domain_conf.c | 42

[libvirt] [PATCHv2 15/16] virNetDevClearIPv4Address: netlink implementation

2014-08-26 Thread Cédric Bosdonnat
--- src/util/virnetdev.c | 60 +++- 1 file changed, 45 insertions(+), 15 deletions(-) diff --git a/src/util/virnetdev.c b/src/util/virnetdev.c index 47f3c90..b718890 100644 --- a/src/util/virnetdev.c +++ b/src/util/virnetdev.c @@ -1015,6 +1015,47

[libvirt] [PATCHv2 13/16] Renamed virNetDevSetIPv4Address to virNetDevSetIPAddress

2014-08-26 Thread Cédric Bosdonnat
Renamed virNetDevSetIPv4Address as it also handles IPv6 addresses. --- src/libvirt_private.syms| 2 +- src/lxc/lxc_container.c | 2 +- src/network/bridge_driver.c | 4 ++-- src/util/virnetdev.c| 14 +++--- src/util/virnetdev.h| 6 +++--- 5 files changed, 14

[libvirt] [PATCHv2 05/16] Allow network capabilities hostdev to configure IP addresses

2014-08-26 Thread Cédric Bosdonnat
--- docs/formatdomain.html.in| 12 +++-- docs/schemas/domaincommon.rng| 23 +++--- src/conf/domain_conf.c | 47 src/conf/domain_conf.h | 2 ++ tests/lxcxml2xmldata/lxc-hostdev.xml | 2 ++ 5

[libvirt] [PATCHv2 06/16] lxc conf2xml: convert ip addresses for hostdev NICs

2014-08-26 Thread Cédric Bosdonnat
--- src/lxc/lxc_native.c | 3 +++ tests/lxcconf2xmldata/lxcconf2xml-physnetwork.config | 2 ++ tests/lxcconf2xmldata/lxcconf2xml-physnetwork.xml| 2 ++ 3 files changed, 7 insertions(+) diff --git a/src/lxc/lxc_native.c b/src/lxc/lxc_native.c index

[libvirt] [PATCHv2 03/16] LXC: set IP addresses to veth devices in the container

2014-08-26 Thread Cédric Bosdonnat
Uses the new virDomainNetDef ips to set the IP addresses on the network interfaces in the container. --- src/lxc/lxc_container.c | 24 +++- 1 file changed, 23 insertions(+), 1 deletion(-) diff --git a/src/lxc/lxc_container.c b/src/lxc/lxc_container.c index 1cf2c8f..ec9d808

[libvirt] [PATCHv2 16/16] Renamed virNetDevClearIPv4Address to virNetDevClearIPAddress

2014-08-26 Thread Cédric Bosdonnat
Make clear that virNetDevClearIPv4Address can also handle IPv6 addresses by changing the name --- src/libvirt_private.syms | 2 +- src/util/virnetdev.c | 14 +++--- src/util/virnetdev.h | 6 +++--- 3 files changed, 11 insertions(+), 11 deletions(-) diff --git

[libvirt] [PATCHv2 11/16] Wrong place for virDomainNetIpsFormat

2014-08-26 Thread Cédric Bosdonnat
--- src/conf/domain_conf.c | 60 +- 1 file changed, 30 insertions(+), 30 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index e1070a6..f9ac1a5 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -16021,6

[libvirt] [PATCHv2 00/16] LXC network configuration support

2014-08-26 Thread Cédric Bosdonnat
Hi all, Here is the whole series resent with a major addition: the functions used to set the IP and add a route now use libnl when possible. The idea behind this is to avoid requiring iproute2 or ifconfig installed in the container rootfs. Otherwise nothing changed since v1. Cédric Bosdonnat

[libvirt] [PATCHv2 04/16] lxc conf2xml: convert IP addresses

2014-08-26 Thread Cédric Bosdonnat
--- src/lxc/lxc_native.c| 153 tests/lxcconf2xmldata/lxcconf2xml-simple.config | 2 + tests/lxcconf2xmldata/lxcconf2xml-simple.xml| 2 + 3 files changed, 106 insertions(+), 51 deletions(-) diff --git a/src/lxc/lxc_native.c

[libvirt] [PATCHv2 08/16] lxc conf2xml: convert lxc.network.ipv[46].gateway

2014-08-26 Thread Cédric Bosdonnat
--- src/lxc/lxc_native.c | 19 ++- tests/lxcconf2xmldata/lxcconf2xml-physnetwork.config | 2 ++ tests/lxcconf2xmldata/lxcconf2xml-physnetwork.xml| 1 + tests/lxcconf2xmldata/lxcconf2xml-simple.config | 2 ++

[libvirt] [PATCHv2 01/16] Forgot to cleanup ifname_guest* in domain network def parsing

2014-08-26 Thread Cédric Bosdonnat
--- src/conf/domain_conf.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 22a7f7e..19c6c75 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -7363,6 +7363,8 @@ virDomainNetDefParseXML(virDomainXMLOptionPtr xmlopt,

[libvirt] [PATCHv2 02/16] Domain conf: allow more than one IP address for net devices

2014-08-26 Thread Cédric Bosdonnat
Add the possibility to have more than one IP address configured for a domain network interface. IP addresses can also have a prefix to define the corresponding netmask. --- docs/formatdomain.html.in | 22 +++ docs/schemas/domaincommon.rng | 11 +++- src/conf/domain_conf.c

[libvirt] [PATCHv2 12/16] virNetDevSetIPv4Address: libnl implementation

2014-08-26 Thread Cédric Bosdonnat
Add a default implementation of virNetDevSetIPv4Address using netlink and libnl. This avoids requiring /usr/sbin/ip or /usr/sbin/ifconfig external binaries. --- src/libvirt_private.syms | 1 + src/util/virnetdev.c | 136 +-- src/util/virnetlink.c

[libvirt] [PATCHv2 14/16] virNetDevAddRoute: implementation using netlink

2014-08-26 Thread Cédric Bosdonnat
--- src/util/virnetdev.c | 105 +++ 1 file changed, 90 insertions(+), 15 deletions(-) diff --git a/src/util/virnetdev.c b/src/util/virnetdev.c index e1ee130..47f3c90 100644 --- a/src/util/virnetdev.c +++ b/src/util/virnetdev.c @@ -926,6 +926,95 @@

[libvirt] [PATCHv2 10/16] LXC: honour network devices link state

2014-08-26 Thread Cédric Bosdonnat
Don't activate LXC network device if link state='down'/ has been set in its configuration. --- src/lxc/lxc_container.c | 28 +++- 1 file changed, 15 insertions(+), 13 deletions(-) diff --git a/src/lxc/lxc_container.c b/src/lxc/lxc_container.c index a2f4c5d..f8b9fc2 100644

[libvirt] [PATCHv2 09/16] LXC: use the new net devices gateway definition

2014-08-26 Thread Cédric Bosdonnat
When a gateway is set on a network device, a new default route via this gateway through the devoce will be added in the container. --- src/lxc/lxc_container.c | 40 1 file changed, 40 insertions(+) diff --git a/src/lxc/lxc_container.c

[libvirt] [PATCHv2 4/5] virsh: domain: Split out code to lookup domain from string

2014-08-26 Thread Peter Krempa
Split out guts of the function to reuse it to get domain objects from string. --- tools/virsh-domain.c | 80 +--- tools/virsh-domain.h | 4 +++ 2 files changed, 55 insertions(+), 29 deletions(-) diff --git a/tools/virsh-domain.c

[libvirt] [PATCHv2 3/5] qemu: Implement bulk stats API and one of the stats groups to return

2014-08-26 Thread Peter Krempa
Implement the API function for virDomainListGetStats and virConnectGetAllDomainStats in a modular way and implement the VIR_DOMAIN_STATS_STATE group of statistics. --- src/qemu/qemu_driver.c | 175 + 1 file changed, 175 insertions(+) diff --git

[libvirt] [PATCHv2 5/5] virsh: Implement command to excercise the bulk stats APIs

2014-08-26 Thread Peter Krempa
Add domstats command that excercises both of the new APIs depending if you specify a domain list or not. The output is printed as a key=value list of the returned parameters. Man page section will be added in a separate patch. --- tools/virsh-domain-monitor.c | 140

[libvirt] [PATCHv2 2/5] remote: Implement bulk domain stats APIs in the remote driver

2014-08-26 Thread Peter Krempa
Implement the remote driver support for shuffling the domain stats around. --- daemon/remote.c | 91 src/remote/remote_driver.c | 88 ++ src/remote/remote_protocol.x | 26 -

[libvirt] [PATCHv2 0/5] Bulk domain stats query API

2014-08-26 Thread Peter Krempa
This version adds implementation in the qemu driver and virsh and fixes the following bugs from v1: *bad type of typed param count *off-by-one when counting and verifying domain objects in libvirt.c *off-by-one when allocating returned array in remote driver *the all domain stats func not

[libvirt] [PATCHv2 1/5] lib: Introduce API for retrieving bulk domain stats

2014-08-26 Thread Peter Krempa
The motivation for this API is that management layers that use libvirt usually poll for statistics using various split up APIs we currently provide. To get all the necessary stuff, the app needs to issue a lot of calls and agregate the results. The APIs I'm introducing here: 1) Returns data in a

Re: [libvirt] [PATCH 2/2] remote: Implement bulk domain stats APIs in the remote driver

2014-08-26 Thread Peter Krempa
On 08/26/14 11:47, Li Wei wrote: On 08/26/2014 01:05 AM, Peter Krempa wrote: Implement the remote driver support for shuffling the domain stats around. --- daemon/remote.c | 91 src/remote/remote_driver.c | 88

Re: [libvirt] [PATCH v2 1/8] blockcopy: virDomainBlockCopy with XML destination, typed params

2014-08-26 Thread Peter Krempa
On 08/26/14 13:21, Eric Blake wrote: This commit (finally) adds the virDomainBlockCopy API, with the intent that it will provide more power to the existing 'virsh blockcopy' command. 'virsh blockcopy' was first added in Apr 2012 (v0.9.12), which corresponds to the upstream qemu 1.2

[libvirt] [libvirt-python PATCH] Implement virDomainOpenGraphicsFD

2014-08-26 Thread Ján Tomko
--- generator.py | 1 + libvirt-override-api.xml | 7 +++ libvirt-override.c | 37 + 3 files changed, 45 insertions(+) diff --git a/generator.py b/generator.py index a12c52b..32ae34d 100755 --- a/generator.py +++ b/generator.py @@

Re: [libvirt] [PATCH v2 1/8] blockcopy: virDomainBlockCopy with XML destination, typed params

2014-08-26 Thread Eric Blake
On 08/26/2014 08:39 AM, Peter Krempa wrote: On 08/26/14 13:21, Eric Blake wrote: This commit (finally) adds the virDomainBlockCopy API, with the intent that it will provide more power to the existing 'virsh blockcopy' command. +/** + * VIR_DOMAIN_BLOCK_COPY_BANDWIDTH: + * Macro for the

Re: [libvirt] [PATCH v2 2/8] blockcopy: split out virsh implementation

2014-08-26 Thread Peter Krempa
On 08/26/14 13:21, Eric Blake wrote: I'm about to extend the capabilities of blockcopy. Hiding a few common lines of implementation gets in the way of the new required logic, and putting the new logic in the common implementation won't benefit any of the other blockjob operations. Therefore,

Re: [libvirt] [PATCH] virsh: fix password auth failed on ssh connection

2014-08-26 Thread Ján Tomko
On 08/26/2014 07:25 AM, Seyeong Kim wrote: When try to connect to another host using virsh with password auth on ssh env, can't put password properly because it's waiting IO from STDIN. This patch check if it's in pts so make that doesn't poll from STDIN. --- tools/virsh-domain.c | 3 +++

Re: [libvirt] [PATCH v2 3/8] blockcopy: expose new API in virsh

2014-08-26 Thread Peter Krempa
On 08/26/14 13:21, Eric Blake wrote: Expose the new power of virDomainBlockCopy through virsh. Continue to use the older API where possible, for maximum compatibility. The command now requires either --dest (with optional --format), to directly describe the file destination, or --xml, to

Re: [libvirt] [PATCH v2 4/8] blockcopy: remote implementation for new API

2014-08-26 Thread Peter Krempa
On 08/26/14 13:21, Eric Blake wrote: Fairly straightforward. * src/remote/remote_protocol.x (remote_domain_block_copy_args): New struct. (REMOTE_PROC_DOMAIN_BLOCK_COPY): New RPC. * src/remote/remote_driver.c (remote_driver): Wire it up. * src/remote_protocol-structs: Regenerate.

Re: [libvirt] [PATCHv2] blkdeviotune: check for overflow when parsing XML

2014-08-26 Thread Ján Tomko
On 08/26/2014 01:29 PM, Erik Skultety wrote: According to docs/schemas/domaincommon.rng and _virDomainBlockIoTuneInfo all the iotune values are interpreted as unsigned long long, however according to qemu_monitor_json.c, qemu silently truncates numbers larger than LLONG_MAX. There's really not

Re: [libvirt] [PATCH v2 5/8] blockcopy: tweak how rebase calls into copy

2014-08-26 Thread Peter Krempa
On 08/26/14 13:21, Eric Blake wrote: In order to implement the new virDomainBlockCopy, the existing block copy internal implementation needs to be adjusted. The new function will parse XML into a storage source, and parse typed parameters into integers, then call into the same common

Re: [libvirt] [PATCH v2 6/8] blockcopy: add a way to parse disk source

2014-08-26 Thread Peter Krempa
On 08/26/14 13:21, Eric Blake wrote: The new blockcopy API wants to reuse only a subset of the disk hotplug parser - namely, we only care about the embedded virStorageSourcePtr inside a disk XML. Strange as it may seem, it was easier to just parse an entire disk definition, then throw away

Re: [libvirt] [PATCH v2 7/8] blockcopy: add qemu implementation of new API

2014-08-26 Thread Peter Krempa
On 08/26/14 13:21, Eric Blake wrote: The hard part of managing the disk copy is already coded; all this had to do was convert the XML and virTypedParameters into the internal representation. With this patch, all blockcopy operations that used the old API should also work via the new API.

Re: [libvirt] [PATCH v2 8/8] blockcopy: add qemu implementation of new tunables

2014-08-26 Thread Peter Krempa
On 08/26/14 13:21, Eric Blake wrote: Upstream qemu 1.4 added some drive-mirror tunables not present when it was first introduced in 1.3. Management apps may want to set these in some cases (for example, without tuning granularity down to sector size, a copy may end up occupying more bytes

Re: [libvirt] [PATCH 3/4] domain_conf: Add support for iothreads in disk definition

2014-08-26 Thread Ján Tomko
On 08/26/2014 02:38 AM, John Ferlan wrote: Add a new disk driver attribute iothread to be parsed as the thread number for the disk to use. In order to more easily facilitate the usage and configuration of the iothread, a zero for the attribute indicates iothreads are not supported for the

Re: [libvirt] [Libvirt] segfault with patch libxl: fix framebuffer port setting for HVM domains

2014-08-26 Thread Chris
Le 26/08/2014 01:05, Jim Fehlig a écrit : Chris wrote: Hello, I encountered segfaults with libvirt + libxl with this specific patch : http://libvirt.org/git/?p=libvirt.git;a=commitdiff;h=b55cc5f4e31b488c4f9c3c8470c992c1f8f5d09c Hi Chris, Thanks for the report. Took a bit to track this

Re: [libvirt] [PATCH 1/3] Introduce virDomainOpenGraphicsFD API

2014-08-26 Thread Peter Krempa
On 08/25/14 20:22, Ján Tomko wrote: Define the public API implementation and declare internal driver prototype. --- include/libvirt/libvirt.h.in | 5 src/driver.h | 7 ++ src/libvirt.c| 58

Re: [libvirt] [PATCH 2/3] Add RPC implementation for virDomainOpenGraphicsFd

2014-08-26 Thread Peter Krempa
On 08/25/14 20:22, Ján Tomko wrote: --- daemon/remote.c | 42 ++ src/remote/remote_driver.c | 39 +++ src/remote/remote_protocol.x | 15 ++- src/rpc/virnetmessage.c | 26

Re: [libvirt] [PATCH 3/4] domain_conf: Add support for iothreads in disk definition

2014-08-26 Thread John Ferlan
On 08/26/2014 12:04 PM, Ján Tomko wrote: On 08/26/2014 02:38 AM, John Ferlan wrote: Add a new disk driver attribute iothread to be parsed as the thread number for the disk to use. In order to more easily facilitate the usage and configuration of the iothread, a zero for the attribute

Re: [libvirt] [PATCHv2 1/5] lib: Introduce API for retrieving bulk domain stats

2014-08-26 Thread Eric Blake
On 08/26/2014 08:14 AM, Peter Krempa wrote: The motivation for this API is that management layers that use libvirt usually poll for statistics using various split up APIs we currently provide. To get all the necessary stuff, the app needs to issue a lot of calls and agregate the results.

Re: [libvirt] [PATCH 3/3] Wire up virDomainOpenGraphicsFD in QEMU driver

2014-08-26 Thread Peter Krempa
On 08/25/14 20:22, Ján Tomko wrote: Should fix https://bugzilla.redhat.com/show_bug.cgi?id=26 --- src/qemu/qemu_driver.c | 80 ++ 1 file changed, 80 insertions(+) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index

[libvirt] [PATCHv2] Add RPC implementation for virDomainOpenGraphicsFd

2014-08-26 Thread Ján Tomko
--- daemon/remote.c | 44 src/remote/remote_driver.c | 43 +++ src/remote/remote_protocol.x | 15 ++- src/remote_protocol-structs | 6 ++ src/rpc/virnetmessage.c | 26

Re: [libvirt] [PATCH 2/3] Add RPC implementation for virDomainOpenGraphicsFd

2014-08-26 Thread Ján Tomko
On 08/26/2014 06:41 PM, Peter Krempa wrote: On 08/25/14 20:22, Ján Tomko wrote: --- daemon/remote.c | 42 ++ src/remote/remote_driver.c | 39 +++ src/remote/remote_protocol.x | 15 ++-

Re: [libvirt] [PATCHv2 1/5] lib: Introduce API for retrieving bulk domain stats

2014-08-26 Thread Peter Krempa
On 08/26/14 18:49, Eric Blake wrote: On 08/26/2014 08:14 AM, Peter Krempa wrote: +typedef int +(*virDrvDomainListGetStats)(virConnectPtr conn, +virDomainPtr *doms, +unsigned int ndoms, +unsigned int

Re: [libvirt] [PATCHv2] Add RPC implementation for virDomainOpenGraphicsFd

2014-08-26 Thread Peter Krempa
On 08/26/14 19:28, Ján Tomko wrote: --- daemon/remote.c | 44 src/remote/remote_driver.c | 43 +++ src/remote/remote_protocol.x | 15 ++- src/remote_protocol-structs | 6 ++

Re: [libvirt] [libvirt-python PATCH] Implement virDomainOpenGraphicsFD

2014-08-26 Thread Peter Krempa
On 08/26/14 16:43, Ján Tomko wrote: --- generator.py | 1 + libvirt-override-api.xml | 7 +++ libvirt-override.c | 37 + 3 files changed, 45 insertions(+) diff --git a/generator.py b/generator.py index a12c52b..32ae34d 100755

Re: [libvirt] [PATCHv2] Add RPC implementation for virDomainOpenGraphicsFd

2014-08-26 Thread Ján Tomko
On 08/26/2014 07:34 PM, Peter Krempa wrote: On 08/26/14 19:28, Ján Tomko wrote: --- daemon/remote.c | 44 src/remote/remote_driver.c | 43 +++ src/remote/remote_protocol.x | 15

Re: [libvirt] [Libvirt] segfault with patch libxl: fix framebuffer port setting for HVM domains

2014-08-26 Thread Jim Fehlig
Chris wrote: Le 26/08/2014 01:05, Jim Fehlig a écrit : Chris wrote: Hello, I encountered segfaults with libvirt + libxl with this specific patch : http://libvirt.org/git/?p=libvirt.git;a=commitdiff;h=b55cc5f4e31b488c4f9c3c8470c992c1f8f5d09c Hi Chris, Thanks for the report. Took a

Re: [libvirt] [PATCH 3/4] domain_conf: Add support for iothreads in disk definition

2014-08-26 Thread Ján Tomko
On 08/26/2014 06:42 PM, John Ferlan wrote: On 08/26/2014 12:04 PM, Ján Tomko wrote: On 08/26/2014 02:38 AM, John Ferlan wrote: Add a new disk driver attribute iothread to be parsed as the thread number for the disk to use. In order to more easily facilitate the usage and configuration of

Re: [libvirt] [PATCHv2 2/5] remote: Implement bulk domain stats APIs in the remote driver

2014-08-26 Thread Eric Blake
On 08/26/2014 08:14 AM, Peter Krempa wrote: Implement the remote driver support for shuffling the domain stats around. --- daemon/remote.c | 91 src/remote/remote_driver.c | 88 ++

Re: [libvirt] [PATCH 3/4] domain_conf: Add support for iothreads in disk definition

2014-08-26 Thread John Ferlan
On 08/26/2014 01:51 PM, Ján Tomko wrote: On 08/26/2014 06:42 PM, John Ferlan wrote: On 08/26/2014 12:04 PM, Ján Tomko wrote: On 08/26/2014 02:38 AM, John Ferlan wrote: Add a new disk driver attribute iothread to be parsed as the thread number for the disk to use. In order to more easily

Re: [libvirt] [PATCHv2 1/5] lib: Introduce API for retrieving bulk domain stats

2014-08-26 Thread Eric Blake
On 08/26/2014 11:28 AM, Peter Krempa wrote: On 08/26/14 18:49, Eric Blake wrote: On 08/26/2014 08:14 AM, Peter Krempa wrote: Would it make sense for @flags to provide the same filtering as virConnectListAllDomains(), for selecting a subset of domains to get stats on? But can

Re: [libvirt] [PATCHv2 2/5] remote: Implement bulk domain stats APIs in the remote driver

2014-08-26 Thread Eric Blake
On 08/26/2014 12:22 PM, Eric Blake wrote: On 08/26/2014 08:14 AM, Peter Krempa wrote: Implement the remote driver support for shuffling the domain stats around. --- daemon/remote.c | 91 src/remote/remote_driver.c | 88

Re: [libvirt] [PATCHv2 3/5] qemu: Implement bulk stats API and one of the stats groups to return

2014-08-26 Thread Eric Blake
On 08/26/2014 08:14 AM, Peter Krempa wrote: Implement the API function for virDomainListGetStats and virConnectGetAllDomainStats in a modular way and implement the VIR_DOMAIN_STATS_STATE group of statistics. --- src/qemu/qemu_driver.c | 175 +

Re: [libvirt] [PATCHv2 3/5] qemu: Implement bulk stats API and one of the stats groups to return

2014-08-26 Thread Peter Krempa
On 08/26/14 21:02, Eric Blake wrote: On 08/26/2014 08:14 AM, Peter Krempa wrote: Implement the API function for virDomainListGetStats and virConnectGetAllDomainStats in a modular way and implement the VIR_DOMAIN_STATS_STATE group of statistics. --- src/qemu/qemu_driver.c | 175

  1   2   >