On Mon, Aug 25, 2014 at 06:37:50PM +0200, Martin Kletzander wrote:
On Fri, Aug 22, 2014 at 11:37:52AM +0200, Michal Privoznik wrote:
Since times when vbox moved to the daemon (due to some licensing
issue) the subdrivers that vbox implements were registered, but not
opened since our generic
On Tue, Aug 26, 2014 at 06:15:46PM -0400, John Ferlan wrote:
Introduce XML to allowing adding iothreads to the domain. These can be
used by virtio-blk-pci devices in order to assign a specific thread to
handle the workload for the device. The iothreads are the official
implementation of the
On Tue, Aug 26, 2014 at 06:15:47PM -0400, John Ferlan wrote:
Add a new capability to ensure the iothreads feature exists for the qemu
emulator being run - requires the query-iothreads QMP command. Using the
domain XML add correspoding command argument in order to generate the
threads. The
On Tue, Aug 26, 2014 at 06:15:46PM -0400, John Ferlan wrote:
Introduce XML to allowing adding iothreads to the domain. These can be
used by virtio-blk-pci devices in order to assign a specific thread to
handle the workload for the device. The iothreads are the official
implementation of the
On Tue, Aug 26, 2014 at 06:15:48PM -0400, John Ferlan wrote:
Add a new disk driver attribute iothread to be parsed as the thread
number for the disk to use. In order to more easily facilitate the usage
and configuration of the iothread, a zero for the attribute indicates
iothreads are not
On Tue, Aug 26, 2014 at 06:15:49PM -0400, John Ferlan wrote:
For virtio-blk-pci disks with the disk iothread attribute that are
running the correct emulator, add the iothread=iothread# to the
-device command line in order to enable iothreads for the disk.
This code will check both the start and
So I tagged 1.2.8-rc1 in git and made tarball and signed rpms
available at the usual place:
ftp://libvirt.org/libvirt/
While we seems to have the new API in place it's also clear that there
is a bunch of patches still waiting, either related to the new APIs
or blocked by lack of review.
Hi Richard,
On Tue, 2014-08-26 at 22:32 +0200, Richard Weinberger wrote:
On Tue, Aug 26, 2014 at 3:20 PM, Cédric Bosdonnat cbosdon...@suse.com wrote:
Hi all,
Here is the whole series resent with a major addition: the functions
used to set the IP and add a route now use libnl when
Cedric,
Am 27.08.2014 09:33, schrieb Cedric Bosdonnat:
Hi Richard,
On Tue, 2014-08-26 at 22:32 +0200, Richard Weinberger wrote:
On Tue, Aug 26, 2014 at 3:20 PM, Cédric Bosdonnat cbosdon...@suse.com
wrote:
Hi all,
Here is the whole series resent with a major addition: the functions
used
On 08/27/2014 12:05 AM, Eric Blake wrote:
Let's fix this before we bake in a painful API. Since we know
that we have exactly one non-negative fd on success, we might
as well return the fd directly instead of forcing the user to
pass in a pointer. Fix a memory leak I found while reviewing.
Currently, after calling commands to create a new volumes,
virStorageBackendZFSCreateVol calls virStorageBackendZFSFindVols that
calls virStorageBackendZFSParseVol.
virStorageBackendZFSParseVol checks if a volume already exists by
trying to get it using virStorageVolDefFindByName.
For a just
On 08/27/2014 11:02 AM, Eric Blake wrote:
On 08/26/2014 08:10 PM, Jincheng Miao wrote:
In qemuDomainRevertToSnapshot(), it will check snap-def-state.
But when the state is PMSUSPENDED/NOSTATE/BLOCKED, it forgets to
call qemuDomainObjEndJob.
Signed-off-by: Jincheng Miao jm...@redhat.com
---
On 08/27/2014 03:20 AM, Jincheng Miao wrote:
On 08/27/2014 11:02 AM, Eric Blake wrote:
On 08/26/2014 08:10 PM, Jincheng Miao wrote:
In qemuDomainRevertToSnapshot(), it will check snap-def-state.
But when the state is PMSUSPENDED/NOSTATE/BLOCKED, it forgets to
call qemuDomainObjEndJob.
resolves https://bugzilla.redhat.com/show_bug.cgi?id=1132305
---
tools/virsh.c | 14 ++
tools/virsh.pod | 6 --
2 files changed, 14 insertions(+), 6 deletions(-)
diff --git a/tools/virsh.c b/tools/virsh.c
index 30a84c1..f9b3991 100644
--- a/tools/virsh.c
+++ b/tools/virsh.c
@@
Signed-off-by: Martin Kletzander mklet...@redhat.com
---
src/conf/domain_conf.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
index 3b295ab..d6fd1ab 100644
--- a/src/conf/domain_conf.c
+++ b/src/conf/domain_conf.c
@@ -2136,6 +2136,8 @@ void
On Wed, Aug 27, 2014 at 03:15:35PM +0200, Erik Skultety wrote:
resolves https://bugzilla.redhat.com/show_bug.cgi?id=1132305
---
tools/virsh.c | 14 ++
tools/virsh.pod | 6 --
2 files changed, 14 insertions(+), 6 deletions(-)
diff --git a/tools/virsh.c b/tools/virsh.c
index
Signed-off-by: Martin Kletzander mklet...@redhat.com
---
src/conf/domain_conf.c | 4
1 file changed, 4 insertions(+)
diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
index 3b295ab..91f92a4 100644
--- a/src/conf/domain_conf.c
+++ b/src/conf/domain_conf.c
@@ -2136,6 +2136,10 @@
On 08/27/2014 03:41 PM, Martin Kletzander wrote:
Signed-off-by: Martin Kletzander mklet...@redhat.com
---
src/conf/domain_conf.c | 4
1 file changed, 4 insertions(+)
ACK
Jan
signature.asc
Description: OpenPGP digital signature
--
libvir-list mailing list
libvir-list@redhat.com
There were two warnings in this module
If the VIR_ALLOC_N(def-serials, 1) fails, then a virDomainChrDefFree(chr)
is called and we jump to cleanup which makes the same call. Just remove
the one after VIR_ALLOC_N()
In the label skipnic: a virDomainNetDefFree(net) is made; however, if
in
After installing a new version of Coverity - my daily checker has found
many more (140) new issues. Figured I'd start tackling the list bit
by bit. I didn't dig into when any of these were introduced - with so
many on the list it'd be overwhelming :-)
John Ferlan (10):
parallels: Resolve
Coverity complains that calling virNetworkDefFree(def), then jumping
to the cleanup: label which calls virNetworkDefFree(def) could result
in a double_free. Just remove the call from the if statement.
Signed-off-by: John Ferlan jfer...@redhat.com
---
src/parallels/parallels_network.c | 4 +---
In qemuNetworkIfaceConnect() a call to virNetDevBandwidthSet() is
made where the function prototype requires the first parameter
(net-ifname) to be non NULL. Coverity complains that the subsequent
non NULL check for net-ifname prior to the next call gets flagged as
an unnecessary check. Resolve
If virDomainDiskDefFree(disk) is called in 'skipdisk:', then it's possible
to either return to skipdisk without reallocating a new disk (via the if
condition just prior) or to end the loop having deleted the disk. Since
virDomainDiskDefFree() does not pass by reference, disk isn't changed in
this
There were two occurrances of attempting to initialize actualType by
calling virStorageSourceGetActualType(src) prior to a check if (!src)
resulting in Coverity complaining about the possible NULL dereference
in virStorageSourceGetActualType() of src.
Resolve by moving the actualType setting
The call to virDomainSnapshotRedefinePrep() had a spurrious ! in front of
it which caused Coverity to complan that the expression is always false.
Signed-off-by: John Ferlan jfer...@redhat.com
---
src/qemu/qemu_driver.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git
Coverity noted that all callers to libxlDomainEventQueue() could ensure
the second parameter (event) was true before calling except this case.
As I look at the code and how events are used - it seems that two events
would have been sent which more than likely causes some bad stuff for
the second
Coverity complains that checking for domain-def being non NULL in the
if (live) path of virDomainObjAssignDef() would be unnecessary or a
NULL deref since the call to virDomainObjIsActive() would already
dereference domain-def when checking if the def-id field was != -1.
Checked all callers to
Adjust the initialization of qemuCaps() to check for a NULL before
attempting to dereference like other callers/users do.
Signed-off-by: John Ferlan jfer...@redhat.com
---
src/qemu/qemu_capabilities.c | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git
In virDomainActualNetDefFormat() a call to virDomainNetGetActualType(def)
was made before a check for (!def) a few lines later. This triggered
Coverity to note the possible NULL deref. Just moving the initialization
to after the !def checks resolves the issue
Signed-off-by: John Ferlan
resolves https://bugzilla.redhat.com/show_bug.cgi?id=1132305
---
tools/virsh.c | 26 --
1 file changed, 20 insertions(+), 6 deletions(-)
diff --git a/tools/virsh.c b/tools/virsh.c
index 30a84c1..713c9a5 100644
--- a/tools/virsh.c
+++ b/tools/virsh.c
@@ -3470,18 +3470,32
Currently, there is one flag passed in during macvtap creation
(withTap) -- Let's convert this field to an unsigned int flag
field for future expansion.
Signed-off-by: Matthew Rosato mjros...@linux.vnet.ibm.com
---
src/lxc/lxc_process.c |4 ++--
src/qemu/qemu_command.c |6
Currently, MAC registration occurs during device creation, which is
early enough that, during live migration, you end up with duplicate
MAC addresses on still-running source and target devices, even though
the target device isn't actually being used yet.
This patch proposes to defer MAC
The following patchset introduces code to defer setting netdevs online
(and therefore registering MACs) until right before beginning guest
CPU execution. The first patch introduces some infrastructure changes
in preparation of the actual function added in the 2nd patch.
Associated BZ:
On 08/27/2014 02:42 AM, Martin Kletzander wrote:
On Tue, Aug 26, 2014 at 06:15:48PM -0400, John Ferlan wrote:
Add a new disk driver attribute iothread to be parsed as the thread
number for the disk to use. In order to more easily facilitate the usage
and configuration of the iothread, a zero
On 08/27/2014 03:51 PM, John Ferlan wrote:
After installing a new version of Coverity - my daily checker has found
many more (140) new issues. Figured I'd start tackling the list bit
by bit. I didn't dig into when any of these were introduced - with so
many on the list it'd be overwhelming
On 08/26/2014 06:15 PM, John Ferlan wrote:
Introduce XML to allowing adding iothreads to the domain. These can be
used by virtio-blk-pci devices in order to assign a specific thread to
handle the workload for the device. The iothreads are the official
implementation of the virtio-blk Data
On 08/27/2014 03:51 PM, John Ferlan wrote:
Coverity noted that all callers to libxlDomainEventQueue() could ensure
the second parameter (event) was true before calling except this case.
As I look at the code and how events are used - it seems that two events
would have been sent which more
On 08/27/2014 08:42 AM, Ján Tomko wrote:
On 08/27/2014 03:51 PM, John Ferlan wrote:
After installing a new version of Coverity - my daily checker has found
many more (140) new issues. Figured I'd start tackling the list bit
by bit. I didn't dig into when any of these were introduced - with so
On 08/27/2014 03:00 AM, Martin Kletzander wrote:
On Tue, Aug 26, 2014 at 06:15:49PM -0400, John Ferlan wrote:
For virtio-blk-pci disks with the disk iothread attribute that are
running the correct emulator, add the iothread=iothread# to the
-device command line in order to enable iothreads
On 08/27/14 15:51, John Ferlan wrote:
There were two occurrances of attempting to initialize actualType by
calling virStorageSourceGetActualType(src) prior to a check if (!src)
resulting in Coverity complaining about the possible NULL dereference
in virStorageSourceGetActualType() of src.
On 08/27/2014 07:39 AM, Martin Kletzander wrote:
On Wed, Aug 27, 2014 at 03:15:35PM +0200, Erik Skultety wrote:
resolves https://bugzilla.redhat.com/show_bug.cgi?id=1132305
---
tools/virsh.c | 14 ++
tools/virsh.pod | 6 --
2 files changed, 14 insertions(+), 6 deletions(-)
On 08/27/2014 10:42 AM, Ján Tomko wrote:
On 08/27/2014 03:51 PM, John Ferlan wrote:
Coverity noted that all callers to libxlDomainEventQueue() could ensure
the second parameter (event) was true before calling except this case.
As I look at the code and how events are used - it seems that two
On 08/27/2014 08:59 AM, Eric Blake wrote:
On 08/27/2014 08:42 AM, Ján Tomko wrote:
On 08/27/2014 03:51 PM, John Ferlan wrote:
After installing a new version of Coverity - my daily checker has found
many more (140) new issues. Figured I'd start tackling the list bit
by bit. I didn't dig into
On 08/27/2014 08:20 AM, Erik Skultety wrote:
resolves https://bugzilla.redhat.com/show_bug.cgi?id=1132305
Please include a short summary of the BZ in the commit message, so a
year from now, we don't have to chase the URL to find out why.
The subject line is out of date, now that you dropped man
On Wed, Aug 27, 2014 at 10:41:45AM -0400, John Ferlan wrote:
On 08/27/2014 03:00 AM, Martin Kletzander wrote:
On Tue, Aug 26, 2014 at 06:15:49PM -0400, John Ferlan wrote:
For virtio-blk-pci disks with the disk iothread attribute that are
running the correct emulator, add the
This series of patches add suport for bps_max, bps_rd_max, bps_wr_max,
bps_max, bps_rd_max, bps_wr_max, and iops_size in the functions
qemuDomainSetBlockIoTune,
and qemuDomainGetBlockIoTune.
The last patch add suport for therse parameters to the virsh blkdeviotune
commande.
Matthias Gatto (9):
Add a value in the enum virQEMUCapsFlags for the qemu capability.
Set it with virQEMUCapsSet if the binary suport bps_max and they friends.
Signed-off-by: Matthias Gatto matthias.ga...@outscale.com
---
src/qemu/qemu_capabilities.c | 6 ++
src/qemu/qemu_capabilities.h | 1 +
2 files changed,
Detect if the the qemu binary currently in use suport the bps_max option,
If yes add it to the command, if not, just ignore the options.
Signed-off-by: Matthias Gatto matthias.ga...@outscale.com
---
src/qemu/qemu_monitor_json.c | 58
1 file changed,
Add the new throttle options to virsh, and send them to libvirt.
Signed-off-by: Matthias Gatto matthias.ga...@outscale.com
---
tools/virsh-domain.c | 119 +++
1 file changed, 119 insertions(+)
diff --git a/tools/virsh-domain.c
Allow qemu driver to save the configuration use by bps_max and they friends.
Signed-off-by: Matthias Gatto matthias.ga...@outscale.com
---
src/conf/domain_conf.c | 89 +-
1 file changed, 88 insertions(+), 1 deletion(-)
diff --git
Detect if the the qemu binary currentely in use suport the bps_max option and
thy firends,
If yes add it to the commande, if not, just ignore the options.
Signed-off-by: Matthias Gatto matthias.ga...@outscale.com
---
src/qemu/qemu_monitor_text.c | 75
Modify the structure _virDomainBlockIoTuneInfo to suport total_bytes_sec_max,
write_bytes_sec_max,
read_bytes_sec_max, total_iops_sec_max, write_iops_sec_max, read_iops_sec_max,
size_iops_sec options.
Add the bool suport_max_options in the sturture _virDomainBlockIoTuneInfo used
to know
if the
Add defines for the new options total_bytes_sec_max, write_bytes_sec_max,
read_bytes_sec_max
total_iops_sec_max, write_iops_sec_max, read_iops_sec_max, size_iops_sec.
Signed-off-by: Matthias Gatto matthias.ga...@outscale.com
---
include/libvirt/libvirt.h.in | 54
Add suport for bps_max and friends in the driver part.
In the part checking if a qemu is running, check if the running binary suport
bps_max,
if not prrint an error message, if yes add it to info variable
Signed-off-by: Matthias Gatto matthias.ga...@outscale.com
---
src/qemu/qemu_driver.c | 158
Check the avability of the options with the current qemu binary, add them in
the varable opt if yes,
print a message if not.
Signed-off-by: Matthias Gatto matthias.ga...@outscale.com
---
src/qemu/qemu_command.c | 49 +
1 file changed, 49
Hi all,
detect_scsi_host_caps function is called without caring of the result in
most cases. Wouldn't it be more logical to have VIR_ERRORs in this
function transformed into VIR_WARN as those problems aren't blocking
libvirt?
Note: I can do the (trivial) patch if the idea is ACKed.
--
Cedric
On Tue, Aug 26, 2014 at 11:15 PM, John Ferlan jfer...@redhat.com wrote:
+The content of this optional element defines the number
+of IOThreads to be assigned to the domain for use by
+virtio-blk-pci target storage devices. There should be
+only 1 or 2 IOThreads
On Tue, Aug 26, 2014 at 1:38 AM, John Ferlan jfer...@redhat.com wrote:
+value. Each device must use a unique IOThread and threads will
+be numbered from 1 to the domain iothreads value.
It is reasonable for multiple devices to share the same IOThread.
For example, if
On 08/27/2014 09:51 AM, John Ferlan wrote:
After installing a new version of Coverity - my daily checker has found
many more (140) new issues. Figured I'd start tackling the list bit
by bit. I didn't dig into when any of these were introduced - with so
many on the list it'd be overwhelming
Kiarie Kahurani wrote:
Introduce the new xen-xl parser that {formats,parses} xl disk
and spice graphics format
This is a big patch with a lot of changes that aren't directly related
parsing/formating xl config. I think it would be best to split this into
three patches: One that exports all
Add helper to free a list of virDomainPtrs without raising or clearing
errors. Use it in one place and prepare it for reuse.
---
src/conf/domain_conf.c | 31 +++
src/conf/domain_conf.h | 2 ++
src/libvirt_private.syms | 1 +
3 files changed, 26 insertions(+), 8
Implement the remote driver support for shuffling the domain stats
around.
---
daemon/remote.c | 86
src/remote/remote_driver.c | 84 +++
src/remote/remote_protocol.x | 25 -
Add domain list filtering functions and a flag to enforce checking
whether the remote daemon supports the requested stats groups.
---
include/libvirt/libvirt.h.in | 15 +++
src/libvirt.c| 29 -
2 files changed, 43 insertions(+), 1
Implement the API function for virDomainListGetStats and
virConnectGetAllDomainStats in a modular way and implement the
VIR_DOMAIN_STATS_STATE group of statistics.
Although it may look like the function looks universal I'd rather not
expose it to other drivers as the comming stats groups are
New iteration of the series with a few improvements
Peter Krempa (5):
conf: Add helper to free domain list
lib: Add few flags for the bulk stats APIs
remote: Implement bulk domain stats APIs in the remote driver
qemu: Implement bulk stats API and one of the stats groups to return
virsh:
Add domstats command that excercises both of the new APIs depending if
you specify a domain list or not. The output is printed as a key=value
list of the returned parameters.
---
tools/virsh-domain-monitor.c | 191 +++
tools/virsh.pod | 34
On Wed, Aug 27, 2014 at 9:18 AM, Daniel Veillard veill...@redhat.com wrote:
So I tagged 1.2.8-rc1 in git and made tarball and signed rpms
Can you please sign the tarball too?
--
Thanks,
//richard
--
libvir-list mailing list
libvir-list@redhat.com
Kiarie Kahurani wrote:
Kiarie Kahurani (1):
src/xenconfig: XL parser
po/POTFILES.in| 1 +
src/Makefile.am | 3 +-
src/libvirt_xenconfig.syms| 5 +
src/libxl/libxl_driver.c | 44
On Tue, Aug 26, 2014 at 8:22 AM, Martin Kletzander mklet...@redhat.com wrote:
On Fri, Aug 22, 2014 at 12:47:00PM +0200, Maxime Leroy wrote:
[..]
Considering there could be other shared memory related devices,
this patch introduces a general device model, called shmem device.
Currenly ivshmem
On 08/27/2014 12:25 PM, Peter Krempa wrote:
Add helper to free a list of virDomainPtrs without raising or clearing
errors. Use it in one place and prepare it for reuse.
---
src/conf/domain_conf.c | 31 +++
src/conf/domain_conf.h | 2 ++
On 08/27/2014 12:25 PM, Peter Krempa wrote:
Add domain list filtering functions and a flag to enforce checking
whether the remote daemon supports the requested stats groups.
---
include/libvirt/libvirt.h.in | 15 +++
src/libvirt.c| 29 -
On Tue, Aug 26, 2014 at 10:42 AM, Martin Kletzander mklet...@redhat.com wrote:
On Fri, Aug 22, 2014 at 12:47:01PM +0200, Maxime Leroy wrote:
This patch adds configuration support for the shmem device
as described in the schema in the previous patch.
[...]
This parsing using loop over
Need to free 'xmlFromFile' on/for the error path when current was
returning false only
Signed-off-by: John Ferlan jfer...@redhat.com
---
tools/virsh-network.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/virsh-network.c b/tools/virsh-network.c
index 578abe0..9497472
If there was a failure processing 'authdef' and the code went to cleanup
before the setting to source-auth, then it'd be leaked.
Signed-off-by: John Ferlan jfer...@redhat.com
---
src/conf/storage_conf.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/src/conf/storage_conf.c
Coverity found that the 'buf' wasn't VIR_FREE'd at exit.
Signed-off-by: John Ferlan jfer...@redhat.com
---
src/qemu/qemu_driver.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c
index 73959da..323957e 100644
--- a/src/qemu/qemu_driver.c
+++
Coverity determined that on error path that 'mach' wouldn't be free'd
Since virCapabilitiesFreeGuestMachine() isn't globally available, we'll
insert first and then if the VIR_STRDUP's fail they it will eventually
cause the 'mach' to be freed in the error path
Signed-off-by: John Ferlan
Coverity determined that the copied 'oldguest' would be leaked for
both error and success paths.
Signed-off-by: John Ferlan jfer...@redhat.com
---
src/cpu/cpu_x86.c | 15 ++-
1 file changed, 10 insertions(+), 5 deletions(-)
diff --git a/src/cpu/cpu_x86.c b/src/cpu/cpu_x86.c
index
I almost didn't want to do this due to the sheer volume, but figured
at the very least the bulk of these are resource leaks found by the
much pickier new coverity scanner.
After this there are only 70 issues found...
John Ferlan (19):
libxl_migration: Resolve Coverity NULL_RETURNS
daemon:
A bunch of false positives brought on by our own doings
Signed-off-by: John Ferlan jfer...@redhat.com
---
src/qemu/qemu_driver.c | 7 +++
1 file changed, 7 insertions(+)
diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c
index 323957e..2c27cd6 100644
--- a/src/qemu/qemu_driver.c
On the error path need to free the chrdef
Signed-off-by: John Ferlan jfer...@redhat.com
---
src/libxl/libxl_domain.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/src/libxl/libxl_domain.c b/src/libxl/libxl_domain.c
index cdac82c..557fc20 100644
---
One useless warning, but the other one rather pertinent. On entry
the 'trans' variable is initialized to VIR_DOMAIN_DISK_TRANS_DEFAULT.
When the trans was found in the parsing loop it def-geometry.trans
was assigned to the return from virDomainDiskGeometryTransTypeFromString
and then 'trans' was
The PROBE macro can expand to more than one line/statement - put curly
braces around the if statement to be safe
Signed-off-by: John Ferlan jfer...@redhat.com
---
src/qemu/qemu_monitor.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/src/qemu/qemu_monitor.c
A bunch of a useless warnings brought on by our own doing.
Signed-off-by: John Ferlan jfer...@redhat.com
---
src/conf/domain_conf.c | 13 +
1 file changed, 13 insertions(+)
diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
index c7dbc73..ce5aad6 100644
---
In the error path the 'ipaddr' wasn't VIR_FREE'd before jumping to cleanup
Signed-off-by: John Ferlan jfer...@redhat.com
---
src/network/bridge_driver.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/network/bridge_driver.c b/src/network/bridge_driver.c
index 9491c51..4b3f07f 100644
---
In each of these cases, Coverity complains that the result count returned
on error paths would be -1 disregarding that the count and the corresponding
are linked together (it doesn't know that). Simple enough to check and
remove the warning
Signed-off-by: John Ferlan jfer...@redhat.com
---
In libxlDomainMigrationPrepare() if the uri_in is false, then
'hostname' is allocated and used generically in the routine,
but not freed. Conversely, if uri_in is true, then a uri is
allocated and hostname is set to the uri-hostname value and
likewise generically used.
At function exit, hostname
Coverity found that on error paths, the 'arg' value wasn't be cleaned
up. Followed the example in qemuAgentSetVCPUs() where upon successful call
to qemuAgentCommand() the 'cpus' is set to NULL; otherwise, when cleanup
occurs the free the memory for 'arg'
Signed-off-by: John Ferlan
On Tue, Aug 26, 2014 at 10:58 AM, Martin Kletzander mklet...@redhat.com wrote:
On Fri, Aug 22, 2014 at 12:47:03PM +0200, Maxime Leroy wrote:
[..]
It will sometimes format the command-line parameter to size=0m, which
will terribly fail. We should add it to the command-line with the
smallest
Coverity noted that all callers to libxlDomainEventQueue() could ensure
the second parameter (event) was true before calling except this case.
As I look at the code and how events are used - it seems that prior to
generating an event for the dom == NULL condition, the resume/suspend
event should
Need to VIR_FREE the startip/endip we allocated for the error message
Signed-off-by: John Ferlan jfer...@redhat.com
---
src/conf/network_conf.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/src/conf/network_conf.c b/src/conf/network_conf.c
index dc25c6e..9571ee1 100644
---
Resolve a few RESOURCE_LEAK's identified by Coverity
Signed-off-by: John Ferlan jfer...@redhat.com
---
src/conf/domain_conf.c | 15 +++
1 file changed, 11 insertions(+), 4 deletions(-)
diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
index 48afb8c..c7dbc73 100644
---
In qemuParseISCSIString() if an error was returned, then the call
to qemuParseDriveURIString() where the uri is free'd wouldn't be run
Signed-off-by: John Ferlan jfer...@redhat.com
---
src/qemu/qemu_command.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/qemu/qemu_command.c
Coverity determines that when jumping to the connected: label, the
addressinfo (ai) is not free'd.
Signed-off-by: John Ferlan jfer...@redhat.com
---
src/phyp/phyp_driver.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/phyp/phyp_driver.c b/src/phyp/phyp_driver.c
index aa1e105..ea1981a
On Tue, Aug 26, 2014 at 11:02 AM, Martin Kletzander mklet...@redhat.com wrote:
On Fri, Aug 22, 2014 at 12:47:04PM +0200, Maxime Leroy wrote:
[...]
+shmem name='shmem0' model='ivshmem'
+ server path='/tmp/socket-shmem0'/
+ msi vectors='32' ioeventfd='on'/
+/shmem
+shmem
On 08/27/2014 12:25 PM, Peter Krempa wrote:
Implement the remote driver support for shuffling the domain stats
around.
---
+static int
+remoteDispatchConnectGetAllDomainStats(virNetServerPtr server
ATTRIBUTE_UNUSED,
+ virNetServerClientPtr client,
+
On Tue, Aug 26, 2014 at 11:02 AM, Wang Rui moon.wang...@huawei.com wrote:
On 2014/8/22 18:47, Maxime Leroy wrote:
This patch adds configuration support for the shmem device
as described in the schema in the previous patch.
[..]
+if (model) {
+if ((def-model ==
On Tue, Aug 26, 2014 at 11:23 AM, Wang Rui moon.wang...@huawei.com wrote:
On 2014/8/22 18:47, Maxime Leroy wrote:
[...]
+if (!(devstr = qemuBuildIvshmemDevStr(def, dev, qemuCaps)))
+return -1;
+virCommandAddArg(cmd, devstr);
+VIR_FREE(devstr);
+
+if
John Ferlan wrote:
On 08/27/2014 10:42 AM, Ján Tomko wrote:
On 08/27/2014 03:51 PM, John Ferlan wrote:
Coverity noted that all callers to libxlDomainEventQueue() could ensure
the second parameter (event) was true before calling except this case.
As I look at the code and how events
On Tue, Aug 26, 2014 at 11:58 AM, Wang Rui moon.wang...@huawei.com wrote:
On 2014/8/22 18:47, Maxime Leroy wrote:
+# util/virivshmemserver.h
+virStartIvshmemServer;
+virStopIvshmemServer;
I think function name virIvshmemStartServer is better.
So is the stop function.
What about
On 08/27/2014 12:25 PM, Peter Krempa wrote:
Implement the API function for virDomainListGetStats and
virConnectGetAllDomainStats in a modular way and implement the
VIR_DOMAIN_STATS_STATE group of statistics.
Although it may look like the function looks universal I'd rather not
expose it to
1 - 100 of 108 matches
Mail list logo
