[libvirt] [PATCH 0/2] fix: unix sockets created for virtio-serail has insufficient permissions

2014-09-02 Thread Chunyan Liu
https://sourceware.org/bugzilla/show_bug.cgi?id=13078#c11 https://bugzilla.novell.com/show_bug.cgi?id=888166 To use virtio-serial device, unix socket created for chardev with default umask(022) has insufficient permissions. e.g.: -device virtio-serial \ -chardev

[libvirt] [PATCH 2/2] qemu: add umask(002) to virtio-serial chardev commandline

2014-09-02 Thread Chunyan Liu
To use virtio-serial device, unix socket created for communication with default umask(022) has insufficient permissions. e.g. 1. Setup a virtual machine with a virtio-serial device: # virsh edit myvm (...) channel type='unix' source mode='bind' path='/tmp/somefile.sock'/ target

[libvirt] [PATCH 1/2] add 'umask' option to -chardev

2014-09-02 Thread Chunyan Liu
To use virtio-serial device, unix socket created for chardev with default umask(022) has insufficient permissions. e.g. start kvm guest with: -device virtio-serial \ -chardev socket,path=/tmp/foo,server,nowait,id=foo \ -device virtserialport,chardev=foo,name=org.fedoraproject.port.0 Check

[libvirt] Release of libvirt-1.2.8

2014-09-02 Thread Daniel Veillard
It's out ! Tagged and signed in git as well as tarball and rpms are available from the usual place: ftp://libvirt.org/libvirt/ I also made a release for the python bindings available from ftp://libvirt.org/libvirt/python/ This is a rather large release (surprizingly for August !) with a

Re: [libvirt] [Qemu-devel] [PATCH 1/2] add 'umask' option to -chardev

2014-09-02 Thread Daniel P. Berrange
On Tue, Sep 02, 2014 at 03:40:42PM +0800, Chunyan Liu wrote: To use virtio-serial device, unix socket created for chardev with default umask(022) has insufficient permissions. e.g. start kvm guest with: -device virtio-serial \ -chardev socket,path=/tmp/foo,server,nowait,id=foo \ -device

[libvirt] [PATCH] Post-release version bump for new dev cycle

2014-09-02 Thread Michal Privoznik
Signed-off-by: Michal Privoznik mpriv...@redhat.com --- Pushed under trivial rule. configure.ac | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure.ac b/configure.ac index f93c6c2..b4fb99a 100644 --- a/configure.ac +++ b/configure.ac @@ -16,7 +16,7 @@ dnl You should

[libvirt] [libvirt-python][PATCH] Post-release version bump for new dev cycle

2014-09-02 Thread Michal Privoznik
Signed-off-by: Michal Privoznik mpriv...@redhat.com --- Pushed under trivial rule. setup.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/setup.py b/setup.py index f5c6542..167f568 100755 --- a/setup.py +++ b/setup.py @@ -309,7 +309,7 @@ class my_clean(clean): _c_modules,

Re: [libvirt] [Qemu-devel] [PATCH 1/2] add 'umask' option to -chardev

2014-09-02 Thread Chun Yan Liu
On 9/2/2014 at 04:54 PM, in message 20140902085434.ga21...@redhat.com, Daniel P. Berrange berra...@redhat.com wrote: On Tue, Sep 02, 2014 at 03:40:42PM +0800, Chunyan Liu wrote: To use virtio-serial device, unix socket created for chardev with default umask(022) has insufficient

Re: [libvirt] [Qemu-devel] [PATCH 1/2] add 'umask' option to -chardev

2014-09-02 Thread Daniel P. Berrange
On Tue, Sep 02, 2014 at 03:08:51AM -0600, Chun Yan Liu wrote: On 9/2/2014 at 04:54 PM, in message 20140902085434.ga21...@redhat.com, Daniel P. Berrange berra...@redhat.com wrote: On Tue, Sep 02, 2014 at 03:40:42PM +0800, Chunyan Liu wrote: To use virtio-serial device, unix socket

Re: [libvirt] Entering freeze for libvirt-1.2.8

2014-09-02 Thread Richard Weinberger
Am 29.08.2014 12:03, schrieb Daniel Veillard: On Wed, Aug 27, 2014 at 08:45:29PM +0200, Richard Weinberger wrote: On Wed, Aug 27, 2014 at 9:18 AM, Daniel Veillard veill...@redhat.com wrote: So I tagged 1.2.8-rc1 in git and made tarball and signed rpms Can you please sign the tarball too?

[libvirt] [python PATCH] libvirt-override: fix some build warnings

2014-09-02 Thread Pavel Hrdina
Remove unused label 'cleanup' in 'libvirt_virConnectGetAllDomainStats' function and remove unused variable 'conn' in function 'libvirt_virDomainListGetStats'. Signed-off-by: Pavel Hrdina phrd...@redhat.com --- Pushed as trivial libvirt-override.c | 3 --- 1 file changed, 3 deletions(-) diff

Re: [libvirt] [PATCH] virsh: Implement command to rename domain

2014-09-02 Thread Michal Privoznik
On 01.09.2014 10:31, Philipp Hahn wrote: Hello Tomas, On 01.09.2014 01:51, Tomas Meszaros wrote: I've recently worked with rather large number of virtual machines and needed to rename all domains. I couldn't find better way how to rename domain other than: virsh dumpxml domain

Re: [libvirt] [Qemu-devel] [PATCH 1/2] add 'umask' option to -chardev

2014-09-02 Thread Chun Yan Liu
On 9/2/2014 at 05:16 PM, in message 20140902091655.gb21...@redhat.com, Daniel P. Berrange berra...@redhat.com wrote: On Tue, Sep 02, 2014 at 03:08:51AM -0600, Chun Yan Liu wrote: On 9/2/2014 at 04:54 PM, in message 20140902085434.ga21...@redhat.com, Daniel P. Berrange

[libvirt] [PATCH] Storage: Fix allocation for raw files.

2014-09-02 Thread Prerna Saxena
When virsh vol-clone is attempted on a raw file where capacity allocation, the resulting cloned volume has a size that matches the virtual-size of the parent; in place of matching its actual, disk size. For example : Given this image: [root@localhost]# qemu-img info

[libvirt] [PATCH] Free ifname in testDomainGenerateIfnames

2014-09-02 Thread Ján Tomko
https://bugzilla.redhat.com/show_bug.cgi?id=1135388 --- Pushed as trivial. src/test/test_driver.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/test/test_driver.c b/src/test/test_driver.c index 3b22cf6..9918d2c 100644 --- a/src/test/test_driver.c +++ b/src/test/test_driver.c @@ -521,6

[libvirt] DHCP and secure containers

2014-09-02 Thread Gene Czarcinski
OK, hopefully this mailing list is more active and I can get some response to my questions. - I have been playing with Secure Containers running a lighttpd server and have it up

Re: [libvirt] [Qemu-devel] [PATCH 1/2] add 'umask' option to -chardev

2014-09-02 Thread Markus Armbruster
Daniel P. Berrange berra...@redhat.com writes: On Tue, Sep 02, 2014 at 03:40:42PM +0800, Chunyan Liu wrote: To use virtio-serial device, unix socket created for chardev with default umask(022) has insufficient permissions. e.g. start kvm guest with: -device virtio-serial \ -chardev

[libvirt] [PATCH 04/11] qemu: report highest offset into block stats

2014-09-02 Thread Francesco Romani
This patch adds the reporting of the highest block stats written to the block stats. This information was already there since the beginning, and doing so we gain the information provided by GetBlockInfo without entering the monitor again. Signed-off-by: Francesco Romani from...@redhat.com ---

[libvirt] [PATCHv2 00/11] bulk stats: QEMU implementation

2014-09-02 Thread Francesco Romani
This patchset enhances the QEMU support for the new bulk stats API to include equivalents of these APIs: virDomainBlockInfo virDomainGetInfo - for balloon stats virDomainGetCPUStats virDomainBlockStatsFlags virDomainInterfaceStats virDomainGetVcpusFlags virDomainGetVcpus This subset of API is

[libvirt] [PATCH 01/11] qemu: extract helper to get the current balloon

2014-09-02 Thread Francesco Romani
Refactor the code to extract an helper method to get the current balloon settings. Signed-off-by: Francesco Romani from...@redhat.com --- src/qemu/qemu_driver.c | 98 ++ 1 file changed, 60 insertions(+), 38 deletions(-) diff --git

[libvirt] [PATCH 05/11] qemu: bulk stats: pass connection to workers

2014-09-02 Thread Francesco Romani
Future patches which will implement more bulk stats groups for QEMU will need to access the connection object, so enrich the worker prototype. Signed-off-by: Francesco Romani from...@redhat.com --- src/qemu/qemu_driver.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git

[libvirt] [PATCHv2 06/11] qemu: bulk stats: implement CPU stats group

2014-09-02 Thread Francesco Romani
This patch implements the VIR_DOMAIN_STATS_CPU_TOTAL group of statistics. Signed-off-by: Francesco Romani from...@redhat.com --- include/libvirt/libvirt.h.in | 1 + src/libvirt.c| 8 +++ src/qemu/qemu_driver.c | 56 3 files

[libvirt] [PATCH 02/11] qemu: extract helper to gather vcpu data

2014-09-02 Thread Francesco Romani
Extracts an helper to gether the VCpu information. Signed-off-by: Francesco Romani from...@redhat.com --- src/qemu/qemu_driver.c | 29 + 1 file changed, 25 insertions(+), 4 deletions(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index

[libvirt] [PATCHv2 10/11] qemu: bulk stats: implement block group

2014-09-02 Thread Francesco Romani
This patch implements the VIR_DOMAIN_STATS_BLOCK group of statistics. Signed-off-by: Francesco Romani from...@redhat.com --- include/libvirt/libvirt.h.in | 1 + src/libvirt.c| 13 + src/qemu/qemu_driver.c | 65 3 files

[libvirt] [PATCHv2 09/11] qemu: bulk stats: implement interface group

2014-09-02 Thread Francesco Romani
This patch implements the VIR_DOMAIN_STATS_INTERFACE group of statistics. Signed-off-by: Francesco Romani from...@redhat.com --- include/libvirt/libvirt.h.in | 1 + src/libvirt.c| 13 +++ src/qemu/qemu_driver.c | 85 3 files

[libvirt] [PATCHv2 08/11] qemu: bulk stats: implement VCPU group

2014-09-02 Thread Francesco Romani
This patch implements the VIR_DOMAIN_STATS_VCPU group of statistics. Signed-off-by: Francesco Romani from...@redhat.com --- include/libvirt/libvirt.h.in | 1 + src/libvirt.c| 8 + src/qemu/qemu_driver.c | 72 3 files

[libvirt] [PATCHv2 07/11] qemu: bulk stats: implement balloon group

2014-09-02 Thread Francesco Romani
This patch implements the VIR_DOMAIN_STATS_BALLOON group of statistics. Signed-off-by: Francesco Romani from...@redhat.com --- include/libvirt/libvirt.h.in | 1 + src/libvirt.c| 4 src/qemu/qemu_driver.c | 32 3 files changed, 37

[libvirt] [PATCH 11/11] qemu: bulk stats: add block allocation information

2014-09-02 Thread Francesco Romani
Management software, want to be able to allocate disk space on demand. To support this, they need keep track of the space occupation of the block device. This information is reported by qemu as part of block stats. This patch extend the block information in the bulk stats with the allocation

[libvirt] [PATCHv2 03/11] qemu: add helper to get the block stats

2014-09-02 Thread Francesco Romani
Add an helper function to get the block stats of a disk. This helper is meant to be used by the bulk stats API. Signed-off-by: Francesco Romani from...@redhat.com --- src/qemu/qemu_driver.c | 41 +++ src/qemu/qemu_monitor.c | 23 + src/qemu/qemu_monitor.h |

[libvirt] [python PATCH] override: Fix two uninitialized variables in convertDomainStatsRecord

2014-09-02 Thread Peter Krempa
py_record_domain and py_record_stats would be accessed uninitialized if an out-of-memory condition would happen in the first loop. Unlikely, but coverity complained. Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1136354 --- Pushed as trivial. libvirt-override.c | 4 ++-- 1 file

[libvirt] [PATCH] remote: Fix memory leak on error path when deserializing bulk stats

2014-09-02 Thread Peter Krempa
The 'elem' variable along with the domain object would be leaked when taking the error path. Found by coverity. --- src/remote/remote_driver.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/src/remote/remote_driver.c b/src/remote/remote_driver.c index

Re: [libvirt] [PATCH] remote: Fix memory leak on error path when deserializing bulk stats

2014-09-02 Thread Martin Kletzander
On Tue, Sep 02, 2014 at 03:18:39PM +0200, Peter Krempa wrote: The 'elem' variable along with the domain object would be leaked when taking the error path. Found by coverity. --- src/remote/remote_driver.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) ACK, Martin diff --git

Re: [libvirt] [Qemu-devel] IO accounting overhaul

2014-09-02 Thread Markus Armbruster
Benoît Canet benoit.ca...@irqsave.net writes: The Monday 01 Sep 2014 à 13:41:01 (+0200), Markus Armbruster wrote : Benoît Canet benoit.ca...@irqsave.net writes: The Monday 01 Sep 2014 à 11:52:00 (+0200), Markus Armbruster wrote : [...] A quick stab at tasks: * QMP interface, either a

Re: [libvirt] [PATCH RFC] qemu: add some synchronizations for snapshot

2014-09-02 Thread Peter Krempa
On 08/28/14 13:27, Jincheng Miao wrote: Currently it lacks synchronization to modify domain's snapshot object list, that race condition causes unsafe access to some freed snapshot objects. Therefore, this patch wraps all access of snapshot object list in vm job lock. Only the

Re: [libvirt] [PATCH] remote: Fix memory leak on error path when deserializing bulk stats

2014-09-02 Thread Peter Krempa
On 09/02/14 15:27, Martin Kletzander wrote: On Tue, Sep 02, 2014 at 03:18:39PM +0200, Peter Krempa wrote: The 'elem' variable along with the domain object would be leaked when taking the error path. Found by coverity. --- src/remote/remote_driver.c | 8 ++-- 1 file changed, 6

Re: [libvirt] [RFC] exclusive vcpu-cpu pinning

2014-09-02 Thread Raghavendra K T
* J?n Tomko jto...@redhat.com [2014-07-31 13:13:19]: Hello developers! Currently, our default cgroup layout is: -top level cgroup \-machine (machine.slice with systemd) `-vm1.libvirt-qemu (machine-qemu\x2dvm1.scope with systemd) `-emulator `-vcpu0 \-vcpu1 \-vm2.libvirt-qemu

[libvirt] (no subject)

2014-09-02 Thread Raghavendra K T
Bcc: Raghavendra K T raghavendra...@linux.vnet.ibm.com Subject: Re: [libvirt] [RFC] exclusive vcpu-cpu pinning Reply-To: Raghavendra K T raghavendra...@linux.vnet.ibm.com In-Reply-To: 53da24cf.8030...@redhat.com * J?n Tomko jto...@redhat.com [2014-07-31 13:13:19]: Hello developers!

[libvirt] [PATCH 0/2] Use huge pages on UMA guests widely

2014-09-02 Thread Michal Privoznik
*** BLURB HERE *** Michal Privoznik (2): conf: Disallow nonexistent NUMA nodes for hugepages qemu: Honor hugepages for UMA domains src/conf/domain_conf.c | 36 + src/qemu/qemu_command.c| 25 ++--

[libvirt] [PATCH 1/2] conf: Disallow nonexistent NUMA nodes for hugepages

2014-09-02 Thread Michal Privoznik
As of 136ad4974 it is possible to specify different huge pages per guest NUMA node. However, there's no check if nodeset specified in ./hugepages/page contains only those guest NUMA nodes that exist. In other words with current code it is possible to define meaningless combination:

[libvirt] [PATCH 2/2] qemu: Honor hugepages for UMA domains

2014-09-02 Thread Michal Privoznik
There are two ways how to tell qemu to use huge pages. The first one is suitable for domains with NUMA nodes: the path to hugetlbfs mount is appended to NUMA node definition on the command line. The second one is suitable for UMA domains: here there's this global '-mem-path' argument that accepts

Re: [libvirt] [RFC] exclusive vcpu-cpu pinning

2014-09-02 Thread Daniel P. Berrange
On Thu, Jul 31, 2014 at 01:13:19PM +0200, Ján Tomko wrote: Hello developers! Currently, our default cgroup layout is: -top level cgroup \-machine (machine.slice with systemd) `-vm1.libvirt-qemu (machine-qemu\x2dvm1.scope with systemd) `-emulator `-vcpu0 \-vcpu1

[libvirt] ignore this message

2014-09-02 Thread Gene Czarcinski
Sorry about that. I am having some trouble posting to this mailing list. Just ignore this message. Gene -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] ignore this message

2014-09-02 Thread Gene Czarcinski
On 09/02/2014 04:27 PM, Gene Czarcinski wrote: Sorry about that. I am having some trouble posting to this mailing list. Just ignore this message. Gene -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

[libvirt] ignore this message

2014-09-02 Thread Gene Czarcinski
Sorry about that. I am having some trouble posting to this mailing list. Just ignore this message. -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH 01/11] qemu: extract helper to get the current balloon

2014-09-02 Thread Eric Blake
On 09/02/2014 06:31 AM, Francesco Romani wrote: Refactor the code to extract an helper method to get the current balloon settings. Signed-off-by: Francesco Romani from...@redhat.com --- src/qemu/qemu_driver.c | 98 ++ 1 file changed, 60

Re: [libvirt] [PATCH 02/11] qemu: extract helper to gather vcpu data

2014-09-02 Thread Eric Blake
On 09/02/2014 06:31 AM, Francesco Romani wrote: Extracts an helper to gether the VCpu s/an/a/ s/gether/gather/ information. Signed-off-by: Francesco Romani from...@redhat.com --- src/qemu/qemu_driver.c | 29 + 1 file changed, 25 insertions(+), 4 deletions(-)

Re: [libvirt] [PATCHv2 03/11] qemu: add helper to get the block stats

2014-09-02 Thread Eric Blake
On 09/02/2014 06:31 AM, Francesco Romani wrote: Add an helper function to get the block stats of a disk. This helper is meant to be used by the bulk stats API. Signed-off-by: Francesco Romani from...@redhat.com --- src/qemu/qemu_driver.c | 41 +++

Re: [libvirt] [PATCH 04/11] qemu: report highest offset into block stats

2014-09-02 Thread Eric Blake
On 09/02/2014 06:31 AM, Francesco Romani wrote: This patch adds the reporting of the highest block stats written to the block stats. This information was already there since the beginning, and doing so we gain the information provided by GetBlockInfo without entering the monitor again.

Re: [libvirt] [PATCH 05/11] qemu: bulk stats: pass connection to workers

2014-09-02 Thread Eric Blake
On 09/02/2014 06:31 AM, Francesco Romani wrote: Future patches which will implement more bulk stats groups for QEMU will need to access the connection object, so enrich the worker prototype. Signed-off-by: Francesco Romani from...@redhat.com --- src/qemu/qemu_driver.c | 9 + 1

Re: [libvirt] [PATCHv2 06/11] qemu: bulk stats: implement CPU stats group

2014-09-02 Thread Eric Blake
On 09/02/2014 06:31 AM, Francesco Romani wrote: This patch implements the VIR_DOMAIN_STATS_CPU_TOTAL group of statistics. Signed-off-by: Francesco Romani from...@redhat.com --- include/libvirt/libvirt.h.in | 1 + src/libvirt.c| 8 +++ src/qemu/qemu_driver.c |

Re: [libvirt] [PATCHv2 06/11] qemu: bulk stats: implement CPU stats group

2014-09-02 Thread Eric Blake
On 09/02/2014 06:31 AM, Francesco Romani wrote: This patch implements the VIR_DOMAIN_STATS_CPU_TOTAL group of statistics. Signed-off-by: Francesco Romani from...@redhat.com --- include/libvirt/libvirt.h.in | 1 + src/libvirt.c| 8 +++ src/qemu/qemu_driver.c |

Re: [libvirt] [PATCHv2 07/11] qemu: bulk stats: implement balloon group

2014-09-02 Thread Eric Blake
On 09/02/2014 06:31 AM, Francesco Romani wrote: This patch implements the VIR_DOMAIN_STATS_BALLOON group of statistics. Signed-off-by: Francesco Romani from...@redhat.com --- include/libvirt/libvirt.h.in | 1 + src/libvirt.c| 4 src/qemu/qemu_driver.c | 32

Re: [libvirt] [PATCHv2 08/11] qemu: bulk stats: implement VCPU group

2014-09-02 Thread Eric Blake
On 09/02/2014 06:31 AM, Francesco Romani wrote: This patch implements the VIR_DOMAIN_STATS_VCPU group of statistics. Signed-off-by: Francesco Romani from...@redhat.com --- include/libvirt/libvirt.h.in | 1 + src/libvirt.c| 8 + src/qemu/qemu_driver.c | 72

Re: [libvirt] [PATCHv2 09/11] qemu: bulk stats: implement interface group

2014-09-02 Thread Eric Blake
On 09/02/2014 06:31 AM, Francesco Romani wrote: This patch implements the VIR_DOMAIN_STATS_INTERFACE group of statistics. Signed-off-by: Francesco Romani from...@redhat.com --- include/libvirt/libvirt.h.in | 1 + src/libvirt.c| 13 +++ src/qemu/qemu_driver.c |

Re: [libvirt] [PATCHv2 10/11] qemu: bulk stats: implement block group

2014-09-02 Thread Eric Blake
On 09/02/2014 06:31 AM, Francesco Romani wrote: This patch implements the VIR_DOMAIN_STATS_BLOCK group of statistics. Signed-off-by: Francesco Romani from...@redhat.com --- include/libvirt/libvirt.h.in | 1 + src/libvirt.c| 13 + src/qemu/qemu_driver.c | 65

Re: [libvirt] [PATCH 11/11] qemu: bulk stats: add block allocation information

2014-09-02 Thread Eric Blake
On 09/02/2014 06:31 AM, Francesco Romani wrote: Management software, want to be able to allocate disk space on demand. s/software, want/software wants/ To support this, they need keep track of the space occupation of the block device. (what's more, during a blockcopy or active blockcommit,

Re: [libvirt] [PATCHv2 00/11] bulk stats: QEMU implementation

2014-09-02 Thread Eric Blake
On 09/02/2014 06:31 AM, Francesco Romani wrote: This patchset enhances the QEMU support for the new bulk stats API to include equivalents of these APIs: virDomainBlockInfo virDomainGetInfo - for balloon stats virDomainGetCPUStats virDomainBlockStatsFlags virDomainInterfaceStats

Re: [libvirt] [PATCH 1/2] qemu: implement block group for bulk stats.

2014-09-02 Thread Eric Blake
On 08/29/2014 01:56 AM, Li Wei wrote: This patch add the block group for bulk stats. The following typed parameter used for each block stats: block.count - number of block devices in this domain block.0.name - name of the block device block.0.rd_bytes - number of read bytes

Re: [libvirt] [PATCH 2/2] virsh: add block group for bulk stats.

2014-09-02 Thread Eric Blake
On 08/29/2014 01:56 AM, Li Wei wrote: Add --block option to domstats command for querying block stats. Signed-off-by: Li Wei l...@cn.fujitsu.com --- tools/virsh-domain-monitor.c | 7 +++ tools/virsh.pod | 4 ++-- 2 files changed, 9 insertions(+), 2 deletions(-) ACK; but

Re: [libvirt] [PATCH 1/2] qemu: implement block group for bulk stats.

2014-09-02 Thread Li Wei
On 09/03/2014 07:19 AM, Eric Blake wrote: On 08/29/2014 01:56 AM, Li Wei wrote: This patch add the block group for bulk stats. The following typed parameter used for each block stats: block.count - number of block devices in this domain block.0.name - name of the block device