Re: [libvirt] [PATCH 4/5] conf: add options for disabling segment offloading

2014-09-17 Thread Ján Tomko
On 09/16/2014 12:24 AM, John Ferlan wrote: On 09/11/2014 07:43 AM, Ján Tomko wrote: Add the following attributes: csum, gso, guest_tso4, guest_tso6, guest_ecn to the driver element of network interface which control the virtio-net device properties of the same names. ---

Re: [libvirt] [PATCH 4/5] conf: add options for disabling segment offloading

2014-09-17 Thread Ján Tomko
On 09/16/2014 12:30 AM, Eric Blake wrote: On 09/11/2014 05:43 AM, Ján Tomko wrote: Add the following attributes: csum, gso, guest_tso4, guest_tso6, guest_ecn to the driver element of network interface which control the virtio-net device properties of the same names. ---

Re: [libvirt] [PATCH 1/1] qemu: Add support for multiple versions of 'pseries' machine type

2014-09-17 Thread Pradipta Kumar Banerjee
On 09/15/2014 07:46 PM, Ján Tomko wrote: On 09/13/2014 05:28 PM, Pradipta Kr. Banerjee wrote: qemu: Add support for multiple versions of 'pseries' machine type qemu for IBM Power processor architecture is adding functionality for supporting multiple 'pseries' machine type versions, each with

Re: [libvirt] [PATCH 1/1] qemu: Add support for multiple versions of 'pseries' machine type

2014-09-17 Thread Ján Tomko
On 09/17/2014 11:02 AM, Pradipta Kumar Banerjee wrote: On 09/15/2014 07:46 PM, Ján Tomko wrote: On 09/13/2014 05:28 PM, Pradipta Kr. Banerjee wrote: qemu: Add support for multiple versions of 'pseries' machine type qemu for IBM Power processor architecture is adding functionality for

[libvirt] [PATCH] qemu: fix crash with shared disks

2014-09-17 Thread Ján Tomko
Commit f36a94f introduced a double free on all success paths in qemuSharedDeviceEntryInsert. Only call qemuSharedDeviceEntryFree on the error path and set entry to NULL before jumping there if the entry already is in the hash table. https://bugzilla.redhat.com/show_bug.cgi?id=1142722 ---

Re: [libvirt] [PATCH] domaincaps: Expose UEFI binary path, if it exists

2014-09-17 Thread Laszlo Ersek
Hi Cole, I'm not subscribed to the list; please CC me on UEFI-related patches. Michal pinged me to review this one. Some comments: On 09/17/14 01:52, Cole Robinson wrote: Check to see if the UEFI binary mentioned in qemu.conf actually exists, and if so expose it in domcapabilities like

Re: [libvirt] [PATCH] domaincaps: Expose UEFI binary path, if it exists

2014-09-17 Thread Michal Privoznik
On 17.09.2014 01:52, Cole Robinson wrote: Check to see if the UEFI binary mentioned in qemu.conf actually exists, and if so expose it in domcapabilities like loader ... value/path/to/ovmf/value /loader We introduce some generic domcaps infrastructure for handling a dynamic list of string

[libvirt] [PATCH v2 0/2] Expose UEFI binary path

2014-09-17 Thread Michal Privoznik
This is practically reworked v1 from Cole. Cole Robinson (1): domaincaps: Expose UEFI binary path, if it exists Michal Privoznik (1): qemu_capabilities: Change virQEMUCapsFillDomainCaps signature docs/formatdomaincaps.html.in | 6 ++ docs/schemas/domaincaps.rng

[libvirt] [PATCH v2 1/2] qemu_capabilities: Change virQEMUCapsFillDomainCaps signature

2014-09-17 Thread Michal Privoznik
Up till now the virQEMUCapsFillDomainCaps() was type of void as there was no way for it to fail. This is, however, going to change in the next commit. Signed-off-by: Michal Privoznik mpriv...@redhat.com --- src/qemu/qemu_capabilities.c | 25 - src/qemu/qemu_capabilities.h

[libvirt] [PATCH v2 2/2] domaincaps: Expose UEFI binary path, if it exists

2014-09-17 Thread Michal Privoznik
From: Cole Robinson crobi...@redhat.com Check to see if the UEFI binary mentioned in qemu.conf actually exists, and if so expose it in domcapabilities like loader ... value/path/to/ovmf/value /loader We introduce some generic domcaps infrastructure for handling a dynamic list of string

Re: [libvirt] [PATCH v2 1/2] qemu_capabilities: Change virQEMUCapsFillDomainCaps signature

2014-09-17 Thread Laszlo Ersek
On 09/17/14 14:15, Michal Privoznik wrote: Up till now the virQEMUCapsFillDomainCaps() was type of void as there was no way for it to fail. This is, however, going to change in the next commit. Signed-off-by: Michal Privoznik mpriv...@redhat.com --- src/qemu/qemu_capabilities.c | 25

Re: [libvirt] [PATCH v2 2/2] domaincaps: Expose UEFI binary path, if it exists

2014-09-17 Thread Laszlo Ersek
On 09/17/14 14:15, Michal Privoznik wrote: diff --git a/tests/domaincapstest.c b/tests/domaincapstest.c index 0c4b09f..8543963 100644 --- a/tests/domaincapstest.c +++ b/tests/domaincapstest.c @@ -34,6 +34,27 @@ typedef int (*virDomainCapsFill)(virDomainCapsPtr domCaps, #define

Re: [libvirt] [PATCH v2 1/2] qemu_capabilities: Change virQEMUCapsFillDomainCaps signature

2014-09-17 Thread Cole Robinson
On 09/17/2014 08:15 AM, Michal Privoznik wrote: Up till now the virQEMUCapsFillDomainCaps() was type of void as there was no way for it to fail. This is, however, going to change in the next commit. Signed-off-by: Michal Privoznik mpriv...@redhat.com --- src/qemu/qemu_capabilities.c | 25

Re: [libvirt] [PATCH v2 2/2] domaincaps: Expose UEFI binary path, if it exists

2014-09-17 Thread Cole Robinson
On 09/17/2014 08:15 AM, Michal Privoznik wrote: From: Cole Robinson crobi...@redhat.com Check to see if the UEFI binary mentioned in qemu.conf actually exists, and if so expose it in domcapabilities like loader ... value/path/to/ovmf/value /loader We introduce some generic domcaps

Re: [libvirt] [PATCH v2] rpc: make daemon spawning a bit more intelligent

2014-09-17 Thread Martin Kletzander
On Tue, Sep 16, 2014 at 10:22:53AM -0400, John Ferlan wrote: On 09/16/2014 05:16 AM, Martin Kletzander wrote: This way it behaves more like the daemon itself does (acquiring a pidfile, deleting the socket before binding, etc.). Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=927369

Re: [libvirt] [PATCH v2 2/2] domaincaps: Expose UEFI binary path, if it exists

2014-09-17 Thread Michal Privoznik
On 17.09.2014 14:57, Cole Robinson wrote: On 09/17/2014 08:15 AM, Michal Privoznik wrote: From: Cole Robinson crobi...@redhat.com Check to see if the UEFI binary mentioned in qemu.conf actually exists, and if so expose it in domcapabilities like loader ... value/path/to/ovmf/value /loader

[libvirt] [PATCH 2/n] dumpxml: prepare to output block info

2014-09-17 Thread Eric Blake
This patch adds the common code for outputting drive sizing information, when a user has requested the new API flag from the previous patch. * src/util/virstoragefile.h (_virStorageSource): Add physical, to mirror virDomainBlockInfo. * docs/schemas/domaincommon.rng (storageSourceExtra): New

[libvirt] [RFC: PATCH 0/2] Display allocation during dumpxml

2014-09-17 Thread Eric Blake
I'm still working on code to populate the latest numbers for each disk of a domain, including getting numbers for offline domains, but have confirmed that with these two patches alone I'm able to see capacity and allocation numbers for block volumes of live domains (thanks to how we populate

[libvirt] [PATCH 1/n] dumpxml: add flag to virDomainGetXMLDesc

2014-09-17 Thread Eric Blake
The information in virDomainGetBlockInfo() is important for clients that use qcow2 format on LVM block devices - by tracking the allocation in relation to the physical size, management can tell if a disk needs to be expanded before the guest (file system contents) and/or qemu (copy-on-write

[libvirt] [PATCH 2/6] qemu: Fix old tcp:host URIs more cleanly

2014-09-17 Thread Jiri Denemark
For compatibility with old libvirt we need to support both tcp:host and tcp://host migration URIs. Let's make the code that parses them a bit cleaner. Signed-off-by: Jiri Denemark jdene...@redhat.com --- Notes: Version 3: - new patch to make qemu: RDMA migration support a bit more

[libvirt] [PATCH 0/6] RDMA migration support

2014-09-17 Thread Jiri Denemark
This is a modified version of RDMA migration patches sent back in January by Michael R. Hines. See individual patches for (numerous) changes since v2. Jiri Denemark (3): qemu: Fix old tcp:host URIs more cleanly qemu: Prepare support for arbitrary migration protocol qemu: Add RDMA migration

[libvirt] [PATCH 6/6] qemu: Memory pre-pinning support for RDMA migration

2014-09-17 Thread Jiri Denemark
From: Michael R. Hines mrhi...@us.ibm.com RDMA Live migration requires registering memory with the hardware, and thus QEMU offers a new 'capability' to pre-register / mlock() the guest memory in advance for higher RDMA performance before the migration begins. This capability is disabled by

[libvirt] [PATCH 3/6] qemu: Prepare support for arbitrary migration protocol

2014-09-17 Thread Jiri Denemark
Currently we only support TCP protocol for native QEMU migration but this is going to be changed. Let's make the code more general and remove hardcoded TCP protocol from several places. Signed-off-by: Jiri Denemark jdene...@redhat.com --- Notes: Version 3: - separated from qemu: RDMA

[libvirt] [PATCH 5/6] qemu: RDMA migration support

2014-09-17 Thread Jiri Denemark
From: Michael R. Hines mrhi...@us.ibm.com This patch adds support for RDMA protocol in migration URIs. USAGE: $ virsh migrate --live --migrateuri rdma://hostname domain qemu+ssh://hostname/system Since libvirt runs QEMU in a pretty restricted environment, several files needs to be added to

[libvirt] [PATCH 4/6] qemu: Add RDMA migration capabilities

2014-09-17 Thread Jiri Denemark
Signed-off-by: Jiri Denemark jdene...@redhat.com --- Notes: Version 3: - separated from qemu: RDMA migration support - switched from version based to feature based probing - fixed existing capabilities tests - added new capabilities test for QEMU 2.1.1 which supports

[libvirt] [PATCH 1/6] qemu: Expose additional migration statistics

2014-09-17 Thread Jiri Denemark
From: Michael R. Hines mrhi...@us.ibm.com RDMA migration uses the 'setup' state in QEMU to optionally lock all memory before the migration starts. The total time spent in this state is exposed as VIR_DOMAIN_JOB_SETUP_TIME. Additionally, QEMU also exports migration throughput (mbps) for both

Re: [libvirt] [PATCH 0/6] RDMA migration support

2014-09-17 Thread Jiri Denemark
On Wed, Sep 17, 2014 at 16:53:02 +0200, Jiri Denemark wrote: This is a modified version of RDMA migration patches sent back in January by Michael R. Hines. See individual patches for (numerous) changes since v2. Jiri Denemark (3): qemu: Fix old tcp:host URIs more cleanly qemu: Prepare

Re: [libvirt] [PATCH 4/5] conf: add options for disabling segment offloading

2014-09-17 Thread Daniel P. Berrange
On Mon, Sep 15, 2014 at 04:30:46PM -0600, Eric Blake wrote: On 09/11/2014 05:43 AM, Ján Tomko wrote: Add the following attributes: csum, gso, guest_tso4, guest_tso6, guest_ecn to the driver element of network interface which control the virtio-net device properties of the same names.

Re: [libvirt] [PATCH v2] rpc: make daemon spawning a bit more intelligent

2014-09-17 Thread Martin Kletzander
On Wed, Sep 17, 2014 at 10:59:21AM -0400, John Ferlan wrote: On 09/17/2014 10:00 AM, Martin Kletzander wrote: On Tue, Sep 16, 2014 at 10:22:53AM -0400, John Ferlan wrote: On 09/16/2014 05:16 AM, Martin Kletzander wrote: This way it behaves more like the daemon itself does (acquiring a

Re: [libvirt] [PATCH v2 0/2] Expose UEFI binary path

2014-09-17 Thread Eric Blake
On 09/17/2014 06:15 AM, Michal Privoznik wrote: This is practically reworked v1 from Cole. Cole Robinson (1): domaincaps: Expose UEFI binary path, if it exists Michal Privoznik (1): qemu_capabilities: Change virQEMUCapsFillDomainCaps signature docs/formatdomaincaps.html.in

[libvirt] [PATCH 0/5] Refactor save image opening and add restore hook

2014-09-17 Thread Peter Krempa
This series refactors (splits) the save image open function into separate chunks and introduces a filter-hook that is called when restoring a save image. Peter Krempa (5): qemu: save image: Split out user provided XML checker qemu: save image: Add possibility to return XML stored in the image

[libvirt] [PATCH 3/5] qemu: save image: Split out new definition check/update

2014-09-17 Thread Peter Krempa
Split out the call to the update method only to places where it is actually used rather than having a mega-method that does all the stuff. --- src/qemu/qemu_driver.c | 26 +++--- 1 file changed, 15 insertions(+), 11 deletions(-) diff --git a/src/qemu/qemu_driver.c

[libvirt] [PATCH 2/5] qemu: save image: Add possibility to return XML stored in the image

2014-09-17 Thread Peter Krempa
Add a new parameter that will allow to return the XML stored in the save image for further manipulation and adjust the callers. This option will be used in later patches. --- src/qemu/qemu_driver.c | 18 +++--- 1 file changed, 11 insertions(+), 7 deletions(-) diff --git

[libvirt] [PATCH 1/5] qemu: save image: Split out user provided XML checker

2014-09-17 Thread Peter Krempa
Extract code used to check save image XMLs provided by users to separate use. --- src/qemu/qemu_driver.c | 100 - 1 file changed, 66 insertions(+), 34 deletions(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index 15ad64d..e41a08e

[libvirt] [PATCH 4/5] qemu: save image: Split out checks done only when editing the save img

2014-09-17 Thread Peter Krempa
Move them to the single corresponding function rather than having them in the common chunk of code. --- src/qemu/qemu_driver.c | 76 +++--- 1 file changed, 41 insertions(+), 35 deletions(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c

[libvirt] [PATCH 5/5] qemu: hook: Provide hook when restoring a domain save image

2014-09-17 Thread Peter Krempa
--- docs/hooks.html.in | 11 src/qemu/qemu_driver.c | 69 +- src/util/virhook.c | 3 ++- src/util/virhook.h | 1 + 4 files changed, 76 insertions(+), 8 deletions(-) diff --git a/docs/hooks.html.in b/docs/hooks.html.in index

Re: [libvirt] [PATCH 4/5] conf: add options for disabling segment offloading

2014-09-17 Thread Eric Blake
On 09/17/2014 08:57 AM, Daniel P. Berrange wrote: + blt;driver csum='off' gso='off' guest_tso4='off' guest_tso6='off' guest_ecn='off'/gt;/b +lt;/interfacegt; Are we stuck with names with underscores in our XML? I'm still not sure if we've come up with the best naming for exposing

[libvirt] [PATCH] domaincapstest: Run cleanly on systems missing OVMF firmware

2014-09-17 Thread Michal Privoznik
As of f05b6a918e28 the test produces the list of paths that can be passed to loader/ and libvirt knows about them. However, during the process of generating the list the paths are checked for their presence. This may produce different results on different systems. Therefore, the path - if missing

Re: [libvirt] [PATCH 4/5] conf: add options for disabling segment offloading

2014-09-17 Thread Ján Tomko
On 09/17/2014 04:57 PM, Daniel P. Berrange wrote: On Mon, Sep 15, 2014 at 04:30:46PM -0600, Eric Blake wrote: On 09/11/2014 05:43 AM, Ján Tomko wrote: Add the following attributes: csum, gso, guest_tso4, guest_tso6, guest_ecn to the driver element of network interface which control the

Re: [libvirt] [PATCH] domaincapstest: Run cleanly on systems missing OVMF firmware

2014-09-17 Thread Martin Kletzander
On Wed, Sep 17, 2014 at 05:32:03PM +0200, Michal Privoznik wrote: As of f05b6a918e28 the test produces the list of paths that can be passed to loader/ and libvirt knows about them. However, during the process of generating the list the paths are checked for their presence. This may produce

Re: [libvirt] [PATCH] domaincapstest: Run cleanly on systems missing OVMF firmware

2014-09-17 Thread Michal Privoznik
On 17.09.2014 17:40, Martin Kletzander wrote: On Wed, Sep 17, 2014 at 05:32:03PM +0200, Michal Privoznik wrote: As of f05b6a918e28 the test produces the list of paths that can be passed to loader/ and libvirt knows about them. However, during the process of generating the list the paths are

Re: [libvirt] [PATCH v2 0/2] Use huge pages on UMA guests widely

2014-09-17 Thread Martin Kletzander
On Mon, Sep 15, 2014 at 01:48:05PM +0200, Michal Privoznik wrote: *** BLURB HERE *** Michal Privoznik (2): conf: Disallow nonexistent NUMA nodes for hugepages qemu: Honor hugepages for UMA domains src/qemu/qemu_command.c| 49 --

Re: [libvirt] [PATCH 4/5] conf: add options for disabling segment offloading

2014-09-17 Thread Daniel P. Berrange
On Wed, Sep 17, 2014 at 05:36:18PM +0200, Ján Tomko wrote: On 09/17/2014 04:57 PM, Daniel P. Berrange wrote: On Mon, Sep 15, 2014 at 04:30:46PM -0600, Eric Blake wrote: On 09/11/2014 05:43 AM, Ján Tomko wrote: Add the following attributes: csum, gso, guest_tso4, guest_tso6, guest_ecn to

Re: [libvirt] [PATCH 4/5] conf: add options for disabling segment offloading

2014-09-17 Thread Eric Blake
On 09/17/2014 09:52 AM, Daniel P. Berrange wrote: Ah, so this is why you shouldn't take the precise solution requested in a bug too literally, and instead look at the general picture :-) So QEMU exposes alot of stuff: $ qemu-kvm -device virtio-net,? virtio-net-pci.guest_tso4=on/off

Re: [libvirt] [PATCHv6 08/11] qemu: bulk stats: add block allocation information

2014-09-17 Thread Peter Krempa
On 09/17/14 00:37, Eric Blake wrote: On 09/15/2014 09:42 AM, Peter Krempa wrote: From: Francesco Romani from...@redhat.com Management software wants to be able to allocate disk space on demand. To support this they need keep track of the space occupation of the block device. This

[libvirt] [PATCH] CVE-2014-3633: qemu: blkiotune: Use correct definition when looking up disk

2014-09-17 Thread Peter Krempa
Live definition was used to look up the disk index while persistent one was indexed leading to a crash in qemuDomainGetBlockIoTune. Use the correct def and report a nice error. Unfortunately it's accessible via read-only connection. Introduced in: eca96694a7f992be633d48d5ca03cedc9bbc3c9aa

Re: [libvirt] [PATCH] CVE-2014-3633: qemu: blkiotune: Use correct definition when looking up disk

2014-09-17 Thread Eric Blake
On 09/17/2014 10:25 AM, Peter Krempa wrote: Live definition was used to look up the disk index while persistent one was indexed leading to a crash in qemuDomainGetBlockIoTune. Use the correct def and report a nice error. Unfortunately it's accessible via read-only connection. Mitigation -

Re: [libvirt] [PATCH] CVE-2014-3633: qemu: blkiotune: Use correct definition when looking up disk

2014-09-17 Thread Peter Krempa
On 09/17/14 18:31, Eric Blake wrote: On 09/17/2014 10:25 AM, Peter Krempa wrote: Live definition was used to look up the disk index while persistent one was indexed leading to a crash in qemuDomainGetBlockIoTune. Use the correct def and report a nice error. Unfortunately it's accessible via

Re: [libvirt] [PATCH 2/3] maint: clean up _virDomainBlockStats

2014-09-17 Thread Eric Blake
On 09/16/2014 07:19 AM, James wrote: I clean up all _virDomainBlockStats. Signed-off-by: James james.wangyu...@huawei.com Signed-off-by: Wang Rui moon.wang...@huawei.com --- src/driver.h | 2 +- src/libvirt.c| 2 +- src/lxc/lxc_driver.c | 2 +-

Re: [libvirt] [PATCH 3/3] maint: clean up _virDomainMemoryStat

2014-09-17 Thread Eric Blake
On 09/16/2014 07:19 AM, James wrote: I clean up all _virDomainMemoryStat. Signed-off-by: James james.wangyu...@huawei.com Signed-off-by: Wang Rui moon.wang...@huawei.com --- daemon/remote.c | 2 +- src/driver.h | 2 +- src/lxc/lxc_driver.c | 2 +-

[libvirt] [PATCH] qemu: Don't fail qemuProcessAttach for IOThreads if no JSON

2014-09-17 Thread John Ferlan
While doing some investigation for another bug I found that I could not qemu-attach to the process and got the following: error: Operation not supported: JSON monitor is required while running thru qemuProcessAttach. Since we can only get the data using the JSON parser and if the guest to be

Re: [libvirt] [PATCH 6/6] qemu: Improve check for local storage

2014-09-17 Thread Peter Krempa
On 09/17/14 00:29, John Ferlan wrote: On 09/11/2014 01:47 PM, Peter Krempa wrote: Now that we have a simple function to check locality of storage, reuse it in qemuDomainCheckDiskPresence(). Also reuse check for empty storage source. --- src/qemu/qemu_domain.c | 8 +++- 1 file

Re: [libvirt] [PATCH 0/3] Add rawio for hostdev

2014-09-17 Thread John Ferlan
On 09/09/2014 07:40 PM, John Ferlan wrote: The rawio setting for a device.../ disk.../ lun isn't duplicated in the scsi_host hostdev device for a lun. Rather than requiring some disk in the disk list to add the rawio, add the rawio property to the scsi_host hostdev lun. John Ferlan (3):

Re: [libvirt] [PATCH] qemu: fix crash with shared disks

2014-09-17 Thread John Ferlan
On 09/17/2014 06:45 AM, Ján Tomko wrote: Commit f36a94f introduced a double free on all success paths in qemuSharedDeviceEntryInsert. Only call qemuSharedDeviceEntryFree on the error path and set entry to NULL before jumping there if the entry already is in the hash table.

[libvirt] retiring v0.9.6-maint

2014-09-17 Thread Eric Blake
Any objections to retiring the v0.9.6-maint branch? After all, we have already retired the v0.9.11-maint branch (http://libvirt.org/git/?p=libvirt.git;a=commit;h=cd0d348ed), and the only activity on v0.9.6-maint since 0.9.6.4 was released in January 2013 was the backport of a single CVE fix. The

[libvirt] [PATCH-RFC-V2] qemu: Add network bandwidth setting for ethernet interfaces

2014-09-17 Thread Anirban Chakraborty
V2: Consolidate calls to virNetDevBandwidthSet Clear bandwidth settings when the interface is detached or domain destroyed V1: Ethernet interfaces in libvirt currently do not support bandwidth setting. For example, following xml file for an interface will not apply these settings to corresponding