In nodeGetFreePages, if startCell is given by '0',
and the max node number is '0' too. The for-loop
wouldn't be executed.
So convert it to while-loop.
Before:
> virsh freepages --cellno 0 --pagesize 4
error: internal error: no suitable info found
After:
> virsh freepages --cellno 0 --pagesize 4
4
The patch
http://libvirt.org/git/?p=libvirt.git;a=commitdiff;h=de0aeafe9ce3eb414c8b5d3aa8995d776a2952de
removes invtsc flag in the host-model CPU.
I'm wondering, will it be better to pass args "migratable=no/yes" to qemu, and
let qemu complete the
remaining work? As that qemu has checked whether
On Tue, 2014-09-23 at 14:42 +0200, Michal Privoznik wrote:
> On 23.09.2014 11:34, Chen Fan wrote:
> > use virDomainNumatuneNodeSetIsAvailable() to verify momory.nodeset
> > whether is out of range. and move up the verification.
> >
> > Signed-off-by: Chen Fan
> > ---
> > src/conf/numatune_conf.
On Tue, 2014-09-23 at 14:41 +0200, Michal Privoznik wrote:
> On 23.09.2014 11:34, Chen Fan wrote:
> > For memnode in numatune element, the range of attribute 'nodeset'
> > was not validated. on my host maxnodes was 1, but when setting nodeset
> > to '0-2' or more, guest also started succuss. there
> -Original Message-
> From: Michal Privoznik [mailto:mpriv...@redhat.com]
>
> On 23.09.2014 05:40, Chen Hanxiao wrote:
> > We don't accept any other values except '0'.
> >
> > Signed-off-by: Chen Hanxiao
> > ---
> > docs/formatdomain.html.in | 2 +-
> > 1 file changed, 1 insertion(+
On 09/18/2014 10:15 AM, Ján Tomko wrote:
> Format the segment offloading options specified by
>
>
>
>
> on virtio-net command line.
> ---
> src/qemu/qemu_command.c| 40
> ++
> .../qemuxml2argv-net-virtio-disable-offloads.args | 10 ++
On 09/18/2014 10:15 AM, Ján Tomko wrote:
> Add options for tuning segment offloading:
>
>ecn='off' ufo='off'/>
>
>
> which control the respective host_ and guest_ properties
> of the virtio-net device.
> ---
> docs/formatdomain.html.in | 24 ++-
> docs/
On 09/23/2014 03:26 PM, Pavel Hrdina wrote:
>>> +
>>> +VIR_DEBUG("Relaying domain tunable event %s %d, callback %d",
>>> + dom->name, dom->id, callback->callbackID);
>>> +
>>
>> Might also be nice to log "%p %n", params, nparams
>
> Yes, that would be probably nice, but since I'v
On 09/23/2014 10:08 PM, Eric Blake wrote:
On 09/23/2014 12:46 PM, Pavel Hrdina wrote:
This new event will use typedParameters to expose what has been actually
updated and the reason is that we can in the future extend any tunable
values or add new tunable values. With typedParameters we don't ha
Eric Blake wrote:
> On 09/23/2014 11:53 AM, Jim Fehlig wrote:
>
>> When libvirt-guests is configured to start guests on host
>> boot, it is possible for guests start and read the host
>> clock before it is synchronized. Services such as
>> libvirt-guests that require correct time should use the
On 09/18/2014 05:54 AM, Peter Krempa wrote:
> Request erroring out from the backing chain traveller and drop qemu's
> internal backing chain integrity tester.
>
> The backin chain traveller reports errors by itself with possibly more
s/backin/backing
> detail than qemuDiskChainCheckBroken ever
On 09/18/2014 05:54 AM, Peter Krempa wrote:
> Report also the name of the parent file and uid/gid used to access it to
> help debugging broken storage configurations.
> ---
> src/storage/storage_driver.c | 20 +++-
> 1 file changed, 15 insertions(+), 5 deletions(-)
>
ACK
John
On 09/18/2014 05:54 AM, Peter Krempa wrote:
> Reuse virStorageSourceIsEmpty and rename "force" argument to
> "force_probe".
> ---
> src/qemu/qemu_domain.c | 8 +++-
> src/qemu/qemu_domain.h | 2 +-
> 2 files changed, 4 insertions(+), 6 deletions(-)
>
ACK - thanks :-)
John
--
libvir-list
On 09/18/2014 05:54 AM, Peter Krempa wrote:
> Add a new parameter to virStorageFileGetMetadata that will break the
> backing chain detection process and report useful error message rather
> than having to use virStorageFileChainGetBroken.
>
> This patch just introduces the option, usage will be
On 09/23/2014 12:46 PM, Pavel Hrdina wrote:
> This new event will use typedParameters to expose what has been actually
> updated and the reason is that we can in the future extend any tunable
> values or add new tunable values. With typedParameters we don't have to
> worry about creating some other
On 09/23/2014 09:37 PM, John Ferlan wrote:
On 09/23/2014 02:47 PM, Pavel Hrdina wrote:
Now we have universal tunable event so we can use it for reporting
changes to user. The cputune values will be prefixed with "cputune" to
distinguish it from other tunable events.
Signed-off-by: Pavel Hrdin
On 09/23/2014 09:36 PM, John Ferlan wrote:
On 09/23/2014 02:46 PM, Pavel Hrdina wrote:
This new event will use typedParameters to expose what has been actually
updated and the reason is that we can in the future extend any tunable
values or add new tunable values. With typedParameters we don't
On 09/18/2014 02:24 AM, Michal Privoznik wrote:
> A long time ago in a galaxy far, far away it has been decided
> that libvirt will manage not only domains but host as well. And
> with my latest work on qemu driver supporting huge pages, we miss
> the cherry on top: an API to allocate huge pages on
On 09/23/2014 02:47 PM, Pavel Hrdina wrote:
> Now we have universal tunable event so we can use it for reporting
> changes to user. The cputune values will be prefixed with "cputune" to
> distinguish it from other tunable events.
>
> Signed-off-by: Pavel Hrdina
> ---
>
> since v4:
> - added ma
On 09/23/2014 02:46 PM, Pavel Hrdina wrote:
> This new event will use typedParameters to expose what has been actually
> updated and the reason is that we can in the future extend any tunable
> values or add new tunable values. With typedParameters we don't have to
> worry about creating some oth
On 09/23/2014 11:53 AM, Jim Fehlig wrote:
> When libvirt-guests is configured to start guests on host
> boot, it is possible for guests start and read the host
> clock before it is synchronized. Services such as
> libvirt-guests that require correct time should use the
> Special Passive System Uni
This new event will use typedParameters to expose what has been actually
updated and the reason is that we can in the future extend any tunable
values or add new tunable values. With typedParameters we don't have to
worry about creating some other events, we will just use this universal
event to in
Now we have universal tunable event so we can use it for reporting
changes to user. The cputune values will be prefixed with "cputune" to
distinguish it from other tunable events.
Signed-off-by: Pavel Hrdina
---
since v4:
- added macro definitions for cputune typedParameters fileds
include/lib
When libvirt-guests is configured to start guests on host
boot, it is possible for guests start and read the host
clock before it is synchronized. Services such as
libvirt-guests that require correct time should use the
Special Passive System Unit time-sync.target
http://www.freedesktop.org/softw
Michal Privoznik wrote:
> On 23.09.2014 08:06, Martin Kletzander wrote:
>> On Mon, Sep 22, 2014 at 04:50:33PM -0600, Jim Fehlig wrote:
>>> Michal Privoznik wrote:
On 20.09.2014 01:36, Jim Fehlig wrote:
> Martin Kletzander wrote:
>> Unfortunately I'm not very familiar with systemd files
Martin Kletzander wrote:
> On Mon, Sep 22, 2014 at 04:50:33PM -0600, Jim Fehlig wrote:
>> Michal Privoznik wrote:
>>> On 20.09.2014 01:36, Jim Fehlig wrote:
Martin Kletzander wrote:
> Unfortunately I'm not very familiar with systemd files, but my guess
> is that After=ntp-wait.service
Move the CPU mode/model handling to its own function. This is just
code movement and re-indentation.
---
src/qemu/qemu_command.c | 226 ++--
1 file changed, 122 insertions(+), 104 deletions(-)
diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command
Added a new parameter to the `virsh migrate` command to switch to
post-copy migration after a given timeout.
Signed-off-by: Cristian Klein
---
tools/virsh-domain.c | 72 ++--
tools/virsh.pod | 5
2 files changed, 75 insertions(+), 2 dele
Right now when building the qemu command line, we try to do various
unconditional validations of the guest CPU against the host CPU. However
this checks are overly applied. The only time we should use the checks
are:
- The user requests host-model/host-passthrough, or
- When KVM is requsted. CPU
Signed-off-by: Cristian Klein
---
src/qemu/qemu_migration.c| 1 +
src/qemu/qemu_monitor.c | 2 +-
src/qemu/qemu_monitor.h | 1 +
src/qemu/qemu_monitor_json.c | 3 ++-
src/qemu/qemu_monitor_text.c | 3 ++-
5 files changed, 7 insertions(+), 3 deletions(-)
diff --git a/src/qemu/qemu_m
The user first start migration using the `VIR_MIGRATE_POSTCOPY` flag,
then calls `virDomainMigrateStartPostCopy` asynchronously to switch from
pre-copy to post-copy.
Signed-off-by: Cristian Klein
---
include/libvirt/libvirt.h.in | 2 ++
src/driver.h | 4
src/libvirt.c
Signed-off-by: Cristian Klein
---
src/qemu/qemu_driver.c | 44
src/qemu/qemu_monitor.c | 19 +++
src/qemu/qemu_monitor.h | 2 ++
src/qemu/qemu_monitor_json.c | 18 ++
src/qemu/qemu_monitor_json.h | 1 +
Patch 1 is a cleanup, just code movement.
Patch 2 has the goods, details in the commit message
Cole Robinson (2):
qemu_command: Split qemuBuildCpuArgStr
qemu: Don't compare CPU against host for TCG
src/qemu/qemu_command.c| 202 -
.../qemuxml2ar
Signed-off-by: Cristian Klein
---
src/remote/remote_driver.c | 1 +
src/remote/remote_protocol.x | 12 +++-
2 files changed, 12 insertions(+), 1 deletion(-)
diff --git a/src/remote/remote_driver.c b/src/remote/remote_driver.c
index 75a3a7b..9a6a974 100644
--- a/src/remote/remote_drive
Added a new `libvirt` migration flag `VIR_MIGRATE_POSTCOPY` and the
necessary code to pass this flag to qemu as migration capability.
Signed-off-by: Cristian Klein
---
include/libvirt/libvirt.h.in | 1 +
src/libvirt.c| 7 +++
src/qemu/qemu_migration.c| 43 ++
Qemu currently implements pre-copy live migration. VM memory pages are
first copied from the source hypervisor to the destination, potentially
multiple times as pages get dirtied during transfer, then VCPU state
is migrated. Unfortunately, if the VM dirties memory faster than the
network bandwidth,
Hello
I apologize in advance for my English.
I compiled the new version of libvirt 1.2.8 on an environment Development
Linux from Scratch with the following configure:
configure: Configuration summary
configure: =
configure:
configure: Drivers
configure:
configure: Xen: n
On 09/18/2014 10:24 AM, Michal Privoznik wrote:
> A long time ago in a galaxy far, far away it has been decided
> that libvirt will manage not only domains but host as well. And
> with my latest work on qemu driver supporting huge pages, we miss
> the cherry on top: an API to allocate huge pages on
On Tue, Sep 23, 2014 at 09:35:56 -0400, John Ferlan wrote:
>
>
> On 09/23/2014 09:32 AM, Jiri Denemark wrote:
> > Signed-off-by: Jiri Denemark
> > ---
> > src/qemu/qemu_migration.c | 5 +++--
> > 1 file changed, 3 insertions(+), 2 deletions(-)
> >
>
> ACK
Pushed, thanks.
Jirka
--
libvir-li
On 09/23/2014 09:32 AM, Jiri Denemark wrote:
> Signed-off-by: Jiri Denemark
> ---
> src/qemu/qemu_migration.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
ACK
John
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Signed-off-by: Jiri Denemark
---
src/qemu/qemu_migration.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/src/qemu/qemu_migration.c b/src/qemu/qemu_migration.c
index 44cb826..6b38592 100644
--- a/src/qemu/qemu_migration.c
+++ b/src/qemu/qemu_migration.c
@@ -3792,13 +3792
On 23.09.2014 05:40, Chen Hanxiao wrote:
We don't accept any other values except '0'.
Signed-off-by: Chen Hanxiao
---
docs/formatdomain.html.in | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/docs/formatdomain.html.in b/docs/formatdomain.html.in
index eefdd5e..bb72452 100
On 23.09.2014 11:34, Chen Fan wrote:
For memnode in numatune element, the range of attribute 'nodeset'
was not validated. on my host maxnodes was 1, but when setting nodeset
to '0-2' or more, guest also started succuss. there probably was qemu's
bug too.
Signed-off-by: Chen Fan
---
src/conf/n
On 23.09.2014 11:34, Chen Fan wrote:
use virDomainNumatuneNodeSetIsAvailable() to verify momory.nodeset
whether is out of range. and move up the verification.
Signed-off-by: Chen Fan
---
src/conf/numatune_conf.c | 3 +++
src/util/virnuma.c | 15 ---
2 files changed, 3 ins
Detect if the the qemu binary currently in use suport the bps_max option and
thy firends,
If yes add it to the command, if not, just ignore the options.
Signed-off-by: Matthias Gatto
---
src/qemu/qemu_monitor_text.c | 76
1 file changed, 69 insertion
Add the new throttle options to virsh, and send them to libvirt.
Signed-off-by: Matthias Gatto
---
tools/virsh-domain.c | 119 +++
tools/virsh.pod | 11 -
2 files changed, 129 insertions(+), 1 deletion(-)
diff --git a/tools/virsh-domain.
Add defines for the news options total_bytes_sec_max, write_bytes_sec_max,
read_bytes_sec_max
total_iops_sec_max, write_iops_sec_max, read_iops_sec_max, size_iops_sec.
Modify the structure _virDomainBlockIoTuneInfo to support these options.
Change the initialization of the variable expectedInfo
Check the arability of the options with the current qemu binary, add them in
the varable opt if yes,
print a message if not.
Signed-off-by: Matthias Gatto
---
src/qemu/qemu_command.c | 49 +
1 file changed, 49 insertions(+)
diff --git a/src/qemu/
Add support for bps_max and friends in the driver part.
In the part checking if a qemu is running, check if the running binary support
bps_max,
if not print an error message, if yes add it to "info" variable
Signed-off-by: Matthias Gatto
---
src/qemu/qemu_driver.c | 162 ++
This series of patches add support for bps_max, bps_rd_max, bps_wr_max,
bps_max, bps_rd_max, bps_wr_max, and iops_size in the functions
qemuDomainSetBlockIoTune and qemuDomainGetBlockIoTune.
The last patch add support for these parameters to the virsh blkdeviotune
command.
v2: spellfix
v3: Mer
Add a value in the enum virQEMUCapsFlags for the qemu capability.
Set it with virQEMUCapsSet if the binary suport bps_max and they friends.
Signed-off-by: Matthias Gatto
---
src/qemu/qemu_capabilities.c | 4
src/qemu/qemu_capabilities.h | 1 +
2 files changed, 5 insertions(+)
diff --git a/
Detect if the the qemu binary currently in use suport the bps_max option,
If yes add it to the command, if not, just ignore the options.
Signed-off-by: Matthias Gatto
---
src/qemu/qemu_monitor_json.c | 59 +++-
1 file changed, 48 insertions(+), 11 deletion
On 19.09.2014 18:14, Serge Hallyn wrote:
The security_driver line in /etc/libvirt/qemu.conf is best-effort - if
selinux is not available on the host, then 'none' will be used.
The security_driver line in /etc/libvirt/lxc.conf doesn't behave the
same way - if apparmor is specified but policies ar
On 22.09.2014 16:34, Martin Kletzander wrote:
Signed-off-by: Martin Kletzander
---
src/conf/domain_conf.c | 11 +--
1 file changed, 9 insertions(+), 2 deletions(-)
diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
index bb4a4cb..9cc118c 100644
--- a/src/conf/domain_conf.c
On 09/23/2014 07:12 AM, Michal Privoznik wrote:
> In the function at one place we check if def->cpu is NULL prior
> to accessing def->cpu->ncells. Then, later in the code,
> def->cpu->ncells is accessed directly, without the check. This
> makes coverity unhappy, because the first check makes it t
On 09/23/2014 05:13 AM, Pavel Hrdina wrote:
> On 09/22/2014 05:50 PM, John Ferlan wrote:
>>
>>
>> On 09/18/2014 04:39 AM, Pavel Hrdina wrote:
>>> This new event will use typedParameters to expose what has been actually
>>> updated and the reason is that we can in the future extend any tunable
>>>
In the function at one place we check if def->cpu is NULL prior
to accessing def->cpu->ncells. Then, later in the code,
def->cpu->ncells is accessed directly, without the check. This
makes coverity unhappy, because the first check makes it think
def->cpu can be NULL. However, the function is not ca
On 09/17/2014 10:53 AM, Jiri Denemark wrote:
> From: "Michael R. Hines"
>
> This patch adds support for RDMA protocol in migration URIs.
>
> USAGE: $ virsh migrate --live --migrateuri rdma://hostname domain
> qemu+ssh://hostname/system
>
> Since libvirt runs QEMU in a pretty restricted envir
On 09/22/2014 05:54 PM, John Ferlan wrote:
On 09/18/2014 04:39 AM, Pavel Hrdina wrote:
Now we have universal tunable event so we can use it for reporting
changes to user. The cputune values will be prefixed with "cputune" to
distinguish it from other tunable events.
Signed-off-by: Pavel Hrdin
It's better to use a macro instead of if-else construct.
Signed-off-by: Michal Privoznik
---
Pushed under trivial rule.
src/nodeinfo.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/src/nodeinfo.c b/src/nodeinfo.c
index 1b4a8d7..2459922 100644
--- a/src/nodeinfo.c
+++ b
for memnode.nodeset in numatune, when setting it more
than the host nodes, it should fail.
Chen Fan (2):
numatune: add check for memnode.nodeset range
numatune: move up verification codes in virNumaSetupMemoryPolicy
src/conf/numatune_conf.c | 32
src/conf/num
use virDomainNumatuneNodeSetIsAvailable() to verify momory.nodeset
whether is out of range. and move up the verification.
Signed-off-by: Chen Fan
---
src/conf/numatune_conf.c | 3 +++
src/util/virnuma.c | 15 ---
2 files changed, 3 insertions(+), 15 deletions(-)
diff --git a/
For memnode in numatune element, the range of attribute 'nodeset'
was not validated. on my host maxnodes was 1, but when setting nodeset
to '0-2' or more, guest also started succuss. there probably was qemu's
bug too.
Signed-off-by: Chen Fan
---
src/conf/numatune_conf.c | 29
On 09/22/2014 05:50 PM, John Ferlan wrote:
On 09/18/2014 04:39 AM, Pavel Hrdina wrote:
This new event will use typedParameters to expose what has been actually
updated and the reason is that we can in the future extend any tunable
values or add new tunable values. With typedParameters we don't
On 22.09.2014 16:02, Gerald Palmer wrote:
Description of problem: Fail to compile
Version-Release number of selected component (if applicable):
Version 1.0.3 through 1.1.1
How reproducible:
Steps to Reproduce:
1./configure --prefix=/usr --localstatedir=/var --sysconfdir=/etc
2.make
Actual
On some systems (using libtirpc instead of glibc's
implementation), xdr_uint64_t exists rather under different name:
xdr_u_int64_t. This makes compilation fail then:
libvirt_lxc-lxc_monitor_protocol.o: In function `xdr_virLXCMonitorInitEventMsg':
/usr/local/src/libvirt/libvirt-1.1.1/src/./lxc/lxc_
On 09/22/2014 05:47 PM, John Ferlan wrote:
On 09/18/2014 04:39 AM, Pavel Hrdina wrote:
Cleanup virDomanDef structure from other nested structure and create
separate type definition for them.
Fix a typo in virDomainHugePage.
Signed-off-by: Pavel Hrdina
---
src/conf/domain_conf.h | 102
On 09/19/2014 06:47 PM, Kevin Wolf wrote:> Am 16.09.2014 um 14:59 hat Paolo
Bonzini geschrieben:
>> Il 16/09/2014 14:52, Kevin Wolf ha scritto:
>>> Yes, that's true. We can't fix this problem in qcow2, though, because
>>> it's a more general one. I think we must make sure that
>>> bdrv_invalidate
On 22.09.2014 12:14, Jincheng Miao wrote:
Jincheng Miao (3):
virsh-host: fix pagesize unit of freepages
nodeinfo: report error when given node is out of range
Fix typo of virNodeGetFreePages comment
src/libvirt.c | 2 +-
src/nodeinfo.c | 24 +---
tools
On 22.09.2014 12:14, Jincheng Miao wrote:
Signed-off-by: Jincheng Miao
---
src/libvirt.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/libvirt.c b/src/libvirt.c
index 7c63825..aa83365 100644
--- a/src/libvirt.c
+++ b/src/libvirt.c
@@ -21307,7 +21307,7 @@ virDomainSet
On 22.09.2014 12:14, Jincheng Miao wrote:
The unit of '--pagesize' of freepages is kibibytes.
https://bugzilla.redhat.com/show_bug.cgi?id=1145048
Signed-off-by: Jincheng Miao
---
tools/virsh-host.c | 27 ++-
1 file changed, 18 insertions(+), 9 deletions(-)
diff --gi
On 22.09.2014 12:14, Jincheng Miao wrote:
https://bugzilla.redhat.com/show_bug.cgi?id=1145050
Signed-off-by: Jincheng Miao
---
src/nodeinfo.c | 24 +---
1 file changed, 21 insertions(+), 3 deletions(-)
diff --git a/src/nodeinfo.c b/src/nodeinfo.c
index af23b8b..1728891 1
On Tue, Sep 23, 2014 at 09:59:17AM +0200, Markus Armbruster wrote:
> "Michael S. Tsirkin" writes:
>
> > On Mon, Sep 22, 2014 at 05:32:16PM +0200, Markus Armbruster wrote:
> >> "Michael S. Tsirkin" writes:
> >>
> >> > On Sun, Sep 21, 2014 at 03:38:59PM +0100, Alex Bligh wrote:
> >> >> Add a conf
"Michael S. Tsirkin" writes:
> On Mon, Sep 22, 2014 at 05:32:16PM +0200, Markus Armbruster wrote:
>> "Michael S. Tsirkin" writes:
>>
>> > On Sun, Sep 21, 2014 at 03:38:59PM +0100, Alex Bligh wrote:
>> >> Add a configure option --enable-pc-1-0-qemu-kvm and the
>> >> corresponding --disable-pc-1-
On 23.09.2014 08:06, Martin Kletzander wrote:
On Mon, Sep 22, 2014 at 04:50:33PM -0600, Jim Fehlig wrote:
Michal Privoznik wrote:
On 20.09.2014 01:36, Jim Fehlig wrote:
Martin Kletzander wrote:
Unfortunately I'm not very familiar with systemd files, but my guess
is that After=ntp-wait.service
75 matches
Mail list logo
