Re: [libvirt] [RFC PATCH] qcow2: Fix race in cache invalidation

2014-09-24 Thread Alexey Kardashevskiy
On 09/23/2014 06:47 PM, Alexey Kardashevskiy wrote: On 09/19/2014 06:47 PM, Kevin Wolf wrote: Am 16.09.2014 um 14:59 hat Paolo Bonzini geschrieben: Il 16/09/2014 14:52, Kevin Wolf ha scritto: Yes, that's true. We can't fix this problem in qcow2, though, because it's a more general one. I

Re: [libvirt] [PATCH v5 2/4] event: introduce new event for tunable values

2014-09-24 Thread Pavel Hrdina
On 09/23/2014 11:50 PM, Eric Blake wrote: On 09/23/2014 03:26 PM, Pavel Hrdina wrote: + +VIR_DEBUG(Relaying domain tunable event %s %d, callback %d, + dom-name, dom-id, callback-callbackID); + Might also be nice to log %p %n, params, nparams Yes, that would be probably

[libvirt] [PATCH] tunable_event: extend debug message and tweak limit for remote message

2014-09-24 Thread Pavel Hrdina
It would be nice to also print a params pointer and number of params in the debug message and the previous limit for number of params in the rpc message was too large. The 2048 params will be enough for future events. Signed-off-by: Pavel Hrdina phrd...@redhat.com --- daemon/remote.c

Re: [libvirt] [Qemu-devel] [PATCH v4] Add machine parameter qemu-kvm-migration for live migrate compatibility with qemu-kvm

2014-09-24 Thread Markus Armbruster
Alex Bligh a...@alex.org.uk writes: This patch series adds inbound migrate capability from qemu-kvm version 1.0. The main ideas are those set out in Cole Robinson's patch here: http://pkgs.fedoraproject.org/cgit/qemu.git/tree/0001-Fix-migration-from-qemu-kvm.patch?h=f20 however, rather than

[libvirt] [PATCH] blkdeviotune: trigger tunable event for blkdeviotune updates

2014-09-24 Thread Pavel Hrdina
With the blkdeviotune event this patch also fixes a bug that the updated live values weren't saved to the live XML so they won't survive restarting the libvirtd. Signed-off-by: Pavel Hrdina phrd...@redhat.com --- include/libvirt/libvirt.h.in | 56

Re: [libvirt] [PATCHv2 4/4] storage: Improve error message when traversing backing chains

2014-09-24 Thread Peter Krempa
On 09/23/14 22:35, John Ferlan wrote: On 09/18/2014 05:54 AM, Peter Krempa wrote: Report also the name of the parent file and uid/gid used to access it to help debugging broken storage configurations. --- src/storage/storage_driver.c | 20 +++- 1 file changed, 15

Re: [libvirt] [Qemu-devel] [PATCH v4] Add machine parameter qemu-kvm-migration for live migrate compatibility with qemu-kvm

2014-09-24 Thread Alex Bligh
Markus, On 24 Sep 2014, at 09:05, Markus Armbruster arm...@redhat.com wrote: Alex Bligh a...@alex.org.uk writes: This patch series adds inbound migrate capability from qemu-kvm version 1.0. The main ideas are those set out in Cole Robinson's patch here:

Re: [libvirt] [PATCH] Fix bug with loading bridge name for active domain during libvirtd start

2014-09-24 Thread Peter Krempa
On 09/18/14 15:31, Pavel Hrdina wrote: If you have a bridge network in running domain and libvirtd is restarted the information about host bridge interface is lost from live xml. Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1140085 Signed-off-by: Pavel Hrdina phrd...@redhat.com

[libvirt] [PATCH v2] Fix bug with loading bridge name for active domain during libvirtd start

2014-09-24 Thread Pavel Hrdina
If you have a bridge network in running domain and libvirtd is restarted the information about host bridge interface is lost from live xml. Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1140085 Signed-off-by: Pavel Hrdina phrd...@redhat.com --- changes in v2: - added error message if

Re: [libvirt] [PATCH v2] Fix bug with loading bridge name for active domain during libvirtd start

2014-09-24 Thread Peter Krempa
On 09/24/14 11:36, Pavel Hrdina wrote: If you have a bridge network in running domain and libvirtd is restarted the information about host bridge interface is lost from live xml. Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1140085 Signed-off-by: Pavel Hrdina phrd...@redhat.com

Re: [libvirt] [PATCH v2] Fix bug with loading bridge name for active domain during libvirtd start

2014-09-24 Thread Pavel Hrdina
On 09/24/2014 11:45 AM, Peter Krempa wrote: On 09/24/14 11:36, Pavel Hrdina wrote: If you have a bridge network in running domain and libvirtd is restarted the information about host bridge interface is lost from live xml. Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1140085

Re: [libvirt] [RFC PATCH] qcow2: Fix race in cache invalidation

2014-09-24 Thread Kevin Wolf
Am 23.09.2014 um 10:47 hat Alexey Kardashevskiy geschrieben: On 09/19/2014 06:47 PM, Kevin Wolf wrote: Am 16.09.2014 um 14:59 hat Paolo Bonzini geschrieben: Il 16/09/2014 14:52, Kevin Wolf ha scritto: Yes, that's true. We can't fix this problem in qcow2, though, because it's a more

[libvirt] [PATCH 2/6] network: set interface actual trustGuestRxFilters from network/portgroup

2014-09-24 Thread Laine Stump
As is done with other items such as vlan, virtualport, and bandwidth, set the actual trustGuestRxFilters value to be used by a domain interface according to a merge of the same attribute in the interface, portgroup, and network in use. the interface setting always takes precedence (if specified),

[libvirt] [PATCH 3/6] util: define virNetDevRxFilter and basic utility functions

2014-09-24 Thread Laine Stump
This same structure will be used to retrieve RX filter info for interfaces on the host via netlink messages, and RX filter info for interfaces on the guest via the qemu query-rx-filter command. --- src/libvirt_private.syms | 8 +++ src/util/virnetdev.c | 40

[libvirt] [PATCH 4/6] qemu: qemuMonitorQueryRxFilter - retrieve guest netdev rx-filter

2014-09-24 Thread Laine Stump
This function can be called at any time to get the current status of a guest's network device rx-filter. In particular it is useful to call after libvirt recieves a NIC_RX_FILTER_CHANGED event - this event only tells you that something has changed in the rx-filter, the details are retrieved with

[libvirt] [PATCH 5/6] qemu: setup infrastructure to handle NIC_RX_FILTER_CHANGED event

2014-09-24 Thread Laine Stump
NIC_RX_FILTER_CHANGED is sent by qemu any time a NIC driver in the guest modified the NIC's RX Filter (for example, if the MAC address of the NIC is changed by the guest). This patch doesn't do anything useful with that event; it just sets up all the plumbing to get news of the event into a

[libvirt] [PATCH 6/6] qemu: change macvtap device MAC address in response to NIC_RX_FILTER_CHANGED

2014-09-24 Thread Laine Stump
This patch fills in the functionality of processNicRxFilterChangedEvent(). It now checks if it is appropriate to respond to the NIC_RX_FILTER_CHANGED event (based on device type and configuration) and takes appropriate action. Currently it checks if the guest interface has been configured with

[libvirt] [PATCH 1/6] conf: add trustGuestRxFilters attribute to network and domain interface

2014-09-24 Thread Laine Stump
This new attribute will control whether or not libvirt will pay attention to guest notifications about changes to network device mac addresses and receive filters. The default for this is 'no' (for security reasons). If it is set to 'yes' *and* the specified device model and connection support it

[libvirt] [PATCH 0/6] handle NIC_RX_FILTER_CHANGED events from qemu

2014-09-24 Thread Laine Stump
These patches set up an event handler for qemu's NIC_RX_FILTER_CHANGED event, which is sent whenever a guest makes a change to a network device's unicast/multicast filter, vlan table, or MAC address. The handler checks if it is appropriate to respond to the NIC_RX_FILTER_CHANGED event (based on

Re: [libvirt] [PATCH 1/6] Added qemu postcopy-active migration status

2014-09-24 Thread Jiri Denemark
On Tue, Sep 23, 2014 at 16:09:56 +0200, Cristian Klein wrote: Signed-off-by: Cristian Klein cristian.kl...@cs.umu.se --- src/qemu/qemu_migration.c| 1 + src/qemu/qemu_monitor.c | 2 +- src/qemu/qemu_monitor.h | 1 + src/qemu/qemu_monitor_json.c | 3 ++-

Re: [libvirt] [PATCH] nodeinfo: fix nodeGetFreePages when max node is zero

2014-09-24 Thread Michal Privoznik
On 24.09.2014 07:45, Jincheng Miao wrote: In nodeGetFreePages, if startCell is given by '0', and the max node number is '0' too. The for-loop wouldn't be executed. So convert it to while-loop. Before: virsh freepages --cellno 0 --pagesize 4 error: internal error: no suitable info found

Re: [libvirt] Is seems necessary to pass migratable=no/yes to qemu.

2014-09-24 Thread Ján Tomko
On 09/24/2014 05:28 AM, zhang bo wrote: The patch http://libvirt.org/git/?p=libvirt.git;a=commitdiff;h=de0aeafe9ce3eb414c8b5d3aa8995d776a2952de removes invtsc flag in the host-model CPU. I'm wondering, will it be better to pass args migratable=no/yes to qemu, and let qemu complete the

Re: [libvirt] [PATCH] nodeinfo: fix nodeGetFreePages when max node is zero

2014-09-24 Thread Jincheng Miao
On 09/24/2014 07:40 PM, Michal Privoznik wrote: On 24.09.2014 07:45, Jincheng Miao wrote: In nodeGetFreePages, if startCell is given by '0', and the max node number is '0' too. The for-loop wouldn't be executed. So convert it to while-loop. Before: virsh freepages --cellno 0 --pagesize 4

[libvirt] [PATCH] Fix MinGW build

2014-09-24 Thread Pavel Hrdina
When building on mingw the format string for long long/unsigned long long have to be I64d/I64u instead of lld/llu. Signed-off-by: Pavel Hrdina phrd...@redhat.com --- I'm not sure if this is the right way to do it so sending it for review. examples/object-events/event-test.c | 13 +++--

Re: [libvirt] [PATCH 2/6] Added public API to enable post-copy migration

2014-09-24 Thread Jiri Denemark
On Tue, Sep 23, 2014 at 16:09:57 +0200, Cristian Klein wrote: Added a new `libvirt` migration flag `VIR_MIGRATE_POSTCOPY` and the necessary code to pass this flag to qemu as migration capability. Signed-off-by: Cristian Klein cristian.kl...@cs.umu.se --- include/libvirt/libvirt.h.in | 1 +

Re: [libvirt] [PATCH 3/6] Added new public API virDomainMigrateStartPostCopy

2014-09-24 Thread Jiri Denemark
On Tue, Sep 23, 2014 at 16:09:58 +0200, Cristian Klein wrote: The user first start migration using the `VIR_MIGRATE_POSTCOPY` flag, then calls `virDomainMigrateStartPostCopy` asynchronously to switch from pre-copy to post-copy. Signed-off-by: Cristian Klein cristian.kl...@cs.umu.se ---

Re: [libvirt] [PATCH] nodeinfo: fix nodeGetFreePages when max node is zero

2014-09-24 Thread Michal Privoznik
On 24.09.2014 14:00, Jincheng Miao wrote: On 09/24/2014 07:40 PM, Michal Privoznik wrote: On 24.09.2014 07:45, Jincheng Miao wrote: In nodeGetFreePages, if startCell is given by '0', and the max node number is '0' too. The for-loop wouldn't be executed. So convert it to while-loop. Before:

Re: [libvirt] [PATCH 4/6] Added domainMigrateStartPostCopy in qemu driver

2014-09-24 Thread Jiri Denemark
On Tue, Sep 23, 2014 at 16:09:59 +0200, Cristian Klein wrote: Signed-off-by: Cristian Klein cristian.kl...@cs.umu.se --- src/qemu/qemu_driver.c | 44 src/qemu/qemu_monitor.c | 19 +++ src/qemu/qemu_monitor.h | 2

Re: [libvirt] [PATCH 5/6] Added domainMigrateStartPostCopy in remote driver

2014-09-24 Thread Jiri Denemark
On Tue, Sep 23, 2014 at 16:10:00 +0200, Cristian Klein wrote: Signed-off-by: Cristian Klein cristian.kl...@cs.umu.se --- src/remote/remote_driver.c | 1 + src/remote/remote_protocol.x | 12 +++- 2 files changed, 12 insertions(+), 1 deletion(-) diff --git

Re: [libvirt] [PATCH 3/6] Added new public API virDomainMigrateStartPostCopy

2014-09-24 Thread Jiri Denemark
On Wed, Sep 24, 2014 at 14:45:02 +0200, Jiri Denemark wrote: On Tue, Sep 23, 2014 at 16:09:58 +0200, Cristian Klein wrote: The user first start migration using the `VIR_MIGRATE_POSTCOPY` flag, then calls `virDomainMigrateStartPostCopy` asynchronously to switch from pre-copy to post-copy.

[libvirt] [PATCH 3/3] qemu: Remove possible NULL deref in debug output

2014-09-24 Thread John Ferlan
Check for !dev-info.alias was done after a VIR_DEBUG() statement that already tried to print - just flip sequence Signed-off-by: John Ferlan jfer...@redhat.com --- src/qemu/qemu_hotplug.c | 24 ++-- 1 file changed, 10 insertions(+), 14 deletions(-) diff --git

[libvirt] [PATCH 1/3] qemu: Fix hot unplug of SCSI_HOST device

2014-09-24 Thread John Ferlan
https://bugzilla.redhat.com/show_bug.cgi?id=1141732 Introduced by commit id '8f76ad99' the logic to detach a scsi_host device (SCSI or iSCSI) fails when attempting to remove the 'drive' because as I found in my investigation - the DelDevice takes care of that for us. The investigation turned up

[libvirt] [PATCH 2/3] qemu: Remove need for virConnectPtr in hotunplug detach host, net

2014-09-24 Thread John Ferlan
Prior patch removed the need for the virConnectPtr in the unplug detach host path which caused ripple effect to remove in multiple callers. The previous patch just left things as ATTRIBUTE_UNUSED - this patch will remove the variable. Signed-off-by: John Ferlan jfer...@redhat.com ---

[libvirt] [PATCH 0/3] Fix hot unplug of scsi_host hostdev

2014-09-24 Thread John Ferlan
https://bugzilla.redhat.com/show_bug.cgi?id=1141732 Attempting to hot unplug a scsi_host device fails. The first patch resolves the issue (and has some details in the commit message). The second patch removes the now unnecessary virConnectPtr from various places. The third patch resolves a

Re: [libvirt] [PATCH 2/3] qemu: Remove need for virConnectPtr in hotunplug detach host, net

2014-09-24 Thread John Ferlan
On 09/24/2014 09:11 AM, John Ferlan wrote: Prior patch removed the need for the virConnectPtr in the unplug detach host path which caused ripple effect to remove in multiple callers. The previous patch just left things as ATTRIBUTE_UNUSED - this patch will remove the variable.

[libvirt] [PATCH 2/3 2/2] qemu: Remove need for virConnectPtr in hotunplug detach host, net

2014-09-24 Thread John Ferlan
Prior patch removed the need for the virConnectPtr in the unplug detach host path which caused ripple effect to remove in multiple callers. The previous patch just left things as ATTRIBUTE_UNUSED - this patch will remove the variable. Signed-off-by: John Ferlan jfer...@redhat.com ---

[libvirt] [PATCH 3/3] qemu: Remove possible NULL deref in debug output

2014-09-24 Thread John Ferlan
Check for !dev-info.alias was done after a VIR_DEBUG() statement that already tried to print - just flip sequence Signed-off-by: John Ferlan jfer...@redhat.com --- src/qemu/qemu_hotplug.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/qemu/qemu_hotplug.c

Re: [libvirt] [PATCHv2 1/2] conf: add options for disabling segment offloading

2014-09-24 Thread Ján Tomko
On 09/24/2014 01:24 AM, John Ferlan wrote: On 09/18/2014 10:15 AM, Ján Tomko wrote: Add options for tuning segment offloading: driver host csum='off' gso='off' tso4='off' tso6='off' ecn='off' ufo='off'/ guest csum='off' tso4='off' tso6='off' ecn='off' ufo='off'/ /driver

Re: [libvirt] [PATCHv2 2/2] qemu: wire up virtio-net segment offloading options

2014-09-24 Thread Ján Tomko
On 09/24/2014 01:24 AM, John Ferlan wrote: On 09/18/2014 10:15 AM, Ján Tomko wrote: Format the segment offloading options specified by driver host .../ guest .../ /driver on virtio-net command line. --- src/qemu/qemu_command.c| 40

Re: [libvirt] [PATCHv2 1/2] conf: add options for disabling segment offloading

2014-09-24 Thread John Ferlan
On 09/24/2014 09:44 AM, Ján Tomko wrote: On 09/24/2014 01:24 AM, John Ferlan wrote: On 09/18/2014 10:15 AM, Ján Tomko wrote: Add options for tuning segment offloading: driver host csum='off' gso='off' tso4='off' tso6='off' ecn='off' ufo='off'/ guest csum='off' tso4='off'

Re: [libvirt] [PATCH] Fix MinGW build

2014-09-24 Thread Martin Kletzander
On Wed, Sep 24, 2014 at 02:13:25PM +0200, Pavel Hrdina wrote: When building on mingw the format string for long long/unsigned long long have to be I64d/I64u instead of lld/llu. Signed-off-by: Pavel Hrdina phrd...@redhat.com --- I'm not sure if this is the right way to do it so sending it for

[libvirt] bad rpm: libvirt-daemon-1.2.8-1

2014-09-24 Thread Gene Czarcinski
Since libvirt-daemon-1.2.8-5 fixes the problem, I just wanted to give everyone a heads up. The libvirt-daemon-1.2.8-1 has an error in the spec file scripts which causes removal failure. I had to manually rpm -e --noscripts libvirt-daemon-1.2.8-1.fc20.x86_64 and then I reinstalled

Re: [libvirt] [PATCH 6/6] virsh: added migrate --postcopy-after

2014-09-24 Thread Jiri Denemark
On Tue, Sep 23, 2014 at 16:10:01 +0200, Cristian Klein wrote: Added a new parameter to the `virsh migrate` command to switch to post-copy migration after a given timeout. Signed-off-by: Cristian Klein cristian.kl...@cs.umu.se --- tools/virsh-domain.c | 72

Re: [libvirt] [PATCH] Fix MinGW build

2014-09-24 Thread Pavel Hrdina
On 09/24/2014 05:13 PM, Martin Kletzander wrote: On Wed, Sep 24, 2014 at 02:13:25PM +0200, Pavel Hrdina wrote: When building on mingw the format string for long long/unsigned long long have to be I64d/I64u instead of lld/llu. Signed-off-by: Pavel Hrdina phrd...@redhat.com --- I'm not sure if

Re: [libvirt] [PATCH 4/6] Added domainMigrateStartPostCopy in qemu driver

2014-09-24 Thread Jiri Denemark
On Wed, Sep 24, 2014 at 15:06:57 +0200, Jiri Denemark wrote: On Tue, Sep 23, 2014 at 16:09:59 +0200, Cristian Klein wrote: Signed-off-by: Cristian Klein cristian.kl...@cs.umu.se --- src/qemu/qemu_driver.c | 44 src/qemu/qemu_monitor.c

Re: [libvirt] [PATCH v3] network: Bring netdevs online later

2014-09-24 Thread Matthew Rosato
On 09/16/2014 04:50 PM, Matthew Rosato wrote: Currently, MAC registration occurs during device creation, which is early enough that, during live migration, you end up with duplicate MAC addresses on still-running source and target devices, even though the target device isn't actually being

[libvirt] [PATCH] security: Fix labelling host devices (bz 1145968)

2014-09-24 Thread Cole Robinson
The check for ISCSI devices was missing a check of subsys type, which meant we could skip labelling of other host devices as well. This fixes USB hotplug on F21 https://bugzilla.redhat.com/show_bug.cgi?id=1145968 --- src/security/security_apparmor.c | 3 ++- src/security/security_dac.c | 6

Re: [libvirt] [PATCH v4 0/2] parallels: use parallels SDK instead of prlctl tool

2014-09-24 Thread Dmitry Guryanov
On Thursday 11 September 2014 20:24:01 Dmitry Guryanov wrote: This patchset begins reworking of parallels driver. We have published Opensource version of parallels SDK (under LGPL license), so libvirt can link with it. Hello! Are there any news about these patches? I've fixed them according

Re: [libvirt] [Qemu-devel] [PATCH v4] Add machine parameter qemu-kvm-migration for live migrate compatibility with qemu-kvm

2014-09-24 Thread Michael Tokarev
22.09.2014 23:34, Alex Bligh wrote: This patch series adds inbound migrate capability from qemu-kvm version 1.0. [...] Isn't it quite a bit too late already? That's an old version by now, and supporting migration from it is interesting for long-term support distributions - like redhat for

Re: [libvirt] [PATCH] tunable_event: extend debug message and tweak limit for remote message

2014-09-24 Thread Eric Blake
On 09/24/2014 01:48 AM, Pavel Hrdina wrote: It would be nice to also print a params pointer and number of params in the debug message and the previous limit for number of params in the rpc message was too large. The 2048 params will be enough for future events. Signed-off-by: Pavel Hrdina

Re: [libvirt] bad rpm: libvirt-daemon-1.2.8-1

2014-09-24 Thread Eric Blake
On 09/24/2014 09:17 AM, Gene Czarcinski wrote: Since libvirt-daemon-1.2.8-5 fixes the problem, I just wanted to give everyone a heads up. The libvirt-daemon-1.2.8-1 has an error in the spec file scripts which causes removal failure. Known issue:

Re: [libvirt] [PATCH] Fix MinGW build

2014-09-24 Thread Eric Blake
On 09/24/2014 06:13 AM, Pavel Hrdina wrote: When building on mingw the format string for long long/unsigned long long have to be I64d/I64u instead of lld/llu. Signed-off-by: Pavel Hrdina phrd...@redhat.com --- Yuck. This is really a problem of the examples directory not taking advantage of

Re: [libvirt] [PATCH 0/6] Post-copy live migration support

2014-09-24 Thread Eric Blake
On 09/23/2014 08:09 AM, Cristian Klein wrote: Qemu currently implements pre-copy live migration. VM memory pages are first copied from the source hypervisor to the destination, potentially multiple times as pages get dirtied during transfer, then VCPU state is migrated. Unfortunately, if the

Re: [libvirt] [PATCH] security: Fix labelling host devices (bz 1145968)

2014-09-24 Thread Eric Blake
On 09/24/2014 09:49 AM, Cole Robinson wrote: The check for ISCSI devices was missing a check of subsys type, which meant we could skip labelling of other host devices as well. This fixes USB hotplug on F21 https://bugzilla.redhat.com/show_bug.cgi?id=1145968 ---

Re: [libvirt] [PATCH] Fix MinGW build

2014-09-24 Thread Eric Blake
On 09/24/2014 01:53 PM, Eric Blake wrote: On 09/24/2014 06:13 AM, Pavel Hrdina wrote: When building on mingw the format string for long long/unsigned long long have to be I64d/I64u instead of lld/llu. Signed-off-by: Pavel Hrdina phrd...@redhat.com --- Yuck. This is really a problem of

Re: [libvirt] [PATCH 0/6] Post-copy live migration support

2014-09-24 Thread Dr. David Alan Gilbert
* Eric Blake (ebl...@redhat.com) wrote: On 09/23/2014 08:09 AM, Cristian Klein wrote: Qemu currently implements pre-copy live migration. VM memory pages are first copied from the source hypervisor to the destination, potentially multiple times as pages get dirtied during transfer, then VCPU

Re: [libvirt] [PATCH 0/6] Post-copy live migration support

2014-09-24 Thread Eric Blake
On 09/24/2014 02:09 PM, Dr. David Alan Gilbert wrote: This right here is a problem. Qemu has explicitly documented that anything beginning with x- may be subject to change or going away in a later release, so libvirt policy has been to delay any patches targetting an x- interface until

Re: [libvirt] [PATCH] security: Fix labelling host devices (bz 1145968)

2014-09-24 Thread Cole Robinson
On 09/24/2014 03:59 PM, Eric Blake wrote: On 09/24/2014 09:49 AM, Cole Robinson wrote: The check for ISCSI devices was missing a check of subsys type, which meant we could skip labelling of other host devices as well. This fixes USB hotplug on F21

Re: [libvirt] [PATCH] hotplug: Fix libvirtd crash on qemu-attached guest

2014-09-24 Thread John Ferlan
On 09/22/2014 05:23 PM, Eric Blake wrote: On 09/22/2014 02:49 PM, John Ferlan wrote: https://bugzilla.redhat.com/show_bug.cgi?id=1141621 Using qemu-attach to attach to a qemu created process and then attempting to virsh detach-interface caused a libvirtd crash since the assumption was that

Re: [libvirt] [PATCH 1/6] conf: add trustGuestRxFilters attribute to network and domain interface

2014-09-24 Thread John Ferlan
On 09/24/2014 05:50 AM, Laine Stump wrote: This new attribute will control whether or not libvirt will pay attention to guest notifications about changes to network device mac addresses and receive filters. The default for this is 'no' (for security reasons). If it is set to 'yes' *and* the

Re: [libvirt] [PATCH 2/6] network: set interface actual trustGuestRxFilters from network/portgroup

2014-09-24 Thread John Ferlan
On 09/24/2014 05:50 AM, Laine Stump wrote: As is done with other items such as vlan, virtualport, and bandwidth, set the actual trustGuestRxFilters value to be used by a domain interface according to a merge of the same attribute in the interface, portgroup, and network in use. the interface

Re: [libvirt] [PATCH 3/6] util: define virNetDevRxFilter and basic utility functions

2014-09-24 Thread John Ferlan
On 09/24/2014 05:50 AM, Laine Stump wrote: This same structure will be used to retrieve RX filter info for interfaces on the host via netlink messages, and RX filter info for interfaces on the guest via the qemu query-rx-filter command. --- src/libvirt_private.syms | 8 +++

Re: [libvirt] [PATCH 4/6] qemu: qemuMonitorQueryRxFilter - retrieve guest netdev rx-filter

2014-09-24 Thread John Ferlan
On 09/24/2014 05:50 AM, Laine Stump wrote: This function can be called at any time to get the current status of a guest's network device rx-filter. In particular it is useful to call after libvirt recieves a NIC_RX_FILTER_CHANGED event - this event only tells you that something has changed

Re: [libvirt] [PATCH v2 0/4] Check migration configuration

2014-09-24 Thread Chen, Fan
ping? On Tue, 2014-09-23 at 12:04 +0800, Chen Fan wrote: add some check in migration configuration. Chen Fan (4): virsocketaddr: return address family in virSocketAddrIsNumeric migration: add migration_host support for Ipv6 address without brackets conf: add

Re: [libvirt] [PATCH 5/6] qemu: setup infrastructure to handle NIC_RX_FILTER_CHANGED event

2014-09-24 Thread John Ferlan
On 09/24/2014 05:50 AM, Laine Stump wrote: NIC_RX_FILTER_CHANGED is sent by qemu any time a NIC driver in the guest modified the NIC's RX Filter (for example, if the MAC address of the NIC is changed by the guest). This patch doesn't do anything useful with that event; it just sets up all

Re: [libvirt] [PATCH 6/6] qemu: change macvtap device MAC address in response to NIC_RX_FILTER_CHANGED

2014-09-24 Thread John Ferlan
On 09/24/2014 05:50 AM, Laine Stump wrote: This patch fills in the functionality of processNicRxFilterChangedEvent(). It now checks if it is appropriate to respond to the NIC_RX_FILTER_CHANGED event (based on device type and configuration) and takes appropriate action. Currently it checks

Re: [libvirt] Is seems necessary to pass migratable=no/yes to qemu.

2014-09-24 Thread zhang bo
On 2014/9/24 19:49, Ján Tomko wrote: On 09/24/2014 05:28 AM, zhang bo wrote: The patch http://libvirt.org/git/?p=libvirt.git;a=commitdiff;h=de0aeafe9ce3eb414c8b5d3aa8995d776a2952de removes invtsc flag in the host-model CPU. I'm wondering, will it be better to pass args migratable=no/yes to

[libvirt] [PATCH] conf: report error in virCPUDefParseXML

2014-09-24 Thread Jincheng Miao
When detected invalid 'memAccess', virCPUDefParseXML should report error. Resolves https://bugzilla.redhat.com/show_bug.cgi?id=1146334 Signed-off-by: Jincheng Miao jm...@redhat.com --- src/conf/cpu_conf.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

Re: [libvirt] [PATCH] nodeinfo: fix nodeGetFreePages when max node is zero

2014-09-24 Thread Jincheng Miao
On 09/24/2014 08:53 PM, Michal Privoznik wrote: On 24.09.2014 14:00, Jincheng Miao wrote: On 09/24/2014 07:40 PM, Michal Privoznik wrote: On 24.09.2014 07:45, Jincheng Miao wrote: In nodeGetFreePages, if startCell is given by '0', and the max node number is '0' too. The for-loop wouldn't be

Re: [libvirt] [PATCH] conf: report error in virCPUDefParseXML

2014-09-24 Thread Martin Kletzander
On Thu, Sep 25, 2014 at 12:23:31PM +0800, Jincheng Miao wrote: When detected invalid 'memAccess', virCPUDefParseXML should report error. Resolves https://bugzilla.redhat.com/show_bug.cgi?id=1146334 Signed-off-by: Jincheng Miao jm...@redhat.com --- src/conf/cpu_conf.c | 4 ++-- 1 file changed, 2