[libvirt] [libvirt-python v2 PATCH] Improve error output when use getTime with a nonzero flags.

2014-10-16 Thread Luyao Huang
When give a nonzero flags to getTime, c_retval will get -1 and goto cleanup. But py_retval still is NULL,so pass c_retval value to py_retval. This will make the output message more correct. error before use this patch: SystemError: error return without exception set after use the patch: libvirtEr

[libvirt] Tunneled migration failures

2014-10-16 Thread Gary Hook
So here¹s the thing: I have an environment running without tunneling. I can move a modestly sized (3.2GB disk space, 2GB RAM) VM back and forth between two systems all day long, using peer-peer migration, with these flags set: VIR_MIGRATE_UNDEFINE_SOURCE VIR_MIGRATE_PEER2PEER VIR_MIGRATE_PERSIST_

Re: [libvirt] [libvirt-ruby] [PATCH] fix storage volume creation error messages

2014-10-16 Thread Chris Lalancette
Hi there, On Thu, Oct 16, 2014 at 6:59 PM, Adam Spiers wrote: >> > Sorry, I forgot to say that this patch is for the ruby-libvirt tree. >> > I'm a total newbie to libvirt development, so apologies if I was >> > supposed to send this elsewhere. >> >> This is the right place, but it might get more

Re: [libvirt] [libvirt-ruby] [PATCH] fix storage volume creation error messages

2014-10-16 Thread Adam Spiers
Eric Blake wrote: > On 10/16/2014 03:49 PM, Adam Spiers wrote: > > Adam Spiers wrote: > >> It seems that raising of error messages associated with creation of > >> storage volumes contained copy'n'paste errors due to the code being > >> copied from network creation code. > >> > >> Signed-off-by:

Re: [libvirt] [libvirt-ruby] [PATCH] fix storage volume creation error messages

2014-10-16 Thread Eric Blake
On 10/16/2014 03:49 PM, Adam Spiers wrote: > Adam Spiers wrote: >> It seems that raising of error messages associated with creation of >> storage volumes contained copy'n'paste errors due to the code being >> copied from network creation code. >> >> Signed-off-by: Adam Spiers >> --- >> ext/libvi

Re: [libvirt] [PATCH] fix storage volume creation error messages

2014-10-16 Thread Adam Spiers
Adam Spiers wrote: > It seems that raising of error messages associated with creation of > storage volumes contained copy'n'paste errors due to the code being > copied from network creation code. > > Signed-off-by: Adam Spiers > --- > ext/libvirt/storage.c | 4 ++-- > 1 file changed, 2 insertio

Re: [libvirt] [PATCH] libxl: add missing 'break' from commit 1298daca

2014-10-16 Thread Jim Fehlig
Eric Blake wrote: > On 10/16/2014 12:42 PM, Jim Fehlig wrote: > >> Add missing 'break's from commit 1298daca, as noted by John Ferlan >> >> https://www.redhat.com/archives/libvir-list/2014-October/msg00430.html >> Signed-off-by: Jim Fehlig >> --- >> src/libxl/libxl_domain.c | 2 ++ >> 1 file c

[libvirt] [PATCH] fix storage volume creation error messages

2014-10-16 Thread Adam Spiers
It seems that raising of error messages associated with creation of storage volumes contained copy'n'paste errors due to the code being copied from network creation code. Signed-off-by: Adam Spiers --- ext/libvirt/storage.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/

Re: [libvirt] [PATCH] libxl: add missing 'break' from commit 1298daca

2014-10-16 Thread Eric Blake
On 10/16/2014 12:42 PM, Jim Fehlig wrote: > Add missing 'break's from commit 1298daca, as noted by John Ferlan > > https://www.redhat.com/archives/libvir-list/2014-October/msg00430.html > Signed-off-by: Jim Fehlig > --- > src/libxl/libxl_domain.c | 2 ++ > 1 file changed, 2 insertions(+) ACK.

[libvirt] [PATCH] qemu: x86_64 is good enough for i686

2014-10-16 Thread Lubomir Rintel
virt-manager on Fedora sets up i686 hosts with "/usr/bin/qemu-kvm" emulator, which in turn unconditionally execs qemu-system-x86_64 querying capabilities then fails: Error launching details: invalid argument: architecture from emulator 'x86_64' doesn't match given architecture 'i686' Traceback (

Re: [libvirt] [PATCH 4/5] libxl: Implement basic video device selection

2014-10-16 Thread Jim Fehlig
John Ferlan wrote: > Coverity complains... > On 09/19/2014 03:23 PM, Jim Fehlig wrote: > >> From: Stefan Bader >> >> This started as an investigation into an issue where libvirt (using the >> libxl driver) and the Xen host, like an old couple, could not agree on >> who is responsible for select

[libvirt] [PATCH] libxl: add missing 'break' from commit 1298daca

2014-10-16 Thread Jim Fehlig
Add missing 'break's from commit 1298daca, as noted by John Ferlan https://www.redhat.com/archives/libvir-list/2014-October/msg00430.html Signed-off-by: Jim Fehlig --- src/libxl/libxl_domain.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/libxl/libxl_domain.c b/src/libxl/libxl_domain

[libvirt] [docs] Couple of wiki pages with examples of live block operations

2014-10-16 Thread Kashyap Chamarthy
Heya, Here are some examples of live block operations (to begin with, active blockcommit) after some testing and from discussions with Eric Blake on IRC/email: http://wiki.libvirt.org/page/Live-disk-backup-with-active-blockcommit http://wiki.libvirt.org/page/Live-merge-an-entire-disk-ima

[libvirt] [PATCH] qemu: move setting emulatorpin ahead of monitor showing up

2014-10-16 Thread Wang Rui
From: Zhou yimin If VM is configured with many devices(including passthrough devices) and large memory, libvirtd will take seconds(in the worst case) to wait for monitor. In this period the qemu process may run on any PCPU though I intend to pin emulator to the specified PCPU in xml configuration

Re: [libvirt] [GIT PULL] namespace updates for v3.17-rc1

2014-10-16 Thread Adrian Davey
On 21.08.2014 08:54:57, writes Eric W. Biederman: Richard Weinberger writes: Am 21.08.2014 08:29, schrieb Richard Weinberger: Am 21.08.2014 06:53, schrieb Eric W. Biederman: The bugs fixed are security issues, so if we have to break a small number of userspace applications we will. Anything

[libvirt] [libvirt-python PATCH] Improve error output when use getTime with a nonzero flags.

2014-10-16 Thread Luyao Huang
When give a nonzero flags to getTime, c_retval will get -1 and goto cleanup. But py_retval still is NULL,so pass c_retval value to py_retval. This will make the output message more correct. error before use this patch: SystemError: error return without exception set after use the patch: libvirtEr

Re: [libvirt] [libvirt-python PATCH 1/1] Change the comment in getPyNodeCPUCount method reflecting correct called methods

2014-10-16 Thread Pavel Hrdina
On 10/15/2014 03:54 PM, Pradipta Kr. Banerjee wrote: Comment mentions virGetNodeCPUMap whereas the actual method is virNodeGetCPUMap. Similarly comment mentions virGetNodeInfo whereas the actual method is virNodeGetInfo Signed-off-by: Pradipta Kr. Banerjee --- libvirt-override.c | 4 ++-- 1