Re: [libvirt] [python PATCH 1/3] Fix function name when parsing arguments in libvirt_virNodeAllocPages

On 10/21/14 20:02, Eric Blake wrote: On 10/21/2014 08:34 AM, Peter Krempa wrote: The override function was copiedpasted from virConnectGetAllDomainStats and the function name after the collon was not changed. Fix the issue as s/collon/colon/ I've fixed this typo and pushed the series.

Re: [libvirt] [PATCH v2] Fix cast errors with clang

Eric Blake wrote: On 10/21/2014 08:22 AM, Roman Bogorodskiy wrote: Build with clang fails with: CC util/libvirt_util_la-virsocketaddr.lo util/virsocketaddr.c:904:17: error: cast from 'struct sockaddr *' to 'struct sockaddr_in *' increases required alignment from 1 to 4

Re: [libvirt] [python PATCH] Fix flags cannot get right value for blockCopy function

On 10/22/2014 07:18 AM, Luyao Huang wrote: When use blockCopy, flags cannot get a right value, because PyArg_ParseTuple want to get 6 parameters and blockCopy only pass 5.Flags will get a unpredictable value, this will make this function cannot be used.And error just like: unsupported flags

Re: [libvirt] [PATCH 0/5] parallels: continue rewriting code to use sdk

On Tuesday 14 October 2014 18:23:31 you wrote: This patch series replaces a series of functions, which retieve different domains info and modifies domains state with new ones, which use parallels sdk instead of executing prlctl command. These functions don't use cached domains list

[libvirt] [PATCH] docs: fix an improper git browsable address

Signed-off-by: Chen Hanxiao chenhanx...@cn.fujitsu.com --- docs/hacking.html.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/hacking.html.in b/docs/hacking.html.in index 4ab0179..b1553a5 100644 --- a/docs/hacking.html.in +++ b/docs/hacking.html.in @@ -14,7 +14,7 @@

[libvirt] [PATCH 0/3] Fix handling of data returned by XML hooks

Peter Krempa (3): util: string: Add helper to check whether string is empty qemu: restore: Fix restoring of VM when the restore hook returns empty XML qemu: migration: Make check for empty hook XML robust src/libvirt_private.syms | 1 + src/qemu/qemu_driver.c| 2 +-

[libvirt] [PATCH 1/3] util: string: Add helper to check whether string is empty

The helper checks whether a string contains only whitespace or is NULL. This will be helpful to skip cases where a user string is optional, but may be provided empty with the same meaning. --- src/libvirt_private.syms | 1 + src/util/virstring.c | 16 src/util/virstring.h

[libvirt] [PATCH 3/3] qemu: migration: Make check for empty hook XML robust

Also consider whitespace only strings returned from the hook as empty result. --- src/qemu/qemu_migration.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/qemu/qemu_migration.c b/src/qemu/qemu_migration.c index e135249..ca70e35 100644 --- a/src/qemu/qemu_migration.c +++

[libvirt] [PATCH 2/3] qemu: restore: Fix restoring of VM when the restore hook returns empty XML

The documentation for the restore hook states that returning an empty XML is equivalent with copying the input. There was a bug in the code checking the returned string by checking the string instead of the contents. Use the new helper to check if the string is empty. --- src/qemu/qemu_driver.c |

Re: [libvirt] [PATCH 0/5] parallels: continue rewriting code to use sdk

On Wed, Oct 22, 2014 at 01:31:41PM +0400, Dmitry Guryanov wrote: On Tuesday 14 October 2014 18:23:31 you wrote: This patch series replaces a series of functions, which retieve different domains info and modifies domains state with new ones, which use parallels sdk instead of executing

Re: [libvirt] [PATCHv3 01/16] Forgot to cleanup ifname_guest* in domain network def parsing

On Fri, Oct 10, 2014 at 02:03:53PM +0200, Cédric Bosdonnat wrote: --- src/conf/domain_conf.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 2810c05..b5c761f 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@

Re: [libvirt] [PATCHv3 02/16] Domain conf: allow more than one IP address for net devices

On Fri, Oct 10, 2014 at 02:03:54PM +0200, Cédric Bosdonnat wrote: Add the possibility to have more than one IP address configured for a domain network interface. IP addresses can also have a prefix to define the corresponding netmask. --- docs/formatdomain.html.in | 22 +++

Re: [libvirt] [PATCHv3 03/16] LXC: set IP addresses to veth devices in the container

On Fri, Oct 10, 2014 at 02:03:55PM +0200, Cédric Bosdonnat wrote: Uses the new virDomainNetDef ips to set the IP addresses on the network interfaces in the container. --- src/lxc/lxc_container.c | 24 +++- 1 file changed, 23 insertions(+), 1 deletion(-) diff --git

Re: [libvirt] [PATCHv3 04/16] lxc conf2xml: convert IP addresses

On Fri, Oct 10, 2014 at 02:03:56PM +0200, Cédric Bosdonnat wrote: --- src/lxc/lxc_native.c| 153 tests/lxcconf2xmldata/lxcconf2xml-simple.config | 2 + tests/lxcconf2xmldata/lxcconf2xml-simple.xml| 2 + 3 files changed, 106

Re: [libvirt] [PATCHv3 05/16] Allow network capabilities hostdev to configure IP addresses

On Fri, Oct 10, 2014 at 02:03:57PM +0200, Cédric Bosdonnat wrote: --- docs/formatdomain.html.in| 12 +++-- docs/schemas/domaincommon.rng| 23 +++--- src/conf/domain_conf.c | 47 src/conf/domain_conf.h

Re: [libvirt] [PATCHv3 06/16] lxc conf2xml: convert ip addresses for hostdev NICs

On Fri, Oct 10, 2014 at 02:03:58PM +0200, Cédric Bosdonnat wrote: --- src/lxc/lxc_native.c | 3 +++ tests/lxcconf2xmldata/lxcconf2xml-physnetwork.config | 2 ++ tests/lxcconf2xmldata/lxcconf2xml-physnetwork.xml| 2 ++ 3 files changed, 7 insertions(+) ACK

Re: [libvirt] [PATCHv3 07/16] Domain network devices can now have a gateway element

On Fri, Oct 10, 2014 at 02:03:59PM +0200, Cédric Bosdonnat wrote: Network interfaces devices and host devices with net capabilities can now have an IPv4 and/or an IPv6 address configured. --- docs/formatdomain.html.in| 9 docs/schemas/domaincommon.rng| 23

Re: [libvirt] [PATCHv3 08/16] lxc conf2xml: convert lxc.network.ipv[46].gateway

On Fri, Oct 10, 2014 at 02:04:00PM +0200, Cédric Bosdonnat wrote: --- src/lxc/lxc_native.c | 19 ++- tests/lxcconf2xmldata/lxcconf2xml-physnetwork.config | 2 ++ tests/lxcconf2xmldata/lxcconf2xml-physnetwork.xml| 1 +

Re: [libvirt] [PATCHv3 09/16] LXC: use the new net devices gateway definition

On Fri, Oct 10, 2014 at 02:04:01PM +0200, Cédric Bosdonnat wrote: When a gateway is set on a network device, a new default route via this gateway through the devoce will be added in the container. --- src/lxc/lxc_container.c | 40 1 file changed, 40

Re: [libvirt] [PATCHv3 10/16] LXC: honour network devices link state

On Fri, Oct 10, 2014 at 02:04:02PM +0200, Cédric Bosdonnat wrote: Don't activate LXC network device if link state='down'/ has been set in its configuration. --- src/lxc/lxc_container.c | 28 +++- 1 file changed, 15 insertions(+), 13 deletions(-) diff --git

Re: [libvirt] [PATCHv3 11/16] Wrong place for virDomainNetIpsFormat

On Fri, Oct 10, 2014 at 02:04:03PM +0200, Cédric Bosdonnat wrote: --- src/conf/domain_conf.c | 60 +- 1 file changed, 30 insertions(+), 30 deletions(-) Could you update the commit message to be a little more explicit about why it is in the

Re: [libvirt] [PATCHv3 12/16] virNetDevSetIPv4Address: libnl implementation

On Fri, Oct 10, 2014 at 02:04:04PM +0200, Cédric Bosdonnat wrote: Add a default implementation of virNetDevSetIPv4Address using netlink and libnl. This avoids requiring /usr/sbin/ip or /usr/sbin/ifconfig external binaries. --- src/libvirt_private.syms | 1 + src/util/virnetdev.c | 136

Re: [libvirt] [PATCHv3 14/16] virNetDevAddRoute: implementation using netlink

On Fri, Oct 10, 2014 at 02:04:06PM +0200, Cédric Bosdonnat wrote: --- src/util/virnetdev.c | 105 +++ 1 file changed, 90 insertions(+), 15 deletions(-) ACK Regards, Daniel -- |: http://berrange.com -o-

Re: [libvirt] [PATCHv3 13/16] Renamed virNetDevSetIPv4Address to virNetDevSetIPAddress

On Fri, Oct 10, 2014 at 02:04:05PM +0200, Cédric Bosdonnat wrote: Renamed virNetDevSetIPv4Address as it also handles IPv6 addresses. --- src/libvirt_private.syms| 2 +- src/lxc/lxc_container.c | 2 +- src/network/bridge_driver.c | 4 ++-- src/util/virnetdev.c| 14

Re: [libvirt] [PATCH] docs: fix an improper git browsable address

On Wed, Oct 22, 2014 at 05:38:33PM +0800, Chen Hanxiao wrote: Signed-off-by: Chen Hanxiao chenhanx...@cn.fujitsu.com --- docs/hacking.html.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/hacking.html.in b/docs/hacking.html.in index 4ab0179..b1553a5 100644 ---

Re: [libvirt] [PATCHv3 03/16] LXC: set IP addresses to veth devices in the container

On 10/22/2014 06:05 AM, Daniel P. Berrange wrote: On Fri, Oct 10, 2014 at 02:03:55PM +0200, Cédric Bosdonnat wrote: Uses the new virDomainNetDef ips to set the IP addresses on the network interfaces in the container. --- src/lxc/lxc_container.c | 24 +++- 1 file

Re: [libvirt] libvirt build failure on armhf (Re: [Xen-devel] [libvirt bisection] complete build-armhf-libvirt)

On Tue, 2014-10-21 at 18:02 -0600, Jim Fehlig wrote: Ian Campbell wrote: Hi, On Fri, 2014-10-17 at 00:42 +0100, xen.org wrote: *** Found and reproduced problem changeset *** Bug is in tree: libvirt git://libvirt.org/libvirt.git Bug introduced:

[libvirt] Libvirt clock/time settings doubt.

Hi everyone! What is the method/function responsible to setup time settings in libvirt? Considering the example of libvirt documentation. clock offset='localtime' timer name='rtc' tickpolicy='catchup' track='guest' catchup threshold='123' slew='120' limit='1'/ /timer timer

[libvirt] [libvirt-python PATCH 1/1] virDomainBlockCopy: initialize flags to 0

An optional argument if not passed isn't modified by the PyArg_ParseTuple function. Signed-off-by: Pavel Hrdina phrd...@redhat.com --- Sigh :/, pushed as trivial libvirt-override.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libvirt-override.c b/libvirt-override.c index

[libvirt] [RFC] Can we error out early for unknown device models?

Hi everyone, I had this idea that since we are probing QEMU binaries for devices using 'qom-list-types', we could store that data in the capabilities and check whether device models are supported before starting QEMU. We do that for _some newer_ devices, but this would be global. It would help

[libvirt] [RFC] Add support for NIC offload discovery

Currently libvirt provides lots of useful information on the HW capabilities of the host and its attached devices. I'm interested in extending the HW capability discovery of libvirt, to a point where it is capable of discovering the HW offload capabilities of host PCI devices. Take a NIC for

Re: [libvirt] [PATCH] Add support for /run/initctl

On Tue, Sep 30, 2014 at 12:01:13PM -0500, Rick Harris wrote: Newer versions of Debian use `/run/initctl` instead of `/dev/initctl`. This patch updates the code to search for the FIFO from a list of well-known locations. In the FreeBSD case, as before, we fall-back to the `/etc/.initctl`

Re: [libvirt] Libvirt clock/time settings doubt.

You probably need to have a look at sequence qemuBuildCommandLine() - qemuBuildClockArgStr() in src/qemu/qemu_command.c Regards, Shiva On Wed, Oct 22, 2014 at 5:16 PM, Julio Faracco jcfara...@gmail.com wrote: Hi everyone! What is the method/function responsible to setup time settings in

Re: [libvirt] [libvirt-python PATCH 1/1] virDomainBlockCopy: initialize flags to 0

On 10/22/14 13:53, Pavel Hrdina wrote: An optional argument if not passed isn't modified by the PyArg_ParseTuple function. Signed-off-by: Pavel Hrdina phrd...@redhat.com --- Sigh :/, pushed as trivial libvirt-override.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

Re: [libvirt] [PATCH 0/3] Fix handling of data returned by XML hooks

On Wed, Oct 22, 2014 at 11:48:03AM +0200, Peter Krempa wrote: Peter Krempa (3): util: string: Add helper to check whether string is empty qemu: restore: Fix restoring of VM when the restore hook returns empty XML qemu: migration: Make check for empty hook XML robust

Re: [libvirt] [PATCH 1/3] lxc: Implement pin emulator for container startup

On 09/04/2014 03:52 AM, Wang Rui wrote: From: Yue Wenyuan yueweny...@huawei.com This patch implements libvirt_lxc process pin with emulatorpin specified in xml. Signed-off-by: Wang Rui moon.wang...@huawei.com Signed-off-by: Yue Wenyuan yueweny...@huawei.com --- src/lxc/lxc_cgroup.c

Re: [libvirt] [PATCH 2/3] lxc: Implement emulator pin API in lxc driver

On 09/04/2014 03:52 AM, Wang Rui wrote: From: Yue Wenyuan yueweny...@huawei.com Implement the lxc driver method for virDomainPinEmulator to set container's cpuset. Signed-off-by: Wang Rui moon.wang...@huawei.com Signed-off-by: Yue Wenyuan yueweny...@huawei.com ---

Re: [libvirt] [PATCH 3/3] lxc: Implement geting emulator pin info API in lxc driver

Fix the $SUBJ s/geting/getting On 09/04/2014 03:52 AM, Wang Rui wrote: From: Yue Wenyuan yueweny...@huawei.com Implement the lxc driver method for virDomainGetEmulatorPinInfo to get container's cpuset. Signed-off-by: Wang Rui moon.wang...@huawei.com Signed-off-by: Yue Wenyuan

Re: [libvirt] [PATCH] docs: fix an improper git browsable address

On 10/22/14 12:24, Martin Kletzander wrote: On Wed, Oct 22, 2014 at 05:38:33PM +0800, Chen Hanxiao wrote: Signed-off-by: Chen Hanxiao chenhanx...@cn.fujitsu.com --- docs/hacking.html.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/hacking.html.in

[libvirt] [PATCH] doc: HACKING: Regenerate after recent change

--- Pushed as trivial. HACKING | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/HACKING b/HACKING index f8546cb..8f42e51 100644 --- a/HACKING +++ b/HACKING @@ -16,7 +16,7 @@ listen to feedback. (2) Official upstream repository is kept in git (git://libvirt.org/libvirt.git)

Re: [libvirt] [PATCH 0/3] Fix handling of data returned by XML hooks

On 10/22/14 15:01, Martin Kletzander wrote: On Wed, Oct 22, 2014 at 11:48:03AM +0200, Peter Krempa wrote: Peter Krempa (3): util: string: Add helper to check whether string is empty qemu: restore: Fix restoring of VM when the restore hook returns empty XML qemu: migration: Make check

[libvirt] [PATCH 05/12] Move virInterface related APIs out of libvirt.c

Introduce a src/libvirt-interface.c file to hold all the methods related to the virInterface type. --- docs/apibuild.py| 1 + src/Makefile.am | 2 + src/libvirt-interface.c | 835 src/libvirt.c | 808

[libvirt] [PATCH 01/12] Rename virDriver to virHypervisorDriver

To prepare for introducing a single global driver, rename the virDriver struct to virHypervisorDriver and the registration API to virRegisterHypervisorDriver() --- docs/hvsupport.pl| 2 +- src/bhyve/bhyve_driver.c | 4 ++-- src/datatypes.h | 2 +-

[libvirt] [PATCH 04/12] Move virNetwork related APIs out of libvirt.c

Introduce a src/libvirt-network.c file to hold all the methods related to the virNetwork type. --- docs/apibuild.py |1 + po/POTFILES.in|1 + src/Makefile.am |2 + src/libvirt-network.c | 1251 + src/libvirt.c

[libvirt] [PATCH 06/12] Move virNWFilter related APIs out of libvirt.c

Introduce a src/libvirt-nwfilter.c file to hold all the methods related to the virNWFilter type. --- docs/apibuild.py | 1 + po/POTFILES.in | 1 + src/Makefile.am| 2 + src/libvirt-nwfilter.c | 515 + src/libvirt.c

[libvirt] [PATCH 08/12] Move virSecret related APIs out of libvirt.c

Introduce a src/libvirt-secret.c file to hold all the methods related to the virSecret type. --- docs/apibuild.py | 1 + po/POTFILES.in | 1 + src/Makefile.am | 2 + src/libvirt-secret.c | 695 +++ src/libvirt.c| 668

[libvirt] [PATCH 07/12] Move virNodeDevice related APIs out of libvirt.c

Introduce a src/libvirt-nodedev.c file to hold all the methods related to the virNodeDevice type. --- docs/apibuild.py | 1 + src/Makefile.am | 2 + src/libvirt-nodedev.c | 756 ++ src/libvirt.c | 728

[libvirt] [PATCH 09/12] Move virStream related APIs out of libvirt.c

Introduce a src/libvirt-stream.c file to hold all the methods related to the virStream type. --- cfg.mk | 4 +- docs/apibuild.py | 1 + po/POTFILES.in | 1 + src/Makefile.am | 2 + src/libvirt-stream.c | 704 +++

[libvirt] [PATCH 03/12] Move virDomainSnapshot related APIs out of libvirt.c

Introduce a src/libvirt-domain-snapshot.c file to hold all the methods related to the virDomainSnapshot type. --- docs/apibuild.py |1 + po/POTFILES.in|1 + src/Makefile.am |2 + src/datatypes.h |1 +

[libvirt] [PATCH 10/12] Move virStorage{Pool, Vol} related APIs out of libvirt.c

Introduce a src/libvirt-storage.c file to hold all the methods related to the virStorage{Pool,Vol} types. --- docs/apibuild.py |1 + po/POTFILES.in|1 + src/Makefile.am |2 + src/libvirt-storage.c | 2118 +

[libvirt] [PATCH 12/12] Move virConnect/virNode related APIs out of libvirt.c

Introduce a src/libvirt-host.c file to hold all the methods related to the virConnect type. --- docs/apibuild.py |1 + po/POTFILES.in |1 + src/Makefile.am|2 + src/libvirt-host.c | 1515 src/libvirt.c | 1484

[libvirt] [PATCH 00/12] Split up large driver files

This patch series splits up the src/driver.h and src/libvirt.c files into a number of smaller pieces. The driver.h file gets split based on the the driver type, while libvirt.c gets split slightly different based on the object type. The reason for the difference is that the hypervisor driver is

Re: [libvirt] [PATCH] qemu: command: Allow UEFI for non-x86

On 10/15/14 15:55, Michal Privoznik wrote: On 14.10.2014 09:42, Cole Robinson wrote: It's supported on aarch64 and armv7l as well, so just drop the restriction entirely since it doesn't add much. --- src/qemu/qemu_command.c | 8 1 file changed, 8 deletions(-) diff --git

Re: [libvirt] [PATCH] Show also short-ids when calling --list-{os, platform}

On 10/22/2014 08:16 AM, Fabiano Fidêncio wrote: As the short-id can be used to set the os/platform in the example program, let's expose them to the user. --- examples/virt-designer.c | 16 ++-- 1 file changed, 10 insertions(+), 6 deletions(-) Which project is this against? It

Re: [libvirt] [PATCHv3] qemu: NUMA/network tuning shouldn't be supported in session mode

On 10/01/2014 08:57 AM, Erik Skultety wrote: Tuning NUMA or network interface parameters require root privileges to manage cgroups, thus an attempt to set some of these parameters in session mode on a running domain should be invalid followed by an error. As an example might be memory tuning

Re: [libvirt] [libvirt-designer] [PATCH] Show also short-ids when calling --list-{os, platform}

Eric, On Wed, 2014-10-22 at 11:55 -0600, Eric Blake wrote: On 10/22/2014 08:16 AM, Fabiano Fidêncio wrote: As the short-id can be used to set the os/platform in the example program, let's expose them to the user. --- examples/virt-designer.c | 16 ++-- 1 file changed, 10

Re: [libvirt] [libvirt-sandbox] [PATCH 0/2] v1.1 bugfix: support dhcp network interfaces

On 10/09/2014 04:46 PM, Gene Czarcinski wrote: On 09/10/2014 07:37 AM, Gene Czarcinski wrote: v1.1 adds some documentation changes. Support for a network such as -N dhcp,source=default was not working in that dhclient was not being started. Although I am not sure what the real problem is,

Re: [libvirt] [PATCH 01/12] Rename virDriver to virHypervisorDriver

On 10/22/2014 11:14 AM, Daniel P. Berrange wrote: To prepare for introducing a single global driver, rename the virDriver struct to virHypervisorDriver and the registration API to virRegisterHypervisorDriver() --- Mostly mechanical. +++ b/src/datatypes.h @@ -336,7 +336,7 @@ struct

Re: [libvirt] [PATCH 03/12] Move virDomainSnapshot related APIs out of libvirt.c

On 10/22/2014 11:14 AM, Daniel P. Berrange wrote: Introduce a src/libvirt-domain-snapshot.c file to hold all the methods related to the virDomainSnapshot type. --- docs/apibuild.py |1 + po/POTFILES.in|1 + src/Makefile.am |2 +

Re: [libvirt] [PATCH 02/12] Split driver.h into multiple parts

On 10/22/2014 11:14 AM, Daniel P. Berrange wrote: With the large number of APIs in libvirt the driver.h file, it is easy to get lost looking for things. Split each driver into a separate header file based on the functional driver groups. Someday, I'd also like to see the public .h headers get

Re: [libvirt] [PATCH 04/12] Move virNetwork related APIs out of libvirt.c

On 10/22/2014 11:14 AM, Daniel P. Berrange wrote: Introduce a src/libvirt-network.c file to hold all the methods related to the virNetwork type. --- docs/apibuild.py |1 + po/POTFILES.in|1 + src/Makefile.am |2 + src/libvirt-network.c | 1251