Re: [libvirt] [PATCHv3] qemu: NUMA/network tuning shouldn't be supported in session mode

Splendid, thank you John :). Erik On 10/22/2014 09:00 PM, John Ferlan wrote: On 10/01/2014 08:57 AM, Erik Skultety wrote: Tuning NUMA or network interface parameters require root privileges to manage cgroups, thus an attempt to set some of these parameters in session mode on a running domain

Re: [libvirt] [PATCH 02/12] Split driver.h into multiple parts

On Wed, Oct 22, 2014 at 05:00:55PM -0600, Eric Blake wrote: On 10/22/2014 11:14 AM, Daniel P. Berrange wrote: With the large number of APIs in libvirt the driver.h file, it is easy to get lost looking for things. Split each driver into a separate header file based on the functional driver

Re: [libvirt] [PATCH 03/12] Move virDomainSnapshot related APIs out of libvirt.c

On Wed, Oct 22, 2014 at 05:06:54PM -0600, Eric Blake wrote: On 10/22/2014 11:14 AM, Daniel P. Berrange wrote: Introduce a src/libvirt-domain-snapshot.c file to hold all the methods related to the virDomainSnapshot type. --- docs/apibuild.py |1 + po/POTFILES.in

Re: [libvirt] [PATCH 04/12] Move virNetwork related APIs out of libvirt.c

On Wed, Oct 22, 2014 at 10:20:24PM -0600, Eric Blake wrote: On 10/22/2014 11:14 AM, Daniel P. Berrange wrote: Introduce a src/libvirt-network.c file to hold all the methods related to the virNetwork type. --- docs/apibuild.py |1 + po/POTFILES.in|1 +

Re: [libvirt] [PATCH] Show also short-ids when calling --list-{os, platform}

On Wed, Oct 22, 2014 at 04:16:14PM +0200, Fabiano Fidêncio wrote: As the short-id can be used to set the os/platform in the example program, let's expose them to the user. Why not, ACK. Christophe pgpW0QEpc8TbY.pgp Description: PGP signature -- libvir-list mailing list libvir-list@redhat.com

[libvirt] [PATCH] virsh: Improve the job type reported of virsh cmd blockcommit

When begin a blockcommit job(active) with virsh, it will report Block Commit started(it really donesn't matter much), but for more preciese it should report Active Block Commit started Signed-off-by: Shanzhi Yu s...@redhat.com --- tools/virsh-domain.c | 12 +--- 1 file changed, 9

[libvirt] [PATCH 01/12] Move virDomainSnapshot related APIs out of libvirt.h.in

Create a new libvirt-domain-snapshot.h file to hold the public API definitions for the virDomainSnapshot type. This header file is not self-contained, so applications will not directly include it. They will contain to #include libvirt/libvirt.h --- docs/apibuild.py | 1

[libvirt] [PATCH 02/12] Move virNetwork related APIs out of libvirt.h.in

Create a new libvirt-network.h file to hold the public API definitions for the virNetwork type. This header file is not self-contained, so applications will not directly include it. They will contain to #include libvirt/libvirt.h --- include/libvirt/libvirt-network.h | 337

[libvirt] [PATCH 06/12] Move virSecret related APIs out of libvirt.h.in

Create a new libvirt-secret.h file to hold the public API definitions for the virSecret type. This header file is not self-contained, so applications will not directly include it. They will contain to #include libvirt/libvirt.h --- docs/apibuild.py | 1 +

[libvirt] [PATCH 04/12] Move virNWFilter related APIs out of libvirt.h.in

Create a new libvirt-nwfilter.h file to hold the public API definitions for the virNWFilter type. This header file is not self-contained, so applications will not directly include it. They will contain to #include libvirt/libvirt.h --- docs/apibuild.py | 1 +

[libvirt] [PATCH 12/12] Fix preprocessor indentation in libvirt.h.in

The cfg.mk rule for checking preprocessor indentation was mistakenly missing the libvirt.h.in file due to bad file extension matching rule. Fix that and the resolve the incorrect indentation thats identified. --- cfg.mk | 2 +- include/libvirt/libvirt.h.in | 76

[libvirt] [PATCH 00/12] Split up the libvirt.h.in file

Similar to the previous series, this splits up the libvirt.h.in header file to many pieces. This is backwards compatible as applications will continue to use the main libvirt/libvirt.h header and are forbidden from including the individual pieces (to allow us to change them again if we want to in

[libvirt] [PATCH 03/12] Move virInterface related APIs out of libvirt.h.in

Create a new libvirt-interface.h file to hold the public API definitions for the virInterface type. This header file is not self-contained, so applications will not directly include it. They will contain to #include libvirt/libvirt.h --- docs/apibuild.py| 2 +

[libvirt] [PATCH 09/12] Move virEvent related APIs out of libvirt.h.in

Create a new libvirt-event.h file to hold the public API definitions for the virEvent type. This header file is not self-contained, so applications will not directly include it. They will contain to #include libvirt/libvirt.h --- docs/apibuild.py| 1 +

[libvirt] [PATCH 07/12] Move virStream related APIs out of libvirt.h.in

Create a new libvirt-stream.h file to hold the public API definitions for the virStream type. This header file is not self-contained, so applications will not directly include it. They will contain to #include libvirt/libvirt.h Note the definition of virStreamPtr is not moved, since that must be

[libvirt] [PATCH 05/12] Move virNodeDevice related APIs out of libvirt.h.in

Create a new libvirt-nodedev.h file to hold the public API definitions for the virNodeDevice type. This header file is not self-contained, so applications will not directly include it. They will contain to #include libvirt/libvirt.h --- docs/apibuild.py | 1 +

[libvirt] [PATCH 08/12] Move virStoragePool/Vol related APIs out of libvirt.h.in

Create a new libvirt-storage.h file to hold the public API definitions for the virStorage/Vol type. This header file is not self-contained, so applications will not directly include it. They will contain to #include libvirt/libvirt.h --- docs/apibuild.py | 1 +

[libvirt] [PATCH 11/12] Move virConnect related APIs out of libvirt.h.in

Create a new libvirt-host.h file to hold the public API definitions for the virConnect type. This header file is not self-contained, so applications will not directly include it. They will contain to #include libvirt/libvirt.h --- docs/apibuild.py | 1 +

Re: [libvirt] [PATCH 1/5] Implement public API for virDomainGetFSInfo

On 09/30/2014 08:20 PM, Tomoki Sekiyama wrote: virDomainGetFSInfo returns a list of filesystems information mounted in the guest, which contains mountpoints, device names, filesystem types, and device aliases named by libvirt. This will be useful, for example, to specify mountpoints to

Re: [libvirt] [PATCH 2/5] remote: Implement the remote protocol for virDomainGetFSInfo

On 09/30/2014 08:20 PM, Tomoki Sekiyama wrote: Add daemon and driver code to (de-)serialize virDomainFSInfo. Signed-off-by: Tomoki Sekiyama tomoki.sekiy...@hds.com --- daemon/remote.c | 117 ++ src/remote/remote_driver.c | 87

Re: [libvirt] [PATCH 3/5] qemu: Implement the qemu driver for virDomainGetFSInfo

On 09/30/2014 08:20 PM, Tomoki Sekiyama wrote: Get mounted filesystems list, which contains hardware info of disks and its controllers, from QEMU guest agent 2.2+. Then, convert the hardware info to corresponding device aliases for the disks. Signed-off-by: Tomoki Sekiyama

Re: [libvirt] [PATCH 4/5] qemu: add test for qemuAgentGetFSInfo

On 09/30/2014 08:20 PM, Tomoki Sekiyama wrote: Add test cases for qemuAgentGetFSInfo, with a sample agent response for the qemu-get-fsinfo command and a configuration xml. Signed-off-by: Tomoki Sekiyama tomoki.sekiy...@hds.com --- tests/Makefile.am|1

Re: [libvirt] [PATCH 5/5] virsh: expose virDomainGetFSInfo

On 09/30/2014 08:20 PM, Tomoki Sekiyama wrote: Add a domfsinfo command that shows a list of filesystems info mounted in the guest. Perhaps a small example of the command being run and expected output would be nice. Signed-off-by: Tomoki Sekiyama tomoki.sekiy...@hds.com ---

Re: [libvirt] [PATCH 1/n] dumpxml: add flag to virDomainGetXMLDesc

On 17/09/14 08:43 -0600, Eric Blake wrote: + * If @flags contains VIR_DOMAIN_XML_BLOCK_INFO, the listing for each + * disk device will contain additional information such as capacity + * and allocation, similar to what is displayed by virStorageVolGetXMLDesc(), + * and avoiding the need to call

[libvirt] [PATCH 04/11] Update Hyper-V driver to always use privateData

Since the secondary drivers are only active when the primary driver is also the Hyper-V driver, there is no need to use the different type specific privateData fields. --- src/hyperv/hyperv_device_monitor.c | 6 +- src/hyperv/hyperv_interface_driver.c | 6 +-

[libvirt] [PATCH 01/11] Clean up remote driver connection open code

The remote driver has had a long term hack to deal with the fact that the old Xen driver worked outside libvirtd, but the rest of the drivers worked inside. So you could have a local hypervisor driver but everything else go via the remote driver. The Xen driver long ago moved inside libvirtd, so

[libvirt] [PATCH 08/11] Update Test driver to always use privateData

Since the secondary drivers are only active when the primary driver is also the Test driver, there is no need to use the different type specific privateData fields. --- src/test/test_driver.c | 24 ++-- 1 file changed, 6 insertions(+), 18 deletions(-) diff --git

[libvirt] [PATCH 00/11] RFC: refactor internal driver architecture

Currently we have a bit of a craz setup for activating drivers for virConnectPtr. We iterate over the primary hypervisor drivers until one matches and activates. This bit is fine. Then we do the same for the network, storage, interface, etc secondary drivers. This is where the fun starts. In the

[libvirt] [PATCH 06/11] Remove abuse of networkPrivateData in phyp driver

For inexplicable reasons the phyp driver defined two separate structs for holding its private data. One it keeps in privateData and the other it keeps in networkPrivateData. It uses them both from all API driver methods. Merge the two separate structs into one to remove this horrible abuse. ---

[libvirt] [PATCH 07/11] Update Parallels driver to always use privateData

Since the secondary drivers are only active when the primary driver is also the Parallels driver, there is no need to use the different type specific privateData fields. The object that was being stored in the storagePrivateData can easily be kept in the parallelsConn struct instead. ---

[libvirt] [PATCH 03/11] Update ESX driver to always use privateData

Since the secondary drivers are only active when the primary driver is also the ESX driver, there is no need to use the different type specific privateData fields. --- src/esx/esx_device_monitor.c| 6 + src/esx/esx_interface_driver.c | 16 +-

[libvirt] [PATCH 09/11] Remove use of storagePrivateData from storage driver

The shared storage driver is stateful and inside the daemon so there is no need to use the storagePrivateData field to get the driver handle. Just access the global driver handle directly. --- src/storage/storage_driver.c | 194 +++ 1 file changed, 86

[libvirt] [PATCH 02/11] Update remote driver to always use privateData

Since the secondary drivers are only active when the primary driver is also the remote driver, there is no need to use the different type specific privateData fields. --- src/remote/remote_driver.c | 84 +- src/rpc/gendispatch.pl | 28

[libvirt] [PATCH 10/11] Remove use of networkPrivateData from network driver

The shared network driver is stateful and inside the daemon so there is no need to use the networkPrivateData field to get the driver handle. Just access the global driver handle directly. Many places already directly accessed the global driver handle in any case, so the code could never work

[libvirt] [PATCH 05/11] Move phyp internal info out of the header file

The phyp_driver.h file has various declarations that are only ever used from phyp_driver.c, so they should be in the .c file only. --- src/phyp/phyp_driver.c | 49 ++ src/phyp/phyp_driver.h | 53 -- 2

[libvirt] [PATCH 11/11] Remove use of networkPrivateData from netcf driver

The shared netcf driver is stateful and inside the daemon so there is no need to use the networkPrivateData field to get the driver handle. Just access the global driver handle directly. --- src/interface/interface_backend_netcf.c | 71 +++-- 1 file changed, 23

[libvirt] [PATCH 00/12] parallels: use SDK in parallels_driver.c

This patch series replaces all code, which used prlctl command to interact with parallels cloud server with calls to parallels sdk functions. The model of this driver remain almost the same - in creates a list of virDomainObj objects on connect and then functions, which returns different

[libvirt] [PATCH 07/12] parallels: create VMs and containers with sdk

This patch replaces code, which creates domains by running prlctl command. prlsdkCreateVm/Ct will do prlsdkApplyConfig, because we send request to the server only once in this case. But prlsdkApplyConfig will be called also from parallelsDomainDefineXML function. There is no problem with it,

[libvirt] [PATCH 08/12] parallels: fix parallelsDomainDefineXML

First, we don't need to call prlsdkApplyConfig after creating new VM or containers, because it's done in functions prlsdkCreateVm and prlsdkCreateCt. Also we don't need to calls prlsdkAddDomain here, because new domain will be added to domains list from the events handler. Signed-off-by: Dmitry

[libvirt] [PATCH 05/12] parallels: reimplement functions, which change domain state

Change domain state using parallels SDK functions instead of prlctl command. We don't need to send events and update domains in privconn-domains list in these functions anymore, because it's done in prlsdkEventsHandler. Each time we do something with domain, parallels server sends an event,

[libvirt] [PATCH 11/12] parallels: add cdroms support

Get cdrom devices list from parallels server in prlsdkLoadDomains and add ability to define a domain with cdroms. Signed-off-by: Dmitry Guryanov dgurya...@parallels.com --- src/parallels/parallels_sdk.c | 70 ++- 1 file changed, 63 insertions(+), 7

[libvirt] [PATCH 09/12] parallels: added function virDomainIsActive()

From: Alexander Burluka aburl...@parallels.com That function is necessary for proper domain removal in openstack/nova. Signed-off-by: Dmitry Guryanov dgurya...@parallels.com --- src/parallels/parallels_driver.c | 19 +++ 1 file changed, 19 insertions(+) diff --git

[libvirt] [PATCH 03/12] parallels: handle events from parallels server

From: Alexander Burluka aburl...@parallels.com Subscribe to events from parallels server. It's needed for 2 things: to update cached domains list and to send corresponding libvirt events. Parallels server sends a lot of different events, in this patch we handle only some of them. In the future

[libvirt] [PATCH 04/12] parallels: move parallelsDomNotFoundError to parallels_utils.h

Move macro parallelsDomNotFoundError to file parallels_utils.h, because it will be used in parallels_sdk.c. Signed-off-by: Dmitry Guryanov dgurya...@parallels.com --- src/parallels/parallels_driver.c | 8 src/parallels/parallels_utils.h | 8 2 files changed, 8 insertions(+), 8

[libvirt] [PATCH 10/12] parallels: Add domainCreateWithFlags() function.

From: Alexander Burluka aburl...@parallels.com domainCreateWithFlags function is used by OpenStack/Nova to boot an instance. Signed-off-by: Dmitry Guryanov dgurya...@parallels.com --- src/parallels/parallels_driver.c | 10 ++ 1 file changed, 10 insertions(+) diff --git

[libvirt] [PATCH 02/12] parallels: get domain info with SDK

From: Alexander Burluka aburl...@parallels.com Obtain information about domains using parallels sdk instead of prlctl. prlsdkLoadDomains functions behaves as former parallelsLoadDomains with NULL as second parameter (name) - it fills parallelsConn.domains list. prlsdkLoadDomain is now able

[libvirt] [PATCH 01/12] parallels: move IS_CT macro to parallels_utils.h

This macro will be used in paralles_sdk.c so move it to common header. Signed-off-by: Dmitry Guryanov dgurya...@parallels.com --- src/parallels/parallels_driver.c | 2 -- src/parallels/parallels_utils.h | 2 ++ 2 files changed, 2 insertions(+), 2 deletions(-) diff --git

[libvirt] [PATCH 12/12] parallels: implement domainUndefine and domainUndefineFlags

Signed-off-by: Dmitry Guryanov dgurya...@parallels.com --- src/parallels/parallels_driver.c | 30 ++ src/parallels/parallels_sdk.c| 10 ++ src/parallels/parallels_sdk.h| 2 ++ 3 files changed, 42 insertions(+) diff --git

[libvirt] [PATCH 06/12] parallels: rewrite parallelsApplyConfig with SDK

Rewrite code, which applies domain configuration given to virDomainDefineXML function to the VM of container registered in PCS. This code first check if there are unsupported parameters in domain XML and if yes - reports error. Some of such parameters are not supported by PCS, for some - it's not

Re: [libvirt] [PATCH v2 0/3] Resolve libvirtd crash matching scsi_host

Ping again - Tks John On 10/06/2014 05:49 PM, John Ferlan wrote: https://bugzilla.redhat.com/show_bug.cgi?id=1146837 Rewrite the v1 patch to take a different method to attack the problem. Expose the getHostNumber from scsi check/startup/refresh in the form of virGetSCSIHostNumber.

Re: [libvirt] [PATCH v3 0/7] hotplug: Fix libvirtd crash on qemu-attached guest

Ping again Tks, John On 10/08/2014 08:08 PM, John Ferlan wrote: v2 is here: http://www.redhat.com/archives/libvir-list/2014-September/msg01575.html As Michal pointed out in his review - other devices could have the same issue - so take care of each of them separately (I already knew

[libvirt] [PATCH] Fix indentation of sysinfo data

The sysinfo data block was indented by 2 spaces too many. This was missed because we never had any test validating the XML formatting. --- src/conf/domain_conf.c | 13 + tests/qemuxml2argvdata/qemuxml2argv-smbios-date.xml | 16 ++--

Re: [libvirt] [PATCH] Fix indentation of sysinfo data

On 10/23/2014 11:36 AM, Daniel P. Berrange wrote: The sysinfo data block was indented by 2 spaces too many. This was missed because we never had any test validating the XML formatting. --- src/conf/domain_conf.c | 13 +

Re: [libvirt] [PATCH 05/12] Move virInterface related APIs out of libvirt.c

On 10/22/2014 11:14 AM, Daniel P. Berrange wrote: Introduce a src/libvirt-interface.c file to hold all the methods related to the virInterface type. --- docs/apibuild.py| 1 + src/Makefile.am | 2 + src/libvirt-interface.c | 835

Re: [libvirt] [PATCH 06/12] Move virNWFilter related APIs out of libvirt.c

On 10/22/2014 11:14 AM, Daniel P. Berrange wrote: Introduce a src/libvirt-nwfilter.c file to hold all the methods related to the virNWFilter type. --- docs/apibuild.py | 1 + po/POTFILES.in | 1 + src/Makefile.am| 2 + src/libvirt-nwfilter.c | 515

Re: [libvirt] [PATCH 07/12] Move virNodeDevice related APIs out of libvirt.c

On 10/22/2014 11:14 AM, Daniel P. Berrange wrote: Introduce a src/libvirt-nodedev.c file to hold all the methods related to the virNodeDevice type. --- docs/apibuild.py | 1 + src/Makefile.am | 2 + src/libvirt-nodedev.c | 756

Re: [libvirt] [PATCH 08/12] Move virSecret related APIs out of libvirt.c

On 10/22/2014 11:14 AM, Daniel P. Berrange wrote: Introduce a src/libvirt-secret.c file to hold all the methods related to the virSecret type. --- docs/apibuild.py | 1 + po/POTFILES.in | 1 + src/Makefile.am | 2 + src/libvirt-secret.c | 695

Re: [libvirt] [PATCH 09/12] Move virStream related APIs out of libvirt.c

On 10/22/2014 11:14 AM, Daniel P. Berrange wrote: Introduce a src/libvirt-stream.c file to hold all the methods related to the virStream type. --- cfg.mk | 4 +- docs/apibuild.py | 1 + po/POTFILES.in | 1 + src/Makefile.am | 2 + src/libvirt-stream.c

Re: [libvirt] [PATCH 10/12] Move virStorage{Pool, Vol} related APIs out of libvirt.c

On 10/22/2014 11:15 AM, Daniel P. Berrange wrote: Introduce a src/libvirt-storage.c file to hold all the methods related to the virStorage{Pool,Vol} types. --- docs/apibuild.py |1 + po/POTFILES.in|1 + src/Makefile.am |2 + src/libvirt-storage.c | 2118

[libvirt] [PATCH 1/2] bhyve: Support /domain/bootloader configuration for non-FreeBSD guests.

Also, flip Bhyve /domain/os/type support from HVM to Xen. Bhyve only supports paravirtualized guests, and 'xen' is closest to that. We still default to bhyveloader(1) if no explicit bootloader configuration is supplied in the domain. If the /domain/bootloader looks like grub-bhyve and the user

[libvirt] [PATCH 0/2] Add non-FreeBSD guest support to Bhyve driver.

First-time libvirt contributor here. Apologies if I've made beginner mistakes, etc. If something needs fixing, please let me know and I'll try and take care of it expediently. First, the bhyve driver expected and assumed an OS type of 'hvm'. I think this was incorrect. Bhyve does not provide a

[libvirt] [PATCH 2/2] Generated PO files for 'bhyve: Support /domain/bootloader'

Sponsored by: EMC / Isilon storage division Signed-off-by: Conrad Meyer conrad.me...@isilon.com --- po/af.po | 4 po/am.po | 4 po/ar.po | 4 po/as.po | 4 po/be.po | 4 po/bg.po | 4 po/bn.po | 4 po/bn_IN.po| 4

Re: [libvirt] [PATCH 11/12] Move virDomain related APIs out of libvirt.c

On 10/22/2014 11:15 AM, Daniel P. Berrange wrote: Introduce a src/libvirt-domain.c file to hold all the methods related to the virDomain type. --- docs/apibuild.py | 2 + po/POTFILES.in | 1 + src/Makefile.am| 2 + src/libvirt-domain.c | 2

Re: [libvirt] [PATCH 11/12] Move virDomain related APIs out of libvirt.c

On 10/23/2014 02:17 PM, Eric Blake wrote: On 10/22/2014 11:15 AM, Daniel P. Berrange wrote: Introduce a src/libvirt-domain.c file to hold all the methods related to the virDomain type. --- docs/apibuild.py | 2 + po/POTFILES.in | 1 + src/Makefile.am| 2 +

Re: [libvirt] [PATCH 12/12] Move virConnect/virNode related APIs out of libvirt.c

On 10/22/2014 11:15 AM, Daniel P. Berrange wrote: Introduce a src/libvirt-host.c file to hold all the methods related to the virConnect type. --- docs/apibuild.py |1 + po/POTFILES.in |1 + src/Makefile.am|2 + src/libvirt-host.c | 1515

[libvirt] [libvirt-tck PATCH] Fix PCI device hotplug tests

This patch fixes a few issues noted while enabling the TCK PCI device hotplug tests. First, the call to node device dettach function misses parameters, resulting in the following failure Failed test 'detached device from host OS' at /usr/share/libvirt-tck/tests/domain/250-pci-host-hotplug.t

Re: [libvirt] [Qemu-devel] spec, RFC: TLS support for NBDµ

For me... On 10/21/14, 1:30 PM, Wouter Verhelst w...@uter.be wrote: Hi Markus, On Tue, Oct 21, 2014 at 10:17:17AM +0200, Markus Armbruster wrote: Misunderstanding. I didn't mean to claim STARTTLS is bad. If I wanted to say that, I would've said it directly. I was merely asking how you

Re: [libvirt] [libvirt-tck PATCH] Fix PCI device hotplug tests

On 10/23/2014 03:21 PM, Jim Fehlig wrote: This patch fixes a few issues noted while enabling the TCK PCI device hotplug tests. First, the call to node device dettach function misses parameters, resulting in the following failure Failed test 'detached device from host OS' at

Re: [libvirt] [PATCH 01/12] Move virDomainSnapshot related APIs out of libvirt.h.in

On 10/23/2014 06:58 AM, Daniel P. Berrange wrote: Create a new libvirt-domain-snapshot.h file to hold the public API definitions for the virDomainSnapshot type. This header file is not self-contained, so applications will not directly include it. They will contain to #include libvirt/libvirt.h

Re: [libvirt] [PATCH v2 1/21] hyperv: avoid query memleaks on failure

On 10/08/2014 10:29 AM, Eric Blake wrote: The function hypervEnumAndPull consumes query on success, but leaked it on failure. Rather than having to change all callers (many of them indirect callers through the generated hypervGetMsvmComputerSystemList), it was easier to just guarantee that

Re: [libvirt] [PATCH 02/12] Move virNetwork related APIs out of libvirt.h.in

On 10/23/2014 06:58 AM, Daniel P. Berrange wrote: Create a new libvirt-network.h file to hold the public API definitions for the virNetwork type. This header file is not self-contained, so applications will not directly include it. They will contain to #include libvirt/libvirt.h

[libvirt] [PATCHv2 1/2] bhyve: Support /domain/bootloader configuration for non-FreeBSD guests.

We still default to bhyveloader(1) if no explicit bootloader configuration is supplied in the domain. If the /domain/bootloader looks like grub-bhyve and the user doesn't supply /domain/bootloader_args, we make an intelligent guess and try chainloading the first partition on the disk. Caveats: -

[libvirt] [PATCHv2 0/2] Add non-FreeBSD guest support to Bhyve driver.

Drvbhyve hardcodes bhyveload(8) as the host bootloader for guests. bhyveload(8) loader only supports FreeBSD guests. This patch adds bootloader and bootloader_args handling to bhyve_command, so libvirt can boot non-FreeBSD guests in Bhyve. See patch logs for further details. Thanks, Conrad

[libvirt] [PATCHv2 2/2] Generated PO files for 'bhyve: Support /domain/bootloader'

Sponsored by: EMC / Isilon storage division Signed-off-by: Conrad Meyer conrad.me...@isilon.com --- po/af.po | 4 po/am.po | 4 po/ar.po | 4 po/as.po | 4 po/be.po | 4 po/bg.po | 4 po/bn.po | 4 po/bn_IN.po| 4

Re: [libvirt] [libvirt-designer][PATCH] Show also short-ids when calling --list-{os, platform}

On 22.10.2014 16:16, Fabiano Fidêncio wrote: As the short-id can be used to set the os/platform in the example program, let's expose them to the user. --- examples/virt-designer.c | 16 ++-- 1 file changed, 10 insertions(+), 6 deletions(-) diff --git a/examples/virt-designer.c

[libvirt] [PATCH 00/19] vbox: Rewrite the storage driver

This is the last part of rewriting vbox driver. The approache is almost the same as the previous. Some code problems such as copyright and irregular macros are fixed in this series. Taowei Luo (19): vbox: Fix copyright mistake vbox: Remove VBOX_OBJECT_CHECK macro vbox: move common codes to

[libvirt] [PATCH 03/19] vbox: move common codes to vbox_common.h

There are lots of macro declarations in vbox_common.c, vbox_network.c, and the coming vbox_storage.c which simply the API calling. Since they are totally the same. We shouldn't keep three copies of that, so they are moved to vbox_common.h. Note: The macros are quite different from those in

[libvirt] [PATCH 01/19] vbox: Fix copyright mistake

I made a mistake on copyright in patch 7f0f415b87. If I copied codes from one file to another, I should copy the copyright announcement as well. So this patch makes up the copyright which I should have added in the previous patch. --- src/vbox/vbox_common.c|4 +++-

[libvirt] [PATCH 04/19] vbox: Rewrite vbox-independent functions

This patch rewrites the following functions *vboxStorageOpen *vboxStorageClose *vboxConnectNumOfStoragePools *vboxConnectListStoragePools *vboxStoragePoolLookupByName These functions do not call any vbox API, so I directly move it from vbox_tmpl.c to vbox_storage.c A small

[libvirt] [PATCH 05/19] vbox: Rewrite vboxStoragePoolNumOfVolumes

We use typedef IMedium IHardDisk to make IHardDisk hierachy from IMedium (Actually it did on vbox 2.2 and 3.0's C++ API). So when calling VBOX_MEDIUM_FUNC_ARG*(IHardDisk, func, args) we can directly replace it to gVBoxAPI.UIMedium.func(IHardDisk, args) When dealing with this two types, we

[libvirt] [PATCH 11/19] vbox: Make CreateHardDisk support all vbox versions

The CreateHardDiskMedium only support create HardDisk for medium type, and it only works when vbox version = 3.1. This patch make the function workable with all vbox versions and rename it as CreateHardDisk. In vbox 2.2 and 3.0 this function will create a IHardDisk object. In vbox later than 3.0,

[libvirt] [PATCH 07/19] vbox: Rewrite vboxStorageVolLookupByName

--- src/vbox/vbox_storage.c | 73 + src/vbox/vbox_tmpl.c | 65 src/vbox/vbox_uniformed_api.h |2 ++ 3 files changed, 75 insertions(+), 65 deletions(-) diff --git a/src/vbox/vbox_storage.c

[libvirt] [PATCH 02/19] vbox: Remove VBOX_OBJECT_CHECK macro

We should follow the rules that CHECK macro only do checking works. But this VBOX_OBJECT_CHECK and VBOX_OBJECT_HOST_CHECK declared some varibles at the same time, which broke the rule. So the patch removed this macros and dispatched it in source code. The storage driver is still not rewriten at

[libvirt] [PATCH 06/19] vbox: Rewrite vboxStoragePoolListVolumes

--- src/vbox/vbox_storage.c | 56 + src/vbox/vbox_tmpl.c | 54 +-- src/vbox/vbox_uniformed_api.h |2 ++ 3 files changed, 64 insertions(+), 48 deletions(-) diff --git a/src/vbox/vbox_storage.c

[libvirt] [PATCH 08/19] vbox: Rewrite vboxStorageVolLookupByKey

--- src/vbox/vbox_storage.c | 67 +++ src/vbox/vbox_tmpl.c | 88 + src/vbox/vbox_uniformed_api.h |3 +- 3 files changed, 88 insertions(+), 70 deletions(-) diff --git a/src/vbox/vbox_storage.c

[libvirt] [PATCH 09/19] vbox: Make FindMedium support old vbox versions

In old version, function FindMedium in UIVirtualBox doesn't work for vbox2.2 and 3.0. We assume it will not be used when vbox in these versions. But when rewriting vboxStorageVolLookupByPath, we found it was compatibe to use FindMedium to get a IHardDisk object, even in vbox old versions. To

[libvirt] [PATCH 10/19] vbox: Rewrite vboxStorageVolLookupByPath

--- src/vbox/vbox_storage.c | 77 + src/vbox/vbox_tmpl.c | 77 - src/vbox/vbox_uniformed_api.h |1 + 3 files changed, 78 insertions(+), 77 deletions(-) diff --git a/src/vbox/vbox_storage.c

[libvirt] [PATCH 13/19] vbox: Make IMediumAttachment work with vbox2.2 and 3.0

The GetMedium will always return a IHardDisk object them. In 2.2 and 3.0, it is what GetHardDisk exactly do. In 3.1 and later, The IMedium is same as IHardDisk. --- src/vbox/vbox_tmpl.c |9 - src/vbox/vbox_uniformed_api.h |2 +- 2 files changed, 5 insertions(+), 6

[libvirt] [PATCH 12/19] vbox: Rewrite vboxStorageVolCreateXML

If the path in target element is not given, libvirt will put the new volume in ~/.VirtualBox by default. --- src/vbox/vbox_common.h| 10 src/vbox/vbox_storage.c | 110 +++ src/vbox/vbox_tmpl.c | 114

[libvirt] [PATCH 14/19] vbox: Rewrite vboxStorageVolDelete

The API on IHardDiskAttachment is merged into IMediumAttachment. So, we don't need it anymore. --- src/vbox/vbox_storage.c | 160 src/vbox/vbox_tmpl.c | 202 ++--- src/vbox/vbox_uniformed_api.h |6 ++ 3

[libvirt] [PATCH 17/19] vbox: Rewrite vboxStorageVolGetPath

--- src/vbox/vbox_storage.c | 55 + src/vbox/vbox_tmpl.c | 61 - src/vbox/vbox_uniformed_api.h |1 + 3 files changed, 56 insertions(+), 61 deletions(-) diff --git a/src/vbox/vbox_storage.c

[libvirt] [PATCH 15/19] vbox: Rewrite vboxStorageVolGetInfo

--- src/vbox/vbox_storage.c | 56 +++ src/vbox/vbox_tmpl.c | 100 + src/vbox/vbox_uniformed_api.h |3 ++ 3 files changed, 89 insertions(+), 70 deletions(-) diff --git a/src/vbox/vbox_storage.c

[libvirt] [PATCH 16/19] vbox: Rewrite vboxStorageVolGetXMLDesc

--- src/vbox/vbox_storage.c | 93 +++ src/vbox/vbox_tmpl.c | 124 +++-- src/vbox/vbox_uniformed_api.h |2 + 3 files changed, 102 insertions(+), 117 deletions(-) diff --git a/src/vbox/vbox_storage.c

[libvirt] [PATCH 18/19] vbox: New storage driver

This patch provides the new stroage driver for vbox. The work is similar with patch 87dea4fc and the next b4022de33. --- src/Makefile.am | 12 +++-- src/vbox/vbox_driver.c| 99 ++-- src/vbox/vbox_get_driver.h|1 +

[libvirt] [PATCH 19/19] vbox: Remove unused things in vbox_tmpl.c

After rewriting the whole driver, Only version specified code is remained in vbox_tmpl.c. So, this patch removes those unused macros header files in vbox_tmpl.c. --- src/vbox/vbox_tmpl.c | 60 +- 1 file changed, 1 insertion(+), 59 deletions(-)

[libvirt] [PATCH] remote: fix jump depends on uninitialised value

Currently remote driver only initializes partial fields of remote_connect_get_all_domain_stats_args. But xdr_array() will check the uninitialised field 'doms_val'. For safty reason, memset all fields of args is better. Fix the following error from valgrind, like: ==30515== 1 errors in context 1

Re: [libvirt] [PATCH 03/12] Move virInterface related APIs out of libvirt.h.in

On 10/23/2014 06:58 AM, Daniel P. Berrange wrote: Create a new libvirt-interface.h file to hold the public API definitions for the virInterface type. This header file is not self-contained, so applications will not directly include it. They will contain to #include libvirt/libvirt.h same

Re: [libvirt] [PATCHv2 1/2] bhyve: Support /domain/bootloader configuration for non-FreeBSD guests.

Conrad Meyer wrote: We still default to bhyveloader(1) if no explicit bootloader configuration is supplied in the domain. If the /domain/bootloader looks like grub-bhyve and the user doesn't supply /domain/bootloader_args, we make an intelligent guess and try chainloading the first

Re: [libvirt] [RFC] Can we error out early for unknown device models?

On 22.10.2014 13:58, Martin Kletzander wrote: Hi everyone, I had this idea that since we are probing QEMU binaries for devices using 'qom-list-types', we could store that data in the capabilities and check whether device models are supported before starting QEMU. We do that for _some newer_

Re: [libvirt] [RFC] Add support for NIC offload discovery

On 22.10.2014 14:02, Chapman, James P wrote: Currently libvirt provides lots of useful information on the HW capabilities of the host and its attached devices. I’m interested in extending the HW capability discovery of libvirt, to a point where it is capable of discovering the HW offload

  1   2   >