[libvirt] [PATCH] lxc: fix setmem effect on a running LXC machine

2014-10-24 Thread Erik Skultety
When user calls setmem on a running LXC machine, we do update its cgroup entry (which is in odds with the original bug report, possibly resolved by later versions), however we neither update domain's runtime XML nor we update our internal structures and this patch fixes it. Resolves:

[libvirt] [PATCH] vbox: network: make sure driver not be NULL in virRegisterNetworkDriver

2014-10-24 Thread Shanzhi Yu
libvirtd will report below error if does not make sure driver not be NULL in virRegisterNetworkDriver $ libvirtd 2014-10-24 09:24:36.443+: 28876: info : libvirt version: 1.2.10 2014-10-24 09:24:36.443+: 28876: error : virRegisterNetworkDriver:549 : driver in virRegisterNetworkDriver must

Re: [libvirt] [RFC] Can we error out early for unknown device models?

2014-10-24 Thread Martin Kletzander
On Fri, Oct 24, 2014 at 07:16:44AM +0200, Michal Privoznik wrote: On 22.10.2014 13:58, Martin Kletzander wrote: Hi everyone, I had this idea that since we are probing QEMU binaries for devices using 'qom-list-types', we could store that data in the capabilities and check whether device models

Re: [libvirt] [RFC] Can we error out early for unknown device models?

2014-10-24 Thread Daniel P. Berrange
On Fri, Oct 24, 2014 at 12:15:24PM +0200, Martin Kletzander wrote: On Fri, Oct 24, 2014 at 07:16:44AM +0200, Michal Privoznik wrote: On 22.10.2014 13:58, Martin Kletzander wrote: Hi everyone, I had this idea that since we are probing QEMU binaries for devices using 'qom-list-types', we

[libvirt] [PATCH v2] tests: Adding SELINUX_LIBS to fix viridentitytest linker bug.

2014-10-24 Thread Julio Faracco
In a clean build system (Ubuntu 14.04), the viridentitytest failed to compile. Even if all the SELINUX libraries and depedencies are installed. See the error message below: [...] CC viridentitytest.o CCLD viridentitytest /usr/bin/ld: viridentitytest.o: undefined reference to symbol

Re: [libvirt] [PATCH v2] tests: Adding SELINUX_LIBS to fix viridentitytest linker bug.

2014-10-24 Thread Julio Faracco
Just rewriting the commit message. The last one was too personal in my opinion. -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCHv2 1/2] bhyve: Support /domain/bootloader configuration for non-FreeBSD guests.

2014-10-24 Thread Conrad Rad
On Fri, Oct 24, 2014 at 12:58 AM, Roman Bogorodskiy bogorods...@gmail.com wrote: Conrad Meyer wrote: Hi Conrad. Thanks for the patch. As for the /tmp, probably storing it somewhere in BHYVE_STATE_DIR would be more clean. Sure. However, I'm concerned about libvirt dealing with the

Re: [libvirt] [PATCHv2 1/2] bhyve: Support /domain/bootloader configuration for non-FreeBSD guests.

2014-10-24 Thread Roman Bogorodskiy
Conrad Rad wrote: On Fri, Oct 24, 2014 at 12:58 AM, Roman Bogorodskiy bogorods...@gmail.com wrote: Conrad Meyer wrote: Hi Conrad. Thanks for the patch. As for the /tmp, probably storing it somewhere in BHYVE_STATE_DIR would be more clean. Sure. However, I'm concerned about

Re: [libvirt] [PATCH] vbox: network: make sure driver not be NULL in virRegisterNetworkDriver

2014-10-24 Thread Eric Blake
On 10/24/2014 03:31 AM, Shanzhi Yu wrote: libvirtd will report below error if does not make sure driver not be NULL in virRegisterNetworkDriver $ libvirtd 2014-10-24 09:24:36.443+: 28876: info : libvirt version: 1.2.10 2014-10-24 09:24:36.443+: 28876: error :

Re: [libvirt] [PATCH] vbox: network: make sure driver not be NULL in virRegisterNetworkDriver

2014-10-24 Thread Daniel P. Berrange
On Fri, Oct 24, 2014 at 08:47:47AM -0600, Eric Blake wrote: On 10/24/2014 03:31 AM, Shanzhi Yu wrote: libvirtd will report below error if does not make sure driver not be NULL in virRegisterNetworkDriver $ libvirtd 2014-10-24 09:24:36.443+: 28876: info : libvirt version: 1.2.10

Re: [libvirt] [libvirt-tck PATCH] Fix PCI device hotplug tests

2014-10-24 Thread Jim Fehlig
Eric Blake wrote: On 10/23/2014 03:21 PM, Jim Fehlig wrote: This patch fixes a few issues noted while enabling the TCK PCI device hotplug tests. First, the call to node device dettach function misses parameters, resulting in the following failure Failed test 'detached device from host

Re: [libvirt] [PATCH 04/12] Move virNWFilter related APIs out of libvirt.h.in

2014-10-24 Thread Eric Blake
On 10/23/2014 06:58 AM, Daniel P. Berrange wrote: Create a new libvirt-nwfilter.h file to hold the public API definitions for the virNWFilter type. This header file is not self-contained, so applications will not directly include it. They will contain to #include libvirt/libvirt.h ---

Re: [libvirt] [libvirt-tck PATCH] Fix PCI device hotplug tests

2014-10-24 Thread Daniel P. Berrange
On Fri, Oct 24, 2014 at 09:15:42AM -0600, Jim Fehlig wrote: Eric Blake wrote: On 10/23/2014 03:21 PM, Jim Fehlig wrote: This patch fixes a few issues noted while enabling the TCK PCI device hotplug tests. First, the call to node device dettach function misses parameters,

Re: [libvirt] [PATCH 05/12] Move virNodeDevice related APIs out of libvirt.h.in

2014-10-24 Thread Eric Blake
On 10/23/2014 06:58 AM, Daniel P. Berrange wrote: Create a new libvirt-nodedev.h file to hold the public API definitions for the virNodeDevice type. This header file is not self-contained, so applications will not directly include it. They will contain to #include libvirt/libvirt.h Don't

Re: [libvirt] [PATCH 06/12] Move virSecret related APIs out of libvirt.h.in

2014-10-24 Thread Eric Blake
On 10/23/2014 06:58 AM, Daniel P. Berrange wrote: Create a new libvirt-secret.h file to hold the public API definitions for the virSecret type. This header file is not self-contained, so applications will not directly include it. They will contain to #include libvirt/libvirt.h ---

Re: [libvirt] [PATCH 07/12] Move virStream related APIs out of libvirt.h.in

2014-10-24 Thread Eric Blake
On 10/23/2014 06:58 AM, Daniel P. Berrange wrote: Create a new libvirt-stream.h file to hold the public API definitions for the virStream type. This header file is not self-contained, so applications will not directly include it. They will contain to #include libvirt/libvirt.h Note the

Re: [libvirt] [libvirt-tck PATCH] Fix PCI device hotplug tests

2014-10-24 Thread Jim Fehlig
Daniel P. Berrange wrote: On Fri, Oct 24, 2014 at 09:15:42AM -0600, Jim Fehlig wrote: Eric Blake wrote: On 10/23/2014 03:21 PM, Jim Fehlig wrote: This patch fixes a few issues noted while enabling the TCK PCI device hotplug tests. First, the call to node device dettach

Re: [libvirt] [libvirt-tck PATCH] Fix PCI device hotplug tests

2014-10-24 Thread Daniel P. Berrange
On Fri, Oct 24, 2014 at 09:29:29AM -0600, Jim Fehlig wrote: Daniel P. Berrange wrote: On Fri, Oct 24, 2014 at 09:15:42AM -0600, Jim Fehlig wrote: Eric Blake wrote: On 10/23/2014 03:21 PM, Jim Fehlig wrote: This patch fixes a few issues noted while enabling the

Re: [libvirt] [PATCH 08/12] Move virStoragePool/Vol related APIs out of libvirt.h.in

2014-10-24 Thread Eric Blake
On 10/23/2014 06:58 AM, Daniel P. Berrange wrote: Create a new libvirt-storage.h file to hold the public API definitions for the virStorage/Vol type. This header file is not self-contained, so applications will not directly include it. They will contain to #include libvirt/libvirt.h ---

Re: [libvirt] [PATCH 09/12] Move virEvent related APIs out of libvirt.h.in

2014-10-24 Thread Eric Blake
On 10/23/2014 06:58 AM, Daniel P. Berrange wrote: Create a new libvirt-event.h file to hold the public API definitions for the virEvent type. This header file is not self-contained, so applications will not directly include it. They will contain to #include libvirt/libvirt.h ---

Re: [libvirt] [PATCH 10/12] Move virDomain related APIs out of libvirt.h.in

2014-10-24 Thread Eric Blake
On 10/23/2014 06:58 AM, Daniel P. Berrange wrote: Create a new libvirt-domain.h file to hold the public API definitions for the virDomain type. This header file is not self-contained, so applications will not directly include it. They will contain to #include libvirt/libvirt.h --- cfg.mk

Re: [libvirt] [PATCH 11/12] Move virConnect related APIs out of libvirt.h.in

2014-10-24 Thread Eric Blake
On 10/23/2014 06:58 AM, Daniel P. Berrange wrote: Create a new libvirt-host.h file to hold the public API definitions for the virConnect type. This header file is not self-contained, so applications will not directly include it. They will contain to #include libvirt/libvirt.h One last

Re: [libvirt] [PATCH 12/12] Fix preprocessor indentation in libvirt.h.in

2014-10-24 Thread Eric Blake
On 10/23/2014 06:58 AM, Daniel P. Berrange wrote: The cfg.mk rule for checking preprocessor indentation was mistakenly missing the libvirt.h.in file due to bad file extension matching rule. Fix that and the resolve the incorrect indentation thats identified. s/thats/that's/ --- cfg.mk

Re: [libvirt] [PATCH 03/12] Move virInterface related APIs out of libvirt.h.in

2014-10-24 Thread Daniel P. Berrange
On Thu, Oct 23, 2014 at 10:11:37PM -0600, Eric Blake wrote: On 10/23/2014 06:58 AM, Daniel P. Berrange wrote: Create a new libvirt-interface.h file to hold the public API definitions for the virInterface type. This header file is not self-contained, so applications will not directly

Re: [libvirt] [PATCH] vbox: network: make sure driver not be NULL in virRegisterNetworkDriver

2014-10-24 Thread Shanzhi Yu
On 10/24/2014 10:52 PM, Daniel P. Berrange wrote: On Fri, Oct 24, 2014 at 08:47:47AM -0600, Eric Blake wrote: On 10/24/2014 03:31 AM, Shanzhi Yu wrote: libvirtd will report below error if does not make sure driver not be NULL in virRegisterNetworkDriver $ libvirtd 2014-10-24

Re: [libvirt] [PATCHv3] qemu: NUMA/network tuning shouldn't be supported in session mode

2014-10-24 Thread Laine Stump
On 10/22/2014 03:00 PM, John Ferlan wrote: On 10/01/2014 08:57 AM, Erik Skultety wrote: Tuning NUMA or network interface parameters require root privileges to manage cgroups, thus an attempt to set some of these parameters in session mode on a running domain should be invalid followed by an

Re: [libvirt] [PATCH] vbox: network: make sure driver not be NULL in virRegisterNetworkDriver

2014-10-24 Thread Eric Blake
On 10/24/2014 10:17 AM, Shanzhi Yu wrote: if (networkDriver virRegisterNetworkDriver(networkDriver) 0) ACK to this. Or did you botch the logic, and really mean: if (!networkDriver || virRegisterNetworkDriver(networkDriver) 0) Furthermore, Dan's recent patch series will probably

[libvirt] [PATCH] util: eliminate use after free in callers of virNetDevLinkDump

2014-10-24 Thread Laine Stump
virNetDevLinkDump() gets a message from netlink into resp, then calls nlmsg_parse() to fill the table tb with pointers into resp. It then returns tb to its caller, but not before freeing the buffer at resp. That means that all the callers of virNetDevLinkDump() are examining memory that has

Re: [libvirt] [PATCH v2] esx: Simplify VI (vSphere) API and VMware product version handling

2014-10-24 Thread Eric Blake
On 10/18/2014 04:08 PM, Matthias Bolte wrote: Store version numbers in this format version = 100 * major + 1000 * minor + micro produced by virParseVersionString instead of dedicated enums. Split the complex esxVI_ProductVersion enum into a simpler esxVI_ProductLine enum and a

Re: [libvirt] [libvirt-python PATCH] Add a type check for time in libvirt_virDomainSetTime

2014-10-24 Thread Eric Blake
On 10/20/2014 03:43 AM, Luyao Huang wrote: When pass a number or other things to setTime,no error output,but set time to 0. Add a type check and give a clear error messages: TypeError: time must be dict Signed-off-by: Luyao Huang lhu...@redhat.com --- libvirt-override.c | 5 + 1

Re: [libvirt] [Qemu-devel] Close the BlockDriverState when guest eject the media

2014-10-24 Thread Eric Blake
On 10/21/2014 12:10 AM, Gonglei wrote: There is a problem. 1. Qemu receive the eject command. 2. Runs eject_request_cb when an eject request is issued from the monitor, the tray is closed, and the medium is locked. But the drive is not closed. 3. Guest agree with opening tray and qemu

Re: [libvirt] [PATCH 00/11] RFC: refactor internal driver architecture

2014-10-24 Thread Laine Stump
On 10/23/2014 11:14 AM, Daniel P. Berrange wrote: Currently we have a bit of a craz setup for activating drivers for virConnectPtr. We iterate over the primary hypervisor drivers until one matches and activates. This bit is fine. Then we do the same for the network, storage, interface, etc

Re: [libvirt] [PATCH v5 1/7] qemu: Add define for the news throttle options

2014-10-24 Thread Eric Blake
On 10/07/2014 05:14 AM, Matthias Gatto wrote: Add defines for the news options total_bytes_sec_max, write_bytes_sec_max, read_bytes_sec_max, total_iops_sec_max, write_iops_sec_max, read_iops_sec_max, size_iops_sec. Signed-off-by: Matthias Gatto matthias.ga...@outscale.com ---

Re: [libvirt] [PATCH] util: eliminate use after free in callers of virNetDevLinkDump

2014-10-24 Thread Eric Blake
On 10/24/2014 11:57 AM, Laine Stump wrote: virNetDevLinkDump() gets a message from netlink into resp, then calls nlmsg_parse() to fill the table tb with pointers into resp. It then returns tb to its caller, but not before freeing the buffer at resp. That means that all the callers of

[libvirt] [PATCH] util: fix libvirtd crash caused by virStorageNetHostTransportTypeFromString

2014-10-24 Thread Shanzhi Yu
When split uri-scheme into two strings with +, the second one will be rdma://server/.., pass it to virStorageNetHostTransportTypeFromString will lead libvirtd crash. So a second virStringSplit call is needed. Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1156288 Signed-off-by: Shanzhi Yu

Re: [libvirt] [PATCH v5 1/7] qemu: Add define for the news throttle options

2014-10-24 Thread Eric Blake
On 10/07/2014 05:14 AM, Matthias Gatto wrote: Add defines for the news options total_bytes_sec_max, write_bytes_sec_max, read_bytes_sec_max, total_iops_sec_max, write_iops_sec_max, read_iops_sec_max, size_iops_sec. s/news/new/ Also, please wrap your commit messages to around 72 columns or

Re: [libvirt] [PATCH] qemu: add capability probing for block-stream

2014-10-24 Thread Shanzhi Yu
Ping? On 09/16/2014 01:06 PM, Shanzhi Yu wrote: Since block-stream is not supported on qemu-kvm, so libvirt should post more accurate error info when do blockpull with qemu-kvm but not Command 'block-stream' is not found Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1140981

Re: [libvirt] [PATCH] util: fix libvirtd crash caused by virStorageNetHostTransportTypeFromString

2014-10-24 Thread Eric Blake
On 10/24/2014 01:01 PM, Shanzhi Yu wrote: When split uri-scheme into two strings with +, the second one will be s/split/splitting/ rdma://server/.., pass it to virStorageNetHostTransportTypeFromString will lead libvirtd crash. So a second virStringSplit call is needed. Can you show the FULL

Re: [libvirt] [PATCH] qemu: add capability probing for block-stream

2014-10-24 Thread Eric Blake
On 09/15/2014 11:06 PM, Shanzhi Yu wrote: Since block-stream is not supported on qemu-kvm, so libvirt should post more accurate error info when do blockpull with qemu-kvm but not Command 'block-stream' is not found Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1140981 Signed-off-by:

[libvirt] [PATCHv3 0/2] Add non-FreeBSD guest support to Bhyve driver.

2014-10-24 Thread Conrad Meyer
Drvbhyve hardcodes bhyveload(8) as the host bootloader for guests. bhyveload(8) loader only supports FreeBSD guests. This patch adds bootloader and bootloader_args handling to bhyve_command, so libvirt can boot non-FreeBSD guests in Bhyve. See patch logs for further details. Thanks, Conrad

[libvirt] [PATCHv3 2/2] Generated PO files for 'bhyve: Support /domain/bootloader'

2014-10-24 Thread Conrad Meyer
Sponsored by: EMC / Isilon storage division Signed-off-by: Conrad Meyer conrad.me...@isilon.com --- po/af.po | 5 + po/am.po | 5 + po/ar.po | 5 + po/as.po | 5 + po/be.po | 5 + po/bg.po | 5 + po/bn.po | 5 + po/bn_IN.po

[libvirt] [PATCHv3 1/2] bhyve: Support /domain/bootloader configuration for non-FreeBSD guests.

2014-10-24 Thread Conrad Meyer
We still default to bhyveloader(1) if no explicit bootloader configuration is supplied in the domain. If the /domain/bootloader looks like grub-bhyve and the user doesn't supply /domain/bootloader_args, we make an intelligent guess and try chainloading the first partition on the disk (or a CD if

Re: [libvirt] [PATCH] qemu: add capability probing for block-stream

2014-10-24 Thread Eric Blake
On 10/24/2014 01:25 PM, Eric Blake wrote: On 09/15/2014 11:06 PM, Shanzhi Yu wrote: Since block-stream is not supported on qemu-kvm, so libvirt should post more accurate error info when do blockpull with qemu-kvm but not Command 'block-stream' is not found Resolves:

[libvirt] [PATCH v2] qemu: better error message when block job can't succeed

2014-10-24 Thread Eric Blake
https://bugzilla.redhat.com/show_bug.cgi?id=1140981 reports that the qemu-kvm shipped as part of RHEL 7.0 intentionally cripples block jobs by removing the 'block-stream' QMP command, but that our probe for whether block jobs work was merely whether 'block-job-cancel' exists. As the crippling did

Re: [libvirt] [PATCH v2] tests: Adding SELINUX_LIBS to fix viridentitytest linker bug.

2014-10-24 Thread Eric Blake
On 10/24/2014 06:33 AM, Julio Faracco wrote: In a clean build system (Ubuntu 14.04), the viridentitytest failed to compile. Even if all the SELINUX libraries and depedencies are installed. See the error message below: [...] CC viridentitytest.o CCLD viridentitytest

Re: [libvirt] [PATCHv2 1/2] bhyve: Support /domain/bootloader configuration for non-FreeBSD guests.

2014-10-24 Thread Craig Rodrigues
On Fri, Oct 24, 2014 at 6:11 AM, Conrad Rad cse@gmail.com wrote: Any idea how soon? Months? A year? 5 years? I'm not comfortable postponing improvements indefinitely for vaporware. In the wonderful bhyve-UEFI future, we can ignore/warn about bootloader. Hi, I have to agree with Conrad

Re: [libvirt] [PATCH v5 2/7] qemu: Modify the structure _virDomainBlockIoTuneInfo.

2014-10-24 Thread Eric Blake
On 10/07/2014 05:14 AM, Matthias Gatto wrote: Modify the structure _virDomainBlockIoTuneInfo to support these the new options. Change the initialization of the variable expectedInfo in qemumonitorjsontest.c to avoid compiling problem. Add documentation about the new xml options

Re: [libvirt] [PATCH v5 5/7] qemu: Add bps_max and friends QMP suport

2014-10-24 Thread Eric Blake
On 10/07/2014 05:14 AM, Matthias Gatto wrote: Detect if the the qemu binary currently in use suport the bps_max option, If yes add it to the command, if not, just ignore the options. Ignoring options is wrong. If a user explicitly requested something in XML but the hypervisor cannot honor it,