Re: [libvirt] [PATCH] mingw: fix build failure

2014-10-31 Thread Pavel Hrdina
On 10/31/2014 11:50 PM, Eric Blake wrote: On 10/31/2014 12:13 PM, Pavel Hrdina wrote: This macro seems to be defined only on linux/unix and it fails during mingw build. Its value is '16' (taken from net/if.h) so define it if it's not defined. Signed-off-by: Pavel Hrdina --- For now just defin

Re: [libvirt] [PATCH] mingw: fix build failure

2014-10-31 Thread Eric Blake
On 10/31/2014 12:13 PM, Pavel Hrdina wrote: > This macro seems to be defined only on linux/unix and it fails during > mingw build. Its value is '16' (taken from net/if.h) so define it if > it's not defined. > > Signed-off-by: Pavel Hrdina > --- > > For now just define it for mingw but we should

Re: [libvirt] [[PATCH libvirt-java]] Implement Connect.listAllDomains

2014-10-31 Thread Claudio Bley
Hi. At Sat, 25 Oct 2014 16:25:48 -0700, Cédric Bosdonnat wrote: > > From: Cédric Bosdonnat > > --- > src/main/java/org/libvirt/Connect.java | 46 > + > src/main/java/org/libvirt/jna/Libvirt.java | 2 ++ > src/test/java/org/libvirt/TestJavaBindings.java |

Re: [libvirt] [PATCH v2] domain: fix parsing of memory tunables on 32-bit machines

2014-10-31 Thread Eric Blake
On 10/31/2014 12:20 AM, Martin Kletzander wrote: > On Thu, Oct 30, 2014 at 02:00:34PM -0600, Eric Blake wrote: >> Commit 6c9a8a4 (Oct 2014) exposed a long-standing issue on 32-bit >> machines: code related to virDomainSetMemoryParameters has always >> been documented as using a 64-bit limit, but it

Re: [libvirt] [PATCH][1.2.10] Relax duplicate SCSI host pool checking

2014-10-31 Thread John Ferlan
On 10/31/2014 12:01 PM, Ján Tomko wrote: > Since commit 3f99d64 no new scsi_host pools can be defined > if one of the already defined scsi_host pools does not refer > to an accessible scsi_host adapter. > > Relax the check by skipping over these inaccessible pools > when checking for duplicates.

Re: [libvirt] [Nbd] [Qemu-devel] spec, RFC: TLS support for NBDµ

2014-10-31 Thread Wouter Verhelst
Hi, On Thu, Oct 30, 2014 at 10:40:56AM +, Stefan Hajnoczi wrote: > On Sat, Oct 25, 2014 at 12:43:35PM +0200, Wouter Verhelst wrote: > > I haven't seen a reply to this anymore. Do people still have comments? > > I'm planning on doing a release of nbd later this weekend, and would > > like to in

[libvirt] [PATCH] mingw: fix build failure

2014-10-31 Thread Pavel Hrdina
This macro seems to be defined only on linux/unix and it fails during mingw build. Its value is '16' (taken from net/if.h) so define it if it's not defined. Signed-off-by: Pavel Hrdina --- For now just define it for mingw but we should review all daemon related code and not build it for mingw at

[libvirt] [sandbox PATCH 1/2] v1.1 for dhclient use g_spawn_sync()

2014-10-31 Thread Gene Czarcinski
This patch addresses problem RHBZ #1133686. For some (unknown to me) reason, g_spawn_async() is not starting dhclient so that a dhcp NIC can be configured. However, simply using g_spawn_sync() works. This was the only use of g_spawn_async(). Note: There is no problem using sync instead of async

[libvirt] [sandbox PATCH 2/2] v1.1 add -v to dhclient parameter arguments

2014-10-31 Thread Gene Czarcinski
This patch improves the ability to understand what is happening with dchlient and is obviously optional. --- libvirt-sandbox/libvirt-sandbox-init-common.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libvirt-sandbox/libvirt-sandbox-init-common.c b/libvirt-sandbox/libvirt-sa

[libvirt] [sandbox PATCH 0/2] v1.1 bugfix: support dhcp network interfaces

2014-10-31 Thread Gene Czarcinski
Resubmitted to add "sandbox PATCH" to Subject v1.1 adds some documentation changes. Support for a network such as -N dhcp,source=default was not working in that dhclient was not being started. Although I am not sure what the real problem is, the solution is to use g_spawn_sync() instead of g_spa

Re: [libvirt] [PATCH 1/2] vbox_storage: fix coverity issue with overwriting value

2014-10-31 Thread John Ferlan
On 10/31/2014 01:14 PM, Pavel Hrdina wrote: > On 10/31/2014 06:05 PM, John Ferlan wrote: >> >> >> On 10/31/2014 12:45 PM, Pavel Hrdina wrote: >>> Coverity is complaining about overwriting value in 'rc' variable >>> without using the old value because it somehow doesn't recognize that >>> the valu

Re: [libvirt] [PATCH 2/2] hotplug: fix char device detach

2014-10-31 Thread Pavel Hrdina
On 10/31/2014 06:16 PM, John Ferlan wrote: On 10/31/2014 12:45 PM, Pavel Hrdina wrote: Hotplugging and hotunplugging char devices is only supported through '-device' and the check for device capability should be independently. Coverity also complains about 'tmpChr->info.alias' could be NULL a

Re: [libvirt] [PATCH 2/2] hotplug: fix char device detach

2014-10-31 Thread John Ferlan
On 10/31/2014 12:45 PM, Pavel Hrdina wrote: > Hotplugging and hotunplugging char devices is only supported through > '-device' and the check for device capability should be independently. > > Coverity also complains about 'tmpChr->info.alias' could be NULL and we > are dereferencing it but it so

Re: [libvirt] [PATCH 1/2] vbox_storage: fix coverity issue with overwriting value

2014-10-31 Thread Pavel Hrdina
On 10/31/2014 06:05 PM, John Ferlan wrote: On 10/31/2014 12:45 PM, Pavel Hrdina wrote: Coverity is complaining about overwriting value in 'rc' variable without using the old value because it somehow doesn't recognize that the value is used by MACRO. The 'rc' variable is there only for checking

Re: [libvirt] [PATCH 1/2] vbox_storage: fix coverity issue with overwriting value

2014-10-31 Thread John Ferlan
On 10/31/2014 12:45 PM, Pavel Hrdina wrote: > Coverity is complaining about overwriting value in 'rc' variable > without using the old value because it somehow doesn't recognize that > the value is used by MACRO. The 'rc' variable is there only for checking > return code so it's save to remove it

[libvirt] [PATCH 2/2] hotplug: fix char device detach

2014-10-31 Thread Pavel Hrdina
Hotplugging and hotunplugging char devices is only supported through '-device' and the check for device capability should be independently. Coverity also complains about 'tmpChr->info.alias' could be NULL and we are dereferencing it but it somehow only in this case don't recognize that the value i

[libvirt] [PATCH 1/2] vbox_storage: fix coverity issue with overwriting value

2014-10-31 Thread Pavel Hrdina
Coverity is complaining about overwriting value in 'rc' variable without using the old value because it somehow doesn't recognize that the value is used by MACRO. The 'rc' variable is there only for checking return code so it's save to remove it and make coverity happy. Signed-off-by: Pavel Hrdina

[libvirt] [PATCH 0/2] Fix two coverity issues

2014-10-31 Thread Pavel Hrdina
Both are false positive but its nice to make coverity happy. Pavel Hrdina (2): vbox_storage: fix coverity issue with overwriting value hotplug: fix char device detach src/qemu/qemu_hotplug.c | 12 src/vbox/vbox_storage.c | 36 2 files changed

Re: [libvirt] [PATCH] network: Add bandwidth support to ethernet interface

2014-10-31 Thread Anirban Chakraborty
Ping ? On 10/29/14, 4:56 PM, "Anirban Chakraborty" wrote: >Ethernet interfaces in libvirt currently do not support bandwidth setting. >For example, following xml file for an interface will not apply these >settings to corresponding qdiscs. > > > > > > > >

[libvirt] [PATCH][1.2.10] Relax duplicate SCSI host pool checking

2014-10-31 Thread Ján Tomko
Since commit 3f99d64 no new scsi_host pools can be defined if one of the already defined scsi_host pools does not refer to an accessible scsi_host adapter. Relax the check by skipping over these inaccessible pools when checking for duplicates. If both of them are defined by their parent, only comp

[libvirt] [PATCH] Use UPDATE_CPU when saving domain status

2014-10-31 Thread Ján Tomko
We only format cpu model for MODE_CUSTOM in domain status XML, but we always format features if they are present. This is a problem if we have a domain using MODE_HOST_PASSTHROUGH that has been managedsaved, then restored, since it now has a feature list but no model in /var/run/libvirt/qemu. Use

Re: [libvirt] [PATCH 1/2] qemu: migration:Release nbd port from migrationPorts instead of remotePorts

2014-10-31 Thread John Ferlan
On 10/31/2014 06:02 AM, Ján Tomko wrote: > On 10/31/2014 09:16 AM, weiwei li wrote: >> commit 3e1e16aa8d4238241a1806cb9bdb3b9ad60db777(Use a port from the >> migration range for NBD as well) change ndb port allocation from >> remotePorts to migrationPorts, but does not change the port releasing >

[libvirt] [PATCH v2 2/2] qemu: avoid rare race when undefining domain

2014-10-31 Thread Martin Kletzander
When one domain is being undefined and at the same time started, for example, there is a possibility of a rare problem occuring. - Thread 1 does virDomainUndefine(), has the lock, checks that the domain is active and because it's not, calls virDomainObjListRemove(). - Thread 2 does virDom

[libvirt] [PATCH v2 0/2] qemu: avoid rare race when undefining domain

2014-10-31 Thread Martin Kletzander
This is a v2 of: https://www.redhat.com/archives/libvir-list/2014-October/msg01052.html This time it's going to be fixed in QEMU only, using a job and hack around virDomainObjListRemove(). Also, in this version, the error message will use UUID instead of the domain name, because it gets reported

[libvirt] [PATCH v2 1/2] DO NOT APPLY UPSTREAM: Reproducer helper

2014-10-31 Thread Martin Kletzander
To reproduce the problem that this series is trying to fix, do the following: - Term 1: LIBVIRT_DEBUG=2 LIBVIRT_LOG_OUTPUTS='2:stderr' daemon/libvirtd - Term 2: virsh undefine $dom - In term 1 look for: NOW!!! - Term 3: virsh start $dom - Enjoy: domain is started, but not i

Re: [libvirt] [PATCH 3/3] Avoid rare race when undefining domain

2014-10-31 Thread Martin Kletzander
On Fri, Oct 31, 2014 at 02:28:49PM +0100, Michal Privoznik wrote: On 31.10.2014 07:35, Martin Kletzander wrote: On Thu, Oct 30, 2014 at 05:44:23PM +, Daniel P. Berrange wrote: On Thu, Oct 30, 2014 at 06:39:56PM +0100, Michal Privoznik wrote: On 30.10.2014 16:04, Martin Kletzander wrote: >W

Re: [libvirt] [PATCH 3/3] Avoid rare race when undefining domain

2014-10-31 Thread Michal Privoznik
On 31.10.2014 07:35, Martin Kletzander wrote: On Thu, Oct 30, 2014 at 05:44:23PM +, Daniel P. Berrange wrote: On Thu, Oct 30, 2014 at 06:39:56PM +0100, Michal Privoznik wrote: On 30.10.2014 16:04, Martin Kletzander wrote: >When one domain is being undefined and at the same time started, for

Re: [libvirt] [PATCH] Do not probe for power mgmt capabilities in lxc emulator

2014-10-31 Thread Martin Kletzander
On Fri, Oct 31, 2014 at 10:22:37AM +0100, Ján Tomko wrote: It fails after 30 seconds with this error: error : virDBusCall:1429 : error from service: CanSuspend: Did not receive a reply. Possible causes include: the remote application did not send a reply, the message bus security policy blocked t

Re: [libvirt] [PATCH] Require at least one console for LXC domain

2014-10-31 Thread Martin Kletzander
On Fri, Oct 31, 2014 at 10:22:25AM +0100, Ján Tomko wrote: A domain without a console quietly dies soon after start, because we try to set /dev/null as a controlling TTY 2014-10-30 15:10:59.705+: 1: error : lxcContainerSetupFDs:283 : ioctl(TIOCSTTY) failed: Inappropriate ioctl for device s

Re: [libvirt] [PATCH 1/2] qemu: migration:Release nbd port from migrationPorts instead of remotePorts

2014-10-31 Thread Ján Tomko
On 10/31/2014 10:15 AM, Wang Rui wrote: > On 2014/10/31 16:16, weiwei li wrote: >> commit 3e1e16aa8d4238241a1806cb9bdb3b9ad60db777(Use a port from the >> migration range for NBD as well) change ndb port allocation from >> remotePorts to migrationPorts, but does not change the port releasing >> proc

Re: [libvirt] [PATCH 2/2] qemu: migration: Ignore null ptr in qemuMigrationStopNBDServer

2014-10-31 Thread Ján Tomko
On 10/31/2014 09:17 AM, weiwei li wrote: > qemuMigrationCookiePtr mig->nbd may be null when MigrationCookie > do not have nbd information ,but nbd port did allocated before and > must be released here, so ignore mig->nbd null ptr and just warn. StartNBDServer is only run when mig->nbd is present,

Re: [libvirt] [PATCH 1/2] qemu: migration:Release nbd port from migrationPorts instead of remotePorts

2014-10-31 Thread Ján Tomko
On 10/31/2014 09:16 AM, weiwei li wrote: > commit 3e1e16aa8d4238241a1806cb9bdb3b9ad60db777(Use a port from the > migration range for NBD as well) change ndb port allocation from > remotePorts to migrationPorts, but does not change the port releasing > process, which makes an error when migration se

[libvirt] [v5][PATCH 4/4] docs: Add documentation for compat mode.

2014-10-31 Thread Prerna Saxena
>From dd917ef27269bc3a9af2294212b088f838792315 Mon Sep 17 00:00:00 2001 From: Prerna Saxena Date: Fri, 31 Oct 2014 15:13:16 +0530 Subject: [PATCH 4/4] docs: Add documentation for compat mode. Add documentation to explain how compat-mode can be invoked with libvirt running on PowerPC architecture

[libvirt] [v5][PATCH 3/4] PowerPC:Improve PVR handling to fallback to CPU generation

2014-10-31 Thread Prerna Saxena
>From 40c57322949a064607d27de8a293047fb5c7ff8e Mon Sep 17 00:00:00 2001 From: Prerna Saxena Date: Tue, 28 Oct 2014 15:30:05 +0530 IBM Power processors differ uniquely across generations (such as power6, power7, power8). Each generation signifies a new PowerISA version that exhibits features uniq

[libvirt] [v5][PATCH 2/4] PowerPC : Add support for launching VMs in 'compat' mode.

2014-10-31 Thread Prerna Saxena
From: Prerna Saxena Date: Tue, 28 Oct 2014 15:05:59 +0530 PowerISA allows processors to run VMs in binary compatibility ("compat") mode supporting an older version of ISA. QEMU has recently added support to explicitly denote a VM running in compatibility mode through commit 6d9412ea & 8dfa3a5e85

Re: [libvirt] [PATCH] Do not probe for power mgmt capabilities in lxc emulator

2014-10-31 Thread Chen, Hanxiao
> -Original Message- > From: libvir-list-boun...@redhat.com [mailto:libvir-list-boun...@redhat.com] > On Behalf Of Ján Tomko > Sent: Friday, October 31, 2014 5:23 PM > To: libvir-list@redhat.com > Subject: [libvirt] [PATCH] Do not probe for power mgmt capabilities in lxc > emulator > >

Re: [libvirt] [PATCH] Require at least one console for LXC domain

2014-10-31 Thread Chen, Hanxiao
> -Original Message- > From: libvir-list-boun...@redhat.com [mailto:libvir-list-boun...@redhat.com] > On Behalf Of Ján Tomko > Sent: Friday, October 31, 2014 5:22 PM > To: libvir-list@redhat.com > Subject: [libvirt] [PATCH] Require at least one console for LXC domain > > A domain without

[libvirt] [v5][PATCH 1/4] Cpu: Add support for Power LE Architecture.

2014-10-31 Thread Prerna Saxena
>From fca5b950ec688122adde121bacd5937b5c4e2e06 Mon Sep 17 00:00:00 2001 From: "Pradipta Kr. Banerjee" Date: Tue, 28 Oct 2014 14:41:59 +0530 Subject: [PATCH 1/4] Cpu: Add support for Power LE Architecture. This adds support for PowerPC Little Endian architecture., and allows libvirt to spawn VMs

[libvirt] [PATCH] Do not probe for power mgmt capabilities in lxc emulator

2014-10-31 Thread Ján Tomko
It fails after 30 seconds with this error: error : virDBusCall:1429 : error from service: CanSuspend: Did not receive a reply. Possible causes include: the remote application did not send a reply, the message bus security policy blocked the reply, the reply timeout expired, or the network connectio

[libvirt] [PATCH] Require at least one console for LXC domain

2014-10-31 Thread Ján Tomko
A domain without a console quietly dies soon after start, because we try to set /dev/null as a controlling TTY 2014-10-30 15:10:59.705+: 1: error : lxcContainerSetupFDs:283 : ioctl(TIOCSTTY) failed: Inappropriate ioctl for device Report an error early instead of trying to start it. https://bu

[libvirt] [v5][Patch 0/4] Libvirt CPU enhancements for Power KVM

2014-10-31 Thread Prerna Saxena
This patch series is a collection of enhancements for PowerPC CPUs on PowerKVM. In this iteration, I have followed Dan's suggestion on using existing cpu mode format to describe powerPC compatibility mode. Hope this can finally make it for 1.2.10 ! Series Summary: == Patch 1/4 : Introduc

Re: [libvirt] [PATCH 1/2] qemu: migration:Release nbd port from migrationPorts instead of remotePorts

2014-10-31 Thread Wang Rui
On 2014/10/31 16:16, weiwei li wrote: > commit 3e1e16aa8d4238241a1806cb9bdb3b9ad60db777(Use a port from the > migration range for NBD as well) change ndb port allocation from > remotePorts to migrationPorts, but does not change the port releasing > process, which makes an error when migration sevea

[libvirt] [PATCH 2/2] qemu: migration: Ignore null ptr in qemuMigrationStopNBDServer

2014-10-31 Thread weiwei li
qemuMigrationCookiePtr mig->nbd may be null when MigrationCookie do not have nbd information ,but nbd port did allocated before and must be released here, so ignore mig->nbd null ptr and just warn. Signed-off-by: Weiwei Li --- src/qemu/qemu_migration.c |2 +- 1 files changed, 1 insertions(+)

[libvirt] [PATCH 1/2] qemu: migration:Release nbd port from migrationPorts instead of remotePorts

2014-10-31 Thread weiwei li
commit 3e1e16aa8d4238241a1806cb9bdb3b9ad60db777(Use a port from the migration range for NBD as well) change ndb port allocation from remotePorts to migrationPorts, but does not change the port releasing process, which makes an error when migration seveal times(above 64). Signed-off-by: Weiwei Li

Re: [libvirt] [PATCH] qemu: make advice from numad available when building commandline

2014-10-31 Thread Martin Kletzander
On Thu, Oct 30, 2014 at 06:21:28PM +0100, Michal Privoznik wrote: On 30.10.2014 07:40, Martin Kletzander wrote: Particularly in qemuBuildNumaArgStr(), there was a need for the advice due to memory backing, which needs to know the nodeset it will be pinned to. With newer qemu this caused the fol