On 11/12/2014 04:16 PM, John Ferlan wrote:
Found missing 'size_iops_sec' check in qemu_command.c.
Add a test for the new blkdeviotune parameters.
John Ferlan (2):
qemu: Add checks for blkdeviotune 'size_iops_sec' and adjust error
qemu: Add tests for new blkdeviotune arguments
On 11/12/2014 04:16 PM, John Ferlan wrote:
The recent commit to add support for block_set_io_throttle parameters
from version 1.7 of qemu did not add any tests - this adds the tests
Signed-off-by: John Ferlan jfer...@redhat.com
---
.../qemuxml2argv-blkdeviotune-max.args | 12
On Tue, Nov 11, 2014 at 12:42:46PM +, Daniel P. Berrange wrote:
A previous commit introduced use of locking with invocation
of iptables in the viriptables.c module
commit ba95426d6f39aec1da6e069dd7222f7a8c6a5862
Author: Serge Hallyn serge.hal...@ubuntu.com
Date: Fri Nov 1 12:36:59 2013
The vram attribute was introduced to set the video memory but it is
usable only for few hypervisors excluding QEMU/KVM. QEMU/KVM has
different attribute for this purpose vgamem_mb and it will be
introduced lately.
The correct usage of vram is to set the video memory for other
hypervisors or to
So far we hadn't any option to set video memory size for qemu video
devices. There were only vram (ram for QXL) attribute but it was valid
only for QXL video device.
To provide this feature to users qemu has dedicated device attribute
called 'vgamem_mb' to set the video memory size. We will use
Allow setting vgamem size for video devices.
Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1076098
Signed-off-by: Pavel Hrdina phrd...@redhat.com
---
src/qemu/qemu_capabilities.c | 25 ++
src/qemu/qemu_capabilities.h | 3 +
QEMU has two different type of QXL display device. The first qxl-vga
is for primary video device and second qxl is for secondary video
device.
There are also two different ways how to specify those devices on qemu
command line, the first one and obsolete is using -vga option and the
current new
There are some changes from the first version. We will not have a new 'vgamem'
attribute for video devices because we can use the 'vram' attribute. So far
for QEMU the 'vram' is used only to set the secondary ram for QXL which seems
to be correct as the secondary ram is used for pixmaps and
Hi,
The 'vgamem_mb' parameter for QXL sets the VGA framebuffer size, but the VGA
mode in QXL is used only as fallback if the OS doesn't have any QXL drivers
or before the drivers are loaded. The VGA framebuffer is part of the first ram
for QXL and for that we have 'ram' attribute. The rest
On Fr, 2014-11-14 at 14:54 +0100, Pavel Hrdina wrote:
+static struct virQEMUCapsStringFlags
virQEMUCapsObjectPropsCirrusVga[] = {
+{ vgamem_mb, QEMU_CAPS_CIRRUS_VGA_VGAMEM },
+};
Please don't touch vgamem_mb on cirrus. The only reason we have this
property in the first place is live
On Fr, 2014-11-14 at 14:54 +0100, Pavel Hrdina wrote:
+if (video-vram % 1024) {
+virReportError(VIR_ERR_CONFIG_UNSUPPORTED,
+ %s, _(value for 'vram' must be multiple
of 1024));
+goto error;
+}
pci bar size must be a power of
On 11/14/2014 04:00 PM, Gerd Hoffmann wrote:
Hi,
The 'vgamem_mb' parameter for QXL sets the VGA framebuffer size, but the VGA
mode in QXL is used only as fallback if the OS doesn't have any QXL drivers
or before the drivers are loaded. The VGA framebuffer is part of the first ram
for QXL
On 11/14/2014 04:06 PM, Gerd Hoffmann wrote:
On Fr, 2014-11-14 at 14:54 +0100, Pavel Hrdina wrote:
+if (video-vram % 1024) {
+virReportError(VIR_ERR_CONFIG_UNSUPPORTED,
+ %s, _(value for 'vram' must be multiple
of 1024));
+goto error;
+
On 11/14/2014 04:03 PM, Gerd Hoffmann wrote:
On Fr, 2014-11-14 at 14:54 +0100, Pavel Hrdina wrote:
+static struct virQEMUCapsStringFlags
virQEMUCapsObjectPropsCirrusVga[] = {
+{ vgamem_mb, QEMU_CAPS_CIRRUS_VGA_VGAMEM },
+};
Please don't touch vgamem_mb on cirrus. The only reason we have
On Fr, 2014-11-14 at 16:15 +0100, Pavel Hrdina wrote:
On 11/14/2014 04:03 PM, Gerd Hoffmann wrote:
On Fr, 2014-11-14 at 14:54 +0100, Pavel Hrdina wrote:
+static struct virQEMUCapsStringFlags
virQEMUCapsObjectPropsCirrusVga[] = {
+{ vgamem_mb, QEMU_CAPS_CIRRUS_VGA_VGAMEM },
+};
On Fr, 2014-11-14 at 16:13 +0100, Pavel Hrdina wrote:
On 11/14/2014 04:06 PM, Gerd Hoffmann wrote:
On Fr, 2014-11-14 at 14:54 +0100, Pavel Hrdina wrote:
+if (video-vram % 1024) {
+virReportError(VIR_ERR_CONFIG_UNSUPPORTED,
+ %s, _(value for
On 11/14/2014 04:24 PM, Gerd Hoffmann wrote:
On Fr, 2014-11-14 at 16:15 +0100, Pavel Hrdina wrote:
On 11/14/2014 04:03 PM, Gerd Hoffmann wrote:
On Fr, 2014-11-14 at 14:54 +0100, Pavel Hrdina wrote:
+static struct virQEMUCapsStringFlags
virQEMUCapsObjectPropsCirrusVga[] = {
+{ vgamem_mb,
Reboot requires more sophistication and is left as a future work item --
but at least part of the plumbing is in place.
---
Looking for feedback. I'm pretty unfamiliar with libvirt; maybe this isn't
quite the right way to do this. Sorry. If you want me to rework it in some way,
just let me know.
On Thu, Nov 13, 2014 at 05:09:04PM -0700, Eric Blake wrote:
On 11/13/2014 04:52 PM, John Ferlan wrote:
On 11/13/2014 09:37 AM, Martin Kletzander wrote:
Brackets were removed by the following script in the root directory of
libvirt's repository:
for i in $(git ls-files | grep '\.[ch]$');
On 11/14/2014 04:19 AM, Ján Tomko wrote:
On 11/12/2014 04:16 PM, John Ferlan wrote:
Found missing 'size_iops_sec' check in qemu_command.c.
Add a test for the new blkdeviotune parameters.
John Ferlan (2):
qemu: Add checks for blkdeviotune 'size_iops_sec' and adjust error
qemu: Add
On 11/14/2014 04:25 PM, Gerd Hoffmann wrote:
On Fr, 2014-11-14 at 16:13 +0100, Pavel Hrdina wrote:
On 11/14/2014 04:06 PM, Gerd Hoffmann wrote:
On Fr, 2014-11-14 at 14:54 +0100, Pavel Hrdina wrote:
+if (video-vram % 1024) {
+virReportError(VIR_ERR_CONFIG_UNSUPPORTED,
+
On 11/13/2014 10:21 PM, Luyao Huang wrote:
It would help to put the bz link in here:
https://bugzilla.redhat.com/show_bug.cgi?id=1164080
When we try to get a hot-unplug disk blkdevio settings via
qemuDomainGetBlockIoTune, libvirt will output a cannot find
device error.Move the check after
On 11/15/2014 06:29 AM, John Ferlan wrote:
On 11/13/2014 10:21 PM, Luyao Huang wrote:
It would help to put the bz link in here:
https://bugzilla.redhat.com/show_bug.cgi?id=1164080
When we try to get a hot-unplug disk blkdevio settings via
qemuDomainGetBlockIoTune, libvirt will output a
23 matches
Mail list logo
