On Tue, Nov 18, 2014 at 05:59:48PM +, Daniel P. Berrange wrote:
The virDomainDefineXML method is one of the few that still lacks
a 'unsigned int flags' parameter. This will be needed for adding
s/a/an/?
XML validation to this API. virDomainCreateXML fortunately already
has flags.
---
incl
On Tue, Nov 18, 2014 at 05:59:47PM +, Daniel P. Berrange wrote:
This proof of concept patch extends the virDomainDefineXML
and virDomainCreateXML APIs so that they can validate
the user supplied XML document against the RNG schemas.
The virsh command will enable validation by default, it
mus
On Tue, Nov 18, 2014 at 05:06:34PM +0100, Michal Privoznik wrote:
Since 1.2.8 it's possible to use OVMF on domains. Moreover, it's
possible to have libvirt create NVRAM file per domain. Later,
when domain is undefined, the file is removed too. However,
things are a bit complicated when domain's t
We can change vnc password by using virDomainUpdateDeviceFlags API with
live flag. But it can't be changed with config flag.
1/3: improve the error number when update graphics failed
2/3: refactor the function qemuDomainFindGraphics for the future patch
3/3: support updating vnc/spice auth argumen
Signed-off-by: Wang Rui
---
src/qemu/qemu_hotplug.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/qemu/qemu_hotplug.c b/src/qemu/qemu_hotplug.c
index b9a0cee..1c75861 100644
--- a/src/qemu/qemu_hotplug.c
+++ b/src/qemu/qemu_hotplug.c
@@ -2347,7 +2347,7 @@ qemu
We can change vnc password by using virDomainUpdateDeviceFlags API with
live flag. But it can't be changed with config flag. Error is reported as
below.
error: Operation not supported: persistent update of device 'graphics' is not
supported
This patch supports the vnc/spice auth arguments change
We want to use qemuDomainFindGraphics in the qemuDomainUpdateDeviceConfig in
a future patch. So adjust its parameter.
Signed-off-by: Wang Rui
---
src/qemu/qemu_hotplug.c | 13 ++---
src/qemu/qemu_hotplug.h | 3 +++
2 files changed, 9 insertions(+), 7 deletions(-)
diff --git a/src/qemu/
Add binding for virDomainOpenGraphicsFD.
---
libvirt-gobject/libvirt-gobject-domain.c | 36
libvirt-gobject/libvirt-gobject-domain.h | 4
libvirt-gobject/libvirt-gobject.sym | 5 +
3 files changed, 45 insertions(+)
diff --git a/libvirt-gobject/libv
Ethernet interfaces in libvirt currently do not support bandwidth setting.
For example, following xml file for an interface will not apply these
settings to corresponding qdiscs.
Signed-off-by: Anirban Chakraborty
---
src/co
On 11/18/14, 2:25 PM, "Vasiliy Tolstov" wrote:
>2014-11-18 21:03 GMT+03:00 Anirban Chakraborty :
>> I was wondering as well if this patch looks fine and ready for merge.
>> Michal, Laine, any thoughts ?
>
>
>Also its not compiled with 1.2.9.1 =(
>
>/tmp/buildd/libvirt-1.2.9.1/./src/qemu/qemu_ho
2014-11-18 21:03 GMT+03:00 Anirban Chakraborty :
> I was wondering as well if this patch looks fine and ready for merge.
> Michal, Laine, any thoughts ?
Also its not compiled with 1.2.9.1 =(
/tmp/buildd/libvirt-1.2.9.1/./src/qemu/qemu_hotplug.c: In function
'qemuDomainDetachControllerDevice':
/t
https://bugzilla.redhat.com/show_bug.cgi?id=1159180
Move the API from the backend to storage_conf and rename it to
virStoragePoolGetVhbaSCSIHostParent. A future patch will need to
use this functionality from storage_conf
Signed-off-by: John Ferlan
---
src/conf/storage_conf.c| 66 ++
https://bugzilla.redhat.com/show_bug.cgi?id=1159180
Currently libvirt only detects duplicate fc_host & scsi_host adapter sources
when the incoming source type definition is the same as the pool type. This
misses the even more oddball cases where a scsi_host/fc_host definition is
using a scsi_hostN
https://bugzilla.redhat.com/show_bug.cgi?id=1159180
The virStoragePoolSourceFindDuplicate only checks the incoming definition
against the same type of pool as the def; however, for "scsi_host" and
"fc_host" adapter pools, it's possible that either some pool "scsi_host"
adapter definition is alread
On 18/11/14 09:35 -0700, Eric Blake wrote:
On 11/18/2014 08:00 AM, Adam Litke wrote:
On 18/11/14 06:31 -0700, Eric Blake wrote:
In a future patch, the implementation of VIR_DOMAIN_XML_BLOCK_INFO
will use information stored in virStorageSource. In order to
maximize code reuse, it is easiest if
On 11/18/14, 2:40 AM, "Vasiliy Tolstov" wrote:
>2014-11-13 2:07 GMT+03:00 Anirban Chakraborty :
>> >From 7db513698bfcc30d2d0b020c3fcf9e0337c66ff4 Mon Sep 17 00:00:00 2001
>> From: Anirban Chakraborty
>> Date: Wed, 12 Nov 2014 14:24:43 -0800
>> Subject: [PATCH] network: Add network bandwidth su
The virDomainDefParse* and virDomainDefFormat* methods both
accept the VIR_DOMAIN_XML_* flags defined in the public API,
along with a set of other VIR_DOMAIN_XML_INTERNAL_* flags
defined in domain_conf.c.
This is seriously confusing & error prone for a number of
reasons:
- VIR_DOMAIN_XML_SECURE,
The XenAPI driver was passing the flags for
virDomainCreateXML straight into the virDomainDefParseString
method, even though they expect totally different sets of
flags. It should have been using VIR_DOMAIN_XML_INACTIVE
---
src/xenapi/xenapi_driver.c | 4 ++--
1 file changed, 2 insertions(+), 2 de
Add a helper method that can validate an XML document against
an RNG schema
---
include/libvirt/virterror.h | 1 +
src/internal.h | 4 +++
src/libvirt_private.syms| 1 +
src/util/virerror.c | 6
src/util/virxml.c | 74
The virDomainDefineXMLFlags and virDomainCreateXML APIs both
gain new flags allowing them to be told to validate XML.
The main limitation with this is that libxml2's errors for
failing schema validation are really awful and not likely
to be any help for the user
eg, I added an element bar immedi
The VIR_DOMAIN_XML_SECURE flag only has effect on the formatting
of XML so should not be passed to virDomainDefParseNode
The VIR_DOMAIN_XML_UPDATE_CPU flag has to be processed by the
driver code, so should not be passed to virDomainDefFormatInternal
---
src/conf/snapshot_conf.c | 6 ++
src/qe
This proof of concept patch extends the virDomainDefineXML
and virDomainCreateXML APIs so that they can validate
the user supplied XML document against the RNG schemas.
The virsh command will enable validation by default, it
must be turned off with --skip-validation if desired.
This series is not
The phyp driver is passing the VIR_DOMAIN_XML_SECURE flag to
virDomainDefParseString which is wrong, because that flag only
has effect when formatting XML.
---
src/phyp/phyp_driver.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/phyp/phyp_driver.c b/src/phyp/phyp_driver.c
Make sure every virt driver implements virDomainDefineXMLFlags
by adding a trivial passthrough from the existing impl with
no flags set.
---
src/bhyve/bhyve_driver.c | 12 ++--
src/esx/esx_driver.c | 10 --
src/libxl/libxl_driver.c | 12 ++--
src
On 18/11/14 09:33 -0700, Eric Blake wrote:
On 11/18/2014 07:50 AM, Adam Litke wrote:
diff --git a/include/libvirt/libvirt-domain.h
b/include/libvirt/libvirt-domain.h
index 1fac2a3..caf1f46 100644
--- a/include/libvirt/libvirt-domain.h
+++ b/include/libvirt/libvirt-domain.h
@@ -1248,6 +1248,7 @@
The virDomainDefineXML method is one of the few that still lacks
a 'unsigned int flags' parameter. This will be needed for adding
XML validation to this API. virDomainCreateXML fortunately already
has flags.
---
include/libvirt/libvirt-domain.h | 4
src/driver-hypervisor.h | 5
This patch enables the helper program to detect event(s) triggered when there
is a change in lease length or expiry and client-id. This transfers complete
control of leases database to libvirt and obsoletes use of the lease database
file (.leases). That file will not be created, read, or written.
T
On 11/18/2014 07:50 AM, Adam Litke wrote:
>>
>> diff --git a/include/libvirt/libvirt-domain.h
>> b/include/libvirt/libvirt-domain.h
>> index 1fac2a3..caf1f46 100644
>> --- a/include/libvirt/libvirt-domain.h
>> +++ b/include/libvirt/libvirt-domain.h
>> @@ -1248,6 +1248,7 @@ typedef enum {
>> VIR
On 11/18/2014 08:00 AM, Adam Litke wrote:
> On 18/11/14 06:31 -0700, Eric Blake wrote:
>> In a future patch, the implementation of VIR_DOMAIN_XML_BLOCK_INFO
>> will use information stored in virStorageSource. In order to
>> maximize code reuse, it is easiest if BlockInfo code also uses the
>> same
On Tue, Nov 18, 2014 at 04:38:49PM +, Daniel P. Berrange wrote:
> On Tue, Nov 18, 2014 at 06:31:46AM -0700, Eric Blake wrote:
> > v1 was here:
> > https://www.redhat.com/archives/libvir-list/2014-September/msg01077.html
> >
> > This adds the framework for exposing disk of all disks from a sing
On Tue, Nov 18, 2014 at 06:31:46AM -0700, Eric Blake wrote:
> v1 was here:
> https://www.redhat.com/archives/libvir-list/2014-September/msg01077.html
>
> This adds the framework for exposing disk of all disks from a single
> dumpxml command. I'm still working on a followup patch to further
> list
Since 1.2.8 it's possible to use OVMF on domains. Moreover, it's
possible to have libvirt create NVRAM file per domain. Later,
when domain is undefined, the file is removed too. However,
things are a bit complicated when domain's transient. There's no
undefine to transient domains. There are two op
virConnect.privateData is void *, so we can't access
fields of parallelsConn, pointer to which is stored in
virConnect.privateData. So replace all occurences of
conn->privateData->storageState with privconn->storageState.
Signed-off-by: Dmitry Guryanov
---
src/parallels/parallels_storage.c | 13
From: Alexander Burluka
domainCreateWithFlags function is used by OpenStack/Nova to boot
an instance.
Signed-off-by: Dmitry Guryanov
---
src/parallels/parallels_driver.c | 10 ++
1 file changed, 10 insertions(+)
diff --git a/src/parallels/parallels_driver.c b/src/parallels/parallels_d
The information in virDomainGetBlockInfo() is important for clients
that use qcow2 format on LVM block devices - by tracking the
allocation in relation to the physical size, management can tell
if a disk needs to be expanded before the guest (file system
contents) and/or qemu (copy-on-write differi
This patch replaces code, which creates domains by
running prlctl command.
prlsdkCreateVm/Ct will do prlsdkApplyConfig, because
we send request to the server only once in this case.
But prlsdkApplyConfig will be called also from
parallelsDomainDefineXML function. There is no problem with
it, para
Rewrite code, which applies domain configuration given
to virDomainDefineXML function to the VM of container
registered in PCS.
This code first check if there are unsupported parameters
in domain XML and if yes - reports error. Some of such
parameters are not supported by PCS, for some - it's not
In a future patch, the implementation of VIR_DOMAIN_XML_BLOCK_INFO
will use information stored in virStorageSource. In order to
maximize code reuse, it is easiest if BlockInfo code also uses the
same location for information.
* src/util/virstoragefile.h (_virStorageSource): Add physical, to
mirro
On 18/11/14 06:31 -0700, Eric Blake wrote:
The information in virDomainGetBlockInfo() is important for clients
that use qcow2 format on LVM block devices - by tracking the
allocation in relation to the physical size, management can tell
if a disk needs to be expanded before the guest (file system
In order for a future patch to actually implement the new
VIR_DOMAIN_XML_BLOCK_INFO flag, we'll need to make a qemu
monitor command call for each disk backed by block storage.
Not only does a monitor command require a job, but even
iterating over disks to determine if the monitor command is
needed
On 18/11/14 06:31 -0700, Eric Blake wrote:
In a future patch, the implementation of VIR_DOMAIN_XML_BLOCK_INFO
will use information stored in virStorageSource. In order to
maximize code reuse, it is easiest if BlockInfo code also uses the
same location for information.
* src/util/virstoragefile.
From: Alexander Burluka
Obtain information about domains using parallels sdk
instead of prlctl. prlsdkLoadDomains functions behaves
as former parallelsLoadDomains with NULL as second
parameter (name) - it fills parallelsConn.domains list.
prlsdkLoadDomain is now able to update specified domain
b
Create a helper function that can be reused to implement the
new VIR_DOMAIN_XML_BLOCK_INFO flag.
* src/qemu/qemu_driver.c (qemuDomainGetBlockInfo): Split guts...
(qemuStorageLimitsRefresh): ...into new helper function.
Signed-off-by: Eric Blake
---
src/qemu/qemu_driver.c | 287 +
On 10/23/2014 07:52 AM, Adam Litke wrote:
> On 17/09/14 08:43 -0600, Eric Blake wrote:
>> + * If @flags contains VIR_DOMAIN_XML_BLOCK_INFO, the listing for each
>> + * device will contain additional information such as capacity
>> + * and allocation, similar to what is displayed by
>> virStorageVo
In order for a future patch to actually implement the new
VIR_DOMAIN_XML_BLOCK_INFO flag, we want to reuse the code for
grabbing block information, including the use of a monitor
command. But grabbing a job multiple times when getting XML
is not wise, so it is easier to reuse the query code if it
Change domain state using parallels SDK functions instead of
prlctl command.
We don't need to send events from these functions now, becase
events handler will send them. But we still need to update
virDomainObj in privconn->domains.
Signed-off-by: Dmitry Guryanov
---
src/parallels/parallels_dri
From: Alexander Burluka
That function is necessary for proper domain removal
in openstack/nova.
Signed-off-by: Dmitry Guryanov
---
src/parallels/parallels_driver.c | 19 +++
1 file changed, 19 insertions(+)
diff --git a/src/parallels/parallels_driver.c b/src/parallels/parallel
Signed-off-by: Dmitry Guryanov
---
src/parallels/parallels_driver.c | 26 ++
src/parallels/parallels_sdk.c| 18 ++
src/parallels/parallels_sdk.h| 2 ++
3 files changed, 46 insertions(+)
diff --git a/src/parallels/parallels_driver.c b/src/parallels
This macro will be used in paralles_sdk.c so move
it to common header.
Signed-off-by: Dmitry Guryanov
---
src/parallels/parallels_driver.c | 2 --
src/parallels/parallels_utils.h | 2 ++
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/parallels/parallels_driver.c b/src/parall
This patch adds the common code for outputting drive sizing
information, when a user has requested the new API flag. The
output covers the data stashed into virStorageSource of each
disk of the domain.
* docs/schemas/domaincommon.rng (storageSourceExtra): New define.
* src/conf/domain_conf.c (vir
On Tue, Nov 18, 2014 at 06:26:54AM -0700, Eric Blake wrote:
> On 11/11/2014 05:42 AM, Daniel P. Berrange wrote:
> > A previous commit introduced use of locking with invocation
> > of iptables in the viriptables.c module
> >
> > commit ba95426d6f39aec1da6e069dd7222f7a8c6a5862
> > Author: Serge
Move macro parallelsDomNotFoundError to file
parallels_utils.h, because it will be used in
parallels_sdk.c.
Signed-off-by: Dmitry Guryanov
---
src/parallels/parallels_driver.c | 8
src/parallels/parallels_utils.h | 8
2 files changed, 8 insertions(+), 8 deletions(-)
diff --gi
First, we don't need to call prlsdkApplyConfig after
creating new VM or containers, because it's done in
functions prlsdkCreateVm and prlsdkCreateCt.
No need to check, if domain exists in the list after
prlsdkAddDomain.
Also organize code, so that we can call virObjectUnlock
in one place.
Signed
Get cdrom devices list from parallels server in
prlsdkLoadDomains and add ability to define a domain
with cdroms.
Signed-off-by: Dmitry Guryanov
---
src/parallels/parallels_sdk.c | 70 ++-
1 file changed, 63 insertions(+), 7 deletions(-)
diff --git a/src/
v1 was here:
https://www.redhat.com/archives/libvir-list/2014-September/msg01077.html
This adds the framework for exposing disk of all disks from a single
dumpxml command. I'm still working on a followup patch to further
list usage of disks in the backing chain, rather than just the
top-level dis
Thanks to the recent refactoring, it is now possible to easily
update the virStorageSource associated with each disk, including
making a monitor call if necessary. Of course, making one
monitor call per disk is not ideal, but that can be improved in
later patches.
* src/qemu/qemu_driver.c (qemuSt
From: Alexander Burluka
Subscribe to events from parallels server. It's
needed for 2 things: to update cached domains list
and to send corresponding libvirt events.
Parallels server sends a lot of different events, in
this patch we handle only some of them. In the future
we can handle for exampl
On 11/11/2014 05:42 AM, Daniel P. Berrange wrote:
> A previous commit introduced use of locking with invocation
> of iptables in the viriptables.c module
>
> commit ba95426d6f39aec1da6e069dd7222f7a8c6a5862
> Author: Serge Hallyn
> Date: Fri Nov 1 12:36:59 2013 -0500
>
> util: use -w
This patch series replaces all code, which used prlctl command
to interact with parallels cloud server with calls to
parallels sdk functions.
The model of this driver remain almost the same - in creates a
list of virDomainObj objects on connect and then functions, which
returns different informati
On 12.11.2014 19:10, Peter Krempa wrote:
On 11/12/14 18:26, Michal Privoznik wrote:
There are two ways how to use nvram variable store file in
libvirt:
1) create it by hand and pass the path in domain XML
2) let libvirt generate path and create the file
Now, we allow users to remove the
2014-11-13 2:07 GMT+03:00 Anirban Chakraborty :
> >From 7db513698bfcc30d2d0b020c3fcf9e0337c66ff4 Mon Sep 17 00:00:00 2001
> From: Anirban Chakraborty
> Date: Wed, 12 Nov 2014 14:24:43 -0800
> Subject: [PATCH] network: Add network bandwidth support to ethernet interfaces
>
> Ethernet interfaces in
On 11/17/2014 08:48 AM, Gerd Hoffmann wrote:
Hi,
We cannot just start enforcing that the vram attribute should be power
of 2. We can ether silently modify the value from user to power of 2 or
let QEMU round the value up to nearest power of 2 value and just add
a note about this to documentat
62 matches
Mail list logo
