Re: [libvirt] [PATCH 3/5] ip link needs 'name' in 3.16 to create the veth pair

2014-11-26 Thread Richard Weinberger
Am 26.11.2014 um 05:51 schrieb Martin Kletzander: On Tue, Nov 25, 2014 at 04:19:48PM +0100, Richard Weinberger wrote: On Tue, Nov 25, 2014 at 9:21 AM, Cedric Bosdonnat cbosdon...@suse.com wrote: On Tue, 2014-11-25 at 08:42 +0100, Martin Kletzander wrote: On Mon, Nov 24, 2014 at 09:54:44PM

Re: [libvirt] [PATCH 3/5] ip link needs 'name' in 3.16 to create the veth pair

2014-11-26 Thread Cedric Bosdonnat
Hi Martin, On Wed, 2014-11-26 at 05:51 +0100, Martin Kletzander wrote: Instead of papering over the issue in libvirt better ship a non-broken iproute2 in openSUSE 13.2. real fix: https://git.kernel.org/cgit/linux/kernel/git/shemminger/iproute2.git/commit/?id=f1b66ff Oh, thank you for

[libvirt] [PATCH] Revert ip link needs 'name' in 3.16 to create the veth pair

2014-11-26 Thread Martin Kletzander
This reverts commit 433b427ff853ab72d32573d415e6ec569b77c7cb. The patch was added in order to overcome a bug in iproute2 and since it was properly identified as a bug, particularly in openSUSE 13.2, and it is being worked on [1], the best solution for libvirt seems to be to keep the old

Re: [libvirt] [PATCH 3/5] ip link needs 'name' in 3.16 to create the veth pair

2014-11-26 Thread Richard Weinberger
Am 26.11.2014 um 09:25 schrieb Cedric Bosdonnat: Hi Martin, On Wed, 2014-11-26 at 05:51 +0100, Martin Kletzander wrote: Instead of papering over the issue in libvirt better ship a non-broken iproute2 in openSUSE 13.2. real fix:

Re: [libvirt] [sandbox][PATCH 2/2] virt-sandbox-service: mount /var after all other file systems

2014-11-26 Thread Cedric Bosdonnat
Hi Martin, On Wed, 2014-11-26 at 05:32 +0100, Martin Kletzander wrote: + +# /var contains the mounted image if there is an image: should be the +# last thing to mount +self.add_bind_mount(source, /var) You have the source set from a random value from self.dirs, ACK

Re: [libvirt] [PATCH v2 0/5] Allow time sync on domain resume

2014-11-26 Thread Michal Privoznik
On 06.11.2014 14:01, Michal Privoznik wrote: Diff to v1: -Fixed issues raised by Peter Michal Privoznik (5): Introduce virDomainResumeFlags API Implement virDomainResumeFlags in all drivers qemu: Split qemuDomainSetTime into two functions qemuDomainResumeFlags: Introduce

Re: [libvirt] [PATCH 3/5] ip link needs 'name' in 3.16 to create the veth pair

2014-11-26 Thread Cedric Bosdonnat
On Wed, 2014-11-26 at 09:34 +0100, Richard Weinberger wrote: Am 26.11.2014 um 09:25 schrieb Cedric Bosdonnat: Hi Martin, On Wed, 2014-11-26 at 05:51 +0100, Martin Kletzander wrote: Instead of papering over the issue in libvirt better ship a non-broken iproute2 in openSUSE 13.2.

Re: [libvirt] [PATCH 3/5] ip link needs 'name' in 3.16 to create the veth pair

2014-11-26 Thread Richard Weinberger
Am 26.11.2014 um 10:16 schrieb Cedric Bosdonnat: On Wed, 2014-11-26 at 09:34 +0100, Richard Weinberger wrote: Am 26.11.2014 um 09:25 schrieb Cedric Bosdonnat: Hi Martin, On Wed, 2014-11-26 at 05:51 +0100, Martin Kletzander wrote: Instead of papering over the issue in libvirt better ship a

Re: [libvirt] [PATCH 2/2] Tests : Make nwfilter testcases robust against optional locking flags.

2014-11-26 Thread Prerna Saxena
Hi Martin, Thanks for the feedback. On Tuesday 25 November 2014 05:57 PM, Martin Kletzander wrote: On Tue, Nov 25, 2014 at 05:12:48PM +0530, Prerna Saxena wrote: Commit dc33e6e4a5a5d42 introduces iptables/ebtables to adding locking flags if/when these are available. However, the nwfilter

Re: [libvirt] [PATCH] qemu: output error when try to hotplug unsupport console

2014-11-26 Thread lhuang
On 11/26/2014 12:17 AM, Pavel Hrdina wrote: On 11/17/2014 03:31 PM, Luyao Huang wrote: https://bugzilla.redhat.com/show_bug.cgi?id=1164627 When try to use attach-device to hotplug a qemu unsupport sonsole, command will return success, and add a console in vm's xml.But this doesn't work in

Re: [libvirt] [PATCH RFC] storage: perform btrfs clone if possible

2014-11-26 Thread Chen, Hanxiao
-Original Message- From: Eric Blake [mailto:ebl...@redhat.com] Sent: Tuesday, November 25, 2014 11:59 PM To: Chen, Hanxiao/陈 晗霄; Martin Kletzander Cc: libvir-list@redhat.com Subject: Re: [libvirt] [PATCH RFC] storage: perform btrfs clone if possible On 11/25/2014 03:19 AM, Chen,

Re: [libvirt] [PATCH 2/2] Tests : Make nwfilter testcases robust against optional locking flags.

2014-11-26 Thread Martin Kletzander
On Wed, Nov 26, 2014 at 03:28:21PM +0530, Prerna Saxena wrote: Hi Martin, Thanks for the feedback. On Tuesday 25 November 2014 05:57 PM, Martin Kletzander wrote: On Tue, Nov 25, 2014 at 05:12:48PM +0530, Prerna Saxena wrote: Commit dc33e6e4a5a5d42 introduces iptables/ebtables to adding

Re: [libvirt] [PATCH 2/2] Tests : Make nwfilter testcases robust against optional locking flags.

2014-11-26 Thread Prerna Saxena
On Wednesday 26 November 2014 04:06 PM, Martin Kletzander wrote: On Wed, Nov 26, 2014 at 03:28:21PM +0530, Prerna Saxena wrote: Hi Martin, Thanks for the feedback. On Tuesday 25 November 2014 05:57 PM, Martin Kletzander wrote: On Tue, Nov 25, 2014 at 05:12:48PM +0530, Prerna Saxena wrote:

Re: [libvirt] [PATCH] storage: remove a redundant NULL assignment

2014-11-26 Thread Jiri Denemark
On Wed, Nov 26, 2014 at 15:51:17 +0800, Chen Hanxiao wrote: We already did this in virSecretDefFree. Signed-off-by: Chen Hanxiao chenhanx...@cn.fujitsu.com --- src/storage/storage_backend.c | 1 - 1 file changed, 1 deletion(-) diff --git a/src/storage/storage_backend.c

Re: [libvirt] [PATCH 2/2] Tests : Make nwfilter testcases robust against optional locking flags.

2014-11-26 Thread Martin Kletzander
On Wed, Nov 26, 2014 at 04:11:16PM +0530, Prerna Saxena wrote: On Wednesday 26 November 2014 04:06 PM, Martin Kletzander wrote: On Wed, Nov 26, 2014 at 03:28:21PM +0530, Prerna Saxena wrote: Hi Martin, Thanks for the feedback. On Tuesday 25 November 2014 05:57 PM, Martin Kletzander wrote:

[libvirt] [libvirt-glib PATCHv3] Add gvir_domain_open_graphics_fd()

2014-11-26 Thread Zeeshan Ali (Khattak)
Add binding for virDomainOpenGraphicsFD. If virDomainOpenGraphicsFD is not available, it means we are dealing with older libvirt so we create the socket pair ourselves if that is the case. --- configure.ac | 4 ++ libvirt-gobject/libvirt-gobject-domain.c | 72

Re: [libvirt] [PATCH] Revert ip link needs 'name' in 3.16 to create the veth pair

2014-11-26 Thread Eric Blake
On 11/26/2014 01:33 AM, Martin Kletzander wrote: This reverts commit 433b427ff853ab72d32573d415e6ec569b77c7cb. The patch was added in order to overcome a bug in iproute2 and since it was properly identified as a bug, particularly in openSUSE 13.2, and it is being worked on [1], the best

Re: [libvirt] [PATCH 3/5] ip link needs 'name' in 3.16 to create the veth pair

2014-11-26 Thread Eric Blake
On 11/26/2014 02:25 AM, Richard Weinberger wrote: So I think we should keep that for those running the buggy 3.16. openSUSE has to fix their package and to serve a bugfix update, full stop. Thought that may not happen only to openSUSE... and that fix didn't harm at all. Yes, but fixing

Re: [libvirt] [PATCH 3/5] ip link needs 'name' in 3.16 to create the veth pair

2014-11-26 Thread Richard Weinberger
Am 26.11.2014 um 14:23 schrieb Eric Blake: On 11/26/2014 02:25 AM, Richard Weinberger wrote: So I think we should keep that for those running the buggy 3.16. openSUSE has to fix their package and to serve a bugfix update, full stop. Thought that may not happen only to openSUSE... and that

Re: [libvirt] [PATCH] Revert ip link needs 'name' in 3.16 to create the veth pair

2014-11-26 Thread John Ferlan
On 11/26/2014 08:21 AM, Eric Blake wrote: On 11/26/2014 01:33 AM, Martin Kletzander wrote: This reverts commit 433b427ff853ab72d32573d415e6ec569b77c7cb. The patch was added in order to overcome a bug in iproute2 and since it was properly identified as a bug, particularly in openSUSE 13.2,

[libvirt] [PATCH] test: fix nwfilter tests following changes in virfirewall.c

2014-11-26 Thread Stefan Berger
Some of the nwfilter tests are now failing since --concurrent shows up in the ebtables command. To avoid this, implement a few functions that allow to set the booleans indicating how the locking is to be done to false, overriding the probing. Signed-off-by: Stefan Berger

[libvirt] [PATCH] network: Fix upgrade from libvirt older than 1.2.4

2014-11-26 Thread Jiri Denemark
Starting from libvirt-1.2.4, network state XML files moved to another directory (see commit b9e95491) and libvirt automatically migrates the network state files to a new location. However, the code used dirent.dt_type which is not supported by all filesystems. Thus, when libvirt is upgraded on a

Re: [libvirt] [PATCH] test: fix nwfilter tests following changes in virfirewall.c

2014-11-26 Thread Eric Blake
On 11/26/2014 08:58 AM, Stefan Berger wrote: Some of the nwfilter tests are now failing since --concurrent shows up in the ebtables command. To avoid this, implement a few functions that allow to set the booleans indicating how the locking is to be done to false, overriding the probing.

Re: [libvirt] [PATCH] network: Fix upgrade from libvirt older than 1.2.4

2014-11-26 Thread Eric Blake
On 11/26/2014 09:07 AM, Jiri Denemark wrote: Starting from libvirt-1.2.4, network state XML files moved to another directory (see commit b9e95491) and libvirt automatically migrates the network state files to a new location. However, the code used dirent.dt_type which is not supported by all

[libvirt] [PATCH v2] test: fix nwfilter tests following changes in virfirewall.c

2014-11-26 Thread Stefan Berger
Some of the nwfilter tests are now failing since --concurrent shows up in the ebtables command. To avoid this, implement a function preventing the probing for lock support in the eb/iptables tools and use it in the tests. Signed-off-by: Stefan Berger stef...@linux.vnet.ibm.com ---

Re: [libvirt] [PATCH 2/2] Tests : Make nwfilter testcases robust against optional locking flags.

2014-11-26 Thread Eric Blake
On 11/26/2014 04:09 AM, Martin Kletzander wrote: The problem is with expected results that are coded for these tests. On distros that support these flags, the issue would go away if the expected results take into account the locking flags. However, adding a permanent change to the expected

Re: [libvirt] [PATCH v2] test: fix nwfilter tests following changes in virfirewall.c

2014-11-26 Thread Eric Blake
On 11/26/2014 09:26 AM, Stefan Berger wrote: Some of the nwfilter tests are now failing since --concurrent shows up in the ebtables command. To avoid this, implement a function preventing the probing for lock support in the eb/iptables tools and use it in the tests. Now that I've read Martin

[libvirt] [PATCH 2/2] security: Manage SELinux labels on shared/readonly hostdev's

2014-11-26 Thread John Ferlan
https://bugzilla.redhat.com/show_bug.cgi?id=1082521 Support for shared hostdev's was added in a number of commits, initially starting with 'f2c1d9a80' and most recently commit id 'fd243fc4' to fix issues with the initial implementation. Missed in all those changes was the need to mimic the

[libvirt] [PATCH 0/2] Manage SELinux labels on shared/readonly hostdev's

2014-11-26 Thread John Ferlan
https://bugzilla.redhat.com/show_bug.cgi?id=1082521 Patch 1 is innocuous and perhaps could have been pushed as trivial... For Patch 2 I wasn't sure if I should use the virSecuritySELinuxSetFilecon or virSecuritySELinuxSetFileconOptional, so I went with the latter since it follows what

[libvirt] [PATCH 1/2] tests: Fix sharable typo

2014-11-26 Thread John Ferlan
Signed-off-by: John Ferlan jfer...@redhat.com --- tests/qemuargv2xmltest.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/qemuargv2xmltest.c b/tests/qemuargv2xmltest.c index 9c00cd9..cf4a6a8 100644 --- a/tests/qemuargv2xmltest.c +++ b/tests/qemuargv2xmltest.c @@ -30,7

Re: [libvirt] [PATCH v2] test: fix nwfilter tests following changes in virfirewall.c

2014-11-26 Thread Stefan Berger
On 11/26/2014 11:53 AM, Eric Blake wrote: On 11/26/2014 09:26 AM, Stefan Berger wrote: Some of the nwfilter tests are now failing since --concurrent shows up in the ebtables command. To avoid this, implement a function preventing the probing for lock support in the eb/iptables tools and use it

[libvirt] Cloning libvirt

2014-11-26 Thread Kevin Wilson
Hi, According to the web page you can clone libvirt by: git clone git://libvirt.org/libvirt.git There are places which block access via git connection, but permit git clone by http/https. So my question is: is there also an http/https server from which you can clone it ? Regards, Kevin --

Re: [libvirt] Cloning libvirt

2014-11-26 Thread Eric Blake
On 11/26/2014 11:51 AM, Kevin Wilson wrote: Hi, According to the web page you can clone libvirt by: git clone git://libvirt.org/libvirt.git There are places which block access via git connection, but permit git clone by http/https. So my question is: is there also an http/https server from

[libvirt] [PATCH] nwfilter: Add support for icmpv6 filtering

2014-11-26 Thread Stefan Berger
Make use of the ebtables functionality to be able to filter certain parameters of icmpv6 packets. Extend the XML parser for icmpv6 types, type ranges, codes, and code ranges. Extend the nwfilter documentation, schema, and test cases. Being able to filter icmpv6 types and codes helps extending the

[libvirt] systemd-cgroups-agent not working in containers

2014-11-26 Thread Richard Weinberger
Hi! I run a Linux container setup with openSUSE 13.1/2 as guest distro. After some time containers slow down. An investigation showed that the containers slow down because a lot of stale user sessions slow down almost all systemd tools, mostly systemctl. loginctl reports many thousand sessions.

[libvirt] [PATCH] qemu: add tun devices to cgroup ACL

2014-11-26 Thread rongqing.li
From: Roy Li rongqing...@windriver.com When systemd is used as init, CGroup will be enabled by default, and lead to virsh unable to start VM(which is using the tun/tap), since virsh can not access /dev/net/tun device Signed-off-by: Roy Li rongqing...@windriver.com --- src/qemu/qemu.conf