[libvirt] [PATCH 0/2] qemu: update jobinfo type if the job is not completed in qemuMigrationRun

2014-11-27 Thread Wang Rui
In qemuMigrationRun the jobinfo type won't be updated until qemuMigrationWaitForCompletion. If migration is failed or cancelled before that(such as in qemuMigrationDriveMirror), we can't get the right jobinfo type. The following patches fix it. Wang Rui (2): qemu: set jobinfo type to CANCELLED

[libvirt] [PATCH 2/2] qemu: set jobinfo type to FAILED if job is failed in qemuMigrationRun

2014-11-27 Thread Wang Rui
If job is failed in qemuMigrationRun, we expect the jobinfo type as FAILED. But jobinfo type won't be updated until entering qemuMigrationWaitForCompletion. We should make it updated in all conditions. Signed-off-by: Wang Rui moon.wang...@huawei.com --- src/qemu/qemu_migration.c | 7 ++- 1

[libvirt] [PATCH 1/2] qemu: set jobinfo type to CANCELLED if migration is cancelled in all conditions

2014-11-27 Thread Wang Rui
The migration job status is traced in qemuMigrationUpdateJobStatus which is called in qemuMigrationRun. But if migration is cancelled before the trace such as in qemuMigrationDriveMirror, the jobinfo type won't be update to CANCELLED. After this patch, we can get jobinfo type as CANCELLED if

Re: [libvirt] [PATCH v2] test: fix nwfilter tests following changes in virfirewall.c

2014-11-27 Thread Martin Kletzander
On Wed, Nov 26, 2014 at 01:18:53PM -0500, Stefan Berger wrote: On 11/26/2014 11:53 AM, Eric Blake wrote: On 11/26/2014 09:26 AM, Stefan Berger wrote: Some of the nwfilter tests are now failing since --concurrent shows up in the ebtables command. To avoid this, implement a function preventing

Re: [libvirt] [PATCH] Revert ip link needs 'name' in 3.16 to create the veth pair

2014-11-27 Thread Martin Kletzander
On Wed, Nov 26, 2014 at 09:02:28AM -0500, John Ferlan wrote: On 11/26/2014 08:21 AM, Eric Blake wrote: On 11/26/2014 01:33 AM, Martin Kletzander wrote: This reverts commit 433b427ff853ab72d32573d415e6ec569b77c7cb. The patch was added in order to overcome a bug in iproute2 and since it was

[libvirt] [PATCH] tests: fix documentation for mocking methods

2014-11-27 Thread Martin Kletzander
It looks like it was copy-pasted, so in case anyone wonders what some of those methods do without looking at them, and for the sake of completeness, fix them. Signed-off-by: Martin Kletzander mklet...@redhat.com --- tests/virmock.h | 17 + 1 file changed, 9 insertions(+), 8

Re: [libvirt] [PATCH] network: Fix upgrade from libvirt older than 1.2.4

2014-11-27 Thread Jiri Denemark
On Wed, Nov 26, 2014 at 09:16:59 -0700, Eric Blake wrote: On 11/26/2014 09:07 AM, Jiri Denemark wrote: Starting from libvirt-1.2.4, network state XML files moved to another directory (see commit b9e95491) and libvirt automatically migrates the network state files to a new location. However,

Re: [libvirt] [libvirt-glib PATCHv3] Add gvir_domain_open_graphics_fd()

2014-11-27 Thread Christophe Fergeau
On Wed, Nov 26, 2014 at 01:13:57PM +, Zeeshan Ali (Khattak) wrote: Add binding for virDomainOpenGraphicsFD. If virDomainOpenGraphicsFD is not available, it means we are dealing with older libvirt so we create the socket pair ourselves if that is the case. --- configure.ac

Re: [libvirt] [PATCH 1/2] qemu: set jobinfo type to CANCELLED if migration is cancelled in all conditions

2014-11-27 Thread Martin Kletzander
On Thu, Nov 27, 2014 at 04:26:24PM +0800, Wang Rui wrote: The migration job status is traced in qemuMigrationUpdateJobStatus which is called in qemuMigrationRun. But if migration is cancelled before the trace such as in qemuMigrationDriveMirror, the jobinfo type won't be update to CANCELLED.

[libvirt] [PATCH] qemu: Don't track quiesced state of FSs

2014-11-27 Thread Michal Privoznik
https://bugzilla.redhat.com/show_bug.cgi?id=1160084 As of b6d4dad11b (1.2.5) we are trying to keep the status of FSFreeze in the guest. Even though I've tried to fixed couple of corner cases (6ea54769ba18), it occurred to me just recently, that the approach is broken by design. Firstly, there are

[libvirt] [PATCH] qemu: fix block{commit,copy} abort handling

2014-11-27 Thread Erik Skultety
When a block{commit,copy} job was aborted on a domain, block job handler did not process it correctly, leaving a phantom job in the background. Any further calls to any blockjob causes block jobtype still active error. This patch fixes the blockjob handler so that it checks not only for

Re: [libvirt] [PATCH] qemu: Don't track quiesced state of FSs

2014-11-27 Thread Jiri Denemark
On Thu, Nov 27, 2014 at 13:27:25 +0100, Michal Privoznik wrote: https://bugzilla.redhat.com/show_bug.cgi?id=1160084 As of b6d4dad11b (1.2.5) we are trying to keep the status of FSFreeze in the guest. Even though I've tried to fixed couple of corner cases s/fixed/fix/ (6ea54769ba18), it

Re: [libvirt] [PATCH] qemu: fix block{commit,copy} abort handling

2014-11-27 Thread Jiri Denemark
On Thu, Nov 27, 2014 at 13:29:42 +0100, Erik Skultety wrote: When a block{commit,copy} job was aborted on a domain, block job handler did not process it correctly, leaving a phantom job in the background. Any further calls to any blockjob causes block jobtype still active error. This patch

Re: [libvirt] systemd-cgroups-agent not working in containers

2014-11-27 Thread Richard Weinberger
Am 26.11.2014 um 22:29 schrieb Richard Weinberger: Hi! I run a Linux container setup with openSUSE 13.1/2 as guest distro. After some time containers slow down. An investigation showed that the containers slow down because a lot of stale user sessions slow down almost all systemd tools,

[libvirt] [PATCH v1 0/5] Precreate storage on migration

2014-11-27 Thread Michal Privoznik
Yet another attempt. One thing that I'm not sure about is, whether this functionality should be on by default or tunable via say flag to migrate APIs. Thing is, in my approach I require disks to be in a storage pool (see the last patch for reasoning). On the other hand, if users still precreate

[libvirt] [PATCH v1 1/5] qemu: Expose qemuOpenFile and qemuOpenFileAs

2014-11-27 Thread Michal Privoznik
This is a pure code movement. Both of the APIs are going to be needed later in several areas of qemu driver code. Signed-off-by: Michal Privoznik mpriv...@redhat.com --- src/qemu/qemu_domain.c | 147 ++ src/qemu/qemu_domain.h | 10

[libvirt] [PATCH v1 4/5] qemu_migration: Send disk sizes to the other side

2014-11-27 Thread Michal Privoznik
Up 'til now, users need to precreate non-shared storage on migration themselves. This is not very friendly requirement and we should do something about it. In this patch, the migration cookie is extended, so that nbd/ section does not only contain NBD port, but info on disks being migrated. This

[libvirt] [PATCH v1 2/5] qemu: Split qemuDomainGetBlockInfo

2014-11-27 Thread Michal Privoznik
Again, this is a pure code movement. The function internals are going to be needed later when determining the disk capacity. Signed-off-by: Michal Privoznik mpriv...@redhat.com --- src/qemu/qemu_domain.c | 172 + src/qemu/qemu_domain.h | 6 ++

[libvirt] [PATCH v1 3/5] storage: Introduce storagePoolLookupByPath

2014-11-27 Thread Michal Privoznik
While this could be exposed as a public API, it's not done yet as there's no demand for that yet. Anyway, this is just preparing the environment for easier volume creation on the destination. Signed-off-by: Michal Privoznik mpriv...@redhat.com --- src/storage/storage_driver.c | 36

[libvirt] [PATCH v1 5/5] qemu_migration: Precreate missing storage

2014-11-27 Thread Michal Privoznik
Based on previous commit, we can now precreate missing volumes. While digging out the functionality from storage driver would be nicer, if you've seen the code it's nearly impossible. So I'm going from the other end: 1) For given disk target, disk path is looked up. 2) If the path exists, and has

Re: [libvirt] [PATCH] tests: fix documentation for mocking methods

2014-11-27 Thread Martin Kletzander
On Thu, Nov 27, 2014 at 09:48:37AM +0100, Martin Kletzander wrote: It looks like it was copy-pasted, so in case anyone wonders what some of those methods do without looking at them, and for the sake of completeness, fix them. Signed-off-by: Martin Kletzander mklet...@redhat.com ---

Re: [libvirt] [PATCH] Revert ip link needs 'name' in 3.16 to create the veth pair

2014-11-27 Thread Martin Kletzander
On Thu, Nov 27, 2014 at 09:45:51AM +0100, Martin Kletzander wrote: On Wed, Nov 26, 2014 at 09:02:28AM -0500, John Ferlan wrote: On 11/26/2014 08:21 AM, Eric Blake wrote: On 11/26/2014 01:33 AM, Martin Kletzander wrote: This reverts commit 433b427ff853ab72d32573d415e6ec569b77c7cb. The patch

Re: [libvirt] [PATCH v3 04/12] parallels: handle events from parallels server

2014-11-27 Thread Dmitry Guryanov
On Tuesday 25 November 2014 15:31:19 Maxim Nestratov wrote: 18.11.2014 16:16, Dmitry Guryanov пишет: From: Alexander Burluka aburl...@parallels.com Subscribe to events from parallels server. It's needed for 2 things: to update cached domains list and to send corresponding libvirt

Re: [libvirt] [PATCH v3 05/12] parallels: reimplement functions, which change domain state

2014-11-27 Thread Dmitry Guryanov
On Tuesday 25 November 2014 16:10:37 Maxim Nestratov wrote: 18.11.2014 16:17, Dmitry Guryanov пишет: Change domain state using parallels SDK functions instead of prlctl command. We don't need to send events from these functions now, becase events handler will send them. But we still

Re: [libvirt] [PATCH v3 07/12] parallels: create VMs and containers with sdk

2014-11-27 Thread Dmitry Guryanov
On Tuesday 25 November 2014 15:52:54 Maxim Nestratov wrote: 18.11.2014 16:17, Dmitry Guryanov пишет: This patch replaces code, which creates domains by running prlctl command. prlsdkCreateVm/Ct will do prlsdkApplyConfig, because we send request to the server only once in this case.

Re: [libvirt] [PATCH 1/2] qemu: set jobinfo type to CANCELLED if migration is cancelled in all conditions

2014-11-27 Thread Wang Rui
On 2014/11/27 18:48, Martin Kletzander wrote: On Thu, Nov 27, 2014 at 04:26:24PM +0800, Wang Rui wrote: The migration job status is traced in qemuMigrationUpdateJobStatus which is called in qemuMigrationRun. But if migration is cancelled before the trace such as in qemuMigrationDriveMirror,

[libvirt] [PATCH] Doc: some small issue in the document

2014-11-27 Thread Luyao Huang
When i pasted some xml from libvirt.org, i found some small mistake. Signed-off-by: Luyao Huang lhu...@redhat.com --- docs/formatdomain.html.in | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/docs/formatdomain.html.in b/docs/formatdomain.html.in index 9c1d0f4..c08b244