https://bugzilla.redhat.com/show_bug.cgi?id=1171582
When we edit a negative controller address number to a device, some
of them will auto generate a controller with invalid index number. This
will make guest disappear after restart libvirtd. Instead of allow
negative number for controller index,
On Fri, Dec 05, 2014 at 12:30:17PM +0100, Jiri Denemark wrote:
On Mon, Dec 01, 2014 at 12:00:52 +0100, Martin Kletzander wrote:
Whenever client socket was disconnected due to keepalive timeout, the
I/O event loop did not exit and continued until the point where the
hangup was found. Ending
On 12/05/2014 11:09 AM, Daniel P. Berrange wrote:
On Thu, Dec 04, 2014 at 09:30:54PM +0100, Pavel Hrdina wrote:
For example on FreeBSD the yajl library is located at /usr/local/lib
and it's not in default LIBS and therefore the configure fails that
yajl not installed.
We can use the
On 11/26/2014 10:02 PM, Stefan Berger wrote:
Make use of the ebtables functionality to be able to filter certain
parameters of icmpv6 packets. Extend the XML parser for icmpv6 types,
type ranges, codes, and code ranges. Extend the nwfilter documentation,
schema, and test cases.
Being able
On Fri, Dec 05, 2014 at 11:37:05PM +, Anirban Chakraborty wrote:
On 12/5/14, 10:43 AM, Laine Stump la...@laine.org wrote:
On 12/05/2014 06:12 AM, Michal Privoznik wrote:
@@ -7374,7 +7399,8 @@ qemuBuildInterfaceCommandLine(virCommandPtr cmd,
}
if (actualType ==
On 12/06/14 09:14, Eric Blake wrote:
Wire up backing chain recursion. Note that for now, we just use
...
Signed-off-by: Eric Blake ebl...@redhat.com
---
src/qemu/qemu_driver.c | 55
+-
1 file changed, 46 insertions(+), 9 deletions(-)
No answer ???
What does it mean :
-you don't have a window for the review ?
-you are not interested in getting these developments ?
-you don't agree with the delivery process I proposed ?
-you prefer getting the whole set of the v2 versions before reviewing ?
On 12/05/14 15:28, John Ferlan wrote:
On 12/05/2014 04:16 AM, Peter Krempa wrote:
Other parts of libvirt use %u for formatting uid/gid and typecast to
unsigned int. Storage driver used the signed variant.
---
src/storage/storage_driver.c | 21 -
1 file changed, 12
If user not specify network type ethernet, assume that user
needs simple tap device created with libvirt.
This patch does not need to run external script to create tap device or
add root to qemu process. Also libvirt runs script after device creating,
if user provide it.
Difference with v3 that
On 12/06/14 09:14, Eric Blake wrote:
qemuDomainGetStatsBlock() could leak a stats hash table if it
encountered OOM while populating the virTypedParameters.
Oddly, the fix doesn't even touch qemuDomainGetStatsBlock :)
* src/qemu/qemu_driver.c (QEMU_ADD_COUNT_PARAM)
(QEMU_ADD_NAME_PARAM):
On 12/06/14 09:14, Eric Blake wrote:
At least with 'virsh domstats --block' on an offline domain, we
currently output no stats even though we recognize the stat
category. Although a later patch will improve this situation,
it is better to document that this is expected behavior.
Also,
The module XML::XPath is needed when building from git only (no need to
have it when building from tarball), so this patch moves the check from
specfile into bootstrap.conf.
Signed-off-by: Martin Kletzander mklet...@redhat.com
---
This patch needs a gnulib update with this proposed patch in it:
On Sat, Dec 06, 2014 at 10:11:27AM +0100, Martin Kletzander wrote:
On Fri, Dec 05, 2014 at 09:55:00AM -0700, Eric Blake wrote:
On 12/05/2014 03:20 AM, Martin Kletzander wrote:
On Fri, Dec 05, 2014 at 09:47:47AM +, Ian Campbell wrote:
On Tue, 2014-12-02 at 07:50 +0100, Martin Kletzander
On 12/06/2014 03:14 AM, Eric Blake wrote:
In order for a future patch to virDomainListGetStats to reuse
some code for determining disk usage of offline domains, we
need to make it easier to pull out part of the guts of grabbing
blockinfo. The current implementation grabs a job fairly late
On Fri, 2014-12-05 at 16:30 +, Anthony PERARD wrote:
Jim Fehlig maintains the libxl driver in libvirt, so you should CC him
(I've done so here...)
The path to the pty of a Xen PV console is set only in
virDomainOpenConsole. But this is done too late. A call to
virDomainGetXMLDesc done
On Mon, Dec 01, 2014 at 10:46:38AM +0100, Jiri Denemark wrote:
On Sun, Nov 30, 2014 at 20:09:08 +0100, Martin Kletzander wrote:
Whenever client socket was marked as closed for some reason, it could've
been changed when really closing the connection. With this patch the
proper reason is kept
On Fri, Dec 05, 2014 at 12:32:28PM +0100, Jiri Denemark wrote:
On Mon, Dec 01, 2014 at 12:00:53 +0100, Martin Kletzander wrote:
Each command that needs a connection causes a new connection to be
made. Reconnecting after a command failed is pointless, mainly when
there is no other command to
Hi all,
The recent patch series that finally start using vram attribute for QEMU
video devices and also introduced new vgamem attribute breaks migration
from older libvirts to the currently developed version.
_Situation before patches:_
The libvirt's XML configuration for VGA device has
On 12/06/14 09:14, Eric Blake wrote:
Right now, grabbing blockinfo always calls stat on the disk, then
opens the image to determine the capacity, using a throw-away
virStorageSourcePtr. This has a couple of drawbacks:
1. We are calling stat and opening a file on every invocation of
the
Use 'they' instead of 'he'.
---
docs/hacking.html.in | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/docs/hacking.html.in b/docs/hacking.html.in
index 32ebd8e..a73b1e0 100644
--- a/docs/hacking.html.in
+++ b/docs/hacking.html.in
@@ -65,7 +65,7 @@
review your patch
On 12/08/14 14:15, Christophe Fergeau wrote:
Use 'they' instead of 'he'.
---
docs/hacking.html.in | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/docs/hacking.html.in b/docs/hacking.html.in
index 32ebd8e..a73b1e0 100644
--- a/docs/hacking.html.in
+++
On 12/08/14 14:19, Peter Krempa wrote:
On 12/08/14 14:15, Christophe Fergeau wrote:
Use 'they' instead of 'he'.
---
docs/hacking.html.in | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Also, you need to regenerate and push the change to the HACKING file too
along with this patch
We can change vnc password by using virDomainUpdateDeviceFlags API with
live flag. But it can't be changed with config flag.
v1: https://www.redhat.com/archives/libvir-list/2014-November/msg00627.html
diff to v1:
according to Jan's suggestion,
1. (patch 1/3) change error number to
Signed-off-by: Wang Rui moon.wang...@huawei.com
---
src/qemu/qemu_hotplug.c | 8 +++-
1 file changed, 3 insertions(+), 5 deletions(-)
diff --git a/src/qemu/qemu_hotplug.c b/src/qemu/qemu_hotplug.c
index d1767bb..ec0122b 100644
--- a/src/qemu/qemu_hotplug.c
+++ b/src/qemu/qemu_hotplug.c
@@
It's not supported to change some graphics arguments with '--live'.
Replace some error code VIR_ERR_INTERNAL_ERROR and VIR_ERR_INVALID_ARG
with VIR_ERR_OPERATION_UNSUPPORTED.
Signed-off-by: Wang Rui moon.wang...@huawei.com
---
src/qemu/qemu_hotplug.c | 16
1 file changed, 8
We can change vnc password by using virDomainUpdateDeviceFlags API with
live flag. But it can't be changed with config flag. Error is reported as
below.
error: Operation not supported: persistent update of device 'graphics' is not
supported
This patch supports the graphics arguments changed
On 12/06/14 09:14, Eric Blake wrote:
Create a helper function that can be reused for gathering block
info from virDomainListGetStats.
* src/qemu/qemu_driver.c (qemuDomainGetBlockInfo): Split guts...
(qemuStorageLimitsRefresh): ...into new helper function.
Signed-off-by: Eric Blake
On 12/06/14 09:14, Eric Blake wrote:
I noticed that for an offline domain, 'virsh domstats --block $dom'
was producing just the domain name, with no stats. But the older
'virsh domblkinfo' works just fine on offline domains. This patch
starts to get us closer, by at least reporting the disk
On 12/06/14 09:14, Eric Blake wrote:
The prior refactoring can now be put to use. With the same domain
as the previous commit (one qcow2 disk and an empty cdrom drive):
$ virsh domstats --block foo
Domain: 'foo'
block.count=2
block.0.name=hda
block.0.allocation=200704
On 12/06/14 09:14, Eric Blake wrote:
I'm about to make block stats optionally more complex to cover
backing chains, where block.count will no longer equal the number
of disks for a domain. For these reasons, it is nicer if the
statistics output includes the source path (for local files).
On 25.11.2014 10:10, Yves Vinter wrote:
Hi All,
As I described the 27^th of October in the following thread:
https://www.redhat.com/archives/libvir-list/2014-October/msg00840.html
[libvirt] [PATCH v2 0/21] hyperv: hyperv: set of new functionalities
new functionalities has been implemented in
On 12/06/14 09:14, Eric Blake wrote:
A coming patch will make it optionally possible to list backing
chain block stats; in this mode of operation, block.counts is no
longer the number of disks in the domain, but the number of
blocks in the array being reported. We still want block.count
On 12/06/14 09:14, Eric Blake wrote:
This patch introduces access to allocation information about
a backing chain of a live domain. While querying storage
volumes for read-only disks could provide some of the details,
there is one case where we have to rely on qemu: when doing
a block commit
On 12/08/14 15:19, Peter Krempa wrote:
On 12/06/14 09:14, Eric Blake wrote:
A coming patch will make it optionally possible to list backing
chain block stats; in this mode of operation, block.counts is no
longer the number of disks in the domain, but the number of
blocks in the array being
On 12/06/14 09:14, Eric Blake wrote:
In order to report stats on backing chains, we need to separate
the output of stats for one block from how we traverse blocks.
* src/qemu/qemu_driver.c (qemuDomainGetStatsBlock): Split...
(qemuDomainGetStatsOneBlock): ...into new helper.
Signed-off-by:
On 12/06/14 09:14, Eric Blake wrote:
Wire up backing chain recursion. Note that for now, we just use
the same allocation numbers for read-only backing files as what
offline domains would report. It is not the correct allocation
number for qcow2 over block devices during block-commit, and it
On 12/05/14 15:02, Martin Kletzander wrote:
Currently, when there is an API that's blocking with locked domain and
second API that's waiting in virDomainObjListFindByUUID() for the domain
lock (with the domain list locked) no other API can be executed on any
domain on the whole hypervisor
On Mon, Dec 08, 2014 at 11:59:44AM +, Ian Campbell wrote:
On Fri, 2014-12-05 at 16:30 +, Anthony PERARD wrote:
Jim Fehlig maintains the libxl driver in libvirt, so you should CC him
(I've done so here...)
Thanks.
The path to the pty of a Xen PV console is set only in
On Mon, Dec 08, 2014 at 04:07:39PM +0100, Peter Krempa wrote:
On 12/05/14 15:02, Martin Kletzander wrote:
Currently, when there is an API that's blocking with locked domain and
second API that's waiting in virDomainObjListFindByUUID() for the domain
lock (with the domain list locked) no
On Mon, 2014-12-08 at 15:11 +, Anthony PERARD wrote:
The patch intend to get the tty path on the first call of GetXMLDesc.
Doesn't it actually do it on domain start (which makes more sense to me
anyway).
Just a wording issue. I meant: Have GetXMLDesc always return the path to
the
This has a qemu: prefix, even though the parsing is done in conf:
It would look nicer split into several commits:
1) parsing the new controller type (without auto-adding them) + qemuxml2xml
test of the controllers
2) auto-adding the controllers
3) adding the 0 domain parameter to many functions
On 11/17/2014 11:02 AM, Shivaprasad G Bhat wrote:
To support VFIO for PPC, spapr-vfio-pci-host-bridge is needed in
QEMU. This patch adds capability for it.
Signed-off-by: Li Zhang zhlci...@linux.vnet.ibm.com
Signed-off-by: Shivaprasad G Bhat sb...@linux.vnet.ibm.com
Reviewed-by: Prerna
On 11/17/2014 11:05 AM, Shivaprasad G Bhat wrote:
On pseries, the vfio host devices attach to the spapr-pci-vfio domain
instead of the default emulated domain.
So, for a host device belonging to iommu group(say) 3, would need below
host bridge.
-device
On Mon, Dec 08, 2014 at 03:12:11PM +, Daniel P. Berrange wrote:
On Mon, Dec 08, 2014 at 04:07:39PM +0100, Peter Krempa wrote:
On 12/05/14 15:02, Martin Kletzander wrote:
Currently, when there is an API that's blocking with locked domain and
second API that's waiting in
On 11/17/2014 11:05 AM, Shivaprasad G Bhat wrote:
The test case adds passthrough hostdevices and interface of
type hostdev. The test case tests the address for multifunction,
multibus, and pci bridges within the spapr-vfio domain.
Signed-off-by: Shivaprasad G Bhat sb...@linux.vnet.ibm.com
On 12/05/2014 05:30 PM, Anthony PERARD wrote:
Hi,
I'm trying to fix an issue when using OpenStack with libvirt+xen
(libxenlight).
OpenStack cannot access the console output of a Xen PV guest, because the XML
generated by libvirt for a domain is missing the path to the pty. The path
The idea behind these patches is the following:
1) most virtual machines only have a single MAC address behind each
interface, and that MAC address is known by libvirt.
2) If we (i.e. libvirt) manually add an entry to the bridge's
forwarding database (fdb) for the MAC address associated with a
The macTableManager attribute of a network's bridge subelement tells
libvirt how the bridge's MAC address table (used to determine the
egress port for packets) is managed. In the default mode, kernel,
management is left to the kernel, which usually determines entries in
part by turning on
At the time that the network driver allocates a connection to a
network, the tap device that will be used hasn't yet been created -
that will be done later by qemu (or lxc or whoever) - but if the
network has macTableManager='libvirt', then when we do get around to
creating the tap device, we will
qemuNetworkIfaceConnect() used to have a special case for
actualType='network' (a network with forward mode of route, nat, or
isolated) to call the libvirt public API to retrieve the bridge being
used by a network. That is no longer necessary - since all network
types that use a bridge and tap
lxcProcessSetupInterfaces() used to have a special case for
actualType='network' (a network with forward mode of route, nat, or
isolated) to call the libvirt public API to retrieve the bridge being
used by a network. That is no longer necessary - since all network
types that use a bridge and tap
These two functions use netlink RTM_NEWNEIGH and RTM_DELNEIGH messages
to add and delete entries from a bridge's fdb. The bridge itself is
not referenced in the arguments to the functions, only the name of the
device that is attached to the bridge (since a device can only be
attached to one bridge
When the actualType of a virDomainNetDef is network, it means that
we are connecting to a libvirt-managed network (routed, natted, or
isolated) which does use a bridge device (created by libvirt). In the
past we have required drivers such as qemu to call the public API to
retrieve the bridge name
When libvirt is managing the MAC table of a Linux host bridge, it must
turn off learning and unicast_flood for each tap device attached to
that bridge, then add a Forwarding Database (fdb) entry for the tap
device using the MAC address from the domain interface config.
Once we have disabled
These functions all set/get items in the sysfs for a bridge device.
---
No change since V1.
src/libvirt_private.syms | 6 ++
src/util/virnetdevbridge.c | 235 -
src/util/virnetdevbridge.h | 28 +-
3 files changed, 266 insertions(+), 3
When the bridge device for a network has macTableManager='libvirt' the
intent is that all kernel management of the bridge's MAC table
(Forwarding Database, or fdb, in the case of a Linux Host Bridge) be
disabled, with libvirt handling updates to the table instead. The
setup required for the bridge
Replace the parts of the code where a backing store is set manually
with virStorageSourceSetBackingStore
Signed-off-by: Matthias Gatto matthias.ga...@outscale.com
---
src/conf/domain_conf.c | 2 +-
src/qemu/qemu_domain.c | 1 -
src/qemu/qemu_driver.c | 4 ++--
As explained for virStorageSourceGetBackingStore, quorum allows
multiple backing store, this make the operation to set bs complex
because we have to check if the backingStore is used as an array
or a pointer, and set it differently in both case.
In order to help the manipulation of backing store,
Create virStorageSourceGetBackingStore function in
preparation for quorum:
Actually, if we want to get a backing store inside a virStorageSource
we have to do it manually(src-backingStore = backingStore).
The problem is that with a quorum, a virStorageSource
can contain multiple backing stores,
As explain in the former patchs, backingStore can be treat an array or
a pointer.
If we have only one backingStore we have to use it as a normal ptr
but if there is more backing store, we use it as a pointer's array.
Because it would be complicated to expend backingStore manually, and do
the
Allow to libvirt to build the quorum string used by quemu.
Add 2 static functions: qemuBuildQuorumStr and
qemuBuildAndAppendDriveStrToVirBuffer.
qemuBuildQuorumStr is made because a quorum can have another quorum
as a child, so we may need to call qemuBuildQuorumStr recursively.
The purpose of these patches is to introduce quorum for libvirt
I've try to follow this proposal:
http://www.redhat.com/archives/libvir-list/2014-May/msg00533.html
This feature ask for 6 task:
1) Allow a _virStorageSource
to contain more than one backing store.
Therefore we have to treat the
Add nodename inside virstoragefile
During xml backingStore parsing, look for a nodename attribute in the disk
declaration if this one is a quorum, if a nodename is found, add it to
the virStorageSource otherwise create a new one with a random name.
Take inspiration from this patch to create the
Add the capabiltty to libvirt to parse and format the quorum syntax
as described here:
http://www.redhat.com/archives/libvir-list/2014-May/msg00533.html
Signed-off-by: Matthias Gatto matthias.ga...@outscale.com
---
src/conf/domain_conf.c | 165 +++--
1
Uniformize backing store usage by calling virStorageSourceGetBackingStore
instead of setting backing store manually.
Signed-off-by: Matthias Gatto matthias.ga...@outscale.com
---
src/conf/domain_conf.c| 7 ---
src/conf/storage_conf.c | 4 ++--
Add VIR_STORAGE_TYPE_QUORUM in virStorageType.
Add VIR_STORAGE_FILE_QUORUM in virStorageFileFormat.
Add threshold value in _virStorageSource
Signed-off-by: Matthias Gatto matthias.ga...@outscale.com
---
src/conf/domain_conf.c| 2 ++
src/qemu/qemu_command.c | 1 +
src/qemu/qemu_driver.c
On Mon, Dec 08, 2014 at 11:00:03AM -0500, Laine Stump wrote:
The macTableManager attribute of a network's bridge subelement tells
libvirt how the bridge's MAC address table (used to determine the
egress port for packets) is managed. In the default mode, kernel,
management is left to the
On 12/08/2014 03:50 AM, Peter Krempa wrote:
On 12/06/14 09:14, Eric Blake wrote:
qemuDomainGetStatsBlock() could leak a stats hash table if it
encountered OOM while populating the virTypedParameters.
Oddly, the fix doesn't even touch qemuDomainGetStatsBlock :)
+ cleanup:
With this change
On Mon, Dec 08, 2014 at 04:40:04PM +0100, Ján Tomko wrote:
On 12/05/2014 05:30 PM, Anthony PERARD wrote:
Hi,
I'm trying to fix an issue when using OpenStack with libvirt+xen
(libxenlight).
OpenStack cannot access the console output of a Xen PV guest, because the
XML
generated by
On 12/08/2014 07:26 AM, Peter Krempa wrote:
On 12/08/14 15:19, Peter Krempa wrote:
On 12/06/14 09:14, Eric Blake wrote:
A coming patch will make it optionally possible to list backing
chain block stats; in this mode of operation, block.counts is no
longer the number of disks in the domain,
Avoid leaving the domain locked on a failed ACL check. Introduced in
commit abf75aea247e (Add ACL checks into the QEMU driver).
---
src/qemu/qemu_driver.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c
index ed8e140..8cec372
Make use of the ebtables functionality to be able to filter certain
parameters of icmpv6 packets. Extend the XML parser for icmpv6 types,
type ranges, codes, and code ranges. Extend the nwfilter documentation,
schema, and test cases.
Being able to filter icmpv6 types and codes helps extending the
On 12/06/14 02:59, Daniel Veillard wrote:
The plan exposed last month is to push the new release mid month.
I will be unavailable mostly on 15-16 so pondering pushing next week,
which means entering freeze for example Tuesday morning for a final
release toward Fri 12 or Sat 13. We have close
Avoid leaving the domain locked on a failed ACL check. Introduced in
commit abf75aea247e (Add ACL checks into the QEMU driver).
---
src/qemu/qemu_driver.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c
index 8cec372..0a684e1
On 12/05/14 15:03, Martin Kletzander wrote:
There is one problem that causes various errors in the daemon. When
domain is waiting for a job, it is unlocked while waiting on the
condition. However, if that domain is for example transient and being
removed in another API (e.g. cancelling
On 12/08/2014 07:17 AM, Peter Krempa wrote:
On 12/06/14 09:14, Eric Blake wrote:
I'm about to make block stats optionally more complex to cover
backing chains, where block.count will no longer equal the number
of disks for a domain. For these reasons, it is nicer if the
statistics output
On 12/08/2014 11:53 AM, Peter Krempa wrote:
Avoid leaving the domain locked on a failed ACL check. Introduced in
commit abf75aea247e (Add ACL checks into the QEMU driver).
---
src/qemu/qemu_driver.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
Should this be squashed with your
Anthony PERARD wrote:
The path to the pty of a Xen PV console is set only in
virDomainOpenConsole. But this is done too late. A call to
virDomainGetXMLDesc done before OpenConsole will not have the path to
the pty, but a call after OpenConsole will.
Hi Anthony,
Thanks for the patch. Can
Anthony PERARD wrote:
Hi,
I'm trying to fix an issue when using OpenStack with libvirt+xen
(libxenlight).
OpenStack cannot access the console output of a Xen PV guest, because the XML
generated by libvirt for a domain is missing the path to the pty. The path
actually appear in the XML once
On 12/08/2014 06:03 AM, Peter Krempa wrote:
On 12/06/14 09:14, Eric Blake wrote:
Right now, grabbing blockinfo always calls stat on the disk, then
opens the image to determine the capacity, using a throw-away
virStorageSourcePtr. This has a couple of drawbacks:
+ * For read-only disks,
On 12/04/2014 04:07 PM, Kyle DeFrancia wrote:
This resolves: https://bugzilla.redhat.com/show_bug.cgi?id=907779
A dhcp element can exist in only one IPv4 address and one IPv6
address per network. This patch enforces that in virNetworkUpdate.
---
Rebased to latest master, hopefully this
On 12/6/14, 2:51 AM, Vasiliy Tolstov v.tols...@selfip.ru wrote:
2014-12-06 2:37 GMT+03:00 Anirban Chakraborty abc...@juniper.net:
In Open Contrail (www.opencontrail.org), we use this feature where tap
interface is created first, so that we know the name of the tap device a
priori, before
On 12/08/2014 11:33 AM, Daniel P. Berrange wrote:
ACK, design looks good now.
Thanks! Based on the previous ACKs of the code, and this ACK of the new
name, I've pushed the series.
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
util/virnetdevbridge.c: In function 'virNetDevBridgePortSetLearning':
util/virnetdevbridge.c:359:38: error: unused parameter 'enable'
[-Werror=unused-parameter]
bool enable)
^
* src/util/virnetdevbridge.c
2014-12-08 23:51 GMT+03:00 Anirban Chakraborty abc...@juniper.net:
Yes, that will work.
So as i see two different point of view... I want to get this patch in
next libvirt release
What i need to do?
--
Vasiliy Tolstov,
e-mail: v.tols...@selfip.ru
jabber: v...@selfip.ru
--
libvir-list
Commit c75425734 introduced a compilation failure:
../../src/access/viraccessdriverpolkit.c: In function
'virAccessDriverPolkitCheck':
../../src/access/viraccessdriverpolkit.c:137:5: error: format '%d' expects
argument of type 'int', but argument 9 has type 'pid_t' [-Werror=format=]
On 12/8/14, 2:10 AM, Daniel P. Berrange berra...@redhat.com wrote:
On Fri, Dec 05, 2014 at 11:37:05PM +, Anirban Chakraborty wrote:
On 12/5/14, 10:43 AM, Laine Stump la...@laine.org wrote:
On 12/05/2014 06:12 AM, Michal Privoznik wrote:
@@ -7374,7 +7399,8 @@
Several portability changes, but the one we are most interested in
is the improvement to bootstrap to detect perl modules.
This patch doesn't actually change our bootstrap requirements
(that will be a separate patch), but sets the stage for it.
* .gnulib: Update to latest, for bootstrap
On 12/08/2014 04:22 AM, Martin Kletzander wrote:
How can you add a perl module in buildreq? I'm not familiar with how
bootstrap works.
I had a look at that and posted a patch for gnulib [1] to work with
perl modules and additional path for libvirt [2] which takes that into
account. Let
On 12/08/2014 03:32 AM, Yves Vinter wrote:
No answer ???
What does it mean :
-you don't have a window for the review ?
Probably truer than we wish - the biggest bottleneck in open source
projects is review time.
-you are not interested in getting these developments ?
On 12/08/2014 04:13 AM, Martin Kletzander wrote:
The module XML::XPath is needed when building from git only (no need to
have it when building from tarball), so this patch moves the check from
specfile into bootstrap.conf.
Signed-off-by: Martin Kletzander mklet...@redhat.com
---
This patch
As planned, I tagged 1.2.11-rc1 in git and made signed tarballs and
rpms available at the usual place:
ftp://libvirt.org/libvirt/
This seems to work fine in my limited testing, but please give it
a serious try !
I understand Peter concerns w.r.t. the parallels patches, IMHO if
this
libxl supports sysrq. Add .domainSendKey function to support
sending sysrq key.
Signed-off-by: Chunyan Liu cy...@suse.com
---
src/libxl/libxl_driver.c | 89
1 file changed, 89 insertions(+)
diff --git a/src/libxl/libxl_driver.c
xm/xend and libxl already support sending sysrq key. Adding the
equivalant to libvirt.
Chunyan Liu (3):
virkeycode: add virKeynameFromKeycode function
xen: add .domainSendKey
libxl: add .domainSendKey
src/libvirt_private.syms | 1 +
src/libxl/libxl_driver.c | 89
xm/xend supports sysrq command. Add .domainSendKey function to support
sending sysrq key.
Signed-off-by: Chunyan Liu cy...@suse.com
---
src/xen/xen_driver.c| 85 +
src/xen/xend_internal.c | 21
src/xen/xend_internal.h | 1 +
3
Add virKeynameFromKeycode for later xen/libxl sendkey usage.
Signed-off-by: Chunyan Liu cy...@suse.com
---
src/libvirt_private.syms | 1 +
src/util/virkeycode.c| 17 +
src/util/virkeycode.h| 1 +
3 files changed, 19 insertions(+)
diff --git a/src/libvirt_private.syms
The variable `nparams` didn't change accordingly when adding a new
parameter in commit b2cecf73.
This patch fixes https://bugzilla.redhat.com/show_bug.cgi?id=1171938
Signed-off-by: Hao Liu h...@redhat.com
---
Virt.xs | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Virt.xs
https://bugzilla.redhat.com/show_bug.cgi?id=1164627
When try to use attach-device to hotplug a qemu
unsupport sonsole, command will return success,
and add a console in vm's xml.But this doesn't work
in qemu, qemu doesn't support these console.Add
a error output when try to hotplug a unsupport
Add a func just check the base target type which
qemu support. But i still doubt this will be useful
, we already have a check when we try to start the
vm. And this check only check the target type, and
the other things will be done in virDomainChrDefParseXML.
Signed-off-by: Luyao Huang
When use attach-device to hotplug a qemu unsupported console, command
will success and add a XML to the running guest, but donnot do anything
in qemu side. Add a check in qemuBuildConsoleChrDeviceStr, and output a
error when try to attach a qemu unsupport console.
About report error for qemu
1 - 100 of 103 matches
Mail list logo
