On 01/05/2015 11:48 PM, Peter Krempa wrote:
On 01/03/15 06:06, Luyao Huang wrote:
We have enough patches for hotplug RNG device, maybe we can
implement live hotplug of a RNG device.
Signed-off-by: Luyao Huang lhu...@redhat.com
---
src/qemu/qemu_driver.c | 8 -
src/qemu/qemu_hotplug.c
On 01/05/2015 11:31 PM, Peter Krempa wrote:
On 01/03/15 06:06, Luyao Huang wrote:
These 2 functions just do some basic check and then call
qemuMonitorJSONAttachRNGDev and qemuMonitorDelObject to
help us.
Signed-off-by: Luyao Huang lhu...@redhat.com
---
src/qemu/qemu_monitor.c | 43
Add API openGraphicsFD test case to linux_domain.conf
Jincheng Miao (2):
domain: add open_graphicsfd
Add open_graphicsFD to linux_domain.conf
cases/linux_domain.conf | 14 ++
repos/domain/open_graphicsfd.py | 89 +++
2 files changed, 103
On 01/05/2015 11:22 PM, Peter Krempa wrote:
On 01/03/15 06:06, Luyao Huang wrote:
qemu side functions, call virDomainRNGInsert and virDomainRNGRemove
to help us.
Signed-off-by: Luyao Huang lhu...@redhat.com
---
src/qemu/qemu_hotplug.c | 23 +++
src/qemu/qemu_hotplug.h |
On 01/05/2015 11:00 PM, Peter Krempa wrote:
Subject: ... How about
conf: Introduce function to compare RNG devices.
On 01/03/15 06:06, Luyao Huang wrote:
virDomainRNGEquals is a func which check if two rng device
are the same.
Signed-off-by: Luyao Huang lhu...@redhat.com
---
On 01/05/2015 11:45 PM, Peter Krempa wrote:
On 01/05/15 15:51, Peter Krempa wrote:
On 01/03/15 06:06, Luyao Huang wrote:
We didn't set a id when we build RNG device cmdline before.
Give a id to every RNG device and we can hotunplug it via
QMP cmd device_del.
Signed-off-by: Luyao Huang
On 01/05/2015 11:10 PM, Peter Krempa wrote:
Subject: perhaps..
qemu: Add helper to assign RNG device aliases
Thanks, good Subject
On 01/03/15 06:06, Luyao Huang wrote:
This function used to set a alias name for RNG device, usage just
This function is used to assign an alias for a RNG
On 01/05/2015 11:18 PM, Peter Krempa wrote:
Subject: change something? That's a really vague statement.
How about:
qemu: refactor qemuBuildRNGDeviceArgs to allow reuse in RNG hotplug
Good subject :)
Thanks
On 01/03/15 06:06, Luyao Huang wrote:
rename qemuBuildRNGDeviceArgs to
On 01/05/2015 11:32 PM, Peter Krempa wrote:
In subject:
audit: export virDomainAuditRNG
On 01/03/15 06:06, Luyao Huang wrote:
Signed-off-by: Luyao Huang lhu...@redhat.com
---
src/conf/domain_audit.c | 2 +-
src/conf/domain_audit.h | 7 +++
src/libvirt_private.syms | 1 +
3 files
Add test case for API domain.openGraphicsFD.
Signed-off-by: Jincheng Miao jm...@redhat.com
---
repos/domain/open_graphicsfd.py | 89 +++
1 files changed, 89 insertions(+), 0 deletions(-)
create mode 100644 repos/domain/open_graphicsfd.py
diff --git
Signed-off-by: Jincheng Miao jm...@redhat.com
---
cases/linux_domain.conf | 14 ++
1 files changed, 14 insertions(+), 0 deletions(-)
diff --git a/cases/linux_domain.conf b/cases/linux_domain.conf
index e7d6bac..b617ace 100644
--- a/cases/linux_domain.conf
+++
On 01/05/2015 11:29 PM, Peter Krempa wrote:
On 01/03/15 06:06, Luyao Huang wrote:
We need a new function to build a RNG device object, and need a
function to build a props which will be used in qemuMonitorJSONAddObject.
Signed-off-by: Luyao Huang lhu...@redhat.com
---
On 12/30/2014 11:33 AM, Cédric Bosdonnat wrote:
Hi there,
Here are 2 patches fixing tiny annoying problems. One of them, makes
apparmor profiles handle /usr/lib64 folder and the other one fixes an
uncleaned piece of domain config.
Cédric Bosdonnat (2):
Teach AppArmor, that /usr/lib64
On Sun, 2015-01-04 at 10:00 -0600, Jamie Strandboge wrote:
On 12/30/2014 04:33 AM, Cédric Bosdonnat wrote:
The apparmor profiles forgot about /usr/lib64 folders, just add lib64
as a possible alternative to lib in the paths
These changes all look good to me. +1
Pushed, then.
Thanks for the
https://bugzilla.redhat.com/show_bug.cgi?id=1178652
We will get a warning when we have a guest in paused
status(casue by kernel panic) and restart libvirtd,
warning message like this:
Qemu reported unknown VM status: 'guest-panicked'
and this seems because we set a wrong status name in
Well, the parallel build doesn't work as there are not dependencies
set correctly. When running 'make -j' I see this error:
make[2]: Entering directory '/home/zippy/work/libvirt/libvirt.git/src'
GEN util/virkeymaps.h
GEN locking/lock_protocol.h
make[2]: *** No rule to make target
On Wed, Dec 17, 2014 at 10:53 AM, Matthias Gatto
matthias.ga...@outscale.com wrote:
On Mon, Dec 8, 2014 at 7:31 PM, Matthias Gatto
matthias.ga...@outscale.com wrote:
The purpose of these patches is to introduce quorum for libvirt
I've try to follow this proposal:
On 30.12.2014 16:46, Narayanan, Krishnaprasad wrote:
Hello all,
I am using libvirt version 1.1.1 on one of the nodes which has several
VMs. When I used virsh dommemstat domain UUID, I am getting the
following flags: actual, swap_in and rss. I am not able to get the
unused memory that is
On 01/03/15 06:06, Luyao Huang wrote:
Signed-off-by: Luyao Huang lhu...@redhat.com
---
src/libvirt_private.syms | 5 +
1 file changed, 5 insertions(+)
diff --git a/src/libvirt_private.syms b/src/libvirt_private.syms
index aa776b4..deab4cf 100644
--- a/src/libvirt_private.syms
+++
On 01/03/15 06:06, Luyao Huang wrote:
We didn't set a id when we build RNG device cmdline before.
Give a id to every RNG device and we can hotunplug it via
QMP cmd device_del.
Signed-off-by: Luyao Huang lhu...@redhat.com
---
src/qemu/qemu_command.c | 12 ++--
1 file changed, 6
The subject is vague. Please try to condense what the patch is adding in
a way that describes the functions instead of an opaque add 3 functions
On 01/03/15 06:06, Luyao Huang wrote:
the 3 functions are:
virDomainRNGInsert: Insert a RNG device to vm-def.
virDomainRNGRemove: remove a RNG
Subject: ... How about
conf: Introduce function to compare RNG devices.
On 01/03/15 06:06, Luyao Huang wrote:
virDomainRNGEquals is a func which check if two rng device
are the same.
Signed-off-by: Luyao Huang lhu...@redhat.com
---
src/conf/domain_conf.c | 34
The local gnulib ssize_t.m4.diff patch no longer applied due to
changed context from the date change.
---
gnulib/local/m4/ssize_t.m4.diff | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Pushed as another build breaker fix
diff --git a/gnulib/local/m4/ssize_t.m4.diff
On 01/05/2015 09:06 AM, Daniel P. Berrange wrote:
Sync to latest gnulib to get files updated with 2015 copyright
date to fix syntax-check
* .gnulib: update to latest
* bootstrap: Regenerate from upstream
Signed-off-by: Daniel P. Berrange berra...@redhat.com
---
.gnulib | 2 +-
In the method networkGetDHCPLeases inside
./src/network/bridge_driver.c , we have:
if (need_results mac !leases_ret) {
virReportError(VIR_ERR_INTERNAL_ERROR,
_(no lease with matching MAC address: %s), mac);
goto error;
}
Is this really required?
On Mon, Jan 05, 2015 at 10:42:01PM +0530, Nehal J Wani wrote:
In the method networkGetDHCPLeases inside
./src/network/bridge_driver.c , we have:
if (need_results mac !leases_ret) {
virReportError(VIR_ERR_INTERNAL_ERROR,
_(no lease with matching MAC
On Tue, Dec 30, 2014 at 11:27:11AM +0100, Cédric Bosdonnat wrote:
Add a default implementation of virNetDevSetIPv4Address using netlink
and libnl. This avoids requiring /usr/sbin/ip or /usr/sbin/ifconfig
external binaries.
---
src/libvirt_private.syms | 1 +
src/util/virnetdev.c | 136
By querying the qemu guest agent with the QMP command
guest-network-get-interfaces and converting the received JSON
output to structured objects.
Although ifconfig is deprecated, IP aliases created by ifconfig
are supported by this API. The legacy syntax of an IP alias is:
ifname:alias-name.
On Tue, Dec 30, 2014 at 11:27:13AM +0100, Cédric Bosdonnat wrote:
---
src/util/virnetdev.c | 105
+++
1 file changed, 90 insertions(+), 15 deletions(-)
ACK
Regards,
Daniel
--
|: http://berrange.com -o-
On Tue, Dec 30, 2014 at 11:27:12AM +0100, Cédric Bosdonnat wrote:
Renamed virNetDevSetIPv4Address as it also handles IPv6 addresses.
---
src/libvirt_private.syms| 2 +-
src/network/bridge_driver.c | 4 ++--
src/util/virnetdev.c| 14 +++---
src/util/virnetdev.h|
On Mon, Jan 05, 2015 at 03:03:51PM +0100, Michal Privoznik wrote:
Well, the parallel build doesn't work as there are not dependencies
set correctly. When running 'make -j' I see this error:
make[2]: Entering directory '/home/zippy/work/libvirt/libvirt.git/src'
GEN util/virkeymaps.h
On Tue, Dec 30, 2014 at 11:27:14AM +0100, Cédric Bosdonnat wrote:
---
src/util/virnetdev.c | 60
+++-
1 file changed, 45 insertions(+), 15 deletions(-)
ACK
Regards,
Daniel
--
|: http://berrange.com -o-
On Tue, Dec 30, 2014 at 11:27:15AM +0100, Cédric Bosdonnat wrote:
Make clear that virNetDevClearIPv4Address can also handle IPv6
addresses by changing the name
---
src/libvirt_private.syms | 2 +-
src/util/virnetdev.c | 14 +++---
src/util/virnetdev.h | 6 +++---
3 files
On Tue, Dec 30, 2014 at 11:27:10AM +0100, Cédric Bosdonnat wrote:
---
src/conf/domain_conf.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
index aafc05e..914faf9 100644
--- a/src/conf/domain_conf.c
+++ b/src/conf/domain_conf.c
@@
On Tue, Dec 30, 2014 at 11:27:17AM +0100, Cédric Bosdonnat wrote:
---
docs/formatdomain.html.in | 11 ++-
1 file changed, 6 insertions(+), 5 deletions(-)
diff --git a/docs/formatdomain.html.in b/docs/formatdomain.html.in
index 9261f24..a17cd8b 100644
---
On Tue, Dec 30, 2014 at 11:27:16AM +0100, Cédric Bosdonnat wrote:
Add the possibility to have more than one IP address configured for a
domain network interface. IP addresses can also have a prefix to define
the corresponding netmask.
---
docs/formatdomain.html.in | 22
On Tue, Dec 30, 2014 at 11:27:19AM +0100, Cédric Bosdonnat wrote:
---
src/lxc/lxc_native.c| 144
+++-
tests/lxcconf2xmldata/lxcconf2xml-simple.config | 2 +
tests/lxcconf2xmldata/lxcconf2xml-simple.xml| 2 +
3 files changed, 97
On Tue, Dec 30, 2014 at 11:27:18AM +0100, Cédric Bosdonnat wrote:
Uses the new virDomainNetDef ips to set the IP addresses on the network
interfaces in the container.
---
src/lxc/lxc_container.c | 20 +++-
src/util/virsocketaddr.h | 2 ++
2 files changed, 21 insertions(+),
On Tue, Dec 30, 2014 at 11:27:21AM +0100, Cédric Bosdonnat wrote:
---
src/lxc/lxc_native.c | 3 +++
tests/lxcconf2xmldata/lxcconf2xml-physnetwork.config | 2 ++
tests/lxcconf2xmldata/lxcconf2xml-physnetwork.xml| 2 ++
3 files changed, 7 insertions(+)
ACK
On Tue, Dec 30, 2014 at 11:27:20AM +0100, Cédric Bosdonnat wrote:
---
docs/formatdomain.html.in| 8
docs/schemas/domaincommon.rng| 28
src/conf/domain_conf.c | 34 ++
On Tue, Dec 30, 2014 at 11:27:22AM +0100, Cédric Bosdonnat wrote:
Network interfaces devices and host devices with net capabilities can
now have IPv4 and/or an IPv6 routes configured.
---
docs/formatdomain.html.in| 19 -
docs/schemas/domaincommon.rng| 31
On Tue, Dec 30, 2014 at 11:27:23AM +0100, Cédric Bosdonnat wrote:
---
src/lxc/lxc_native.c | 57
+-
.../lxcconf2xmldata/lxcconf2xml-physnetwork.config | 2 +
tests/lxcconf2xmldata/lxcconf2xml-physnetwork.xml | 2 +
On Tue, Dec 30, 2014 at 11:27:26AM +0100, Cédric Bosdonnat wrote:
Vzctl man page says that --ipadd can be provided multiple times to add
several IP addresses. Looping over the configured ip addresses to add
one --ipadd for each. This would even handle the multiple IPs handled
by openvz_conf.c
On Tue, Dec 30, 2014 at 11:27:25AM +0100, Cédric Bosdonnat wrote:
Don't activate LXC network device if link state='down'/ has been set
in its configuration.
---
src/lxc/lxc_container.c | 46 --
1 file changed, 24 insertions(+), 22 deletions(-)
ACK
Michal Privoznik wrote:
Well, the parallel build doesn't work as there are not dependencies
set correctly. When running 'make -j' I see this error:
make[2]: Entering directory '/home/zippy/work/libvirt/libvirt.git/src'
GEN util/virkeymaps.h
GEN locking/lock_protocol.h
make[2]:
On 12/30/2014 03:27 AM, Cédric Bosdonnat wrote:
Add a default implementation of virNetDevSetIPv4Address using netlink
and libnl. This avoids requiring /usr/sbin/ip or /usr/sbin/ifconfig
external binaries.
---
src/libvirt_private.syms | 1 +
src/util/virnetdev.c | 136
Commit 4dc04d3a added virNetlinkGetErrorCode, but forgot to provide
a fallback, which kills the build on mingw (among others):
CCLD libvirt.la
Cannot export virNetlinkGetErrorCode: symbol not defined
collect2: error: ld returned 1 exit status
* src/util/virnetlink.c
On 01/05/2015 07:03 AM, Michal Privoznik wrote:
Well, the parallel build doesn't work as there are not dependencies
set correctly. When running 'make -j' I see this error:
make[2]: Entering directory '/home/zippy/work/libvirt/libvirt.git/src'
GEN util/virkeymaps.h
GEN
On 01/05/2015 02:09 AM, Luyao Huang wrote:
https://bugzilla.redhat.com/show_bug.cgi?id=1178652
We will get a warning when we have a guest in paused
status(casue by kernel panic) and restart libvirtd,
s/status(casue/status (caused/
warning message like this:
Qemu reported unknown VM
-Original Message-
From: libvir-list-boun...@redhat.com [mailto:libvir-list-boun...@redhat.com]
On
Behalf Of Chen Hanxiao
Sent: Monday, December 22, 2014 11:57 AM
To: libvir-list@redhat.com
Subject: [libvirt] [PATCH RFC] LXC: don't RO mount /proc, /sys when user
namespce
Another update is required to pick up today's gnulib fix for mingw
builds (now that gnulib turns on mingw's replacement printf that
understands %lld, it must also tell the compiler to respect the
improved definition of PRIdMAX and friends).
* .gnulib: Update to latest.
Signed-off-by: Eric Blake
On 01/05/2015 12:16 PM, John Ferlan wrote:
On 01/05/2015 12:49 PM, Nehal J Wani wrote:
Lack of a lease (whether mac is given or not) is a normal expected scenario.
There is no need to raise an error.
Signed-off-by: Nehal J Wani nehaljw.k...@gmail.com
---
src/network/bridge_driver.c | 6
On 01/05/2015 11:54 PM, Peter Krempa wrote:
On 01/03/15 06:06, Luyao Huang wrote:
We have enough patches for hotunplug RNG device, maybe we can
implement live hotunplug of a RNG device.
Signed-off-by: Luyao Huang lhu...@redhat.com
---
src/qemu/qemu_driver.c | 4 +-
On Tue, Dec 30, 2014 at 11:27:24AM +0100, Cédric Bosdonnat wrote:
Actually set routes in lxc containers if there are defined ones.
---
src/lxc/lxc_container.c | 26 ++
1 file changed, 26 insertions(+)
ACK
Regards,
Daniel
--
|: http://berrange.com -o-
Lack of a lease (whether mac is given or not) is a normal expected scenario.
There is no need to raise an error.
Signed-off-by: Nehal J Wani nehaljw.k...@gmail.com
---
src/network/bridge_driver.c | 6 --
1 file changed, 6 deletions(-)
diff --git a/src/network/bridge_driver.c
On Tue, Dec 30, 2014 at 11:27:27AM +0100, Cédric Bosdonnat wrote:
Drivers supporting one and only one IP address raise an error if more IP
addresses are configured.
---
src/vbox/vbox_common.c | 12 +---
src/xenconfig/xen_common.c | 12 ++--
src/xenconfig/xen_sxpr.c |
On 01/05/2015 12:49 PM, Nehal J Wani wrote:
Lack of a lease (whether mac is given or not) is a normal expected scenario.
There is no need to raise an error.
Signed-off-by: Nehal J Wani nehaljw.k...@gmail.com
---
src/network/bridge_driver.c | 6 --
1 file changed, 6 deletions(-)
Hi Jan,
Thanks for your review. Pushed.
--
Cedric
On Mon, 2015-01-05 at 10:37 +0100, Ján Tomko wrote:
On 12/30/2014 11:33 AM, Cédric Bosdonnat wrote:
Hi there,
Here are 2 patches fixing tiny annoying problems. One of them, makes
apparmor profiles handle /usr/lib64 folder and the other
Hi Daniel,
Thanks a lot for your reviews. I just pushed the patch series with the
IP Doc commit squashed.
--
Cedric
On Mon, 2015-01-05 at 17:26 +, Daniel P. Berrange wrote:
On Tue, Dec 30, 2014 at 11:27:10AM +0100, Cédric Bosdonnat wrote:
---
src/conf/domain_conf.c | 2 ++
1 file
Subject: change something? That's a really vague statement.
How about:
qemu: refactor qemuBuildRNGDeviceArgs to allow reuse in RNG hotplug
On 01/03/15 06:06, Luyao Huang wrote:
rename qemuBuildRNGDeviceArgs to qemuBuildRNGDevStr, we need this function
to build a cmdline.
Rename
On 12/30/2014 03:33 AM, Cédric Bosdonnat wrote:
s/,// in the subject
Also, we tend to avoid trailing '.' in commit summary lines, although
that is not strictly enforced
The apparmor profiles forgot about /usr/lib64 folders, just add lib64
as a possible alternative to lib in the paths
---
In subject:
audit: export virDomainAuditRNG
On 01/03/15 06:06, Luyao Huang wrote:
Signed-off-by: Luyao Huang lhu...@redhat.com
---
src/conf/domain_audit.c | 2 +-
src/conf/domain_audit.h | 7 +++
src/libvirt_private.syms | 1 +
3 files changed, 9 insertions(+), 1 deletion(-)
ACK,
Sync to latest gnulib to get files updated with 2015 copyright
date to fix syntax-check
* .gnulib: update to latest
* bootstrap: Regenerate from upstream
Signed-off-by: Daniel P. Berrange berra...@redhat.com
---
.gnulib | 2 +-
bootstrap | 2 +-
2 files changed, 2 insertions(+), 2
On 01/03/15 06:06, Luyao Huang wrote:
These 2 functions just do some basic check and then call
qemuMonitorJSONAttachRNGDev and qemuMonitorDelObject to
help us.
Signed-off-by: Luyao Huang lhu...@redhat.com
---
src/qemu/qemu_monitor.c | 43 +++
On 01/05/15 15:51, Peter Krempa wrote:
On 01/03/15 06:06, Luyao Huang wrote:
We didn't set a id when we build RNG device cmdline before.
Give a id to every RNG device and we can hotunplug it via
QMP cmd device_del.
Signed-off-by: Luyao Huang lhu...@redhat.com
---
src/qemu/qemu_command.c |
On 01/03/15 06:06, Luyao Huang wrote:
We have enough patches for hotunplug RNG device, maybe we can
implement live hotunplug of a RNG device.
Signed-off-by: Luyao Huang lhu...@redhat.com
---
src/qemu/qemu_driver.c | 4 +-
src/qemu/qemu_hotplug.c | 97
Subject: perhaps..
qemu: Add helper to assign RNG device aliases
On 01/03/15 06:06, Luyao Huang wrote:
This function used to set a alias name for RNG device, usage just
This function is used to assign an alias for a RNG device. It will be
later reused when hotplugging RNGs.
like other named
On 01/03/15 06:06, Luyao Huang wrote:
qemu side functions, call virDomainRNGInsert and virDomainRNGRemove
to help us.
Signed-off-by: Luyao Huang lhu...@redhat.com
---
src/qemu/qemu_hotplug.c | 23 +++
src/qemu/qemu_hotplug.h | 7 +++
2 files changed, 30
On 01/03/15 06:06, Luyao Huang wrote:
We need a new function to build a RNG device object, and need a
function to build a props which will be used in qemuMonitorJSONAddObject.
Signed-off-by: Luyao Huang lhu...@redhat.com
---
src/qemu/qemu_monitor_json.c | 58
On 01/03/15 06:06, Luyao Huang wrote:
We have enough patches for hotplug RNG device, maybe we can
implement live hotplug of a RNG device.
Signed-off-by: Luyao Huang lhu...@redhat.com
---
src/qemu/qemu_driver.c | 8 -
src/qemu/qemu_hotplug.c | 92
70 matches
Mail list logo
