On 01/15/2015 04:25 AM, Cédric Bosdonnat wrote:
---
docs/formatdomain.html.in | 9 +-
docs/schemas/domaincommon.rng | 29 +-
docs/schemas/network.rng | 2 +-
docs/schemas/networkcommon.rng| 2
On 01/15/2015 04:25 AM, Cédric Bosdonnat wrote:
If 0.0.0.0 address is provided, then the returned prefix should be 0,
rather than 8.
---
src/util/virsocketaddr.c | 6 ++
1 file changed, 6 insertions(+)
diff --git a/src/util/virsocketaddr.c b/src/util/virsocketaddr.c
index
On 01/15/2015 04:25 AM, Cédric Bosdonnat wrote:
From: John Ferlan jfer...@redhat.com
Commit id 'aa2cc721' added calls to virSocketAddrFormat but did not
check for a NULL (error) return which could lead to bad output
in the XML file. Need to check for NULL return and cause failure.
On 01/15/2015 04:25 AM, Cédric Bosdonnat wrote:
---
docs/schemas/basictypes.rng | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/docs/schemas/basictypes.rng b/docs/schemas/basictypes.rng
index 9ddd92b..efc9da4 100644
--- a/docs/schemas/basictypes.rng
+++
(Gene - I Cc'ed you because of one question I have for you down in the
bowels of the review. Just search for Gene and you'll get to it).
On 01/15/2015 04:25 AM, Cédric Bosdonnat wrote:
Moving code for parsing and formatting network routes to
networkcommon_conf helps reusing those routes for
On 01/15/2015 09:06 AM, Daniel P. Berrange wrote:
On Thu, Jan 15, 2015 at 08:52:44AM -0700, Eric Blake wrote:
On 01/15/2015 03:51 AM, Jiri Denemark wrote:
On Thu, Jan 15, 2015 at 10:42:39 +, Daniel Berrange wrote:
On Wed, Jan 14, 2015 at 08:08:16PM -0700, Eric Blake wrote:
In some cases,
On 01/15/2015 04:25 AM, Cédric Bosdonnat wrote:
From: John Ferlan jfer...@redhat.com
Commit id 'aa2cc721' added call to virSocketAddrFormat
and did not VIR_FREE() the returned memory.
Signed-off-by: John Ferlan jfer...@redhat.com
---
src/conf/domain_conf.c | 1 +
1 file changed, 1
The 'virsh edit' command gets XML validation enabled by default,
with a --skip-validate option to disable it. The 'virsh define'
and 'virsh create' commands get a --validate option to enable
it, to avoid regressions for existing scripts.
The quality of error reporting from libxml2 varies
On 01/15/2015 07:11 AM, Cedric Bosdonnat wrote:
On Thu, 2015-01-15 at 11:58 +0100, Michal Privoznik wrote:
On 15.01.2015 10:25, Cédric Bosdonnat wrote:
Moving network route to the network common schema will allow reusing it.
---
docs/schemas/network.rng | 20 +---
On Wed, Jan 14, 2015 at 07:48:26PM -0500, John Ferlan wrote:
On 01/14/2015 04:46 AM, Daniel P. Berrange wrote:
On Tue, Jan 13, 2015 at 04:12:32PM -0500, John Ferlan wrote:
https://bugzilla.redhat.com/show_bug.cgi?id=1138516
The disk backend uses 'parted' in order to create and delete
On 01/15/2015 03:51 AM, Jiri Denemark wrote:
On Thu, Jan 15, 2015 at 10:42:39 +, Daniel Berrange wrote:
On Wed, Jan 14, 2015 at 08:08:16PM -0700, Eric Blake wrote:
In some cases, it is very easy for downstream distros to backport
enum values without requiring a .so bump. Keying the
On Thu, Jan 15, 2015 at 08:52:44AM -0700, Eric Blake wrote:
On 01/15/2015 03:51 AM, Jiri Denemark wrote:
On Thu, Jan 15, 2015 at 10:42:39 +, Daniel Berrange wrote:
On Wed, Jan 14, 2015 at 08:08:16PM -0700, Eric Blake wrote:
In some cases, it is very easy for downstream distros to
The path to the pty of a Xen PV console is set only in
virDomainOpenConsole. But this is done too late. A call to
virDomainGetXMLDesc done before OpenConsole will not have the path to
the pty, but a call after OpenConsole will.
e.g. of the current issue.
Starting a domain with 'console type=pty/'
While the main storage driver code allows the flag
VIR_STORAGE_VOL_RESIZE_SHRINK to be set, none of the backend
drivers are supporting it. At the very least this can work
for plain file based volumes since we just ftruncate() them
to the new size. It does not work with qcow2 volumes, but we
can
On 01/15/2015 03:20 PM, Daniel P. Berrange wrote:
On Thu, Jan 15, 2015 at 03:12:01PM +0100, Ján Tomko wrote:
Return 0 instead of ERR_NO_SUPPORT to avoid spamming daemon logs
when 'virsh dominfo' is run.
https://bugzilla.redhat.com/show_bug.cgi?id=1095637
---
src/lxc/lxc_driver.c | 24
https://bugzilla.redhat.com/show_bug.cgi?id=1182486
When updating a network and adding new ip-dhcp-host entry, the deamon
may crash. The problem is, we iterate over existing host/ entries
trying to compare MAC addresses to see if there's already an existing
rule. However, not all entries are
On 01/15/2015 09:48 AM, Michal Privoznik wrote:
https://bugzilla.redhat.com/show_bug.cgi?id=1182486
When updating a network and adding new ip-dhcp-host entry, the deamon
may crash. The problem is, we iterate over existing host/ entries
trying to compare MAC addresses to see if there's already
From: Gary R Hook grhookatw...@gmail.com
Do not run ZFS tests when ZFS is unsupported in the environment.
The recent patch b4af40226d09adeaf9e33a1d6594c4e8ce7f771d adds tests
to storagepoolxml2xmltest for the optional ZFS feature. When ZFS is
not included in the configuration these tests should
On 01/15/2015 10:43 AM, Daniel P. Berrange wrote:
I looked through some history and didn't see anywhere that supplied name
must match partition name was enforced, but there's a lot of code motion
and new features that may cloud the history. Perhaps it's the assumption
true in so many other
On 01/15/2015 03:32 PM, Gary R Hook wrote:
From: Gary R Hook grhookatw...@gmail.com
Do not run ZFS tests when ZFS is unsupported in the environment.
The recent patch b4af40226d09adeaf9e33a1d6594c4e8ce7f771d adds tests
to storagepoolxml2xmltest for the optional ZFS feature. When ZFS is
not
On 01/15/2015 03:53 PM, Gary R Hook wrote:
+storagepoolxml2xmltest_CFLAGS = $(AM_CFLAGS)
+if WITH_STORAGE_ZFS
+storagepoolxml2xmltest_CFLAGS += -DWITH_STORAGE_ZFS
+endif
This shouldn't be needed. Our config.h should already be defining all
the appropriate WITH_* feature macros. If it is
On 1/15/15 4:37 PM, Eric Blake wrote:
On 01/15/2015 03:32 PM, Gary R Hook wrote:
From: Gary R Hook grhookatw...@gmail.com
Do not run ZFS tests when ZFS is unsupported in the environment.
The recent patch b4af40226d09adeaf9e33a1d6594c4e8ce7f771d adds tests
to storagepoolxml2xmltest for the
On Wed, Jan 14, 2015 at 10:34 PM, Michal Privoznik mpriv...@redhat.com wrote:
On 14.01.2015 12:01, Shivaprasad G Bhat wrote:
If a device in the same iommu group is in use by a different vm, the guest
boot
fails with the
https://bugzilla.redhat.com/show_bug.cgi?id=1182467
We changed our build numa qemu cmd line way in f309db,
But qemu cannot accept one cell use memdev and another not,
so this cause a issue when we start a vm with one cell
have hugpage or nodemask settings and others not.
After this patch we will
From: John Ferlan jfer...@redhat.com
Commit id 'aa2cc721' added calls to virSocketAddrFormat but did not
check for a NULL (error) return which could lead to bad output
in the XML file. Need to check for NULL return and cause failure.
Signed-off-by: John Ferlan jfer...@redhat.com
---
Hi guys,
Here are a few patches to have common route definitions for domains and
networks.
What has changed since v1:
* Split into several patches for backportability as suggested by Laine
* Moved the virNetworkRouteDef struct definition in the c file to make sure
all
routes are created
Moving network route to the network common schema will allow reusing it.
---
docs/schemas/network.rng | 20 +---
docs/schemas/networkcommon.rng | 22 ++
2 files changed, 23 insertions(+), 19 deletions(-)
diff --git a/docs/schemas/network.rng
On 15.01.2015 10:25, Cédric Bosdonnat wrote:
Moving code for parsing and formatting network routes to
networkcommon_conf helps reusing those routes for domains. The route
definition has been hidden to help reducing the number of unnecessary
checks in the format function.
---
po/POTFILES.in
On 15.01.2015 10:25, Cédric Bosdonnat wrote:
Hi guys,
Here are a few patches to have common route definitions for domains and
networks.
What has changed since v1:
* Split into several patches for backportability as suggested by Laine
* Moved the virNetworkRouteDef struct definition in
On Tue, Jan 13, 2015 at 17:00:16 +, Daniel Berrange wrote:
The 'virsh edit' command gets XML validation enabled by default,
with a --skip-validate option to disable it. The 'virsh define'
and 'virsh create' commands get a --validate option to enable
it, to avoid regressions for existing
On 15.01.2015 10:25, Cédric Bosdonnat wrote:
Moving network route to the network common schema will allow reusing it.
---
docs/schemas/network.rng | 20 +---
docs/schemas/networkcommon.rng | 22 ++
2 files changed, 23 insertions(+), 19 deletions(-)
On Tue, Jan 13, 2015 at 10:15:52 +0800, Luyao Huang wrote:
https://bugzilla.redhat.com/show_bug.cgi?id=1181182
When we meet error in qemuMigrationPrepareAny and goto
cleanup with rc 0, we forget clear the priv-origname and this
will make this vm migrate fail next time because leave a wrong
On Thu, Jan 15, 2015 at 11:14:37AM +0100, Jiri Denemark wrote:
On Tue, Jan 13, 2015 at 17:00:16 +, Daniel Berrange wrote:
The 'virsh edit' command gets XML validation enabled by default,
with a --skip-validate option to disable it. The 'virsh define'
and 'virsh create' commands get a
On Wed, Jan 14, 2015 at 08:08:16PM -0700, Eric Blake wrote:
In some cases, it is very easy for downstream distros to backport
enum values without requiring a .so bump. Keying the conditional
code off of the upstream version where the enum value was added
is not ideal, because downstream then
On Thu, Jan 15, 2015 at 10:42:39 +, Daniel Berrange wrote:
On Wed, Jan 14, 2015 at 08:08:16PM -0700, Eric Blake wrote:
In some cases, it is very easy for downstream distros to backport
enum values without requiring a .so bump. Keying the conditional
code off of the upstream version
From: John Ferlan jfer...@redhat.com
Commit id 'aa2cc721' added call to virSocketAddrFormat
and did not VIR_FREE() the returned memory.
Signed-off-by: John Ferlan jfer...@redhat.com
---
src/conf/domain_conf.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/conf/domain_conf.c
Moving code for parsing and formatting network routes to
networkcommon_conf helps reusing those routes for domains. The route
definition has been hidden to help reducing the number of unnecessary
checks in the format function.
---
po/POTFILES.in| 1 +
src/Makefile.am
---
docs/formatdomain.html.in | 9 +-
docs/schemas/domaincommon.rng | 29 +-
docs/schemas/network.rng | 2 +-
docs/schemas/networkcommon.rng| 2 +-
src/conf/domain_conf.c
If 0.0.0.0 address is provided, then the returned prefix should be 0,
rather than 8.
---
src/util/virsocketaddr.c | 6 ++
1 file changed, 6 insertions(+)
diff --git a/src/util/virsocketaddr.c b/src/util/virsocketaddr.c
index c5584af..e7870bf 100644
--- a/src/util/virsocketaddr.c
+++
---
docs/schemas/basictypes.rng | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/docs/schemas/basictypes.rng b/docs/schemas/basictypes.rng
index 9ddd92b..efc9da4 100644
--- a/docs/schemas/basictypes.rng
+++ b/docs/schemas/basictypes.rng
@@ -174,7 +174,7 @@
define
On Tue, Jan 13, 2015 at 17:00:15 +, Daniel Berrange wrote:
The virDomainDefineXMLFlags and virDomainCreateXML APIs both
gain new flags allowing them to be told to validate XML.
This updates all the drivers to turn on validation in the
XML parser when the flags are set
...
diff --git
On 01/14/2015 12:14 AM, John Ferlan wrote:
On 12/06/2014 11:32 AM, Shanzhi Yu wrote:
When create inactive external snapshot, after update disk definitions,
virDomainSaveConfig is needed, if not after restart libvirtd the new snapshot
file definitions in xml will be lost.
Reproduce steps:
1.
On Tue, Jan 13, 2015 at 17:00:14 +, Daniel Berrange wrote:
Add a helper method that can validate an XML document against
an RNG schema
---
include/libvirt/virterror.h | 1 +
src/internal.h | 4 +++
src/libvirt_private.syms| 1 +
src/util/virerror.c | 6
Ján Tomko (2):
Add an XML test for host-model CPU with features
Simplify condition for formatting CPU features
src/conf/cpu_conf.c| 42 +++---
.../qemuxml2argv-cpu-host-model-features.xml | 33 +
tests/qemuxml2xmltest.c
Commit adff345 added support for features to MODE_HOSTPASSTHROUGH
as well. Since we support all modes now, the condition can be
eliminated.
---
src/conf/cpu_conf.c | 42 --
1 file changed, 20 insertions(+), 22 deletions(-)
Mostly whitespace changes.
diff
On Thu, 2015-01-15 at 11:58 +0100, Michal Privoznik wrote:
On 15.01.2015 10:25, Cédric Bosdonnat wrote:
Moving network route to the network common schema will allow reusing it.
---
docs/schemas/network.rng | 20 +---
docs/schemas/networkcommon.rng | 22
On Thu, 2015-01-15 at 11:58 +0100, Michal Privoznik wrote:
On 15.01.2015 10:25, Cédric Bosdonnat wrote:
Moving code for parsing and formatting network routes to
networkcommon_conf helps reusing those routes for domains. The route
definition has been hidden to help reducing the number of
In case we find out, there are more PCI devices to be connected
than there are available slots on the default PCI bus, we automatically add a
new bus and a related PCI bridge controller as well. As there are no free slots
left on the default PCI bus, PCI bridge controller gets a free slot on a
We tested for positive return value from virDomainMaybeAddController,
but it returns 0 or -1 only resulting in a dead code.
---
src/qemu/qemu_command.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c
index 06def5f..1671e11
Erik Skultety (3):
qemu: Tweak auto adding PCI bridge controller when extending default
PCI bus
qemu: qemuDomainAssignPCIAddresses fix dead code
qemu: Add XML test for too many PCI devices on default PCI bus
src/qemu/qemu_command.c | 26 ++-
On 15.01.2015 13:11, Cedric Bosdonnat wrote:
On Thu, 2015-01-15 at 11:58 +0100, Michal Privoznik wrote:
On 15.01.2015 10:25, Cédric Bosdonnat wrote:
Moving network route to the network common schema will allow reusing it.
---
docs/schemas/network.rng | 20 +---
This was broken in a dowstream build due to a missing backport:
https://bugzilla.redhat.com/show_bug.cgi?id=1182448
---
.../qemuxml2argv-cpu-host-model-features.xml | 33 ++
tests/qemuxml2xmltest.c| 1 +
2 files changed, 34 insertions(+)
---
tests/qemuxml2argvdata/qemuxml2argv-pci-many.args | 63 +++
tests/qemuxml2argvdata/qemuxml2argv-pci-many.xml | 214 ++
tests/qemuxml2argvtest.c | 2 +
3 files changed, 279 insertions(+)
create mode 100644
Hello everyone,
we are very interested about the post-copy live migration mechanism in
libvirt [1] using QEMU. Mentioning post-copy in this context means the
setup with the first full iteration of standard pre-copy and then
switching to the post-copy. VIR_MIGRATE_ENABLE_POSTCOPY,
On Thu, Jan 15, 2015 at 02:45:13PM +0100, Vojtech Cima wrote:
Hello everyone,
we are very interested about the post-copy live migration mechanism in
libvirt [1] using QEMU. Mentioning post-copy in this context means the setup
with the first full iteration of standard pre-copy and then
Return 0 instead of ERR_NO_SUPPORT to avoid spamming daemon logs
when 'virsh dominfo' is run.
https://bugzilla.redhat.com/show_bug.cgi?id=1095637
---
src/lxc/lxc_driver.c | 24
1 file changed, 24 insertions(+)
diff --git a/src/lxc/lxc_driver.c b/src/lxc/lxc_driver.c
On Thu, Jan 15, 2015 at 03:12:01PM +0100, Ján Tomko wrote:
Return 0 instead of ERR_NO_SUPPORT to avoid spamming daemon logs
when 'virsh dominfo' is run.
https://bugzilla.redhat.com/show_bug.cgi?id=1095637
---
src/lxc/lxc_driver.c | 24
1 file changed, 24
-Original Message-
From: libvir-list-boun...@redhat.com [mailto:libvir-list-boun...@redhat.com]
On
Behalf Of Chen Hanxiao
Sent: Tuesday, January 13, 2015 4:18 PM
To: libvir-list@redhat.com
Subject: [libvirt] [PATCH 0/2] try to use btrfs COW copy
If
58 matches
Mail list logo
