[libvirt] [PATCH] Fix virCgroupNewMachine prototype on non-Linux

2015-01-20 Thread Ján Tomko
Commit 318df5a changed the prototype of virCgroupNewMachine without adjusting the stub function for platforms without cgroups. --- Pushed as a trivial build fix. src/util/vircgroup.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/util/vircgroup.c b/src/util/vircgroup.c index

Re: [libvirt] [PATCH 2/3] Grant access to helpers

2015-01-20 Thread Cedric Bosdonnat
On Mon, 2015-01-19 at 18:25 -0700, Mike Latimer wrote: Apparmor must not prevent access to required helper programs. The following helpers should be allowed to run in unconfined execution mode: - libvirt_parthelper - libvirt_iohelper --- examples/apparmor/usr.sbin.libvirtd | 2 ++ 1

Re: [libvirt] [PATCH 3/3] Fix apparmor issues for tck

2015-01-20 Thread Cedric Bosdonnat
On Mon, 2015-01-19 at 18:25 -0700, Mike Latimer wrote: The network and nwfilter tests contained in the libvirt-TCK testkit can fail unless access to raw network packets is granted. Without this access, the following apparmor error can be seen while running the tests: apparmor=DENIED

Re: [libvirt] [PATCH 1/3] Fix apparmor issues for Xen

2015-01-20 Thread Cedric Bosdonnat
On Mon, 2015-01-19 at 18:25 -0700, Mike Latimer wrote: In order for apparmor to work properly in Xen environments, the following access rights need to be allowed: - Allow CAP_SYS_PACCT, which is required when resetting some multi-port Broadcom cards by writting to the PCI config space

[libvirt] [PATCH] qemu: fix cannot set graphic passwd via qemuDomainSaveImageDefineXML

2015-01-20 Thread Luyao Huang
https://bugzilla.redhat.com/show_bug.cgi?id=1183890 When we try to update a xml to a image file, we will clear the graphics passwd settings, because we do not pass VIR_DOMAIN_XML_SECURE to qemuDomainDefCopy, qemuDomainDefFormatBuf won't format the passwd. Add VIR_DOMAIN_XML_SECURE flag when we

Re: [libvirt] [PATCH] qemu: Propagate storage errors on migration

2015-01-20 Thread Michal Privoznik
On 19.01.2015 22:58, John Ferlan wrote: On 01/09/2015 07:22 AM, Michal Privoznik wrote: There's one bug that got more visible with my patches that automatically precreate storage on migration. The problem is, if there's not enough disk space on destination, we successfully finish the

[libvirt] [PATCH] qemu: format server interface without a listen address

2015-01-20 Thread Ján Tomko
https://bugzilla.redhat.com/show_bug.cgi?id=1130390 The listen address is not mandatory for interface type='server' but when it's not specified, we've been formatting it as: -netdev socket,listen=(null):5558,id=hostnet0 which failed with: Device 'socket' could not be initialized Omit the address

Re: [libvirt] [PATCH 3/3] qemu: Add support for setting vCPU and I/O thread scheduler setting

2015-01-20 Thread Martin Kletzander
On Mon, Jan 19, 2015 at 10:33:52PM -0500, John Ferlan wrote: On 01/13/2015 02:57 AM, Martin Kletzander wrote: Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1178986 Could use a bit more details here. Signed-off-by: Martin Kletzander mklet...@redhat.com --- src/qemu/qemu_driver.c

Re: [libvirt] [PATCH 2/3] docs, schema, conf: Add support for setting scheduler parameters of guest threads

2015-01-20 Thread Martin Kletzander
On Mon, Jan 19, 2015 at 10:23:22PM -0500, John Ferlan wrote: On 01/13/2015 02:57 AM, Martin Kletzander wrote: In order for QEMU vCPU (and other) threads to run with RT scheduler, libvirt needs to take care of that so QEMU doesn't have to run privileged. Resolves:

[libvirt] [PATCH 5/8] Remove use of interfacePrivateData from udev driver

2015-01-20 Thread Daniel P. Berrange
The udev driver can be implemented using global state instead of the connect private data. --- src/interface/interface_backend_udev.c | 103 +++-- 1 file changed, 58 insertions(+), 45 deletions(-) diff --git a/src/interface/interface_backend_udev.c

[libvirt] [PATCH 0/8] Refactoring driver registration

2015-01-20 Thread Daniel P. Berrange
This series continues on my previous work to refactor the driver registration process. With this patch series applied, there is no probing of secondary drivers any more. Once the hypervisor driver is chosen, the correct secondary drivers are immediately known. This enables a bunch of hacks to be

[libvirt] [PATCH 4/8] Remove use of nodeDevicePrivateData from nodeDev driver

2015-01-20 Thread Daniel P. Berrange
The node device driver can rely on its global state instead of the connect private data. --- src/node_device/node_device_driver.c | 68 + src/node_device/node_device_driver.h | 6 ++- src/node_device/node_device_hal.c| 84

[libvirt] [PATCH 7/8] don't disable state driver when libvirtd is not built

2015-01-20 Thread Daniel P. Berrange
A bunch of code is wrapped in #if WITH_LIBVIRTD in order to enable the virStateDriver to be disabled when libvirtd is not built. Disabling this code doesn't have any real functional benefit beyond removing 1 pointer from the virConnectPtr struct, while having a cost of many more conditionals.

[libvirt] [PATCH 6/8] Remove all secondary driver private data fields

2015-01-20 Thread Daniel P. Berrange
Now all drivers are converted to use their global state directly, there is no need for private data fields for the secondary drivers in virConnectPtr --- src/datatypes.h | 6 -- 1 file changed, 6 deletions(-) diff --git a/src/datatypes.h b/src/datatypes.h index d202597..4973b07 100644 ---

[libvirt] [PATCH 1/8] Remove use of secretPrivateData from secret driver

2015-01-20 Thread Daniel P. Berrange
The secret driver can rely on its global state instead of the connect private data. --- src/secret/secret_driver.c | 198 - 1 file changed, 89 insertions(+), 109 deletions(-) diff --git a/src/secret/secret_driver.c b/src/secret/secret_driver.c index

[libvirt] [PATCH 8/8] Removing probing of secondary drivers

2015-01-20 Thread Daniel P. Berrange
For stateless, client side drivers, it is never correct to probe for secondary drivers. It is only ever appropriate to use the secondary driver that is associated with the hypervisor in question. As a result the ESX HyperV drivers have both been forced to do hacks where they register no-op

[libvirt] [PATCH 2/8] Remove use of nwfilterPrivateData from nwfilter driver

2015-01-20 Thread Daniel P. Berrange
The nwfilter driver can rely on its global state instead of the connect private data. --- src/conf/domain_nwfilter.c | 5 +- src/conf/domain_nwfilter.h | 6 +-- src/lxc/lxc_driver.c | 3 +- src/lxc/lxc_process.c | 8 ++- src/lxc/lxc_process.h | 3 +-

[libvirt] [PATCH 3/8] Remove use of storagePrivateData/networkPrivateData from vbox

2015-01-20 Thread Daniel P. Berrange
The vbox driver can use the main hypervisor private data and so does not need to use the storage/network private data fields. --- src/vbox/vbox_network.c | 6 +++--- src/vbox/vbox_storage.c | 6 +++--- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/src/vbox/vbox_network.c

Re: [libvirt] [PATCH v3] qemu: Allow UEFI paths to be specified at compile time

2015-01-20 Thread Martin Kletzander
On Wed, Jan 14, 2015 at 04:28:33PM +0100, Michal Privoznik wrote: Up until now there are just two ways how to specify UEFI paths to libvirt. The first one is editing qemu.conf, the other is editing qemu_conf.c and recompile which is not that fancy. So, new configure option is introduced:

Re: [libvirt] [PATCH 2/2] qemu: add a check when cold-plug a Chr device

2015-01-20 Thread John Ferlan
On 12/09/2014 01:48 AM, Luyao Huang wrote: Add a func just check the base target type which qemu support. But i still doubt this will be useful , we already have a check when we try to start the vm. And this check only check the target type, and the other things will be done in

Re: [libvirt] Question about migration max downtime in domXML

2015-01-20 Thread Jim Fehlig
Daniel P. Berrange wrote: On Tue, Jan 20, 2015 at 11:00:26AM -0700, Jim Fehlig wrote: Hi All, I've had a few user requests to add migration max downtime to the domain XML. IIRC, this was discussed on the list quite some time ago, but I'm unable to find it in the archives. My

Re: [libvirt] [PATCHv2 1/2] qemu: output error when try to hotplug unsupport console

2015-01-20 Thread John Ferlan
Looks like this one may have been lost in the holidays... On 12/09/2014 01:48 AM, Luyao Huang wrote: https://bugzilla.redhat.com/show_bug.cgi?id=1164627 When try to use attach-device to hotplug a qemu unsupport sonsole, command will return success, and add a console in vm's xml.But this

Re: [libvirt] Question about migration max downtime in domXML

2015-01-20 Thread Daniel P. Berrange
On Tue, Jan 20, 2015 at 11:00:26AM -0700, Jim Fehlig wrote: Hi All, I've had a few user requests to add migration max downtime to the domain XML. IIRC, this was discussed on the list quite some time ago, but I'm unable to find it in the archives. My recollection is that max downtime is

[libvirt] Question about migration max downtime in domXML

2015-01-20 Thread Jim Fehlig
Hi All, I've had a few user requests to add migration max downtime to the domain XML. IIRC, this was discussed on the list quite some time ago, but I'm unable to find it in the archives. My recollection is that max downtime is considered a tunable vs config and as such not included in the

Re: [libvirt] [PATCHv2 1/2] qemu: output error when try to hotplug unsupport console

2015-01-20 Thread lhuang
On 01/21/2015 02:59 AM, John Ferlan wrote: Looks like this one may have been lost in the holidays... Aha, thanks a lot for 'save' this patch, I almost forget this patch ;) On 12/09/2014 01:48 AM, Luyao Huang wrote: https://bugzilla.redhat.com/show_bug.cgi?id=1164627 When try to use

Re: [libvirt] [PATCH] tests: fix xlconfigtest build failure

2015-01-20 Thread Eric Blake
On 01/20/2015 09:09 PM, Jim Fehlig wrote: When libvirt is configured --without-xen, building the xlconfigtest fails with CCLD xlconfigtest /usr/lib/gcc/x86_64-linux-gnu/4.7/../../../x86_64-linux-gnu/crt1.o In function `_start': (.text+0x20): undefined reference to `main'

[libvirt] [PATCH] tests: fix xlconfigtest build failure

2015-01-20 Thread Jim Fehlig
When libvirt is configured --without-xen, building the xlconfigtest fails with CCLD xlconfigtest /usr/lib/gcc/x86_64-linux-gnu/4.7/../../../x86_64-linux-gnu/crt1.o In function `_start': (.text+0x20): undefined reference to `main' collect2: error: ld returned 1 exit status Introduced in

Re: [libvirt] [PATCH 2/2] qemu: add a check when cold-plug a Chr device

2015-01-20 Thread lhuang
On 01/21/2015 03:00 AM, John Ferlan wrote: On 12/09/2014 01:48 AM, Luyao Huang wrote: Add a func just check the base target type which qemu support. But i still doubt this will be useful , we already have a check when we try to start the vm. And this check only check the target type, and the

Re: [libvirt] [Xen-devel] [libvirt bisection] complete build-armhf-libvirt

2015-01-20 Thread Jim Fehlig
Ian Campbell wrote: On Mon, 2015-01-19 at 09:37 +, Ian Campbell wrote: On Mon, 2015-01-19 at 04:48 +, xen.org wrote: branch xen-unstable xen branch xen-unstable job build-armhf-libvirt test libvirt-build Tree: libvirt git://libvirt.org/libvirt.git Tree: qemuu

Re: [libvirt] [PATCH] qemu: format server interface without a listen address

2015-01-20 Thread Peter Krempa
On Tue, Jan 20, 2015 at 13:50:22 +0100, Ján Tomko wrote: https://bugzilla.redhat.com/show_bug.cgi?id=1130390 The listen address is not mandatory for interface type='server' but when it's not specified, we've been formatting it as: -netdev socket,listen=(null):5558,id=hostnet0 which failed

Re: [libvirt] [PATCH 1/2] Introduce btrfsCloneFile for btrfs COW copy

2015-01-20 Thread Chen, Hanxiao
-Original Message- From: libvir-list-boun...@redhat.com [mailto:libvir-list-boun...@redhat.com] On Behalf Of Chen, Hanxiao Sent: Monday, January 19, 2015 2:26 PM To: Ján Tomko; libvir-list@redhat.com Subject: Re: [libvirt] [PATCH 1/2] Introduce btrfsCloneFile for btrfs COW copy

Re: [libvirt] [PATCH] tests: fix xlconfigtest build failure

2015-01-20 Thread Jim Fehlig
Eric Blake wrote: On 01/20/2015 09:09 PM, Jim Fehlig wrote: When libvirt is configured --without-xen, building the xlconfigtest fails with CCLD xlconfigtest /usr/lib/gcc/x86_64-linux-gnu/4.7/../../../x86_64-linux-gnu/crt1.o In function `_start': (.text+0x20): undefined reference

Re: [libvirt] [PATCH 3/3] qemu: Add support for setting vCPU and I/O thread scheduler setting

2015-01-20 Thread John Ferlan
On 01/20/2015 09:48 AM, Martin Kletzander wrote: ...snip... Do you plan to add a new command 'vcpusched' (like vcpupin). It's something that's desired for IOThreads, so perhaps one of us gets to reuse code :-) I'm not sure anyone will use that, but it there is demand, then I have no