[libvirt] Submit your Google Summer of Code project ideas and volunteer to mentor

2015-01-23 Thread Stefan Hajnoczi
Dear libvirt, KVM, and QEMU contributors, The Google Summer of Code season begins soon and it's time to collect our thoughts for mentoring students this summer working full-time on libvirt, KVM, and QEMU. What is GSoC? Google Summer of Code 2015 (GSoC) funds students to work on open source

Re: [libvirt] Assert with libvirt + xen hvm

2015-01-23 Thread CloudPatch Staff
After some debugging we found what was causing of the assert. In our configuration we have two kernels to boot, one is a pv-linux for Xen dom0 and another just a normal linux kernel. We have libvirt built with both Xen and vbox support. When running with Xen, the libxl driver is used so it ends

Re: [libvirt] [PATCH v2 3/4] qemu: Fix auto-adding PCI bridge when all slots are reserved

2015-01-23 Thread Ján Tomko
On 01/23/2015 01:17 PM, Erik Skultety wrote: Commit 93c8ca tried to fix the issue with auto-adding of a PCI bridge controller, but didn't work properly in all scenarios. This patch provides a better fix of the issue when all slots on a PCI bus are reserved by devices with user specified

Re: [libvirt] [PATCH v2 4/4] qemu: Add check for PCI bridge placement if there are too many PCI devices

2015-01-23 Thread Ján Tomko
On 01/23/2015 01:17 PM, Erik Skultety wrote: Previous patch of this series fixed the issue with adding a new PCI bridge when all the slots were reserved by devices with user specified addresses. In case there are still some PCI devices waiting to get a slot reserved by

Re: [libvirt] [PATCH v2 2/4] qemu: move PCI slot assignment for PIIX3, Q35 into a separate function

2015-01-23 Thread Ján Tomko
On 01/23/2015 01:17 PM, Erik Skultety wrote: In order to be able to test for fully reserved PCI buses, assignment of PCI slots for integrated devices needs to be moved to a separate function. This also might be a good preparation if we decide to add support for other chipsets as well. ---

Re: [libvirt] [PATCH v2 1/4] qemu: reorder PCI slot assignment functions

2015-01-23 Thread Ján Tomko
On 01/23/2015 01:17 PM, Erik Skultety wrote: In previous commit a chunk of code got moved in to a separate static function qemuValidateDevicePCISlotsChipsets. This function then invokes chipset specific functions which are defined as static as well. For these reasons it is necessary to either

Re: [libvirt] [PATCH v2 1/4] qemu: reorder PCI slot assignment functions

2015-01-23 Thread Ján Tomko
On 01/23/2015 01:17 PM, Erik Skultety wrote: In previous commit a chunk of code got moved in to a separate static function qemuValidateDevicePCISlotsChipsets. This function then invokes chipset specific functions which are defined as static as well. For these reasons it is necessary to either

Re: [libvirt] [PATCH v2 4/4] qemu: Add check for PCI bridge placement if there are too many PCI devices

2015-01-23 Thread Erik Skultety
On 01/23/2015 02:38 PM, Ján Tomko wrote: diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c index a3dedbf..870771f 100644 --- a/src/qemu/qemu_command.c +++ b/src/qemu/qemu_command.c @@ -1982,6 +1982,25 @@ qemuDomainAssignPCIAddresses(virDomainDefPtr def, if

Re: [libvirt] Assert with libvirt + xen hvm

2015-01-23 Thread Michal Privoznik
On 22.01.2015 17:49, CloudPatch Staff wrote: We're hitting an assert whenever we try to create an HVM instance under Xen via libvirtd. System is running on Gentoo, package information as follows: app-emulation/xen-4.5.0 USE=api debug flask hvm pam pygrub python qemu screen

Re: [libvirt] [PATCH v3 1/2] systemd: fix build without dbus

2015-01-23 Thread Michal Privoznik
On 22.01.2015 17:51, Daniel P. Berrange wrote: The virDBusMethodCall method has a DBusError as one of its parameters. If the caller wants to pass a non-NULL value for this, it immediately makes the calling code require DBus at build time. This has led to breakage of non-DBus builds several

[libvirt] Availability of Candidate Release 20 of libvirt-1.2.12

2015-01-23 Thread Daniel Veillard
The cr2 is tagged in git and available as signed tarballs and rpms from the usual place: ftp://livirt.org/libvirt/ This seems to work fine with my limited testing, but please give it a try ! Assuming no last minute issues the final release will be pushed early Tuesday, Please check

[libvirt] libvirt domXML - libxl_domain_config conversion testing

2015-01-23 Thread Jim Fehlig
Hi All, I've been attempting to revive the libvirt domXML - libxl_domain_config tests originally started by Daniel all the way back in May! https://www.redhat.com/archives/libvir-list/2014-May/msg01102.html In a reply to patch5 of the series, Ian Campbell noted that the doc produced by

Re: [libvirt] [PATCH 3/5] qemu: Fix auto-adding PCI bridge when all slots are reserved

2015-01-23 Thread Erik Skultety
On 01/22/2015 05:00 PM, Ján Tomko wrote: On 01/21/2015 05:50 PM, Erik Skultety wrote: Commit 93c8ca tried to fix the issue with auto-adding of a PCI bridge controller, it worked well when the slots were reserved by devices with user defined addresses without any other devices with

[libvirt] [PATCH v2 1/4] qemu: reorder PCI slot assignment functions

2015-01-23 Thread Erik Skultety
In previous commit a chunk of code got moved in to a separate static function qemuValidateDevicePCISlotsChipsets. This function then invokes chipset specific functions which are defined as static as well. For these reasons it is necessary to either have a forward declaration or slightly reorder

[libvirt] [PATCH v2 3/4] qemu: Fix auto-adding PCI bridge when all slots are reserved

2015-01-23 Thread Erik Skultety
Commit 93c8ca tried to fix the issue with auto-adding of a PCI bridge controller, but didn't work properly in all scenarios. This patch provides a better fix of the issue when all slots on a PCI bus are reserved by devices with user specified addresses and no additional bridges need to be

[libvirt] [PATCH v2 4/4] qemu: Add check for PCI bridge placement if there are too many PCI devices

2015-01-23 Thread Erik Skultety
Previous patch of this series fixed the issue with adding a new PCI bridge when all the slots were reserved by devices with user specified addresses. In case there are still some PCI devices waiting to get a slot reserved by qemuAssignDevicePCISlots, this means a new bus needs to be created along

[libvirt] [PATCH v2 0/4] qemu: fix PCI bridge auto-add to extend default bus

2015-01-23 Thread Erik Skultety
Erik Skultety (4): qemu: reorder PCI slot assignment functions qemu: move PCI slot assignment for PIIX3, Q35 into a separate function qemu: Fix auto-adding PCI bridge when all slots are reserved qemu: Add check for PCI bridge placement if there are too many PCI devices

[libvirt] [PATCH v2 2/4] qemu: move PCI slot assignment for PIIX3, Q35 into a separate function

2015-01-23 Thread Erik Skultety
In order to be able to test for fully reserved PCI buses, assignment of PCI slots for integrated devices needs to be moved to a separate function. This also might be a good preparation if we decide to add support for other chipsets as well. --- src/qemu/qemu_command.c | 47

Re: [libvirt] [PATCH 4/5] qemu: move PCI slot assignment for PIIX3, Q35 into a separate function

2015-01-23 Thread Erik Skultety
On 01/22/2015 05:00 PM, Ján Tomko wrote: On 01/21/2015 05:50 PM, Erik Skultety wrote: In order to be able to test for fully reserved PCI buses, assignment of PCI slots for integrated devices needs to be moved to a separate function. This also might be a good preparation if we decide to add

[libvirt] [PATCH] Fix build with older gcc

2015-01-23 Thread Ján Tomko
My commit af1c98e4 broke the build on RHEL-6: vircgrouptest.c: In function 'testCgroupGetPercpuStats': vircgrouptest.c:566: error: nested extern declaration of '_gl_verify_function2' [-Wnested-externs] The only thing that needs checking is that the array size is at least EXPECTED_NCPUS, to

Re: [libvirt] Tunnelled post-copy live migration - support of bidirectional communication over the tunnel

2015-01-23 Thread Vojtech Cima
Hello, thank you for the clarification. However, right now I still cannot see any traffic going back from the stream (stream doesn't become readable on the source side). I still struggle with the overall tunnelling design - especially on the destination side. I suppose following scheme where

Re: [libvirt] [PATCH 2/5] conf: virDomainDefMaybeAddController tweak return code

2015-01-23 Thread Ján Tomko
On 01/21/2015 05:49 PM, Erik Skultety wrote: Previously the function returned either -1 in case of an error or 0 on success. However, we should also distinguish between a case we successfully added a controller and a case there wasn't a need to add any controller --- src/conf/domain_conf.c

Re: [libvirt] [PATCH 1/5] qemu: Remove dead code in qemuDomainAssignPCIAddresses revert patch

2015-01-23 Thread Ján Tomko
On 01/21/2015 05:49 PM, Erik Skultety wrote: As it turned out, fix of dead code 419a22 changed the affected condition from never true to always true, so better fix would be to change the return code of virDomainMaybeAddController from 0 to 1 if a new bridge has been added, thus distinguishing

[libvirt] [PATCHv2 2/2] storage: try to perform btrfs clone if possible

2015-01-23 Thread Chen Hanxiao
When creating RAW file, we don't take advantage of clone of btrfs. Try to do a btrfs lightweight copy, or error out. Signed-off-by: Chen Hanxiao chenhanx...@cn.fujitsu.com --- include/libvirt/libvirt-storage.h | 1 + src/storage/storage_backend.c | 43

[libvirt] [PATCHv2 1/2] storage: introduce btrfsCloneFile() for COW copy

2015-01-23 Thread Chen Hanxiao
Signed-off-by: Chen Hanxiao chenhanx...@cn.fujitsu.com --- configure.ac | 12 src/storage/storage_backend.c | 24 2 files changed, 36 insertions(+) diff --git a/configure.ac b/configure.ac index f370475..2498389 100644 --- a/configure.ac +++

Re: [libvirt] [PATCH 2/3] Grant access to helpers

2015-01-23 Thread Cedric Bosdonnat
On Thu, 2015-01-22 at 09:17 -0700, Mike Latimer wrote: On Thursday, January 22, 2015 08:55:07 AM Cedric Bosdonnat wrote: Seems like the apparmor profile for libvirtd is pretty wide open, so I'm not sure if there will be much of a difference between those two settings. I'm also not sure

[libvirt] [PATCHv2 0/2] add support for btrfs COW copy

2015-01-23 Thread Chen Hanxiao
If VIR_STORAGE_VOL_CREATE_REFLINK is specified, try to use btrfs COW copy; v2: check BTRFS_IOC_CLONE in configure.ac error out if COW copy is not supported Chen Hanxiao (2): storage: introduce btrfsCloneFile() for COW copy storage: try to perform btrfs clone if possible configure.ac

Re: [libvirt] [PATCH] aarch64: Support versioned machine types.

2015-01-23 Thread Daniel P. Berrange
On Fri, Jan 23, 2015 at 09:53:13AM -0500, Richard W.M. Jones wrote: From: Richard W.M. Jones rjo...@redhat.com For distros that want to add versioned machine types, they will add (downstream) machine types like virt-foo-1.2.3. Detect these as MMIO too. Not just distros - qemu upstream will

Re: [libvirt] [PATCH] Use correct location for qcow1 encryption header

2015-01-23 Thread Daniel P. Berrange
On Fri, Jan 23, 2015 at 01:35:26PM +0100, Ján Tomko wrote: After the 8-byte size header, there are two one-byte headers and two bytes of padding before the crypt_header field. Our QCOW1_HDR_CRYPT constant did not skip the padding.

[libvirt] [PATCH] aarch64: Support versioned machine types.

2015-01-23 Thread Richard W.M. Jones
From: Richard W.M. Jones rjo...@redhat.com For distros that want to add versioned machine types, they will add (downstream) machine types like virt-foo-1.2.3. Detect these as MMIO too. Signed-off-by: Richard W.M. Jones rjo...@redhat.com --- src/qemu/qemu_command.c | 3 ++- 1 file changed, 2

Re: [libvirt] [PATCH 0/5] Const correctnes/random fixes

2015-01-23 Thread Peter Krempa
On Thu, Jan 22, 2015 at 17:11:04 +0100, Michal Privoznik wrote: On 22.01.2015 11:53, Peter Krempa wrote: Few fixes/tweaks that have accumulated in my memory hotplug branch. They should be trivial enough and semantically inert. ... 8 files changed, 17 insertions(+), 12 deletions(-)

[libvirt] [PATCH] Use correct location for qcow1 encryption header

2015-01-23 Thread Ján Tomko
After the 8-byte size header, there are two one-byte headers and two bytes of padding before the crypt_header field. Our QCOW1_HDR_CRYPT constant did not skip the padding. http://git.qemu.org/?p=qemu.git;a=blob;f=block/qcow.c;h=ece22697#l41 https://bugzilla.redhat.com/show_bug.cgi?id=1185165 ---